Re: [Mesa-dev] [PATCH v2] egl/dri2: Allow modifiers to add FDs to imports

Hi, On 11 August 2017 at 08:39, Philipp Zabel wrote: > Nice, this makes sure that all planes up to the last modifier have fds > present. And since all fds are guaranteed to be present, the modifier > equality check in dri2_check_dma_buf_attribs also makes sure that there

Re: [Mesa-dev] [PATCH v2] egl/dri2: Allow modifiers to add FDs to imports

On Wed, 2017-08-09 at 11:53 +0100, Daniel Stone wrote: > When using dmabuf import, make sure that the modifier is actually > allowed to add planes to the base format, as implied by the comment. > > Signed-off-by: Daniel Stone --- >  src/egl/drivers/dri2/egl_dri2.c | 38

Re: [Mesa-dev] [PATCH v2] egl/dri2: Allow modifiers to add FDs to imports

LGTM, now existence of fd is checked foreach plane_n; Reviewed-by: Tapani Pälli On 08/09/2017 01:53 PM, Daniel Stone wrote: When using dmabuf import, make sure that the modifier is actually allowed to add planes to the base format, as implied by the comment.

[Mesa-dev] [PATCH v2] egl/dri2: Allow modifiers to add FDs to imports

When using dmabuf import, make sure that the modifier is actually allowed to add planes to the base format, as implied by the comment. Signed-off-by: Daniel Stone --- src/egl/drivers/dri2/egl_dri2.c | 38 +++--- 1 file changed, 19