Re: [Mesa-dev] [PATCH v2 03/10] st/mesa: add PROGRAM_BUFFER, stop using gl_register_file

Because I got a ton of errors about how PROGRAM_BUFFER was out of bounds for the enum. I could add them to the enum, of course, but I think that enum was about ARB_vp/fp things? -ilia On Tue, Jan 19, 2016 at 9:23 AM, Brian Paul wrote: > Can you say why you're removing

Re: [Mesa-dev] [PATCH v2 03/10] st/mesa: add PROGRAM_BUFFER, stop using gl_register_file

Can you say why you're removing gl_register_file? Enums are so much nicer when debugging. -Brian On 01/18/2016 07:30 PM, Ilia Mirkin wrote: Signed-off-by: Ilia Mirkin Reviewed-by: Marek Olšák --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 21

Re: [Mesa-dev] [PATCH v2 03/10] st/mesa: add PROGRAM_BUFFER, stop using gl_register_file

On Tue, Jan 19, 2016 at 9:34 AM, Brian Paul wrote: > I don't have any issue with simply adding PROGRAM_BUFFER to the enum type. > prog_src_register::File is a 4-bit field and we currently have 13 enum > values so we're safe there (not sure if that even matters). That's cutting

Re: [Mesa-dev] [PATCH v2 03/10] st/mesa: add PROGRAM_BUFFER, stop using gl_register_file

I don't have any issue with simply adding PROGRAM_BUFFER to the enum type. prog_src_register::File is a 4-bit field and we currently have 13 enum values so we're safe there (not sure if that even matters). I know I've used gdb to debug/trace something in st_glsl_to_tgsi.cpp at least twice

Re: [Mesa-dev] [PATCH v2 03/10] st/mesa: add PROGRAM_BUFFER, stop using gl_register_file

On 01/19/2016 07:37 AM, Ilia Mirkin wrote: On Tue, Jan 19, 2016 at 9:34 AM, Brian Paul wrote: I don't have any issue with simply adding PROGRAM_BUFFER to the enum type. prog_src_register::File is a 4-bit field and we currently have 13 enum values so we're safe there (not

[Mesa-dev] [PATCH v2 03/10] st/mesa: add PROGRAM_BUFFER, stop using gl_register_file

Signed-off-by: Ilia Mirkin Reviewed-by: Marek Olšák --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp