On Sat, 2019-02-16 at 10:25 +1100, Timothy Arceri wrote:
> If the updated piglit tests pass on the Nvidia blob as per my reply to
> those patches and this patch passes on the new and old piglit tests.
> Then this patch is:
As commented in the piglit thread, the nVIDIA blob has many other
Actually you probably want to add this to the commit message also since
it will also be needed if the revert patch gets picked up by stable:
Fixes: 1aa5738e666 ("glsl: relax input->output validation for SSO programs")
On 7/2/19 2:58 am, Andres Gomez wrote:
If there is no Static Use of an
If the updated piglit tests pass on the Nvidia blob as per my reply to
those patches and this patch passes on the new and old piglit tests.
Then this patch is:
Reviewed-by: Timothy Arceri
Thanks for fixing this!
On 7/2/19 2:58 am, Andres Gomez wrote:
If there is no Static Use of an input
https://patchwork.freedesktop.org/series/56400/
On Thu, 2019-02-07 at 07:53 +1100, Timothy Arceri wrote:
> Before reviewing this can we get a piglit test for the following scenario
>
> Two "program" objects say:
>
> 1. vs->gs
> 2. fs
>
> Where the interface between vs and gs has a used input
Before reviewing this can we get a piglit test for the following scenario
Two "program" objects say:
1. vs->gs
2. fs
Where the interface between vs and gs has a used input that doesn't
exist in the vs. The test should fail validation, the idea being the
test would have failed on your v1 of
If there is no Static Use of an input variable, the linker shouldn't
fail whenever there is no defined matching output variable in the
previous stage.
From page 47 (page 51 of the PDF) of the GLSL 4.60 v.5 spec:
" Only the input variables that are statically read need to be
written by the
