Re: [Mesa-dev] [PATCH v3] egl/android: support for EGL_KHR_partial_update

2017-06-06 Thread Eric Engestrom
On Monday, 2017-06-05 19:37:55 +0530, Harish Krupo wrote: > This patch adds support for the EGL_KHR_partial_update extension for > android platform. It passes 36/37 tests in dEQP for EGL_KHR_partial_update. > 1 test not supported. > > v2: add fallback for eglSetDamageRegionKHR (Tapani) > > v3:

Re: [Mesa-dev] [PATCH v3] egl/android: support for EGL_KHR_partial_update

2017-06-06 Thread Emil Velikov
On 6 June 2017 at 14:54, Eric Engestrom wrote: > On Monday, 2017-06-05 17:04:28 +0100, Emil Velikov wrote: >> > + * If the width of the passed rect is greater than the surface's >> > + * width then it is clamped to the width of the surface. Same with >> > + * height. >>

Re: [Mesa-dev] [PATCH v3] egl/android: support for EGL_KHR_partial_update

2017-06-06 Thread Eric Engestrom
On Monday, 2017-06-05 17:04:28 +0100, Emil Velikov wrote: > > + * If the width of the passed rect is greater than the surface's > > + * width then it is clamped to the width of the surface. Same with > > + * height. > > + */ > > + > > +static void > > +_eglSetDamageRegionKHRClampRects(_EGLDisplay*

Re: [Mesa-dev] [PATCH v3] egl/android: support for EGL_KHR_partial_update

2017-06-05 Thread Emil Velikov
Hi Harish, There's a handful of comments, most of which style related nitpicks. Couple that apply through the patch: - rewrap the comments to utilise ~80 columns. - please use consistent variable names - fooBar is not used in src/egl. Splitting the core implementation and Android code into

[Mesa-dev] [PATCH v3] egl/android: support for EGL_KHR_partial_update

2017-06-05 Thread Harish Krupo
This patch adds support for the EGL_KHR_partial_update extension for android platform. It passes 36/37 tests in dEQP for EGL_KHR_partial_update. 1 test not supported. v2: add fallback for eglSetDamageRegionKHR (Tapani) v3: The native_window_set_surface_damage call is available only from