Re: [Mesa-dev] [PATCH v3 1/3] spirv: Fix reaching unreachable for compare exchange on images

2017-07-10 Thread Jason Ekstrand
On Mon, Jul 10, 2017 at 1:46 PM, Andres Gomez wrote: > James, it doesn't seem like this patch has landed in master. Are you in > need of review or is it that this has been superseded? > Sorry. My fault. Reviewed-by: Jason Ekstrand and pushed.

Re: [Mesa-dev] [PATCH v3 1/3] spirv: Fix reaching unreachable for compare exchange on images

2017-07-10 Thread Andres Gomez
James, it doesn't seem like this patch has landed in master. Are you in need of review or is it that this has been superseded? Thanks! On Mon, 2017-06-26 at 10:46 +0100, James Legg wrote: > We were hitting the > unreachable("Invalid image opcode") > near the end of vtn_handle_image when

[Mesa-dev] [PATCH v3 1/3] spirv: Fix reaching unreachable for compare exchange on images

2017-06-26 Thread James Legg
We were hitting the unreachable("Invalid image opcode") near the end of vtn_handle_image when parsing the SpvOpAtomicCompareExchange opcode. v2: Add stable CC. v3: Ignore SpvOpAtomicCompareExchangeWeak. It requires the Kernel capability which is not exposed in Vulkan, and spirv_to_nir is