Re: [Mesa-dev] [PATCH v4 1/7] nir: evaluate if condition uses inside the if branches

2018-08-29 Thread Timothy Arceri
On 30/08/18 12:56, Jason Ekstrand wrote: On Wed, Aug 29, 2018 at 9:45 PM Timothy Arceri > wrote: On 30/08/18 10:57, Ian Romanick wrote: > On 08/27/2018 02:08 AM, Timothy Arceri wrote: >> Since we know what side of the branch we ended up on we can just

Re: [Mesa-dev] [PATCH v4 1/7] nir: evaluate if condition uses inside the if branches

2018-08-29 Thread Jason Ekstrand
On Wed, Aug 29, 2018 at 9:45 PM Timothy Arceri wrote: > On 30/08/18 10:57, Ian Romanick wrote: > > On 08/27/2018 02:08 AM, Timothy Arceri wrote: > >> Since we know what side of the branch we ended up on we can just > >> replace the use with a constant. > >> > >> All the spill changes in

Re: [Mesa-dev] [PATCH v4 1/7] nir: evaluate if condition uses inside the if branches

2018-08-29 Thread Timothy Arceri
On 30/08/18 10:57, Ian Romanick wrote: On 08/27/2018 02:08 AM, Timothy Arceri wrote: Since we know what side of the branch we ended up on we can just replace the use with a constant. All the spill changes in shader-db are from Dolphin uber shaders, despite some small regressions the change is

Re: [Mesa-dev] [PATCH v4 1/7] nir: evaluate if condition uses inside the if branches

2018-08-29 Thread Jason Ekstrand
On Wed, Aug 29, 2018 at 7:58 PM Ian Romanick wrote: > On 08/27/2018 02:08 AM, Timothy Arceri wrote: > > Since we know what side of the branch we ended up on we can just > > replace the use with a constant. > > > > All the spill changes in shader-db are from Dolphin uber shaders, > > despite some

Re: [Mesa-dev] [PATCH v4 1/7] nir: evaluate if condition uses inside the if branches

2018-08-29 Thread Ian Romanick
On 08/27/2018 02:08 AM, Timothy Arceri wrote: > Since we know what side of the branch we ended up on we can just > replace the use with a constant. > > All the spill changes in shader-db are from Dolphin uber shaders, > despite some small regressions the change is clearly positive. > > V2:

Re: [Mesa-dev] [PATCH v4 1/7] nir: evaluate if condition uses inside the if branches

2018-08-28 Thread Jason Ekstrand
On Mon, Aug 27, 2018 at 4:09 AM Timothy Arceri wrote: > Since we know what side of the branch we ended up on we can just > replace the use with a constant. > > All the spill changes in shader-db are from Dolphin uber shaders, > despite some small regressions the change is clearly positive. > >

[Mesa-dev] [PATCH v4 1/7] nir: evaluate if condition uses inside the if branches

2018-08-27 Thread Timothy Arceri
Since we know what side of the branch we ended up on we can just replace the use with a constant. All the spill changes in shader-db are from Dolphin uber shaders, despite some small regressions the change is clearly positive. V2: insert new constant after any phis in the