Re: [Mesa-dev] [PATCH v4 27/40] intel/compiler: generalize the combine constants pass

2019-02-18 Thread Iago Toral
On Sat, 2019-02-16 at 09:29 -0600, Jason Ekstrand wrote: > On Tue, Feb 12, 2019 at 5:57 AM Iago Toral Quiroga > wrote: > > At the very least we need it to handle HF too, since we are doing > > > > constant propagation for MAD and LRP, which relies on this pass > > > > to promote the immediates

Re: [Mesa-dev] [PATCH v4 27/40] intel/compiler: generalize the combine constants pass

2019-02-16 Thread Jason Ekstrand
On Tue, Feb 12, 2019 at 5:57 AM Iago Toral Quiroga wrote: > At the very least we need it to handle HF too, since we are doing > constant propagation for MAD and LRP, which relies on this pass > to promote the immediates to GRF in the end, but ideally > we want it to support even more types so we

[Mesa-dev] [PATCH v4 27/40] intel/compiler: generalize the combine constants pass

2019-02-12 Thread Iago Toral Quiroga
At the very least we need it to handle HF too, since we are doing constant propagation for MAD and LRP, which relies on this pass to promote the immediates to GRF in the end, but ideally we want it to support even more types so we can take advantage of it to improve register pressure in some