Re: [Mesa-dev] [PATCH] glsl: handle error case with ast_post_inc, ast_post_dec

2018-08-09 Thread Tapani Pälli
On 08/09/2018 03:24 PM, Andres Gomez wrote: Tapani, should we also include this in the stable queues ? I was not sure if this is 'critical enough' for stable, but yes I'm OK including it there! Thanks; On Tue, 2018-08-07 at 08:20 +0300, Tapani Pälli wrote: Return ir_rvalue::error_value

Re: [Mesa-dev] [PATCH] glsl: handle error case with ast_post_inc, ast_post_dec

2018-08-09 Thread Andres Gomez
Tapani, should we also include this in the stable queues ? On Tue, 2018-08-07 at 08:20 +0300, Tapani Pälli wrote: > Return ir_rvalue::error_value with ast_post_inc, ast_post_dec if > parser error was emitted previously. This way process_array_size > won't see bogus IR generated like with commit

Re: [Mesa-dev] [PATCH] glsl: handle error case with ast_post_inc, ast_post_dec

2018-08-07 Thread Iago Toral
Reviewed-by: Iago Toral Quiroga On Tue, 2018-08-07 at 08:20 +0300, Tapani Pälli wrote: > Return ir_rvalue::error_value with ast_post_inc, ast_post_dec if > parser error was emitted previously. This way process_array_size > won't see bogus IR generated like with commit 9c676a64273. > >