Re: [EXTERNAL] Re: Zink MR signoff tags

2022-10-20 Thread Yonggang Luo
For simple MR without rb/ab is good, but for large MR, part of them are reviewed, and part of are not. I would suggest for large MR, the reviewed commits's title can styled with for example: ``` xlib(ab): Some change acked of xlib ``` ``` xlib(rb): Some change reviewed of xlib ``` For changes

Re: [EXTERNAL] Re: Zink MR signoff tags

2022-10-20 Thread Adam Jackson
t; > > -Original Message- > > > From: mesa-dev On Behalf Of > Gert Wollny > > > Sent: Friday, October 7, 2022 2:37 AM > > > To: erik.faye-lund ; Alyssa Rosenzweig < > aly...@collabora.com>; Mike Blumenkrantz > > > Cc: ML mesa-dev >

Re: [EXTERNAL] Re: Zink MR signoff tags

2022-10-18 Thread Karol Herbst
; Alyssa Rosenzweig > > ; Mike Blumenkrantz > > Cc: ML mesa-dev > > Subject: [EXTERNAL] Re: Zink MR signoff tags > > > > On Wed, 2022-10-05 at 17:21 +0200, Erik Faye-Lund wrote: > > > On Wed, 2022-10-05 at 08:20 -0400, Alyssa Rosenzweig wrote: > > > &g

Re: [EXTERNAL] Re: Zink MR signoff tags

2022-10-18 Thread Karol Herbst
Of Gert > Wollny > Sent: Friday, October 7, 2022 2:37 AM > To: erik.faye-lund ; Alyssa Rosenzweig > ; Mike Blumenkrantz > Cc: ML mesa-dev > Subject: [EXTERNAL] Re: Zink MR signoff tags > > On Wed, 2022-10-05 at 17:21 +0200, Erik Faye-Lund wrote: > > On W

RE: [EXTERNAL] Re: Zink MR signoff tags

2022-10-17 Thread Jesse Natalie
Cc: ML mesa-dev Subject: [EXTERNAL] Re: Zink MR signoff tags On Wed, 2022-10-05 at 17:21 +0200, Erik Faye-Lund wrote: > On Wed, 2022-10-05 at 08:20 -0400, Alyssa Rosenzweig wrote: > > + for not requiring rb/ab tags ... > > I think it's time to think about making this chang

Re: Zink MR signoff tags

2022-10-07 Thread Gert Wollny
On Wed, 2022-10-05 at 17:21 +0200, Erik Faye-Lund wrote: > On Wed, 2022-10-05 at 08:20 -0400, Alyssa Rosenzweig wrote: > > + for not requiring rb/ab tags ... > > I think it's time to think about making this change all over Mesa as > well. We're deeply in bed with GitLab by now, so I don't think >

Re: Zink MR signoff tags

2022-10-05 Thread Marek Olšák
That's a good idea. Marek On Wed, Oct 5, 2022, 11:22 Erik Faye-Lund wrote: > On Wed, 2022-10-05 at 08:20 -0400, Alyssa Rosenzweig wrote: > > + for not requiring rb/ab tags ... > > I think it's time to think about making this change all over Mesa as > well. We're deeply in bed with GitLab by

Re: Zink MR signoff tags

2022-10-05 Thread Alyssa Rosenzweig
> > + for not requiring rb/ab tags ... > > I think it's time to think about making this change all over Mesa as > well. We're deeply in bed with GitLab by now, so I don't think there's > a realistic chance that this isn't going to just be duplicate info any > time soon... I agree, but I don't

Re: Zink MR signoff tags

2022-10-05 Thread Erik Faye-Lund
On Wed, 2022-10-05 at 08:20 -0400, Alyssa Rosenzweig wrote: > + for not requiring rb/ab tags ... I think it's time to think about making this change all over Mesa as well. We're deeply in bed with GitLab by now, so I don't think there's a realistic chance that this isn't going to just be

Re: Zink MR signoff tags

2022-10-05 Thread Alyssa Rosenzweig
+ for not requiring rb/ab tags ... I kinda like the s-o-b tags but those don't require fiddly rebases, just -s in the right place.. On Tue, Oct 04, 2022 at 10:44:31PM -0500, Mike Blumenkrantz wrote: >Hi, >After some vigorous and robust discussion with Erik, we've decided that >zink

Zink MR signoff tags

2022-10-04 Thread Mike Blumenkrantz
Hi, After some vigorous and robust discussion with Erik, we've decided that zink will no longer require any rb/ab/etb tags to be applied to patches in MRs. Following in Turnip's footsteps, any MR that receives sufficient reviewage in gitlab comments can be merged directly with no further action