[Mesa-dev] [PATCH] Add a draw-pixel-with-texture testcase

2011-11-21 Thread Yuanhan Liu
Add a draw-pixel-with-texture testcase to check if texture sampling is happened while drawing pixels by glDrawPixels. v2: use piglit_probe_rect_rgba instead of just sampling a set of pixels(comments from Eric) Signed-off-by: Yuanhan Liu yuanhan@linux.intel.com --- tests/all.tests

Re: [Mesa-dev] [PATCH] gallium: separate out floating-point CAPs into its own enum

2011-11-21 Thread Jose Fonseca
I think that PIPE_CAP_FLOAT_XXX is too long and that the non-abbreviated _FLOAT_ word is distracting and misleading, as it sounds like it's related with floating point features, which is not. Something more subtle, such as PIPE_CAPF_XXX, would be OK though. It's consistent with get_param and

[Mesa-dev] mesademos build system: would one be enough?

2011-11-21 Thread Jose Fonseca
Johannes Obermayr's recent patch series remind me of one thing I've been planning to ask here for quite some time: Would anybody oppose dropping automake build system in mesademos for just cmake ? On Mesa there is rationale behind the two different build systems (automake and scons), but for

Re: [Mesa-dev] [PATCH 3/3] mesa: handle MapRenderbuffer() failures in glReadPixels

2011-11-21 Thread Jose Fonseca
Looks good to me. Jose - Original Message - --- src/mesa/main/readpix.c | 45 + 1 files changed, 45 insertions(+), 0 deletions(-) diff --git a/src/mesa/main/readpix.c b/src/mesa/main/readpix.c index aa893de..8048a72 100644 ---

Re: [Mesa-dev] mesademos build system: would one be enough?

2011-11-21 Thread Dave Airlie
On Mon, Nov 21, 2011 at 11:17 AM, Jose Fonseca jfons...@vmware.com wrote: Johannes Obermayr's recent patch series remind me of one thing I've been planning to ask here for quite some time: Would anybody oppose dropping automake build system in mesademos for just cmake ? On Mesa there is

Re: [Mesa-dev] mesademos build system: would one be enough?

2011-11-21 Thread Jose Fonseca
- Original Message - On Mon, Nov 21, 2011 at 11:17 AM, Jose Fonseca jfons...@vmware.com wrote: Johannes Obermayr's recent patch series remind me of one thing I've been planning to ask here for quite some time: Would anybody oppose dropping automake build system in mesademos

Re: [Mesa-dev] [PATCH] gallium: separate out floating-point CAPs into its own enum

2011-11-21 Thread Marek Olšák
On Mon, Nov 21, 2011 at 9:53 AM, Jose Fonseca jfons...@vmware.com wrote: I think that PIPE_CAP_FLOAT_XXX is too long and that the non-abbreviated _FLOAT_ word is distracting and misleading, as it sounds like it's related with floating point features, which is not.  Something more subtle, such

[Mesa-dev] [Bug 43138] New: [glsl] fail to get the active attribute with function glGetProgramiv

2011-11-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=43138 Bug #: 43138 Summary: [glsl] fail to get the active attribute with function glGetProgramiv Classification: Unclassified Product: Mesa Version: 7.11 Platform: Other

[Mesa-dev] [Bug 43138] [glsl] fail to get the active attribute with function glGetProgramiv

2011-11-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=43138 --- Comment #1 from sunyi yi@intel.com 2011-11-21 06:44:48 PST --- Created attachment 53740 -- https://bugs.freedesktop.org/attachment.cgi?id=53740 Piglit case to test retrieving the number of active attribute. -- Configure bugmail:

Re: [Mesa-dev] [PATCH 1/2] mesa: remove buggy assertions in unpack Z24

2011-11-21 Thread Brian Paul
On 11/20/2011 07:08 AM, Marek Olšák wrote: unpack_float_z_Z24_X8 fails with -O2 in: - fbo-blit-d24s8 - fbo-depth-sample-compare - fbo-readpixels-depth-formats - glean/depthStencil With -O0, it works fine. I am removing all the assertions. There's not much point in having them, is there? ---

[Mesa-dev] [Bug 41999] GL_OES_mapbuffer is advertised but calling glMapBufferOES throws a warning

2011-11-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=41999 --- Comment #2 from Neil Roberts n...@linux.intel.com 2011-11-21 07:40:50 PST --- Created attachment 53741 -- https://bugs.freedesktop.org/attachment.cgi?id=53741 Standalone test case I still have the issue but actually the situation is more

[Mesa-dev] [Bug 41999] eglGetProcAddress(glMapBufferOES) doesn't work if the app links against both -lGL and -lGLESv2

2011-11-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=41999 Neil Roberts n...@linux.intel.com changed: What|Removed |Added Summary|GL_OES_mapbuffer is

Re: [Mesa-dev] reworking pipe_video_decoder / pipe_video_buffer

2011-11-21 Thread Christian König
On 16.11.2011 15:38, Maarten Lankhorst wrote: Hey, On 11/16/2011 02:47 PM, Christian König wrote: On 15.11.2011 17:52, Maarten Lankhorst wrote: Deleted: - begin_frame/end_frame: Was only useful for XvMC, should be folded into flush.. I'm not completely happy with the current interface also,

[Mesa-dev] [Bug 43143] Mesa 7.11.1 fails to build at main/dlist.c:4532 with error message: format not a string literal and no format arguments

2011-11-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=43143 --- Comment #1 from Henri Verbeet hverb...@gmail.com 2011-11-21 09:01:22 PST --- We should cherry pick 5485192, I guess. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because:

[Mesa-dev] [Bug 43122] piglit: spec/ARB_depth_buffer_float/fbo-depth-GL_DEPTH_COMPONENT32F-{blit, {read, draw, copy}pixels}

2011-11-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=43122 --- Comment #2 from Kai deb...@carbon-project.org 2011-11-21 10:09:01 PST --- Created attachment 53744 -- https://bugs.freedesktop.org/attachment.cgi?id=53744 Bisection run for this bug As this is a regression, I did a git bisect, but

Re: [Mesa-dev] [PATCH 1/2] mesa: remove buggy assertions in unpack Z24

2011-11-21 Thread Eric Anholt
On Sun, 20 Nov 2011 15:08:55 +0100, Marek Olšák mar...@gmail.com wrote: unpack_float_z_Z24_X8 fails with -O2 in: - fbo-blit-d24s8 - fbo-depth-sample-compare - fbo-readpixels-depth-formats - glean/depthStencil With -O0, it works fine. I am removing all the assertions. There's not much

Re: [Mesa-dev] mesademos build system: would one be enough?

2011-11-21 Thread Eric Anholt
On Mon, 21 Nov 2011 03:17:03 -0800 (PST), Jose Fonseca jfons...@vmware.com wrote: Johannes Obermayr's recent patch series remind me of one thing I've been planning to ask here for quite some time: Would anybody oppose dropping automake build system in mesademos for just cmake ? cmake is

[Mesa-dev] [Bug 43122] piglit: spec/ARB_depth_buffer_float/fbo-depth-GL_DEPTH_COMPONENT32F-{blit, {read, draw, copy}pixels}

2011-11-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=43122 Kai deb...@carbon-project.org changed: What|Removed |Added CC||bri...@vmware.com ---

[Mesa-dev] [Bug 43122] piglit: spec/ARB_depth_buffer_float/fbo-depth-GL_DEPTH_COMPONENT32F-{blit, {read, draw, copy}pixels}

2011-11-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=43122 --- Comment #4 from Brian Paul bri...@vmware.com 2011-11-21 10:41:41 PST --- When you're bisecting and get the undefined reference to `_swrast_ReadPixels' error, just temporarily change the offending call to be _mesa_readpixels instead. That

Re: [Mesa-dev] mesademos build system: would one be enough?

2011-11-21 Thread Brian Paul
On 11/21/2011 05:07 AM, Jose Fonseca wrote: - Original Message - On Mon, Nov 21, 2011 at 11:17 AM, Jose Fonsecajfons...@vmware.com wrote: Johannes Obermayr's recent patch series remind me of one thing I've been planning to ask here for quite some time: Would anybody oppose dropping

Re: [Mesa-dev] [PATCH 2/2] st/mesa: quick fix of CopyPixels with GL_DEPTH_STENCIL

2011-11-21 Thread Brian Paul
On 11/20/2011 07:08 AM, Marek Olšák wrote: This fixes: - depthstencil-default_fb-copypixels - fbo-depthstencil-GL_DEPTH24_STENCIL8-copypixels --- src/mesa/state_tracker/st_cb_drawpixels.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 4/6] gallium: remove PIPE_CAP_GLSL and enable GLSL unconditionally

2011-11-21 Thread Brian Paul
I probably haven't built/tested the Cell driver in nearly a year and nobody's reported any bugs or submitted patches for it so I think it's effectively dead. -Brian On 11/19/2011 10:50 AM, Marek Olšák wrote: Well, there are three drivers which are pretty much dead: - cell - failover

Re: [Mesa-dev] mesademos build system: would one be enough?

2011-11-21 Thread Ian Romanick
On 11/21/2011 09:40 AM, Eric Anholt wrote: On Mon, 21 Nov 2011 03:17:03 -0800 (PST), Jose Fonsecajfons...@vmware.com wrote: Johannes Obermayr's recent patch series remind me of one thing I've been planning to ask here for quite some time: Would anybody oppose dropping automake build system

Re: [Mesa-dev] [PATCH] glsl: disable resource checking in the linker until it's done right

2011-11-21 Thread Ian Romanick
NAK with extreme prejudice. Technically speaking, these are app bugs. I absolutely will not disable all correct behavior to work around broken apps. The problem is the following shaders will correctly link, but completely explode: uniform float array[1234]; uniform int i; void main() {

Re: [Mesa-dev] [PATCH 1/6] glsl: finish up ARB_conservative_depth

2011-11-21 Thread Ian Romanick
On 11/19/2011 07:42 AM, Marek Olšák wrote: On Fri, Nov 18, 2011 at 9:44 PM, Ian Romanicki...@freedesktop.org wrote: On 11/18/2011 11:27 AM, Marek Olšák wrote: This patch also needs to change the _mesa_glsl_supported_extensions table in glsl_parser_extras.cpp. AMD_conservative_depth is used

[Mesa-dev] [Bug 43143] Mesa 7.11.1 fails to build at main/dlist.c:4532 with error message: format not a string literal and no format arguments

2011-11-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=43143 --- Comment #3 from Henri Verbeet hverb...@gmail.com 2011-11-21 11:08:10 PST --- Sure, pushed. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee

Re: [Mesa-dev] [PATCH] intel: Replace intel_renderbuffer::region with a miptree [v2]

2011-11-21 Thread Chad Versace
On 11/18/2011 05:03 PM, Eric Anholt wrote: On Fri, 18 Nov 2011 12:50:36 -0800, Chad Versace chad.vers...@linux.intel.com wrote: Essentially, this patch just globally substitutes `irb-region` with `irb-mt-region` and then does some minor cleanups to avoid segfaults and other problems. This

Re: [Mesa-dev] mesademos build system: would one be enough?

2011-11-21 Thread Kenneth Graunke
On 11/21/2011 09:40 AM, Eric Anholt wrote: On Mon, 21 Nov 2011 03:17:03 -0800 (PST), Jose Fonseca jfons...@vmware.com wrote: Johannes Obermayr's recent patch series remind me of one thing I've been planning to ask here for quite some time: Would anybody oppose dropping automake build system

[Mesa-dev] [PATCH] i965/gen6: Manipulate state batches for HiZ meta-ops [v2]

2011-11-21 Thread Chad Versace
A lot of the state manipulation is handled by the meta-op state setup. However, some batches need manual intervention. v2: [anholt] Do not special-case the 3DSTATE_DEPTH_STENCIL.Depth_Test_Enable bit for HiZ in gen6_upload_depth_stencil(). The HiZ meta-op sets ctx-Depth.Test, so just

Re: [Mesa-dev] [PATCH 28/41] i965: Resolve buffers before drawing

2011-11-21 Thread Chad Versace
On 11/18/2011 04:37 PM, Eric Anholt wrote: On Thu, 17 Nov 2011 19:58:55 -0800, Chad Versace chad.vers...@linux.intel.com wrote: Before emitting primitives in brw_try_draw_prims(), resolve the depth buffer's HiZ buffer and resolve the depth buffer of each enabled depth texture.

[Mesa-dev] [Bug 43125] [bisected] Start screen in Amnesia too dark after Rewrite the way uniforms are tracked and handled commit

2011-11-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=43125 --- Comment #3 from Ian Romanick i...@freedesktop.org 2011-11-21 11:49:17 PST --- Does the application generate any errors in a log? Does running a debug build of Mesa cause any Mesa warnings to be logged? -- Configure bugmail:

[Mesa-dev] [PATCH] linker: Remove erroneous multiply by 4 in uniform usage calculation

2011-11-21 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com The old count_uniform_size::num_shader_uniforms was actually calculating the number of components used. Multiplying by 4 when setting gl_shader::num_uniform_components caused us to count 4x as many uniform components as were actually used.

[Mesa-dev] [Bug 42930] [r300g, bisected] EVE online only shows black screen

2011-11-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=42930 --- Comment #10 from Ian Romanick i...@freedesktop.org 2011-11-21 11:54:03 PST --- I just posted a patch to the mesa-dev mailing list that may fix this issue: http://lists.freedesktop.org/archives/mesa-dev/2011-November/014913.html --

[Mesa-dev] [Bug 43125] [bisected] Start screen in Amnesia too dark after Rewrite the way uniforms are tracked and handled commit

2011-11-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=43125 --- Comment #4 from Ian Romanick i...@freedesktop.org 2011-11-21 11:55:07 PST --- I just posted a patch to the mesa-dev mailing list that may fix this issue: http://lists.freedesktop.org/archives/mesa-dev/2011-November/014913.html --

Re: [Mesa-dev] [PATCH] intel: Replace intel_renderbuffer::region with a miptree [v2]

2011-11-21 Thread Chad Versace
On 11/21/2011 11:27 AM, Chad Versace wrote: On 11/18/2011 05:03 PM, Eric Anholt wrote: On Fri, 18 Nov 2011 12:50:36 -0800, Chad Versace chad.vers...@linux.intel.com wrote: Essentially, this patch just globally substitutes `irb-region` with `irb-mt-region` and then does some minor cleanups to

Re: [Mesa-dev] mesademos build system: would one be enough?

2011-11-21 Thread Jose Fonseca
- Original Message - On 11/21/2011 09:40 AM, Eric Anholt wrote: On Mon, 21 Nov 2011 03:17:03 -0800 (PST), Jose Fonseca jfons...@vmware.com wrote: Johannes Obermayr's recent patch series remind me of one thing I've been planning to ask here for quite some time: Would

Re: [Mesa-dev] mesademos build system: would one be enough?

2011-11-21 Thread Jose Fonseca
- Original Message - On Mon, 21 Nov 2011 03:17:03 -0800 (PST), Jose Fonseca jfons...@vmware.com wrote: Johannes Obermayr's recent patch series remind me of one thing I've been planning to ask here for quite some time: Would anybody oppose dropping automake build system in

[Mesa-dev] [Bug 43122] piglit: spec/ARB_depth_buffer_float/fbo-depth-GL_DEPTH_COMPONENT32F-{blit, {read, draw, copy}pixels}

2011-11-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=43122 Kai deb...@carbon-project.org changed: What|Removed |Added Attachment #53744|0 |1 is obsolete|

[Mesa-dev] [PATCH] st/mesa: fix accum buffer allocation in st_renderbuffer_alloc_storage()

2011-11-21 Thread Brian Paul
If the gallium driver doesn't support PIPE_FORMAT_R16G16B16A16_SNORM the call to st_choose_renderbuffer_format() would fail and we'd generate an GL_OUT_OF_MEMORY error. We'd never get to the subsequent code that handles software/malloc-based renderbuffers. Add a special-case check for

[Mesa-dev] [Bug 43122] piglit: spec/ARB_depth_buffer_float/fbo-depth-GL_DEPTH_COMPONENT32F-{blit, {read, draw, copy}pixels}

2011-11-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=43122 --- Comment #6 from Brian Paul bri...@vmware.com 2011-11-21 13:13:16 PST --- I can't test the r600g driver so hopefully someone else can take a look at this. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You

Re: [Mesa-dev] [PATCH] linker: Remove erroneous multiply by 4 in uniform usage calculation

2011-11-21 Thread Eric Anholt
On Mon, 21 Nov 2011 11:51:13 -0800, Ian Romanick i...@freedesktop.org wrote: From: Ian Romanick ian.d.roman...@intel.com The old count_uniform_size::num_shader_uniforms was actually calculating the number of components used. Multiplying by 4 when setting gl_shader::num_uniform_components

[Mesa-dev] Various Patches

2011-11-21 Thread Vincent Lejeune
Hi, these are previous patches I reformatted to fix my git user name. Regards, Vincent ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 1/3] mesa : move bindbuffer{base, range} from transformfeedback.c

2011-11-21 Thread Vincent Lejeune
BindBuffer* functions are part of tfb extension. They are however used by others extensions such as uniform buffer object. This patch moves the BindBuffer* definition to to bufferobj.c where it acts as a dispatcher calling original tfb function ; BindBuffer* functions can be used by

[Mesa-dev] [PATCH 2/3] gallium: rework some utilities functions to support 2d indexing

2011-11-21 Thread Vincent Lejeune
This patch adds a 2d ureg_src constructor, and add a field in st_src_reg inside glsl_to_tgsi that hold potential 2d index. 2d indexing is required at least for uniform buffer object support --- src/gallium/auxiliary/tgsi/tgsi_ureg.h | 12

[Mesa-dev] [PATCH 3/3] gallium: fix function description

2011-11-21 Thread Vincent Lejeune
ureg_DECL_constant2D does not return anything. --- src/gallium/auxiliary/tgsi/tgsi_ureg.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_ureg.c b/src/gallium/auxiliary/tgsi/tgsi_ureg.c index cada435..5d8dbba 100644 ---

[Mesa-dev] [Bug 42930] [r300g, bisected] EVE online only shows black screen

2011-11-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=42930 --- Comment #11 from Pavel Ondračka pavel.ondra...@email.cz 2011-11-21 14:02:14 PST --- (In reply to comment #10) I just posted a patch to the mesa-dev mailing list that may fix this issue:

[Mesa-dev] [PATCH] i965/gen6: Manipulate state batches for HiZ meta-ops [v3]

2011-11-21 Thread Chad Versace
Eric, is this v3 change what you had in mind? - A lot of the state manipulation is handled by the meta-op state setup. However, some batches need manual intervention. v2: Do not special-case the 3DSTATE_DEPTH_STENCIL.Depth_Test_Enable bit for HiZ in gen6_upload_depth_stencil(). The

Re: [Mesa-dev] [PATCH 27/41] i965: Prevent recursive calls to FLUSH_VERTICES

2011-11-21 Thread Chad Versace
On 11/18/2011 05:19 PM, Eric Anholt wrote: On Thu, 17 Nov 2011 19:58:54 -0800, Chad Versace chad.vers...@linux.intel.com wrote: To do so, we must resolve all buffers on entering a glBegin/glEnd block. For the detailed explanation, see the Doxygen comments in this patch. Signed-off-by: Chad

[Mesa-dev] [PATCH] i965: Prevent recursive calls to FLUSH_VERTICES [v2]

2011-11-21 Thread Chad Versace
To do so, we must resolve all buffers on entering a glBegin/glEnd block. For the detailed explanation, see the Doxygen comments in this patch. v2ju: - Fix typo: s/enusure/ensure/. - In brwPrepareExecBegin(), do the same resolves as done by brw_predraw_resolve_buffers(). CC: Eric

Re: [Mesa-dev] [PATCH 35/41] intel: Enable HiZ for texture renderbuffers

2011-11-21 Thread Chad Versace
On 11/18/2011 05:36 PM, Eric Anholt wrote: On Thu, 17 Nov 2011 19:59:02 -0800, Chad Versace chad.vers...@linux.intel.com wrote: When a depth texture is first attached to framebuffer, allocate a HiZ miptree for it. Signed-off-by: Chad Versace chad.vers...@linux.intel.com ---

[Mesa-dev] [Bug 43125] [bisected] Start screen in Amnesia too dark after Rewrite the way uniforms are tracked and handled commit

2011-11-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=43125 --- Comment #5 from Jure Repinc jlp.b...@gmail.com 2011-11-21 14:26:54 PST --- IF I did everything right applying this patch, then it unfortunately doesn't appear to help. I get this output when I run the game: $ libGL: Can't open configuration

Re: [Mesa-dev] [PATCH 37/41] i965: Set vertical alignment in SURFACE_STATE batch

2011-11-21 Thread Chad Versace
On 11/18/2011 05:43 PM, Eric Anholt wrote: On Thu, 17 Nov 2011 19:59:04 -0800, Chad Versace chad.vers...@linux.intel.com wrote: Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- src/mesa/drivers/dri/i965/brw_defines.h |9 +

Re: [Mesa-dev] [PATCH 41/41] i965: Document where Piglit test glean/fbo breaks due to HiZ

2011-11-21 Thread Chad Versace
On 11/18/2011 05:55 PM, Eric Anholt wrote: On Thu, 17 Nov 2011 19:59:08 -0800, Chad Versace chad.vers...@linux.intel.com wrote: I found the line of code that breaks the test, but don't know how to easily fix it. Signed-off-by: Chad Versace chad.vers...@linux.intel.com ---

[Mesa-dev] [PATCH] Allow glTexImage2D with a depth component cube map

2011-11-21 Thread anuj . phogat
From: Anuj Phogat anuj.pho...@gmail.com Thanks for the review comments. Here is the updated patch to allow depth component cube maps in GL 3.0. I'll post the piglit testcase for this patch in a separate e-mail. Anuj Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- src/mesa/main/teximage.c

Re: [Mesa-dev] [PATCH] Allow glTexImage2D with a depth component cube map

2011-11-21 Thread Brian Paul
On 11/21/2011 03:45 PM, anuj.pho...@gmail.com wrote: From: Anuj Phogatanuj.pho...@gmail.com Thanks for the review comments. Here is the updated patch to allow depth component cube maps in GL 3.0. I'll post the piglit testcase for this patch in a separate e-mail. Anuj Signed-off-by: Anuj

Re: [Mesa-dev] [PATCH 1/3] mesa : move bindbuffer{base, range} from transformfeedback.c

2011-11-21 Thread Ian Romanick
On 11/21/2011 02:01 PM, Vincent Lejeune wrote: BindBuffer* functions are part of tfb extension. They are however used by others extensions such as uniform buffer object. This patch moves the BindBuffer* definition to to bufferobj.c where it acts as a dispatcher calling original

Re: [Mesa-dev] [PATCH] linker: Remove erroneous multiply by 4 in uniform usage calculation

2011-11-21 Thread Ian Romanick
On 11/21/2011 01:27 PM, Eric Anholt wrote: On Mon, 21 Nov 2011 11:51:13 -0800, Ian Romanicki...@freedesktop.org wrote: From: Ian Romanickian.d.roman...@intel.com The old count_uniform_size::num_shader_uniforms was actually calculating the number of components used. Multiplying by 4 when

[Mesa-dev] [PATCH] i965: Implement the actual tables for texture alignment units [v2]

2011-11-21 Thread Chad Versace
From: Kenneth Graunke kenn...@whitecape.org I implemented functions for horizontal/vertical alignment units separately because I find it easier to read that way...especially with all the corner-cases. [chad] Corrected the vertical alignment calculation by checking for depthstencil formats. v2:

Re: [Mesa-dev] [PATCH] linker: Remove erroneous multiply by 4 in uniform usage calculation

2011-11-21 Thread Marek Olšák
Thanks for looking into this, Ian. Acked-by: Marek Olšák mar...@gmail.com On Mon, Nov 21, 2011 at 8:51 PM, Ian Romanick i...@freedesktop.org wrote: From: Ian Romanick ian.d.roman...@intel.com The old count_uniform_size::num_shader_uniforms was actually calculating the number of components

Re: [Mesa-dev] [PATCH] i965/gen6: Manipulate state batches for HiZ meta-ops [v3]

2011-11-21 Thread Eric Anholt
On Mon, 21 Nov 2011 14:02:40 -0800, Chad Versace chad.vers...@linux.intel.com wrote: Eric, is this v3 change what you had in mind? - A lot of the state manipulation is handled by the meta-op state setup. However, some batches need manual intervention. v2: Do not special-case

Re: [Mesa-dev] [PATCH] i965: Implement the actual tables for texture alignment units [v2]

2011-11-21 Thread Eric Anholt
On Mon, 21 Nov 2011 15:53:09 -0800, Chad Versace chad.vers...@linux.intel.com wrote: From: Kenneth Graunke kenn...@whitecape.org I implemented functions for horizontal/vertical alignment units separately because I find it easier to read that way...especially with all the corner-cases.

[Mesa-dev] [PULL] chadversary 7.11-proposed

2011-11-21 Thread Chad Versace
Here are some fixes for stencil buffers on gen7. Patch 3 fixes a critical bug in the builtin DRI2 backend; without the fix, an app crashes if it requests a window system stencil buffer. The following changes since commit 658d994473dcfbff140e43178253bbcf438af797: mesa: use format string in

Re: [Mesa-dev] [PATCH 1/3] mesa: rename the AMD_conservative_depth extension flag to ARB

2011-11-21 Thread Ian Romanick
On 11/19/2011 09:54 AM, Marek Olšák wrote: The series is Reviewed-by: Ian Romanick ian.d.roman...@intel.com --- src/glsl/glcpp/glcpp-parse.y|2 +- src/glsl/glsl_parser_extras.cpp |4 ++-- src/mesa/main/extensions.c |4 ++-- src/mesa/main/mtypes.h |2 +-

[Mesa-dev] [Bug 43138] [glsl] fail to get the active attribute with function glGetProgramiv

2011-11-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=43138 --- Comment #2 from Gordon Jin gordon@intel.com 2011-11-21 17:22:10 UTC --- It looks like the built-in attribute gl_vertex not counted by GL_ACTIVE_ATTRIBUTES, similar to bug#32403. This one is for attribute, and that one is for uniform. --

[Mesa-dev] [Bug 43138] [glsl] fail to get the active attribute with function glGetProgramiv

2011-11-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=43138 --- Comment #3 from Ian Romanick i...@freedesktop.org 2011-11-21 17:37:30 UTC --- This problem only exists in 7.11,correct? This should have been fixed on master by a fairly long (12 patches) and intrusive patch sequence that ended at commit

[Mesa-dev] [Bug 43138] [glsl] fail to get the active attribute with function glGetProgramiv

2011-11-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=43138 sunyi yi@intel.com changed: What|Removed |Added Version|7.11|git --- Comment #4 from sunyi

Re: [Mesa-dev] [PATCH] linker: Remove erroneous multiply by 4 in uniform usage calculation

2011-11-21 Thread Kenneth Graunke
On 11/21/2011 11:51 AM, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com The old count_uniform_size::num_shader_uniforms was actually calculating the number of components used. Multiplying by 4 when setting gl_shader::num_uniform_components caused us to count 4x as many