[Mesa-dev] [PATCH 1/2] st/xlib: Fix XImage bytes-per-pixel calculation

2013-06-14 Thread Richard Sandiford
Fixes a crash seen while running gnome on a 16-bit screen over vnc. Signed-off-by: Richard Sandiford rsand...@linux.vnet.ibm.com --- src/gallium/state_trackers/glx/xlib/xm_api.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/gallium/state_trackers/glx/xlib/xm_api.c

[Mesa-dev] [PATCH 2/2] st/xlib: Fix XImage stride calculation

2013-06-14 Thread Richard Sandiford
Fixes window skew seen while running gnome on a 16-bit screen over vnc. Signed-off-by: Richard Sandiford rsand...@linux.vnet.ibm.com --- src/gallium/state_trackers/glx/xlib/xm_api.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 7/8] util: Expand the comment above the channel[] array

2013-06-14 Thread Richard Sandiford
Will Schmidt will_schm...@vnet.ibm.com writes: On Thu, 2013-06-13 at 14:50 +0100, Richard Sandiford wrote: The entirety of the comment looks pretty good to me. :-) One question, and this is mostly curiosity on my part, I'm not specifically asking for another revision. * (This is

[Mesa-dev] [PATCH 1/3] glsl/linker: Use correct array length when linking inter-stage uniforms and varyings.

2013-06-14 Thread Fabian Bieler
Signed-off-by: Fabian Bieler fabianbie...@fastmail.fm --- src/glsl/linker.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cpp index cd8d680..e3a8ccd 100644 --- a/src/glsl/linker.cpp +++ b/src/glsl/linker.cpp @@ -1147,7 +1147,7 @@

[Mesa-dev] [PATCH 2/3] glsl: Only call mark_whole_array_access for arrays.

2013-06-14 Thread Fabian Bieler
Otherwise the max_array_access field of scalar variables is set to 0x. This doesn't lead to any errors since that field isn't used for scalar variables but leaving it at zero is probably better. Signed-off-by: Fabian Bieler fabianbie...@fastmail.fm --- src/glsl/ast_to_hir.cpp | 8

[Mesa-dev] [PATCH 3/3] mesa/main: Check for 0 size draws after validation.

2013-06-14 Thread Fabian Bieler
When validating draw parameters move check for 0 draw count last (drawing with count 0 is not an error), so that other parameters (e.g.: the primitive type) are validated and the correct errors (if applicable) are generated. From the OpenGL 3.3 spec page 33 (page 48 of the PDF): [Regarding

Re: [Mesa-dev] Pull request for 1.50 GS layout qualifiers

2013-06-14 Thread Fabian Bieler
Hello! I gave your series a try and found two small nitpicks: In glsl: Parse the GLSL 1.50 GS layout qualifiers.: There are two debug printfs left in ast_type_qualifier::merge_qualifier max_vertices or VerticesOut is not checked against MaxGeometryOutputVertices. Fabian On 2013-06-14 03:15,

Re: [Mesa-dev] [PATCH] draw: don't clear the so targets until we stream out

2013-06-14 Thread Brian Paul
On 06/13/2013 07:01 PM, Zack Rusin wrote: Though I find stream output very confusing... I agree. I was digging a bit more and I think I was correct the first time. The D3D spec is very clear that a buffer cannot be bound as both an input and an output at the same time, so I think the current

Re: [Mesa-dev] [PATCH 2/2] st/xlib: Fix XImage stride calculation

2013-06-14 Thread Brian Paul
On 06/14/2013 04:11 AM, Richard Sandiford wrote: Fixes window skew seen while running gnome on a 16-bit screen over vnc. Signed-off-by: Richard Sandiford rsand...@linux.vnet.ibm.com --- src/gallium/state_trackers/glx/xlib/xm_api.c | 8 1 file changed, 4 insertions(+), 4 deletions(-)

[Mesa-dev] [PATCH] R600: Add SI load support for v[24]i32 and store for v2i32

2013-06-14 Thread Aaron Watry
Also add a seperate vector lit test file, since r600 doesn't seem to handle v2i32 load/store yet, but we can test both for SI. Signed-off-by: Aaron Watry awa...@gmail.com --- lib/Target/R600/SIInstructions.td | 5 + test/CodeGen/R600/load.vec.ll | 19 +++ 2 files

Re: [Mesa-dev] [PATCH] draw: don't clear the so targets until we stream out

2013-06-14 Thread Jose Fonseca
Sounds good to me. Jose - Original Message - Since draw auto fetches the count from the buffers, we can't just clear them on bind, we need to wait until the actual stream out is performed. Otherwise the count for draw auto will be zero. Plus is cleaner to have draw do it rather than

Re: [Mesa-dev] R600 Patches: Add support for the local address space

2013-06-14 Thread Vincent Lejeune
Hi, Thank for your work on this ! Patch 2, 4 and 5 have my rb. diff --git a/lib/Target/R600/R600InstrInfo.cpp b/lib/Target/R600/R600InstrInfo.cpp index b9da74c..6de47f7 100644 --- a/lib/Target/R600/R600InstrInfo.cpp +++ b/lib/Target/R600/R600InstrInfo.cpp @@ -133,6 +133,12 @@ bool

Re: [Mesa-dev] [PATCH] mesa: per-texture locking

2013-06-14 Thread Eric Anholt
Frank Henigman fjhenig...@google.com writes: On Wed, Jun 12, 2013 at 1:33 PM, Eric Anholt e...@anholt.net wrote: glCopyTexSubImage was just an example of reads from texture and writes to texture, thanks to FBOs -- you've also got the normal drawing path, glCopyPixels, glDrawPixels, glBitmap,

[Mesa-dev] [PATCH] gallium: add condition parameter to render_condition

2013-06-14 Thread sroland
From: Roland Scheidegger srol...@vmware.com For conditional rendering this makes it possible to skip rendering if either the predicate is true or false, as supported by d3d10 (in fact previously it was sort of implied skip rendering if predicate is false for occlusion predicate, and true for

[Mesa-dev] [PATCH] mesa: Fix ieee fp on Alpha

2013-06-14 Thread Sven Joachim
Commit 1f82bf12ed inadvertently broke it, checking for __IEEE_FLOAT on all Alpha machines instead of only on VMS as before. NOTE: This is a candidate for the 9.1 branch. Signed-off-by: Sven Joachim svenj...@gmx.de --- src/mesa/main/compiler.h | 2 +- 1 file changed, 1 insertion(+), 1

Re: [Mesa-dev] [PATCH] mesa: Fix ieee fp on Alpha

2013-06-14 Thread Matt Turner
On Fri, Jun 14, 2013 at 1:10 PM, Sven Joachim svenj...@gmx.de wrote: Commit 1f82bf12ed inadvertently broke it, checking for __IEEE_FLOAT on all Alpha machines instead of only on VMS as before. NOTE: This is a candidate for the 9.1 branch. Signed-off-by: Sven Joachim svenj...@gmx.de ---

[Mesa-dev] RFC: more changes to render_condition

2013-06-14 Thread Roland Scheidegger
Am 14.06.2013 19:49, schrieb srol...@vmware.com: From: Roland Scheidegger srol...@vmware.com For conditional rendering this makes it possible to skip rendering if either the predicate is true or false, as supported by d3d10 (in fact previously it was sort of implied skip rendering if

[Mesa-dev] [PATCH] prog_parameter.c ASAN Patch

2013-06-14 Thread Myles C. Maxfield
Sorry for the triple post; I received a bounce email the first time and got sent to the spam folder the second time, so I'm trying a third time. Hello, all. I was running Mesa with Address Sanitizer [1] turned on, and found one place where ASAN pointed out a read-before-initialized problem. In

Re: [Mesa-dev] [PATCH] clover: Don't segfault when compiling a program with no kernel

2013-06-14 Thread Tom Stellard
On Thu, Jun 06, 2013 at 10:29:21AM -0500, Aaron Watry wrote: Looks good to me. Is there a piglit test for this? I just sent a test for this to the list. -Tom --Aaron On Wed, Jun 5, 2013 at 7:12 PM, Tom Stellard t...@stellard.net wrote: From: Tom Stellard thomas.stell...@amd.com

Re: [Mesa-dev] [PATCH] R600: Add SI load support for v[24]i32 and store for v2i32

2013-06-14 Thread Tom Stellard
On Fri, Jun 14, 2013 at 08:40:38AM -0500, Aaron Watry wrote: Also add a seperate vector lit test file, since r600 doesn't seem to handle v2i32 load/store yet, but we can test both for SI. Pushed, thanks! -Tom Signed-off-by: Aaron Watry awa...@gmail.com ---

[Mesa-dev] [PATCH] llvmpipe: fixes for conditional rendering

2013-06-14 Thread sroland
From: Roland Scheidegger srol...@vmware.com honor render_condition for clear_render_target and clear_depth_stencil. Also add minimal support for occlusion predicate, though it can't be active at the same time as an occlusion query yet. While here also switchify some large if-else (actually just