[Mesa-dev] [PATCH] llvmpipe: fix pipeline statistics with a null ps

2013-08-13 Thread Zack Rusin
If the fragment shader is null then pixel shader invocations have to be equal to zero. And if we're running a null ps then clipper invocations and primitives should be equal to zero but only if both stancil and depth testing are disabled. Signed-off-by: Zack Rusin za...@vmware.com ---

Re: [Mesa-dev] Patches: R600: Merge R600 and SI vector op expansions

2013-08-13 Thread Michel Dänzer
On Mon, 2013-08-12 at 15:25 -0700, Tom Stellard wrote: The attached patches expand a few more vector operations and also move the expansion code into AMDGPUISelLowering.cpp so it can be shared between R600 and SI. This series is Reviewed-by: Michel Dänzer michel.daen...@amd.com --

Re: [Mesa-dev] OpenGL ES only configuration (without desktop OpenGL support)

2013-08-13 Thread Tom Gall
On Mon, Aug 12, 2013 at 10:09 PM, Chad Versace chad.vers...@linux.intel.com wrote: On 08/06/2013 09:44 PM, Siarhei Siamashka wrote: On Tue, 6 Aug 2013 15:54:57 -0700 Matt Turner matts...@gmail.com wrote: On Tue, Aug 6, 2013 at 2:13 PM, Siarhei Siamashka siarhei.siamas...@gmail.com wrote:

Re: [Mesa-dev] Patches: R600/SI: Rework resource descriptor types and fix piglit compute hangs

2013-08-13 Thread Michel Dänzer
On Mon, 2013-08-12 at 12:53 -0700, Tom Stellard wrote: Hi, The attached patches make the v1i32 type which was used for sample coordinates and the v16i8 type which was used for resource descriptors illegal. There is a new pass which will convert v1i32 to i32 and v16i8 to i128 for all

Re: [Mesa-dev] [PATCH] draw: make sure that the stages setup outputs

2013-08-13 Thread Roland Scheidegger
Am 09.08.2013 16:13, schrieb Zack Rusin: Calling the prepare outputs cleans up the slot assignments for outputs, unfortunately aapoint and aaline didn't have code to reset their slots after the initial setup, this was messing up our slot assignments. The unfilled stage was just missing the

Re: [Mesa-dev] [PATCH] tgsi_build: fix order of arguments for ind register build

2013-08-13 Thread Brian Paul
On 08/12/2013 06:14 PM, Dave Airlie wrote: From: Dave Airlie airl...@redhat.com This was broken when arrayid was added. Signed-off-by: Dave Airlie airl...@redhat.com --- src/gallium/auxiliary/tgsi/tgsi_build.c | 2 +- src/gallium/renderer/virgl_hw.h | 39

Re: [Mesa-dev] segfault in pstip_bind_sampler_states

2013-08-13 Thread Brian Paul
On 08/12/2013 11:30 AM, Kevin H. Hobbs wrote: On 08/12/2013 10:29 AM, Brian Paul wrote: Can you run with valgrind? That should give us some useful info if there's a use-after-free. Sure, $ valgrind /home/kevin/kitware/VTK_OSMesa_Build/bin/vtkpython --enable-bt

Re: [Mesa-dev] Patches: R600: Improve load / store support for 8-bit and 16-bit types

2013-08-13 Thread Aaron Watry
I've finished running comparison tests on Cayman/Pitcairn. The descriptors series and 8/16-bit load/store support series both look like they're in good condition for the cards I was able to test: Cedar (5400), A6-3500 Llano and Pitcairn (7850). No regressions spotted, just improvements. And as

Re: [Mesa-dev] OpenGL ES only configuration (without desktop OpenGL support)

2013-08-13 Thread Siarhei Siamashka
On Thu, 08 Aug 2013 16:19:28 -0700 Ian Romanick i...@freedesktop.org wrote: On 08/06/2013 02:13 PM, Siarhei Siamashka wrote: Hello, Some months ago, the commit configure.ac: Allow OpenGL ES1 and ES2 only with enabled OpenGL dropped support for the OpenGL-free configuration.

Re: [Mesa-dev] OpenGL ES only configuration (without desktop OpenGL support)

2013-08-13 Thread Siarhei Siamashka
On Mon, 12 Aug 2013 14:09:39 -0700 Chad Versace chad.vers...@linux.intel.com wrote: On 08/06/2013 09:44 PM, Siarhei Siamashka wrote: On Tue, 6 Aug 2013 15:54:57 -0700 Matt Turner matts...@gmail.com wrote: On Tue, Aug 6, 2013 at 2:13 PM, Siarhei Siamashka siarhei.siamas...@gmail.com

Re: [Mesa-dev] segfault in pstip_bind_sampler_states

2013-08-13 Thread Kevin H. Hobbs
On 08/13/2013 09:50 AM, Brian Paul wrote: On 08/12/2013 11:30 AM, Kevin H. Hobbs wrote: --30166-- VALGRIND INTERNAL ERROR: Valgrind received a signal 11 (SIGSEGV) - exiting Well, that's not too helpful. I think it may have been helpful. Before Valgrind crashed it mentions that

[Mesa-dev] [PATCH 0/4] i965: Some small refactors for Broadwell

2013-08-13 Thread Chad Versace
Here are some small refactors for Broadwell. I'd like to see them merged upstream now to ease the maintenance of internal trees. There's nothing exciting here, so I request your rubberstamp. Chad Versace (2): i965: Refactor names of sample_positions_8/4x arrays i965: Move arrays

[Mesa-dev] [PATCH 1/4] i965: Mark a few brw_draw_upload.c functions as non-static

2013-08-13 Thread Chad Versace
From: Kenneth Graunke kenn...@whitecape.org We will reuse these for Broadwell. Reviewed-by: Chad Versace chad.vers...@linux.intel.com --- src/mesa/drivers/dri/i965/brw_context.h | 5 + src/mesa/drivers/dri/i965/brw_draw_upload.c | 16 +--- 2 files changed, 14 insertions(+),

[Mesa-dev] [PATCH 2/4] i965/gen7+: Mark upload_3dstate_so_decl_list as non-static (v2)

2013-08-13 Thread Chad Versace
From: Kenneth Graunke kenn...@whitecape.org We will reuse this for Broadwell. v2: Prefix function name with 'gen7'. (chadv) Reviewed-by: Chad Versace chad.vers...@linux.intel.com --- src/mesa/drivers/dri/i965/brw_state.h | 4 src/mesa/drivers/dri/i965/gen7_sol_state.c | 6 +++--- 2

[Mesa-dev] [PATCH 3/4] i965: Refactor names of sample_positions_8/4x arrays

2013-08-13 Thread Chad Versace
Place each array in the brw namespace by renaming it: sample_positions_4x - brw_multisample_positions_4x sample_positions_8x - brw_multisample_positions_8x This prepares for moving the arrays to a header shared by gen6 and gen8. CC: Paul Berry stereotype...@gmail.com Signed-off-by: Chad

[Mesa-dev] [PATCH 4/4] i965: Move arrays brw_multisample_positions* to new header

2013-08-13 Thread Chad Versace
Move the arrays to the new header brw_multisample_state.h, which will be shared with Broadwell code. CC: Paul Berry stereotype...@gmail.com Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- src/mesa/drivers/dri/i965/brw_multisample_state.h | 72 ++

[Mesa-dev] [PATCH] configure: link against -lLLVM to determine build type

2013-08-13 Thread Maarten Lankhorst
Fixes a build failure of 9.2 on ubuntu, because libLLVM-3.3.so is not present in /usr/lib/llvm-3.2/lib. Signed-off-by: Maarten Lankhorst maarten.lankho...@canonical.com --- diff --git a/configure.ac b/configure.ac index 35f6797..579d8d4 100644 --- a/configure.ac +++ b/configure.ac @@ -1870,7

Re: [Mesa-dev] [Patch] Sharing flags should disable tiling

2013-08-13 Thread Chad Versace
On 08/12/2013 03:15 PM, Stéphane Marchesin wrote: On Mon, Aug 12, 2013 at 3:05 PM, Marek Olšák mar...@gmail.com wrote: On Mon, Aug 12, 2013 at 11:36 PM, Stéphane Marchesin stephane.marche...@gmail.com wrote: Other than hybrid systems (of which there are none with i915 graphics), is there any

[Mesa-dev] [PATCH] radeon/llvm: fix compile error with -Werror=format-security

2013-08-13 Thread Maarten Lankhorst
Signed-off-by: Maarten Lankhorst maarten.lankho...@canonical.com --- diff --git a/src/gallium/drivers/radeon/radeon_llvm_emit.c b/src/gallium/drivers/radeon/radeon_llvm_emit.c index 1a4d4fd..2dd7bf7 100644 --- a/src/gallium/drivers/radeon/radeon_llvm_emit.c +++

Re: [Mesa-dev] [PATCH 4/4] i965: Move arrays brw_multisample_positions* to new header

2013-08-13 Thread Kenneth Graunke
On 08/13/2013 08:53 AM, Chad Versace wrote: Move the arrays to the new header brw_multisample_state.h, which will be shared with Broadwell code. CC: Paul Berry stereotype...@gmail.com Signed-off-by: Chad Versace chad.vers...@linux.intel.com Hmm. Looks like I botched my patches in a rebase,

[Mesa-dev] [PATCH 1/4] ilo: implement new float comparison instructions

2013-08-13 Thread sroland
From: Roland Scheidegger srol...@vmware.com untested. --- src/gallium/drivers/ilo/shader/toy_tgsi.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/src/gallium/drivers/ilo/shader/toy_tgsi.c b/src/gallium/drivers/ilo/shader/toy_tgsi.c index

[Mesa-dev] [PATCH 3/4] r600/radeonsi: implement new float comparison instructions

2013-08-13 Thread sroland
From: Roland Scheidegger srol...@vmware.com Also use ordered comparisons for old cmp instructions. Untested. --- src/gallium/drivers/r600/r600_shader.c | 18 --- .../drivers/radeon/radeon_setup_tgsi_llvm.c| 49 2 files changed, 48 insertions(+),

[Mesa-dev] [PATCH 2/4] nv50: implement new float comparison instructions

2013-08-13 Thread sroland
From: Roland Scheidegger srol...@vmware.com untested. --- .../drivers/nv50/codegen/nv50_ir_from_tgsi.cpp | 17 + 1 file changed, 17 insertions(+) diff --git a/src/gallium/drivers/nv50/codegen/nv50_ir_from_tgsi.cpp b/src/gallium/drivers/nv50/codegen/nv50_ir_from_tgsi.cpp

[Mesa-dev] [PATCH 4/4] st/mesa: use new float comparison opcodes if native integers are supported

2013-08-13 Thread sroland
From: Roland Scheidegger srol...@vmware.com Should get rid of some float-to-int conversions (with negation). No piglit regressions (with llvmpipe). --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 45 ++-- 1 file changed, 15 insertions(+), 30 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 4/4] st/mesa: use new float comparison opcodes if native integers are supported

2013-08-13 Thread Roland Scheidegger
I tested this for llvmpipe, but it would be good if the respective driver authors could verify it works for their drivers, I have no idea if I got it right there, just guessed how it might work based mostly on how other comparison instructions are handled (and I hope I caught all drivers, those

Re: [Mesa-dev] [i965][V2] i965/draw: Move constant formation outside of for loop and use an enum.

2013-08-13 Thread Kenneth Graunke
On 08/09/2013 12:33 AM, Eric Anholt wrote: Mark Mueller markkmuel...@gmail.com writes: On Thu, Aug 8, 2013 at 2:19 PM, Eric Anholt e...@anholt.net wrote: Mark Mueller markkmuel...@gmail.com writes: Signed-off-by: Mark Mueller markkmuel...@gmail.com --- src/mesa/drivers/dri/i965/brw_draw.c

Re: [Mesa-dev] Enable GLX TLS by default in Mesa?

2013-08-13 Thread Kenneth Graunke
On 08/09/2013 12:26 AM, Vedran Rodic wrote: Hi, I've been burned with the issue of GLX TLS not being enabled by default in Mesa (Dota 2 seems to rely on it). What's the rationale of not enabling it by default? Thanks, Vedran Rodic As far as I know, --enable-glx-tls just makes things more

Re: [Mesa-dev] [PATCH 1/2] glsl: Fix incorrect pattern matching in ir_set_program_inouts

2013-08-13 Thread Kenneth Graunke
On 08/09/2013 10:27 AM, Paul Berry wrote: In commit 8fc41df (glsl: Modify ir_set_program_inouts to handle geometry shaders), when attempting to pattern match the foo part of expressions such as: foo[i][j] foo[i] I incorrectly called as_dereference_variable() on the subexpression foo[i]

[Mesa-dev] [PATCH v2 2/2] radeonsi: Don't export unused clip distance vectors from vertex shader

2013-08-13 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com E.g. the Source engine seems to always write to gl_ClipVertex, but normally doesn't enable any GL_CLIP_DISTANCEn states. This change removes some irrelevant parts from the generated vertex shader code in such cases. Signed-off-by: Michel Dänzer

[Mesa-dev] [PATCH v2 1/2] radeonsi: Don't leave gaps between position exports from vertex shader

2013-08-13 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com If the vertex shader exports clip distances but not point size, use position exports 1/2 instead of 2/3 for the clip distances. Fixes geometry corruption in that case. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=66974 Cc:

Re: [Mesa-dev] segfault in pstip_bind_sampler_states

2013-08-13 Thread Kevin H. Hobbs
On 08/13/2013 11:45 AM, Kevin H. Hobbs wrote: On 08/13/2013 09:50 AM, Brian Paul wrote: On 08/12/2013 11:30 AM, Kevin H. Hobbs wrote: --30166-- VALGRIND INTERNAL ERROR: Valgrind received a signal 11 (SIGSEGV) - exiting Well, that's not too helpful. Ha! I can move the segfault all the

Re: [Mesa-dev] [PATCH 3/9] glsl: Emit errors for things that look like default precision statements

2013-08-13 Thread Kenneth Graunke
On 08/09/2013 04:38 PM, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com Previously we would emit a warning for empty declarations like float; We would also emit the same warning for things like highp float; However, this second case is most likely the application trying to

Re: [Mesa-dev] [PATCH 2/4] nv50: implement new float comparison instructions

2013-08-13 Thread Christoph Bumiller
On 13.08.2013 19:04, srol...@vmware.com wrote: From: Roland Scheidegger srol...@vmware.com untested. Looks like it should work though, thanks. nv50 only supported u32 result all along and on nvc0 both cases are already handled by the rest of the code, too. ---

Re: [Mesa-dev] Enable GLX TLS by default in Mesa?

2013-08-13 Thread Vedran Rodic
On Tue, Aug 13, 2013 at 7:19 PM, Kenneth Graunke kenn...@whitecape.org wrote: As far as I know, --enable-glx-tls just makes things more efficient. Nothing should *rely* on it, or even be able to detect it... Dota 2 crashes without that option when loading the actual game map. I assumed it

[Mesa-dev] Another Take on the S3TC issue

2013-08-13 Thread Uwe Schmidt
Hi, I have read about the issue of implementing the S3TC Extension in Mesa: http://dri.freedesktop.org/wiki/S3TC/ As I understood, the problem is, that encoding and decoding S3TC in software is covered by patents, while passing S3TC compressed data to the GPU is still ok. AS NOW: If

[Mesa-dev] [PATCH 2/2] i965: Add Gen7 depth stall flushes before disabling depth in BLORP.

2013-08-13 Thread Kenneth Graunke
We emit these before configuring depth in the normal path, or actually using the depth buffer in BLORP - we just failed to emit them when disabling depth altogether. Signed-off-by: Kenneth Graunke kenn...@whitecape.org --- src/mesa/drivers/dri/i965/gen7_blorp.cpp | 2 ++ 1 file changed, 2

[Mesa-dev] [PATCH 1/2] i965: Add Gen6 depth stall flushes before disabling depth in BLORP.

2013-08-13 Thread Kenneth Graunke
We emit these before configuring depth in the normal path, or actually using the depth buffer in BLORP - we just failed to emit them when disabling depth altogether. On Sandybridge, this also requires the post_sync_nonzero flush. Signed-off-by: Kenneth Graunke kenn...@whitecape.org ---

Re: [Mesa-dev] Another Take on the S3TC issue

2013-08-13 Thread Patrick Baggett
I've been hanging on this list for a while, and this isn't the first time this has been suggested. The general thing that is repeated is basically this: if you make an API (e.g. OpenGL) that supports S3TC without a license, you're in trouble, even if it is a passthrough to the hardware, which also

Re: [Mesa-dev] Another Take on the S3TC issue

2013-08-13 Thread Ian Romanick
On 08/13/2013 11:53 AM, Uwe Schmidt wrote: Hi, I have read about the issue of implementing the S3TC Extension in Mesa: http://dri.freedesktop.org/wiki/S3TC/ As I understood, the problem is, that encoding and decoding S3TC in software is covered by patents, while passing S3TC compressed data to

Re: [Mesa-dev] OpenGL ES only configuration (without desktop OpenGL support)

2013-08-13 Thread Ian Romanick
On 08/13/2013 07:49 AM, Siarhei Siamashka wrote: On Thu, 08 Aug 2013 16:19:28 -0700 Ian Romanick i...@freedesktop.org wrote: On 08/06/2013 02:13 PM, Siarhei Siamashka wrote: Hello, Some months ago, the commit configure.ac: Allow OpenGL ES1 and ES2 only with enabled OpenGL dropped support for

Re: [Mesa-dev] Another Take on the S3TC issue

2013-08-13 Thread Roland Mainz
On Tue, Aug 13, 2013 at 10:20 PM, Ian Romanick i...@freedesktop.org wrote: On 08/13/2013 11:53 AM, Uwe Schmidt wrote: [snip] SO MY PROPOSAL: If 'format' is one of the S3TC types, and format!=internalFormat is true, then set internalFormat:=format. 'format' cannot be a compressed type.

Re: [Mesa-dev] segfault in pstip_bind_sampler_states

2013-08-13 Thread Kevin H. Hobbs
On 08/13/2013 01:41 PM, Kevin H. Hobbs wrote: Ha! I can move the segfault all the way back to : Program received signal SIGSEGV, Segmentation fault. 0x7fffe0ba6d43 in osmesa_st_framebuffer_flush_front (stctx=0x1518ee0, stfbi=0x1520560, statt=ST_ATTACHMENT_FRONT_LEFT) at

Re: [Mesa-dev] Another Take on the S3TC issue

2013-08-13 Thread Ian Romanick
On 08/13/2013 01:27 PM, Roland Mainz wrote: On Tue, Aug 13, 2013 at 10:20 PM, Ian Romanick i...@freedesktop.org wrote: On 08/13/2013 11:53 AM, Uwe Schmidt wrote: [snip] SO MY PROPOSAL: If 'format' is one of the S3TC types, and format!=internalFormat is true, then set internalFormat:=format.

[Mesa-dev] [PATCH] glsl: Emit better warnings for things that look like default precision statements

2013-08-13 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Previously we would emit a warning for empty declarations like float; We would also emit the same warning for things like highp float; However, this second case is most likely the application trying to set the default precision. This makes the

Re: [Mesa-dev] Enable GLX TLS by default in Mesa?

2013-08-13 Thread Chad Versace
On 08/13/2013 12:04 PM, Vedran Rodic wrote: On Tue, Aug 13, 2013 at 7:19 PM, Kenneth Graunke kenn...@whitecape.org wrote: As far as I know, --enable-glx-tls just makes things more efficient. Nothing should *rely* on it, or even be able to detect it... Dota 2 crashes without that option

Re: [Mesa-dev] Another Take on the S3TC issue

2013-08-13 Thread Roland Mainz
On Tue, Aug 13, 2013 at 10:33 PM, Ian Romanick i...@freedesktop.org wrote: On 08/13/2013 01:27 PM, Roland Mainz wrote: On Tue, Aug 13, 2013 at 10:20 PM, Ian Romanick i...@freedesktop.org wrote: On 08/13/2013 11:53 AM, Uwe Schmidt wrote: [snip] Until S3 grants it's IP to OIN or the patents

Re: [Mesa-dev] [PATCH 2/2] i965: Add Gen7 depth stall flushes before disabling depth in BLORP.

2013-08-13 Thread Chad Versace
The series is Reviewed-by: Chad Versace chad.vers...@linux.intel.com Yet another instance of the reason to unify blorp with normal draw. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] Another Take on the S3TC issue

2013-08-13 Thread Ian Romanick
On 08/13/2013 01:42 PM, Roland Mainz wrote: On Tue, Aug 13, 2013 at 10:33 PM, Ian Romanick i...@freedesktop.org wrote: On 08/13/2013 01:27 PM, Roland Mainz wrote: On Tue, Aug 13, 2013 at 10:20 PM, Ian Romanick i...@freedesktop.org wrote: On 08/13/2013 11:53 AM, Uwe Schmidt wrote: [snip]

Re: [Mesa-dev] Enable GLX TLS by default in Mesa?

2013-08-13 Thread Ian Romanick
On 08/13/2013 12:04 PM, Vedran Rodic wrote: On Tue, Aug 13, 2013 at 7:19 PM, Kenneth Graunke kenn...@whitecape.org wrote: As far as I know, --enable-glx-tls just makes things more efficient. Nothing should *rely* on it, or even be able to detect it... Dota 2 crashes without that option

Re: [Mesa-dev] Another Take on the S3TC issue

2013-08-13 Thread Patrick Baggett
Erm... I'm wondering... why does the S3TC issue come up every few months out of it's grave and haunt the list (and your nerves) ? I think it is because the issue looks deceptively simple. Hardware is hardware, right? ASICs do the decompression, not software. Surely blindly copying bits from one

Re: [Mesa-dev] [PATCH 4/4] st/mesa: use new float comparison opcodes if native integers are supported

2013-08-13 Thread Brian Paul
On 08/13/2013 11:04 AM, srol...@vmware.com wrote: From: Roland Scheidegger srol...@vmware.com Should get rid of some float-to-int conversions (with negation). No piglit regressions (with llvmpipe). --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 45 ++-- 1 file

Re: [Mesa-dev] [PATCH 4/4] st/mesa: use new float comparison opcodes if native integers are supported

2013-08-13 Thread Roland Scheidegger
Am 13.08.2013 23:38, schrieb Brian Paul: On 08/13/2013 11:04 AM, srol...@vmware.com wrote: From: Roland Scheidegger srol...@vmware.com Should get rid of some float-to-int conversions (with negation). No piglit regressions (with llvmpipe). --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp |

Re: [Mesa-dev] Another Take on the S3TC issue

2013-08-13 Thread Marek Olšák
I don't think this is our problem. If a distro wants S3TC support, its maintainers can package libtxc_dxtn. Some distros really do it. If a distro doesn't want S3TC support, there is nothing we can do about it. Marek On Tue, Aug 13, 2013 at 8:53 PM, Uwe Schmidt simon.schm...@cs-systemberatung.de

Re: [Mesa-dev] [Patch] Sharing flags should disable tiling

2013-08-13 Thread Kristian Høgsberg
On Mon, Aug 12, 2013 at 3:05 PM, Marek Olšák mar...@gmail.com wrote: On Mon, Aug 12, 2013 at 11:36 PM, Stéphane Marchesin stephane.marche...@gmail.com wrote: Other than hybrid systems (of which there are none with i915 graphics), is there any case where __DRI_IMAGE_USE_SHARE can occur? You

Re: [Mesa-dev] [PATCH v2] gbm: fix linking

2013-08-13 Thread Bryce W. Harrington
Armin K wrote: Link to internal libwayland-drm library if Wayland EGL platform is enabled. The library needs to be built before gbm. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=67962 In going through the wayland manual build directions[1] the other day, I hit this bug when trying

Re: [Mesa-dev] [PATCH 2/3] i965/gen7: Set MOCS L3 cacheability for IVB/BYT

2013-08-13 Thread Vedran Rodic
On Mon, Aug 12, 2013 at 3:07 PM, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com IVB/BYT also has the same L3 cacheability control in MOCS as HSW, so let's make use of it. According to the discussion we had on #intel-gfx a few weeks ago, on IVB all Mesa

[Mesa-dev] [PATCH] i965: Force X-tiling for 128 bpp formats on Sandybridge.

2013-08-13 Thread Kenneth Graunke
128 bpp formats are not allowed to be Y-tiled on any architectures except Gen7. +11 Piglits on Sandybridge (mostly regression fixes since the switch to Y-tiling). Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=63867 Cc: Topi Pohjolainen topi.pohjolai...@intel.com Cc: Chad Versace

Re: [Mesa-dev] [PATCH] glsl: Emit better warnings for things that look like default precision statements

2013-08-13 Thread Matt Turner
On Tue, Aug 13, 2013 at 1:35 PM, Ian Romanick i...@freedesktop.org wrote: and the spec doesn't explicitly forbid it. I was surprised by this, so I verified it. In the GLSL ES 3.0 spec: single_declaration fully_specified_type type_specifier precision_qualifier type_specifier_no_prec

Re: [Mesa-dev] [PATCH 8/9] glsl: Merge precision qualifiers too

2013-08-13 Thread Matt Turner
On Fri, Aug 9, 2013 at 4:38 PM, Ian Romanick i...@freedesktop.org wrote: From: Ian Romanick ian.d.roman...@intel.com We never noticed this before because we previously didn't enfoce GLSL ES fragement shader requirements that precision be defined. There may also have been some interaction

[Mesa-dev] [PATCH] i965/fs: Fix Sandybridge regressions from SEL optimization.

2013-08-13 Thread Kenneth Graunke
Sandybridge is the only platform that supports an IF instruction with an embedded comparison. In this case, we need to emit a CMP to go along with the SEL. Fixes regressions in Piglit's glsl-fs-atan-3, fs-unpackHalf2x16, fs-faceforward-float-float-float, isinf-and-isnan fs_basic, and

Re: [Mesa-dev] Another Take on the S3TC issue

2013-08-13 Thread Maxence Le Doré
Maybe it's time let S3TC go away and think about something else. Like BPTC. I've started something. Currently, this is very dirty. Please, take a quick look at this : https://docs.google.com/file/d/0B1BiksMm0x0GVjZPZHgyNm0xLVE/edit?usp=sharing Yeah, I know. Ugly. But it basically works. I can

[Mesa-dev] [PATCH] gallivm: fix border color with normalized texture formats

2013-08-13 Thread sroland
From: Roland Scheidegger srol...@vmware.com We need to put border color into texture format color space which essentially means clamping for non-float, normalized formats (not entirely sure if we're also meant to quantize the float but it's probably ok not to do it thankfully). For OpenGL we

Re: [Mesa-dev] [PATCH] glsl: Emit better warnings for things that look like default precision statements

2013-08-13 Thread Ian Romanick
On 08/13/2013 03:50 PM, Matt Turner wrote: On Tue, Aug 13, 2013 at 1:35 PM, Ian Romanick i...@freedesktop.org wrote: and the spec doesn't explicitly forbid it. I was surprised by this, so I verified it. In the GLSL ES 3.0 spec: single_declaration fully_specified_type type_specifier

[Mesa-dev] [PATCH] i965/hsw: Populate MOCS for STATE_BASE_ADDRESS (v2)

2013-08-13 Thread Chad Versace
From: Ville Syrjälä ville.syrj...@linux.intel.com Just spotted these unpopulated MOCS fields when comparing the code against BSpec. Set the MOCS to the same as everywhere else in Haswell: L3-cacheable. v2: Annotate state packet fields (chadv). Signed-off-by: Ville Syrjälä

Re: [Mesa-dev] [PATCH] i965: Force X-tiling for 128 bpp formats on Sandybridge.

2013-08-13 Thread Ian Romanick
On 08/13/2013 03:37 PM, Kenneth Graunke wrote: 128 bpp formats are not allowed to be Y-tiled on any architectures except Gen7. +11 Piglits on Sandybridge (mostly regression fixes since the switch to Y-tiling). Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=63867 Also

Re: [Mesa-dev] [PATCH 2/3] i965/gen7: Set MOCS L3 cacheability for IVB/BYT

2013-08-13 Thread Chad Versace
On 08/13/2013 03:31 PM, Vedran Rodic wrote: On Mon, Aug 12, 2013 at 3:07 PM, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com IVB/BYT also has the same L3 cacheability control in MOCS as HSW, so let's make use of it. According to the discussion we had

Re: [Mesa-dev] [PATCH] i965: Force X-tiling for 128 bpp formats on Sandybridge.

2013-08-13 Thread Chad Versace
On 08/13/2013 05:45 PM, Ian Romanick wrote: On 08/13/2013 03:37 PM, Kenneth Graunke wrote: 128 bpp formats are not allowed to be Y-tiled on any architectures except Gen7. +11 Piglits on Sandybridge (mostly regression fixes since the switch to Y-tiling). Bugzilla:

Re: [Mesa-dev] [PATCH] i965/fs: Fix Sandybridge regressions from SEL optimization.

2013-08-13 Thread Ian Romanick
On 08/13/2013 04:47 PM, Kenneth Graunke wrote: Sandybridge is the only platform that supports an IF instruction with an embedded comparison. In this case, we need to emit a CMP to go along with the SEL. Fixes regressions in Piglit's glsl-fs-atan-3, fs-unpackHalf2x16,

Re: [Mesa-dev] [PATCH] i965: Force X-tiling for 128 bpp formats on Sandybridge.

2013-08-13 Thread Ian Romanick
On 08/13/2013 05:47 PM, Chad Versace wrote: On 08/13/2013 05:45 PM, Ian Romanick wrote: On 08/13/2013 03:37 PM, Kenneth Graunke wrote: 128 bpp formats are not allowed to be Y-tiled on any architectures except Gen7. +11 Piglits on Sandybridge (mostly regression fixes since the switch to

Re: [Mesa-dev] [PATCH 2/3] i965/gen7: Set MOCS L3 cacheability for IVB/BYT

2013-08-13 Thread Chad Versace
On 08/12/2013 06:07 AM, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com IVB/BYT also has the same L3 cacheability control in MOCS as HSW, so let's make use of it. pts/xonotic and pts/reaction @ 1920x1080 gain ~4% on my IVB GT2. Most other things show less

Re: [Mesa-dev] [PATCH] i965/fs: Fix Sandybridge regressions from SEL optimization.

2013-08-13 Thread Kenneth Graunke
On 08/13/2013 05:49 PM, Ian Romanick wrote: On 08/13/2013 04:47 PM, Kenneth Graunke wrote: Sandybridge is the only platform that supports an IF instruction with an embedded comparison. In this case, we need to emit a CMP to go along with the SEL. Fixes regressions in Piglit's glsl-fs-atan-3,

Re: [Mesa-dev] [PATCH 3/3] i965/gen7: Don't use L3$ for render targets

2013-08-13 Thread Chad Versace
On 08/12/2013 06:07 AM, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com According to HSW Bspec L3$ evictions may land in LLC regardless of LLC MOCS/PTE settings. That means we shouldn't set scanout buffers as L3 cacheable when writing to them. So far I've

[Mesa-dev] [PATCH 15/20] radeonsi: add basic infrastructure for atom-based states

2013-08-13 Thread Marek Olšák
It's the same as in r600g. I can't merge si_atom with si_pm4_state, because the latter is too big and isn't even driven by the dirty flag. Also I'm gonna share the whole streamout state handling with r600g (just one atom though) and therefore I need the same interface. The advantage is that

Re: [Mesa-dev] [PATCH] r600g/llvm: Add missing %s format string to fprintf.

2013-08-13 Thread Tom Stellard
On Sun, Aug 11, 2013 at 07:37:01PM +0200, Jon Severinsson wrote: This fixes a compilation warning with -Wformat-security. CC: 9.2 mesa-sta...@lists.freedesktop.org Reviewed-by: Tom Stellard thomas.stell...@amd.com I've pushed this patch, thanks. -Tom ---

Re: [Mesa-dev] [PATCH] radeon/llvm: fix compile error with -Werror=format-security

2013-08-13 Thread Tom Stellard
On Tue, Aug 13, 2013 at 06:25:28PM +0200, Maarten Lankhorst wrote: Signed-off-by: Maarten Lankhorst maarten.lankho...@canonical.com An identical patch was sent to the list a few days ago, and I've just pushed it now. -Tom --- diff --git a/src/gallium/drivers/radeon/radeon_llvm_emit.c

Re: [Mesa-dev] [PATCH] configure: link against -lLLVM to determine build type

2013-08-13 Thread Tom Stellard
On Tue, Aug 13, 2013 at 05:53:52PM +0200, Maarten Lankhorst wrote: Fixes a build failure of 9.2 on ubuntu, because libLLVM-3.3.so is not present in /usr/lib/llvm-3.2/lib. I'm trying to understand the problem here, could you give a little more information about how Ubuntu packages LLVM? Where

Re: [Mesa-dev] [PATCH 3/4] r600/radeonsi: implement new float comparison instructions

2013-08-13 Thread Tom Stellard
On Tue, Aug 13, 2013 at 07:04:56PM +0200, srol...@vmware.com wrote: From: Roland Scheidegger srol...@vmware.com Also use ordered comparisons for old cmp instructions. Untested. This patch looks good to me, but I would like to do a piglit run on radeonsi before you commit. I will try to do

Re: [Mesa-dev] [PATCH v2 1/2] radeonsi: Don't leave gaps between position exports from vertex shader

2013-08-13 Thread Tom Stellard
On Tue, Aug 13, 2013 at 07:39:10PM +0200, Michel Dänzer wrote: From: Michel Dänzer michel.daen...@amd.com If the vertex shader exports clip distances but not point size, use position exports 1/2 instead of 2/3 for the clip distances. Fixes geometry corruption in that case. Bugzilla: