Re: [Mesa-dev] [WIP 04/13] mesa: add a storage for inactive/removed uniform variables

2014-04-07 Thread Tapani Pälli
On 04/05/2014 01:13 AM, Ian Romanick wrote: I've been thinking about this a bit, and I think this is more complex than it needs to be. I don't have a complete design, but here are some thoughts on the matter. When linking is all done, we just want the UniformRemapTable. It's entires should

[Mesa-dev] [PATCH 7/9] glsl: Pass ctx-Const.NativeIntegers to do_common_optimization().

2014-04-07 Thread Kenneth Graunke
The next few patches will introduce an optimization that only works when integers are not represented as floating point values. Signed-off-by: Kenneth Graunke kenn...@whitecape.org --- src/glsl/glsl_parser_extras.cpp| 6 -- src/glsl/ir_optimization.h | 3 ++-

[Mesa-dev] [PATCH 1/9] i965: Fix SIMD16 unsupported messages via KHR_debug.

2014-04-07 Thread Kenneth Graunke
Performance warnings are logged via KHR_debug in addition to when the INTEL_DEBUG=perf environment variable is set. Without this, messages in debug contexts would have (null) for the reason. Signed-off-by: Kenneth Graunke kenn...@whitecape.org --- src/mesa/drivers/dri/i965/brw_fs.cpp | 2 +- 1

[Mesa-dev] [PATCH 5/9] glsl: Fix lack of i2u in lower_ubo_reference.

2014-04-07 Thread Kenneth Graunke
ir_binop_ubo_load takes unsigned integer operands. However, the array index used to compute these offsets may be a signed integer. (For example, see Piglit's spec/glsl-1.40/uniform_buffer/fs-bvec-array). For some reason, we were missing an ir_binop_i2u cast, and ir_validator was failing to

[Mesa-dev] [PATCH 4/9] i965/fs: Skip emitting MACH/MOV for small integers.

2014-04-07 Thread Kenneth Graunke
The vector backend already implemented this optimization, but surprisingly, we never bothered to implement it in the scalar backend. In addition to saving two instructions, this eliminates a use of the accumulator as an explicit source, which is unsupported in SIMD16 mode on Gen7+, which could

[Mesa-dev] [PATCH 6/9] glsl: Validate that base types match for a number of binops.

2014-04-07 Thread Kenneth Graunke
The IR is not supposed to support implicit type conversions; we just failed to validate it. Signed-off-by: Kenneth Graunke kenn...@whitecape.org --- src/glsl/ir_validate.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/glsl/ir_validate.cpp b/src/glsl/ir_validate.cpp index

[Mesa-dev] [PATCH 3/9] glsl: Make is_16bit_constant from i965 an ir_constant method.

2014-04-07 Thread Kenneth Graunke
The i965 MUL instruction doesn't natively support 32-bit by 32-bit integer multiplication; additional instructions (MACH/MOV) are required. However, we can avoid those if we know one of the operands can be represented in 16 bits or less. The vector backend's is_16bit_constant static helper

[Mesa-dev] [PATCH 8/9] glsl: Pass ctx-Const.NativeIntegers to do_algebraic.

2014-04-07 Thread Kenneth Graunke
The next patch will introduce an optimization that only works when integers are not represented as floating point values. Signed-off-by: Kenneth Graunke kenn...@whitecape.org --- src/glsl/glsl_parser_extras.cpp | 2 +- src/glsl/ir_optimization.h | 2 +- src/glsl/opt_algebraic.cpp | 8

[Mesa-dev] [PATCH 2/9] mesa: Move is_power_of_two() function from brw_context.h to macros.h.

2014-04-07 Thread Kenneth Graunke
This makes the function available from core Mesa code, including the GLSL compiler. Signed-off-by: Kenneth Graunke kenn...@whitecape.org --- src/mesa/drivers/dri/i965/brw_context.h | 6 -- src/mesa/main/macros.h | 11 +++ 2 files changed, 11 insertions(+), 6

[Mesa-dev] [PATCH 9/9] glsl: Convert mul/div by power-of-two factors to shift expressions.

2014-04-07 Thread Kenneth Graunke
Integer shifts are basically always well supported and efficient; that isn't always true of integer division, and sometimes even integer multiplication isn't without issues. On some Intel hardware, INTDIV can't be used in SIMD16 mode. It also doesn't support immediate operands (on any

[Mesa-dev] [PATCH 1/2] winsys/svga: Update the vmwgfx_drm.h header to latest version from kernel

2014-04-07 Thread Thomas Hellstrom
Cc: 10.1 mesa-sta...@lists.freedesktop.org Signed-off-by: Thomas Hellstrom thellst...@vmware.com --- src/gallium/winsys/svga/drm/vmwgfx_drm.h | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/src/gallium/winsys/svga/drm/vmwgfx_drm.h

[Mesa-dev] [PATCH 2/2] winsys/svga: Fix prime surface references also for guest-backed surfaces

2014-04-07 Thread Thomas Hellstrom
Implement guest-backed surface sharing using prime fds. Previously only legacy surfaces could use this functionality. Also use the vmwgfx 2.6 single-ioctl prime fd reference if available. Cc: 10.1 mesa-sta...@lists.freedesktop.org Signed-off-by: Thomas Hellstrom thellst...@vmware.com ---

Re: [Mesa-dev] [PATCH 1/2] winsys/svga: Update the vmwgfx_drm.h header to latest version from kernel

2014-04-07 Thread Jakob Bornecrantz
On Mon, Apr 7, 2014 at 11:50 AM, Thomas Hellstrom thellst...@vmware.com wrote: Cc: 10.1 mesa-sta...@lists.freedesktop.org Signed-off-by: Thomas Hellstrom thellst...@vmware.com --- src/gallium/winsys/svga/drm/vmwgfx_drm.h | 13 - 1 file changed, 12 insertions(+), 1 deletion(-)

[Mesa-dev] [PATCH] st/xa: Bind destination before setting new state

2014-04-07 Thread Thomas Hellstrom
Binding a new destination may cause the svga driver to emit draw calls while propagating the surface. Make sure this doesn't happen in the middle of sampler state setup where state may be incosistent. In practice, surface propagation should never happen here and even if it did, it wouldn't be a

Re: [Mesa-dev] [PATCH 0/5] util: Rework endian handling in python code

2014-04-07 Thread Richard Sandiford
Ping. Richard Sandiford rsand...@linux.vnet.ibm.com writes: Ping (with fixed subject) Richard Sandiford rsand...@linux.vnet.ibm.com writes: This is a refresh of: http://lists.freedesktop.org/archives/mesa-dev/2013-June/040594.html At the moment the python code uses sys.byteorder to

Re: [Mesa-dev] [PATCH] gallium glsl: Fix crash with piglit fs-deref-literal-array-of-structs.shader_test

2014-04-07 Thread Maarten Lankhorst
op 03-04-14 18:19, Marek Olšák schreef: Acked-by: Marek Olšák marek.ol...@amd.com Nacked by self btw, the alternative fix below doesn't break other testcases. The original fix did.. No idea why it is legal to move a constant struct/array here, but it appears to pass all tests... --- diff

Re: [Mesa-dev] [PATCH] st/xa: Bind destination before setting new state

2014-04-07 Thread Jakob Bornecrantz
On Mon, Apr 7, 2014 at 12:32 PM, Thomas Hellstrom thellst...@vmware.com wrote: Binding a new destination may cause the svga driver to emit draw calls while propagating the surface. Make sure this doesn't happen in the middle of sampler state setup where state may be incosistent. In practice,

Re: [Mesa-dev] [PATCH mesa/mesa] Hardcode the DRI driver extension as .so to match it's current uses.

2014-04-07 Thread Jon TURNEY
On 06/04/2014 17:45, Emil Velikov wrote: Sorry about this breakage. I assumed that the library extensions are handled consistently across mesa. Seems like I was wrong. Guessing that you meant to send this to the mesa-dev ? Yes, sorry about that. On 06/04/14 15:59, Jon TURNEY wrote: A

Re: [Mesa-dev] [PATCH 3/9] glsl: Make is_16bit_constant from i965 an ir_constant method.

2014-04-07 Thread Ilia Mirkin
On Mon, Apr 7, 2014 at 2:49 AM, Kenneth Graunke kenn...@whitecape.org wrote: The i965 MUL instruction doesn't natively support 32-bit by 32-bit integer multiplication; additional instructions (MACH/MOV) are required. However, we can avoid those if we know one of the operands can be represented

[Mesa-dev] [PATCH 2/2] st/xa: Move version information into a single place

2014-04-07 Thread Emil Velikov
Previously the version was specified in configure.ac as well as one of the xa headers. Thus incleasing the risk of discrepancies when a developer bumps one but forgets about the other. Currently only automake builds the xa state-tracker + targets, and we should move the version definitions to a

[Mesa-dev] [PATCH 1/2] Revert st/xa: Fix advertized version number and try to avoid future discrepancies

2014-04-07 Thread Emil Velikov
Parsing source files through build systems is never a good idea. Especially when the issue can be resolved by adding a couple of definitions to CPPFLAGS via the build system. This reverts commit 61bedc3d6b08943f015f9d590c07a6af36c2a92c. Cc: Thomas Hellstrom thellst...@vmware.com --- Seems like

[Mesa-dev] [PATCH] nouveau: fix firmware check on nvd7/nvd9

2014-04-07 Thread Ilia Mirkin
The kernel driver expects the class to be based on chipset generation rather than VP generation. Make sure to pass 90b1 for NVDX chipsets instead of 95b1. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=77102 Fixes: 40dd777b33073 Signed-off-by: Ilia Mirkin imir...@alum.mit.edu Cc: 10.1

Re: [Mesa-dev] [PATCH 1/2] winsys/svga: Update the vmwgfx_drm.h header to latest version from kernel

2014-04-07 Thread Emil Velikov
On 07/04/14 10:50, Thomas Hellstrom wrote: Cc: 10.1 mesa-sta...@lists.freedesktop.org Signed-off-by: Thomas Hellstrom thellst...@vmware.com Rather silly question: Why do you guys pull this header inside mesa and over using the one provided by libdrm ? AFAICS every other driver seems to do the

Re: [Mesa-dev] [PATCH 1/2] Revert st/xa: Fix advertized version number and try to avoid future discrepancies

2014-04-07 Thread Thomas Hellstrom
On 04/07/2014 02:44 PM, Emil Velikov wrote: Parsing source files through build systems is never a good idea. Especially when the issue can be resolved by adding a couple of definitions to CPPFLAGS via the build system. I've nothing against reverting the commit, but the log message is

Re: [Mesa-dev] [PATCH 2/2] st/xa: Move version information into a single place

2014-04-07 Thread Thomas Hellstrom
On 04/07/2014 02:44 PM, Emil Velikov wrote: Previously the version was specified in configure.ac as well as one of the xa headers. Thus incleasing the risk of discrepancies when a developer bumps one but forgets about the other. Currently only automake builds the xa state-tracker + targets,

Re: [Mesa-dev] Mesa 10.2 release plan strawman

2014-04-07 Thread Ian Romanick
On 04/04/2014 05:52 PM, Matt Turner wrote: On Fri, Apr 4, 2014 at 5:18 PM, Ian Romanick i...@freedesktop.org wrote: Fast forwarding 3 months from the 10.1 release (March 4th, planned for February 28th) is May 30th. I'd like to propose the following set of dates: May 2nd: Feature freeze /

Re: [Mesa-dev] [PATCH] i965/vec4: fix record clearing in copy propagation

2014-04-07 Thread Ian Romanick
On 04/06/2014 09:31 PM, Chia-I Wu wrote: From: Chia-I Wu o...@lunarg.com Given mov vgrf7, vgrf9.xyxz add vgrf9.xyz, vgrf4.xyzw, vgrf5.xyzw add vgrf10.x, vgrf6.xyzw, vgrf7. the last instruction would be wrongly changed to add vgrf10.x, vgrf6.xyzw, vgrf9. during

Re: [Mesa-dev] [PATCH 1/2] winsys/svga: Update the vmwgfx_drm.h header to latest version from kernel

2014-04-07 Thread Thomas Hellstrom
On 04/07/2014 02:49 PM, Emil Velikov wrote: On 07/04/14 10:50, Thomas Hellstrom wrote: Cc: 10.1 mesa-sta...@lists.freedesktop.org Signed-off-by: Thomas Hellstrom thellst...@vmware.com Rather silly question: Why do you guys pull this header inside mesa and over using the one provided by

Re: [Mesa-dev] [PATCH 3/9] glsl: Make is_16bit_constant from i965 an ir_constant method.

2014-04-07 Thread Ian Romanick
On 04/06/2014 11:49 PM, Kenneth Graunke wrote: The i965 MUL instruction doesn't natively support 32-bit by 32-bit integer multiplication; additional instructions (MACH/MOV) are required. However, we can avoid those if we know one of the operands can be represented in 16 bits or less. The

Re: [Mesa-dev] [PATCH 7/9] glsl: Pass ctx-Const.NativeIntegers to do_common_optimization().

2014-04-07 Thread Ian Romanick
On 04/06/2014 11:49 PM, Kenneth Graunke wrote: diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cpp index 3bf2789..d8edc95 100644 --- a/src/glsl/linker.cpp +++ b/src/glsl/linker.cpp @@ -2298,7 +2298,7 @@ link_shaders(struct gl_context *ctx, struct gl_shader_program *prog)

[Mesa-dev] [PATCH] Partially revert st/xa: Fix advertized version number and try to avoid future discrepancies

2014-04-07 Thread Emil Velikov
This reverts commit 61bedc3d6b08943f015f9d590c07a6af36c2a92c. As the header is the one defining the API/ABI and is distributed during installation, we should be using it rather than re-defining the XA version in configure.ac. Bump the version in the header to 2.2.0, to reflect what was the

Re: [Mesa-dev] [PATCH 9/9] glsl: Convert mul/div by power-of-two factors to shift expressions.

2014-04-07 Thread Ian Romanick
On 04/06/2014 11:49 PM, Kenneth Graunke wrote: Integer shifts are basically always well supported and efficient; that isn't always true of integer division, and sometimes even integer multiplication isn't without issues. On some Intel hardware, INTDIV can't be used in SIMD16 mode. It also

Re: [Mesa-dev] [PATCH 1/9] i965: Fix SIMD16 unsupported messages via KHR_debug.

2014-04-07 Thread Ian Romanick
I made a couple random comments on several patches. I also like Ilia's suggestion on patch 3. Patches 1 through 8 (with Ilia's suggestion on 3) are Reviewed-by: Ian Romanick ian.d.roman...@intel.com I think patch 9 still needs some work for signed numerator handling in division. On 04/06/2014

Re: [Mesa-dev] [WIP 11/13] glsl: parser changes for GL_ARB_explicit_uniform_location

2014-04-07 Thread Ian Romanick
On 04/06/2014 10:27 PM, Tapani Pälli wrote: On 04/05/2014 12:58 AM, Ian Romanick wrote: On 04/04/2014 02:42 PM, Ian Romanick wrote: On 03/27/2014 11:45 PM, Tapani Pälli wrote: Patch adds a preprocessor define for the extension and stores explicit location data for uniforms during AST-HIR

Re: [Mesa-dev] [PATCH mesa/mesa] Hardcode the DRI driver extension as .so to match it's current uses.

2014-04-07 Thread Emil Velikov
On 07/04/14 13:05, Jon TURNEY wrote: On 06/04/2014 17:45, Emil Velikov wrote: IMHO if we're starting from scratch we should use the platform specific extensions consistently but neither suggestion matter in this case :'( Can you explain your reasoning? This seems to me to be a foolish

[Mesa-dev] [PATCH] build: force .so extension for the gallium dri modules

2014-04-07 Thread Emil Velikov
While linux uses .so as a default extension of a shared library that is not the case for other platforms. The loader in libGL (and others) assume that the dri module will always have a .so extension, thus it will fail to load it on some platforms. Spotted-by: Jon TURNEY

Re: [Mesa-dev] [PATCH 02/10] swrast: rename texture fetch functions (pt. 1)

2014-04-07 Thread Ian Romanick
On 04/05/2014 03:50 PM, Brian Paul wrote: Rename functions to match format names. sed commands: s/signed_rgba_rev/R8G8B8A8_SNORM/g s/signed_rgba/A8B8G8R8_SNORM/g s/f_rgba_rev/R8G8B8A_UNORM/g s/f_rgba/A8B8G8R8_UNORM/g s/f_rgbx_rev/R8G8B8X8_UNORM/g

Re: [Mesa-dev] [PATCH 01/10] mesa: rename stencil/Z functions in format_unpack.c

2014-04-07 Thread Ian Romanick
The series is Reviewed-by: Ian Romanick ian.d.roman...@intel.com On 04/05/2014 03:50 PM, Brian Paul wrote: So the function names match the format names. --- src/mesa/main/format_unpack.c | 80 - 1 file changed, 40 insertions(+), 40 deletions(-)

Re: [Mesa-dev] [PATCH 02/10] swrast: rename texture fetch functions (pt. 1)

2014-04-07 Thread Brian Paul
On 04/07/2014 09:17 AM, Ian Romanick wrote: On 04/05/2014 03:50 PM, Brian Paul wrote: Rename functions to match format names. sed commands: s/signed_rgba_rev/R8G8B8A8_SNORM/g s/signed_rgba/A8B8G8R8_SNORM/g s/f_rgba_rev/R8G8B8A_UNORM/g s/f_rgba/A8B8G8R8_UNORM/g

[Mesa-dev] [Bug 61750] Undefined references linking libGLESv2 when configured with --disable-dri

2014-04-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=61750 --- Comment #4 from Will Wagner wi...@carallon.com --- This appears to be a duplicate of bug 75098? -- You are receiving this mail because: You are the assignee for the bug. ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH] i965: Don't enable reset notification support on Gen4-5.

2014-04-07 Thread Ian Romanick
On 03/13/2014 08:15 AM, Mika Kuoppala wrote: Ian Romanick i...@freedesktop.org writes: On 03/12/2014 01:43 AM, Kenneth Graunke wrote: arekm reported that using Chrome with GPU acceleration enabled on GM45 triggered the hw_ctx != NULL assertion in brw_get_graphics_reset_status. We

Re: [Mesa-dev] [PATCH 1/2] i965/gs: Add dummy source to prepare_channel_masks instruction.

2014-04-07 Thread Eric Anholt
Kenneth Graunke kenn...@whitecape.org writes: On 04/04/2014 03:28 PM, Matt Turner wrote: The generator uses its destination as a source implicitly, which breaks some assumptions in dead code elimination. Giving the instruction a source allows us to reason about it better. ---

Re: [Mesa-dev] Mesa 10.2 release plan strawman

2014-04-07 Thread Eric Anholt
Ian Romanick i...@freedesktop.org writes: On 04/04/2014 05:52 PM, Matt Turner wrote: On Fri, Apr 4, 2014 at 5:18 PM, Ian Romanick i...@freedesktop.org wrote: Fast forwarding 3 months from the 10.1 release (March 4th, planned for February 28th) is May 30th. I'd like to propose the following

Re: [Mesa-dev] [PATCH] i965: fix MakeCurrent when switching a context between multiple drawables.

2014-04-07 Thread Eric Anholt
Iago Toral Quiroga ito...@igalia.com writes: Commit 11baad35088dfd4bdabc1710df650dbfb413e7a3 produces a regression when switching a single context between multiple drawables. The problem is that we check whether we have a viewport set to decide if we need to generate buffers for the drawble,

Re: [Mesa-dev] [PATCH 7/7] i965/fs: Check for interference after finding all channels.

2014-04-07 Thread Eric Anholt
Matt Turner matts...@gmail.com writes: It's more likely that we won't find writes to all channels than one will interfere, and calculating interference is more expensive. This change will also help prepare for coalescing load_payload instructions' operands. Also update the live intervals

[Mesa-dev] [PATCH] glsl: Use M_PI_* macros.

2014-04-07 Thread Matt Turner
Notice our multiple values for M_PI_2, which rounded ...32 up to ...4 and ...5. --- The float casts are ugly. I tried to define M_PI_2f using the preprocessor -- something like #define M_PI_2f M_PI_2##f but no luck. src/glsl/builtin_functions.cpp | 14 +++--- 1 file changed, 7

Re: [Mesa-dev] [PATCH] glsl: Use M_PI_* macros.

2014-04-07 Thread Aaron Watry
On Mon, Apr 7, 2014 at 12:19 PM, Matt Turner matts...@gmail.com wrote: Notice our multiple values for M_PI_2, which rounded ...32 up to ...4 and ...5. --- The float casts are ugly. I tried to define M_PI_2f using the preprocessor -- something like #define M_PI_2f M_PI_2##f but no luck.

Re: [Mesa-dev] [PATCH] glsl: Use M_PI_* macros.

2014-04-07 Thread Matt Turner
On Mon, Apr 7, 2014 at 10:28 AM, Aaron Watry awa...@gmail.com wrote: On Mon, Apr 7, 2014 at 12:19 PM, Matt Turner matts...@gmail.com wrote: Notice our multiple values for M_PI_2, which rounded ...32 up to ...4 and ...5. --- The float casts are ugly. I tried to define M_PI_2f using the

Re: [Mesa-dev] [PATCH 9/9] glsl: Convert mul/div by power-of-two factors to shift expressions.

2014-04-07 Thread Roland Scheidegger
Am 07.04.2014 15:52, schrieb Ian Romanick: On 04/06/2014 11:49 PM, Kenneth Graunke wrote: Integer shifts are basically always well supported and efficient; that isn't always true of integer division, and sometimes even integer multiplication isn't without issues. On some Intel hardware,

Re: [Mesa-dev] [PATCH] i965: glClearBuffer() should only clear a single buffer.

2014-04-07 Thread Eric Anholt
Iago Toral Quiroga ito...@igalia.com writes: glClearBuffer() is currently clearing all active draw color buffers (all buffers that have not been set to GL_NONE when calling glDrawBuffers) instead of only clearing the one it receives as parameter. Altough brw_clear() receives a bit mask

Re: [Mesa-dev] [PATCH 3/3] i965: Fix missing dirty bits in the gen8_sbe_state atom.

2014-04-07 Thread Eric Anholt
Kenneth Graunke kenn...@whitecape.org writes: These are clearly needed---the comments in the function are even present for each one of them. I originally had two separate state atoms for 3DSTATE_SBE and 3DSTATE_SBE_SWIZ. When I combined the functions, I must have forgotten to add the atoms

Re: [Mesa-dev] [PATCH] i965: Make sure we always compute valid index bounds before drawing.

2014-04-07 Thread Eric Anholt
Iago Toral Quiroga ito...@igalia.com writes: When doing software rendering (i.e. rendering to the selection buffer) we need to make sure that we have valid index bounds before calling _tnl_draw_prims(), otherwise we can crash. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=59455 ---

[Mesa-dev] [PATCH] i965: Add glBlitFramebuffer to commands affected by conditional rendering

2014-04-07 Thread Anuj Phogat
Fixes failures in Khronos OpenGL CTS test conditional_render_test9 Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- src/mesa/drivers/dri/i965/intel_fbo.c | 8 1 file changed, 8 insertions(+) diff --git a/src/mesa/drivers/dri/i965/intel_fbo.c b/src/mesa/drivers/dri/i965/intel_fbo.c

Re: [Mesa-dev] [PATCH 9/9] glsl: Convert mul/div by power-of-two factors to shift expressions.

2014-04-07 Thread Matt Turner
On Sun, Apr 6, 2014 at 11:49 PM, Kenneth Graunke kenn...@whitecape.org wrote: Integer shifts are basically always well supported and efficient; that isn't always true of integer division, and sometimes even integer multiplication isn't without issues. On some Intel hardware, INTDIV can't be

Re: [Mesa-dev] [PATCH 1/9] i965: Fix SIMD16 unsupported messages via KHR_debug.

2014-04-07 Thread Matt Turner
On Sun, Apr 6, 2014 at 11:49 PM, Kenneth Graunke kenn...@whitecape.org wrote: Performance warnings are logged via KHR_debug in addition to when the INTEL_DEBUG=perf environment variable is set. Without this, messages in debug contexts would have (null) for the reason. Signed-off-by: Kenneth

[Mesa-dev] [Bug 77152] New: libglapi.so: undefined reference to `entry_get_public'

2014-04-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77152 Priority: medium Bug ID: 77152 Keywords: regression CC: matts...@gmail.com Assignee: mesa-dev@lists.freedesktop.org Summary: libglapi.so: undefined reference to

Re: [Mesa-dev] [PATCH] glsl: Use M_PI_* macros.

2014-04-07 Thread Ian Romanick
On 04/07/2014 10:28 AM, Aaron Watry wrote: On Mon, Apr 7, 2014 at 12:19 PM, Matt Turner matts...@gmail.com wrote: Notice our multiple values for M_PI_2, which rounded ...32 up to ...4 and ...5. --- The float casts are ugly. I tried to define M_PI_2f using the preprocessor -- something like

Re: [Mesa-dev] Mesa 10.2 release plan strawman

2014-04-07 Thread Ian Romanick
On 04/07/2014 09:14 AM, Eric Anholt wrote: Ian Romanick i...@freedesktop.org writes: On 04/04/2014 05:52 PM, Matt Turner wrote: On Fri, Apr 4, 2014 at 5:18 PM, Ian Romanick i...@freedesktop.org wrote: Fast forwarding 3 months from the 10.1 release (March 4th, planned for February 28th) is

[Mesa-dev] [PATCH] i965/vec4: Add a test for copy propagation behavior.

2014-04-07 Thread Eric Anholt
I thought I was seeing a bug in the code while reviewing, but it's not there. --- src/mesa/drivers/dri/i965/.gitignore | 1 + src/mesa/drivers/dri/i965/Makefile.am | 7 + .../dri/i965/test_vec4_copy_propagation.cpp| 156 + 3 files

Re: [Mesa-dev] [PATCH] i965/vec4: fix record clearing in copy propagation

2014-04-07 Thread Eric Anholt
Chia-I Wu olva...@gmail.com writes: From: Chia-I Wu o...@lunarg.com Given mov vgrf7, vgrf9.xyxz add vgrf9.xyz, vgrf4.xyzw, vgrf5.xyzw add vgrf10.x, vgrf6.xyzw, vgrf7. the last instruction would be wrongly changed to add vgrf10.x, vgrf6.xyzw, vgrf9. during copy

[Mesa-dev] [PATCH 2/2] gallium/u_gen_mipmap: rewrite using pipe-blit (v2)

2014-04-07 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com This replaces u_gen_mipmap with an extremely simple implementation based on pipe-blit. st/mesa is also cleaned up. Pros: - less code - correct mipmap generation for NPOT 3D textures (u_blitter uses a better formula) - queries are not affected by mipmap

[Mesa-dev] [PATCH] swrast: Add glBlitFramebuffer to commands affected by conditional rendering

2014-04-07 Thread Anuj Phogat
Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- src/mesa/swrast/s_blit.c | 8 1 file changed, 8 insertions(+) diff --git a/src/mesa/swrast/s_blit.c b/src/mesa/swrast/s_blit.c index 1ba188c..e3b45f1 100644 --- a/src/mesa/swrast/s_blit.c +++ b/src/mesa/swrast/s_blit.c @@ -29,6 +29,7

[Mesa-dev] [PATCH] mesa: add bounds checking to eliminate buffer overrun

2014-04-07 Thread Courtney Goeltzenleuchter
Updated patch to include reference to bug that it resolves. Since this fixes a buffer overrun in the driver (found running GLBenchmark's Manhattan test) I think it would be a good candidate for the stable branch. ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH 2/2] gallium/u_gen_mipmap: rewrite using pipe-blit (v2)

2014-04-07 Thread Roland Scheidegger
Just a trivial comment, otherwise looks good to me. Thanks! Roland Am 07.04.2014 21:05, schrieb Marek Olšák: From: Marek Olšák marek.ol...@amd.com This replaces u_gen_mipmap with an extremely simple implementation based on pipe-blit. st/mesa is also cleaned up. Pros: - less code -

[Mesa-dev] [PATCH 02/12] mesa: add missing null checks in _tnl_register_fastpath()

2014-04-07 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com Reviewed-by: Matt Turner matts...@gmail.com --- src/mesa/tnl/t_vertex.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/src/mesa/tnl/t_vertex.c b/src/mesa/tnl/t_vertex.c index b3deac0..5a4bb0b

[Mesa-dev] [PATCH 00/12] Again Klocwork patches

2014-04-07 Thread Juha-Pekka Heikkila
Set of patches which mostly were here earlier, hope I did not this time miss any comments. #12 is new to the set. These pass Piglit quick tests with no regression on my Ivybridge. /Juha-Pekka Ian Romanick (1): mesa: Add _mesa_error_no_memory for logging out-of-memory messages Juha-Pekka

[Mesa-dev] [PATCH 03/12] mesa: add extra null checks in vbo_rebase_prims()

2014-04-07 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com Reviewed-by: Matt Turner matts...@gmail.com --- src/mesa/vbo/vbo_rebase.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/src/mesa/vbo/vbo_rebase.c b/src/mesa/vbo/vbo_rebase.c index f3fe5f7..374d129 100644

[Mesa-dev] [PATCH 01/12] mesa: Add _mesa_error_no_memory for logging out-of-memory messages

2014-04-07 Thread Juha-Pekka Heikkila
From: Ian Romanick ian.d.roman...@intel.com This can be called from locations that don't have a context pointer handy. This patch also adds enough infrastructure so that the unit tests for the GLSL compiler and the stand-alone compiler will build and function. This patch was originally signed

[Mesa-dev] [PATCH 06/12] glsl: add missing null check in tfeedback_decl::init()

2014-04-07 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/glsl/link_varyings.cpp | 5 + 1 file changed, 5 insertions(+) diff --git a/src/glsl/link_varyings.cpp b/src/glsl/link_varyings.cpp index c925c00..c3cc509 100644 --- a/src/glsl/link_varyings.cpp +++

[Mesa-dev] [PATCH 05/12] mesa: Add missing null checks into prog_hash_table.c

2014-04-07 Thread Juha-Pekka Heikkila
Check calloc return values in hash_table_insert() and hash_table_replace() Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/mesa/program/prog_hash_table.c | 8 1 file changed, 8 insertions(+) diff --git a/src/mesa/program/prog_hash_table.c

[Mesa-dev] [PATCH 07/12] mesa: add missing null check in _mesa_NewHashTable()

2014-04-07 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/mesa/main/hash.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/mesa/main/hash.c b/src/mesa/main/hash.c index 4c92005..976f7b8 100644 --- a/src/mesa/main/hash.c +++ b/src/mesa/main/hash.c @@ -115,10

[Mesa-dev] [PATCH 08/12] i965: check malloc return value in intel_resolve_map_set()

2014-04-07 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/mesa/drivers/dri/i965/intel_resolve_map.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/mesa/drivers/dri/i965/intel_resolve_map.c b/src/mesa/drivers/dri/i965/intel_resolve_map.c index 04b5c94..c5a4cd7 100644

Re: [Mesa-dev] Mesa 10.2 release plan strawman

2014-04-07 Thread Ian Romanick
On 04/07/2014 11:47 AM, Ian Romanick wrote: On 04/07/2014 09:14 AM, Eric Anholt wrote: Ian Romanick i...@freedesktop.org writes: On 04/04/2014 05:52 PM, Matt Turner wrote: On Fri, Apr 4, 2014 at 5:18 PM, Ian Romanick i...@freedesktop.org wrote: Fast forwarding 3 months from the 10.1 release

Re: [Mesa-dev] [PATCH] i965/vec4: Add a test for copy propagation behavior.

2014-04-07 Thread Ian Romanick
On 04/07/2014 11:51 AM, Eric Anholt wrote: I thought I was seeing a bug in the code while reviewing, but it's not there. One observation below. Regardless, Reviewed-by: Ian Romanick ian.d.roman...@intel.com --- src/mesa/drivers/dri/i965/.gitignore | 1 +

Re: [Mesa-dev] [PATCH] mesa: add bounds checking to eliminate buffer overrun

2014-04-07 Thread Ian Romanick
On 04/07/2014 12:19 PM, Courtney Goeltzenleuchter wrote: Updated patch to include reference to bug that it resolves. Where? The proper way to do this is to send the path with git-send-mail, and include extra verbage in the commit message like: v3: Updated patch to include reference to bug that

Re: [Mesa-dev] [PATCH 00/12] Again Klocwork patches

2014-04-07 Thread Juha-Pekka Heikkilä
Hmm... Wonder where my patches 9..12 vanished. They show in git send-email as Result: 250 ok: Message ### accepted. If they don't magically show up here I will resend entire set tomorrow from better connection. /Juha-Pekka On Mon, Apr 7, 2014 at 10:48 PM, Juha-Pekka Heikkila

Re: [Mesa-dev] [PATCH 00/12] Again Klocwork patches

2014-04-07 Thread Emil Velikov
On 07/04/14 21:06, Juha-Pekka Heikkilä wrote: Hmm... Wonder where my patches 9..12 vanished. They show in git send-email as Result: 250 ok: Message ### accepted. If they don't magically show up here I will resend entire set tomorrow from better connection. An innocent bystander type of

Re: [Mesa-dev] [PATCH] glsl: Use M_PI_* macros.

2014-04-07 Thread Matt Turner
On Mon, Apr 7, 2014 at 11:39 AM, Ian Romanick i...@freedesktop.org wrote: On 04/07/2014 10:28 AM, Aaron Watry wrote: On Mon, Apr 7, 2014 at 12:19 PM, Matt Turner matts...@gmail.com wrote: Notice our multiple values for M_PI_2, which rounded ...32 up to ...4 and ...5. --- The float casts are

[Mesa-dev] [PATCH] st/xa: Make sure unused samplers are set to NULL

2014-04-07 Thread Thomas Hellstrom
renderer_copy_prepare was setting the first sampler but never telling the cso code how many samplers were actually used. Fix this. Cc: 10.1 mesa-sta...@freedesktop.org Signed-off-by: Thomas Hellstrom thellst...@vmware.com --- src/gallium/state_trackers/xa/xa_renderer.c | 5 +++-- 1 file changed,

Re: [Mesa-dev] [PATCH] st/xa: Make sure unused samplers are set to NULL

2014-04-07 Thread Brian Paul
On 04/07/2014 02:48 PM, Thomas Hellstrom wrote: renderer_copy_prepare was setting the first sampler but never telling the cso code how many samplers were actually used. Fix this. Cc: 10.1 mesa-sta...@freedesktop.org Signed-off-by: Thomas Hellstrom thellst...@vmware.com ---

Re: [Mesa-dev] [PATCH 00/12] Again Klocwork patches

2014-04-07 Thread Juha-Pekka Heikkilä
On Mon, Apr 7, 2014 at 11:21 PM, Emil Velikov emil.l.veli...@gmail.com wrote: On 07/04/14 21:06, Juha-Pekka Heikkilä wrote: Hmm... Wonder where my patches 9..12 vanished. They show in git send-email as Result: 250 ok: Message ### accepted. If they don't magically show up here I will resend

Re: [Mesa-dev] [PATCH] i965: Don't enable reset notification support on Gen4-5.

2014-04-07 Thread Timo Aaltonen
On 12.03.2014 10:43, Kenneth Graunke wrote: arekm reported that using Chrome with GPU acceleration enabled on GM45 triggered the hw_ctx != NULL assertion in brw_get_graphics_reset_status. We definitely do not want to advertise reset notification support on Gen4-5 systems, since it needs

Re: [Mesa-dev] [PATCH 00/12] Again Klocwork patches

2014-04-07 Thread Emil Velikov
On 07/04/14 22:10, Juha-Pekka Heikkilä wrote: On Mon, Apr 7, 2014 at 11:21 PM, Emil Velikov emil.l.veli...@gmail.com wrote: On 07/04/14 21:06, Juha-Pekka Heikkilä wrote: Hmm... Wonder where my patches 9..12 vanished. They show in git send-email as Result: 250 ok: Message ### accepted. If

[Mesa-dev] [PATCH 04/12] mesa: In emit_texenv() type mismatch was forced with typecast

2014-04-07 Thread Juha-Pekka Heikkila
Type mismatch caused random memory to be copied when casted memory area was smaller than expected type. Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/mesa/main/ff_fragment_shader.cpp | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git

[Mesa-dev] [PATCH 09/12] mesa: add null checks in symbol_table.c

2014-04-07 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/mesa/program/symbol_table.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/src/mesa/program/symbol_table.c b/src/mesa/program/symbol_table.c index 9462978..5b22745 100644 ---

[Mesa-dev] [PATCH 11/12] glsl: check _mesa_hash_table_create return value in link_uniform_blocks

2014-04-07 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/glsl/link_uniform_blocks.cpp | 5 + 1 file changed, 5 insertions(+) diff --git a/src/glsl/link_uniform_blocks.cpp b/src/glsl/link_uniform_blocks.cpp index 72d6c53..add3ef4 100644 --- a/src/glsl/link_uniform_blocks.cpp

[Mesa-dev] [PATCH 12/12] i965/fs: Check variable_storage return value in fs_visitor::visit

2014-04-07 Thread Juha-Pekka Heikkila
check variable_storage() found the requested fs_reg. Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp

[Mesa-dev] [PATCH 10/12] glsl: Add null check in loop_analysis.cpp

2014-04-07 Thread Juha-Pekka Heikkila
Check return value from hash_table_find before using it as a pointer Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/glsl/loop_analysis.cpp | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/glsl/loop_analysis.cpp b/src/glsl/loop_analysis.cpp

Re: [Mesa-dev] Mesa 10.2 release plan strawman

2014-04-07 Thread Eric Anholt
Ian Romanick i...@freedesktop.org writes: On 04/07/2014 09:14 AM, Eric Anholt wrote: Ian Romanick i...@freedesktop.org writes: On 04/04/2014 05:52 PM, Matt Turner wrote: On Fri, Apr 4, 2014 at 5:18 PM, Ian Romanick i...@freedesktop.org wrote: Fast forwarding 3 months from the 10.1 release

[Mesa-dev] [Bug 77152] libglapi.so: undefined reference to `entry_get_public'

2014-04-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77152 Matt Turner matts...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED

Re: [Mesa-dev] [PATCH] mesa: add bounds checking to eliminate buffer overrun

2014-04-07 Thread Courtney Goeltzenleuchter
Hi Ian, I didn't think this even got out. I was getting a weird error from git-send-mail when it tried to send to the gmail server and I got distracted with other things. Here's log: Send this email? ([y]es|[n]o|[q]uit|[a]ll): y Password for 'smtp://court...@lunarg.com@smtp.gmail.com:587': OK.

[Mesa-dev] [PATCH 1/2] mesa: add bounds checking to eliminate buffer overrun

2014-04-07 Thread Courtney Goeltzenleuchter
Decompressing ETC2 textures was causing intermitent segfault by copying resulting 4x4 texel block to the destination texture regardless of the size of the destination texture. Issue found via application crash in GLBenchmark 3.0's Manhattan test. v2: add more explanatory comments v3: add bugzilla

Re: [Mesa-dev] [PATCH] mesa: add bounds checking to eliminate buffer overrun

2014-04-07 Thread Emil Velikov
On 08/04/14 01:18, Courtney Goeltzenleuchter wrote: Hi Ian, I didn't think this even got out. I was getting a weird error from git-send-mail when it tried to send to the gmail server and I got distracted with other things. Here's log: Send this email? ([y]es|[n]o|[q]uit|[a]ll): y

[Mesa-dev] [Bug 77161] New: [softpipe] piglit fbo-generatemipmap-cubemap S3TC_DXT1 regression

2014-04-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77161 Priority: medium Bug ID: 77161 Keywords: regression CC: mar...@gmail.com Assignee: mesa-dev@lists.freedesktop.org Summary: [softpipe] piglit fbo-generatemipmap-cubemap S3TC_DXT1

Re: [Mesa-dev] [PATCH] mesa: add bounds checking to eliminate buffer overrun

2014-04-07 Thread Courtney Goeltzenleuchter
Thanks Emil, I've got it sorted out I think. The format of the cc: was incorrect, it shouldn't have the mailto:... piece. Should look like: Cc: 9.2 10.0 10.1 mesa-sta...@lists.freedesktop.org I'll send out updated patch. Courtney On Mon, Apr 7, 2014 at 6:28 PM, Emil Velikov

[Mesa-dev] [PATCH] mesa: add bounds checking to eliminate buffer overrun

2014-04-07 Thread Courtney Goeltzenleuchter
Decompressing ETC2 textures was causing intermitent segfault by copying resulting 4x4 texel block to the destination texture regardless of the size of the destination texture. Issue found via application crash in GLBenchmark 3.0's Manhattan test. v2: add more explanatory comments v3: add bugzilla

Re: [Mesa-dev] [PATCH] Partially revert st/xa: Fix advertized version number and try to avoid future discrepancies

2014-04-07 Thread Thomas Hellstrom
Hi! Thanks, This looks good to me. Reviewed-by: Thomas Hellstrom thellst...@vmware.com /Thomas On 04/07/2014 03:45 PM, Emil Velikov wrote: This reverts commit 61bedc3d6b08943f015f9d590c07a6af36c2a92c. As the header is the one defining the API/ABI and is distributed during installation, we