On Sat, 2015-03-21 at 09:27 -0700, Jason Ekstrand wrote:
On Mar 21, 2015 2:49 AM, Timothy Arceri t_arc...@yahoo.com.au
wrote:
This series adds most of the remaining glsl arrays of arrays
support. Support for uniform blocks is still missing, I've played
around with this but don't have
This allows queries to return different numeric types.
Signed-off-by: Samuel Pitoiset samuel.pitoiset at gmail.com
---
src/gallium/auxiliary/hud/hud_driver_query.c| 3 ++-
src/gallium/drivers/freedreno/freedreno_query.c | 12 ++--
src/gallium/drivers/nouveau/nvc0/nvc0_query.c | 9
Hello,
A series I have waited too long to re-submit, but I recently refactored the
code and fixed some minor issues.
This patchset enables GL_AMD_performance_monitor for svga, freedreno, r600,
radeonsi and nvc0 drivers.
This code has been tested with Nouveau (NVD9 and NVE7) but it should also
This enables GL_AMD_performance_monitor for svga.
Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com
---
src/gallium/drivers/svga/svga_context.h | 1 +
src/gallium/drivers/svga/svga_screen.c | 11 +++
2 files changed, 12 insertions(+)
diff --git
According to the spec of GL_AMD_performance_monitor, valid type values
returned are UNSIGNED_INT, UNSIGNED_INT64_AMD, PERCENTAGE_AMD, FLOAT.
This also introduces the new field group_id in order to categorize
queries into groups.
v2: add PIPE_DRIVER_QUERY_TYPE_BYTES
Signed-off-by: Samuel Pitoiset
This enables GL_AMD_performance_monitor for freedreno.
Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com
Reviewed-by: Rob Clark robcl...@freedesktop.org
---
src/gallium/drivers/freedreno/freedreno_query.c | 9 +
src/gallium/drivers/freedreno/freedreno_query.h | 1 +
2 files
This will be used by GL_AMD_performance_monitor.
Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com
---
src/gallium/include/pipe/p_defines.h | 8
1 file changed, 8 insertions(+)
diff --git a/src/gallium/include/pipe/p_defines.h
b/src/gallium/include/pipe/p_defines.h
index
This enables GL_AMD_performance_monitor for radeon.
Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com
Reviewed-by: Marek Olšák marek.ol...@amd.com
---
src/gallium/drivers/radeon/r600_pipe_common.c | 9 +
src/gallium/drivers/radeon/r600_pipe_common.h | 1 +
2 files changed, 10
This function can be used to get a generic group of driver-specific
queries when a driver doesn't expose any groups.
Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com
---
src/gallium/auxiliary/Makefile.sources | 1 +
src/gallium/auxiliary/util/u_query.c | 50
GL_AMD_performance_monitor must return an error when a monitoring
session cannot be started.
Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com
---
src/gallium/drivers/freedreno/freedreno_query.c| 4 ++--
src/gallium/drivers/freedreno/freedreno_query.h| 2 +-
From: Christoph Bumiller e0425...@student.tuwien.ac.at
This is based on the original patch of Christoph Bumiller.
(source: http://people.freedesktop.org/~chrisbmr/perfmon.diff)
As for the Gallium HUD, we keep a list of busy queries in a ring
buffer in order to prevent stalls when reading
Driver queries are organized as a single hierarchy where queries are
categorized into groups. Each goup has a list of queries and a maximum
number of queries that can be sampled. The list of available groups can
be obtained using pipe_screen::get_driver_query_group_info.
This will be used by
GL_AMD_performance_monitor is supported by nvc0, svga, freedreno,
r600 and radeonsi.
Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com
---
docs/relnotes/10.6.0.html | 1 +
1 file changed, 1 insertion(+)
diff --git a/docs/relnotes/10.6.0.html b/docs/relnotes/10.6.0.html
index
This patch exposes Driver statistics and MP counters groups.
Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com
---
src/gallium/drivers/nouveau/nvc0/nvc0_query.c | 61 --
src/gallium/drivers/nouveau/nvc0/nvc0_screen.h | 11 +
2 files changed, 69 insertions(+),
This enables GL_AMD_performance_monitor for nvc0.
Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com
---
src/gallium/drivers/nouveau/nvc0/nvc0_query.c | 10 ++
src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 1 +
src/gallium/drivers/nouveau/nvc0/nvc0_screen.h | 3 +++
3 files
Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com
---
src/gallium/drivers/nouveau/nvc0/nvc0_query.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_query.c
b/src/gallium/drivers/nouveau/nvc0/nvc0_query.c
index
Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com
---
src/gallium/drivers/nouveau/nvc0/nvc0_query.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_query.c
b/src/gallium/drivers/nouveau/nvc0/nvc0_query.c
index
On Sat, Mar 14, 2015 at 09:54:27PM -0700, Jordan Justen wrote:
Add some values for gen7 gen8. These are the number threads in a
subslice.
Signed-off-by: Jordan Justen jordan.l.jus...@intel.com
Cc: Ben Widawsky b...@bwidawsk.net
Cc: Kenneth Graunke kenn...@whitecape.org
---
Hi all,
I've been working fixing the piglit tests around glDrawPixels, and I'm not
sure what the correct behaviour of glDrawPixels is when any texturing units
are enabled (tested with the draw-pixel-with-texture piglit test). After
asking on irc, imirkin suggested I bring the issue here as it
On Sat, 2015-03-21 at 19:57 -0400, Ilia Mirkin wrote:
On Sat, Mar 21, 2015 at 5:49 AM, Timothy Arceri t_arc...@yahoo.com.au wrote:
Add support for setting the max access of an unsized member
of an interface array of arrays.
For example ifc[j][k].foo[i] where foo is unsized.
---
The only hackish ones are llvmpipe and softpipe, which currently return
the same string as for get_vendor(), while ideally they should return
the CPU vendor.
Signed-off-by: Giuseppe Bilotta giuseppe.bilo...@gmail.com
Reviewed-by: Tom Stellard thomas.stell...@amd.com
---
The pipe's get_vendor method returns something more akin to a driver
vendor string in most cases, instead of the actual device vendor. Use
get_device_vendor instead, which was introduced specifically for this
purpose.
Signed-off-by: Giuseppe Bilotta giuseppe.bilo...@gmail.com
Reviewed-by: Michel
This will be needed by Clover to return the correct information
to CL_DEVICE_VENDOR info queries.
Signed-off-by: Giuseppe Bilotta giuseppe.bilo...@gmail.com
Reviewed-by: Michel Dänzer michel.daen...@amd.com
---
src/gallium/docs/source/screen.rst | 6 ++
src/gallium/include/pipe/p_screen.h
OpenCL (as opposed to OpenGL) has separate vendor strings for the
implementation/driver/platform and the device. CL_PLATFORM_VENDOR
is akin to the GL_VENDOR string, while CL_DEVICE_VENDOR is supposed to
return the actual device vendor.
(For example, the AMD OpenCL platform returns GenuineIntel as
Signed-off-by: Giuseppe Bilotta giuseppe.bilo...@gmail.com
Reviewed-by: Michel Dänzer michel.daen...@amd.com
---
src/gallium/include/pipe/p_screen.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/include/pipe/p_screen.h
b/src/gallium/include/pipe/p_screen.h
https://bugs.freedesktop.org/show_bug.cgi?id=89705
Vinson Lee v...@freedesktop.org changed:
What|Removed |Added
Keywords||bisected
--- Comment
On Sat, 2015-03-21 at 20:06 -0400, Ilia Mirkin wrote:
Patches 1, 2, 3, 4, 8, and 11 are Reviewed-by: Ilia Mirkin
imir...@alum.mit.edu
The rest I sent comments on, although even if you address my feedback,
I'm not sufficiently familiar to r-b at least some of them.
Thanks for the reviews.
git://people.freedesktop.org/~jljusten/mesa i965-barrier-v1
These have been tested with CS on gen7 gen8.
There is more glsl barrer() work with regards to control flow
requirements, but I think Chris already has some support for this in
his TS branch. (CS will require some tweaks to that as
Signed-off-by: Jordan Justen jordan.l.jus...@intel.com
Reviewed-by: Chris Forbes chr...@ijw.co.nz
---
src/mesa/drivers/dri/i965/brw_defines.h | 8
1 file changed, 8 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/brw_defines.h
b/src/mesa/drivers/dri/i965/brw_defines.h
index
Signed-off-by: Jordan Justen jordan.l.jus...@intel.com
Reviewed-by: Chris Forbes chr...@ijw.co.nz
---
src/mesa/drivers/dri/i965/brw_defines.h| 5 +
src/mesa/drivers/dri/i965/brw_fs.h | 3 +++
src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 11 +++
From: Chris Forbes chr...@ijw.co.nz
[jordan.l.jus...@intel.com: Add CS support]
Signed-off-by: Jordan Justen jordan.l.jus...@intel.com
---
src/glsl/builtin_functions.cpp | 29 +
1 file changed, 29 insertions(+)
diff --git a/src/glsl/builtin_functions.cpp
Signed-off-by: Jordan Justen jordan.l.jus...@intel.com
Reviewed-by: Chris Forbes chr...@ijw.co.nz
---
src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 4
1 file changed, 4 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp
b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp
index
From: Chris Forbes chr...@ijw.co.nz
[jordan.l.jus...@intel.com: Add nir support]
Signed-off-by: Jordan Justen jordan.l.jus...@intel.com
---
src/glsl/ir.h | 24
src/glsl/ir_hierarchical_visitor.cpp | 9 +
Signed-off-by: Jordan Justen jordan.l.jus...@intel.com
Reviewed-by: Chris Forbes chr...@ijw.co.nz
---
src/mesa/drivers/dri/i965/brw_disasm.c | 16
1 file changed, 16 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/brw_disasm.c
b/src/mesa/drivers/dri/i965/brw_disasm.c
index
This will be used by the wait instruction when implementing the barrier()
function.
Signed-off-by: Jordan Justen jordan.l.jus...@intel.com
Reviewed-by: Chris Forbes chr...@ijw.co.nz
---
src/mesa/drivers/dri/i965/brw_reg.h | 16
1 file changed, 16 insertions(+)
diff --git
These fields will be used when emitting a send for the barrier function.
Reference: IVB PRM Volume 4, Part 2, Section 1.1.1 Message Descriptor
Signed-off-by: Jordan Justen jordan.l.jus...@intel.com
Reviewed-by: Chris Forbes chr...@ijw.co.nz
---
src/mesa/drivers/dri/i965/brw_inst.h | 18
This will be used to implement the barrier function.
Signed-off-by: Jordan Justen jordan.l.jus...@intel.com
Reviewed-by: Chris Forbes chr...@ijw.co.nz
---
src/mesa/drivers/dri/i965/brw_eu.h | 2 ++
src/mesa/drivers/dri/i965/brw_eu_emit.c | 23 +++
2 files changed, 25
Signed-off-by: Jordan Justen jordan.l.jus...@intel.com
Reviewed-by: Chris Forbes chr...@ijw.co.nz
---
src/glsl/nir/glsl_to_nir.cpp | 4 +++-
src/glsl/nir/nir_intrinsics.h | 1 +
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/glsl/nir/glsl_to_nir.cpp
On Sun, Mar 22, 2015 at 6:49 PM, Jordan Justen
jordan.l.jus...@intel.com wrote:
From: Chris Forbes chr...@ijw.co.nz
[jordan.l.jus...@intel.com: Add nir support]
Signed-off-by: Jordan Justen jordan.l.jus...@intel.com
---
src/glsl/ir.h | 24
On Sun, Mar 22, 2015 at 6:49 PM, Jordan Justen
jordan.l.jus...@intel.com wrote:
This will be used by the wait instruction when implementing the barrier()
function.
Signed-off-by: Jordan Justen jordan.l.jus...@intel.com
Reviewed-by: Chris Forbes chr...@ijw.co.nz
---
On Sun, Mar 22, 2015 at 6:49 PM, Jordan Justen
jordan.l.jus...@intel.com wrote:
This will be used to implement the barrier function.
Signed-off-by: Jordan Justen jordan.l.jus...@intel.com
Reviewed-by: Chris Forbes chr...@ijw.co.nz
---
src/mesa/drivers/dri/i965/brw_eu.h | 2 ++
On Sun, Mar 22, 2015 at 6:49 PM, Jordan Justen
jordan.l.jus...@intel.com wrote:
This will be used to implement the Gateway Barrier SEND needed to implement
the barrier function.
Signed-off-by: Jordan Justen jordan.l.jus...@intel.com
Reviewed-by: Chris Forbes chr...@ijw.co.nz
---
Reviewed-by: Connor Abbott cwabbo...@gmail.com
On Sun, Mar 22, 2015 at 9:49 PM, Jordan Justen
jordan.l.jus...@intel.com wrote:
Signed-off-by: Jordan Justen jordan.l.jus...@intel.com
Reviewed-by: Chris Forbes chr...@ijw.co.nz
---
src/glsl/nir/glsl_to_nir.cpp | 4 +++-
Jordan,
You also need to set m0.2:15 (Barrier count enable) and m0.2:14-9
(Barrier count) to have the message gateway actually collect the
proper number of threads, right?
- Chris
On Mon, Mar 23, 2015 at 2:49 PM, Jordan Justen
jordan.l.jus...@intel.com wrote:
Signed-off-by: Jordan Justen
On Fri, Mar 20, 2015 at 5:23 PM, Jason Ekstrand ja...@jlekstrand.net wrote:
v2: Fix the spelling of analyze and re-arrange code for better readability
as per Connor's comments.
v3: Make the naming of things more consistent and add a pile of comments
---
On Mar 22, 2015 8:48 PM, Connor Abbott cwabbo...@gmail.com wrote:
On Fri, Mar 20, 2015 at 5:23 PM, Jason Ekstrand ja...@jlekstrand.net
wrote:
v2: Fix the spelling of analyze and re-arrange code for better
readability
as per Connor's comments.
v3: Make the naming of things more
On Sunday, March 22, 2015 12:39:25 PM Ben Widawsky wrote:
On Sat, Mar 14, 2015 at 09:54:27PM -0700, Jordan Justen wrote:
[snip]
@@ -225,7 +229,8 @@ static const struct brw_device_info
brw_device_info_hsw_gt3 = {
.max_hs_threads = 504, \
.max_ds_threads =
47 matches
Mail list logo
