[Mesa-dev] [PATCH] glsl: Copy propagate in array index function parameters

Copy propagate is not applied in function parameters when they are out or inout. But if the parameter is an array, we can copy propagate the index array. This also fixes several shaders@out-parameter-indexing piglit tests, that exposes a wrong handling of inout function parameters in Mesa. This

[Mesa-dev] [PATCH] configure.ac: error out when building from git without python3

From: Emil Velikov Bail early, as opposed to later on during the build. Signed-off-by: Emil Velikov --- configure.ac | 6 ++ 1 file changed, 6 insertions(+) diff --git a/configure.ac b/configure.ac index 5f75c60..0932871 100644 ---

Re: [Mesa-dev] [PATCH] egl/wayland: Avoid race conditions when on non-main thread

Hi Jonas, On 4 May 2016 at 09:53, Jonas Ådahl wrote: > When EGL is used on some other thread than the thread that drives the > main wl_display queue, the Wayland EGL dri2 implementation is > vulnerable to a race condition related to display round trips and global > object

Re: [Mesa-dev] [PATCH 12/15] i965: abort linking if URB read length greater than 15

On Wed, 2016-05-04 at 03:43 -0700, Kenneth Graunke wrote: > On Thursday, April 28, 2016 1:40:42 PM PDT Antia Puentes wrote: > > > > From: "Juan A. Suarez Romero" > > > > In scalar mode, URB read length limit is 15. Abort if we go beyond > > it. > > --- > >  

Re: [Mesa-dev] [PATCH 02/15] i965: Configure how to store *64*PASSTHRU vertex components

Hi Kenneth, thanks for reviewing. On mié, 2016-05-04 at 03:36 -0700, Kenneth Graunke wrote: > On Thursday, April 28, 2016 1:40:32 PM PDT Antia Puentes wrote: > > > > From the Broadwell specification, structure VERTEX_ELEMENT_STATE > > description: > > > >    "When SourceElementFormat is set to

Re: [Mesa-dev] [PATCH 32/59] i965/fs: optimize unpack double

On Mon, 2016-05-02 at 11:38 +0300, Pohjolainen, Topi wrote: > On Fri, Apr 29, 2016 at 01:29:29PM +0200, Samuel Iglesias Gons?lvez wrote: > > From: Iago Toral Quiroga > > > > When we are actually unpacking from a double that we have previously > > packed from its 32-bit

Re: [Mesa-dev] [PATCH 03/59] freedreno/ir3: lower lrp when operating with double operands

On Fri, Apr 29, 2016 at 7:29 AM, Samuel Iglesias Gonsálvez wrote: > Lower lrp when operating with double operands because float version of > lrp is also lowered. > > Signed-off-by: Samuel Iglesias Gonsálvez > CC: Rob Clark > --- >

Re: [Mesa-dev] [PATCH 12/15] i965: abort linking if URB read length greater than 15

On Thursday, April 28, 2016 1:40:42 PM PDT Antia Puentes wrote: > From: "Juan A. Suarez Romero" > > In scalar mode, URB read length limit is 15. Abort if we go beyond it. > --- > src/mesa/drivers/dri/i965/brw_vec4.cpp | 8 > 1 file changed, 8 insertions(+) > >

Re: [Mesa-dev] [PATCH 01/15] i965: get the proper vertex surface type for doubles on gen8+

On Thursday, April 28, 2016 1:40:31 PM PDT Antia Puentes wrote: > From: Alejandro Piñeiro > > This commit adds support for PASSTHRU format when pushing > double-precision attributes. > > Check glarray->Doubles in order to know if we should choose a format > that does a

Re: [Mesa-dev] [PATCH 03/59] freedreno/ir3: lower lrp when operating with double operands

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 This patch is still unreviewed. Rob, Can you take a look at it? Sam On 29/04/16 13:29, Samuel Iglesias Gonsálvez wrote: > Lower lrp when operating with double operands because float version > of lrp is also lowered. > > Signed-off-by: Samuel

Re: [Mesa-dev] [PATCH 06/23] i965/fs: fix copy/constant propagation regioning checks

On Tue, 2016-05-03 at 17:37 -0700, Jason Ekstrand wrote: > > > On Tue, May 3, 2016 at 5:21 AM, Samuel Iglesias Gonsálvez > wrote: > From: Iago Toral Quiroga > > We were not accounting for reg_suboffset in the check for the >

Re: [Mesa-dev] [PATCH 02/15] i965: Configure how to store *64*PASSTHRU vertex components

On Thursday, April 28, 2016 1:40:32 PM PDT Antia Puentes wrote: > From the Broadwell specification, structure VERTEX_ELEMENT_STATE > description: > >"When SourceElementFormat is set to one of the *64*_PASSTHRU > formats, 64-bit components are stored in the URB without any >

Re: [Mesa-dev] [PATCH] configure.ac: error out when building from git without python3

Only if building Intel vulkan, no? Could that script just be fixed to work with python2 BTW? On May 4, 2016 6:44 AM, "Emil Velikov" wrote: > From: Emil Velikov > > Bail early, as opposed to later on during the build. > > Signed-off-by: Emil

Re: [Mesa-dev] [PATCH 27/59] i965/fs: add a stride helper

On Wed, 2016-05-04 at 01:15 -0700, Francisco Jerez wrote: > Iago Toral writes: > > > On Mon, 2016-05-02 at 18:48 -0700, Francisco Jerez wrote: > >> Samuel Iglesias Gonsálvez writes: > >> > >> > From: Connor Abbott > >> > > >>

[Mesa-dev] [PATCH] egl/wayland: Avoid race conditions when on non-main thread

When EGL is used on some other thread than the thread that drives the main wl_display queue, the Wayland EGL dri2 implementation is vulnerable to a race condition related to display round trips and global object advertisements. The race that may happen is that after after a proxy is created, but

Re: [Mesa-dev] [PATCH 31/59] i965/fs: optimize pack double

On Mon, 2016-05-02 at 15:11 -0400, Connor Abbott wrote: > On Fri, Apr 29, 2016 at 7:29 AM, Samuel Iglesias Gonsálvez > wrote: > > From: Iago Toral Quiroga > > > > When we are actually creating a double using values obtained from a > > previous unpack

Re: [Mesa-dev] [PATCH] swr: Fix resource leak in object.

After shader compilation, the gallivm_state is owned by ShaderVariant<> and destroyed by its destructor (swr_state.h) so that the generated JIT code and gallivm_state can be freed when no longer needed. > On May 3, 2016, at 5:45 PM, robert.f...@collabora.com wrote: > > From: Robert Foss

Re: [Mesa-dev] [PATCH 00/59] Initial arb_gpu_shader_fp64 support to the i965 scalar backend

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 03/05/16 20:59, Kenneth Graunke wrote: > Other than patches 37, 56, and ones you agreed to drop, the series > is: Reviewed-by: Kenneth Graunke > > I think you can go ahead and land all except those, and we can > land

[Mesa-dev] [PATCH v3] vulkan: Fix use of uninitialized variable.

From: Robert Foss The return variable was not set for failure paths. It has now been changed to VK_ERROR_INITIALIZATION_FAILED for failure paths. Coverity: 1358944 Reviewed-by: Eric Engestrom Signed-off-by: Robert Foss

Re: [Mesa-dev] [PATCH v2 03/25] anv: tweak the %.json rule

On fredag 22. april 2016 19.55.10 CEST Emil Velikov wrote: > From: Emil Velikov > > It's used only by dev_icd.json so just call it that way. While we're > here, manually expand $< (as it might cause issue on some systems) > and drop the unneeded install_libdir

Re: [Mesa-dev] [PATCHv2 10/23] i965/fs: Stop using the LOAD_PAYLOAD instruction in lower_simd_width.

Hi Curro, Am 04.05.2016 um 06:26 schrieb Francisco Jerez: > Instead of using the LOAD_PAYLOAD instruction (emitted through the > emit_transpose() helper that is no longer useful and this commit > removes) which had to be marked force_writemask_all in some cases, > emit a series of moves to apply

[Mesa-dev] [PATCH] anv: fix hang during generation of dev_icd.json.

--- src/intel/vulkan/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/Makefile.am b/src/intel/vulkan/Makefile.am index fd8aae0..662d720 100644 --- a/src/intel/vulkan/Makefile.am +++ b/src/intel/vulkan/Makefile.am @@ -156,7 +156,7 @@ noinst_DATA =

Re: [Mesa-dev] [PATCH] swr: Fix resource leak in object.

On 05/04/2016 08:52 AM, Rowley, Timothy O wrote: After shader compilation, the gallivm_state is owned by ShaderVariant<> and destroyed by its destructor (swr_state.h) so that the generated JIT code and gallivm_state can be freed when no longer needed. Oh. Splendid. Thanks for looking into

Re: [Mesa-dev] [PATCH] configure.ac: error out when building from git without python3

On 4 May 2016 at 13:08, Ilia Mirkin wrote: > Only if building Intel vulkan, no? I believe the idea is to move from python2 so this will do no harm as is. > Could that script just be fixed to work > with python2 BTW? > Possibly. The above 'moving away from python2' topic

Re: [Mesa-dev] [PATCH 01/15] i965: get the proper vertex surface type for doubles on gen8+

On 04/05/16 12:31, Kenneth Graunke wrote: > On Thursday, April 28, 2016 1:40:31 PM PDT Antia Puentes wrote: >> From: Alejandro Piñeiro >> >> This commit adds support for PASSTHRU format when pushing >> double-precision attributes. >> >> Check glarray->Doubles in order to

[Mesa-dev] [PATCH v2] vulkan: Fix use of uninitialized variable.

From: Robert Foss The return variable was not set for failure paths. It has now been changed to VK_ERROR_INITIALIZATION_FAILED for failure paths. Coverity: 1358944 Signed-off-by: Robert Foss --- Changes since v1: - Started using

Re: [Mesa-dev] [PATCH v2] nir: fix assert for wildcard pairs

On Wed, May 4, 2016 at 7:46 AM, Eduardo Lima Mitev wrote: > Good catch! > > Reviewed-by: Eduardo Lima Mitev > Thanks! I do not have commit access. Can I ask you to push? > > On 05/04/2016 05:48 AM, Thomas Hindoe Paaboel Andersen wrote: > > The assert was

Re: [Mesa-dev] [PATCH] i965/fs: Don't follow pow with an instruction with two dest regs.

Matt Turner writes: > Beginning with commit 7b208a73, Unigine Valley began hanging the GPU on > Gen >= 8 platforms. > > Evidently that commit allowed the scheduler to make different choices > that somehow finally ran afoul of a hardware bug in which POW and FDIV >

Re: [Mesa-dev] [PATCH 1/4] i965/fs: Merge nir_emit_texture and emit_texture

On Tuesday, May 3, 2016 3:00:24 PM PDT Jason Ekstrand wrote: > The fs_visitor::emit_texture helper originated when we still had both NIR > and IR visitors for the FS backend. Since the old visitor was removed, > emit_texture serves no real purpose beyond arbitrarily splitting > heavily-linked

[Mesa-dev] [PATCH 2/2] i965/borp: Don't blend integer values during MSAA resolves

--- src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 30 ++-- 1 file changed, 19 insertions(+), 11 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp_blit.cpp b/src/mesa/drivers/dri/i965/brw_blorp_blit.cpp index 882f9ed..dc68eab 100644 ---

[Mesa-dev] [PATCH 1/2] meta/blit: Don't blend integer values during MSAA resolves

--- src/mesa/drivers/common/meta_blit.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/common/meta_blit.c b/src/mesa/drivers/common/meta_blit.c index 6761238..bb79c46 100644 --- a/src/mesa/drivers/common/meta_blit.c +++

Re: [Mesa-dev] [PATCH 3/3] mesa: remove null check before free

On Wed, May 4, 2016 at 7:54 AM, Eduardo Lima Mitev wrote: > Patch 2 and 3 are: > > Reviewed-by: Eduardo Lima Mitev > Thanks! I do not have commit access. Can I ask you to push (again)? > > I barely know about coccinelle scripts so I will let others look at

Re: [Mesa-dev] [PATCH 37/59] i965/fs: generalize SIMD16 interference workaround

On Curro's suggestion, I tried reproducing the problem that the patch fixes. Not only could I not reproduce it, but it seems like the original workaround that Jason added back when he reworked the fs backend ages ago is unnecessary at least on my ivybridge and broadwell machines. Since reproducing

[Mesa-dev] [PATCH 05/14] gallium/radeon: implement randomized SDMA texture copy testing (v2)

From: Marek Olšák v2: - adjustments for exercising all important SDMA code paths - decrease the probability of getting huge sizes (faster testing) - increase the probability of getting power-of-two dimensions - change the memory cap to 128MB (faster testing)

[Mesa-dev] [PATCH 03/14] gallium/radeon: use a common function for DMA blit preparation

From: Marek Olšák this is more robust and probably fixes some bugs already --- src/gallium/drivers/r600/evergreen_state.c| 10 ++--- src/gallium/drivers/r600/r600_state.c | 5 ++- src/gallium/drivers/radeon/r600_pipe_common.h | 7

[Mesa-dev] [PATCH 02/14] gallium/radeon: split out code for discarding DCC

From: Marek Olšák --- src/gallium/drivers/radeon/r600_texture.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_texture.c b/src/gallium/drivers/radeon/r600_texture.c index 6df013a..ac11380 100644 ---

[Mesa-dev] [PATCH 04/14] gallium/radeon: discard CMASK or DCC if overwriting a whole texture by DMA

From: Marek Olšák --- src/gallium/drivers/radeon/r600_texture.c | 46 ++- 1 file changed, 39 insertions(+), 7 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_texture.c b/src/gallium/drivers/radeon/r600_texture.c index 0dba045..d6d95af

[Mesa-dev] [PATCH 06/14] radeonsi: only expose *_init_*dma_functions from (S)DMA files

From: Marek Olšák just normalizing the interfaces --- src/gallium/drivers/radeonsi/cik_sdma.c | 19 --- src/gallium/drivers/radeonsi/si_dma.c | 19 --- src/gallium/drivers/radeonsi/si_pipe.c | 5 +

[Mesa-dev] [PATCH 07/14] radeonsi: remove SDMA texture copy code

From: Marek Olšák Most of this has never worked according to the new test. The new code will be radically different. --- src/gallium/drivers/radeonsi/cik_sdma.c | 217 +--- 1 file changed, 2 insertions(+), 215 deletions(-) diff --git

[Mesa-dev] [PATCH 08/14] radeonsi: raise the max size for SDMA buffer copies

From: Marek Olšák --- src/gallium/drivers/radeonsi/cik_sdma.c | 4 ++-- src/gallium/drivers/radeonsi/sid.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/radeonsi/cik_sdma.c b/src/gallium/drivers/radeonsi/cik_sdma.c index

[Mesa-dev] [PATCH 10/14] radeonsi: add new SDMA texture copy code

From: Marek Olšák This implements: - Linear-to-linear partial copies. (unaligned) - Tiled-to-linear and linear-to-tiled partial copies. (unaligned except 1-2 Bpp) - Tiled-to-tiled partial copies aligned to 8x8. --- src/gallium/drivers/radeonsi/cik_sdma.c | 436

[Mesa-dev] [PATCH 01/14] gallium/radeon: rename r600_texture_disable_cmask -> discard_cmask

From: Marek Olšák because it doesn't decompress --- src/gallium/drivers/radeon/r600_texture.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_texture.c b/src/gallium/drivers/radeon/r600_texture.c index

[Mesa-dev] [PATCH 00/14] RadeonSI: SDMA texture copy rewrite

Hi, This patch series completely rewrites texture copying with SDMA for CIK & VI. It only uses the "partial" copy packets, which makes it a lot simpler (one packet per layered/3D copy). Most of the complexity is in handling hw limitations, but luckily the SDMA path can be used in the majority

Re: [Mesa-dev] [PATCH 1/3] i965/fs: Add and use get_nir_src_imm().

On Wednesday, May 4, 2016 3:54:12 PM PDT Matt Turner wrote: > Terrible name. Suggest something else, or even a better way to do this. > > Basically, the next patch wants to inspect the LOD argument and do > something different if it's 0.0f. But at that point we've emitted a MOV > for it and we

[Mesa-dev] [PATCH 1/2] mesa/compute: move compute checks around for tests.

From: Dave Airlie This fixes GL43-CTS.compute_shader.api-indirect which tests the length/4 before anything else. Signed-off-by: Dave Airlie --- src/mesa/main/api_validate.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[Mesa-dev] [PATCH 2/2] mesa/compute: drop pointless casts.

From: Dave Airlie We already are a GLintptr, casting won't help. Signed-off-by: Dave Airlie --- src/mesa/main/api_validate.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/api_validate.c

Re: [Mesa-dev] [PATCH 3/3] i965/fs: Recognize and emit ld_lz, sample_lz, sample_c_lz.

On Wednesday, May 4, 2016 3:54:14 PM PDT Matt Turner wrote: > Ken suggested instead of a big and complicated optimization pass, to > just recognize the operations here. It's certainly less code and a lot > prettier, but it seems to actually perform worse for currently unknown > reasons. One

Re: [Mesa-dev] [PATCH 2/3] i965: Add infrastucture for sample lod-zero operations.

On Wednesday, May 4, 2016 3:54:13 PM PDT Matt Turner wrote: > --- > src/mesa/drivers/dri/i965/brw_defines.h | 5 + > src/mesa/drivers/dri/i965/brw_disasm.c | 3 +++ > src/mesa/drivers/dri/i965/brw_fs.cpp| 3 +++ >

[Mesa-dev] [PATCH] i965/fs: Don't follow pow with an instruction with two dest regs.

Beginning with commit 7b208a73, Unigine Valley began hanging the GPU on Gen >= 8 platforms. Evidently that commit allowed the scheduler to make different choices that somehow finally ran afoul of a hardware bug in which POW and FDIV instructions may not be followed by an instruction with two

[Mesa-dev] [PATCH 11/14] gallium/radeon: flush if DMA IB memory usage is too high

From: Marek Olšák This prevents IB rejections due to insane memory usage from many concecutive texture uploads. --- src/gallium/drivers/r600/evergreen_hw_context.c | 2 +- src/gallium/drivers/r600/evergreen_state.c | 2 +- src/gallium/drivers/r600/r600_hw_context.c

[Mesa-dev] [PATCH 12/14] gallium/radeon: add a heuristic for better (S)DMA performance

From: Marek Olšák --- src/gallium/drivers/radeon/r600_pipe_common.c | 16 src/gallium/drivers/radeon/radeon_winsys.h| 2 ++ src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 8 src/gallium/winsys/radeon/drm/radeon_drm_cs.c | 8 4

[Mesa-dev] [PATCH 09/14] gallium/radeon: fix (S)DMA read-after-write hazards

From: Marek Olšák --- src/gallium/drivers/r600/evergreen_hw_context.c | 1 + src/gallium/drivers/r600/evergreen_state.c | 1 + src/gallium/drivers/r600/r600_hw_context.c | 1 + src/gallium/drivers/r600/r600_state.c | 1 +

[Mesa-dev] [PATCH 14/14] gallium/radeon: don't flush the GFX IB if DMA doesn't depend on it

From: Marek Olšák --- src/gallium/drivers/radeon/r600_pipe_common.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_pipe_common.c b/src/gallium/drivers/radeon/r600_pipe_common.c index 3eb12f3..4845587 100644

[Mesa-dev] [PATCH 13/14] radeonsi: consolidate radeon_add_to_buffer_list calls for DMA

From: Marek Olšák --- src/gallium/drivers/radeon/r600_pipe_common.c | 14 ++ src/gallium/drivers/radeonsi/cik_sdma.c | 23 --- src/gallium/drivers/radeonsi/si_dma.c | 10 -- 3 files changed, 14 insertions(+), 33

Re: [Mesa-dev] [PATCH] main: uses casts to silence some _mesa_debug() format warnings

Reviewed-by: Sinclair Yeh On Mon, May 02, 2016 at 07:15:11PM -0600, Brian Paul wrote: > Silences warnings with 32-bit Linux gcc builds and MinGW which doesn't > recognize the ‘t’ conversion character. > --- > src/mesa/main/bufferobj.c | 10 ++ > 1 file changed, 6

[Mesa-dev] [RFC demos] a mesa equivalent to vulkaninfo

Hi, some weeks ago Dave Airlie made the review for the ARB_internalformat_query2 extension support (again, thanks a lot), and at the end he suggested to create a "mesa-demos glxinfo super query app. Something that does what vulkaninfo kinda does" [1]. As I mentioned at the moment, I had a heavily

Re: [Mesa-dev] [PATCH 08/11] glapi: Harden GLX request size processing

On Mon, 2016-03-28 at 11:10 -0700, Ian Romanick wrote: > > @@ -428,7 +428,7 @@ class PrintGlxReqSize_h(PrintGlxReqSize_common): >   def printBody(self, api): > >  for func in api.functionIterateGlx(): > >  if not func.ignore and func.has_variable_size_request(): > > -  

Re: [Mesa-dev] [PATCH] swr: Remove stall waiting for core query counters.

Reviewed-By: George Kyriazis > -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of BruceCherniak > Sent: Thursday, April 28, 2016 12:13 PM > To: mesa-dev@lists.freedesktop.org > Subject: [Mesa-dev] [PATCH] swr:

[Mesa-dev] About tolerance calculation on specific (builtin) functions

Hi, as part of the work done to "Add FP64 support to the i965 shader backends" at: https://bugs.freedesktop.org/show_bug.cgi?id=92760 I've been working to add piglit tests that would check the new features added by this addition. Due to this, I've been checking and making modifications into the

Re: [Mesa-dev] [RFC] add MAINTAINERS and get_maintainer.pl script

On Wed, May 4, 2016 at 1:04 PM, Eric Engestrom wrote: > On Tue, May 03, 2016 at 11:11:56AM -0400, Rob Clark wrote: >> >> Ok, I've renamed to REVIEWERS and scripts/get_reviewer.pl and updated >> the verbage appropriately. > > scripts/get_reviewer.pl still obeys

Re: [Mesa-dev] About tolerance calculation on specific (builtin) functions

On Wed, May 4, 2016 at 1:05 PM, Andres Gomez wrote: > Hi, > > as part of the work done to "Add FP64 support to the i965 shader > backends" at: > https://bugs.freedesktop.org/show_bug.cgi?id=92760 > > I've been working to add piglit tests that would check the new features >

[Mesa-dev] [Bug 95266] Geometry missing from rendering, only when using Mesa.

https://bugs.freedesktop.org/show_bug.cgi?id=95266 Bug ID: 95266 Summary: Geometry missing from rendering, only when using Mesa. Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW

Re: [Mesa-dev] About tolerance calculation on specific (builtin) functions

On Wed, May 4, 2016 at 1:41 PM, Connor Abbott wrote: > On Wed, May 4, 2016 at 1:05 PM, Andres Gomez wrote: >> Hi, >> >> as part of the work done to "Add FP64 support to the i965 shader >> backends" at: >> https://bugs.freedesktop.org/show_bug.cgi?id=92760

Re: [Mesa-dev] [RFC] add MAINTAINERS and get_maintainer.pl script

On Tue, May 03, 2016 at 11:11:56AM -0400, Rob Clark wrote: > > Ok, I've renamed to REVIEWERS and scripts/get_reviewer.pl and updated > the verbage appropriately. scripts/get_reviewer.pl still obeys .get_maintainer.conf and .get_maintainer.ignore. Is that something we want to make more

Re: [Mesa-dev] About tolerance calculation on specific (builtin) functions

On Wed, May 4, 2016 at 10:05 AM, Andres Gomez wrote: > Hi, > > as part of the work done to "Add FP64 support to the i965 shader > backends" at: > https://bugs.freedesktop.org/show_bug.cgi?id=92760 > > I've been working to add piglit tests that would check the new features >

[Mesa-dev] [PATCH] mesa/ubo: add missing compute cases for ubo/atomic buffers

From: Dave Airlie This fixes: GL43-CTS.compute_shader.resource-ubo Signed-off-by: Dave Airlie --- src/mesa/main/uniforms.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/mesa/main/uniforms.c b/src/mesa/main/uniforms.c index

[Mesa-dev] [PATCH] radeonsi: set DECOMPRESS_Z_ON_FLUSH if nr_samples >= 4

From: Marek Olšák Vulkan always sets this. It only affects in-place Z decompression. This is recommended for performance, but what app uses MSAA depth texturing? --- src/gallium/drivers/radeonsi/si_state.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 2/3] i965: Add infrastucture for sample lod-zero operations.

--- src/mesa/drivers/dri/i965/brw_defines.h | 5 + src/mesa/drivers/dri/i965/brw_disasm.c | 3 +++ src/mesa/drivers/dri/i965/brw_fs.cpp| 3 +++ src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 14 ++

[Mesa-dev] [PATCH 3/3] i965/fs: Recognize and emit ld_lz, sample_lz, sample_c_lz.

Ken suggested instead of a big and complicated optimization pass, to just recognize the operations here. It's certainly less code and a lot prettier, but it seems to actually perform worse for currently unknown reasons. total instructions in shared programs: 8514403 -> 8495373 (-0.22%)

[Mesa-dev] [PATCH 1/3] i965/fs: Add and use get_nir_src_imm().

Terrible name. Suggest something else, or even a better way to do this. Basically, the next patch wants to inspect the LOD argument and do something different if it's 0.0f. But at that point we've emitted a MOV for it and we just have a register to look at. --- This is an alternative approach to

Re: [Mesa-dev] [PATCH] st/nine: clean up WINAPI definition

On Sun, May 1, 2016 at 12:02 PM, Emil Velikov wrote: > Hi Christian, > > On 29 April 2016 at 19:53, Christian Schmidbauer > wrote: >> As Emil pointed out, only gcc, clang and MSVC compatibility is required. >> Hence the check for GNUC can be

[Mesa-dev] [PATCH 1/6] glapi: Fix whitespace droppings when printing the license header

Signed-off-by: Adam Jackson --- src/mapi/glapi/gen/gl_XML.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/gl_XML.py b/src/mapi/glapi/gen/gl_XML.py index 2e7123e..e11f6fc 100644 --- a/src/mapi/glapi/gen/gl_XML.py +++

[Mesa-dev] [Bug 95266] Geometry missing from rendering, only when using Mesa.

https://bugs.freedesktop.org/show_bug.cgi?id=95266 Ilia Mirkin changed: What|Removed |Added Attachment #123465|text/plain |application/bzip2

[Mesa-dev] [Bug 95266] Geometry missing from rendering, only when using Mesa.

https://bugs.freedesktop.org/show_bug.cgi?id=95266 --- Comment #2 from Ilia Mirkin --- You might consider including an apitrace that reproduces the issue. People are probably going to be less inclined to run some random binary off the interwebs. Also, is this only a bug

[Mesa-dev] [Bug 95266] Geometry missing from rendering, only when using Mesa.

https://bugs.freedesktop.org/show_bug.cgi?id=95266 --- Comment #3 from David Lonie --- I included an apitrace on the last bug, and was told that it was not suitable for reproducing bugs (something about apitrace forcing a 4.5 context IIRC). I can make one for this issue

[Mesa-dev] [Bug 95266] Geometry missing from rendering, only when using Mesa.

https://bugs.freedesktop.org/show_bug.cgi?id=95266 --- Comment #4 from Ilia Mirkin --- (In reply to David Lonie from comment #3) > I included an apitrace on the last bug, and was told that it was not > suitable for reproducing bugs (something about apitrace forcing a 4.5 >

Re: [Mesa-dev] [PATCH 02/15] i965: Configure how to store *64*PASSTHRU vertex components

On Wednesday, May 4, 2016 1:01:33 PM PDT Antía Puentes wrote: > Hi Kenneth, > > thanks for reviewing. > > On mié, 2016-05-04 at 03:36 -0700, Kenneth Graunke wrote: > > On Thursday, April 28, 2016 1:40:32 PM PDT Antia Puentes wrote: > > > > > > From the Broadwell specification, structure

[Mesa-dev] [PATCH 5/6] glapi: Define PURE for Sun Studio as well

Signed-off-by: Adam Jackson --- src/mapi/glapi/gen/gl_XML.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/gl_XML.py b/src/mapi/glapi/gen/gl_XML.py index 4f35343..8036a02 100644 --- a/src/mapi/glapi/gen/gl_XML.py +++

[Mesa-dev] [PATCH 4/6] glapi/glx: Mark byteswap functions as _X_UNUSED (v2)

Squashes the one remaining warning in the xserver build. v2: Also clean up some non-standard whitespace (Ian Romanick) Reviewed-by: Ian Romanick Signed-off-by: Adam Jackson --- src/mapi/glapi/gen/glX_proto_recv.py | 12 ++-- 1 file changed, 6

[Mesa-dev] [PATCH 3/6] glapi: Harden GLX request size processing (v2)

v2: Use == not is for equality testing (Dylan Baker) Signed-off-by: Adam Jackson --- src/mapi/glapi/gen/glX_XML.py| 2 +- src/mapi/glapi/gen/glX_proto_recv.py | 2 -- src/mapi/glapi/gen/glX_proto_send.py | 2 -- src/mapi/glapi/gen/glX_proto_size.py | 24

[Mesa-dev] [PATCH 2/6] glapi: Add the safe_{add, mul, pad} functions from xserver

We're about to update the generator scripts to use these, easier not to vary between client and server. Signed-off-by: Adam Jackson --- src/mapi/glapi/gen/glX_proto_send.py | 24 1 file changed, 24 insertions(+) diff --git

[Mesa-dev] [PATCH 0/6] Update generated GLX server code

Another attempt at syncing the GLX generator scripts with xserver. Jon mentioned a couple of issues in the last series, namely that these two patches were still necessary: https://lists.x.org/archives/xorg-devel/2014-April/041597.html

[Mesa-dev] [PATCH 6/6] glapi/gen: Copy some GL 1.0 enum details into ARB_viewport_array

Otherwise the instances in the extension XML override the core definitions, and we stop knowing their sizes in indirect_size_get.c Signed-off-by: Adam Jackson --- src/mapi/glapi/gen/ARB_viewport_array.xml | 16 1 file changed, 12 insertions(+), 4 deletions(-)

[Mesa-dev] [Bug 95266] Geometry missing from rendering, only when using Mesa.

https://bugs.freedesktop.org/show_bug.cgi?id=95266 --- Comment #5 from Ilia Mirkin --- FWIW I was able to run your trace from the other bug with MESA_GL_VERSION_OVERRIDE=4.5 MESA_GLSL_VERSION_OVERRIDE=450 so I suspect that a trace of this issue would be nice to have as

Re: [Mesa-dev] [PATCH 01/15] i965: get the proper vertex surface type for doubles on gen8+

On Wednesday, May 4, 2016 3:30:13 PM PDT Alejandro Piñeiro wrote: > > On 04/05/16 12:31, Kenneth Graunke wrote: > > On Thursday, April 28, 2016 1:40:31 PM PDT Antia Puentes wrote: > >> From: Alejandro Piñeiro > >> > >> This commit adds support for PASSTHRU format when

[Mesa-dev] [Bug 94955] Uninitialized variables leads to random segfaults (valgrind log, apitrace attached)

https://bugs.freedesktop.org/show_bug.cgi?id=94955 --- Comment #23 from David Lonie --- Opened a new bug: https://bugs.freedesktop.org/show_bug.cgi?id=95266 Feel free to close this one. -- You are receiving this mail because: You are the QA Contact for the bug. You

[Mesa-dev] [Bug 95266] Geometry missing from rendering, only when using Mesa.

https://bugs.freedesktop.org/show_bug.cgi?id=95266 --- Comment #1 from David Lonie --- The "Reproduction of issue" attachment is a tar.bz2 file, btw. When I try to download it it just dumps the binary as character data to my browser...Let me know if I should re-upload it

Re: [Mesa-dev] About tolerance calculation on specific (builtin) functions

Andres Gomez writes: > Hi, > > as part of the work done to "Add FP64 support to the i965 shader > backends" at: > https://bugs.freedesktop.org/show_bug.cgi?id=92760 > > I've been working to add piglit tests that would check the new features > added by this addition. > > Due to

Re: [Mesa-dev] About tolerance calculation on specific (builtin) functions

On Wed, 2016-05-04 at 13:48 -0400, Ilia Mirkin wrote: > On Wed, May 4, 2016 at 1:41 PM, Connor Abbott > wrote: > > > > On Wed, May 4, 2016 at 1:05 PM, Andres Gomez > > wrote: > > > > > > Hi, > > > > > > as part of the work done to "Add FP64 support to

[Mesa-dev] [Bug 95266] Geometry missing from rendering, only when using Mesa.

https://bugs.freedesktop.org/show_bug.cgi?id=95266 --- Comment #6 from Jose Fonseca --- (In reply to David Lonie from comment #3) > I included an apitrace on the last bug, and was told that it was not > suitable for reproducing bugs (something about apitrace forcing a 4.5 >

Re: [Mesa-dev] [PATCH] st/nine: clean up WINAPI definition

On Sun, May 1, 2016 at 6:03 PM, Axel Davy wrote: > Do we need the #ifndef WINAPI part ? > > Axel > > > On 29/04/2016 20:53, Christian Schmidbauer wrote: >> >> As Emil pointed out, only gcc, clang and MSVC compatibility is required. >> Hence the check for GNUC can be skipped, as

[Mesa-dev] [Bug 95266] Geometry missing from rendering, only when using Mesa.

https://bugs.freedesktop.org/show_bug.cgi?id=95266 --- Comment #7 from David Lonie --- I'm trying to get a trace, but apitrace is failing an assertion: $ apitrace trace --api gl bin/vtkRenderingCoreCxxTests "TestTranslucentLUTDepthPeeling"

[Mesa-dev] [Bug 95211] scons TypeError: 'tuple' object is not callable

https://bugs.freedesktop.org/show_bug.cgi?id=95211 Jose Fonseca changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |jfons...@vmware.com

[Mesa-dev] [Bug 95266] Geometry missing from rendering, only when using Mesa.

https://bugs.freedesktop.org/show_bug.cgi?id=95266 --- Comment #9 from Roland Scheidegger --- FWIW it was not the samplers returning NaN for the float texture, but rather the _coords_ being NaNs (thus the results from sampling could be anything, though it is possible some

[Mesa-dev] [PATCH] glapi: fix parameter type for GetSamplerParameterIuivEXT() in es_EXT.xml

The function returns GLuint, not GLfloat values. --- src/mapi/glapi/gen/es_EXT.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/es_EXT.xml b/src/mapi/glapi/gen/es_EXT.xml index bf67eae..e453401 100644 --- a/src/mapi/glapi/gen/es_EXT.xml +++

[Mesa-dev] [PATCH] mesa: include texture format in glGenerateMipmap error message

--- src/mesa/main/genmipmap.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/genmipmap.c b/src/mesa/main/genmipmap.c index 1a6ae9a..d917220 100644 --- a/src/mesa/main/genmipmap.c +++ b/src/mesa/main/genmipmap.c @@ -139,7 +139,8 @@

Re: [Mesa-dev] [PATCH] vulkan: Fix use of uninitialized variable.

On Tue, May 03, 2016 at 06:46:39PM -0400, robert.f...@collabora.com wrote: > From: Robert Foss > > The return variable was not set for failure paths. > It has now been changed to VK_ERROR_INITIALIZATION_FAILED > for failure paths. > > Coverity: 1358944 >

[Mesa-dev] [Bug 95266] Geometry missing from rendering, only when using Mesa.

https://bugs.freedesktop.org/show_bug.cgi?id=95266 --- Comment #15 from Emil Velikov --- Just pointing out something that may not be that obvious - David is using the xlib powered gallium libGL. That one uses the (iirc) unsupported split shared LLVM libraries. -- You

[Mesa-dev] [Bug 95266] Geometry missing from rendering, only when using Mesa.

https://bugs.freedesktop.org/show_bug.cgi?id=95266 --- Comment #16 from Jose Fonseca --- (In reply to David Lonie from comment #12) > Just tried that here, no such luck: > > $ ln -s libGL.so libGL.so.1 > $ LD_LIBRARY_PATH=$PWD:$LD_LIBRARY_PATH apitrace trace --api gl >

Re: [Mesa-dev] [PATCH 27/59] i965/fs: add a stride helper

On Mon, 2016-05-02 at 18:48 -0700, Francisco Jerez wrote: > Samuel Iglesias Gonsálvez writes: > > > From: Connor Abbott > > > > Similar to retype() and offset(). > > --- > > src/mesa/drivers/dri/i965/brw_ir_fs.h | 8 > > 1 file changed,

  1   2   >