[Mesa-dev] [PATCH 5/5] gallium: change pipe_draw_info::mode to be pipe_prim_type

Makes debugging with gdb a little nicer. --- src/gallium/include/pipe/p_state.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/include/pipe/p_state.h b/src/gallium/include/pipe/p_state.h index eacf9bb..396f563 100644 --- a/src/gallium/include/pipe/p_state.h +++

[Mesa-dev] [PATCH 1/5] svga: s/unsigned/enum pipe_prim_type/ for primitive type variables

Proper enum types were only added recently. --- src/gallium/drivers/svga/svga_draw.h | 4 ++-- src/gallium/drivers/svga/svga_draw_arrays.c | 6 +++--- src/gallium/drivers/svga/svga_draw_elements.c | 6 +++--- src/gallium/drivers/svga/svga_draw_private.h | 5 +++--

[Mesa-dev] [PATCH 2/5] svga: s/unsigned/enum pipe_resource_usage/ for buffer usage variables

--- src/gallium/drivers/svga/svga_resource_buffer.c | 2 +- src/gallium/drivers/svga/svga_screen_cache.c| 2 +- src/gallium/drivers/svga/svga_screen_cache.h| 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/svga/svga_resource_buffer.c

Re: [Mesa-dev] [Mesa-stable] [V2 PATCH] meta: Fix the pbo usage in meta for GLES{1, 2} contexts

Hi all, On 2 March 2016 at 03:22, Ian Romanick wrote: > Sorry for the delay. > > Reviewed-by: Ian Romanick > > > On 02/09/2016 03:28 PM, Anuj Phogat wrote: >> OpenGL ES 1.0 doesn't support using GL_STREAM_DRAW and both >> ES 1.0 and 2.0 don't

Re: [Mesa-dev] [PATCH] egl: Check if API is supported when using eglBindAPI.

On 05/24/2016 04:42 PM, Plamena Manolova wrote: According to the EGL specifications before binding an API we must check whether it's supported first. If not eglBindAPI should return EGL_FALSE and generate a EGL_BAD_PARAMETER error. Signed-off-by: Plamena Manolova

Re: [Mesa-dev] [Mesa-stable] [PATCH v2] scons: build osmesa swrast and gallium

On 27 April 2016 at 12:36, Emil Velikov wrote: > On 11 March 2016 at 08:43, Andreas Fänger wrote: >> This patch makes it possible to build classic osmesa/swrast on windows >> again. Although there is a gallium version of osmesa now, the swrast

Re: [Mesa-dev] [PATCH 3/3] radeon/llvm: Use alloca instructions for larger arrays

For the series: Reviewed-by: Marek Olšák Marek On Wed, May 25, 2016 at 2:35 PM, Tom Stellard wrote: > We were storing arrays in vectors, which was leading to some really bad > spill code for large arrays. allocas instructions are a better fit for

Re: [Mesa-dev] [PATCH 1/2] mesa: Allow to invalidate external textures when (re-)binding

Reviewed-by: Marek Olšák Marek On Wed, May 25, 2016 at 3:17 PM, Philipp Zabel wrote: > To comply with the requirement from the GL_OES_EGL_image_external > extension that a call to glBindTexture guarantees that all further > sampling will return

Re: [Mesa-dev] [PATCH 2/2] st/mesa: Invalidate external textures when (re-)binding

On Wed, May 25, 2016 at 3:34 PM, Philipp Zabel wrote: > Am Mittwoch, den 25.05.2016, 09:23 -0400 schrieb Ilia Mirkin: >> Iirc invalidate_resource is to allow backend to discard the contents... > > Thanks, I didn't know that. So this would need a new callback then? >

Re: [Mesa-dev] [Mesa-stable] [PATCH] nv50/ir: fix texture barriers insertion with combined load/store

On 05/26/2016 04:29 PM, Emil Velikov wrote: Hi guys, Double-checking through the list and this patch never landed in master. From a quick read through the log it's not immediately obvious if an alternative did get pushed. Can someone shed some light on the topic ? Hi Emil, Oops! I have

Re: [Mesa-dev] [PATCH] nir: Use double-precision pow() when bit_size is 64, powf() otherwise

On Thu, 2016-05-26 at 15:13 +0100, Emil Velikov wrote: > On 19 May 2016 at 10:00, Iago Toral wrote: > > I have just noticed that this was never pushed, right? I noticed this > > while working on providing double-precision implementation for the other > > functions discussed in

Re: [Mesa-dev] [PATCH v3 00/14] radeonsi: offchip tessellation

On Thu, May 26, 2016 at 3:33 PM, Bas Nieuwenhuizen wrote: > Addressed review comments by Marek. > > As part of that the max number of patches per threadgroup was reduced to 40 > from 64. This reduced unigine-heaven performance from 43.1 fps to 42.5 fps > (the number

Re: [Mesa-dev] [PATCH 2/2] st/mesa: Invalidate external textures when (re-)binding

On Thu, May 26, 2016 at 10:31 AM, Marek Olšák wrote: > On Wed, May 25, 2016 at 3:34 PM, Philipp Zabel wrote: >> Am Mittwoch, den 25.05.2016, 09:23 -0400 schrieb Ilia Mirkin: >>> Iirc invalidate_resource is to allow backend to discard the contents... >>

Re: [Mesa-dev] [Mesa-stable] [PATCH 7/8] glsl/linker: Don't include interface name for built-in blocks

Hi all, On 18 May 2016 at 00:35, Timothy Arceri wrote: > On Tue, 2016-05-17 at 15:11 -0700, Ian Romanick wrote: >> From: Ian Romanick >> >> Commit 11096ec introduced a regression in some piglit tests (e.g., >>

Re: [Mesa-dev] [Mesa-stable] [PATCH v2] scons: build osmesa swrast and gallium

On 05/26/2016 08:23 AM, Emil Velikov wrote: On 27 April 2016 at 12:36, Emil Velikov wrote: On 11 March 2016 at 08:43, Andreas Fänger wrote: This patch makes it possible to build classic osmesa/swrast on windows again. Although there is a

Re: [Mesa-dev] [PATCH] nir: Use double-precision pow() when bit_size is 64, powf() otherwise

On 19 May 2016 at 10:00, Iago Toral wrote: > I have just noticed that this was never pushed, right? I noticed this > while working on providing double-precision implementation for the other > functions discussed in the thread. > You are correct Iago. Gents, can anyone get some

[Mesa-dev] [PATCH 3/5] util: s/unsigned/enum pipe_resource_usage/ for buffer usage variables

--- src/gallium/auxiliary/util/u_debug.c | 2 +- src/gallium/auxiliary/util/u_debug.h | 2 +- src/gallium/auxiliary/util/u_inlines.h| 6 +++--- src/gallium/auxiliary/util/u_staging.c| 2 +- src/gallium/auxiliary/util/u_staging.h| 2 +- src/gallium/auxiliary/util/u_suballoc.c

Re: [Mesa-dev] [Mesa-stable] [PATCH 4/4] glx: fix error code when there is no context bound

Hi all, On 29 February 2016 at 07:14, Tapani Pälli wrote: > > On 02/22/2016 10:16 PM, Ian Romanick wrote: >> >> There are 17 total occurrences of >> >> grep -r '[(]!gc[)]' src/glx/ >> >> and >> >> grep -r 'gc[[:space:]]*==[[:space:]]*NULL' src/glx/ >> >> None of

Re: [Mesa-dev] [Mesa-stable] [PATCH] nv50/ir: fix texture barriers insertion with combined load/store

Hi guys, Double-checking through the list and this patch never landed in master. From a quick read through the log it's not immediately obvious if an alternative did get pushed. Can someone shed some light on the topic ? Thanks Emil ___ mesa-dev

Re: [Mesa-dev] [PATCH 2/2] st/mesa: Invalidate external textures when (re-)binding

On Thu, May 26, 2016 at 4:36 PM, Ilia Mirkin wrote: > On Thu, May 26, 2016 at 10:31 AM, Marek Olšák wrote: >> On Wed, May 25, 2016 at 3:34 PM, Philipp Zabel >> wrote: >>> Am Mittwoch, den 25.05.2016, 09:23 -0400 schrieb Ilia

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/2] glsl/linker: Include the interface name for input and output blocks

Hi gents, On 14 May 2016 at 04:11, Kenneth Graunke wrote: > On Friday, May 13, 2016 6:42:54 PM PDT Ian Romanick wrote: >> From: Ian Romanick >> >> On my oes_shader_io_blocks branch, this fixes 71 >>

Re: [Mesa-dev] [PATCH v3 13/14] radeonsi: Process multiple patches per threadgroup.

Patches 12-13: Reviewed-by: Marek Olšák Marek On Thu, May 26, 2016 at 3:33 PM, Bas Nieuwenhuizen wrote: > Using more than 1 wave per threadgroup does increase performance > generally. Not using too many patches per threadgroup also > increases

Re: [Mesa-dev] [PATCH 3/5] util: s/unsigned/enum pipe_resource_usage/ for buffer usage variables

Reviewed-by: Marek Olšák Marek On Thu, May 26, 2016 at 4:09 PM, Brian Paul wrote: > --- > src/gallium/auxiliary/util/u_debug.c | 2 +- > src/gallium/auxiliary/util/u_debug.h | 2 +- > src/gallium/auxiliary/util/u_inlines.h| 6 +++--- >

Re: [Mesa-dev] [PATCH 5/5] gallium: change pipe_draw_info::mode to be pipe_prim_type

Reviewed-by: Marek Olšák Marek On Thu, May 26, 2016 at 4:09 PM, Brian Paul wrote: > Makes debugging with gdb a little nicer. > --- > src/gallium/include/pipe/p_state.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [Mesa-dev] [PATCH 2/2] st/mesa: Invalidate external textures when (re-)binding

Am Donnerstag, den 26.05.2016, 10:36 -0400 schrieb Ilia Mirkin: > On Thu, May 26, 2016 at 10:31 AM, Marek Olšák wrote: > > On Wed, May 25, 2016 at 3:34 PM, Philipp Zabel > > wrote: > >> Am Mittwoch, den 25.05.2016, 09:23 -0400 schrieb Ilia Mirkin: > >>>

Re: [Mesa-dev] [PATCH] gallium: detect avx512 cpu features

Am 26.05.2016 um 02:10 schrieb Tim Rowley: > --- > src/gallium/auxiliary/util/u_cpu_detect.c | 17 + > src/gallium/auxiliary/util/u_cpu_detect.h | 10 ++ > 2 files changed, 27 insertions(+) > > diff --git a/src/gallium/auxiliary/util/u_cpu_detect.c >

[Mesa-dev] [PATCH] i965/bxt: Add 2x6 variant

Cc: mesa-sta...@lists.freedesktop.org Signed-off-by: Ben Widawsky --- include/pci_ids/i965_pci_ids.h | 2 ++ src/mesa/drivers/dri/i965/brw_device_info.c | 22 ++ 2 files changed, 24 insertions(+) diff --git a/include/pci_ids/i965_pci_ids.h

[Mesa-dev] [PATCH 2/2] tgsi: fix coverity out-of-bounds warning

From: Rob Clark CID 1271532 (#1 of 1): Out-of-bounds read (OVERRUN)34. overrun-local: Overrunning array of 2 16-byte elements at element index 2 (byte offset 32) by dereferencing pointer [i]. Signed-off-by: Rob Clark ---

[Mesa-dev] [PATCH 1/2] tgsi: fix out of bounds access

From: Rob Clark Not sure why coverity calls this an out-of-bounds read vs out-of-bounds write. CID 1358920 (#1 of 1): Out-of-bounds read (OVERRUN)9. overrun-local: Overrunning array r of 3 16-byte elements at element index 3 (byte offset 48) using index chan (which

Re: [Mesa-dev] [PATCH 5/5] util/indices: implement unfilled (tri->line) conversion for adjacency prims

Am 26.05.2016 um 16:06 schrieb Brian Paul: > Tested with new piglit gl-3.2-adj-prims test. > --- > src/gallium/auxiliary/indices/u_unfilled_gen.py| 26 > -- > src/gallium/auxiliary/indices/u_unfilled_indices.c | 14 > 2 files changed, 38 insertions(+), 2

Re: [Mesa-dev] [PATCH 2/2] tgsi: fix coverity out-of-bounds warning

On Thu, May 26, 2016 at 11:33 AM, Brian Paul wrote: > On 05/26/2016 09:25 AM, Rob Clark wrote: >> >> From: Rob Clark >> >> CID 1271532 (#1 of 1): Out-of-bounds read (OVERRUN)34. overrun-local: >> Overrunning array of 2 16-byte elements at element

Re: [Mesa-dev] [PATCH] i965/bxt: Add 2x6 variant

On Thu, May 26, 2016 at 8:08 AM, Ben Widawsky wrote: > Cc: mesa-sta...@lists.freedesktop.org > Signed-off-by: Ben Widawsky The numbers check out. Reviewed-by: Kristian Høgsberg > --- > include/pci_ids/i965_pci_ids.h | 2

Re: [Mesa-dev] [PATCH 2/2] nvc0/ir: handle a load's reg result not being used for locked variants

On Thu, May 26, 2016 at 11:51 AM, Samuel Pitoiset wrote: > > > On 05/26/2016 05:49 PM, Samuel Pitoiset wrote: >> >> What about the Maxwell logic? LDS expects a GPR at def(0) and in case >> the dst reg doesn't exist, you move the predicate to def(0). >> >> Are you sure

Re: [Mesa-dev] [PATCH 2/2] tgsi: fix coverity out-of-bounds warning

On 05/26/2016 09:25 AM, Rob Clark wrote: From: Rob Clark CID 1271532 (#1 of 1): Out-of-bounds read (OVERRUN)34. overrun-local: Overrunning array of 2 16-byte elements at element index 2 (byte offset 32) by dereferencing pointer [i]. Signed-off-by: Rob Clark

Re: [Mesa-dev] [PATCH 5/5] util/indices: implement unfilled (tri->line) conversion for adjacency prims

On 05/26/2016 09:37 AM, Roland Scheidegger wrote: Am 26.05.2016 um 16:06 schrieb Brian Paul: Tested with new piglit gl-3.2-adj-prims test. --- src/gallium/auxiliary/indices/u_unfilled_gen.py| 26 -- src/gallium/auxiliary/indices/u_unfilled_indices.c | 14

Re: [Mesa-dev] [PATCH 10/10] anv: Stop linking against libmesa.la and libdri_test_stubs.la

Update the TODO as well. With that, for the series: Reviewed-by: Kristian Høgsberg On Wed, May 25, 2016 at 6:52 PM, Jason Ekstrand wrote: > This brings the final size of an optimized non-debug build of the Vulkan > driver down to 2.9 MB as opposed to

Re: [Mesa-dev] [PATCH 4/5] util/indices: implement provoking vertex conversion for adjacency primitives

On 05/26/2016 09:35 AM, Roland Scheidegger wrote: Am 26.05.2016 um 16:06 schrieb Brian Paul: Tested with new piglit gl-3.2-adj-prims test. --- src/gallium/auxiliary/indices/u_indices.c | 52 src/gallium/auxiliary/indices/u_indices_gen.py | 83 +-

Re: [Mesa-dev] [PATCH 4/5] util/indices: implement provoking vertex conversion for adjacency primitives

Am 26.05.2016 um 17:39 schrieb Brian Paul: > On 05/26/2016 09:35 AM, Roland Scheidegger wrote: >> Am 26.05.2016 um 16:06 schrieb Brian Paul: >>> Tested with new piglit gl-3.2-adj-prims test. >>> --- >>> src/gallium/auxiliary/indices/u_indices.c | 52 >>>

Re: [Mesa-dev] [PATCH 2/2] nvc0/ir: handle a load's reg result not being used for locked variants

On 05/26/2016 05:49 PM, Samuel Pitoiset wrote: What about the Maxwell logic? LDS expects a GPR at def(0) and in case the dst reg doesn't exist, you move the predicate to def(0). Are you sure you don't need to check if dst(0) is not a predicate in emitLDS()? Oh, actually not because we don't

Re: [Mesa-dev] [PATCH v4] swr: implement clipPlanes/clipVertex/clipDistance/cullDistance

> On May 26, 2016, at 8:33 AM, Ilia Mirkin wrote: > > On Thu, May 26, 2016 at 9:11 AM, Tim Rowley > wrote: >> v2: only load the clip vertex once >> >> v3: fix clip enable logic, add cullDistance >> >> v4: remove duplicate fields in vs jit

Re: [Mesa-dev] [PATCH 2/2] nvc0/ir: handle a load's reg result not being used for locked variants

What about the Maxwell logic? LDS expects a GPR at def(0) and in case the dst reg doesn't exist, you move the predicate to def(0). Are you sure you don't need to check if dst(0) is not a predicate in emitLDS()? On 05/26/2016 04:44 AM, Ilia Mirkin wrote: For a load locked, we might not use

Re: [Mesa-dev] [PATCH 4/5] util/indices: implement provoking vertex conversion for adjacency primitives

Am 26.05.2016 um 16:06 schrieb Brian Paul: > Tested with new piglit gl-3.2-adj-prims test. > --- > src/gallium/auxiliary/indices/u_indices.c | 52 > src/gallium/auxiliary/indices/u_indices_gen.py | 83 > +- >

Re: [Mesa-dev] [PATCH 5/5] gallium: change pipe_draw_info::mode to be pipe_prim_type

Am 26.05.2016 um 16:09 schrieb Brian Paul: > Makes debugging with gdb a little nicer. > --- > src/gallium/include/pipe/p_state.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/gallium/include/pipe/p_state.h > b/src/gallium/include/pipe/p_state.h > index

Re: [Mesa-dev] [PATCH 2/2] nvc0/ir: handle a load's reg result not being used for locked variants

On 05/26/2016 05:51 PM, Samuel Pitoiset wrote: On 05/26/2016 05:49 PM, Samuel Pitoiset wrote: What about the Maxwell logic? LDS expects a GPR at def(0) and in case the dst reg doesn't exist, you move the predicate to def(0). Are you sure you don't need to check if dst(0) is not a predicate

Re: [Mesa-dev] [PATCH 1/2] nvc0/ir: avoid generating illegal instructions for compute constbuf loads

Makes sense. We should also clamp the index for indirect access as part of the robustness, but this can be done later. Reviewed-by: Samuel Pitoiset On 05/26/2016 04:44 AM, Ilia Mirkin wrote: For user-supplied constbufs, fileIndex is 0. In that case, when we

Re: [Mesa-dev] [PATCH 00/10] i965, anv: Stop linking the Vulkan driver to libmesa

On 26 May 2016 at 02:52, Jason Ekstrand wrote: > This little series reworks the build a bit so that we can stop linking the > Vulkan driver to libmesa. This lets us substantially cut down on the size > of the final binary. The whole series can be found in a branch here: >

Re: [Mesa-dev] [Mesa-stable] [V2 PATCH] meta: Fix the pbo usage in meta for GLES{1, 2} contexts

On Thu, May 26, 2016 at 7:18 AM, Emil Velikov wrote: > Hi all, > > On 2 March 2016 at 03:22, Ian Romanick wrote: >> Sorry for the delay. >> >> Reviewed-by: Ian Romanick >> >> >> On 02/09/2016 03:28 PM, Anuj Phogat wrote:

[Mesa-dev] [PATCH] util/indices: move duplicated assignments out of switch cases

Spotted by Roland. --- src/gallium/auxiliary/indices/u_indices.c | 33 --- 1 file changed, 4 insertions(+), 29 deletions(-) diff --git a/src/gallium/auxiliary/indices/u_indices.c b/src/gallium/auxiliary/indices/u_indices.c index 91f00f2..323c971 100644 ---

[Mesa-dev] [PATCH] isl: Fix some tautological-compare warnings

Fixes: isl.c:62:22: warning: self-comparison always evaluates to true [-Wtautological-compare] assert(ISL_DEV_GEN(dev) == dev->info->gen); ^~ isl.c:63:33: warning: self-comparison always evaluates to true [-Wtautological-compare]

Re: [Mesa-dev] [PATCH 2/2] tgsi: fix coverity out-of-bounds warning

On Thu, May 26, 2016 at 11:42 AM, Rob Clark wrote: > On Thu, May 26, 2016 at 11:33 AM, Brian Paul wrote: >> On 05/26/2016 09:25 AM, Rob Clark wrote: >>> >>> From: Rob Clark >>> >>> CID 1271532 (#1 of 1): Out-of-bounds read

Re: [Mesa-dev] [PATCH] i965/sklgt4: Implement depth/timestamp write w/a

On Thu, May 26, 2016 at 11:04 AM, Ben Widawsky wrote: > From: Ben Widawsky > > The stated bug describes a scenario in which a post sync write operation for > depth or timestamp can be ignored. There are two workarounds suggested, the > first and

Re: [Mesa-dev] [PATCH 2/2] svga: fix test for unfilled triangles fallback

This series looks good to me. Reviewed-by: Charmaine Lee From: Brian Paul Sent: Thursday, May 26, 2016 7:09 AM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee; Roland Scheidegger Subject: [PATCH 2/2] svga:

[Mesa-dev] [PATCH 1/4] util: Add _mesa_llroundevenf().

--- src/util/rounding.h | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/util/rounding.h b/src/util/rounding.h index afb38fb..8a3e630 100644 --- a/src/util/rounding.h +++ b/src/util/rounding.h @@ -112,6 +112,20 @@ _mesa_lroundevenf(float x) * \brief Rounds \c x to the

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965/bxt: Add 2x6 variant

Kristian Høgsberg writes: > On Thu, May 26, 2016 at 8:08 AM, Ben Widawsky wrote: >> Cc: mesa-sta...@lists.freedesktop.org >> Signed-off-by: Ben Widawsky > > The numbers check out. > > Reviewed-by: Kristian Høgsberg

[Mesa-dev] [PATCH] i965/sklgt4: Implement depth/timestamp write w/a

From: Ben Widawsky The stated bug describes a scenario in which a post sync write operation for depth or timestamp can be ignored. There are two workarounds suggested, the first and easier is to simply do a cs stall when we do these type of writes. The second option is to do a

Re: [Mesa-dev] [Mesa-stable] [V2 PATCH] meta: Fix the pbo usage in meta for GLES{1, 2} contexts

On 26 May 2016 at 18:37, Anuj Phogat wrote: > This patch has landed in commit 6d4ebbe. The minor tweak in the commit message got me there. Thanks Anuj ! -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

[Mesa-dev] [PATCH 2/4] mesa: Replace uses of IROUND{, D, 64} with libm functions.

IROUND is replaces with lroundf. IROUNDD is replaces with lround. IROUND64 is replaced with llroundf. --- This is a resend of a patch from last year. Roland suggested using rint instead of round since it's cheaper, but it actually causes test failures in some dEQP tests. Additionally, while

[Mesa-dev] [PATCH 3/4] mesa: Replace IROUND_POS() with lroundf().

--- src/mesa/drivers/x11/xm_api.c | 2 +- src/mesa/main/imports.h | 9 - src/mesa/program/prog_execute.c | 4 src/mesa/swrast/s_aaline.c | 2 +- src/mesa/swrast/s_aatriangle.c | 2 +- 5 files changed, 3 insertions(+), 16 deletions(-) diff --git

[Mesa-dev] [PATCH 4/4] xlib: Use float type in calculation.

--- src/mesa/drivers/x11/xm_api.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/x11/xm_api.c b/src/mesa/drivers/x11/xm_api.c index 3eaa6cf..15ac130 100644 --- a/src/mesa/drivers/x11/xm_api.c +++ b/src/mesa/drivers/x11/xm_api.c @@ -149,8 +149,8 @@

Re: [Mesa-dev] [PATCH] gallium: detect avx512 cpu features

All good, but I would suggest matching the already existing editing style (ie correct tabulation, and zero-padding of cpuid() args. Reviewed-By: George Kyriazis > -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf

Re: [Mesa-dev] [PATCH] i965: Use the buffer object size for VERTEX_BUFFER_STATE's size field.

Reviewed-by: Jason Ekstrand On Thu, May 26, 2016 at 12:31 AM, Kenneth Graunke wrote: > commit 7c8dfa78b98a12c1c5 (i965/draw: Use the real size for vertex > buffers) changed how we programmed the VERTEX_BUFFER_STATE size field. > > Previously, we

Re: [Mesa-dev] [PATCH 2/2] mesa: add support for GLSL ES 3.20 version string

On Thu, May 26, 2016 at 10:58 AM, Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin > --- > src/mesa/main/getstring.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/mesa/main/getstring.c b/src/mesa/main/getstring.c > index

[Mesa-dev] [PATCH 2/2] mesa: add support for GLSL ES 3.20 version string

Signed-off-by: Ilia Mirkin --- src/mesa/main/getstring.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/main/getstring.c b/src/mesa/main/getstring.c index c39a076..6e90511 100644 --- a/src/mesa/main/getstring.c +++ b/src/mesa/main/getstring.c @@ -80,6 +80,8

[Mesa-dev] [PATCH 1/2] mapi: expose new functions in GL ES 3.2

Signed-off-by: Ilia Mirkin --- src/mapi/glapi/gen/ARB_copy_image.xml| 2 +- src/mapi/glapi/gen/ARB_sampler_objects.xml | 8 src/mapi/glapi/gen/ARB_tessellation_shader.xml | 2 +- src/mapi/glapi/gen/ARB_texture_buffer_range.xml

[Mesa-dev] [PATCH] i965: Use the buffer object size for VERTEX_BUFFER_STATE's size field.

commit 7c8dfa78b98a12c1c5 (i965/draw: Use the real size for vertex buffers) changed how we programmed the VERTEX_BUFFER_STATE size field. Previously, we programmed it to the size of the actual underlying BO, which is page-aligned, and potentially much larger than the GL buffer object. This

Re: [Mesa-dev] [PATCH 0/2] fix load of unpacked double vector input varyings

On Thu, 2016-05-26 at 17:44 +1000, Timothy Arceri wrote: > On Thu, 2016-05-26 at 07:56 +0200, Samuel Iglesias Gonsálvez wrote: > > > > Hello, > > > > Timothy found that tests with unpacked double vector input varyings > > were failing in i965 driver. For example, this is happening when > > using

Re: [Mesa-dev] [PATCH 0/2] fix load of unpacked double vector input varyings

On Thu, 2016-05-26 at 07:56 +0200, Samuel Iglesias Gonsálvez wrote: > Hello, > > Timothy found that tests with unpacked double vector input varyings > were failing in i965 driver. For example, this is happening when > using explicit locations because Mesa disables varying packing for > that case.

Re: [Mesa-dev] [PATCH v2] nvc0: enable 32 textures on kepler+

I think you forgot to increase the array of commands from 16 to 32 in nvc0_validate_tsc() (you did it in v1). With that addressed, this patch is: Reviewed-by: Samuel Pitoiset On 05/26/2016 04:55 AM, Ilia Mirkin wrote: For fermi, this likely will require use of

Re: [Mesa-dev] [PATCH] glsl: re-enable varying packing in GL4.4+

On Thu, 2016-05-26 at 14:50 +1000, Timothy Arceri wrote: > The i965 backend currently expects doubles to be packed. This patch is: Reviewed-by: Iago Toral Quiroga With that said, I think these two patches from Samuel might have fixed i965 to handle unpacked doubles, or at

[Mesa-dev] [PATCH] i965: Fix the passthrough TCS for isolines.

We weren't setting up several of the uniform values for the patch header, so we'd crash when uploading push constants. We at least need to initialize them to zero. We also had the isoline parameters reversed, so it would also render incorrectly (if it didn't crash). Fixes a new Piglit test(*)

Re: [Mesa-dev] [PATCH] st/dri: fix winsys handle stride calculation for block formats

On 25.05.2016 22:20, Philipp Zabel wrote: > This fixes the stride calculation for pipe formats with a block width > larger than one. > > Signed-off-by: Philipp Zabel > --- > src/gallium/state_trackers/dri/dri2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: [Mesa-dev] [PATCH 2/4] mesa: Replace uses of IROUND{, D, 64} with libm functions.

On 05/26/2016 11:28 AM, Matt Turner wrote: > IROUND is replaces with lroundf. > IROUNDD is replaces with lround. ^ d on both of the above > IROUND64 is replaced with llroundf. > --- > This is a resend of a patch from last year. > > Roland suggested using rint instead of

[Mesa-dev] [PATCH] gallium/util: use enum pipe_prim_type in u_prim.h functions

--- src/gallium/auxiliary/util/u_prim.h | 30 -- 1 file changed, 16 insertions(+), 14 deletions(-) diff --git a/src/gallium/auxiliary/util/u_prim.h b/src/gallium/auxiliary/util/u_prim.h index a09c315..fb9290d 100644 --- a/src/gallium/auxiliary/util/u_prim.h +++

Re: [Mesa-dev] [Mesa-stable] [PATCH 7/8] glsl/linker: Don't include interface name for built-in blocks

There has been some confusion about this code because our piglit tests were actually incorrect. I have a 3rd fix coming in this area. I will put together a concise set of fixes for stable once all the dust settles. Sorry for all the churn. :( On 05/26/2016 07:41 AM, Emil Velikov wrote: > Hi

Re: [Mesa-dev] [PATCH 1/4] util: Add _mesa_llroundevenf().

On Thu, May 26, 2016 at 12:37 PM, Ian Romanick wrote: > On 05/26/2016 11:28 AM, Matt Turner wrote: >> --- >> src/util/rounding.h | 14 ++ >> 1 file changed, 14 insertions(+) >> >> diff --git a/src/util/rounding.h b/src/util/rounding.h >> index afb38fb..8a3e630

Re: [Mesa-dev] [PATCH 2/4] mesa: Replace uses of IROUND{, D, 64} with libm functions.

Am 26.05.2016 um 20:28 schrieb Matt Turner: > IROUND is replaces with lroundf. > IROUNDD is replaces with lround. > IROUND64 is replaced with llroundf. > --- > This is a resend of a patch from last year. > > Roland suggested using rint instead of round since it's cheaper, but it > actually

Re: [Mesa-dev] [PATCH] util/indices: move duplicated assignments out of switch cases

Reviewed-by: Roland Scheidegger Am 26.05.2016 um 20:18 schrieb Brian Paul: > Spotted by Roland. > --- > src/gallium/auxiliary/indices/u_indices.c | 33 > --- > 1 file changed, 4 insertions(+), 29 deletions(-) > > diff --git

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/2] glsl/linker: Include the interface name for input and output blocks

On Thursday, May 26, 2016 3:39:50 PM PDT Emil Velikov wrote: > Seems like I forgot to press 'send' a while back. > > The function itself is missing in 11.2 branch and from a quick look > there isn't a quick backport. Can anyone prep one or it doesn't make > sense to have one at all in -stable ? >

Re: [Mesa-dev] [PATCH 1/4] util: Add _mesa_llroundevenf().

On 05/26/2016 11:28 AM, Matt Turner wrote: > --- > src/util/rounding.h | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git a/src/util/rounding.h b/src/util/rounding.h > index afb38fb..8a3e630 100644 > --- a/src/util/rounding.h > +++ b/src/util/rounding.h > @@ -112,6 +112,20 @@

Re: [Mesa-dev] [PATCH 2/4] mesa: Replace uses of IROUND{, D, 64} with libm functions.

On 05/26/2016 12:28 PM, Matt Turner wrote: IROUND is replaces with lroundf. IROUNDD is replaces with lround. IROUND64 is replaced with llroundf. --- This is a resend of a patch from last year. Roland suggested using rint instead of round since it's cheaper, but it actually causes test

[Mesa-dev] [PATCH v2] gallium: detect avx512 cpu features

v2: style code, add avx512 to cpu dump --- src/gallium/auxiliary/util/u_cpu_detect.c | 26 ++ src/gallium/auxiliary/util/u_cpu_detect.h | 10 ++ 2 files changed, 36 insertions(+) diff --git a/src/gallium/auxiliary/util/u_cpu_detect.c

Re: [Mesa-dev] [PATCH] isl: Fix some tautological-compare warnings

On Thu, May 26, 2016 at 11:59 AM, Ben Widawsky wrote: > Fixes: > isl.c:62:22: warning: self-comparison always evaluates to true > [-Wtautological-compare] > assert(ISL_DEV_GEN(dev) == dev->info->gen); > ^~ > isl.c:63:33: warning:

[Mesa-dev] [PATCH 2/2] winsys/amdgpu: disable CE preamble until the kernel is fixed

From: Marek Olšák SDMA submission somehow interacts with the skipping CE preamble logic. This is a workaround for current kernels which have the bug. Sadly, I can't see what's wrong with the kernel driver. The CE preamble handling there looks good to me. Bugzilla:

Re: [Mesa-dev] [PATCH] nir: Make nir_const_value a union

On Thu, May 26, 2016 at 3:59 PM, Vinson Lee wrote: > On Thu, May 26, 2016 at 3:40 PM, Jason Ekstrand > wrote: > > There's no good reason for it to be a struct of an anonymous union. > > > > Cc: Vinson Lee > > --- > >

[Mesa-dev] [Bug 96221] nir/nir_lower_tex.c:202: error: unknown field ‘f32’ specified in initializer

https://bugs.freedesktop.org/show_bug.cgi?id=96221 Jason Ekstrand changed: What|Removed |Added Resolution|--- |FIXED

Re: [Mesa-dev] [PATCH 02/11] glsl: Add glsl LowerCsDerivedVariables option

On Tuesday, May 24, 2016 1:37:47 AM PDT Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > src/compiler/glsl/builtin_variables.cpp | 13 +++-- > src/compiler/glsl/glsl_parser_extras.cpp | 8 > src/mesa/drivers/dri/i965/brw_compiler.c | 2 ++

[Mesa-dev] [PATCH 1/2] radeonsi: don't flush TC at the end of IBs on DRM >= 3.2.0

From: Marek Olšák It's not needed since it was fixed in the kernel. --- src/gallium/drivers/radeonsi/si_hw_context.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_hw_context.c

Re: [Mesa-dev] [PATCH] mesa: Only validate SSO shader IO in OpenGL ES or debug context

This will cause st/mesa to break, no? Right now validate_io iterates over the shader ir, which st/mesa frees after linking. -ilia On Thu, May 26, 2016 at 5:59 PM, Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick

Re: [Mesa-dev] [PATCH 1/2] radeonsi: don't flush TC at the end of IBs on DRM >= 3.2.0

On Thu, May 26, 2016 at 5:51 PM, Marek Olšák wrote: > From: Marek Olšák > > It's not needed since it was fixed in the kernel. Reviewed-by: Alex Deucher > --- > src/gallium/drivers/radeonsi/si_hw_context.c | 5 +++-- > 1 file

[Mesa-dev] [PATCH] nvc0: do not always invalidate 3D CBs when using compute

Constant buffers are aliased between 3D and CP on Fermi, but we should only invalidate them when a compute shader actually uses CBs and not all the time after a lauching grid. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_compute.c | 25

Re: [Mesa-dev] [PATCH] mesa: Only validate SSO shader IO in OpenGL ES or debug context

On Thu, May 26, 2016 at 7:09 PM, Ian Romanick wrote: > On 05/26/2016 03:39 PM, Ilia Mirkin wrote: >> On Thu, May 26, 2016 at 6:26 PM, Ian Romanick wrote: >>> On 05/26/2016 03:03 PM, Ilia Mirkin wrote: This will cause st/mesa to break, no? Right

Re: [Mesa-dev] [PATCH] mesa: Only validate SSO shader IO in OpenGL ES or debug context

On Thu, 2016-05-26 at 14:59 -0700, Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick > Suggested-by: Timothy Arceri > Cc: Timothy Arceri Looks good to me.

[Mesa-dev] [PATCH] mesa: Only validate SSO shader IO in OpenGL ES or debug context

From: Ian Romanick Signed-off-by: Ian Romanick Suggested-by: Timothy Arceri Cc: Timothy Arceri --- src/mesa/main/pipelineobj.c| 18 --

Re: [Mesa-dev] [PATCH 2/2] winsys/amdgpu: disable CE preamble until the kernel is fixed

On Thu, May 26, 2016 at 5:51 PM, Marek Olšák wrote: > From: Marek Olšák > > SDMA submission somehow interacts with the skipping CE preamble logic. > This is a workaround for current kernels which have the bug. > > Sadly, I can't see what's wrong with the

Re: [Mesa-dev] [PATCH] mesa: Only validate SSO shader IO in OpenGL ES or debug context

On 05/26/2016 03:03 PM, Ilia Mirkin wrote: > This will cause st/mesa to break, no? Right now validate_io iterates > over the shader ir, which st/mesa frees after linking. Only as much as it is already broken. :) Any desktop OpenGL application using GLSL ES shaders would already have that problem.

[Mesa-dev] [Bug 18508] OpenGL texture corruption

https://bugs.freedesktop.org/show_bug.cgi?id=18508 Topcomfort changed: What|Removed |Added URL|

Re: [Mesa-dev] [PATCH] mesa: Only validate SSO shader IO in OpenGL ES or debug context

On Thu, May 26, 2016 at 6:26 PM, Ian Romanick wrote: > On 05/26/2016 03:03 PM, Ilia Mirkin wrote: >> This will cause st/mesa to break, no? Right now validate_io iterates >> over the shader ir, which st/mesa frees after linking. > > Only as much as it is already broken. :)

Re: [Mesa-dev] [PATCH] nir: Make nir_const_value a union

On Thu, May 26, 2016 at 3:40 PM, Jason Ekstrand wrote: > There's no good reason for it to be a struct of an anonymous union. > > Cc: Vinson Lee > --- > src/compiler/nir/nir.h | 16 +++- >

Re: [Mesa-dev] [PATCH] mesa: Only validate SSO shader IO in OpenGL ES or debug context

On 05/26/2016 03:39 PM, Ilia Mirkin wrote: > On Thu, May 26, 2016 at 6:26 PM, Ian Romanick wrote: >> On 05/26/2016 03:03 PM, Ilia Mirkin wrote: >>> This will cause st/mesa to break, no? Right now validate_io iterates >>> over the shader ir, which st/mesa frees after linking.

Re: [Mesa-dev] [PATCH] gallium/util: use enum pipe_prim_type in u_prim.h functions

Am 26.05.2016 um 23:14 schrieb Brian Paul: > --- > src/gallium/auxiliary/util/u_prim.h | 30 -- > 1 file changed, 16 insertions(+), 14 deletions(-) > > diff --git a/src/gallium/auxiliary/util/u_prim.h > b/src/gallium/auxiliary/util/u_prim.h > index a09c315..fb9290d

  1   2   3   >