Re: [Mesa-dev] [PATCH] if if is is, then then the the do do for for an a

Thanks spending the time on doing this. With a lightly more descriptive commit summary fixup, Reviewed-by: Edward O'Callaghan On 06/23/2016 03:32 PM, Matt Turner wrote: > On Wed, Jun 22, 2016 at 10:05 PM, Giuseppe Bilotta > wrote: >>

Re: [Mesa-dev] [PATCH 1/4] radeon/vce: add vce structures

Am 22.06.2016 um 23:44 schrieb Boyuan Zhang: Signed-off-by: Boyuan Zhang I'm still not completely happy with this but I think we should move forward and can fix the fallout later on. So patches #1 and #2 are Reviewed-by: Christian König . If

[Mesa-dev] [Bug 61907] Indirect rendering of multi-texture vertex arrays broken

https://bugs.freedesktop.org/show_bug.cgi?id=61907 Matt Turner changed: What|Removed |Added QA Contact|

[Mesa-dev] [PATCH] i965: Preserve the internal format of the dri image

Since the OpenGLES API is strict about the internal format matching the for many operations, we need to preserve it. See _mesa_es3_error_check_format_and_type in src/mesa/main/glformats.c. Fixes ES2-CTS.gtf.GL2ExtensionTests.egl_image.egl_image Bugzilla:

[Mesa-dev] [Bug 96219] Using glXBindTexImageEXT with a GLXPixmap created out-of-process fails

https://bugs.freedesktop.org/show_bug.cgi?id=96219 --- Comment #1 from Matt Turner --- (In reply to Andrew Comminos from comment #0) > I suggest that driFetchDrawable is used in dri{2,3}_bind_tex_image, as it is > in dri{2,3}_bind_context. Have you tried that? If it works,

[Mesa-dev] [PATCH mesa] gbm: doc fixes

Signed-off-by: Eric Engestrom --- src/gbm/main/gbm.c | 8 src/gbm/main/gbm.h | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/gbm/main/gbm.c b/src/gbm/main/gbm.c index 0f4657a..a464f3c 100644 --- a/src/gbm/main/gbm.c +++

[Mesa-dev] [PATCH] gbm: Fix comments

--- src/gbm/main/gbm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gbm/main/gbm.c b/src/gbm/main/gbm.c index 0f4657a..31202ed 100644 --- a/src/gbm/main/gbm.c +++ b/src/gbm/main/gbm.c @@ -132,7 +132,7 @@ _gbm_mesa_get_device(int fd) * the file descriptor

[Mesa-dev] [PATCH] include: Require MSVC 2013 Update 4.

Earlier MSVC 2013 releases have troubles compiling some of our C99 code, so make sure we have Update 4 to avoid confusion. Cc: mesa-sta...@lists.freedesktop.org --- include/c99_compat.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/c99_compat.h

Re: [Mesa-dev] [PATCH] gbm: Fix comments

On Thu, Jun 23, 2016 at 03:54:11PM +0530, Gurkirpal Singh wrote: > --- Yes, and this reminds me I forgot to send similar fixes I made in this file ^^ Reviewed-by: Eric Engestrom You might also want to add a Signed-off-by: line with your name (although I don't think

Re: [Mesa-dev] [PATCH 2/4] anv: use cache uuid based on the build timestamp.

On 23 June 2016 at 03:49, Michel Dänzer wrote: > On 22.06.2016 21:04, Emil Velikov wrote: >> From: Emil Velikov >> >> Do not rely on the git sha1: >> - its current truncated form makes it less unique >> - it does not attribute for local (Vulkand

Re: [Mesa-dev] [PATCH] if if is is, then then the the do do for for an a

On Thu, Jun 23, 2016 at 7:32 AM, Matt Turner wrote: > On Wed, Jun 22, 2016 at 10:05 PM, Giuseppe Bilotta > wrote: >> Miscellaneous repetitions in commits and fly-by typo fixes. > > How about an actual commit title? I'm sorry, I couldn't resist the

Re: [Mesa-dev] [PATCH] include: Require MSVC 2013 Update 4.

On 06/23/2016 04:31 AM, Jose Fonseca wrote: Earlier MSVC 2013 releases have troubles compiling some of our C99 code, so make sure we have Update 4 to avoid confusion. Cc: mesa-sta...@lists.freedesktop.org --- include/c99_compat.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[Mesa-dev] [Bug 96518] [llvmpipe] piglit linestipple regression

https://bugs.freedesktop.org/show_bug.cgi?id=96518 Jose Fonseca changed: What|Removed |Added CC||bri...@vmware.com

[Mesa-dev] [Bug 96656] [regression, bisected] all textureGather piglits fail

https://bugs.freedesktop.org/show_bug.cgi?id=96656 Bug ID: 96656 Summary: [regression, bisected] all textureGather piglits fail Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity:

[Mesa-dev] [PATCHv2] Remove wrongly repeated words in comments

Clean up misrepetitions ('if if', 'the the' etc) found throughout the comments. This has been done manually, after grepping case-insensitively for duplicate if, is, the, then, do, for, an v2: * proper commit message and non-joke title; * replace two 'as is' followed by 'is' to 'as-is'.

Re: [Mesa-dev] Mesa 12.0.0 release candidate 4

Hi all, On 21 June 2016 at 15:35, Emil Velikov wrote: > The fourth release candidate for Mesa 12.0.0 is now available. > > Note: this is the final release candidate, with Mesa 12.0.0 expected in a > couple of days. > Considering the requests, from different parties,

Re: [Mesa-dev] [PATCH] include: Require MSVC 2013 Update 4.

Am 23.06.2016 um 12:31 schrieb Jose Fonseca: > Earlier MSVC 2013 releases have troubles compiling some of our C99 code, > so make sure we have Update 4 to avoid confusion. > > Cc: mesa-sta...@lists.freedesktop.org > --- > include/c99_compat.h | 4 ++-- > 1 file changed, 2 insertions(+), 2

Re: [Mesa-dev] [PATCH 03/11] mesa: Implement _mesa_all_varyings_in_vbos.

On Friday 17 June 2016, mathias.froehl...@gmx.net wrote: > From: Mathias Fröhlich > > Implement the equivalent of vbo_all_varyings_in_vbos for > vertex array objects. > > Signed-off-by: Mathias Fröhlich > --- > src/mesa/main/arrayobj.c | 35

Re: [Mesa-dev] [PATCHv2] Remove wrongly repeated words in comments

On Jun 23, 2016 6:33 AM, "Giuseppe Bilotta" wrote: > > Clean up misrepetitions ('if if', 'the the' etc) found throughout the > comments. This has been done manually, after grepping > case-insensitively for duplicate if, is, the, then, do, for, an > > v2: > * proper

Re: [Mesa-dev] [PATCH 2/2] clover: fix getting struct args api size

On Wed, 2016-06-22 at 20:22 -0700, Francisco Jerez wrote: > Jan Vesely writes: > > > On Wed, 2016-06-22 at 17:07 -0700, Francisco Jerez wrote: > > > Jan Vesely writes: > > > > > > > On Mon, 2016-06-13 at 17:24 -0700, Francisco Jerez wrote: > > >

Re: [Mesa-dev] [PATCH mesa] gbm: doc fixes

On Thu 23 Jun 2016, Eric Engestrom wrote: > Signed-off-by: Eric Engestrom > --- > src/gbm/main/gbm.c | 8 > src/gbm/main/gbm.h | 2 +- > 2 files changed, 5 insertions(+), 5 deletions(-) Reviewed-by: Chad Versace

[Mesa-dev] [PATCH 11/18] i965/blorp: Tell vertex fetcher about flat inputs

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/gen6_blorp.c | 30 -- src/mesa/drivers/dri/i965/gen8_blorp.c | 8 ++-- 2 files changed, 30 insertions(+), 8 deletions(-) diff --git a/src/mesa/drivers/dri/i965/gen6_blorp.c

[Mesa-dev] [PATCH 14/18] i965/blorp: Remove support for push constants

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_blorp.c | 17 ++- src/mesa/drivers/dri/i965/brw_blorp.h | 15 - src/mesa/drivers/dri/i965/gen6_blorp.c | 56 +- src/mesa/drivers/dri/i965/gen7_blorp.c |

[Mesa-dev] [PATCH 18/18] i965/blorp/gen7+: Do not trigger push constant space reconfig

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/gen7_urb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/gen7_urb.c b/src/mesa/drivers/dri/i965/gen7_urb.c index 84648d1..24b45f1 100644 ---

[Mesa-dev] [PATCH 15/18] i965/urb: Allow blorp to record current settings

This makes it possible to skip urb re-configuration if the subsequent renders agree with the settings. Also allows blorp to allocate the maximun amount of vs entries available. Core upload logic already knows how to calculate this. Helps one synthetic benchmark. Signed-off-by: Topi Pohjolainen

[Mesa-dev] [PATCH 10/18] i965/blorp: Add support for flat input buffer

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/gen6_blorp.c | 68 -- 1 file changed, 65 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/gen6_blorp.c b/src/mesa/drivers/dri/i965/gen6_blorp.c index

[Mesa-dev] [PATCH 16/18] i965/blorp: Fix the size requirement for vertex elements

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_blorp.h | 3 ++- src/mesa/drivers/dri/i965/gen7_blorp.c | 38 ++ src/mesa/drivers/dri/i965/gen8_blorp.c | 2 +- 3 files changed, 28 insertions(+), 15 deletions(-)

[Mesa-dev] [PATCH 17/18] i965/blorp/gen7+: Stop trashing push constant allocation

Packet 3DSTATE_CONSTANT_PS is still emitted explicitly as ps stage itself is enabled and hardware may try to prefetch constants from the buffer. From the BSpec: 3D Pipeline - Windower - 3DSTATE_PUSH_CONSTANT_ALLOC_PS "Specifies the size of the PS constant buffer. This value will determine

[Mesa-dev] [PATCH 13/18] i965/blorp: Use flat inputs instead of uniforms

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 43 ++- src/mesa/drivers/dri/i965/brw_blorp_clear.cpp | 9 +++--- 2 files changed, 27 insertions(+), 25 deletions(-) diff --git

[Mesa-dev] [PATCH] st/mesa: handle negative _ColorDrawBufferIndexes values correctly

--- src/mesa/state_tracker/st_cb_fbo.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_cb_fbo.c b/src/mesa/state_tracker/st_cb_fbo.c index a53b95a..950ec3e 100644 --- a/src/mesa/state_tracker/st_cb_fbo.c +++ b/src/mesa/state_tracker/st_cb_fbo.c @@

[Mesa-dev] [PATCH 05/18] i965/blorp: Rename push constants to inputs

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_blorp.h | 8 src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 24 src/mesa/drivers/dri/i965/brw_blorp_clear.cpp | 4 ++--

[Mesa-dev] [PATCH 06/18] i965/blorp: Share input slot between pixel kill and blend/scaled

These are never used in parallel, lets document this. Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_blorp.h | 47 --- src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 82 ++-

[Mesa-dev] [PATCH 08/18] i965/blorp: Drop LOAD_UNIFORM macro

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp_blit.cpp b/src/mesa/drivers/dri/i965/brw_blorp_blit.cpp index

[Mesa-dev] [PATCH 07/18] i965/blorp: Load tranformation coordinates as vec4

In preparation for loading as flat vertex input. Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] i965: Preserve the internal format of the dri image

On Wed 22 Jun 2016, Jordan Justen wrote: > Since the OpenGLES API is strict about the internal format matching > the for many operations, we need to preserve it. > > See _mesa_es3_error_check_format_and_type in > src/mesa/main/glformats.c. > > Fixes

[Mesa-dev] [PATCH 12/18] i965/blorp: Prepare for more than two vertex attributes

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_blorp.h | 13 + src/mesa/drivers/dri/i965/gen6_blorp.c | 4 +++- src/mesa/drivers/dri/i965/gen7_blorp.c | 4 +++- src/mesa/drivers/dri/i965/gen8_blorp.c | 4 +++- 4 files changed, 22

[Mesa-dev] [PATCH 04/18] i965/blorp: Use core vertex buffer state setup

Also split the setup from the setup of vertex elements. Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/gen6_blorp.c | 62 -- 1 file changed, 14 insertions(+), 48 deletions(-) diff --git

[Mesa-dev] i965/blorp: Use flat vertex inputs instead of uniforms

In addition to the actual vertex coordinates blorp will get another vertex input buffer providing the constants that are until now provided as uniforms. This will remove the need to configure push constants and their allocation in the pipeline. First three patches refactor the vertex data setup

[Mesa-dev] [PATCH 01/18] i965/draw: Expose vertex buffer state setup

Also change the interface to use start and end offsets. Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_draw.h| 13 + src/mesa/drivers/dri/i965/brw_draw_upload.c | 42 - 2 files changed, 37 insertions(+),

[Mesa-dev] [PATCH 03/18] i965/blorp: Split vertex data and element setup

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/gen6_blorp.c | 46 ++ 1 file changed, 25 insertions(+), 21 deletions(-) diff --git a/src/mesa/drivers/dri/i965/gen6_blorp.c b/src/mesa/drivers/dri/i965/gen6_blorp.c index

Re: [Mesa-dev] [PATCHv3] Remove wrongly repeated words in comments

On Thu 23 Jun 2016, Giuseppe Bilotta wrote: > Clean up misrepetitions ('if if', 'the the' etc) found throughout the > comments. This has been done manually, after grepping > case-insensitively for duplicate if, is, the, then, do, for, an, > plus a few other typos corrected in fly-by > > v2: >

[Mesa-dev] [PATCH 02/18] i965: Unify vertex buffer setup

On gen >= 8 one doesn't provide ending address but number of bytes available. This is relative to the given offset. Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_draw_upload.c | 34 +++

[Mesa-dev] [PATCH 09/18] i965/blorp: Store input read mask

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_blorp.c | 1 + src/mesa/drivers/dri/i965/brw_blorp.h | 1 + 2 files changed, 2 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_blorp.c b/src/mesa/drivers/dri/i965/brw_blorp.c index

[Mesa-dev] [PATCH 2/2] st/vdpau: use bicubic filter for scaling(v5)

use bicubic filtering as high quality scaling L1. v2: fix a typo and add a newline to code v3: -render the unscaled image on a temporary surface (Christian) -apply noise reduction and sharpness filter on unscaled surface -render the final scaled surface using bicubic

Re: [Mesa-dev] [PATCH] anv: Add anv_render_pass_attachment::store_op

R-B On Thu, Jun 23, 2016 at 1:56 PM, Chad Versace wrote: > Will be needed for resolving auxiliary surfaces. > > I didn't add anv_render_pass_attachment::stencil_store_op, as the driver > would likely never use it, as stencil surfaces never have auxiliary > surfaces. >

[Mesa-dev] [PATCH] anv: Add anv_render_pass_attachment::store_op

Will be needed for resolving auxiliary surfaces. I didn't add anv_render_pass_attachment::stencil_store_op, as the driver would likely never use it, as stencil surfaces never have auxiliary surfaces. --- src/intel/vulkan/anv_pass.c| 3 +-- src/intel/vulkan/anv_private.h | 1 + 2 files

[Mesa-dev] [PATCH v2 32/34] i965: Use ISL for emitting buffer surface states

--- src/mesa/drivers/dri/i965/brw_binding_tables.c| 2 +- src/mesa/drivers/dri/i965/brw_context.h | 8 -- src/mesa/drivers/dri/i965/brw_state.h | 9 +++ src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 97 +++

[Mesa-dev] [PATCH v2 05/34] isl: Add support for filling out surface states all the way back to gen4

Reviewed-by: Chad Versace --- src/intel/isl/Android.mk | 60 +++ src/intel/isl/Makefile.am | 12 src/intel/isl/Makefile.sources| 13 +++-- src/intel/isl/isl.c | 22 ++

[Mesa-dev] [PATCH v2 10/34] i965/miptree: Add a helper for getting an isl_surf from a miptree

--- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 171 +- src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 6 + 2 files changed, 175 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c

[Mesa-dev] [PATCH v2 31/34] i965/state: Account for the element size in emit_buffer_surface_state

--- src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 11 ++- src/mesa/drivers/dri/i965/gen7_wm_surface_state.c | 9 + src/mesa/drivers/dri/i965/gen8_surface_state.c| 9 + 3 files changed, 16 insertions(+), 13 deletions(-) diff --git

[Mesa-dev] [PATCH v2 12/34] i965/miptree: Add a helper for getting the aux isl_surf from a miptree

--- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 89 +++ src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 5 ++ 2 files changed, 94 insertions(+) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c index

[Mesa-dev] [PATCH v2 27/34] i965/gen7: Use the generic ISL-based path for renderbuffer surfaces

--- src/mesa/drivers/dri/i965/brw_state.h | 7 - src/mesa/drivers/dri/i965/gen7_wm_surface_state.c | 194 +- 2 files changed, 1 insertion(+), 200 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_state.h b/src/mesa/drivers/dri/i965/brw_state.h index

[Mesa-dev] [PATCH v2 01/34] genxml: Add enough XML for gens 4, 4.5, and 5 to get SURFACE_STATE

--- src/intel/genxml/Android.mk | 15 +++ src/intel/genxml/Makefile.am | 3 +++ src/intel/genxml/Makefile.sources | 3 +++ src/intel/genxml/gen4.xml | 52 src/intel/genxml/gen45.xml| 56

[Mesa-dev] [PATCH v2 14/34] i965/blorp: Use the generic ISL path for renderbuffer surfaces on gen8-9

--- src/mesa/drivers/dri/i965/gen8_blorp.c | 99 ++ 1 file changed, 4 insertions(+), 95 deletions(-) diff --git a/src/mesa/drivers/dri/i965/gen8_blorp.c b/src/mesa/drivers/dri/i965/gen8_blorp.c index fcf5a53..b5c600b 100644 ---

[Mesa-dev] [PATCH v2 24/34] i965/gen8: Use the generic ISL-based path for texture surfaces

--- src/mesa/drivers/dri/i965/gen8_surface_state.c | 213 + 1 file changed, 1 insertion(+), 212 deletions(-) diff --git a/src/mesa/drivers/dri/i965/gen8_surface_state.c b/src/mesa/drivers/dri/i965/gen8_surface_state.c index f4375ea..ed26271 100644 ---

[Mesa-dev] [PATCH v2 20/34] i965/blorp: Use a generic ISL path for texture surfaces on gen8

--- src/mesa/drivers/dri/i965/gen8_blorp.c | 47 +++--- 1 file changed, 38 insertions(+), 9 deletions(-) diff --git a/src/mesa/drivers/dri/i965/gen8_blorp.c b/src/mesa/drivers/dri/i965/gen8_blorp.c index b5c600b..918f3d6 100644 ---

[Mesa-dev] [PATCH v2 08/34] isl: Add an auxiliary surface layout enum

--- src/intel/isl/isl.h | 26 ++ 1 file changed, 26 insertions(+) diff --git a/src/intel/isl/isl.h b/src/intel/isl/isl.h index 4aedb11..5011d15 100644 --- a/src/intel/isl/isl.h +++ b/src/intel/isl/isl.h @@ -506,6 +506,32 @@ enum isl_dim_layout {

[Mesa-dev] [PATCH v2 26/34] i965/gen7: Use the generic ISL-based path for texture surfaces

--- src/mesa/drivers/dri/i965/gen7_wm_surface_state.c | 169 +- 1 file changed, 1 insertion(+), 168 deletions(-) diff --git a/src/mesa/drivers/dri/i965/gen7_wm_surface_state.c b/src/mesa/drivers/dri/i965/gen7_wm_surface_state.c index 2a7ae31..bdb4f66 100644 ---

[Mesa-dev] [PATCH 3/3] i965: Delete send-from-GRF only opcodes from implied_mrf_writes().

These only exist post-Sandybridge, and always use send-from-GRF. So inst->base_mrf will be -1, and we will have already returned 0. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_fs.cpp | 18 -- 1 file changed, 18 deletions(-) diff --git

[Mesa-dev] [PATCH 2/3] i965: Drop unnecessary inst->base_mrf = -1 assignments.

These are now unnecessary, as base_mrf is -1 by default. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_fs.cpp | 4 src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 12 2 files changed, 16 deletions(-) diff --git

[Mesa-dev] [PATCH 1/3] i965: Set fs_inst::base_mrf = -1 by default.

On MRF platforms, we need to set base_mrf to the first MRF value we'd like to use for the message. On send-from-GRF platforms, we set it to -1 to indicate that the operation doesn't use MRFs. As MRF platforms are becoming increasingly a thing of the past, we've forgotten to bother with this. It

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/3] i965: Set fs_inst::base_mrf = -1 by default.

Kenneth Graunke writes: > On MRF platforms, we need to set base_mrf to the first MRF value we'd > like to use for the message. On send-from-GRF platforms, we set it to > -1 to indicate that the operation doesn't use MRFs. > > As MRF platforms are becoming increasingly a

Re: [Mesa-dev] [PATCH v2 04/11] glsl: Pack integer and double varyings as flat even if interpolation mode is none

ping On 06/16/2016 12:07 PM, Ian Romanick wrote: > From: Ian Romanick > > v2: Also update varying_matches::compute_packing_class(). Suggested by > Timothy Arceri. > > Signed-off-by: Ian Romanick > Bugzilla:

[Mesa-dev] [PATCHv3] Remove wrongly repeated words in comments

Clean up misrepetitions ('if if', 'the the' etc) found throughout the comments. This has been done manually, after grepping case-insensitively for duplicate if, is, the, then, do, for, an, plus a few other typos corrected in fly-by v2: * proper commit message and non-joke title; * replace

[Mesa-dev] [PATCH 1/4] glx: Call __glXInitVertexArrayState() with a usable gc.

From: Colin McDonald For each indirect context the indirect vertex array state must be initialised by __glXInitVertexArrayState in indirect_vertex_array.c. As noted in the routine header it requires that the glx context has been setup prior to the call, in order to

[Mesa-dev] [PATCH 2/4] glx: Correct opcode typos in __indirect_glTexCoordPointer.

From: Colin McDonald At the same time, replace opcode numbers with names in __indirect_glVertexAttribPointer. Reviewed-by: Matt Turner Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=61907 --- src/glx/indirect_vertex_array.c | 19

[Mesa-dev] [PATCH 3/4] glx: Fix indirect multi-texture GL_DOUBLE coordinate arrays.

From: Colin McDonald There is no draw arrays protocol support for multi-texture coordinate arrays, so it is implemented by sending batches of immediate mode commands from emit_element_none in indirect_vertex_array.c. This sends the target texture unit (which has been

[Mesa-dev] [PATCH 4/4] glx: Undo memory allocation checking damage.

This partially reverts commit d41f5396f3cb619729021390c273f838d92f11fb. That untested commit broke the tex-skipped-unit piglit test and the arbvparray Mesa demo when run with indirect GLX. state->array_state is used during initialization, so its assignment cannot be moved to the end of the

[Mesa-dev] [PATCH v2 30/34] isl/formats: Mark RAW as having a block size of 1 byte

--- src/intel/isl/isl_format_layout.csv | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/isl/isl_format_layout.csv b/src/intel/isl/isl_format_layout.csv index bf86b05..82126da 100644 --- a/src/intel/isl/isl_format_layout.csv +++ b/src/intel/isl/isl_format_layout.csv

[Mesa-dev] [PATCH v2 23/34] i965/state: Add generic surface update functions based on ISL

--- src/mesa/drivers/dri/i965/brw_state.h| 9 ++ src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 184 +++ 2 files changed, 193 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_state.h b/src/mesa/drivers/dri/i965/brw_state.h index c582873..2653d51

[Mesa-dev] [PATCH v2 25/34] i965/gen8: Use the generic ISL-based path for renderbuffer surfaces

--- src/mesa/drivers/dri/i965/brw_state.h | 16 -- src/mesa/drivers/dri/i965/gen8_surface_state.c | 249 + 2 files changed, 2 insertions(+), 263 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_state.h b/src/mesa/drivers/dri/i965/brw_state.h index

[Mesa-dev] [PATCH v2 06/34] isl/state: Add support for OffsetX/Y in surface state

Reviewed-by: Chad Versace --- src/intel/isl/isl.h | 3 +++ src/intel/isl/isl_surface_state.c | 12 2 files changed, 15 insertions(+) diff --git a/src/intel/isl/isl.h b/src/intel/isl/isl.h index 3bf7469..f2128d8 100644 --- a/src/intel/isl/isl.h

[Mesa-dev] [PATCH v2 29/34] i965/gen4-6: Use the generic ISL-based path for texture surfaces

--- src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 96 +--- 1 file changed, 1 insertion(+), 95 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_wm_surface_state.c b/src/mesa/drivers/dri/i965/brw_wm_surface_state.c index ec6c635..944d64d 100644 ---

[Mesa-dev] [PATCH v2 19/34] i965/state: Add a helper for emitting a surface state using isl

--- src/mesa/drivers/dri/i965/brw_state.h| 8 +++ src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 83 2 files changed, 91 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_state.h b/src/mesa/drivers/dri/i965/brw_state.h index b29412e..c582873

[Mesa-dev] [PATCH v2 28/34] i965/gen6: Use the generic ISL-based path for renderbuffer surfaces

--- src/mesa/drivers/dri/i965/gen6_surface_state.c | 100 + 1 file changed, 1 insertion(+), 99 deletions(-) diff --git a/src/mesa/drivers/dri/i965/gen6_surface_state.c b/src/mesa/drivers/dri/i965/gen6_surface_state.c index d892c93..84b8ef4 100644 ---

[Mesa-dev] [PATCH v2 17/34] i965/blorp: Use the generic ISL path for renderbuffer surfaces on gen6

--- src/mesa/drivers/dri/i965/gen6_blorp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/gen6_blorp.c b/src/mesa/drivers/dri/i965/gen6_blorp.c index 5f84ab0..3af9c95 100644 --- a/src/mesa/drivers/dri/i965/gen6_blorp.c +++

[Mesa-dev] [PATCH v2 16/34] i965/blorp: Use the generic ISL path for texture surfaces on gen7

--- src/mesa/drivers/dri/i965/gen7_blorp.c | 97 ++ 1 file changed, 3 insertions(+), 94 deletions(-) diff --git a/src/mesa/drivers/dri/i965/gen7_blorp.c b/src/mesa/drivers/dri/i965/gen7_blorp.c index 00d2840..cd88808 100644 ---

[Mesa-dev] [PATCH v2 03/34] genxml: Add macros and #includes for gens 4-6

Reviewed-by: Chad Versace --- src/intel/genxml/genX_pack.h | 10 +- src/intel/genxml/gen_macros.h | 15 ++- 2 files changed, 23 insertions(+), 2 deletions(-) diff --git a/src/intel/genxml/genX_pack.h b/src/intel/genxml/genX_pack.h index

[Mesa-dev] [PATCH v2 21/34] i965/state: Use ISL for emitting image surfaces

--- src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 32 1 file changed, 21 insertions(+), 11 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_wm_surface_state.c b/src/mesa/drivers/dri/i965/brw_wm_surface_state.c index ab45959..d2bc3ba 100644 ---

[Mesa-dev] [PATCH v2 13/34] i965/blorp: Add a generic ISL-based surface state emit path

--- src/mesa/drivers/dri/i965/brw_blorp.c | 148 ++ src/mesa/drivers/dri/i965/brw_blorp.h | 6 ++ 2 files changed, 154 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_blorp.c b/src/mesa/drivers/dri/i965/brw_blorp.c index 9590968..eac5802 100644 ---

[Mesa-dev] [PATCH v2 33/34] i965: Get rid of gen6_surface_state.c

The only useful thing left was gen6_init_vtable_surface_functions which we can easily put in brw_wm_surface_state.c. --- src/mesa/drivers/dri/i965/Makefile.sources | 1 - src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 7 src/mesa/drivers/dri/i965/gen6_surface_state.c | 48

[Mesa-dev] [PATCH v2 22/34] i965/surface_state: Rename brw_update to gen4_update

We're about to add generic versions which work across gens and those should have the brw name. --- src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_wm_surface_state.c

[Mesa-dev] [PATCH v2 07/34] isl: Add surface formats for color compression surfaces

--- src/intel/isl/isl.h | 21 + src/intel/isl/isl_format_layout.csv | 14 ++ 2 files changed, 35 insertions(+) diff --git a/src/intel/isl/isl.h b/src/intel/isl/isl.h index f2128d8..4aedb11 100644 --- a/src/intel/isl/isl.h +++ b/src/intel/isl/isl.h

[Mesa-dev] [PATCH v2 09/34] isl/state: Add support for handling color control surfaces

--- src/intel/isl/isl.h | 7 +++ src/intel/isl/isl_surface_state.c | 39 --- 2 files changed, 43 insertions(+), 3 deletions(-) diff --git a/src/intel/isl/isl.h b/src/intel/isl/isl.h index 5011d15..5f24d6e 100644 --- a/src/intel/isl/isl.h +++

[Mesa-dev] [PATCH v2 34/34] i965/context: Remove some unnecessary vfuncs

--- src/mesa/drivers/dri/i965/brw_context.h | 17 - src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 3 +-- src/mesa/drivers/dri/i965/gen7_wm_surface_state.c | 1 - src/mesa/drivers/dri/i965/gen8_surface_state.c| 1 - 4 files changed, 1 insertion(+), 21

[Mesa-dev] [PATCH v2 02/34] genxml: Make X/Y Offset field of SURFACE_STATE a uint

THe offset type has special implications that it's intended to be some form of aligned memory address. These assumptions allow it to handle the case where there is some alignment requirement on the offset and the bottom bits are used for other things. However, the offsets in the surface state

[Mesa-dev] [PATCH v2 15/34] i965/blorp: Use the generic ISL path for renderbuffer surfaces on gen7

--- src/mesa/drivers/dri/i965/gen7_blorp.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/gen7_blorp.c b/src/mesa/drivers/dri/i965/gen7_blorp.c index 235f0b5..00d2840 100644 --- a/src/mesa/drivers/dri/i965/gen7_blorp.c +++

[Mesa-dev] [PATCH v2 04/34] isl: Add an ISL_DEV_IS_G4X macro

Reviewed-by: Chad Versace --- src/intel/isl/isl.h | 4 1 file changed, 4 insertions(+) diff --git a/src/intel/isl/isl.h b/src/intel/isl/isl.h index ef86228..3bf7469 100644 --- a/src/intel/isl/isl.h +++ b/src/intel/isl/isl.h @@ -65,6 +65,10 @@ struct brw_image_param;

[Mesa-dev] [PATCH 1/2] vl: add a bicubic interpolation filter(v2)

This is a shader based bicubic interpolater which uses cubic Hermite spline algorithm. v2: set dst_area and dst_clip during scaling (Christian) Signed-off-by: Nayan Deshmukh --- src/gallium/auxiliary/Makefile.sources | 2 +

[Mesa-dev] [PATCH v2 11/34] i965/miptree: Add a helper for getting the ISL clear color from a miptree

--- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 24 src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 4 2 files changed, 28 insertions(+) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c index

[Mesa-dev] [PATCH v2 18/34] i965/blorp: Use the generic ISL path for texture surfaces on gen6

--- src/mesa/drivers/dri/i965/gen6_blorp.c | 77 +- 1 file changed, 2 insertions(+), 75 deletions(-) diff --git a/src/mesa/drivers/dri/i965/gen6_blorp.c b/src/mesa/drivers/dri/i965/gen6_blorp.c index 3af9c95..4620da2 100644 ---

[Mesa-dev] [PATCH v2 00/34] i965: Use ISL for emitting surface state

This series is largely a resend of the earlier series. Most of the precursor ISL cleanup patches have been pushed and tagged for 12.0 for Vulkan. These are the patches actually needed to convert the i965 driver over. The primary change since v1 is a rework of the way color compression surfaces

[Mesa-dev] Fwd: [PATCH] st/vdpau: use bicubic filter for scaling

Hi Andy, Could you test the new patch series that I have sent? It should probably work this time. Thanks, Nayan. On Wed, Jun 22, 2016 at 7:07 PM, Andy Furniss wrote: > Andy Furniss wrote: > > re-testing with an unpatched mesa and return false after PREFERS I see >> the

Re: [Mesa-dev] [PATCH v2 03/11] mesa: Strip arrayness from interface block names in some IO validation

ping I'll have a response to Ilia's feedback shortly. On 06/16/2016 12:06 PM, Ian Romanick wrote: > From: Ian Romanick > > Outputs from the vertex shader need to be able to match > per-vertex-arrayed inputs of later stages. Acomplish this by stripping > one level of

[Mesa-dev] [PATCH 1/2] drm/i915: Add more Kabylake PCI IDs.

The spec has been updated adding new PCI IDs. Signed-off-by: Rodrigo Vivi --- include/drm/i915_pciids.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h index 9094599..87dde1c 100644 ---

[Mesa-dev] [PATCH 1/2] intel: Add more Kabylake PCI IDs.

The spec has been updated adding new PCI IDs. Signed-off-by: Rodrigo Vivi --- intel/intel_chipset.h | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/intel/intel_chipset.h b/intel/intel_chipset.h index e2554c3..0c3ca82 100644 ---

[Mesa-dev] [PATCH 1/2] i956: Add more Kabylake PCI IDs.

The spec has been updated adding new PCI IDs. Signed-off-by: Rodrigo Vivi --- include/pci_ids/i965_pci_ids.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/pci_ids/i965_pci_ids.h b/include/pci_ids/i965_pci_ids.h index fce00da..7a7897f 100644 ---

[Mesa-dev] [PATCH 2/2] i965: Removing PCI IDs that are no longer listed as Kabylake.

This is unusual. Usually IDs listed on early stages of platform definition are kept there as reserved for later use. However these IDs here are not listed anymore in any of steppings and devices IDs tables for Kabylake on configurations overview section of BSpec. So it is better removing them

Re: [Mesa-dev] [Mesa-stable] [PATCH v2 03/11] mesa: Strip arrayness from interface block names in some IO validation

On 06/16/2016 12:12 PM, Ilia Mirkin wrote: > On Thu, Jun 16, 2016 at 3:06 PM, Ian Romanick wrote: >> From: Ian Romanick >> >> Outputs from the vertex shader need to be able to match >> per-vertex-arrayed inputs of later stages. Acomplish this by

[Mesa-dev] [PATCH] nir: Add a NIR_VALIDATE environment variable

It defaults to true so default behavior doesn't change but it allows you to do NIR_VALIDATE=false if you don't want validation. Disabling validation can substantially speed up shader compiles so you frequently want to turn it off if compiler invariants aren't in question. ---

  1   2   >