Re: [Mesa-dev] [PATCH] texgetimage: Check that a multisample tex is not passed to GetTextureSubImage

On 02/02/2017 07:38 PM, Ilia Mirkin wrote: > On Thu, Feb 2, 2017 at 1:36 PM, Ilia Mirkin wrote: >> On Thu, Feb 2, 2017 at 1:29 PM, Eduardo Lima Mitev wrote: >>> OpenGL 4.5 spec, section "8.11.4 Texture Image Queries", page 233 of >>> the PDF states: >>>

Re: [Mesa-dev] [PATCH 3/5] anv: Add support for the PMA fix on Broadwell

On Wed, Feb 01, 2017 at 05:43:53PM -0800, Jason Ekstrand wrote: > In order to get good performance numbers for this, I had to hack up the > driver to whack wm_prog_data::uses_kill to true to emulate a discard and > used the Sascha "shadowmapping" demo. Setting uses_kill to true dropped > the

Re: [Mesa-dev] [PATCH] texgetimage: Check that a multisample tex is not passed to GetTextureSubImage

On Thu, Feb 2, 2017 at 1:58 PM, Eduardo Lima Mitev wrote: > On 02/02/2017 07:38 PM, Ilia Mirkin wrote: >> On Thu, Feb 2, 2017 at 1:36 PM, Ilia Mirkin wrote: >>> On Thu, Feb 2, 2017 at 1:29 PM, Eduardo Lima Mitev wrote: OpenGL 4.5

Re: [Mesa-dev] [PATCH] swr: [rasterizer core] Remove dead code Clipper::ClipScalar()

Reviewed-by: Ilia Mirkin I got confused by this code as well when I was trying to understand the clipper. I think the Clip() function can go too now in the .cpp file (as well as the fwd decl in the header)? On Thu, Feb 2, 2017 at 3:15 PM, Bruce Cherniak

[Mesa-dev] [Bug 99633] rasterizer/core/clip.h:279:49: error: ‘const struct API_STATE’ has no member named ‘linkageCount’

https://bugs.freedesktop.org/show_bug.cgi?id=99633 --- Comment #6 from Bruce Cherniak --- Patch has been generated: https://patchwork.freedesktop.org/patch/136674/ -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for

[Mesa-dev] [PATCH 3/3] main/fboject: default_framebuffer allowed for GetFramebufferParameter

Before 4.5, the default framebuffer was not allowed for GetFramebufferParameter, so it should return INVALID_OPERATION for any call using the default framebuffer. 4.5 included new pnames, and some of them are allowed for the default framebuffer. For the rest, INVALID_OPERATION. From OpenGL 4.5

[Mesa-dev] [PATCH 1/3] main/framebuffer: refactor _mesa_get_color_read_format/type

Current implementation returns the value for the currently bound read framebuffer. GetNamedFramebufferParameteriv allows to get it for any given framebuffer. GetFramebufferParameteriv would be also interested on that method It was refactored by allowing to pass a given framebuffer. If NULL is

Re: [Mesa-dev] [PATCH v2] texgetimage: Add check for the target argument to GetTextureSubImage

On Thu, Feb 2, 2017 at 2:50 PM, Eduardo Lima Mitev wrote: > This is currently not being checked and e.g a multisample texture image is > passed > down to the driver hook. On i965, it is crashing the driver with an assertion: > > intel_mipmap_tree.c:3125: intel_miptree_map:

Re: [Mesa-dev] [PATCH] winsys/amdgpu: avoid potential segfault in amdgpu_bo_map()

Cc stable? Reviewed-by: Marek Olšák Marek On Thu, Feb 2, 2017 at 6:40 PM, Samuel Pitoiset wrote: > cs can be NULL when it comes from r600_buffer_map_sync_with_rings() > to avoid doing the same checks. It was checked for write mappings > but not

Re: [Mesa-dev] [PATCH 2/2] anv: Implement the Sky Lake stencil PMA optimization

On Thu, Feb 2, 2017 at 10:55 AM, Nanley Chery wrote: > On Wed, Feb 01, 2017 at 10:11:42PM -0800, Jason Ekstrand wrote: > > This improves the performance of Dota 2 on my Sky Lake Skull Canyon > > machine by about 2-3%. > > --- > > src/intel/vulkan/anv_private.h | 1 +

[Mesa-dev] [PATCH] mesa: Don't crash when destroying contexts created with no visual.

dEQP-EGL.functional.create_context.no_config tries to create a context with no config, then immediately destroys it. The drawbuffer is never set up, so we can't dereference it asking if it's double buffered, or we'll crash on a null pointer dereference. Just bail early. Signed-off-by: Kenneth

[Mesa-dev] [PATCH] swr: [rasterizer core] Remove dead code Clipper::ClipScalar()

Clipper::ClipScalar() is dead code and should be removed. It is causing an error with gcc-7 because it references a now defunct member. CC: "13.0 17.0" --- src/gallium/drivers/swr/rasterizer/core/clip.h | 39 -- 1 file changed, 39

Re: [Mesa-dev] [PATCH v2] texgetimage: Add check for the target argument to GetTextureSubImage

On 02/02/2017 09:24 PM, Ilia Mirkin wrote: > On Thu, Feb 2, 2017 at 2:50 PM, Eduardo Lima Mitev wrote: >> This is currently not being checked and e.g a multisample texture image is >> passed >> down to the driver hook. On i965, it is crashing the driver with an >> assertion:

Re: [Mesa-dev] [PATCH] texgetimage: Check that a multisample tex is not passed to GetTextureSubImage

On Thu, Feb 2, 2017 at 1:36 PM, Ilia Mirkin wrote: > On Thu, Feb 2, 2017 at 1:29 PM, Eduardo Lima Mitev wrote: >> OpenGL 4.5 spec, section "8.11.4 Texture Image Queries", page 233 of >> the PDF states: >> >> "An INVALID_OPERATION error is generated if

[Mesa-dev] [PATCH 2/3] main/fbobject: implement new 4.5 pnames for GetFramebufferParameter

4.5 added new pnames allowed for GetFramebufferParameter, and GetNamedFramebufferParameter. From OpenGL 4.5 spec, section 9.2.3 "Framebuffer Object Queries" (quoting the paragraph with only the new pnames, not all the supported): "pname may also be one of DOUBLEBUFFER,

[Mesa-dev] [Bug 99618] AVX Intrinsics Run in GUI thread only

https://bugs.freedesktop.org/show_bug.cgi?id=99618 Bruce Cherniak changed: What|Removed |Added Status|NEW |ASSIGNED ---

Re: [Mesa-dev] [PATCH] texgetimage: Check that a multisample tex is not passed to GetTextureSubImage

On Thu, Feb 2, 2017 at 1:29 PM, Eduardo Lima Mitev wrote: > OpenGL 4.5 spec, section "8.11.4 Texture Image Queries", page 233 of > the PDF states: > > "An INVALID_OPERATION error is generated if texture is the name of a > buffer > or multisample texture." > >

[Mesa-dev] [PATCH] Revert "radeonsi: decrease the number of texture slots to 24"

From: Marek Olšák This reverts commit bdd860e3076655519d45bd66936ef7be9b7dda63. Requested by a game developer. Cc: 17.0 --- src/gallium/drivers/radeonsi/si_state.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [Freedreno] WebProcess crash on DB410c

btw, where exactly is it crashing? I grabbed the WebKitForWayland tree.. if I'm looking at the right thing, the only place where it should try to create a pbuffer is in Source/WebCore/platform/graphics/egl/GLContextEGL.cpp and that looks like it should only be a fallback after

[Mesa-dev] [PATCH 4/7] glsl: Prehash to avoid hashing two times when inserting

--- src/compiler/glsl/opt_constant_variable.cpp | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/compiler/glsl/opt_constant_variable.cpp b/src/compiler/glsl/opt_constant_variable.cpp index 1c06ffe675..a07d64067b 100644 ---

[Mesa-dev] [PATCH 2/7] util: Avoid computing hash twice in string_to_uint_map

This is not a hot path, but when we have the functionality we should take advantage of it. --- src/util/string_to_uint_map.h | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/util/string_to_uint_map.h b/src/util/string_to_uint_map.h index e0533ec6ea..3248696e88

[Mesa-dev] [PATCH 3/7] glsl: Prehash to avoid computing the hash twice

--- src/compiler/glsl/opt_copy_propagation_elements.cpp | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/compiler/glsl/opt_copy_propagation_elements.cpp b/src/compiler/glsl/opt_copy_propagation_elements.cpp index 9f79fa9202..d318417f6c 100644 ---

[Mesa-dev] [PATCH 6/7] nir: Prehash in instr_set to avoid unnecessary hashing

This should prove benefitial in the common case of inserting and not rewriting anything. --- src/compiler/nir/nir_instr_set.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/compiler/nir/nir_instr_set.c b/src/compiler/nir/nir_instr_set.c index

[Mesa-dev] [PATCH 5/7] glsl: Prehash in constant propagation

--- src/compiler/glsl/opt_constant_propagation.cpp | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/compiler/glsl/opt_constant_propagation.cpp b/src/compiler/glsl/opt_constant_propagation.cpp index 4039512097..553de9c803 100644 ---

[Mesa-dev] [PATCH 1/7] mesa: Avoid unnecessary string hashing in symbol table

This is one of our largest users of hash_table_insert. This causes some code duplication and a parameter to pass in, so might not be worth it. --- src/mesa/program/symbol_table.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git

[Mesa-dev] [PATCH 7/7] glsl: Prehash in refcount hash table

_mesa_hash_table_search is one of our hottest function according to perf. Callgrind shows the refcounting as one of the major users of the searching functions. We can reduce the pain by prehashing, so that we avoid hash two times when inserting in the table. On a short shader-db run (with

[Mesa-dev] [PATCH v3] texgetimage: Add check for the effective target to GetTextureSubImage

OpenGL 4.5 spec, section "8.11.4 Texture Image Queries", page 233 of the PDF states: "An INVALID_OPERATION error is generated if texture is the name of a buffer or multisample texture." This is currently not being checked and e.g a multisample texture image can be passed down to the

[Mesa-dev] [PATCH 0/7] Prehash all the things

This series converts multiple users of the hash table to reuse the hash when searching, and then inserting an element if the search did not find an entry. Since we have the functionality we should take advantage of it to lower the number of calls to the hashing functions. I'm not quite sold on the

[Mesa-dev] [PATCH v2 3/5] anv: Add support for the PMA fix on Broadwell

In order to get good performance numbers for this, I had to hack up the driver to whack wm_prog_data::uses_kill to true to emulate a discard and used the Sascha "shadowmapping" demo. Setting uses_kill to true dropped the framerate on the demo by 25-30%. Enabling the PMA fix brought it back up to

Re: [Mesa-dev] [PATCH] glsl: Allow compatibility shaders with MESA_GL_VERSION_OVERRIDE=...

Tested-by: Dylan Baker signature.asc Description: signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] isl: Add assertions for render target swizzle restrictions

On Tue, Jan 31, 2017 at 06:51:12PM -0800, Jason Ekstrand wrote: > --- > src/intel/isl/isl_surface_state.c | 32 > 1 file changed, 32 insertions(+) > > diff --git a/src/intel/isl/isl_surface_state.c > b/src/intel/isl/isl_surface_state.c > index b735478..c7b220b

Re: [Mesa-dev] [PATCH 2/2] anv: Implement the Sky Lake stencil PMA optimization

On Thu, Feb 2, 2017 at 10:55 AM, Nanley Chery wrote: > On Wed, Feb 01, 2017 at 10:11:42PM -0800, Jason Ekstrand wrote: > > This improves the performance of Dota 2 on my Sky Lake Skull Canyon > > machine by about 2-3%. > > --- > > src/intel/vulkan/anv_private.h | 1 +

Re: [Mesa-dev] [PATCH] Revert "radeonsi: decrease the number of texture slots to 24"

Reviewed-by: Samuel Pitoiset This should also fix the glActiveTexture() errors with The Wither 3. On 02/02/2017 07:46 PM, Marek Olšák wrote: From: Marek Olšák This reverts commit bdd860e3076655519d45bd66936ef7be9b7dda63. Requested by a game

Re: [Mesa-dev] [PATCH] isl: Add assertions for render target swizzle restrictions

On Thu, Feb 02, 2017 at 12:28:02PM -0800, Jason Ekstrand wrote: > On Thu, Feb 2, 2017 at 11:09 AM, Nanley Chery wrote: > > > On Tue, Jan 31, 2017 at 06:51:12PM -0800, Jason Ekstrand wrote: > > > --- > > > src/intel/isl/isl_surface_state.c | 32

Re: [Mesa-dev] [PATCH v3] texgetimage: Add check for the effective target to GetTextureSubImage

Reviewed-by: Ilia Mirkin Although come to think of it, perhaps this *would* be better as if (!legal_getteximage_target(ctx, texObj->Target, true)) { _mesa_error(ctx, GL_INVALID_OPERATION, "%s(invalid texture)", caller); return; } or something. [No

[Mesa-dev] [PATCH v2 2/2] anv: Implement the Sky Lake stencil PMA optimization

This improves the performance of Dota 2 on my Sky Lake Skull Canyon machine by about 2-3%. Reviewed-by: Lionel Landwerlin --- src/intel/vulkan/anv_private.h | 1 + src/intel/vulkan/gen8_cmd_buffer.c | 157 -

Re: [Mesa-dev] [PATCH] configure.ac: explicitly require libdrm for dri classic drivers.

On 3 Feb. 2017 03:11, "Chad Versace" wrote: On Thu 02 Feb 2017, Chad Versace wrote: > On Thu 02 Feb 2017, Dave Airlie wrote: > > From: Dave Airlie > > > > Although this might come from somewhere else require it explicitly. > > > > Signed-off-by:

Re: [Mesa-dev] [PATCH] swr: [rasterizer core] Remove dead code Clipper::ClipScalar()

I followed up with a v2 that includes the bugzilla reference. Good point, I’ll look into following up with a patch to remove Clip(). Thanks for the quick review. > On Feb 2, 2017, at 2:26 PM, Ilia Mirkin wrote: > > Reviewed-by: Ilia Mirkin > > I

Re: [Mesa-dev] [PATCH 2/2] anv: Implement the Sky Lake stencil PMA optimization

On Wed, Feb 01, 2017 at 10:11:42PM -0800, Jason Ekstrand wrote: > This improves the performance of Dota 2 on my Sky Lake Skull Canyon > machine by about 2-3%. > --- > src/intel/vulkan/anv_private.h | 1 + > src/intel/vulkan/gen8_cmd_buffer.c | 155 > - >

[Mesa-dev] [PATCH v2] texgetimage: Add check for the target argument to GetTextureSubImage

This is currently not being checked and e.g a multisample texture image is passed down to the driver hook. On i965, it is crashing the driver with an assertion: intel_mipmap_tree.c:3125: intel_miptree_map: Assertion `mt->num_samples <= 1' failed. Similar check exists for GetTextureSubImage.

Re: [Mesa-dev] [PATCH] isl: Add assertions for render target swizzle restrictions

On Thu, Feb 2, 2017 at 11:09 AM, Nanley Chery wrote: > On Tue, Jan 31, 2017 at 06:51:12PM -0800, Jason Ekstrand wrote: > > --- > > src/intel/isl/isl_surface_state.c | 32 > > 1 file changed, 32 insertions(+) > > > > diff --git

[Mesa-dev] [PATCH v2] swr: [rasterizer core] Remove dead code Clipper::ClipScalar()

v2: includes bugzilla reference, same code change Clipper::ClipScalar() is dead code and should be removed. It is causing an error with gcc-7 because it references a now defunct member. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99633 CC: "13.0 17.0"

[Mesa-dev] [PATCH] radeon/ac: move common llvm build functions to a separate file.

From: Dave Airlie Suggested by Marek. Signed-off-by: Dave Airlie --- src/amd/Makefile.sources | 2 + src/amd/common/ac_llvm_build.c| 752 ++ src/amd/common/ac_llvm_build.h

Re: [Mesa-dev] [PATCH 2/2] anv: Implement the Sky Lake stencil PMA optimization

On Thu, Feb 2, 2017 at 3:01 PM, Nanley Chery wrote: > On Thu, Feb 02, 2017 at 01:55:30PM -0800, Jason Ekstrand wrote: > > On Thu, Feb 2, 2017 at 1:45 PM, Nanley Chery > wrote: > > > > > On Thu, Feb 02, 2017 at 01:37:56PM -0800, Nanley Chery wrote: >

Re: [Mesa-dev] [PATCH 4/7] glsl: Prehash to avoid hashing two times when inserting

2017-02-02 21:57 GMT+01:00 Thomas Helland : > --- > src/compiler/glsl/opt_constant_variable.cpp | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/src/compiler/glsl/opt_constant_variable.cpp > b/src/compiler/glsl/opt_constant_variable.cpp >

Re: [Mesa-dev] [PATCH 6/7] nir: Prehash in instr_set to avoid unnecessary hashing

On Thu, Feb 2, 2017 at 12:57 PM, Thomas Helland wrote: > This should prove benefitial in the common case of inserting > and not rewriting anything. > --- > src/compiler/nir/nir_instr_set.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH 2/2] anv: Implement the Sky Lake stencil PMA optimization

On Thu, Feb 02, 2017 at 01:37:56PM -0800, Nanley Chery wrote: > On Thu, Feb 02, 2017 at 12:53:33PM -0800, Jason Ekstrand wrote: > > On Thu, Feb 2, 2017 at 10:55 AM, Nanley Chery wrote: > > > > > On Wed, Feb 01, 2017 at 10:11:42PM -0800, Jason Ekstrand wrote: > > > > This

Re: [Mesa-dev] [PATCH 2/2] anv: Implement the Sky Lake stencil PMA optimization

On Thu, Feb 2, 2017 at 1:45 PM, Nanley Chery wrote: > On Thu, Feb 02, 2017 at 01:37:56PM -0800, Nanley Chery wrote: > > On Thu, Feb 02, 2017 at 12:53:33PM -0800, Jason Ekstrand wrote: > > > On Thu, Feb 2, 2017 at 10:55 AM, Nanley Chery > wrote: > >

Re: [Mesa-dev] [PATCH v2 2/2] anv/blorp: Disable resolves for transparent black clears

On Thu, Feb 02, 2017 at 08:15:30AM -0800, Nanley Chery wrote: Polite ping. > Signed-off-by: Nanley Chery > --- > src/intel/vulkan/anv_blorp.c | 10 -- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/src/intel/vulkan/anv_blorp.c

Re: [Mesa-dev] [PATCH v3] texgetimage: Add check for the effective target to GetTextureSubImage

On 02/02/2017 10:05 PM, Ilia Mirkin wrote: > Reviewed-by: Ilia Mirkin > > Although come to think of it, perhaps this *would* be better as > > if (!legal_getteximage_target(ctx, texObj->Target, true)) { >_mesa_error(ctx, GL_INVALID_OPERATION, >

Re: [Mesa-dev] [PATCH] Revert "radeonsi: decrease the number of texture slots to 24"

On 02.02.2017 19:46, Marek Olšák wrote: From: Marek Olšák This reverts commit bdd860e3076655519d45bd66936ef7be9b7dda63. Requested by a game developer. Cc: 17.0 We're really being pushed towards bindless_texture :) Reviewed-by:

Re: [Mesa-dev] [PATCH 2/2] anv: Implement the Sky Lake stencil PMA optimization

On Thu, Feb 02, 2017 at 01:55:30PM -0800, Jason Ekstrand wrote: > On Thu, Feb 2, 2017 at 1:45 PM, Nanley Chery wrote: > > > On Thu, Feb 02, 2017 at 01:37:56PM -0800, Nanley Chery wrote: > > > On Thu, Feb 02, 2017 at 12:53:33PM -0800, Jason Ekstrand wrote: > > > > On Thu,

Re: [Mesa-dev] [PATCH 2/2] anv: Implement the Sky Lake stencil PMA optimization

On Thu, Feb 02, 2017 at 03:10:21PM -0800, Jason Ekstrand wrote: > On Thu, Feb 2, 2017 at 3:01 PM, Nanley Chery wrote: > > > On Thu, Feb 02, 2017 at 01:55:30PM -0800, Jason Ekstrand wrote: > > > On Thu, Feb 2, 2017 at 1:45 PM, Nanley Chery > > wrote:

[Mesa-dev] X.Org Foundation Membership Renewal

On January 19th all xorg members were expired as part of the regular process to remove inactive members. If you would still like to be a member of the X.Org Foundation, please renew your membership. To renew or to become a first time member, go to https://members.x.org/ . For renewals, log in

Re: [Mesa-dev] [PATCH v2 1/2] anv/cmd_buffer: Don't temporarily enable CCS_E within a render pass

On Thu, Feb 02, 2017 at 01:38:45PM -0800, Jason Ekstrand wrote: > Perf numbers in the commit message would be nice > How's the following? Reclaims about 1.95% FPS for Dota 2 on some configurations. > Reviewed-by: Jason Ekstrand Thanks! > > On Thu, Feb 2, 2017 at

Re: [Mesa-dev] [PATCH v2 1/2] anv/cmd_buffer: Don't temporarily enable CCS_E within a render pass

Perf numbers in the commit message would be nice Reviewed-by: Jason Ekstrand On Thu, Feb 2, 2017 at 8:15 AM, Nanley Chery wrote: > Compressing a render target and decompressing it in the same > single-subpass render pass may waste bandwidth. While

Re: [Mesa-dev] [PATCH 2/2] anv: Implement the Sky Lake stencil PMA optimization

On Thu, Feb 02, 2017 at 12:53:33PM -0800, Jason Ekstrand wrote: > On Thu, Feb 2, 2017 at 10:55 AM, Nanley Chery wrote: > > > On Wed, Feb 01, 2017 at 10:11:42PM -0800, Jason Ekstrand wrote: > > > This improves the performance of Dota 2 on my Sky Lake Skull Canyon > > >

Re: [Mesa-dev] [PATCH 3/5] intel/isl: Add a formats_are_ccs_e_compatible helper

On Wed, 2017-02-01 at 14:40 -0800, Jason Ekstrand wrote: > --- >  src/intel/blorp/blorp_blit.c |  6 ++ >  src/intel/isl/isl.h  |  4 >  src/intel/isl/isl_format.c   | 31 +++ >  3 files changed, 41 insertions(+) > > diff --git

Re: [Mesa-dev] [PATCH 2/2] radeonsi/ac: move tbuffer store and buffer load to shared code.

On 02.02.2017 00:15, Dave Airlie wrote: From: Dave Airlie These are all reuseable by radv. Signed-off-by: Dave Airlie --- src/amd/common/ac_llvm_util.c| 154 + src/amd/common/ac_llvm_util.h| 44 +-

Re: [Mesa-dev] [PATCH 5/5] anv/pipeline: Be smarter about depth/stencil state

Thanks, that's pretty clean :) Reviewed-by: Lionel Landwerlin On 02/02/17 01:43, Jason Ekstrand wrote: This seemed to help Dota 2 by a percent or two. --- src/intel/vulkan/genX_pipeline.c | 133 +-- 1 file changed, 99

[Mesa-dev] [Bug 99638] Mesa opengles Peppa Pig and openggles2 smurfs on Radeon PowerPC and PPC64

https://bugs.freedesktop.org/show_bug.cgi?id=99638 Bug ID: 99638 Summary: Mesa opengles Peppa Pig and openggles2 smurfs on Radeon PowerPC and PPC64 Product: Mesa Version: unspecified Hardware: PowerPC OS:

Re: [Mesa-dev] [PATCH 1/2] genxml: Add the CACHE_MODE_0 register on gen9

Reviewed-by: Lionel Landwerlin On 02/02/17 06:11, Jason Ekstrand wrote: --- src/intel/genxml/gen9.xml | 28 1 file changed, 28 insertions(+) diff --git a/src/intel/genxml/gen9.xml b/src/intel/genxml/gen9.xml index 671322b..ec29d13

Re: [Mesa-dev] [PATCH] vbo: process buffer binding state changes on draw when recording

Reviewed-by: Marek Olšák On Feb 1, 2017 10:11 PM, "Ilia Mirkin" wrote: > The VBO module keeps track of any vbo buffers. It updates this list when > receiving an InvalidateState call, however this never happens when > recording draws right now. Make

Re: [Mesa-dev] [PATCH 1/5] intel/isl: Rename supports_lossless_compression to supports_ccs_e

Patch series is Reviewed-by: Samuel Iglesias Gonsálvez Just one minor comment on patch 3. Sam On Wed, 2017-02-01 at 14:40 -0800, Jason Ekstrand wrote: > The term "lossless compression" could potentially mean multisample > color compression, single-sample color

[Mesa-dev] [Bug 99638] Mesa opengles Peppa Pig and openggles2 smurfs on Radeon PowerPC and PPC64

https://bugs.freedesktop.org/show_bug.cgi?id=99638 --- Comment #1 from intermedi...@hotmail.com --- I have more screenshots but can only insert one example. Qemu sdl or gtk,gl=on gave blue color Kubuntu task bar, desktop and icon is blue. -- You are receiving this

Re: [Mesa-dev] [PATCH 1/5] anv: Disable stencil writes when both write masks are zero

Reviewed-by: Lionel Landwerlin On 02/02/17 04:07, Jason Ekstrand wrote: The only mechanism Vulkan provides for disabling stencil writes is to set the stencil write mask to 0. Since that is dynamic state, we have to move handle it late during command buffer

Re: [Mesa-dev] [PATCH 3/5] anv: Add support for the PMA fix on Broadwell

Oops, miss on the v2. Indeed clearing up the variables in case info == NULL is good! Reviewed-by: Lionel Landwerlin On 02/02/17 04:12, Jason Ekstrand wrote: In order to get good performance numbers for this, I had to hack up the driver to whack

Re: [Mesa-dev] [PATCH] st/va: remove assert for single slice

Am 01.02.2017 um 13:59 schrieb Nayan Deshmukh: we anyway allow for multiple slices Signed-off-by: Nayan Deshmukh --- src/gallium/state_trackers/va/picture_mpeg12.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/gallium/state_trackers/va/picture_mpeg12.c

Re: [Mesa-dev] Samping GL_R32UI?

Thank you for the help! It was indeed an incomplete texture issue. Setting the MIN/MAG filters to GL_NEAREST ended up resolving it. I did have one other question -- why is this considered a silent non-error condition? Even with KHR_debug enabled and set to use DEBUG_SEVERITY_NOTIFICATION, I don't

Re: [Mesa-dev] [PATCH] anv/pass: Store the depth-stencil attachment's last subpass index

Reviewed-by: Samuel Iglesias Gonsálvez On Wed, 2017-02-01 at 17:21 -0800, Nanley Chery wrote: > Commit 968ffd6c868af7226e8f889573eef709888151cb stored the last > subpass > index of all the attachments but that of the depth-stencil > attachment. > This could cause depth

Re: [Mesa-dev] [PATCH 2/2] radv/ac: use shared thread id code

For the series: Reviewed-by: Nicolai Hähnle On 02.02.2017 00:41, Dave Airlie wrote: From: Dave Airlie Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 44 ++--- 1 file

Re: [Mesa-dev] [PATCH 2/2] radv/ac: move to using shared emit_ddxy code.

For the series: Reviewed-by: Nicolai Hähnle On 02.02.2017 00:56, Dave Airlie wrote: From: Dave Airlie Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 75 - 1 file

Re: [Mesa-dev] [PATCH 0/5] anv: Implement the depth PMA fix on Broadwell

Not sure what happened to patches 1,2 & 4... If you have a branch somewhere, I'll give the remaining Rbs here. Thanks On 02/02/17 01:43, Jason Ekstrand wrote: This little series does a few little cleanups as well as implements the PMA fix on Broadwell. The cleanups are focussed around letting

Re: [Mesa-dev] [PATCH 0/5] anv: Implement the depth PMA fix on Broadwell

Oh, ignore me, my mail client is a bit crap :( On 02/02/17 11:08, Lionel Landwerlin wrote: Not sure what happened to patches 1,2 & 4... If you have a branch somewhere, I'll give the remaining Rbs here. Thanks On 02/02/17 01:43, Jason Ekstrand wrote: This little series does a few little

[Mesa-dev] [PATCH 1/3] ilo: EOL unplumb unmaintained gallium drv from winsys

This is no longer actively maintained and is just accumulating bitrot. Signed-off-by: Edward O'Callaghan --- .../auxiliary/pipe-loader/pipe_loader_drm.c| 5 --- src/gallium/auxiliary/target-helpers/drm_helper.h | 29 -

[Mesa-dev] [PATCH 3/3] ilo: EOL unmaintained older gallium intel driver

This is no longer actively maintained and is just accumulating bitrot. Signed-off-by: Edward O'Callaghan --- src/gallium/drivers/ilo/Android.mk | 35 - src/gallium/drivers/ilo/Automake.inc | 11 - src/gallium/drivers/ilo/Makefile.am

[Mesa-dev] [PATCH 2/3] ilo: EOL drop unmaintained gallium drv from buildsys

This is no longer actively maintained and is just accumulating bitrot. Signed-off-by: Edward O'Callaghan --- Android.mk | 4 ++-- Makefile.am | 2 +- configure.ac| 12

Re: [Mesa-dev] [PATCH 3/5] anv: Add support for the PMA fix on Broadwell

Reviewed-by: Lionel Landwerlin On 02/02/17 01:43, Jason Ekstrand wrote: In order to get good performance numbers for this, I had to hack up the driver to whack wm_prog_data::uses_kill to true to emulate a discard and used the Sascha "shadowmapping" demo. Setting

Re: [Mesa-dev] [PATCH] mesa: disable on-disk shader cache unless supported by the driver

On Thu, 2 Feb 2017 17:32:58 +1100 Timothy Arceri wrote: > On Thu, 2 Feb 2017 16:17:02 +1100 > Timothy Arceri wrote: > > > This will stop people enabling the shader cache on drivers that > > don't support it via the env vars. Also this will be

Re: [Mesa-dev] [PATCH] mesa: Don't crash when destroying contexts created with no visual.

Reviewed-by: Samuel Iglesias Gonsálvez On Thu, 2017-02-02 at 13:14 -0800, Kenneth Graunke wrote: > dEQP-EGL.functional.create_context.no_config tries to create a > context > with no config, then immediately destroys it.  The drawbuffer is > never > set up, so we can't

[Mesa-dev] [Bug 99467] [radv] DOOM 2016 + wine. Green screen everywhere (but can be started)

https://bugs.freedesktop.org/show_bug.cgi?id=99467 --- Comment #11 from Bogomil Vasilev --- (In reply to Dave Airlie from comment #10) > Please retest with the radv-wip-doom-wine branch. > > It should be rendering properly now. Works perfect! I don't experience any issues

Re: [Mesa-dev] [PATCH v2 2/2] anv: Implement the Sky Lake stencil PMA optimization

On 17-02-02 13:27:05, Jason Ekstrand wrote: This improves the performance of Dota 2 on my Sky Lake Skull Canyon machine by about 2-3%. Reviewed-by: Lionel Landwerlin --- src/intel/vulkan/anv_private.h | 1 + src/intel/vulkan/gen8_cmd_buffer.c | 157

Re: [Mesa-dev] [PATCH v2 1/2] anv/cmd_buffer: Don't temporarily enable CCS_E within a render pass

On Thu, Feb 2, 2017 at 3:49 PM, Nanley Chery wrote: > On Thu, Feb 02, 2017 at 01:38:45PM -0800, Jason Ekstrand wrote: > > Perf numbers in the commit message would be nice > > > > How's the following? > >Reclaims about 1.95% FPS for Dota 2 on some configurations. >

Re: [Mesa-dev] [PATCH 1/2] configure: libdrm is a single package, no split different versions

On Wed, Feb 1, 2017 at 9:36 PM, Emil Velikov wrote: > On 2 February 2017 at 02:33, Ilia Mirkin wrote: >> The intent of the libdrm_driver version limits has always been to not >> burden the "other" drivers with updating their libdrm unless really >>

Re: [Mesa-dev] [PATCH] radv: fix compute shared memory stores since 64-bit.

Reviewed-by: Edward O'Callaghan On 02/03/2017 12:04 PM, Dave Airlie wrote: > From: Dave Airlie > > These regressed and caused doom to stop loading. > > Fixes: > 03724af26 radv/ac: Implement Float64 load/store var. > > Signed-off-by: Dave

Re: [Mesa-dev] [Freedreno] WebProcess crash on DB410c

On Thu, Feb 2, 2017 at 2:13 AM, Sivasubramanian Patchaiperumal wrote: > Hi, > I'm trying to port WPE on DB410c with Westeros compositor, but the > webprocess crashes due to null sharingcontext. Webprocess fails to create gl > context as eglChooseConfig

[Mesa-dev] [PATCH] android: fix droid_create_image_from_prime_fd_yuv for YV12

Earlier changes introduced is_ycrcb flag which checks the component order of u and v components. Condition for setting the flag was incorrect, with ycrcb we are supposed to have cr before cb. This patch (together with a fix in our gralloc) fixes corrupted rendering from 'test-opengl-gl2_yuvtex'

Re: [Mesa-dev] [PATCH 2/5] genxml: Add the CACHE_MODE_1 register on gen8

Reviewed-by: Lionel Landwerlin On 02/02/17 01:43, Jason Ekstrand wrote: --- src/intel/genxml/gen8.xml | 21 + 1 file changed, 21 insertions(+) diff --git a/src/intel/genxml/gen8.xml b/src/intel/genxml/gen8.xml index 970e637..32ed764 100644

Re: [Mesa-dev] [PATCH 2/2] anv: Implement the Sky Lake stencil PMA optimization

Reviewed-by: Lionel Landwerlin The documentation has the following sentence for both CACHE_MODE_0 & CACHE_MODE_1 : "Before changing the value of this register, GFX pipeline must be idle i.e. full flush is required." That seems coherent with a command

Re: [Mesa-dev] [PATCH] android: fix droid_create_image_from_prime_fd_yuv for YV12

Reviewed-by: Marta Lofstedt > -Original Message- > From: Palli, Tapani > Sent: Thursday, February 2, 2017 2:27 PM > To: mesa-dev@lists.freedesktop.org > Cc: tf...@chromium.org; Lofstedt, Marta ; Palli, > Tapani

Re: [Mesa-dev] [PATCH] configure.ac: describe what all the LIBDRM_*REQUIRED macros mean

LGTM Reviewed-by: Plamena Manolova On Thu, Feb 2, 2017 at 2:32 AM, Emil Velikov wrote: > From: Emil Velikov > > They are versions of the respective libdrm package. They are _not_ the > version of libdrm[.so]

Re: [Mesa-dev] [PATCH] mesa: disable on-disk shader cache unless supported by the driver

You can just add a function to initialize the cache that drivers can optionally call. Then you don't need the const flag. Marek On Feb 2, 2017 11:45 AM, "Timothy Arceri" wrote: On Thu, 2 Feb 2017 17:32:58 +1100 Timothy Arceri wrote: > On Thu, 2

Re: [Mesa-dev] [PATCH 3/5] travis: correct libdrm required regex to also track libdrm itself

On 2 February 2017 at 02:53, Andres Gomez wrote: > LGTM > > Reviewed-by: Andres Gomez > Reviewed-by: Rhys Kidd > > On Wed, 2017-02-01 at 22:30 +, Emil Velikov wrote: > > From: Emil Velikov > > > > The

Re: [Mesa-dev] [PATCH 4/5] anv/pipeline: Make a copy of VkPipelineDepthStencilStateCreateinfo

Reviewed-by: Lionel Landwerlin On 02/02/17 01:43, Jason Ekstrand wrote: --- src/intel/vulkan/genX_pipeline.c | 34 ++ 1 file changed, 18 insertions(+), 16 deletions(-) diff --git a/src/intel/vulkan/genX_pipeline.c

[Mesa-dev] [Bug 94194] New Account Request

https://bugs.freedesktop.org/show_bug.cgi?id=94194 Plamena Manolova changed: What|Removed |Added Attachment #121812|Public PGP Key |Public

Re: [Mesa-dev] [PATCH] android: fix droid_create_image_from_prime_fd_yuv for YV12

LGTM :) Reviewed-by: Plamena Manolova On Thu, Feb 2, 2017 at 12:27 PM, Tapani Pälli wrote: > Earlier changes introduced is_ycrcb flag which checks the component > order of u and v components. Condition for setting the flag was > incorrect,

Re: [Mesa-dev] [Freedreno] WebProcess crash on DB410c

hmm, ok, so it is a *client* process that is crashing? The wayland winsys (used by client processes, as opposed to gbm/drm winsys used by compositor) does support pbuffers. BR, -R On Thu, Feb 2, 2017 at 7:43 AM, Sivasubramanian Patchaiperumal wrote: >

[Mesa-dev] [PATCH] radv: fix compute shared memory stores since 64-bit.

From: Dave Airlie These regressed and caused doom to stop loading. Fixes: 03724af26 radv/ac: Implement Float64 load/store var. Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff

Re: [Mesa-dev] [PATCH] radv/ac: correctly size shared memory usage.

Reviewed-by: Edward O'Callaghan On 02/03/2017 12:47 PM, Dave Airlie wrote: > From: Dave Airlie > > We count the number of slots used, but slots are vec4 sized, > so we have to scale by 16 not 4. > > Signed-off-by: Dave Airlie

[Mesa-dev] [Bug 99662] DOTA2 Vulkan graphics corruption--radv: Handle command buffers that need scratch memory

https://bugs.freedesktop.org/show_bug.cgi?id=99662 --- Comment #2 from charlie --- glxinfo reports: OpenGL renderer string: Gallium 0.4 on AMD FIJI (DRM 3.9.0 / 4.10.0-rc3+, LLVM 5.0.0) But that LLVM might be a couple of weeks old. I will recompile todays LLVM git. --

  1   2   >