Re: [Mesa-dev] [PATCH] radv: fetch sample index via fmask for image coord as well.

On Wed, Feb 22, 2017 at 5:31 AM, Dave Airlie wrote: > From: Dave Airlie > > This follows the txf_ms code, I can't figure out why amdgpu-pro > doesn't do this in their shaders, they must know someone we don't. > > This fixes: >

[Mesa-dev] [PATCH] glsl: enable early_fragment_tests implicitly with post_depth_coverage

From: Iago Toral Quiroga From ARB_post_depth_coverage: "This extension allows the fragment shader to control whether values in gl_SampleMaskIn[] reflect the coverage after application of the early depth and stencil tests. This feature

Re: [Mesa-dev] [PATCH 0/8] gallium: A number of video code fixes

Am 21.02.2017 um 21:52 schrieb Thomas Hellstrom: A couple of fixes / improvements for things I've encountered while looking through and testing the video code in preparation for a virtual hardware video driver. Reviewed-by: Christian König for the whole set.

[Mesa-dev] [PATCH] vl: u_upload_alloc might fail to allocate buffer in bicubic filter

Signed-off-by: Nayan Deshmukh --- src/gallium/auxiliary/vl/vl_bicubic_filter.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/gallium/auxiliary/vl/vl_bicubic_filter.c b/src/gallium/auxiliary/vl/vl_bicubic_filter.c index

Re: [Mesa-dev] [PATCH 0/8] gallium: A number of video code fixes

On 02/22/2017 09:56 AM, Christian König wrote: > Am 21.02.2017 um 21:52 schrieb Thomas Hellstrom: >> A couple of fixes / improvements for things I've encountered while >> looking >> through and testing the video code in preparation for a virtual >> hardware video >> driver. > > Reviewed-by:

Re: [Mesa-dev] [PATCH 5/8] gallium: add get_disk_shader_cache() callback

On 22.02.2017 07:23, Michel Dänzer wrote: On 22/02/17 12:45 PM, Timothy Arceri wrote: +get_disk_shader_cache +^ + +Returns a pointer to driver-specific on-disk shader cache. If the driver +failed to create the cache or does not support an on-disk shader cache NULL is

Re: [Mesa-dev] V4 TGSI on-disk shader cache

On 22.02.2017 04:45, Timothy Arceri wrote: Changes in V4: - split tgsi cache code into its own file - add missing fallback for tgsi cache miss - share the sha1 generated by the load function with the store function like in the glsl ir cache. - add get_disk_shader_cache() to the pass-throughs

Re: [Mesa-dev] [PATCH 1/4] gallium/u_queue: fix random crashes when the app calls exit()

Reviewed-by: Nicolai Hähnle On 21.02.2017 22:05, Marek Olšák wrote: From: Marek Olšák This fixes: vdpauinfo: ../lib/CodeGen/TargetPassConfig.cpp:579: virtual void llvm::TargetPassConfig::addMachinePasses(): Assertion `TPI && IPI &&

Re: [Mesa-dev] [PATCH 3/4] gallium/hud: prevent an infinite loop

On 21.02.2017 22:09, Marek Olšák wrote: From: Marek Olšák v2: use UINT64_MAX / 11 Reviewed-by: Nicolai Hähnle --- src/gallium/auxiliary/hud/hud_context.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH mesa v2] glx: add GLXdispatchIndex sort check

Signed-off-by: Eric Engestrom --- v2: make sure the list is in the order C's strcmp uses (Ilia) Ilia: I used LC_ALL instead of LANG, as it takes precedence (ie. LANG=C in this script would be overridden by LC_ALL=en_US in the environment). ---

Re: [Mesa-dev] [PATCH 1/8] util/disk_cache: fix bug with deleting old cache dirs

On Wed, Feb 22, 2017 at 5:45 AM, Timothy Arceri wrote: > If there was more than a single directory in the .cache/mesa dir > then it would only remove one (or none) of the directories. > > Apparently Valgrind was also reporting: > Conditional jump or move depends on

Re: [Mesa-dev] [PATCH 4/8] st/mesa: implement a tgsi on-disk shader cache

On 22.02.2017 04:45, Timothy Arceri wrote: Implements a tgsi cache for the OpenGL state tracker. V2: add support for compute shaders --- src/mesa/Makefile.sources | 2 + src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 6 + src/mesa/state_tracker/st_program.c| 27 +-

Re: [Mesa-dev] [PATCH 6/8] ddebug/rbug/trace: add get_disk_shader_cache() to pass-throughs

On 22.02.2017 04:45, Timothy Arceri wrote: --- src/gallium/drivers/ddebug/dd_screen.c | 9 + src/gallium/drivers/rbug/rbug_screen.c | 9 + src/gallium/drivers/trace/tr_screen.c | 21 + 3 files changed, 39 insertions(+) diff --git

[Mesa-dev] [PATCH] isl/state: fix assert on raw buffer surface state minimum size

From IVB PRM, SURFACE_STATE::Height: "For typed buffer and structured buffer surfaces, the number of entries in the buffer ranges from 1 to 2^27 . For raw buffer surfaces, the number of entries in the buffer is the number of bytes which can range from 1 to 2^30." The minimum value is 1,

Re: [Mesa-dev] [PATCH 8/8] r600/radeonsi: enable glsl/tgsi on-disk cache

On 22.02.2017 04:45, Timothy Arceri wrote: For gpu generations that use LLVM we create a timestamp string containing both the LLVM and Mesa build times, otherwise we just use the Mesa build time. Reviewed-by: Marek Olšák Reviewed-by: Edward O'Callaghan

Re: [Mesa-dev] [PATCH 1/2] st/vdpau: Don't reallocate video surfaces on putBitsYCbCr format mismatch

Am 22.02.2017 um 14:42 schrieb Thomas Hellstrom: mplayer likes putting YV12 data, and if there is a buffer format mismatch, the vdpau state tracker would try to reallocate the video surface as an YV12 surface. A virtual driver doesn't like reallocating and doesn't like YV12 surfaces, so before

[Mesa-dev] [Bug 99604] kwin_x11 disabling compositing with mesa 17

https://bugs.freedesktop.org/show_bug.cgi?id=99604 --- Comment #1 from Fabio Coatti --- same issue with mesa 17.0.0 -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the

Re: [Mesa-dev] [PATCH 8/8] r600/radeonsi: enable glsl/tgsi on-disk cache

Am Mittwoch, 22. Februar 2017, 04:45:46 CET schrieb Timothy Arceri: > For gpu generations that use LLVM we create a timestamp string > containing both the LLVM and Mesa build times, otherwise we just > use the Mesa build time. > > Reviewed-by: Marek Olšák > Reviewed-by:

Re: [Mesa-dev] [PATCH 1/8] util/disk_cache: fix bug with deleting old cache dirs

On 22/02/17 21:43, Grazvydas Ignotas wrote: On Wed, Feb 22, 2017 at 5:45 AM, Timothy Arceri wrote: If there was more than a single directory in the .cache/mesa dir then it would only remove one (or none) of the directories. Apparently Valgrind was also reporting:

[Mesa-dev] [PATCH 1/3] anv/blorp/i965: blump blorp's pipe controls back into the embedding driver

At the moment, we don't seem to miss any workaround from having blorp's pipe controls not tracked by the embedding driver, but this should make things more robust if something new comes up. Signed-off-by: Lionel Landwerlin --- src/intel/blorp/blorp_genX_exec.h

[Mesa-dev] [PATCH 2/3] anv: centralize PIPE_CONTROLs

This allows us to monitor pipe controls and apply workarounds in a single location if needed. Signed-off-by: Lionel Landwerlin --- src/intel/vulkan/anv_genX.h| 26 ++ src/intel/vulkan/anv_private.h | 8

[Mesa-dev] [PATCH 3/3] anv: implement WaCsStallAtEveryFourthPipecontrol for gen7

Signed-off-by: Lionel Landwerlin --- src/intel/vulkan/anv_batch_chain.c | 5 + src/intel/vulkan/anv_pipeline.c| 2 ++ src/intel/vulkan/anv_private.h | 4 src/intel/vulkan/genX_cmd_buffer.c | 21 +++-- 4 files changed, 30

[Mesa-dev] [PATCH 1/2] st/vdpau: Don't reallocate video surfaces on putBitsYCbCr format mismatch

mplayer likes putting YV12 data, and if there is a buffer format mismatch, the vdpau state tracker would try to reallocate the video surface as an YV12 surface. A virtual driver doesn't like reallocating and doesn't like YV12 surfaces, so before trying the reallocation, check whether we can

[Mesa-dev] [PATCH 2/2] st/va: Fix up YV12 to NV12 putImage conversion

Use the utility u_copy_nv12_from_yv12 to implement this similarly to how it's been done in the VPAU state tracker. The old code mixed up planes and fields and didn't correctly handle video surfaces in interlaced format. Signed-off-by: Thomas Hellstrom ---

[Mesa-dev] [PATCH 0/3] anv/blorp/i965: pipe control blumping

Hi, While looking at blorp, I noticed we weren't looking at blorp's pipe controls instructions in the i965 driver. As far as I can tell this isn't a problem with regards to workarounds at the moment, but it feels like we should have them centralized just in case something changes. We can also

Re: [Mesa-dev] [PATCH 0/8] gallium: A number of video code fixes

On 02/22/2017 04:46 PM, Christian König wrote: > Am 22.02.2017 um 16:31 schrieb Thomas Hellstrom: >> On 02/22/2017 04:00 PM, Emil Velikov wrote: >>> On 22 February 2017 at 09:30, Thomas Hellstrom >>> wrote: On 02/22/2017 09:56 AM, Christian König wrote: > Am

Re: [Mesa-dev] [PATCH] isl/state: fix assert on raw buffer surface state minimum size

Seems reasonable Are you sure this isn't somehow required on old hardware? Reviewed-by: Jason Ekstrand On Wed, Feb 22, 2017 at 3:39 AM, Samuel Iglesias Gonsálvez < sigles...@igalia.com> wrote: > From IVB PRM, SURFACE_STATE::Height: > > "For typed buffer and structured

[Mesa-dev] [PATCH] anv: ensure that we do not emit negative Depth in 3DSTATE_DEPTH_BUFFER

This fixes a number of new CTS tests that would crash otherwise: dEQP-VK.pipeline.render_to_image.* --- src/intel/vulkan/genX_cmd_buffer.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c index

[Mesa-dev] [Bug 99604] kwin_x11 disabling compositing with mesa 17

https://bugs.freedesktop.org/show_bug.cgi?id=99604 Emil Velikov changed: What|Removed |Added QA Contact|mesa-dev@lists.freedesktop.

Re: [Mesa-dev] [PATCH] anv: ensure that we do not emit negative Depth in 3DSTATE_DEPTH_BUFFER

I can't reproduce on the vulkan-cts-next-dev (I just pull -r, so I shouldn't miss anything right?). On 22/02/17 14:45, Iago Toral Quiroga wrote: This fixes a number of new CTS tests that would crash otherwise: dEQP-VK.pipeline.render_to_image.* --- src/intel/vulkan/genX_cmd_buffer.c | 3 ++-

Re: [Mesa-dev] [PATCH 5/8] gallium: add get_disk_shader_cache() callback

On 22/02/17 07:58 PM, Nicolai Hähnle wrote: > On 22.02.2017 07:23, Michel Dänzer wrote: >> On 22/02/17 12:45 PM, Timothy Arceri wrote: >>> >>> +get_disk_shader_cache >>> +^ >>> + >>> +Returns a pointer to driver-specific on-disk shader cache. If the >>> driver >>> +failed to

Re: [Mesa-dev] [PATCH 0/8] gallium: A number of video code fixes

Am 22.02.2017 um 16:31 schrieb Thomas Hellstrom: On 02/22/2017 04:00 PM, Emil Velikov wrote: On 22 February 2017 at 09:30, Thomas Hellstrom wrote: On 02/22/2017 09:56 AM, Christian König wrote: Am 21.02.2017 um 21:52 schrieb Thomas Hellstrom: A couple of fixes /

[Mesa-dev] [PATCH 1/2] st/vdpau: Provide YV12 to NV12 putBits conversion v2

mplayer likes putting YV12 data, and if there is a buffer format mismatch, the vdpau state tracker would try to reallocate the video surface as an YV12 surface. A virtual driver doesn't like reallocating and doesn't like YV12 surfaces, so if we can't support YV12, try an YV12 to NV12 conversion

Re: [Mesa-dev] [PATCH 0/8] gallium: A number of video code fixes

On 02/22/2017 04:00 PM, Emil Velikov wrote: > On 22 February 2017 at 09:30, Thomas Hellstrom wrote: >> On 02/22/2017 09:56 AM, Christian König wrote: >>> Am 21.02.2017 um 21:52 schrieb Thomas Hellstrom: A couple of fixes / improvements for things I've encountered while

Re: [Mesa-dev] [PATCH] anv: ensure that we do not emit negative Depth in 3DSTATE_DEPTH_BUFFER

On Wed, Feb 22, 2017 at 6:45 AM, Iago Toral Quiroga wrote: > This fixes a number of new CTS tests that would crash otherwise: > dEQP-VK.pipeline.render_to_image.* > --- > src/intel/vulkan/genX_cmd_buffer.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff

Re: [Mesa-dev] [PATCH 2/3] Model INTEL perf query backend after query object BE

On Wednesday, February 22, 2017 10:35:24 AM PST Robert Bragg wrote: > On Wed, Feb 22, 2017 at 1:24 AM, Kenneth Graunke > wrote: > > On Wednesday, February 15, 2017 1:37:36 PM PST Robert Bragg wrote: [snip] > >> diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h >

Re: [Mesa-dev] [PATCH] glx/glvnd: Fix GLXdispatchIndex sorting

On 02/20/2017 01:32 AM, Hans de Goede wrote: Hi Emil, On 16-02-17 16:38, Emil Velikov wrote: Hi Hans, On 6 February 2017 at 13:09, Hans de Goede wrote: Commit 8bca8d89ef3b ("glx/glvnd: Fix dispatch function names and indices") fixed the sorting of the array initializers

[Mesa-dev] [PATCH 0/6] Removal of PIPE_CAP_USER_INDEX_BUFFERS (take 3)

Hi, This version is hopefully final. I moved the helper code into a separate commit and fixed a pipe_resource leak there. (thanks Brian for the clue) The rest didn't really change. Please review, Marek ___ mesa-dev mailing list

[Mesa-dev] [PATCH 6/6] gallium: remove PIPE_CAP_USER_INDEX_BUFFERS

From: Marek Olšák all drivers support it Reviewed-by: Nicolai Hähnle --- src/gallium/docs/source/screen.rst | 4 src/gallium/drivers/etnaviv/etnaviv_screen.c | 1 - src/gallium/drivers/freedreno/freedreno_screen.c | 1 -

Re: [Mesa-dev] [PATCH] vl: u_upload_alloc might fail to allocate buffer in bicubic filter

It would be better to return from the function in that case. Marek On Wed, Feb 22, 2017 at 9:25 AM, Nayan Deshmukh wrote: > Signed-off-by: Nayan Deshmukh > --- > src/gallium/auxiliary/vl/vl_bicubic_filter.c | 8 +--- > 1 file changed,

Re: [Mesa-dev] [PATCH 3/3] anv: Enable MSAA compression

On Wed 22 Feb 2017, Jason Ekstrand wrote: > On Wed, Feb 22, 2017 at 11:09 AM, Chad Versace > wrote: > > > On Mon 20 Feb 2017, Jason Ekstrand wrote: > > > This just enables basic MSAA compression (no fast clears) for all > > > multisampled surfaces. This improves the

Re: [Mesa-dev] [PATCH] vl: u_upload_alloc might fail to allocate buffer in bicubic filter

OK sounds good. Reviewed-by: Marek Olšák Marek On Wed, Feb 22, 2017 at 9:16 PM, Nayan Deshmukh wrote: > On Thu, Feb 23, 2017 at 1:34 AM, Marek Olšák wrote: >> It would be better to return from the function in that case. >> >

Re: [Mesa-dev] [PATCH 5/8] gallium: add get_disk_shader_cache() callback

On 22.02.2017 16:19, Michel Dänzer wrote: On 22/02/17 07:58 PM, Nicolai Hähnle wrote: On 22.02.2017 07:23, Michel Dänzer wrote: On 22/02/17 12:45 PM, Timothy Arceri wrote: +get_disk_shader_cache +^ + +Returns a pointer to driver-specific on-disk shader cache. If the

Re: [Mesa-dev] [PATCH] glsl: enable early_fragment_tests implicitly with post_depth_coverage

Reviewed-by: Marek Olšák Marek On Wed, Feb 22, 2017 at 9:06 AM, Iago Toral Quiroga wrote: > From: Iago Toral Quiroga > > From ARB_post_depth_coverage: > >"This extension allows the fragment shader to

Re: [Mesa-dev] [PATCH] glsl: enable early_fragment_tests implicitly with post_depth_coverage

On Wed, Feb 22, 2017 at 12:06 AM, Iago Toral Quiroga wrote: > From: Iago Toral Quiroga Oops :) ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH] vl: u_upload_alloc might fail to allocate buffer in bicubic filter

On Thu, Feb 23, 2017 at 1:34 AM, Marek Olšák wrote: > It would be better to return from the function in that case. > We can still execute it as it will display the video properly though the edges will be a bit jagged but it won't be much noticeable in most cases. Regards, Nayan

Re: [Mesa-dev] [PATCH] glsl: enable early_fragment_tests implicitly with post_depth_coverage

On Wed, Feb 22, 2017 at 9:11 PM, Matt Turner wrote: > On Wed, Feb 22, 2017 at 12:06 AM, Iago Toral Quiroga > wrote: >> From: Iago Toral Quiroga > > Oops :) Sneaky product placement. :) Marek

[Mesa-dev] [PATCH] GLX: Generate the libglvnd dispatch stub functions.

This patch adds a script to generate the dispatch stubs for libglvnd, instead of using a manually-edited list of functions. This should avoid problems in the future with the stub lists getting out of sync or out of order. I put the scripts into a new src/generate/ directory, because there's some

Re: [Mesa-dev] [PATCH] vl: u_upload_alloc might fail to allocate buffer in bicubic filter

Pushed, thanks. Marek On Wed, Feb 22, 2017 at 9:20 PM, Nayan Deshmukh wrote: > Can you please push the patch. > > On Thu, Feb 23, 2017 at 1:46 AM, Marek Olšák wrote: >> OK sounds good. >> >> Reviewed-by: Marek Olšák >> >> Marek

Re: [Mesa-dev] [PATCH 0/6] Removal of PIPE_CAP_USER_INDEX_BUFFERS (take 3)

On 02/22/2017 01:00 PM, Marek Olšák wrote: Hi, This version is hopefully final. I moved the helper code into a separate commit and fixed a pipe_resource leak there. (thanks Brian for the clue) The rest didn't really change. Please review, For the series, Reviewed-by: Brian Paul

Re: [Mesa-dev] [PATCH 4/4] mesa: Avoid out-of-bounds stack read via _mesa_Materiali

For 1, 3, 4: Reviewed-by: Marek Olšák I need some time to review patch 2 unless someone else beats me to it. Marek On Wed, Feb 22, 2017 at 8:04 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > MATERIALFV may end up

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/4] glsl: fix use-after-free when processing array re-declarations

I thought we already landed a different patch for this. I'll look through the archives when I get back in front of a computer... On February 22, 2017 11:05:26 AM Nicolai Hähnle wrote: From: Nicolai Hähnle When determining whether the array is

Re: [Mesa-dev] [PATCH 8/8] r600/radeonsi: enable glsl/tgsi on-disk cache

On Tue, Feb 21, 2017 at 7:45 PM, Timothy Arceri wrote: > For gpu generations that use LLVM we create a timestamp string > containing both the LLVM and Mesa build times, otherwise we just > use the Mesa build time. Why not use the build id for Mesa?

[Mesa-dev] [PATCH 2/2] st/wgl: flush with ST_FLUSH_WAIT before releasing shared contexts

Before releasing a shared context, flush the context with ST_FLUSH_WAIT to make sure all commands are executed. This ensures that rendering to any shared resources is completed before they will be referenced by another context. Fixes an intermittent flickering with Photoshop. (VMware bug#

[Mesa-dev] [PATCH 1/2] st: add ST_FLUSH_WAIT to st_context_flush()

When st_context_flush() is called with ST_FLUSH_WAIT, the function will return after the fence is completed. --- src/gallium/include/state_tracker/st_api.h | 1 + src/mesa/state_tracker/st_manager.c| 7 +++ 2 files changed, 8 insertions(+) diff --git

Re: [Mesa-dev] [PATCH] anv/blorp/clear_subpass: Only set surface clear color for fast clears

This patch is also needed for MSAA compression. On Tue, Feb 21, 2017 at 7:31 PM, Jason Ekstrand wrote: > Not all clear colors are valid. In particular, on Broadwell and > earlier, only 0/1 colors are allowed in surface state. No CTS tests are > affected outright by this

Re: [Mesa-dev] [PATCH 8/8] r600/radeonsi: enable glsl/tgsi on-diskcache

Am Mittwoch, 22. Februar 2017, 22:27:42 CET schrieb Timothy Arceri: > On 23/02/17 01:57, Marc Dietrich wrote: > > Am Mittwoch, 22. Februar 2017, 15:48:18 CET schrieb Emil Velikov: > >> On 22 February 2017 at 13:31, Marc Dietrich wrote: > >>> Am Mittwoch, 22. Februar 2017,

[Mesa-dev] [PATCH 1/2] haiku: build fixes around debug defines

From: Jerome Duval --- src/gallium/auxiliary/util/u_debug.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/auxiliary/util/u_debug.h b/src/gallium/auxiliary/util/u_debug.h index 7da7f53..63940b7 100644 ---

Re: [Mesa-dev] [PATCH 1/1] clover: Dump linked module to a different file

> On Feb 22, 2017, at 07:51, Jan Vesely wrote: > > This allows to pass the generated files directly to llc or bugpoint. > Note that if program links multiple binaries they will still be in the same > file, the module name is "link”. Can you add a counter ID or

Re: [Mesa-dev] [PATCH 8/8] r600/radeonsi: enable glsl/tgsi on-disk cache

On 23/02/17 01:57, Marc Dietrich wrote: Am Mittwoch, 22. Februar 2017, 15:48:18 CET schrieb Emil Velikov: On 22 February 2017 at 13:31, Marc Dietrich wrote: Am Mittwoch, 22. Februar 2017, 04:45:46 CET schrieb Timothy Arceri: For gpu generations that use LLVM we create a

Re: [Mesa-dev] [PATCH 8/8] r600/radeonsi: enable glsl/tgsi on-disk cache

On 23/02/17 08:46, Matt Turner wrote: On Tue, Feb 21, 2017 at 7:45 PM, Timothy Arceri wrote: For gpu generations that use LLVM we create a timestamp string containing both the LLVM and Mesa build times, otherwise we just use the Mesa build time. Why not use the build

Re: [Mesa-dev] [PATCH 8/8] r600/radeonsi: enable glsl/tgsi on-disk cache

On Wed, Feb 22, 2017 at 2:12 PM, Timothy Arceri wrote: > On 23/02/17 08:46, Matt Turner wrote: >> On Tue, Feb 21, 2017 at 7:45 PM, Timothy Arceri >> wrote: >>> >>> For gpu generations that use LLVM we create a timestamp string >>> containing both the

[Mesa-dev] [PATCH 2/2] haiku/winsys: fix dt prototype args

From: Jerome Duval --- src/gallium/winsys/sw/hgl/hgl_sw_winsys.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/winsys/sw/hgl/hgl_sw_winsys.c b/src/gallium/winsys/sw/hgl/hgl_sw_winsys.c index 89dd547..f7bc907 100644 ---

Re: [Mesa-dev] [PATCH 0/8] gallium: A number of video code fixes

Am 22.02.2017 um 18:05 schrieb Thomas Hellstrom: On 02/22/2017 05:54 PM, Christian König wrote: Am 22.02.2017 um 17:23 schrieb Thomas Hellstrom: On 02/22/2017 04:46 PM, Christian König wrote: Am 22.02.2017 um 16:31 schrieb Thomas Hellstrom: On 02/22/2017 04:00 PM, Emil Velikov wrote: On 22

Re: [Mesa-dev] [PATCH 2/3] Model INTEL perf query backend after query object BE

On Wed, Feb 22, 2017 at 1:24 AM, Kenneth Graunke wrote: > On Wednesday, February 15, 2017 1:37:36 PM PST Robert Bragg wrote: >> Instead of using the same backend interface as AMD_performance_monitor >> this defines a dedicated INTEL_performance_query interface that is >>

[Mesa-dev] [PATCH] st/mesa: inform the driver of framebuffer changes before compute dispatches

From: Nicolai Hähnle Even though compute shaders cannot access the framebuffer, there is a synchronization issue when a compute dispatch accesses a texture that was previously bound and drawn to as a framebuffer. Section 9.3 (Feedback Loops Between Textures and the

Re: [Mesa-dev] [PATCH 3/3] anv: Enable MSAA compression

On Wed, Feb 22, 2017 at 11:09 AM, Chad Versace wrote: > On Mon 20 Feb 2017, Jason Ekstrand wrote: > > This just enables basic MSAA compression (no fast clears) for all > > multisampled surfaces. This improves the framerate of the Sascha > > "multisampling" demo by 76%

Re: [Mesa-dev] [PATCH 3/3] anv: Enable MSAA compression

On Mon 20 Feb 2017, Jason Ekstrand wrote: > This just enables basic MSAA compression (no fast clears) for all > multisampled surfaces. This improves the framerate of the Sascha > "multisampling" demo by 76% on my Sky Lake laptop. Running Talos on > medium settings with 8x MSAA, this improves the

Re: [Mesa-dev] [PATCH 8/8] r600/radeonsi: enable glsl/tgsi on-disk cache

On 22 February 2017 at 14:57, Marc Dietrich wrote: > Am Mittwoch, 22. Februar 2017, 15:48:18 CET schrieb Emil Velikov: >> On 22 February 2017 at 13:31, Marc Dietrich wrote: >> > Am Mittwoch, 22. Februar 2017, 04:45:46 CET schrieb Timothy Arceri: >> >> For gpu

Re: [Mesa-dev] [PATCH v2] i965: Implement INTEL_performance_query backend

On Wed, Feb 22, 2017 at 1:26 AM, Kenneth Graunke wrote: > On Thursday, February 16, 2017 5:20:37 AM PST Robert Bragg wrote: > [snip] >> + switch(obj->query->kind) { > > Space after "switch" please. Oh, oops, repeated that in a few places. > > Patch 3 is: > Reviewed-by:

[Mesa-dev] [PATCH 0/4] Various memory error fixes

Hi, this is a bunch of patches for random problems that were all found by running with -fsanitize=address. Please review! Thanks, Nicolai -- src/compiler/glsl/ast_to_hir.cpp | 55 +++- src/mesa/main/api_loopback.c | 3 +- src/mesa/main/api_validate.c

[Mesa-dev] [PATCH 4/4] mesa: Avoid out-of-bounds stack read via _mesa_Materiali

From: Nicolai Hähnle MATERIALFV may end up reading up to 4 floats from the passed parameter. This should really set a GL_INVALID_ENUM error in the cases where it matters, but does anybody really care? Found by ASAN in piglit gl-1.0-beginend-coverage. ---

[Mesa-dev] [PATCH 2/4] glsl: fix use-after-free when processing array re-declarations

From: Nicolai Hähnle When determining whether the array is implicitly sized, we must avoid accessing var->data.mode (around line 5270), because var may have been deleted. Instead of adding yet another ternary condition based on earlier == NULL, refactor

[Mesa-dev] [PATCH 3/4] st/glsl_to_tgsi: avoid iterating past the head of the instruction list

From: Nicolai Hähnle exec_node::get_prev() does not guard against going past the beginning of the list, so we need to add explicit checks here. Found by ASAN in piglit arb_shader_storage_buffer_object-rendering. Cc: mesa-sta...@lists.freedesktop.org ---

[Mesa-dev] [PATCH 1/4] mesa/main: fix MultiDrawElements[BaseVertex] validation of primcount

From: Nicolai Hähnle primcount must be a GLsizei as in the signature for MultiDrawElements or bad things can happen. Furthermore, an error should be flagged when primcount is negative (plus there is an argument about whether it should be flagged when primcount is 0, but

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/4] glsl: fix use-after-free when processing array re-declarations

On 23/02/17 07:44, Ian Romanick wrote: I thought we already landed a different patch for this. I'll look through the archives when I get back in front of a computer... It looks like the patches are still waiting on a review: https://patchwork.freedesktop.org/series/19382/ On February

[Mesa-dev] [PATCH 06/13] anv: convert header generation in anv_entrypoints_gen.py to mako

This produces an identical file except for whitespace. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 75 ++--- 1 file changed, 41 insertions(+), 34 deletions(-) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py

[Mesa-dev] [PATCH 02/13] anv: Use python style in anv_entrypoints_gen.py

These are all fairly small cleanups/tweaks that don't really deserve their own patch. - Prefer comprehensions to map() and filter(), since they're faster - replace unused variables with _ - Use 4 spaces of indent - drop semicolons from the end of lines - Don't use parens around if conditions -

[Mesa-dev] [PATCH 01/13] anv: anv_entrypoints_gen.py: use a main function

This is just good practice. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 458 1 file changed, 233 insertions(+), 225 deletions(-) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py

[Mesa-dev] [PATCH 00/13] cleanup anv_entrpoints_gen.py

There are a number of small style cleanups and simplifications in this series, but the main changes are: - use a mako template to generate the header and code rather than prints - be python 3.x ready (the goal isn't to write python 3 code, but to write code that is easy to port or hybridize)

[Mesa-dev] [PATCH 05/13] anv: split main into two functions in anv_entrypoints_gen.py

This is groundwork for the next patches, it will allows porting the header and the code to mako separately, and will also allow both to be run simultaneously. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 96 +

Re: [Mesa-dev] [PATCH 02/13] anv: Use python style in anv_entrypoints_gen.py

On Wed, Feb 22, 2017 at 3:15 PM, Dylan Baker wrote: > These are all fairly small cleanups/tweaks that don't really deserve > their own patch. > > - Prefer comprehensions to map() and filter(), since they're faster > - replace unused variables with _ > - Use 4 spaces of

Re: [Mesa-dev] [PATCH 02/13] anv: Use python style in anv_entrypoints_gen.py

Quoting Jason Ekstrand (2017-02-22 15:28:50) > On Wed, Feb 22, 2017 at 3:15 PM, Dylan Baker wrote: > > These are all fairly small cleanups/tweaks that don't really deserve > their own patch. > > - Prefer comprehensions to map() and filter(), since they're faster

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/4] glsl: fix use-after-free when processing array re-declarations

On 02/22/2017 03:08 PM, Timothy Arceri wrote: > On 23/02/17 07:44, Ian Romanick wrote: >> I thought we already landed a different patch for this. I'll look >> through the archives when I get back in front of a computer... >> > > It looks like the patches are still waiting on a review: > >

Re: [Mesa-dev] [PATCH 1/4 v3] gallium: implement util_clear_texture

For the series: Reviewed-by: Roland Scheidegger (I'll commit this tomorrow). Roland Am 22.02.2017 um 16:56 schrieb Lars Hamre: > v3: have util_clear_texture mirror the pipe function (Roland Scheidegger) > v2: rework util clear functions such that they operate on a resource

Re: [Mesa-dev] [PATCH 4/4] mesa: Avoid out-of-bounds stack read via _mesa_Materiali

On 02/22/2017 11:04 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > MATERIALFV may end up reading up to 4 floats from the passed parameter. > > This should really set a GL_INVALID_ENUM error in the cases where it > matters, but does anybody really care? Probably

Re: [Mesa-dev] [PATCH 4/4] mesa: Avoid out-of-bounds stack read via _mesa_Materiali

indeed 1, 3 & 4 - good catches, Reviewed-by: Edward O'Callaghan On 02/23/2017 07:29 AM, Marek Olšák wrote: > For 1, 3, 4: > > Reviewed-by: Marek Olšák > > I need some time to review patch 2 unless someone else beats me to it. > > Marek > >

[Mesa-dev] [PATCH 1/5] trace: remove pipe_resource wrapping

From: Marek Olšák Not needed. ddebug does the same thing. The limitation is that drivers can only use pipe_resource::screen through pipe_resource_reference. This unbreaks trace, because pipe_context uploaders aren't wrapped, so trace doesn't understand buffers returned by

[Mesa-dev] [PATCH 4/5] st/mesa: set blend state for PBO readbacks

From: Marek Olšák Cc: 13.0 17.0 --- src/mesa/state_tracker/st_cb_readpixels.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/state_tracker/st_cb_readpixels.c b/src/mesa/state_tracker/st_cb_readpixels.c index

[Mesa-dev] [PATCH 2/5] st/mesa: don't check st->vp in update_clip

From: Marek Olšák The clip state is updated before VS, so it can be NULL for the first draw call. Just remove the unnecessary dependency on st->vp. --- src/mesa/state_tracker/st_atom_clip.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git

[Mesa-dev] [PATCH 5/5] st/mesa: don't update unrelated states in non-draw calls such as Clear

From: Marek Olšák If a VAO isn't bound and u_vbuf isn't enabled because of the Core profile, we'll get user vertex buffers in drivers if we update vertex buffers in glClear. So don't do that. This fixes a regression since disabling u_vbuf for Core profiles. ---

[Mesa-dev] [PATCH 3/5] st/mesa: reset sample_mask, min_sample, and render_condition for PBO ops

From: Marek Olšák Cc: 13.0 17.0 --- src/mesa/state_tracker/st_cb_readpixels.c | 7 +++ src/mesa/state_tracker/st_cb_texture.c| 6 ++ 2 files changed, 13 insertions(+) diff --git a/src/mesa/state_tracker/st_cb_readpixels.c

Re: [Mesa-dev] [PATCH 3/3] radv/ac: handle gs->copy shader clip distances.

Series is: Reviewed-by: Bas Nieuwenhuizen On Tue, Feb 21, 2017 at 5:14 AM, Dave Airlie wrote: > From: Dave Airlie > > This fixes up the clip distance passing between the geometry > shader and the copy shader. It packs the clip

Re: [Mesa-dev] [PATCH 1/2] glsl: fix heap-use-after-free in ast_declarator_list::hir()

On 02/09/2017 06:23 AM, Samuel Iglesias Gonsálvez wrote: > The get_variable_being_redeclared() function can free 'var' because > a re-declaration of an unsized array variable can establish the size, so > we set the array type to the 'earlier' declaration and free 'var' as it is > not needed

Re: [Mesa-dev] [PATCH 1/4] mesa/main: fix MultiDrawElements[BaseVertex] validation of primcount

On 02/22/2017 11:04 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > primcount must be a GLsizei as in the signature for MultiDrawElements > or bad things can happen. > > Furthermore, an error should be flagged when primcount is negative > (plus there is an argument

[Mesa-dev] [RESEND 12/13] anv: don't use Element.get in anv_entrypoints_gen.py

This has the potential to mask errors, since Element.get works like dict.get, returning None if the element isn't found. I think the reason that Element.get was used is that vulkan has one extension that isn't really an extension, and thus is missing the 'protect' field. This patch changes the

[Mesa-dev] [RESEND 04/13] anv: don't pass xmlfile via stdin anv_entrypoints_gen.py

It's slow, and has the potential for encoding issues. Signed-off-by: Dylan Baker --- src/intel/vulkan/Makefile.am| 6 ++ src/intel/vulkan/anv_entrypoints_gen.py | 6 +- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git

[Mesa-dev] [RESEND 03/13] anv: make constants capitals in anv_entrypoints_gen.py

Again, it's standard python style. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 38 - 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py

[Mesa-dev] [RESEND 01/13] anv: anv_entrypoints_gen.py: use a main function

This is just good practice. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 458 1 file changed, 233 insertions(+), 225 deletions(-) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py

[Mesa-dev] [RESEND 08/13] anv: generate anv_entrypoints.{h, c} in one command

This changes the python generator to write the files itself, rather than piping them out. This has a couple of advantages: first, it encapsulates the encoding. Second, it ensures that the header file and code file are generated at the same time with the same data. Signed-off-by: Dylan Baker

  1   2   >