Ah that's what I did first, but figured it was probably in accurate naming
after that
On Sat, 25 Feb 2017 at 08:21 Axel Davy wrote:
> Hi Mike,
>
> We really want not to use user index buffers when csmt is active (thus
> the !This->csmt_active).
> This should be a one line
This fixes 4a883966c1f74f43afc145d2c3d27af7b8c5e01a where the pipe cap
was removed
Now USER_INDEX_BUFFERS are always enabled remove the check and only
check for cmst_active
v2: Axel pointed out the code was still needed when cmst was inactive,
Rebase on master too
Fixes: 4a883966c1f7
Hi Mike,
We really want not to use user index buffers when csmt is active (thus
the !This->csmt_active).
This should be a one line patch to just remove the part
GET_PCAP(USER_INDEX_BUFFERS)
Yours,
Axel Davy
On 25/02/2017 06:23, Mike Lothian wrote:
This fixes
There's too many negatives, not sure if this should really be "if
(This->cmst_active) {" or not
On Sat, 25 Feb 2017 at 10:42 Mike Lothian wrote:
> This fixes 4a883966c1f74f43afc145d2c3d27af7b8c5e01a where the pipe cap
> was removed
>
> Now USER_INDEX_BUFFERS are always
https://bugs.freedesktop.org/show_bug.cgi?id=99319
--- Comment #7 from Bas Nieuwenhuizen ---
I think this is actually fixed in Mesa git. I get 60 fps for the platformer
demo now.
--
You are receiving this mail because:
You are the assignee for the bug.
You are the QA
commit 4a88396 dropped 'PIPE_CAP_USER_INDEX_BUFFERS' however
this case was missed.
Signed-off-by: Edward O'Callaghan
---
src/gallium/state_trackers/nine/device9.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
This bit is definitely not necessary because subroutine_list
can be used instead. This frees one more bit in the flags.q
struct which is nice because arb_bindless_texture will need
4 bits for the new layout qualifiers.
No piglit regressions found (including compiler tests) with
"-t subroutine".
Are we better off just checking for cmst_active now? Since that's all we're
checking
On Sat, 25 Feb 2017 at 11:12 Edward O'Callaghan
wrote:
> commit 4a88396 dropped 'PIPE_CAP_USER_INDEX_BUFFERS' however
> this case was missed.
>
> Signed-off-by: Edward O'Callaghan
From: Mike Lothian
This fixes 4a883966c1f74f43afc145d2c3d27af7b8c5e01a where the
PIPE_CAP was removed.
Now USER_INDEX_BUFFERS are always enabled remove the check and only
check for cmst_active directly.
v2: Axel pointed out the code was still needed when cmst was inactive,
yes sorry disregard this one, I got report this independently.
sorry for the noise.
On 02/25/2017 10:18 PM, Mike Lothian wrote:
> Are we better off just checking for cmst_active now? Since that's all
> we're checking
>
> On Sat, 25 Feb 2017 at 11:12 Edward O'Callaghan
>
I think my question regarding the double negative still stands. Is it
"!This->cmst_active" ot "This->cmst_active"
On Sat, 25 Feb 2017 at 11:23 Edward O'Callaghan
wrote:
> From: Mike Lothian
>
> This fixes
oh yes I missed that, you want to have drop the negation in your patch Mike.
On 02/25/2017 10:28 PM, Mike Lothian wrote:
> I think my question regarding the double negative still stands. Is it
> "!This->cmst_active" ot "This->cmst_active"
>
> On Sat, 25 Feb 2017 at 11:23 Edward O'Callaghan
>
Will do.
On Sat, 25 Feb 2017 at 11:31 Edward O'Callaghan
wrote:
> oh yes I missed that, you want to have drop the negation in your patch
> Mike.
>
> On 02/25/2017 10:28 PM, Mike Lothian wrote:
> > I think my question regarding the double negative still stands. Is it
This fixes 4a883966c1f74f43afc145d2c3d27af7b8c5e01a where the
PIPE_CAP was removed.
Now USER_INDEX_BUFFERS are always enabled remove the check and only
check for cmst_active directly.
v2: Axel pointed out the code was still needed when cmst was inactive,
Rebase on master too
v3: Drop struct
On 02/25/2017 10:39 PM, Mike Lothian wrote:
> This fixes 4a883966c1f74f43afc145d2c3d27af7b8c5e01a where the
> PIPE_CAP was removed.
>
> Now USER_INDEX_BUFFERS are always enabled remove the check and only
> check for cmst_active directly.
>
> v2: Axel pointed out the code was still needed when
This fixes 4a883966c1f74f43afc145d2c3d27af7b8c5e01a where the
PIPE_CAP was removed.
Now USER_INDEX_BUFFERS are always enabled remove the check and only
check for cmst_active directly.
v2: Axel pointed out the code was still needed when cmst was inactive,
Rebase on master too
v3: Drop struct
Very noisy but you got there in the end,
Reviewed-by: Edward O'Callaghan
On 02/25/2017 10:50 PM, Mike Lothian wrote:
> This fixes 4a883966c1f74f43afc145d2c3d27af7b8c5e01a where the
> PIPE_CAP was removed.
>
> Now USER_INDEX_BUFFERS are always enabled remove the
Thanks for pushing and being patient with me
On Sat, 25 Feb 2017 at 12:13 Edward O'Callaghan
wrote:
> Very noisy but you got there in the end,
>
> Reviewed-by: Edward O'Callaghan
>
> On 02/25/2017 10:50 PM, Mike Lothian wrote:
> > This
https://bugs.freedesktop.org/show_bug.cgi?id=99953
Mike Lothian changed:
What|Removed |Added
Resolution|--- |FIXED
Anyone with mesa/libdrm push access should in theory be able to push
directly. Not really any point to wait for me to have time to merge
pullreqs on github ;-)
I've spiffed it out slightly, so it supports both legacy pageflip mode
and atomic/fence mode, etc.
Am 25.02.2017 05:56, schrieb Timothy Arceri:
On 24/02/17 21:02, Marek Olšák wrote:
On Fri, Feb 24, 2017 at 3:18 AM, Timothy Arceri
wrote:
On 24/02/17 08:49, Timothy Arceri wrote:
On 24/02/17 05:12, Marek Olšák wrote:
On Thu, Feb 23, 2017 at 3:09 AM, Timothy
>
> Besides this issue, also 8e03250fcf4fc5de31e92ca4919959d932888a69
> "vulkan: Combine wsi and util makefiles" requires changes/an Android.mk
> makefile
>
> Regarding the -o argument,
> it is indeed essential for Android Build System that generated
> sources/headers
> go in
The following commits require android porting:
e9dcb17 "vulkan/util: Add generator for enum_to_str functions"
8e03250 "vulkan: Combine wsi and util makefiles"
The following changes are implemented in this patch:
Add src/vulkan/Android.mk to build libmesa_vulkan_util and libmesa_vulkan_wsi
https://bugs.freedesktop.org/show_bug.cgi?id=99856
--- Comment #4 from Aidan Thornton ---
I've been having the same issue on Gentoo for a while with Mesa and libdrm from
git master, and it appears someone's been having the same problem with the
Debian-packaged version of
https://bugs.freedesktop.org/show_bug.cgi?id=99856
--- Comment #5 from Henrique Dante de Almeida ---
I'll try with an upstream environment and generate strace output soon
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the
https://bugs.freedesktop.org/show_bug.cgi?id=99856
--- Comment #8 from Henrique Dante de Almeida ---
Should I have verde-r600-* ? I'm not using amdgpu.
--
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the
https://bugs.freedesktop.org/show_bug.cgi?id=99856
--- Comment #9 from Henrique Dante de Almeida ---
I'm currently unable to use amdgpu with kernel 4.9. I'm getting this when
exiting X and unable to shutdown cleanly:
fev 25 18:00:44 dragonmount kernel: amdgpu :01:00.0:
On Sat, Feb 25, 2017 at 5:06 PM, Dieter Nützel wrote:
> Am 25.02.2017 05:56, schrieb Timothy Arceri:
>>
>> On 24/02/17 21:02, Marek Olšák wrote:
>>>
>>> On Fri, Feb 24, 2017 at 3:18 AM, Timothy Arceri
>>> wrote:
On 24/02/17 08:49,
https://bugs.freedesktop.org/show_bug.cgi?id=99856
--- Comment #6 from Jan Vesely ---
(In reply to Henrique Dante de Almeida from comment #2)
> Yes:
>
> Nome : libclc
> Versão : 0.2.0+334+520743b-1
> Descrição: Library
https://bugs.freedesktop.org/show_bug.cgi?id=99856
--- Comment #7 from Henrique Dante de Almeida ---
libclc /usr/
libclc /usr/include/
libclc /usr/include/clc/
libclc /usr/include/clc/as_type.h
libclc /usr/include/clc/async/
libclc /usr/include/clc/async/async_work_group_copy.h
The algorithms used by this pass, especially for division, are heavily
based on the work Ian Romanick did for the similar int64 lowering pass
in the GLSL compiler.
v2: Properly handle vectors
v3: Get rid of log2_denom stuff. Since we're using bcsel, we do all the
calculations anyway and
https://bugs.freedesktop.org/show_bug.cgi?id=99856
--- Comment #10 from Jan Vesely ---
(In reply to Henrique Dante de Almeida from comment #8)
> Should I have verde-r600-* ? I'm not using amdgpu.
no. verde-amdgcn- is correct.
the Linux kernel driver does not
https://bugs.freedesktop.org/show_bug.cgi?id=99856
--- Comment #11 from Henrique Dante de Almeida ---
Created attachment 129915
--> https://bugs.freedesktop.org/attachment.cgi?id=129915=edit
OpenCL hello strace
--
You are receiving this mail because:
You are the QA Contact
https://bugs.freedesktop.org/show_bug.cgi?id=99856
--- Comment #12 from Jan Vesely ---
(In reply to Henrique Dante de Almeida from comment #11)
> Created attachment 129915 [details]
> OpenCL hello strace
thank you.
libclc is located and loaded correctly.
can you
https://bugs.freedesktop.org/show_bug.cgi?id=99856
--- Comment #13 from Henrique Dante de Almeida ---
Created attachment 129916
--> https://bugs.freedesktop.org/attachment.cgi?id=129916=edit
Arch Linux libclc tahiti-amdgcn--.bc
--
You are receiving this mail because:
You
From: Marek Olšák
---
src/amd/common/ac_llvm_build.c | 68 ++
src/amd/common/ac_llvm_build.h | 29 ++
src/gallium/drivers/radeonsi/si_shader.c | 154 +--
3 files changed, 159 insertions(+), 92 deletions(-)
From: Marek Olšák
---
src/amd/common/ac_llvm_build.c | 62 +
src/amd/common/ac_llvm_build.h | 34 --
src/amd/common/ac_nir_to_llvm.c | 16 +++
src/gallium/drivers/radeonsi/si_shader.c | 79
From: Marek Olšák
TODO: ADD_TID doesn't work. Needs more investigation.
---
src/amd/common/ac_llvm_build.c| 58 ++-
src/amd/common/ac_llvm_build.h| 4 +-
src/amd/common/ac_nir_to_llvm.c | 4 +-
From: Marek Olšák
---
src/amd/common/ac_llvm_build.c | 17 +
src/amd/common/ac_llvm_build.h | 6 ++
src/gallium/drivers/radeonsi/si_shader.c | 25 ++---
3 files changed, 33 insertions(+), 15 deletions(-)
diff
From: Marek Olšák
---
src/amd/common/ac_llvm_util.c | 2 ++
src/amd/common/ac_llvm_util.h | 2 ++
src/gallium/auxiliary/gallivm/lp_bld_intr.c | 2 ++
src/gallium/auxiliary/gallivm/lp_bld_intr.h | 2 ++
4 files changed, 8 insertions(+)
diff --git
From: Marek Olšák
---
src/amd/common/ac_llvm_build.c | 15 ++
src/amd/common/ac_llvm_build.h | 11 ++
src/gallium/drivers/radeonsi/si_shader.c | 306 +++
3 files changed, 170 insertions(+), 162 deletions(-)
diff --git
From: Marek Olšák
---
src/amd/common/ac_llvm_build.c | 11 +--
src/amd/common/ac_llvm_build.h | 3 ++-
src/gallium/drivers/radeonsi/si_shader.c | 20 ++--
3 files changed, 21 insertions(+), 13 deletions(-)
diff --git
From: Marek Olšák
---
src/amd/common/ac_llvm_build.c| 26 +++
src/amd/common/ac_llvm_build.h| 3 +++
src/gallium/drivers/radeonsi/si_shader_tgsi_alu.c | 11 --
3 files changed, 33 insertions(+), 7
From: Marek Olšák
and move one function up to reuse the code.
---
src/gallium/drivers/radeonsi/si_shader.c | 97
1 file changed, 49 insertions(+), 48 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_shader.c
From: Marek Olšák
---
src/gallium/drivers/radeonsi/si_shader.c | 64 ++--
1 file changed, 19 insertions(+), 45 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_shader.c
b/src/gallium/drivers/radeonsi/si_shader.c
index af031c7..887e6a4
From: Marek Olšák
---
src/amd/common/ac_llvm_build.c | 31 +++
src/gallium/drivers/radeonsi/si_shader.c | 8 +---
2 files changed, 36 insertions(+), 3 deletions(-)
diff --git a/src/amd/common/ac_llvm_build.c
From: Marek Olšák
---
src/amd/common/ac_llvm_build.c | 37
src/amd/common/ac_llvm_build.h | 2 ++
src/amd/common/ac_nir_to_llvm.c | 41 ++
src/gallium/drivers/radeonsi/si_shader.c | 49
From: Marek Olšák
---
src/amd/common/ac_llvm_build.c | 18 ++
src/amd/common/ac_llvm_build.h | 2 ++
src/gallium/drivers/radeonsi/si_shader.c | 6 +-
3 files changed, 21 insertions(+), 5 deletions(-)
diff --git
From: Marek Olšák
---
src/amd/common/ac_llvm_build.c | 80 ++
1 file changed, 80 insertions(+)
diff --git a/src/amd/common/ac_llvm_build.c b/src/amd/common/ac_llvm_build.c
index 3a1ef93..187c2cb 100644
---
From: Marek Olšák
just a cleanup
---
src/amd/common/ac_llvm_build.c| 16
src/amd/common/ac_llvm_build.h| 1 +
src/gallium/drivers/radeonsi/si_shader.c | 12
Hi,
This series depends on the patch adding attributes at call sites:
https://patchwork.freedesktop.org/series/20100/
The only legacy intrinsics still in use are:
- llvm.SI.load.const
- llvm.SI.tbuffer.store (when ADD_TID = 1)
- llvm.AMDGPU.kill
- llvm.AMDGPU.kilp
A lot of the code that builds
From: Marek Olšák
---
src/gallium/drivers/radeonsi/si_shader.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_shader.c
b/src/gallium/drivers/radeonsi/si_shader.c
index dd5bdf6..16579af 100644
---
From: Marek Olšák
---
src/gallium/auxiliary/tgsi/tgsi_scan.c | 15 ++-
src/gallium/auxiliary/tgsi/tgsi_scan.h | 8 +++-
src/gallium/drivers/radeonsi/si_shader.c | 4 +++-
3 files changed, 16 insertions(+), 11 deletions(-)
diff --git
From: Marek Olšák
---
src/gallium/drivers/radeonsi/si_shader.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/gallium/drivers/radeonsi/si_shader.c
b/src/gallium/drivers/radeonsi/si_shader.c
index caff95b..699fefd 100644
---
On Sun, 2017-02-26 at 00:58 +0100, Marek Olšák wrote:
> From: Marek Olšák
>
> ---
> src/amd/common/ac_llvm_util.c | 2 ++
> src/amd/common/ac_llvm_util.h | 2 ++
> src/gallium/auxiliary/gallivm/lp_bld_intr.c | 2 ++
>
https://bugs.freedesktop.org/show_bug.cgi?id=73777
Joaquín Montero Salinas changed:
What|Removed |Added
CC|
Samuel Iglesias Gonsálvez writes:
> This bug can make that we don't detect the end of a contiguous area
> correctly and push larger areas than the real ones.
>
> Signed-off-by: Samuel Iglesias Gonsálvez
> Cc: "17.0"
https://bugs.freedesktop.org/show_bug.cgi?id=99856
--- Comment #14 from Jan Vesely ---
I think the problem is that the libclc implementation contains uninlined calls
(function calls are not supported an AMD GPUs):
; Function Attrs: alwaysinline nounwind
define
From: Marek Olšák
Vulkan does the same thing.
---
src/gallium/drivers/radeonsi/si_shader.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_shader.c
b/src/gallium/drivers/radeonsi/si_shader.c
index
From: Marek Olšák
---
src/amd/common/ac_llvm_build.c | 20
1 file changed, 20 insertions(+)
diff --git a/src/amd/common/ac_llvm_build.c b/src/amd/common/ac_llvm_build.c
index 8fac89c..6364657 100644
--- a/src/amd/common/ac_llvm_build.c
+++
From: Marek Olšák
s/emit/build/
---
src/amd/common/ac_llvm_build.c | 299 ++---
src/amd/common/ac_llvm_build.h | 58 ++--
src/amd/common/ac_nir_to_llvm.c| 208 +++---
From: Marek Olšák
---
src/amd/common/ac_llvm_build.c | 9 -
src/amd/common/ac_llvm_build.h | 3 +--
src/amd/common/ac_nir_to_llvm.c | 6 +++---
src/gallium/drivers/radeonsi/si_shader.c | 25 -
4 files changed,
From: Marek Olšák
---
src/gallium/drivers/radeonsi/si_shader.c | 114 ---
1 file changed, 104 insertions(+), 10 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_shader.c
b/src/gallium/drivers/radeonsi/si_shader.c
index 6ccb407..467d0bd
Just to double check, is there anything else I need to do to have this
patch committed?
Jacob Lifshay
On Feb 19, 2017 02:08, "Kai Wasserbäch" wrote:
> Jason Ekstrand wrote on 19.02.2017 06:01:
> > On Feb 18, 2017 12:37 PM, "Kai Wasserbäch"
Passes corresponding piglit tests.
---
src/gallium/drivers/swr/swr_context.cpp | 1 +
src/gallium/drivers/swr/swr_screen.cpp | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/gallium/drivers/swr/swr_context.cpp
b/src/gallium/drivers/swr/swr_context.cpp
index
From: Marek Olšák
It was harmless, because we also set unorm in the sampler state.
---
src/gallium/drivers/radeonsi/si_shader.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/gallium/drivers/radeonsi/si_shader.c
Signed-off-by: Bas Nieuwenhuizen
---
src/amd/common/ac_nir_to_llvm.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c
index 9778581a1ef..4f3d689db7e 100644
---
If i-th thread could not be created it means we have i threads,
not i+1, because we start from 0.
Fixes: 404d0d5 "gallium/u_queue: add an option to have multiple worker threads"
Signed-off-by: Grazvydas Ignotas
---
no commit access
src/gallium/auxiliary/util/u_queue.c | 2 +-
Commit 4aea8fe ("gallium/u_queue: fix random crashes when the app calls
exit()") added a atexit handler which calls
util_queue_killall_and_wait() for each queue to stop the threads.
However the app is also free to use atexit handlers to clean up things,
leading to util_queue_destroy() call which
Reviewed-by: Edward O'Callaghan
On 02/26/2017 02:09 PM, Bruce Cherniak wrote:
> Passes corresponding piglit tests.
> ---
> src/gallium/drivers/swr/swr_context.cpp | 1 +
> src/gallium/drivers/swr/swr_screen.cpp | 2 +-
> 2 files changed, 2 insertions(+), 1
Acked-by: Edward O'Callaghan
On 02/26/2017 12:39 PM, Bas Nieuwenhuizen wrote:
> Signed-off-by: Bas Nieuwenhuizen
> ---
> src/amd/common/ac_nir_to_llvm.c | 18 ++
> 1 file changed, 18 insertions(+)
>
> diff --git
https://bugs.freedesktop.org/show_bug.cgi?id=73777
Joaquín Montero Salinas changed:
What|Removed |Added
Status|RESOLVED|REOPENED
> On Feb 25, 2017, at 15:58, Marek Olšák wrote:
>
> }
> +
> +LLVMValueRef ac_emit_cvt_pkrtz_f16(struct ac_llvm_context *ctx,
> +LLVMValueRef args[2])
> +{
> + if (HAVE_LLVM >= 0x0500) {
> + LLVMTypeRef v2f16 =
> +
---
docs/features.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/features.txt b/docs/features.txt
index d9528e9..c42581a 100644
--- a/docs/features.txt
+++ b/docs/features.txt
@@ -192,7 +192,7 @@ GL 4.4, GLSL 4.40 -- all DONE: i965/gen8+, nvc0, radeonsi
Samuel Iglesias Gonsálvez writes:
> The lowered BSW/BXT indirect move instructions had incorrect
> source types, which luckily wasn't causing incorrect assembly to be
> generated due to the bug fixed in the next patch, but would have
> confused the remaining back-end IR
Jan Vesely writes:
> this allows to pass the generated files directly to llc or bugpoint
>
> v2: add atomic counter ID
>
> Signed-off-by: Jan Vesely
> ---
> src/gallium/state_trackers/clover/llvm/invocation.cpp | 8 ++--
> 1 file changed, 6
76 matches
Mail list logo