Re: [Mesa-dev] [PATCH] gles2: Support for GL_EXT_occlusion_query_boolean

On 08/21/2017 08:47 AM, Harish Krupo wrote: Hi Ilia, On 08/21/2017 10:42 AM, Ilia Mirkin wrote: On Mon, Aug 21, 2017 at 12:52 AM, Harish Krupo wrote: Hi Ilia, On 08/18/2017 07:20 PM, Ilia Mirkin wrote: Why the static data changes? Also, I haven't double

Re: [Mesa-dev] [PATCH 8/8] gallium: remove TGSI opcode KILL

On Sun, Aug 20, 2017 at 4:29 AM, Roland Scheidegger wrote: > For 1-3/8, I don't think anything ever used these, and 5/8 (DPH) we > don't need neither, so > Reviewed-by: Roland Scheidegger > > 4,6,7, well we can live fine without them, just translating them

Re: [Mesa-dev] VDPAU issues in 17.2 and master, and a test request

On Mon, Aug 21, 2017 at 5:54 PM, Andy Furniss wrote: > Ilia Mirkin wrote: > >> As I don't have the hardware myself, I was hoping someone could >> confirm that this is a nouveau issue and not a more general one. >> Ideally this would be done by testing VDPAU on both radeonsi

Re: [Mesa-dev] [PATCH 02/13] nir/spirv: Use unreachable("...") rather than assert(!"...")

On Mon, Aug 21, 2017 at 2:44 PM, Matt Turner wrote: > On Thu, Aug 10, 2017 at 7:02 PM, Jordan Justen > wrote: > > On 2017-08-10 15:02:33, Matt Turner wrote: > >> Quiets a number of uninitialized variable warnings in clang. > >> --- > >>

Re: [Mesa-dev] [PATCH v3] gallium/util: add new module that allocate "numbers"

Reviewed-by: Marek Olšák Marek On Mon, Aug 21, 2017 at 4:49 PM, Samuel Pitoiset wrote: > Will be used for allocating bindless descriptor slots for > RadeonSI. > > v3; - use a faster loop in util_idalloc_alloc() (Marek) > v2: - change the

Re: [Mesa-dev] [PATCH 3/3] mesa: optimize _mesa_attr_zero_aliases_vertex()

For the series: Reviewed-by: Marek Olšák Marek On Mon, Aug 21, 2017 at 8:56 PM, Brian Paul wrote: > After the context is initialized, the API and context flags won't > change. So, we can compute whether vertex attribute 0 aliases > vertex position just

Re: [Mesa-dev] [PATCH 09/11] radeonsi: make use of LOAD for UBOs

This will use vector loads (64 loads per 64 threads) instead of scalar loads (1 load per 64 threads). Vector loads are much slower. allow_smem should be set to allow scalar loads for constbufs. Also, can_speculate should be true for constbuf loads. I think you really need to check shader-db or

Re: [Mesa-dev] [PATCH 8/8] gallium: remove TGSI opcode KILL

Am 21.08.2017 um 22:57 schrieb Marek Olšák: > On Sun, Aug 20, 2017 at 4:29 AM, Roland Scheidegger > wrote: >> For 1-3/8, I don't think anything ever used these, and 5/8 (DPH) we >> don't need neither, so >> Reviewed-by: Roland Scheidegger >> >> 4,6,7,

[Mesa-dev] [Bug 102038] assertion failure in update_framebuffer_size

https://bugs.freedesktop.org/show_bug.cgi?id=102038 --- Comment #9 from Brian Paul --- Created attachment 133654 --> https://bugs.freedesktop.org/attachment.cgi?id=133654=edit proposed patch Bruce, can you try the attached patch? -- You are receiving this mail because:

Re: [Mesa-dev] [PATCH] radeonsi: remove Constant Engine support

On Mon, Aug 21, 2017 at 8:49 PM, Samuel Pitoiset wrote: > dirty_mask can be removed entirely because it only makes sense with CE. Thanks. Removed locally. Marek ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH] mesa: fix ES only draw if we have vertex positions

Reviewed-by: Marek Olšák Marek On Mon, Aug 21, 2017 at 2:42 AM, Timothy Arceri wrote: > This code was separated from the validation code so it could > use used with KHR_no_error paths. The return values were inverted > to reflect the name of the

Re: [Mesa-dev] [PATCH 05/11] gallium: add UBO type to tgsi_file_type

I'd like the new "file" type to be called CONSTBUF instead of UBO. We don't generally use GL nomenclature in Gallium. Marek On Thu, Aug 17, 2017 at 1:03 PM, Timothy Arceri wrote: > This will be use to distinguish between load types when using > the TGSI_OPCODE_LOAD

Re: [Mesa-dev] [PATCH 07/11] mesa/st: create add_buffer_to_load_and_stores() helper

For patches 1-3, 6, 7: Reviewed-by: Marek Olšák Marek On Thu, Aug 17, 2017 at 1:03 PM, Timothy Arceri wrote: > Will be used to add LOAD support to UBOs. > --- > src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 46 > ++ > 1

[Mesa-dev] [PATCH] glsl_to_tgsi: clean up opcode translation

From: Marek Olšák An island of beauty in the middle of chaos. --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 92 ++ 1 file changed, 30 insertions(+), 62 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp

Re: [Mesa-dev] [PATCH] Android: Fix LLVM duplicated symbols linking for N and M

On Mon, Aug 21, 2017 at 4:44 PM, Mauro Rossi wrote: > 2017-08-18 21:46 GMT+02:00 Rob Herring : >> Both statically linking libLLVMCore and dynamically linking libLLVM causes >> duplicated symbols in gallium_dri.so and it fails to dlopen. We don't >> really

[Mesa-dev] [Bug 102038] assertion failure in update_framebuffer_size

https://bugs.freedesktop.org/show_bug.cgi?id=102038 --- Comment #11 from Bruce Cherniak --- Created attachment 133661 --> https://bugs.freedesktop.org/attachment.cgi?id=133661=edit simple-msaa.c Hi Brian, This simple msaa sample fails in the same way when run with

[Mesa-dev] [PATCH 1/2] mesa: only expose glImportMemoryFdEXT if the ext is supported

From the EXT_external_objects_fd spec: "If the GL_EXT_memory_object_fd string is reported, the following commands are added: void ImportMemoryFdEXT(uint memory, uint64 size, enum handleType, int fd);"

Re: [Mesa-dev] [PATCH v4 6/6] radeonsi: try to re-use previously deleted bindless descriptor slots

Reviewed-by: Marek Olšák So let's commit this! Marek On Mon, Aug 21, 2017 at 4:50 PM, Samuel Pitoiset wrote: > Currently, when the array is full it is resized but it can grow > over and over because we don't try to re-use descriptor slots. > >

Re: [Mesa-dev] [PATCH] svga: replace gotos with conditionals in array drawing code

Reviewed-by: Charmaine Lee From: Brian Paul Sent: Monday, August 21, 2017 11:55 AM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee; Neha Bhende Subject: [PATCH] svga: replace gotos with conditionals in

Re: [Mesa-dev] [PATCH 2/2] mesa: only expose EXT_memory_object functions if the ext is supported

For the series: Reviewed-by: Marek Olšák Marek On Mon, Aug 21, 2017 at 10:22 PM, Samuel Pitoiset wrote: > They should not be exposed when the extension is unsupported. > Note that ARB_direct_state_access is always exposed and > EXT_semaphore is

Re: [Mesa-dev] [PATCH] Android: Fix LLVM duplicated symbols linking for N and M

2017-08-18 21:46 GMT+02:00 Rob Herring : > Both statically linking libLLVMCore and dynamically linking libLLVM causes > duplicated symbols in gallium_dri.so and it fails to dlopen. We don't > really need to link libLLVMCore, but just need generated headers to be > built first.

Re: [Mesa-dev] [PATCH 02/13] nir/spirv: Use unreachable("...") rather than assert(!"...")

On Thu, Aug 10, 2017 at 7:02 PM, Jordan Justen wrote: > On 2017-08-10 15:02:33, Matt Turner wrote: >> Quiets a number of uninitialized variable warnings in clang. >> --- >> src/compiler/spirv/spirv_to_nir.c | 24 >>

[Mesa-dev] [PATCH] android: restore llvm includes

Fixes the following building errors: In file included from external/mesa/src/amd/common/ac_shader_info.c:25: In file included from external/mesa/src/amd/common/ac_nir_to_llvm.h:29: In file included from external/llvm/include/llvm-c/TargetMachine.h:23: external/llvm/include/llvm-c/Target.h:23:10:

[Mesa-dev] [PATCH 10/15] radeonsi/gfx9: don't flush L2 metadata for DB if not needed

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_blit.c | 12 +--- src/gallium/drivers/radeonsi/si_pipe.h | 17 ++--- src/gallium/drivers/radeonsi/si_state.c | 8 +++- 3 files changed, 26 insertions(+), 11 deletions(-) diff --git

[Mesa-dev] [PATCH 09/15] radeonsi/gfx9: don't flush L2 metadata for CB if not needed

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_blit.c | 8 +--- src/gallium/drivers/radeonsi/si_pipe.h | 23 +++ src/gallium/drivers/radeonsi/si_state.c | 19 +++ src/gallium/drivers/radeonsi/si_state_draw.c |

[Mesa-dev] [PATCH 15/15] radeonsi: emit VGT_REUSE_OFF in the right place

From: Marek Olšák clip_regs aren't marked dirty when writes_viewport_index is changed. Cc: 17.2 --- src/gallium/drivers/radeonsi/si_state.c | 6 -- src/gallium/drivers/radeonsi/si_state_shaders.c | 11 +-- 2 files

[Mesa-dev] [PATCH 11/15] gallium/radeon: add helpers for whether HTILE is enabled

From: Marek Olšák --- src/gallium/drivers/r600/evergreen_state.c| 3 +-- src/gallium/drivers/r600/r600_blit.c | 3 +-- src/gallium/drivers/r600/r600_state.c | 3 +-- src/gallium/drivers/radeon/r600_pipe_common.h | 13 +

[Mesa-dev] [PATCH 12/15] radeonsi: don't decompress Z/S if there is no HTILE

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_blit.c | 27 +++ 1 file changed, 15 insertions(+), 12 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_blit.c b/src/gallium/drivers/radeonsi/si_blit.c index 378441a..2544388 100644 ---

[Mesa-dev] [PATCH 14/15] radeonsi: add support for TGSI opcodes DCEIL, DFLR, DROUND, DSSG, DTRUNC

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_pipe.c| 2 +- src/gallium/drivers/radeonsi/si_shader_tgsi_alu.c | 14 ++ 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_pipe.c

[Mesa-dev] [PATCH 13/15] radeonsi: use a faster version of PK2H

From: Marek Olšák + 4 piglit regressions, but it's correct accorcing to the GL spec and performance is more important than piglit. --- src/gallium/drivers/radeonsi/si_shader_tgsi_alu.c | 29 +++ 1 file changed, 8 insertions(+), 21 deletions(-) diff

Re: [Mesa-dev] [PATCH] android: restore llvm includes

This one is not needed, I was testing with missing pieces in external/llvm on my side Sorry for the noise Mauro 2017-08-21 23:49 GMT+02:00 Mauro Rossi : > Fixes the following building errors: > > In file included from external/mesa/src/amd/common/ac_shader_info.c:25: > In

[Mesa-dev] [PATCH 02/15] radeonsi/gfx9: prevent shader-db crashes

From: Marek Olšák - don't precompile LS and ES (they don't exist on GFX9), compile as VS instead - don't precompile HS and GS (we don't have LS and ES parts) --- src/gallium/drivers/radeonsi/si_state_shaders.c | 12 +++- 1 file changed, 11 insertions(+), 1

[Mesa-dev] [PATCH 06/15] ac/surface/gfx9: don't allow DCC for the smallest mipmap levels

From: Marek Olšák This fixes garbage there if we don't flush TC L2 after rendering. --- src/amd/common/ac_surface.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/src/amd/common/ac_surface.c b/src/amd/common/ac_surface.c index

[Mesa-dev] [PATCH 08/15] radeonsi/gfx9: don't flush TC L2 between rendering and texturing if not needed

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_blit.c | 29 - src/gallium/drivers/radeonsi/si_pipe.h | 23 +++ src/gallium/drivers/radeonsi/si_state.c | 29 - 3 files changed, 47

[Mesa-dev] [PATCH 05/15] radeonsi/gfx9: don't use GS scenario A for VS writing ViewportIndex

From: Marek Olšák Vulkan doesn't do it anymore. --- src/gallium/drivers/radeonsi/si_state_shaders.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state_shaders.c

[Mesa-dev] [PATCH 03/15] radeonsi/gfx9: set 'not a query' for r600_gfx_write_event_eop correctly

From: Marek Olšák 0 is PIPE_QUERY_OCCLUSION_COUNTER, which is not what we want. --- src/gallium/drivers/radeon/r600_pipe_common.h | 2 ++ src/gallium/drivers/radeonsi/si_perfcounter.c | 2 +- src/gallium/drivers/radeonsi/si_state_draw.c | 4 ++-- 3 files changed, 5

[Mesa-dev] [PATCH 04/15] gallium/radeon: clean up EOP_DATA_SEL magic numbers

From: Marek Olšák --- src/amd/common/r600d_common.h | 10 -- src/gallium/drivers/radeon/r600_query.c | 9 ++--- src/gallium/drivers/radeonsi/si_perfcounter.c | 3 ++- src/gallium/drivers/radeonsi/si_state_draw.c | 6 -- 4 files

Re: [Mesa-dev] VDPAU issues in 17.2 and master, and a test request

Ilia Mirkin wrote: As I don't have the hardware myself, I was hoping someone could confirm that this is a nouveau issue and not a more general one. Ideally this would be done by testing VDPAU on both radeonsi and r600, as well as both the DRI3 and the DRI2 paths. Please use mplayer for this,

[Mesa-dev] [PATCH 07/15] radeonsi/gfx9: use correct TC flush flags when invalidating CB & DB

From: Marek Olšák Now we can finally stop flushing L2 data. --- src/gallium/drivers/radeonsi/si_state_draw.c | 28 +--- 1 file changed, 21 insertions(+), 7 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state_draw.c

[Mesa-dev] [PATCH 01/15] radeonsi/gfx9: properly handle imported textures with unexpected swizzle mode

From: Marek Olšák Cc: 17.2 --- src/amd/common/ac_surface.c | 5 + src/gallium/drivers/radeon/r600_texture.c | 9 +++-- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/src/amd/common/ac_surface.c

Re: [Mesa-dev] [PATCH] Android: Fix LLVM duplicated symbols linking for N and M

2017-08-21 23:57 GMT+02:00 Rob Herring : > On Mon, Aug 21, 2017 at 4:44 PM, Mauro Rossi wrote: >> 2017-08-18 21:46 GMT+02:00 Rob Herring : >>> Both statically linking libLLVMCore and dynamically linking libLLVM causes >>> duplicated symbols

[Mesa-dev] [Bug 102038] assertion failure in update_framebuffer_size

https://bugs.freedesktop.org/show_bug.cgi?id=102038 --- Comment #10 from Bruce Cherniak --- For llvmpipe, this fails in the same way as before. Unless llvmpipe_is_format_supported is changed in the same way that you modified svga_is_format_supported: - if

[Mesa-dev] [PATCH 2/2] mesa: only expose EXT_memory_object functions if the ext is supported

They should not be exposed when the extension is unsupported. Note that ARB_direct_state_access is always exposed and EXT_semaphore is not supported at all. Signed-off-by: Samuel Pitoiset --- src/mesa/main/bufferobj.c | 21 +++--

[Mesa-dev] [PATCH] vulkan: import 1.0.59 headers and xml.

From: Dave Airlie --- include/vulkan/vulkan.h| 19 + src/vulkan/registry/vk.xml | 53 +++--- 2 files changed, 60 insertions(+), 12 deletions(-) diff --git a/include/vulkan/vulkan.h b/include/vulkan/vulkan.h index

Re: [Mesa-dev] nouveau hardware decoding and vaDeriveImage

Hi Julien, thanks for providing some background on the issue. Now it makes a lot more sense. Am Mittwoch, den 16.08.2017, 10:40 +0100 schrieb Julien Isorce: > Hi, > > This issue is tracked here https://bugs.freedesktop.org/show_bug.cgi? > id=98285 > This is due to a limitation in libva API

Re: [Mesa-dev] [PATCH 2/2] intel/isl: Replace switch statements of doom with a macro

Hi Jason, -Ursprüngliche Nachricht- Von: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] Im Auftrag von Jason Ekstrand Gesendet: Donnerstag, 17. August 2017 23:57 An: mesa-dev@lists.freedesktop.org Cc: Jason Ekstrand Betreff: [Mesa-dev] [PATCH 2/2]

[Mesa-dev] [PATCH] Revert "glsl: Mark functions static"

This reverts commit ca73c3358c91434e68ab31c23d13986d87c661cd. This commit broke 'make check' revert it for now. --- src/compiler/glsl/ast_function.cpp | 10 +- src/compiler/glsl/ast_to_hir.cpp| 6 +++--- src/compiler/glsl/glsl_parser_extras.cpp| 2

[Mesa-dev] [PATCH] glsl/linker: Make several functions not static

From: Ian Romanick copy_constant_to_storage, set_uniform_initializer, populate_consumer_input_sets, and get_matching_input are all used by tests in src/compiler/glsl/tests: glsl/tests/varyings_test.o: In function `link_varyings_single_simple_input_Test::TestBody()':

Re: [Mesa-dev] [PATCH] glsl/linker: Make several functions not static

Reviewed-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v6.1] egl: Allow creation of per surface out fence

> -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf > Of Emil Velikov > Sent: Monday, August 21, 2017 11:24 PM > To: Marathe, Yogesh > Cc: Gao, Shuo ; Liu, Zhiquan ; >

Re: [Mesa-dev] [PATCH] i965/clear: Quantize the depth clear value based on the format

On Saturday, August 19, 2017 8:56:06 PM PDT Jason Ekstrand wrote: > In f9fd976e8adba733b08d we changed the clear value to be stored as an > isl_color_value. This had the side-effect same clear value check is now > happening directly between the f32[0] field of the isl_color_value and >

[Mesa-dev] [PATCH] spirv: Add support for the HelperInvocation builtin

I have no idea how this got missed but it's been missing since forever. Cc: mesa-sta...@lists.freedesktop.org --- src/compiler/spirv/vtn_variables.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/compiler/spirv/vtn_variables.c b/src/compiler/spirv/vtn_variables.c

Re: [Mesa-dev] [PATCH] spirv: Add support for the HelperInvocation builtin

Reviewed-by: Samuel Iglesias Gonsálvez On Mon, 2017-08-21 at 22:11 -0700, Jason Ekstrand wrote: > I have no idea how this got missed but it's been missing since > forever. > > Cc: mesa-sta...@lists.freedesktop.org > --- >  src/compiler/spirv/vtn_variables.c | 5 - >  1

Re: [Mesa-dev] [PATCH 2/4] util/disk_cache: add struct cache_item_metadata

On 08/18/2017 04:02 AM, Nicolai Hähnle wrote: On 15.08.2017 01:26, Timothy Arceri wrote: This will be used to store more information about the cache item in it's header. This information is intended for 3rd party and cache analysis use but can also be used for detecting the unlikely scenario

Re: [Mesa-dev] [PATCH] glsl/linker: Make several functions not static

On Mon, Aug 21, 2017 at 9:57 PM, Ian Romanick wrote: > From: Ian Romanick > > copy_constant_to_storage, set_uniform_initializer, > populate_consumer_input_sets, and get_matching_input are all used by > tests in src/compiler/glsl/tests:

[Mesa-dev] [Bug 102052] No package 'expat' found

https://bugs.freedesktop.org/show_bug.cgi?id=102052 Vinson Lee changed: What|Removed |Added Resolution|--- |FIXED

[Mesa-dev] VDPAU issues in 17.2 and master, and a test request

Hi guys, I just wanted to record some of my observations with nouveau; I haven't had time to debug what happened. All testing done with mplayer -vo vdpau. First off, it seems like master + DRI3 works, up to a point, but then crashes in nouveau pushbuf logic with a missing kref (which means some

[Mesa-dev] [ANNOUNCE] mesa 17.2.0-rc5

The fifth release candidate for Mesa 17.2.0 is now available. This is the final planned RC. Chris Wilson (1): i965: Always allow CPU readback of the scanout on LLC platforms Dave Airlie (4): radv/gfx9: fix set predication packet. radv/gfx9: remove some leftover gfx6 descriptor

Re: [Mesa-dev] [PATCH 00/18] Gallium blitter optimizations

Am Montag, den 21.08.2017, 10:22 +1000 schrieb Dave Airlie: > Hi Gert, > > Can you test this along with the fetch shader patch Marek sent? This patch fixes the flickering in Blender and UE4Editor. Not applying Marks fetch patch results in a segfault in glxgears.  I've also tested with the

Re: [Mesa-dev] [PATCH 8/8] gallium: remove TGSI opcode KILL

Hi Marek, On 20 August 2017 at 01:49, Marek Olšák wrote: > From: Marek Olšák > > use KILL_IF -1 instead. > --- I'm not 100% sure, but I believe virgl uses TGSI to talk with the host driver. Thus Dave might want to check if the series does not break things

Re: [Mesa-dev] [PATCH 07/10] radv/image: don't rescale width/height if the format isn't changing

The old code would just do a * blocksize / blocksize , which is the identity (as long as we don't overflow). Did this cause any issues? On Mon, Aug 21, 2017, at 09:34, Dave Airlie wrote: > From: Dave Airlie > > If the image view has the same format, we don't need to rescale

[Mesa-dev] [PATCH] radv: don't crash if we have no framebuffer

From: Dave Airlie Recording secondaries with no framebuffer attachment may make this happen, though this might not be the complete solution. (esp if someone does meta stuff in there, would we have to save things, not sure). --- src/amd/vulkan/radv_cmd_buffer.c | 4 1

[Mesa-dev] [PATCH 09/10] radv: don't degrade tiling mode for small compressed or depth texture.

From: Dave Airlie This is what radeonsi does, so we should do the same, also vega doesn't support linear depth textures anyways. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_image.c | 16 ++-- 1 file changed, 10 insertions(+), 6

Re: [Mesa-dev] [PATCH 13/45] i965/fs: Handle 16-bit base types in helper functions

On 08/17/2017 09:26 PM, Jason Ekstrand wrote: > On Thu, Jul 13, 2017 at 7:35 AM, Alejandro Piñeiro > wrote: > > From: Eduardo Lima Mitev > > > --- > src/intel/compiler/brw_fs.cpp | 3

[Mesa-dev] [PATCH shader-db 3/3] run: add extension_in_string() helper

From: Emil Velikov memmem() does not attribute what the character after the searched string is. Thus it will flag even when haystack is "foobar" while we're looking for "foo". Pull a small helper (based on piglit) that correctly handles this and use it. Note: when

Re: [Mesa-dev] [PATCH 07/16] radeonsi: add reference count to si_compute

Am Sonntag, den 20.08.2017, 15:48 +0200 schrieb Marek Olšák: > The patch seems OK to me. Hmm, you're right in that I was wrong about "program", I still need learn to think in patches.  However, when I look at si_delete_compute_state where si_compute_reference is called: >+

[Mesa-dev] [PATCH shader-db 2/3] run: introduce get_glsl_version() helper

From: Emil Velikov Flesh the duplicated functionality to a helper. Use const char * + sscanf to keep the compiler happy. Signed-off-by: Emil Velikov --- A bit more could be fleshed out into helper(s). This is enough to keep the compiler

[Mesa-dev] [PATCH shader-db 1/3] run: define extension_string within the specified scope

From: Emil Velikov The same declaration was being used for two distinct things - a short list of EGL and the core GL extensions. In the former it is a const string, while the latter is a dynamically managed list of extensions. Define the variables within the

[Mesa-dev] [PATCH 10/10] radv/gfx9: don't expose linear depth on vega.

From: Dave Airlie This just zeros out the linear flags for gfx9 + depth formats. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_formats.c | 4 1 file changed, 4 insertions(+) diff --git a/src/amd/vulkan/radv_formats.c

[Mesa-dev] [PATCH 06/10] radv: cleanup some image view descriptor setup.

From: Dave Airlie Avoid passing the vulkan image creation into the image view descriptor setup. This cleans up the usage of range inside the init, instead using the properly inited values in the image view. This is just a cleanup but some future vega changes will depend on

[Mesa-dev] radv/gfx9: more vega fixes.

This is a good chunk of vega related fixes (with some cleanups). I still have a few more fixes to go, but things are working a lot better now, I've cleaned up the first round of fixes in this set. It mostly addresses issues with the color/texture registers around how miptrees are tiled mipmaps

[Mesa-dev] [PATCH 03/10] radv/gfx9: fixup db/stencil disable.

From: Dave Airlie This fixes disabled Z/stencil. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_cmd_buffer.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c

[Mesa-dev] [PATCH 02/10] radv/gfx9: fix level count in color register setup.

From: Dave Airlie There was an off by one here. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index

[Mesa-dev] [PATCH 08/10] radv/gfx9: only minify image view width/height/depth before gfx9.

From: Dave Airlie For gfx9 the addressing for images has changed, so we need to provide the hw with the level0, however we still need to scale for format block differences (so our compressed upload paths still work). Signed-off-by: Dave Airlie ---

[Mesa-dev] [PATCH 05/10] radv/gfx9: emit sx_mrt_blend registers

From: Dave Airlie GFX9 needs the SX MRT blend registers programmed, port over the code from radeonsi to workout the values from the blend state, and program the registers on rbplus systems. This fixes lots of: dEQP-VK.pipeline.blend.* Signed-off-by: Dave Airlie

[Mesa-dev] [PATCH 04/10] radv: bump space check for indexed draw.

From: Dave Airlie For the GFX9 packet we need one more dword. Fixes an assert in: dEQP-VK.draw.shader_draw_parameters.base_vertex.draw_indexed Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_cmd_buffer.c | 2 +- 1 file changed, 1 insertion(+), 1

[Mesa-dev] [PATCH 01/10] radv/gfx9: use total levels in texture descriptor

From: Dave Airlie We need to use all the levels when filling out the gfx9 descriptor. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_image.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_image.c

[Mesa-dev] [PATCH 07/10] radv/image: don't rescale width/height if the format isn't changing

From: Dave Airlie If the image view has the same format, we don't need to rescale the w/h. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_image.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 7/8] docs: remove link to MissingFunctionality wiki page

On Monday, 2017-08-21 12:46:05 +1000, Timothy Arceri wrote: > Outdated, features.txt is used instead. > --- > > It would be great if someone who knows how could just remove the wiki > page. It doesn't really offer anything of value anymore. `git rm MissingFunctionality` should do it. Might

[Mesa-dev] [PATCH v3] gallium/util: add new module that allocate "numbers"

Will be used for allocating bindless descriptor slots for RadeonSI. v3; - use a faster loop in util_idalloc_alloc() (Marek) v2: - change the interface (remove lock/unlock) - make a non-inline implementation Signed-off-by: Samuel Pitoiset Reviewed-by: Marek Olšák

Re: [Mesa-dev] [PATCH v3] gallium/util: add new module that allocate "numbers"

On Monday, 2017-08-21 16:49:48 +0200, Samuel Pitoiset wrote: > Will be used for allocating bindless descriptor slots for > RadeonSI. > > v3; - use a faster loop in util_idalloc_alloc() (Marek) > v2: - change the interface (remove lock/unlock) > - make a non-inline implementation > >

Re: [Mesa-dev] [PATCH 0/4] radeonsi: CE odds and ends + gfx9 perf counters

Series is: Reviewed-by: Samuel Pitoiset On 08/16/2017 01:13 PM, Nicolai Hähnle wrote: Hi all, the first 3 are a bunch of CE-related changes that I still had flying around from our experiments. Patches 1+3 are clear improvements, 2 is a wash with how we're currently

Re: [Mesa-dev] [PATCH v3] gallium/util: add new module that allocate "numbers"

On Monday, 2017-08-21 17:06:19 +0200, Samuel Pitoiset wrote: > On 08/21/2017 04:59 PM, Eric Engestrom wrote: > > On Monday, 2017-08-21 16:49:48 +0200, Samuel Pitoiset wrote: > > > Will be used for allocating bindless descriptor slots for > > > RadeonSI. > > > > > > v3; - use a faster loop in

Re: [Mesa-dev] [PATCH 11/45] i965/vec4: Handle 16-bit types at type_size_xvec4

On 08/17/2017 09:23 PM, Jason Ekstrand wrote: > > > On Thu, Jul 13, 2017 at 7:35 AM, Alejandro Piñeiro > wrote: > > These types have similar vec4 sizes as their 32-bit counterparts. > --- > src/intel/compiler/brw_vec4_visitor.cpp

Re: [Mesa-dev] [PATCH 2/2] egl: Add dma_buf_import_modifiers for glvnd

Hi Emil, On 19 August 2017 at 00:57, Emil Velikov wrote: > On 11 August 2017 at 11:18, Daniel Stone wrote: >> On 31 July 2017 at 15:15, Daniel Stone wrote: >>> Make sure we advertise the new entrypoints to libglvnd's EGL

Re: [Mesa-dev] [PATCH 2/2] egl/drm: set the VISUAL_TYPE alongside the VISUAL_ID

Hi Emil, On 21 August 2017 at 15:18, Emil Velikov wrote: > On 11 July 2017 at 14:27, Emil Velikov wrote: >> According to the EGL_KHR_platform_gbm extension: >> >> For each EGLConfig that belongs to the GBM platform, the >>

[Mesa-dev] [PATCH v4 5/6] radeonsi: use slot indexes for bindless handles

Using VRAM address as bindless handles is not a good idea because we have to use LLVMIntToPTr and the LLVM CSE pass can't optimize because it has no information about the pointer. Instead, use slots indexes like the existing descriptors. Note that we use fixed 16-dword slots for both samplers and

[Mesa-dev] [PATCH v4 4/6] radeonsi: add si_emit_global_shader_pointers() helper

To share common code between rw buffers and bindless descriptors. v3: - rename to si_emit_global_shader_pointers() Signed-off-by: Samuel Pitoiset Reviewed-by: Marek Olšák (v3) --- src/gallium/drivers/radeonsi/si_descriptors.c | 57

[Mesa-dev] [PATCH v4 2/6] radeonsi: make some si_descriptors fields 32-bit

The number of bindless descriptors is dynamic and we definitely have to support more than 256 slots. Signed-off-by: Samuel Pitoiset Reviewed-by: Marek Olšák --- src/gallium/drivers/radeonsi/si_state.h | 10 +- 1 file changed, 5

[Mesa-dev] [PATCH v4 3/6] radeonsi: only initialize dirty_mask when CE is used

Looks like it's useless to initialize that field when CE is unused. This will also allow to declare more than 64 elements for the array of bindless descriptors. Signed-off-by: Samuel Pitoiset Reviewed-by: Marek Olšák ---

[Mesa-dev] [PATCH v4 6/6] radeonsi: try to re-use previously deleted bindless descriptor slots

Currently, when the array is full it is resized but it can grow over and over because we don't try to re-use descriptor slots. v4: - rebase on top of idalloc changes v3: - use new idalloc gallium module Signed-off-by: Samuel Pitoiset ---

[Mesa-dev] [PATCH v4 1/6] radeonsi: declare new user SGPR indices for bindless samplers/images

A new pair of user SGPR is needed for loading the bindless descriptors from shaders. Because the descriptors are global for all stages, there is no need to add separate indices for GFX9. v4: - do not remove those unused inputs v3: - fix merged shaders on GFX9 v2: - fix declaring new bindless

Re: [Mesa-dev] [PATCH v3] gallium/util: add new module that allocate "numbers"

On 08/21/2017 04:59 PM, Eric Engestrom wrote: On Monday, 2017-08-21 16:49:48 +0200, Samuel Pitoiset wrote: Will be used for allocating bindless descriptor slots for RadeonSI. v3; - use a faster loop in util_idalloc_alloc() (Marek) v2: - change the interface (remove lock/unlock) - make a

[Mesa-dev] [ANNOUNCE] mesa 17.1.7

Mesa 17.1.7 is now available. In this release we have: The state tracker received a fix to avoid a crash accessing a null pointer exposed using llvmpipe on Windows. The GLSL compiler has received a fix that prevents an assertion in an error code path with invalid types. Intel drivers have a

Re: [Mesa-dev] [PATCH v6.1] egl: Allow creation of per surface out fence

Can someone please comment on this? Are we done / still not done here? Regards, Yogesh. > -Original Message- > From: Marathe, Yogesh > Sent: Friday, August 18, 2017 3:39 PM > To: mesa-dev@lists.freedesktop.org > Cc: tf...@chromium.org; emil.l.veli...@gmail.com; Gao, Shuo >

Re: [Mesa-dev] [PATCH] Revert "glsl: Mark functions static"

On 22/08/17 10:48 AM, Timothy Arceri wrote: > This reverts commit ca73c3358c91434e68ab31c23d13986d87c661cd. > > This commit broke 'make check' revert it for now. Acked-by: Michel Dänzer -- Earthling Michel Dänzer | http://www.amd.com Libre

Re: [Mesa-dev] [PATCH 5/5] radv/gfx9: fix tile swizzle handling for gfx9

Hi Dave, On 15 August 2017 at 06:26, Dave Airlie wrote: > From: David Airlie > > This sets the tile swizzle up properly for gfx9. > > Signed-off-by: Dave Airlie > --- Can you please provide a backport of this patch for

Re: [Mesa-dev] [PATCH 07/16] radeonsi: add reference count to si_compute

On Mon, Aug 21, 2017 at 8:36 AM, Gert Wollny wrote: > Am Sonntag, den 20.08.2017, 15:48 +0200 schrieb Marek Olšák: >> The patch seems OK to me. > > Hmm, > > you're right in that I was wrong about "program", I still need learn to > think in patches. > > However, when I look

[Mesa-dev] [PATCH V3 2/2] mesa: Modify drirc option types

From: Quentin Liu The type and default values of certain drirc options are changed, namely, those semantically boolean options such as pp_celshade. --- src/gallium/auxiliary/pipe-loader/driinfo_gallium.h | 8 src/util/xmlpool/t_options.h

Re: [Mesa-dev] [Mesa-stable] [PATCH] radeonsi: update non-resident bindless descriptors if needed

On Mon, Aug 21, 2017 at 3:23 PM, Samuel Pitoiset wrote: > > > On 08/19/2017 03:37 AM, Marek Olšák wrote: >> >> On Sat, Aug 19, 2017 at 1:49 AM, Emil Velikov >> wrote: >>> >>> Hi Samuel, >>> >>> On 9 August 2017 at 14:47, Samuel Pitoiset

  1   2   >