Re: [Mesa-dev] [PATCH] i965/gen6/xfb: handle case where transform feedback is not active

2018-08-29 Thread Samuel Iglesias Gonsálvez
On 28/08/18 23:41, Andres Gomez wrote: > Andrii, Samuel, should we also include this in the stable queues ? Yes, please. Add it to stable queue. Sam > > On Wed, 2018-08-15 at 18:20 +0300, asimiklit.w...@gmail.com wrote: >> From: Andrii Simiklit >> >> When the SVBI Payload Enable is false I

Re: [Mesa-dev] [PATCH 18/22] intel: Use TXQ for image_size when we have a typed surface

2018-08-29 Thread Kenneth Graunke
On Friday, August 17, 2018 1:06:24 PM PDT Jason Ekstrand wrote: > --- > src/intel/compiler/brw_eu_defines.h | 3 +++ > src/intel/compiler/brw_fs.cpp | 8 ++ > src/intel/compiler/brw_fs_generator.cpp | 26 --- >

Re: [Mesa-dev] [PATCH] egl/android: rework device probing

2018-08-29 Thread Tomasz Figa
Hi Emil, On Fri, Aug 24, 2018 at 9:25 PM Emil Velikov wrote: > > From: Emil Velikov > > Unlike the other platforms, here we aim do guess if the device that we > somewhat arbitrarily picked, is supported or not. > > In particular: when a vendor is _not_ requested we loop through all > devices,

Re: [Mesa-dev] [PATCH 17/22] glsl/link, i965: Make ImageAccess four-state

2018-08-29 Thread Kenneth Graunke
On Friday, August 17, 2018 1:06:23 PM PDT Jason Ekstrand wrote: > The GLSL spec allows you to set both the "readonly" and "writeonly" > qualifiers on images to indicate that it can only be used with > imageSize. However, we had no way of representing this int he linked > shader and flagged it as

Re: [Mesa-dev] [PATCH] virgl: don't send a shader create with no data.

2018-08-29 Thread Erik Faye-Lund
On on., aug. 29, 2018 at 12:34 AM, Dave Airlie wrote: From: Dave Airlie This fixes the situation where we'd send a shader with just the header and no data. piglit/glsl-max-varyings test was causing this to happen, and the renderer fix was breaking it. ---

Re: [Mesa-dev] [PATCH] ac/radeonsi: fix CIK copy max size

2018-08-29 Thread Christian König
Am 29.08.2018 um 05:53 schrieb Dave Airlie: From: Dave Airlie While adding transfer queues to radv, I started writing some tests, the first test I wrote fell over copying a buffer larger than this limit. Checked AMDVLK and found the correct limit. Cc: --- src/amd/common/sid.h | 4 +++- 1

[Mesa-dev] [Bug 107734] [GLSL] glsl-fface-invariant, glsl-fcoord-invariant and glsl-pcoord-invariant should fail

2018-08-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107734 Bug ID: 107734 Summary: [GLSL] glsl-fface-invariant, glsl-fcoord-invariant and glsl-pcoord-invariant should fail Product: Mesa Version: unspecified Hardware: Other

[Mesa-dev] [PATCH] glsl/linker: Check the invariance of built-in special variables

2018-08-29 Thread Vadym Shovkoplias
From Section 4.6.4 (Invariance and Linkage) of the GLSL ES 1.0 specification "The invariance of varyings that are declared in both the vertex and fragment shaders must match. For the built-in special variables, gl_FragCoord can only be declared invariant if and only if

[Mesa-dev] [AppVeyor] mesa master #8738 failed

2018-08-29 Thread AppVeyor
Build mesa 8738 failed Commit 5a1c23d150 by Lionel Landwerlin on 8/28/2018 10:16 AM: anv: blorp: support multiple aspect blits\n\nNewer blit tests are enabling depth blits. We currently don't\nsupport it but can do by iterating over the aspects masks (copy

Re: [Mesa-dev] [PATCH] ac/radeonsi: fix CIK copy max size

2018-08-29 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Wed, Aug 29, 2018 at 5:53 AM Dave Airlie wrote: > > From: Dave Airlie > > While adding transfer queues to radv, I started writing some tests, > the first test I wrote fell over copying a buffer larger than this > limit. > > Checked AMDVLK and found the correct

[Mesa-dev] [Bug 107698] Ubuntu 18.10 kernel 4.18rc1-4.18.6 or kernel 4.19rc1

2018-08-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107698 --- Comment #5 from efeli...@yahoo.com --- I tried to add amdgpu.dc=0 on the kernel command line, but this does not avoid the back screen. The screen go black when the amdgpu driver is loaded because I can catch to see nothing. I see bootloader

Re: [Mesa-dev] [PATCH] glsl/linker: Link all out vars from a shader objects on a single stage

2018-08-29 Thread Timothy Arceri
On 28/08/18 17:34, Vadim Shovkoplias wrote: Hi Timothy, Thanks for the review! Space was removed. Can you please push this patch since I haven't got write permissions ? For some reason the space was still there but I removed it and pushed. Thanks for the patch. Regards, Vadym вт, 28

[Mesa-dev] [AppVeyor] mesa master #8739 completed

2018-08-29 Thread AppVeyor
Build mesa 8739 completed Commit 966a797e43 by vadym.shovkoplias on 8/28/2018 7:32 AM: glsl/linker: Link all out vars from a shader objects on a single stage\n\nDuring intra stage linking some out variables can be dropped because\nit is not used in a shader

[Mesa-dev] [PATCH v2 3/5] gitlab-ci: Build from the released tarballs

2018-08-29 Thread Juan A. Suarez Romero
The `distcheck` stage creates a tarball ready for the distribution, and compiles it with the autotools to ensure everything works fine. But it does not try with the other tools: scons and meson. Hence, let's add a new stage that takes the generated tarball and builds it using meson and scons.

[Mesa-dev] [PATCH v2 1/5] gitlab-ci: build Mesa using GitLab CI

2018-08-29 Thread Juan A. Suarez Romero
Creates different Docker images containing Mesa built with different tools (autotools, meson, scons, etc). The build is done in 3 levels: the first level creates a base image with all the requirements to build Mesa. The second level (based of the first one), builds different images with

[Mesa-dev] [PATCH v2 2/5] gitlab-ci: build base images if dependencies changed

2018-08-29 Thread Juan A. Suarez Romero
Most of times, the base and LLVM images do not require to be rebuilt, as the dependencies remains the same. To avoid rebuilding these images everytime, store in the image the Dockerfile's sha256sum: if the Dockerfile changes (because new dependencies were added or changed), then rebuild the image

[Mesa-dev] [PATCH v2 0/5] Use GitLab CI to build Mesa

2018-08-29 Thread Juan A. Suarez Romero
Hello. This is a first part, version 2, of a more complete proposal to use GitLab CI to build and test Mesa. This first part just adds the required pieces to build Mesa, using the different supported tools (meson, autotools, and scons). A second part, to be sent in the future, will use the

[Mesa-dev] [Bug 105731] linker error "fragment shader input ... has no matching output in the previous stage" when previous stage's output declaration in a separate shader object

2018-08-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105731 Timothy Arceri changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[Mesa-dev] [PATCH v2 5/5] gitlab-ci: use branch/tag in base image names

2018-08-29 Thread Juan A. Suarez Romero
To avoid conflicts with the base images when building two different branches or tags at the same time, let's use different base/llvm image names. This way if both branches require different dependencies each one will use its own base/llvm images. Signed-off-by: Juan A. Suarez Romero ---

[Mesa-dev] [PATCH v2 4/5] gitlab-ci: update base + llvm images with scheduled pipelines

2018-08-29 Thread Juan A. Suarez Romero
Use scheduled pipelines to update both the base and the LLVM images. This way allows to have an updated version of the base images even when the respect Rockerfiles keep the same. Signed-off-by: Juan A. Suarez Romero --- .gitlab-ci.yml | 8 ++-- 1 file changed, 6 insertions(+), 2

Re: [Mesa-dev] [PATCH 10/10] egl: add EGL_platform_device support

2018-08-29 Thread Emil Velikov
On 29 August 2018 at 12:16, Eric Engestrom wrote: >> +static int >> +_eglCompareDeviceDisplay(_EGLDisplay *dpy, void *plat_opt) > > This is a true/false check, so we I think should return a bool and > change name to reflect which "comparison" returns true, and you could > avoid the inline cast

Re: [Mesa-dev] [PATCH 14/22] intel/compiler: Do image load/store lowering to NIR

2018-08-29 Thread Jason Ekstrand
On Wed, Aug 29, 2018 at 12:49 AM Kenneth Graunke wrote: > On Friday, August 17, 2018 1:06:20 PM PDT Jason Ekstrand wrote: > [snip] > > +# Intel-specific query for loading from the brw_image_param struct > passed > > +# into the shader as a uniform. The variable is a deref to the image > > +#

Re: [Mesa-dev] [PATCH mesa] meson: disable asserts by default on release builds

2018-08-29 Thread Emil Velikov
On 29 August 2018 at 15:01, Eric Engestrom wrote: > Ping? > > I think we should land this now, ie. for 18.3. > > By the time Mesa 18.3 comes out (probably December '18), Meson 0.45 will > be 9 months old (March '18), so I think this is reasonable. > > (btw, the currently-required Meson 0.44.1 was

Re: [Mesa-dev] [PATCH 10/10] egl: add EGL_platform_device support

2018-08-29 Thread Eric Engestrom
On Friday, 2018-08-03 13:44:26 +0100, Emil Velikov wrote: > From: Emil Velikov > > This new 'platform' is added by default with no guards. > > It is effectively a copy of the surfaceless one, with updated function > names and brand new probe function. > > Due to the reuse, some of the ifdef

Re: [Mesa-dev] [PATCH 03/10] egl: add EGL_MESA_device_software support

2018-08-29 Thread Eric Engestrom
On Friday, 2018-08-03 13:44:19 +0100, Emil Velikov wrote: > From: Emil Velikov > > Add LookupDevices/FindDevice helpers, alongside their first user - > software device ;-) > > This adds support to both dri2 and haiku backends. > > Signed-off-by: Emil Velikov > --- > How can we split this up

Re: [Mesa-dev] [PATCH 02/10] egl: add simple EGL_EXT_device_base implementation

2018-08-29 Thread Emil Velikov
Hi Eric, On 29 August 2018 at 11:29, Eric Engestrom wrote: >> +EGLBoolean >> +_eglQueryDevicesEXT(EGLint max_devices, >> +_EGLDevice **devices, >> +EGLint *num_devices) >> +{ >> + _EGLDevice *dev, *devs; >> + int i = 0, num_devs; >> + >> + if

Re: [Mesa-dev] [PATCH 02/10] egl: add simple EGL_EXT_device_base implementation

2018-08-29 Thread Eric Engestrom
On Friday, 2018-08-03 13:44:18 +0100, Emil Velikov wrote: > From: Emil Velikov > > Introduce the API for device query and enumeration. Those at the moment > produce nothing useful since zero devices are actually available. > > With later commits we'll add support for software (always) and

Re: [Mesa-dev] [PATCH 18/22] intel: Use TXQ for image_size when we have a typed surface

2018-08-29 Thread Jason Ekstrand
On Wed, Aug 29, 2018 at 1:36 AM Kenneth Graunke wrote: > On Friday, August 17, 2018 1:06:24 PM PDT Jason Ekstrand wrote: > > --- > > src/intel/compiler/brw_eu_defines.h | 3 +++ > > src/intel/compiler/brw_fs.cpp | 8 ++ > > src/intel/compiler/brw_fs_generator.cpp

Re: [Mesa-dev] [PATCH mesa] meson: disable asserts by default on release builds

2018-08-29 Thread Eric Engestrom
Ping? I think we should land this now, ie. for 18.3. By the time Mesa 18.3 comes out (probably December '18), Meson 0.45 will be 9 months old (March '18), so I think this is reasonable. (btw, the currently-required Meson 0.44.1 was released less than 12 days before 0.45, so we're really not

Re: [Mesa-dev] [PATCH/RFC] glsl: allow redeclaring variables as 'precise invariant'

2018-08-29 Thread Erik Faye-Lund
Ping? On on., aug. 22, 2018 at 7:34 PM, Erik Faye-Lund wrote: There's seems to be nothing in the GLSL (ES) specifications that diallow redeclaring a variable as both 'precise' and 'invariant' in the same statement. But the way the parse-rules are structured this fails to parse, because this

Re: [Mesa-dev] [PATCH 18/22] intel: Use TXQ for image_size when we have a typed surface

2018-08-29 Thread Kenneth Graunke
On Wednesday, August 29, 2018 5:38:59 AM PDT Jason Ekstrand wrote: > On Wed, Aug 29, 2018 at 1:36 AM Kenneth Graunke > wrote: > > > On Friday, August 17, 2018 1:06:24 PM PDT Jason Ekstrand wrote: > > > --- > > > src/intel/compiler/brw_eu_defines.h | 3 +++ > > >

Re: [Mesa-dev] [PATCH 03/10] egl: add EGL_MESA_device_software support

2018-08-29 Thread Emil Velikov
On 29 August 2018 at 12:47, Eric Engestrom wrote: >> +{ >> + _EGLDevice *dev; >> + >> + mtx_lock(_eglGlobal.Mutex); >> + dev = _eglGlobal.DeviceList; >> + /* The first device is always software */ >> + if (!dev) { >> + _eglGlobal.DeviceList = _device; >> + dev =

Re: [Mesa-dev] [PATCH 3/3] i965/screen: Allow modifiers on sRGB formats

2018-08-29 Thread Eero Tamminen
Hi, On 29.08.2018 01:22, Jason Ekstrand wrote: This effectively reverts a26693493570a9d0f0fba1be617e01ee7bfff4db which was a misguided attempt at protecting intel_query_dma_buf_modifiers from invalid formats. Unfortunately, in some internal EGL cases, we can get an SRGB format validly in this

Re: [Mesa-dev] [PATCH v2 5/5] gitlab-ci: use branch/tag in base image names

2018-08-29 Thread Emil Velikov
On 29 August 2018 at 11:12, Juan A. Suarez Romero wrote: > To avoid conflicts with the base images when building two different > branches or tags at the same time, let's use different base/llvm image > names. > > This way if both branches require different dependencies each one will > use its own

Re: [Mesa-dev] [PATCH v2 4/5] gitlab-ci: update base + llvm images with scheduled pipelines

2018-08-29 Thread Emil Velikov
On 29 August 2018 at 11:12, Juan A. Suarez Romero wrote: > Use scheduled pipelines to update both the base and the LLVM images. > > This way allows to have an updated version of the base images even when > the respect Rockerfiles keep the same. > Grammar seems off. Please include an example when

[Mesa-dev] [Bug 107477] [DXVK] Setting high shader quality in GTA V results in LLVM error

2018-08-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107477 --- Comment #14 from Samuel Pitoiset --- Created attachment 141347 --> https://bugs.freedesktop.org/attachment.cgi?id=141347=edit fix v2 Does this fix the smoke issue too? -- You are receiving this mail because: You are the assignee for

Re: [Mesa-dev] [PATCH 2/3] anv: Copy the appliation info into the instance

2018-08-29 Thread Andres Gomez
Jason, this series (specifically, the patch 2/3), is causing regressions in VK-GL-CTS with mesa's 18.2 stable queue. I don't know if this is happening also in master, but it's quite possible. I've checked with the x11_egl target and the "vulkan-cts-1.1.2" branch:

[Mesa-dev] [Bug 107734] [GLSL] glsl-fface-invariant, glsl-fcoord-invariant and glsl-pcoord-invariant should fail

2018-08-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107734 --- Comment #1 from vadym --- Patch: https://patchwork.freedesktop.org/patch/246321/ -- You are receiving this mail because: You are the assignee for the bug.___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH v2 1/5] gitlab-ci: build Mesa using GitLab CI

2018-08-29 Thread Emil Velikov
Hi Juan, I've shared a number of suggestions. I'll leave that to you if they will be in v3 or patches on top. On 29 August 2018 at 11:12, Juan A. Suarez Romero wrote: > In order to build the images, Rocker is used. This is a tool that > extends the Dockerfiles with new features that are quite

Re: [Mesa-dev] [PATCH] egl/android: rework device probing

2018-08-29 Thread Emil Velikov
On 29 August 2018 at 07:55, Tomasz Figa wrote: > Hi Emil, > > On Fri, Aug 24, 2018 at 9:25 PM Emil Velikov wrote: >> >> From: Emil Velikov >> >> Unlike the other platforms, here we aim do guess if the device that we >> somewhat arbitrarily picked, is supported or not. >> >> In particular: when

Re: [Mesa-dev] [PATCH 1/5] meson: Actually load translation files

2018-08-29 Thread Emil Velikov
On 29 August 2018 at 15:37, Andres Gomez wrote: > Dylan, due to a previously backport requested by Emil, this patch has > bumped into some trivial conflict I have resolved. > > Please, check that everything looks in order. > > You can find the commit here (staging/18.2): >

Re: [Mesa-dev] [PATCH 3/3] anv: Claim to support depthBounds for ID games

2018-08-29 Thread Jason Ekstrand
On Wed, Aug 29, 2018 at 10:52 AM Eric Engestrom wrote: > On Tuesday, 2018-08-28 13:02:17 -0500, Jason Ekstrand wrote: > > On Tue, Aug 28, 2018 at 12:40 PM Lionel Landwerlin < > > lionel.g.landwer...@intel.com> wrote: > > > I remember talks about doing this kind of tricks for particular titles >

Re: [Mesa-dev] [PATCH 22/22] intel/compiler: Remove surface_idx from brw_image_param

2018-08-29 Thread Kenneth Graunke
On Friday, August 17, 2018 1:06:28 PM PDT Jason Ekstrand wrote: > Now that the drivers are lowering to surface indices themselves, we no > longer need to push the surface index into the shader. > --- > src/intel/compiler/brw_compiler.h| 16 ++-- >

[Mesa-dev] [Bug 107477] [DXVK] Setting high shader quality in GTA V results in LLVM error

2018-08-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107477 --- Comment #15 from Clément Guérin --- I haven't found the time to test it yet. Is forcing `output_usage_mask` at line 71 intentional? -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the

Re: [Mesa-dev] [PATCH 1/5] meson: Actually load translation files

2018-08-29 Thread Andres Gomez
Dylan, due to a previously backport requested by Emil, this patch has bumped into some trivial conflict I have resolved. Please, check that everything looks in order. You can find the commit here (staging/18.2):

Re: [Mesa-dev] [PATCH] anv: Free the app and engine name

2018-08-29 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 29/08/2018 16:07, Jason Ekstrand wrote: Fixes: 8c048af5890d4 "anv: Copy the appliation info into the instance" --- src/intel/vulkan/anv_device.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/intel/vulkan/anv_device.c

[Mesa-dev] [PATCH] nir: evaluate if condition uses inside the if branches

2018-08-29 Thread Jason Ekstrand
From: Timothy Arceri Since we know what side of the branch we ended up on we can just replace the use with a constant. All the spill changes in shader-db are from Dolphin uber shaders, despite some small regressions the change is clearly positive. V2: insert new constant after any phis in the

Re: [Mesa-dev] [PATCH 3/3] i965/screen: Allow modifiers on sRGB formats

2018-08-29 Thread Jason Ekstrand
On Wed, Aug 29, 2018 at 10:42 AM Eric Engestrom wrote: > On Tuesday, 2018-08-28 21:44:54 -0500, Jason Ekstrand wrote: > > On Tue, Aug 28, 2018 at 5:22 PM Jason Ekstrand > wrote: > > > > > This effectively reverts a26693493570a9d0f0fba1be617e01ee7bfff4db which > > > was a misguided attempt at

[Mesa-dev] [PATCH] anv: Free the app and engine name

2018-08-29 Thread Jason Ekstrand
Fixes: 8c048af5890d4 "anv: Copy the appliation info into the instance" --- src/intel/vulkan/anv_device.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c index 07de5f7543e..47c6c6e93b4 100644 --- a/src/intel/vulkan/anv_device.c

[Mesa-dev] [PATCH] radv: Add missing checks in radv_get_image_format_properties.

2018-08-29 Thread Bas Nieuwenhuizen
CC: --- src/amd/vulkan/radv_formats.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/src/amd/vulkan/radv_formats.c b/src/amd/vulkan/radv_formats.c index f0cc0fc5f95..6253c27b95d 100644 --- a/src/amd/vulkan/radv_formats.c +++ b/src/amd/vulkan/radv_formats.c @@ -1112,6

Re: [Mesa-dev] [Mesa-stable] [PATCH] mesa: allow GL_UNSIGNED_BYTE type for SNORM reads

2018-08-29 Thread Dylan Baker
Quoting Tapani Pälli (2018-08-27 04:46:37) > OpenGL ES spec states: >"For normalized fixed-point rendering surfaces, the combination format > RGBA and type UNSIGNED_BYTE is accepted." > > This fixes following failing VK-GL-CTS tests: > >

Re: [Mesa-dev] [PATCH v2] mesa: enable ARB_direct_state_access in compat for GL3.1+

2018-08-29 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Tue, Aug 28, 2018 at 10:40 PM, Timothy Arceri wrote: > We could enable it for lower versions of GL but this allows us > to just use the existing version/extension checks that are already > used by the core profile. > > v2: fix potential crash in no error path

Re: [Mesa-dev] [PATCH 3/3] i965/screen: Allow modifiers on sRGB formats

2018-08-29 Thread Eric Engestrom
On Tuesday, 2018-08-28 21:44:54 -0500, Jason Ekstrand wrote: > On Tue, Aug 28, 2018 at 5:22 PM Jason Ekstrand wrote: > > > This effectively reverts a26693493570a9d0f0fba1be617e01ee7bfff4db which > > was a misguided attempt at protecting intel_query_dma_buf_modifiers from > > invalid formats.

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/5] meson: Actually load translation files

2018-08-29 Thread Dylan Baker
Quoting Andres Gomez (2018-08-29 07:37:57) > Dylan, due to a previously backport requested by Emil, this patch has > bumped into some trivial conflict I have resolved. > > Please, check that everything looks in order. > > You can find the commit here (staging/18.2): >

Re: [Mesa-dev] [PATCH] anv: blorp: support multiple aspect blits

2018-08-29 Thread Dylan Baker
Quoting Lionel Landwerlin (2018-08-28 04:27:13) > Newer blit tests are enabling depth blits. We currently don't > support it but can do by iterating over the aspects masks (copy some > logic from the CopyImage function). > > Signed-off-by: Lionel Landwerlin > Fixes: 9f44745eca0e41 ("anv: Use

[Mesa-dev] [PATCH v2 14/22] intel/compiler: Do image load/store lowering to NIR

2018-08-29 Thread Jason Ekstrand
This commit moves our storage image format conversion codegen into NIR instead of doing it in the back-end. This has the advantage of letting us run it through NIR's optimizer which is pretty effective at shrinking things down. In the common case of rgba8, the number of instructions emitted

[Mesa-dev] [PATCH] anv: Use separate MOCS settings for external BOs on gen8

2018-08-29 Thread Jason Ekstrand
On all other platforms, it's safe to use the usual PTE settings for both internal and external BOs. On Broadwell, however, we can't get the right caching behavior for scanout without disabling eLLC and we really don't want to do this on everything. In order to do this, we add an anv-specific BO

[Mesa-dev] [PATCH] anv: Re-emit vertex buffers when the pipeline changes

2018-08-29 Thread Jason Ekstrand
Some of the bits of VERTEX_BUFFER_STATE such as access type, instance data step rate, and pitch come from the pipeline. Cc: mesa-sta...@lists.freedesktop.org --- src/intel/vulkan/genX_cmd_buffer.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/intel/vulkan/genX_cmd_buffer.c

Re: [Mesa-dev] [PATCH] glsl: skip stringification in preprocessor if in unreachable branch

2018-08-29 Thread Ian Romanick
On 08/28/2018 06:36 PM, Timothy Arceri wrote: > This fixes compilation of some "No Mans Sky" shaders where the stringification > happens in branches intended for DX12. I was going to complain that this would make things like the following compile: #version 110 #ifdef this_is_undefined

Re: [Mesa-dev] [PATCH 18/22] intel: Use TXQ for image_size when we have a typed surface

2018-08-29 Thread Jason Ekstrand
On Wed, Aug 29, 2018 at 9:29 AM Kenneth Graunke wrote: > On Wednesday, August 29, 2018 5:38:59 AM PDT Jason Ekstrand wrote: > > On Wed, Aug 29, 2018 at 1:36 AM Kenneth Graunke > > wrote: > > > > > On Friday, August 17, 2018 1:06:24 PM PDT Jason Ekstrand wrote: > > > > --- > > > >

Re: [Mesa-dev] [PATCH 3/3] anv: Claim to support depthBounds for ID games

2018-08-29 Thread Eric Engestrom
On Tuesday, 2018-08-28 13:02:17 -0500, Jason Ekstrand wrote: > On Tue, Aug 28, 2018 at 12:40 PM Lionel Landwerlin < > lionel.g.landwer...@intel.com> wrote: > > I remember talks about doing this kind of tricks for particular titles in > > a layer. > > > > It doesn't necessarily makes things easier

[Mesa-dev] [PATCH v2 21.5/22 (was 18/22)] intel: Use TXS for image_size when we have a typed surface

2018-08-29 Thread Jason Ekstrand
--- src/intel/compiler/brw_eu_defines.h | 2 ++ src/intel/compiler/brw_fs_generator.cpp | 23 +--- src/intel/compiler/brw_fs_nir.cpp | 35 +++ .../compiler/brw_nir_lower_image_load_store.c | 15 src/intel/compiler/brw_shader.cpp

Re: [Mesa-dev] [PATCH v2 14/22] intel/compiler: Do image load/store lowering to NIR

2018-08-29 Thread Kenneth Graunke
On Wednesday, August 29, 2018 10:11:48 AM PDT Jason Ekstrand wrote: > This commit moves our storage image format conversion codegen into NIR > instead of doing it in the back-end. This has the advantage of letting > us run it through NIR's optimizer which is pretty effective at shrinking > things

Re: [Mesa-dev] [PATCH 2/3] anv: Copy the appliation info into the instance

2018-08-29 Thread Jason Ekstrand
I just pushed a fix: commit cdea5d996edaaf59ab0acf3e758c3d9a4c22c335 (public/master) Author: Jason Ekstrand Date: Wed Aug 29 10:06:56 2018 -0500 anv: Free the app and engine name Fixes: 8c048af5890d4 "anv: Copy the appliation info into the instance" Reviewed-by: Lionel Landwerlin

[Mesa-dev] [PATCH 2/2] pipe-loader: move dup(fd) within pipe_loader_drm_probe_fd

2018-08-29 Thread Emil Velikov
From: Emil Velikov Currently pipe_loader_drm_probe_fd takes ownership of the fd given. To match that, pipe_loader_release closes it. Yet we have many instances which do not want the change of ownership, and thus duplicate the fd before passing it to the pipe-loader. Move the dup() within

[Mesa-dev] [PATCH 1/2] st/nine: do not double-close the fd on teardown

2018-08-29 Thread Emil Velikov
From: Emil Velikov As the newly introduced comment says: The pipe loader takes ownership of the fd Thus, there's no need to close it again. Cc: Patrick Rudolph Cc: Axel Davy Cc: mesa-sta...@lists.freedesktop.org> Signed-off-by: Emil Velikov --- src/gallium/targets/d3dadapter9/drm.c | 2 +-

Re: [Mesa-dev] [PATCH 2/3] anv: Copy the appliation info into the instance

2018-08-29 Thread Jason Ekstrand
Thanks for the heads up. I just sent a patch which should fix it. Hooray for the CTS catching memory leaks. --Jason On Wed, Aug 29, 2018 at 9:32 AM Andres Gomez wrote: > Jason, this series (specifically, the patch 2/3), is causing > regressions in VK-GL-CTS with mesa's 18.2 stable queue. I

Re: [Mesa-dev] [PATCH mesa] meson: disable asserts by default on release builds

2018-08-29 Thread Dylan Baker
Quoting Dylan Baker (2018-08-29 08:58:55) > Quoting Eric Engestrom (2018-08-29 07:01:06) > > Ping? > > > > I think we should land this now, ie. for 18.3. > > > > By the time Mesa 18.3 comes out (probably December '18), Meson 0.45 will > > be 9 months old (March '18), so I think this is

Re: [Mesa-dev] [PATCH 21/22] anv, i965: Lower away image derefs in the driver

2018-08-29 Thread Kenneth Graunke
On Friday, August 17, 2018 1:06:27 PM PDT Jason Ekstrand wrote: > Previously, the back-end compiler turn image access into magic uniform > reads and there was a complex contract between back-end compiler and > driver about setting up and filling out those params. As of this > commit, both drivers

Re: [Mesa-dev] [PATCH v2 21.5/22 (was 18/22)] intel: Use TXS for image_size when we have a typed surface

2018-08-29 Thread Kenneth Graunke
On Wednesday, August 29, 2018 10:12:59 AM PDT Jason Ekstrand wrote: > --- > src/intel/compiler/brw_eu_defines.h | 2 ++ > src/intel/compiler/brw_fs_generator.cpp | 23 +--- > src/intel/compiler/brw_fs_nir.cpp | 35 +++ >

[Mesa-dev] [PATCH v3] intel/tools: new i965_disasm tool

2018-08-29 Thread Sagar Ghuge
Adds a new i965 instruction disassemble tool v2: 1) fix a few nits (Matt Turner) 2) Remove i965_disasm header (Matt Turner) v3: 1) Redirect output to correct file descriptors (Matt Turner) 2) Refactor code (Matt Turner) 3) Use better formatting style (Matt Turner) Signed-off-by:

[Mesa-dev] [PATCH 14/15] radeonsi: flush when an IB uses more VRAM than available

2018-08-29 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_pipe.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_pipe.h b/src/gallium/drivers/radeonsi/si_pipe.h index 29d7e555a0c..b3d607b93e3 100644 --- a/src/gallium/drivers/radeonsi/si_pipe.h +++

[Mesa-dev] [PATCH 10/15] radeonsi: merge SI and CI dma_clear_buffer and remove the callback

2018-08-29 Thread Marek Olšák
From: Marek Olšák also use assertions for the requirements that offset and size are a multiple of 4. --- src/gallium/drivers/radeon/radeon_video.c | 3 +- src/gallium/drivers/radeonsi/cik_sdma.c | 41 - src/gallium/drivers/radeonsi/si_cp_dma.c | 2 +-

[Mesa-dev] [PATCH 13/15] radeonsi: adjust and simplify max_alloc_size determination

2018-08-29 Thread Marek Olšák
From: Marek Olšák --- src/amd/common/ac_gpu_info.c | 16 .../winsys/radeon/drm/radeon_drm_winsys.c| 8 +--- 2 files changed, 13 insertions(+), 11 deletions(-) diff --git a/src/amd/common/ac_gpu_info.c b/src/amd/common/ac_gpu_info.c index

[Mesa-dev] [PATCH 01/15] radeonsi: fix HTILE for NPOT textures with mipmapping on SI/CI

2018-08-29 Thread Marek Olšák
From: Marek Olšák VI uses addrlib so it's unaffected. Cc: 18.1 18.2 --- src/gallium/drivers/radeonsi/si_texture.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_texture.c b/src/gallium/drivers/radeonsi/si_texture.c index

[Mesa-dev] [Bug 107477] [DXVK] Setting high shader quality in GTA V results in LLVM error

2018-08-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107477 --- Comment #16 from Samuel Pitoiset --- Yeah, it was just a workaround for a weird issue but I fixed it since. I'm improving the patch for supporting cull distances as well. -- You are receiving this mail because: You are the QA Contact for

Re: [Mesa-dev] [PATCH 5/9] nir: Add a local dead write vars removal pass

2018-08-29 Thread Jason Ekstrand
On Wed, Aug 29, 2018 at 3:19 PM Caio Marcelo de Oliveira Filho < caio.olive...@intel.com> wrote: > Jason Ekstrand writes: > > >> >> +static bool > >> >> +remove_dead_write_vars_local(struct state *state, nir_block *block) > >> >> +{ > >> >> + bool progress = false; > >> >> + > >> >> + struct

Re: [Mesa-dev] [PATCH 2/2] i965/vec4: Clamp indirect tes input array reads with 0x0fffffff

2018-08-29 Thread Jason Ekstrand
Have you seen this cause an actual problem? There's no way we can actually end up with an input array that big... I guess this is for the crazy OOB case? On Wed, Aug 29, 2018 at 3:12 PM Ian Romanick wrote: > From: Ian Romanick > > Page 190 of "Volume 7: 3D Media GPGPU Engine (Haswell)" says

Re: [Mesa-dev] [PATCH] docs/relnotes: Add AMD_depth_clamp_separate for i965

2018-08-29 Thread Marek Olšák
Looks good. You can push this without an Rb. Marek On Tue, Aug 28, 2018 at 5:53 PM, Sagar Ghuge wrote: > Signed-off-by: Sagar Ghuge > --- > docs/relnotes/18.3.0.html | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/docs/relnotes/18.3.0.html b/docs/relnotes/18.3.0.html > index

[Mesa-dev] [Bug 105731] linker error "fragment shader input ... has no matching output in the previous stage" when previous stage's output declaration in a separate shader object

2018-08-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105731 --- Comment #3 from Mark Janes --- Vadym, can you make a piglit test for this bug? -- You are receiving this mail because: You are the assignee for the bug.___ mesa-dev mailing list

[Mesa-dev] [PATCH 00/15] RadeonSI Fixes and Cleanups

2018-08-29 Thread Marek Olšák
Hi, There are HTILE and CMASK allocator fixes, a GPU hang fix for bindless textures with LLVM 7.0, partial NIR support for bindless textures, ddebug fix, and much more. Please review. Thanks, Marek ___ mesa-dev mailing list

[Mesa-dev] [PATCH 03/15] r600: fix HTILE for NPOT textures with mipmapping

2018-08-29 Thread Marek Olšák
From: Marek Olšák Cc: 18.1 18.2 --- src/gallium/drivers/r600/r600_texture.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/r600/r600_texture.c b/src/gallium/drivers/r600/r600_texture.c index 08db6bab04c..d08c6e5637c 100644 ---

[Mesa-dev] [PATCH 2/2] i965/vec4: Clamp indirect tes input array reads with 0x0fffffff

2018-08-29 Thread Ian Romanick
From: Ian Romanick Page 190 of "Volume 7: 3D Media GPGPU Engine (Haswell)" says the valid range of the offset is [0, 0FFFh]. Signed-off-by: Ian Romanick Cc: mesa-sta...@lists.freedesktop.org Cc: Kenneth Graunke --- src/intel/compiler/brw_vec4_tes.cpp | 12 +++- 1 file changed, 11

[Mesa-dev] [PATCH 1/2] i965/vec4: Correctly handle uniform sources in generate_tes_add_indirect_urb_offset

2018-08-29 Thread Ian Romanick
From: Ian Romanick Fixes failure in the new piglit test tes-patch-input-array-vec2-index-invalid-rd.shader_test. Signed-off-by: Ian Romanick Cc: mesa-sta...@lists.freedesktop.org Cc: Kenneth Graunke --- src/intel/compiler/brw_vec4_generator.cpp | 15 ++- 1 file changed, 14

[Mesa-dev] [PATCH v2] i965/gen7_urb: Re-emit PUSH_CONSTANT_ALLOC on some gen9

2018-08-29 Thread Nanley Chery
According to internal docs, some gen9 platforms have a pixel shader push constant synchronization issue. Although not listed among said platforms, this issue seems to be present on the GeminiLake 2x6's we've tested. We consider the available workarounds to be too detrimental on performance.

Re: [Mesa-dev] [PATCH] mesa/state_tracker: explicitely handle case ir_intrinsic_begin_fragment_shader_ordering in visit_generic_intrinsic()

2018-08-29 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Tue, Aug 28, 2018 at 2:07 PM, wrote: > From: Kevin Rogovin > > --- > src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp >

Re: [Mesa-dev] [PATCH 2/2] pipe-loader: move dup(fd) within pipe_loader_drm_probe_fd

2018-08-29 Thread Thomas Hellstrom
Hi, Emil, On 08/29/2018 07:13 PM, Emil Velikov wrote: From: Emil Velikov Currently pipe_loader_drm_probe_fd takes ownership of the fd given. To match that, pipe_loader_release closes it. Yet we have many instances which do not want the change of ownership, and thus duplicate the fd before

[Mesa-dev] [PATCH 2/5] i965/vec4/dce: Don't narrow the write mask if the flags are used

2018-08-29 Thread Ian Romanick
From: Ian Romanick In an instruction sequence like cmp(8).ge.f0.0 vgrf17:D, vgrf2.:D, vgrf9.:D (+f0.0) sel(8) vgrf1:UD, vgrf8.xyzw:UD, vgrf1.xyzw:UD The other fields of vgrf17 may be unused, but the CMP still needs to generate the other flag bits. To my surprise,

[Mesa-dev] [RESEND PATCH 0/5] i965: More cmod propagation

2018-08-29 Thread Ian Romanick
This is mostly a resend of a series that I originally sent out around the end of June. I updated some of the shader-db results, and I dropped one patch (i965/fs: Allow Boolean conditions in CSEL generation). I decided that I want to try to acomplish that with a different method. That's going to

[Mesa-dev] [PATCH 4/5] i965/fs: Relax type matching rules in cmod propagation from MOV instructions

2018-08-29 Thread Ian Romanick
From: Ian Romanick To allow cmod propagation from a MOV in a sequence like: and(16) g31<1>UD g20<8,8,1>UD g22<8,8,1>UD mov.nz.f0(16) null<1>F g31<8,8,1>D A similar change to the vec4 backend had no effect. Somewhere between c1ec5820593 and 40fc4b5acd6 (1,094

[Mesa-dev] [PATCH 3/5] i965/fs: Eliminate unary op on operand of compare-with-zero

2018-08-29 Thread Ian Romanick
From: Ian Romanick All Gen7+ platforms had similar results. (Broadwell shown) total instructions in shared programs: 14715715 -> 14715709 (<.01%) instructions in affected programs: 474 -> 468 (-1.27%) helped: 6 HURT: 0 helped stats (abs) min: 1 max: 1 x̄: 1.00 x̃: 1 helped stats (rel) min: 1.12%

[Mesa-dev] [PATCH 1/5] i965/vec4: Silence unused parameter warnings in vec4 compiler tests

2018-08-29 Thread Ian Romanick
From: Ian Romanick src/intel/compiler/test_vec4_copy_propagation.cpp: In member function ‘virtual brw::dst_reg* copy_propagation_vec4_visitor::make_reg_for_system_value(int)’: src/intel/compiler/test_vec4_copy_propagation.cpp:57:51: warning: unused parameter ‘location’ [-Wunused-parameter]

[Mesa-dev] [PATCH 5/5] i965/vec4: Propagate conditional modifiers from more compares to other compares

2018-08-29 Thread Ian Romanick
From: Ian Romanick If there is a CMP.NZ that compares a single component (via a . swizzle, for example) with 0, it can propagate its conditional modifier back to a previous CMP that writes only that component. The specific case that I saw was: cmp.l.f0(8) g42<1>.xF g61<4>.xF

[Mesa-dev] [PATCH] radv: fix passing clip distances from VS to FS

2018-08-29 Thread Samuel Pitoiset
CTS doesn't test input clip distances with the fragment shader stage, which explains why it was broken. I wrote a simple test locally that does pass now. I'm quite sure that cull distances are broken as well but that can be fixed later. This fixes a crash with GTA V and DXVK. Cc:

[Mesa-dev] [PATCH 06/15] ac: add radeon_info::num_good_cu_per_sh

2018-08-29 Thread Marek Olšák
From: Marek Olšák --- src/amd/common/ac_gpu_info.c | 3 +++ src/amd/common/ac_gpu_info.h | 1 + src/gallium/drivers/radeonsi/si_state.c | 4 +--- src/gallium/winsys/radeon/drm/radeon_drm_winsys.c | 4 4 files changed, 9 insertions(+), 3

[Mesa-dev] [PATCH 09/15] radeonsi: fix GPU hangs with bindless textures and LLVM 7.0

2018-08-29 Thread Marek Olšák
From: Marek Olšák --- src/amd/common/ac_llvm_build.c| 52 +-- src/amd/common/ac_llvm_build.h| 4 ++ .../drivers/radeonsi/si_shader_internal.h | 3 +- src/gallium/drivers/radeonsi/si_shader_nir.c | 12 -

[Mesa-dev] [PATCH 15/15] radeonsi/nir: port some bindless and sampler code from TGSI

2018-08-29 Thread Marek Olšák
From: Marek Olšák These might be all missing changes for bindless textures. --- src/gallium/drivers/radeonsi/si_shader_nir.c | 80 1 file changed, 50 insertions(+), 30 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader_nir.c

[Mesa-dev] [PATCH 12/15] radeonsi: split si_copy_buffer

2018-08-29 Thread Marek Olšák
From: Marek Olšák compute and SDMA will be added into it. --- src/gallium/drivers/radeonsi/si_blit.c| 2 +- src/gallium/drivers/radeonsi/si_cp_dma.c | 33 --- src/gallium/drivers/radeonsi/si_pipe.c| 3 +- src/gallium/drivers/radeonsi/si_pipe.h| 8

[Mesa-dev] [PATCH 11/15] radeonsi: don't call VBO prefetch with size=0

2018-08-29 Thread Marek Olšák
From: Marek Olšák for the next commit. --- src/gallium/drivers/radeonsi/si_cp_dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_cp_dma.c b/src/gallium/drivers/radeonsi/si_cp_dma.c index 598d5ecf0dc..ad53682b1b2 100644 ---

[Mesa-dev] [PATCH 07/15] ac: use iN_0/1 constants

2018-08-29 Thread Marek Olšák
From: Marek Olšák --- src/amd/common/ac_llvm_build.c| 23 +-- src/amd/common/ac_nir_to_llvm.c | 4 ++-- src/gallium/drivers/radeonsi/si_shader.c | 4 ++-- .../drivers/radeonsi/si_shader_tgsi_alu.c | 2 +- 4 files changed, 16

  1   2   >