Re: [Mesa-dev] [PATCH] mesa: enable ARB_vertex_buffer_object in core profile

2018-09-06 Thread Timothy Arceri
On 07/09/18 11:49, Ian Romanick wrote: On 09/06/2018 06:08 PM, Timothy Arceri wrote: On 07/09/18 11:00, Ian Romanick wrote: On 09/06/2018 03:24 PM, Timothy Arceri wrote: On 07/09/18 06:18, Ian Romanick wrote: So... this game that requires at least OpenGL 3.2 (by virtue of using core profile)

Re: [Mesa-dev] [PATCH 1/2] gallium: add PIPE_CAP_MAX_TEXTURE_UPLOAD_MEMORY_BUDGET

2018-09-06 Thread Marek Olšák
It's been 6 days since I sent the patches. I'm thinking about just pushing this. Marek On Tue, Sep 4, 2018 at 8:16 PM, Dieter Nützel wrote: > Hello Marek, > > can you resend? > I want the texture upload speed up... > > Dieter > > > Am 01.09.2018 03:02, schrieb Marek Olšák: >> >> From: Marek

Re: [Mesa-dev] [PATCH 0/4] virgil: fix crash when mapping ms-texture

2018-09-06 Thread David Airlie
On Thu, Sep 6, 2018 at 7:58 PM, Erik Faye-Lund wrote: > Here's a series of patches to address a crash when mapping multisampled > textures in piglit. The crash can easily be reproduce using the > following command: > > bin/copyteximage 2D -samples=2 -auto > > However, it's not clear to me if this

Re: [Mesa-dev] [PATCH 1/2] gallium: New cap PIPE_CAP_MAX_VERTEX_ELEMENT_SRC_OFFSET.

2018-09-06 Thread Mathias Fröhlich
Hi, On Thursday, 6 September 2018 23:43:41 CEST Roland Scheidegger wrote: > Looks alright to me, albeit seems a bit weird your hw can have offset of > 255 but only max stride of 128 - max offset being larger than max stride > doesn't really make a whole lot of sense. (Could you handle stride 255

Re: [Mesa-dev] [PATCH 2/4] st/mesa: pin driver threads to a specific L3 cache on AMD Zen (v2)

2018-09-06 Thread Brian Paul
The revised series looks OK to me. One whitespace issue below. For the series, Reviewed-by: Brian Paul On 09/06/2018 07:04 PM, Marek Olšák wrote: From: Marek Olšák v2: use set_context_param --- src/gallium/auxiliary/util/u_helpers.c | 42 +++

Re: [Mesa-dev] [PATCH mesa] meson: drop unnecessary llvm version hacks

2018-09-06 Thread Dylan Baker
Quoting Eric Engestrom (2018-09-06 07:47:49) > The current minimum meson version supported is 0.44.1, so we have met > both the 0.43 and 0.44 requirement to not need these hacks anymore :) > > Signed-off-by: Eric Engestrom > --- > meson.build | 9 - > 1 file changed, 9 deletions(-) > >

Re: [Mesa-dev] [PATCH v2] docs: add the beginning of the 18.3 cycle

2018-09-06 Thread Juan A. Suarez Romero
On Thu, 2018-09-06 at 15:56 +0300, Andres Gomez wrote: > v2: Move 18.3.0-rcZ releases to Tuesdays. > > Cc: Dylan Baker > Cc: Juan A. Suarez > Cc: Emil Velikov > Signed-off-by: Andres Gomez > Acked-by: Dylan Baker > --- > > Releases should happen on Wednesdays and X.Y.0-rcZ announcements

Re: [Mesa-dev] [PATCH] tnl: Fix green gun regression in xonotic.

2018-09-06 Thread Mathias Fröhlich
Hi Dylan, On Thursday, 6 September 2018 18:11:55 CEST Dylan Baker wrote: > > Fix an other regression of patch 64d2a2048054 > > mesa: Make gl_vertex_array contain pointers to first order VAO members. > > The regression showed up with drivers using the tnl module and > > was reproducible using

Re: [Mesa-dev] [PATCH] mesa: enable ARB_vertex_buffer_object in core profile

2018-09-06 Thread Timothy Arceri
On 07/09/18 11:00, Ian Romanick wrote: On 09/06/2018 03:24 PM, Timothy Arceri wrote: On 07/09/18 06:18, Ian Romanick wrote: So... this game that requires at least OpenGL 3.2 (by virtue of using core profile) is checking for an OpenGL 1.4 feature?  That makes me a little sad. Its a little odd

Re: [Mesa-dev] [PATCH v4 5/8] mesa/main: don't use win _vsnprintf. there is 'util_vsnprintf' function

2018-09-06 Thread Ian Romanick
It seems like it might better to just replace all the calllers of _mesa_*printf with util_*printf. On 09/06/2018 07:43 AM, asimiklit.w...@gmail.com wrote: > From: Andrii Simiklit > > The win '_vsnprintf' function incompatibility with C99 vsnprintf. > At least for case when the input buffer size

Re: [Mesa-dev] [PATCH v4 7/7] egl/main: use cross platform implementation 'util_vsnprintf'

2018-09-06 Thread Ian Romanick
On 09/06/2018 07:43 AM, asimiklit.w...@gmail.com wrote: > From: Andrii Simiklit > > I guess it makes this implementation more portable. > > Signed-off-by: Andrii Simiklit > --- > src/amd/vulkan/radv_util.c | 5 +++-- > src/egl/main/egllog.c | 3 ++- > 2 files changed, 5 insertions(+), 3

Re: [Mesa-dev] [PATCH 00/15] RadeonSI Fixes and Cleanups

2018-09-06 Thread Marek Olšák
Does anybody want to review this? Thanks, Marek On Wed, Aug 29, 2018 at 4:12 PM, Marek Olšák wrote: > Hi, > > There are HTILE and CMASK allocator fixes, a GPU hang fix for bindless > textures with LLVM 7.0, partial NIR support for bindless textures, > ddebug fix, and much more. > > Please

Re: [Mesa-dev] [PATCH] mesa: enable ARB_vertex_buffer_object in core profile

2018-09-06 Thread Ian Romanick
On 09/06/2018 03:24 PM, Timothy Arceri wrote: > On 07/09/18 06:18, Ian Romanick wrote: >> So... this game that requires at least OpenGL 3.2 (by virtue of using >> core profile) is checking for an OpenGL 1.4 feature?  That makes me a >> little sad. > > Its a little odd it creates both a compat

[Mesa-dev] [PATCH 1/4] gallium: add pipe_context::set_context_param for tuning perf on AMD Zen (v2)

2018-09-06 Thread Marek Olšák
From: Marek Olšák State trackers will not use the new param directly, but will instead use a helper in MakeCurrent that does the right thing. v2: rework the interface --- .../auxiliary/driver_ddebug/dd_context.c | 11 ++ src/gallium/auxiliary/driver_noop/noop_pipe.c | 7 +++

[Mesa-dev] [PATCH 3/4] gallium/u_threaded: implement set_context_param for thread pinning (v2)

2018-09-06 Thread Marek Olšák
From: Marek Olšák v2: - use set_context_param - set set_context_param even if the driver doesn't implement it --- .../auxiliary/util/u_threaded_context.c | 40 +++ .../auxiliary/util/u_threaded_context_calls.h | 1 + 2 files changed, 41 insertions(+) diff --git

[Mesa-dev] [PATCH 4/4] radeonsi: pin the winsys thread to the requested L3 cache (v2)

2018-09-06 Thread Marek Olšák
From: Marek Olšák v2: rebase --- src/gallium/drivers/radeon/radeon_winsys.h| 8 src/gallium/drivers/radeonsi/si_pipe.c| 15 +++ src/gallium/winsys/amdgpu/drm/amdgpu_winsys.c | 10 ++ src/gallium/winsys/radeon/drm/radeon_drm_winsys.c | 13

[Mesa-dev] [PATCH 0/4] Patches 5-8 rework: Gallium/RadeonSI for Ryzen CPUs

2018-09-06 Thread Marek Olšák
This changes the interface to pipe_context::set_context_param. Please review. Thanks, Marek ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 2/4] st/mesa: pin driver threads to a specific L3 cache on AMD Zen (v2)

2018-09-06 Thread Marek Olšák
From: Marek Olšák v2: use set_context_param --- src/gallium/auxiliary/util/u_helpers.c | 42 +++ src/gallium/auxiliary/util/u_helpers.h | 4 ++ src/mesa/state_tracker/st_context.c| 3 ++ src/mesa/state_tracker/st_manager.c| 9 src/util/u_thread.h

Re: [Mesa-dev] [PATCH 0/8] Gallium & RadeonSI optimization for Ryzen CPUs

2018-09-06 Thread Marek Olšák
On Thu, Sep 6, 2018 at 5:54 PM, Roland Scheidegger wrote: > Am 06.09.2018 um 22:56 schrieb Axel Davy: >> Yeah by pinning to cores, I meant to group of cores. >> >> I think a reasonable policy would be for the kernel to put all threads >> of a given process on the same L3 >> as long as the number

Re: [Mesa-dev] [PATCH] mesa: enable ARB_vertex_buffer_object in core profile

2018-09-06 Thread Ian Romanick
On 09/06/2018 06:08 PM, Timothy Arceri wrote: > On 07/09/18 11:00, Ian Romanick wrote: >> On 09/06/2018 03:24 PM, Timothy Arceri wrote: >>> On 07/09/18 06:18, Ian Romanick wrote: So... this game that requires at least OpenGL 3.2 (by virtue of using core profile) is checking for an OpenGL

[Mesa-dev] [PATCH] nv50,nvc0: warn on not-explicitly-handled caps

2018-09-06 Thread Ilia Mirkin
Not handling caps explicitly means that we're likely getting incorrect values -- these need to be reviewed and set appropriately. While we're at it, add in some missing caps, and set all the subpixel stuff to 8 as that seems to be what the blob reports. Signed-off-by: Ilia Mirkin ---

Re: [Mesa-dev] [PATCH 0/8] Gallium & RadeonSI optimization for Ryzen CPUs

2018-09-06 Thread Axel Davy
Hi Marek, Shouldn't this core pinning be handled by the kernel ? Else all multithreaded games (or applications) need an update. I also see a risk in applications handling the core pinning: several intensive applications may pin the same cores. The kernel would be able to switch automatically

[Mesa-dev] GLU problem with gluNurbsSurface

2018-09-06 Thread j. Scheurich
Hi, I know the GLU library in mesa 3D is just a copy of SGIs GLU library, but i found noone else to ask. 8-( The problem is in gluNurbsSurface. When used with a larger number of control points, some tesselation results are useless e.g. "inf" or fall outside of the contol point bounding box.

Re: [Mesa-dev] [PATCH v2] i965: clearify map_gtt cases

2018-09-06 Thread Lionel Landwerlin
On 05/09/2018 18:01, Kenneth Graunke wrote: On Tuesday, September 4, 2018 3:30:42 AM PDT Lionel Landwerlin wrote: Both brw_bo_map_cpu() & brw_bo_map_wc() assert if mapping the underlying BO fails. Failing back to brw_bo_map_gtt() doesn't seem to make any sense for that reason. We also only

[Mesa-dev] [PATCH 8/8] intel/aub_viewer: Print blend states properly

2018-09-06 Thread Lionel Landwerlin
Identical fix to : commit 70de31d0c106f58d6b7e6d5b79b8d90c1c112a3b Author: Jason Ekstrand Date: Fri Aug 24 16:05:08 2018 -0500 intel/batch_decoder: Print blend states properly Signed-off-by: Lionel Landwerlin --- src/intel/tools/aubinator_viewer_decoder.cpp | 18 -- 1

[Mesa-dev] [PATCH 2/8] intel/decoders: add address space indicator to get BOs

2018-09-06 Thread Lionel Landwerlin
Some commands like MI_BATCH_BUFFER_START have this indicator. Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_batch_decoder.c | 34 ++ src/intel/common/gen_decoder.h| 3 +- src/intel/tools/aubinator.c | 23

Re: [Mesa-dev] GLU problem with gluNurbsSurface

2018-09-06 Thread j. scheurich
To compile for the testcase use $ bzip2 -cd wdune-0.99rc1035.tar.bz | tar -xf - $ cd wdune-0.99rc1035 $ buildscripts/build-without-cgal-debug-j4.sh It should be $ sh buildscripts/build-without-cgal-debug-j4.sh sorry so long MUFTI ___ mesa-dev

[Mesa-dev] [PATCH 6/8] intel/aubinator: fix ring buffer pointer

2018-09-06 Thread Lionel Landwerlin
We can only start parsing commands from the head pointer. This was working fine up to now because we only dealt with a "made up" ring buffer (generated by aub_write) which always had its head at 0. Signed-off-by: Lionel Landwerlin --- src/intel/tools/aubinator.c | 4 ++--

[Mesa-dev] [PATCH 0/8] intel/tools: decoding fixes

2018-09-06 Thread Lionel Landwerlin
Hi all, Here are a number of fixes and slight rework dealing with the ring buffer decoding. Found while trying to generate aub files that remap all the buffers from the i915 error state. A more complete state of this ongoing work is available there (unfortunately not quite there for Gen9) :

[Mesa-dev] [PATCH 4/8] intel/decoders: read ring buffer length

2018-09-06 Thread Lionel Landwerlin
Use this value to limit reading the ring buffer. Signed-off-by: Lionel Landwerlin --- src/intel/tools/aubinator.c | 4 +++- src/intel/tools/aubinator_viewer.cpp | 3 ++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/intel/tools/aubinator.c

[Mesa-dev] [PATCH 3/8] intel/decoders: handle decoding MI_BBS from ring

2018-09-06 Thread Lionel Landwerlin
An MI_BATCH_BUFFER_START in the ring buffer acts as a second level batchbuffer (aka jump back to ring buffer when running into a MI_BATCH_BUFFER_END). Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_batch_decoder.c | 6 +++--- src/intel/common/gen_decoder.h| 2

[Mesa-dev] [PATCH 1/8] intel/decoders: fix end of batch limit

2018-09-06 Thread Lionel Landwerlin
Pointer arithmetic... Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_batch_decoder.c | 2 +- src/intel/tools/aubinator_viewer_decoder.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/intel/common/gen_batch_decoder.c

[Mesa-dev] [PATCH 5/8] intel/decoders: limit number of decoded batchbuffers

2018-09-06 Thread Lionel Landwerlin
IGT has this test hang test that works by having a batch buffer call itself. As our implementation of the decoding is perfectly mimicking the hardware, our decoder also "hangs". This change limits the number of batch buffer we'll decode before we bail to 100. Signed-off-by: Lionel Landwerlin ---

[Mesa-dev] [PATCH 7/8] intel/aub_viewer: fix dynamic state printing

2018-09-06 Thread Lionel Landwerlin
Identical fix to : commit cbd4bc1346f7397242e157bb66099b950a8c5643 Author: Jason Ekstrand Date: Fri Aug 24 16:04:03 2018 -0500 intel/batch_decoder: Fix dynamic state printing Signed-off-by: Lionel Landwerlin --- src/intel/tools/aubinator_viewer_decoder.cpp | 4 ++-- 1 file changed, 2

Re: [Mesa-dev] [PATCH v1 2/2] driconf: replaced file with defines

2018-09-06 Thread Eric Engestrom
On Thursday, 2018-09-06 12:59:48 +0300, Sergii Romantsov wrote: > Building of 32bit mesa with meson causes issues: > "expected ‘}’ before ‘DRI_CONF_MESA_NO_ERROR’" > "expected ‘}’ before ‘DRI_CONF_ALLOW_GLSL_CROSS_STAGE_INTERPOLATION_MISMATCH’" > "expected ‘}’ before

Re: [Mesa-dev] [PATCH v1 2/2] driconf: replaced file with defines

2018-09-06 Thread Sergii Romantsov
Looks like you are right. After 'git clean' its ok. Thanks. On Thu, Sep 6, 2018 at 2:37 PM Eric Engestrom wrote: > On Thursday, 2018-09-06 12:59:48 +0300, Sergii Romantsov wrote: > > Building of 32bit mesa with meson causes issues: > > "expected ‘}’ before ‘DRI_CONF_MESA_NO_ERROR’" > >

Re: [Mesa-dev] [Mesa-stable] [PATCH v4] i965: compiler option msse2 and mstackrealign

2018-09-06 Thread Sergii Romantsov
Hello, can you replace i965 with intel in the title of the commit done I assume you have commit access? Unfortunately, i don't. Thanks everybody for pointing details. On Wed, Sep 5, 2018 at 8:41 PM, Dylan Baker wrote: > Quoting Sergii Romantsov (2018-09-05 04:40:37) > > Seems in case of

Re: [Mesa-dev] [PATCH v2 2/4] intel/decoder: Avoid freeing invalid pointer

2018-09-06 Thread Lionel Landwerlin
On 06/09/2018 05:12, Sagar Ghuge wrote: v2: Free ctx.spec if error while reading genxml (Lionel Landwerlin) Signed-off-by: Sagar Ghuge --- src/intel/common/gen_decoder.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/src/intel/common/gen_decoder.c

[Mesa-dev] [PATCH 2/4] virgl: drop needless return-code

2018-09-06 Thread Erik Faye-Lund
We always return TRUE, and we never check the return-value. Let's just drop the return value instead. Signed-off-by: Erik Faye-Lund --- src/gallium/drivers/virgl/virgl_texture.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/gallium/drivers/virgl/virgl_texture.c

[Mesa-dev] [PATCH v1 1/2] i965/tools: 32bit compilation with meson

2018-09-06 Thread Sergii Romantsov
Building of 32bit mesa with meson causes issue: "implicit declaration of function ‘__builtin_ia32_clflush’". Fixed by adding msse2 compilation flag. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107843 Fixes: 314879f7fec0 (i965: Fix asynchronous mappings on !LLC platforms.)

[Mesa-dev] [PATCH v1 2/2] driconf: replaced file with defines

2018-09-06 Thread Sergii Romantsov
Building of 32bit mesa with meson causes issues: "expected ‘}’ before ‘DRI_CONF_MESA_NO_ERROR’" "expected ‘}’ before ‘DRI_CONF_ALLOW_GLSL_CROSS_STAGE_INTERPOLATION_MISMATCH’" "expected ‘}’ before ‘DRI_CONF_ALLOW_RGB10_CONFIGS’" File with defines replaced to correct. Bugzilla:

Re: [Mesa-dev] [PATCH v5] intel: compiler option msse2 and mstackrealign

2018-09-06 Thread Lionel Landwerlin
Giving it a run through CI and I'll push after. Thanks! On 06/09/2018 09:07, Sergii Romantsov wrote: Seems in case of 32-bit library, usage of msse2 makes some stack corruption or incorrect instructions. Usage with mstackrealign fixes that case. v2: Fixed meson. v3: Definition of c_sse2_args

[Mesa-dev] [PATCH 0/4] virgil: fix crash when mapping ms-texture

2018-09-06 Thread Erik Faye-Lund
Here's a series of patches to address a crash when mapping multisampled textures in piglit. The crash can easily be reproduce using the following command: bin/copyteximage 2D -samples=2 -auto However, it's not clear to me if this is the right fix or not; the resource creation code and the

[Mesa-dev] [PATCH 3/4] virgl: remove dead code

2018-09-06 Thread Erik Faye-Lund
We don't use the size we calculate in this function, so let's just drop the calculation Signed-off-by: Erik Faye-Lund --- src/gallium/drivers/virgl/virgl_texture.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/gallium/drivers/virgl/virgl_texture.c

[Mesa-dev] [PATCH 4/4] virgl: do not map zero-sized resource

2018-09-06 Thread Erik Faye-Lund
When creating textures, we avoid creating backing-store for all multisampled textures, not just depth buffers. So we can't try to map them later. That's just going to fail. So let's take the blit-based code-path that seems to avoid this problem. This make this piglit test-case no longer crash

[Mesa-dev] [PATCH 1/4] virgl: free trans on map-error

2018-09-06 Thread Erik Faye-Lund
When we fail to map memory, we should also free trans to avoid leaking memory. Noticed while reading code. Signed-off-by: Erik Faye-Lund --- src/gallium/drivers/virgl/virgl_texture.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/virgl/virgl_texture.c

Re: [Mesa-dev] [PATCH v1 1/2] i965/tools: 32bit compilation with meson

2018-09-06 Thread Lionel Landwerlin
Aren't other tools affected as well? Thanks, - Lionel On 06/09/2018 10:59, Sergii Romantsov wrote: Building of 32bit mesa with meson causes issue: "implicit declaration of function ‘__builtin_ia32_clflush’". Fixed by adding msse2 compilation flag. Bugzilla:

Re: [Mesa-dev] [PATCH 1/8] intel/decoders: fix end of batch limit

2018-09-06 Thread Eric Engestrom
On Thursday, 2018-09-06 12:39:34 +0100, Eric Engestrom wrote: > On Thursday, 2018-09-06 11:34:44 +0100, Lionel Landwerlin wrote: > > Pointer arithmetic... > > > > Signed-off-by: Lionel Landwerlin > > --- > > src/intel/common/gen_batch_decoder.c | 2 +- > >

Re: [Mesa-dev] [PATCH] mesa/util: add missing va_end() after va_copy()

2018-09-06 Thread asimiklit.w...@gmail.com
Hello, Thanks for your reply. The 'util_vsnprintf' function under Linux is just an alias for 'vsnprintf': #define util_vsnprintf vsnprintf So as far as I understood we should ensure compatibility between 'vsnprintf' function under Linux and '_vsnprintf' function under Windows using our

Re: [Mesa-dev] [PATCH v1 1/2] i965/tools: 32bit compilation with meson

2018-09-06 Thread Lionel Landwerlin
Oh right, I see, this is the only using gen_invalidate_range(). Thanks! Reviewed-by: Lionel Landwerlin On 06/09/2018 11:40, Sergii Romantsov wrote: With -Dtools=all compilation is passed now. At this moment looking additionally on linkage issue with building, have solution but would like to

Re: [Mesa-dev] [PATCH 5/6] mesa: remove duplicate declarations from glheader.h

2018-09-06 Thread Emil Velikov
On 6 September 2018 at 01:27, Timothy Arceri wrote: > On 06/09/18 02:35, Emil Velikov wrote: >> >> From: Emil Velikov >> >> Remove all the desktop GL and GLX entries from the list. >> Former are pulled by the gl.h and glext.h includes at the top while the >> latter are not longer needed. > > >

Re: [Mesa-dev] [PATCH 1/8] intel/decoders: fix end of batch limit

2018-09-06 Thread Eric Engestrom
On Thursday, 2018-09-06 11:34:44 +0100, Lionel Landwerlin wrote: > Pointer arithmetic... > > Signed-off-by: Lionel Landwerlin > --- > src/intel/common/gen_batch_decoder.c | 2 +- > src/intel/tools/aubinator_viewer_decoder.cpp | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) >

Re: [Mesa-dev] [PATCH 3/4] gallium/u_inlines: improve pipe_reference_described perf for debug builds

2018-09-06 Thread Michel Dänzer
On 2018-09-05 11:49 p.m., Marek Olšák wrote: > On Tue, Sep 4, 2018 at 2:35 PM, Marek Olšák wrote: >> On Mon, Sep 3, 2018 at 6:08 AM, Michel Dänzer wrote: >>> On 2018-09-01 8:54 a.m., Marek Olšák wrote: From: Marek Olšák +41% performance in debug builds (testing

Re: [Mesa-dev] [PATCH v1 1/2] i965/tools: 32bit compilation with meson

2018-09-06 Thread Sergii Romantsov
With -Dtools=all compilation is passed now. At this moment looking additionally on linkage issue with building, have solution but would like to find better, so hope will provide additional 3rd commit today. On Thu, Sep 6, 2018 at 1:03 PM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote:

[Mesa-dev] [PATCH] winsys/virgl: avoid unintended behavior

2018-09-06 Thread Erik Faye-Lund
If we end up never taking the loop that writes ret, we can end up with an uninitialized value, and if we're *really* unlucky, that value can be -1, causing us to go down an error-path instead of a success path. This was obviously not intended, so let's just initialize this to zero. Noticed by

Re: [Mesa-dev] [PATCH] mesa/util: add missing va_end() after va_copy()

2018-09-06 Thread Emil Velikov
Hi Andrii, I think you might be overthinking my comments. There's nothing special, nor am I trying to force my opinion. If you think my suggestions make sense, great. Otherwise don't bother too much. HTH Emil ___ mesa-dev mailing list

[Mesa-dev] Request to Work on Project Piglit for VA-API under XorgEvoC

2018-09-06 Thread Naveen Naidu
Hello Everyone, I am Naveen a Junior year computer science undergrad from India. I really apologize for disturbing you all again. But I have been going through the available projects for the XorgEVoC program and the project *Piglit for VA-API *caught my attention. This project really intrigues

Re: [Mesa-dev] [Mesa-announce] [ANNOUNCE] mesa 18.2.0-rc5

2018-09-06 Thread Andres Gomez
On Tue, 2018-09-04 at 17:10 -0400, Marek Olšák wrote: > Hi Andres, > > When do you plan to release final Mesa 18.2? > > Thanks, > Marek > > On Wed, Aug 29, 2018 at 8:28 PM, Andres Gomez wrote: [...] > > The plan is to have the sixth release candidate for 18.2.0 next > > Wednesday

[Mesa-dev] [PATCH v2] gallium: Correctly handle no config context creation

2018-09-06 Thread Elie Tournier
This patch fixes the following Piglit test: spec@egl_mesa_configless_context@basic It also fixes few test in a virgl guest. v2: Evaluate the value of no_config (Ilia) Suggested-by: Emil Velikov Signed-off-by: Elie Tournier --- src/gallium/include/state_tracker/st_api.h | 2 ++

Re: [Mesa-dev] [PATCH v1 1/2] i965/tools: 32bit compilation with meson

2018-09-06 Thread Lionel Landwerlin
And pushed. On 06/09/2018 11:53, Lionel Landwerlin wrote: Oh right, I see, this is the only using gen_invalidate_range(). Thanks! Reviewed-by: Lionel Landwerlin On 06/09/2018 11:40, Sergii Romantsov wrote: With -Dtools=all compilation is passed now. At this moment looking additionally on

Re: [Mesa-dev] [PATCH 0/9] dri2: Swapbuffer update v3.

2018-09-06 Thread Timothy Arceri
On 06/09/18 04:57, Thomas Hellstrom wrote: On 09/05/2018 04:30 PM, Timothy Arceri wrote: On 05/09/18 23:36, Thomas Hellstrom wrote: On 09/05/2018 02:36 PM, Timothy Arceri wrote: On 05/09/18 22:09, Thomas Hellstrom wrote: On 09/05/2018 01:45 PM, Timothy Arceri wrote: On 16/08/17 04:31,

Re: [Mesa-dev] [PATCH 1/8] intel/decoders: fix end of batch limit

2018-09-06 Thread Lionel Landwerlin
On 06/09/2018 12:39, Eric Engestrom wrote: On Thursday, 2018-09-06 11:34:44 +0100, Lionel Landwerlin wrote: Pointer arithmetic... Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_batch_decoder.c | 2 +- src/intel/tools/aubinator_viewer_decoder.cpp | 2 +- 2 files changed,

Re: [Mesa-dev] GLU problem with gluNurbsSurface

2018-09-06 Thread j. Scheurich
Ok, i found a bug in my code. I updated ftp://ftp.ourproject.org/pub/wdune/wdune-0.99rc1035.tar.bz2 But the result is nearly the same 8-( https://wdune.ourproject.org/examples/nurbs_problem.jpg so long MUFTI ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH] virgl: Add command and flags to initiate debugging on the host

2018-09-06 Thread Emil Velikov
On 5 September 2018 at 16:34, Gert Wollny wrote: > + > +enum virgl_debug_flags { > + debug_shader_tgsi = 1 << 0, > + debug_shader_glsl = 1 << 1, > + debug_shader_streamout = 1 << 2, > + debug_shader = debug_shader_tgsi | debug_shader_glsl | > debug_shader_streamout, > + debug_cmd = 1

[Mesa-dev] [PATCH mesa] meson: drop unnecessary llvm version hacks

2018-09-06 Thread Eric Engestrom
The current minimum meson version supported is 0.44.1, so we have met both the 0.43 and 0.44 requirement to not need these hacks anymore :) Signed-off-by: Eric Engestrom --- meson.build | 9 - 1 file changed, 9 deletions(-) diff --git a/meson.build b/meson.build index

Re: [Mesa-dev] [PATCH 0/9] dri2: Swapbuffer update v3.

2018-09-06 Thread Michel Dänzer
On 2018-09-06 1:20 p.m., Timothy Arceri wrote: > On 06/09/18 04:57, Thomas Hellstrom wrote: >> On 09/05/2018 04:30 PM, Timothy Arceri wrote: >>> On 05/09/18 23:36, Thomas Hellstrom wrote: On 09/05/2018 02:36 PM, Timothy Arceri wrote: > On 05/09/18 22:09, Thomas Hellstrom wrote: >>

Re: [Mesa-dev] [PATCH] mesa: add missing return statement for GL_RG_SNORM case

2018-09-06 Thread Eric Engestrom
On Thursday, 2018-09-06 17:01:07 +0300, Danylo Piliaiev wrote: > Signed-off-by: Danylo Piliaiev Fixes: 0d356cf4781bece0dc9a7 "mesa: enable EXT_render_snorm extension" Reviewed-by: Eric Engestrom > --- > src/mesa/main/fbobject.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

[Mesa-dev] [PATCH 2/2] etnaviv: Reduce max offset to available hardware bits.

2018-09-06 Thread Mathias . Froehlich
From: Mathias Fröhlich Signed-off-by: Mathias Fröhlich --- src/gallium/drivers/etnaviv/etnaviv_screen.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/etnaviv/etnaviv_screen.c b/src/gallium/drivers/etnaviv/etnaviv_screen.c index 9ddba62855..0081f9a173 100644 ---

[Mesa-dev] [PATCH 1/2] gallium: New cap PIPE_CAP_MAX_VERTEX_ELEMENT_SRC_OFFSET.

2018-09-06 Thread Mathias . Froehlich
From: Mathias Fröhlich Introduce a new capability for the maximum value of pipe_vertex_element::src_offset. Initially just every driver backend returns the value previously set from _mesa_init_constants. So this shall end up in no functional change. Signed-off-by: Mathias Fröhlich ---

Re: [Mesa-dev] [PATCH 1/2] gallium: New cap PIPE_CAP_MAX_VERTEX_ELEMENT_SRC_OFFSET.

2018-09-06 Thread Brian Paul
The series looks good to me. Reviewed-by: Brian Paul On 09/06/2018 08:31 AM, mathias.froehl...@gmx.net wrote: From: Mathias Fröhlich Introduce a new capability for the maximum value of pipe_vertex_element::src_offset. Initially just every driver backend returns the value previously set from

Re: [Mesa-dev] [PATCH] virgl: Add command and flags to initiate debugging on the host

2018-09-06 Thread Gert Wollny
Am Donnerstag, den 06.09.2018, 15:37 +0200 schrieb Erik Faye-Lund: > > > Jfyi: These are effectively part of the ABI/protocol. A host/guest > > definitions mismatch will result in the wrong debug being printed. > > Ohh "the horror" I know, hence the jfyi ;-) > > Good point. I think they should

[Mesa-dev] [PATCH v4 4/8] mesa/util: add missing va_end() after va_copy()

2018-09-06 Thread asimiklit . work
From: Andrii Simiklit MSDN: "va_end must be called on each argument list that's initialized with va_start or va_copy before the function returns." Reviewed-by: Eric Engestrom Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107810 Fixes: c6267ebd6c8a "gallium/util: Stop bundling our

[Mesa-dev] [PATCH v4 2/8] mesa/util: don't use the same 'va_list' instance twice

2018-09-06 Thread asimiklit . work
From: Andrii Simiklit The first usage of the 'va_list' instance could change it. Reviewed-by: Eric Engestrom Fixes: 864148d69e1e "util: add util_vasprintf() for Windows (v2)" Signed-off-by: Andrii Simiklit --- src/util/u_string.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[Mesa-dev] [PATCH v4 3/8] mesa/util: don't ignore NULL returned from 'malloc'

2018-09-06 Thread asimiklit . work
From: Andrii Simiklit We should exit from the function 'util_vasprintf' with error code -1 for case where 'malloc' returns NULL Reviewed-by: Eric Engestrom Fixes: 864148d69e1e "util: add util_vasprintf() for Windows (v2)" Signed-off-by: Andrii Simiklit --- src/util/u_string.h | 2 +- 1 file

[Mesa-dev] [PATCH v4 0/8] mesa: fix usage of [v][s][n]printf functions

2018-09-06 Thread asimiklit . work
From: Andrii Simiklit This patch improve usage of [v][s][n]printf functions. Fixes cross platform implementation of vsnprintf v2: Linux man about vXXXprintf functions: "These functions do not call the va_end macro. Because they invoke the va_arg macro, the value of ap is undefined

[Mesa-dev] [PATCH v4 1/8] apple/glx/log: added missing va_end() after va_copy()

2018-09-06 Thread asimiklit . work
From: Andrii Simiklit Each invocation of va_copy() must be matched by a corresponding invocation of va_end() Fixes: 51691f0767f6 "darwin: Use ASL for logging" Signed-off-by: Andrii Simiklit --- src/glx/apple/apple_glx_log.c | 1 + 1 file changed, 1 insertion(+) diff --git

[Mesa-dev] [PATCH v4 7/7] egl/main: use cross platform implementation 'util_vsnprintf'

2018-09-06 Thread asimiklit . work
From: Andrii Simiklit I guess it makes this implementation more portable. Signed-off-by: Andrii Simiklit --- src/amd/vulkan/radv_util.c | 5 +++-- src/egl/main/egllog.c | 3 ++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/amd/vulkan/radv_util.c

[Mesa-dev] [PATCH v4 7/8] radv: use cross platform implementation 'util_vsnprintf'

2018-09-06 Thread asimiklit . work
From: Andrii Simiklit I guess it makes this implementation more portable. Signed-off-by: Andrii Simiklit --- src/amd/vulkan/radv_util.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/amd/vulkan/radv_util.c b/src/amd/vulkan/radv_util.c index 72bedc6..90d3824

Re: [Mesa-dev] [PATCH] mesa: fold _glapi_check_multithread() back into _mesa_make_current

2018-09-06 Thread Brian Paul
Reviewed-by: Brian Paul On 09/05/2018 10:09 AM, Emil Velikov wrote: From: Emil Velikov With commit c6c0f947142, back in 2006 Brian removed the _glapi_check_multithread() call from core mesa - _mesa_make_current. It was done to remove fairly awkward #ifdef guard which caused subtle

[Mesa-dev] [PATCH v4 8/8] egl/main: use cross platform implementation 'util_vsnprintf'

2018-09-06 Thread asimiklit . work
From: Andrii Simiklit I guess it makes this implementation more portable. Signed-off-by: Andrii Simiklit --- src/egl/main/egllog.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/egl/main/egllog.c b/src/egl/main/egllog.c index c223f49..d21b070 100644 ---

[Mesa-dev] [PATCH v4 5/8] mesa/main: don't use win _vsnprintf. there is 'util_vsnprintf' function

2018-09-06 Thread asimiklit . work
From: Andrii Simiklit The win '_vsnprintf' function incompatibility with C99 vsnprintf. At least for case when the input buffer size less than the required size: '_vsnprintf' returns -1 for this case. 'vsnprintf' returns the required size. So use cross platform implementation 'util_vsnprintf'.

[Mesa-dev] [PATCH v4 6/8] mesa/util: use cross platform implementation 'util_vsnprintf'

2018-09-06 Thread asimiklit . work
From: Andrii Simiklit The win '_vsnprintf' function incompatibility with C99 vsnprintf. At least for case when the input buffer size less than the required size: '_vsnprintf' returns -1 for this case. 'vsnprintf' returns the required size. So use cross platform implementation 'util_vsnprintf'.

Re: [Mesa-dev] [PATCH] tnl: Fix green gun regression in xonotic.

2018-09-06 Thread Mathias Fröhlich
Hi, On Monday, 3 September 2018 03:11:37 CEST Ian Romanick wrote: > I don't know this code very well, but this seems to better match the > original (before 64d2a204805). Since it works for Ville and passes the > Intel CI, > > Reviewed-by: Ian Romanick Thanks for looking into that! I have

[Mesa-dev] [PATCH v2] docs: add the beginning of the 18.3 cycle

2018-09-06 Thread Andres Gomez
v2: Move 18.3.0-rcZ releases to Tuesdays. Cc: Dylan Baker Cc: Juan A. Suarez Cc: Emil Velikov Signed-off-by: Andres Gomez Acked-by: Dylan Baker --- Releases should happen on Wednesdays and X.Y.0-rcZ announcements just 24h before a release. Therefore, moving 18.3.0-rcZ to Tuesdays. diff

Re: [Mesa-dev] [PATCH] mesa: add missing return statement for GL_RG_SNORM case

2018-09-06 Thread Tapani Pälli
argh ... Reviewed-by: Tapani Pälli On 06.09.2018 17:01, Danylo Piliaiev wrote: Signed-off-by: Danylo Piliaiev --- src/mesa/main/fbobject.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index 51e137dce9..edb86438e3

Re: [Mesa-dev] [PATCH v2] i965: clearify map_gtt cases

2018-09-06 Thread Kenneth Graunke
On Thursday, September 6, 2018 3:30:58 AM PDT Lionel Landwerlin wrote: > On 05/09/2018 18:01, Kenneth Graunke wrote: > > On Tuesday, September 4, 2018 3:30:42 AM PDT Lionel Landwerlin wrote: > >> Both brw_bo_map_cpu() & brw_bo_map_wc() assert if mapping the > >> underlying BO fails. Failing back

[Mesa-dev] [PATCH 0/2] Introduce and use cap for MaxVertexAttribRelativeOffset.

2018-09-06 Thread Mathias . Froehlich
From: Mathias Fröhlich Hi all, The following two patches introduce a gallium capability to feed gl_constants::MaxVertexAttribRelativeOffset. Then adapt etnyviv to return what it can really handle. That prevents _mesa_update_vao_derived_arrays from collapsing too many attribute arrays into a

[Mesa-dev] [PATCH v1] mesa/meson: 32bit xmlconfig linkage

2018-09-06 Thread Sergii Romantsov
Building of 32bit mesa with meson causes linkage issue: "undefined reference to `util_get_process_name'" Fixed by adding link-with mesa_util for xmlconfig primary. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107843 Signed-off-by: Sergii Romantsov --- src/gbm/meson.build | 2 +-

Re: [Mesa-dev] [PATCH mesa] meson: disable asserts by default on release builds

2018-09-06 Thread Emil Velikov
On 6 September 2018 at 16:18, Eric Engestrom wrote: > On Wednesday, 2018-08-29 15:19:34 +0100, Emil Velikov wrote: >> On 29 August 2018 at 15:01, Eric Engestrom wrote: >> > Ping? >> > >> > I think we should land this now, ie. for 18.3. >> > >> > By the time Mesa 18.3 comes out (probably December

Re: [Mesa-dev] [PATCH] winsys/virgl: avoid unintended behavior

2018-09-06 Thread Erik Faye-Lund
On to., sep. 6, 2018 at 3:00 PM, Emil Velikov wrote: Hi Erik, On 6 September 2018 at 11:48, Erik Faye-Lund wrote: If we end up never taking the loop that writes ret, we can end up with an uninitialized value, and if we're *really* unlucky, that value can be -1, causing us to go down

Re: [Mesa-dev] [PATCH] virgl: Add command and flags to initiate debugging on the host

2018-09-06 Thread Erik Faye-Lund
On to., sep. 6, 2018 at 3:25 PM, Emil Velikov wrote: On 5 September 2018 at 16:34, Gert Wollny wrote: + +enum virgl_debug_flags { + debug_shader_tgsi = 1 << 0, + debug_shader_glsl = 1 << 1, + debug_shader_streamout = 1 << 2, + debug_shader = debug_shader_tgsi |

[Mesa-dev] [PATCH] mesa: add missing return statement for GL_RG_SNORM case

2018-09-06 Thread Danylo Piliaiev
Signed-off-by: Danylo Piliaiev --- src/mesa/main/fbobject.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index 51e137dce9..edb86438e3 100644 --- a/src/mesa/main/fbobject.c +++ b/src/mesa/main/fbobject.c @@ -2080,7 +2080,7

[Mesa-dev] [PATCH] vl/dri3: add support for 10 bits format

2018-09-06 Thread Leo Liu
Signed-off-by: Leo Liu --- src/gallium/auxiliary/vl/vl_winsys_dri3.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/gallium/auxiliary/vl/vl_winsys_dri3.c b/src/gallium/auxiliary/vl/vl_winsys_dri3.c index 8e3c4a0e04d..0233f58441e 100644 ---

Re: [Mesa-dev] [PATCH mesa] meson: disable asserts by default on release builds

2018-09-06 Thread Eric Engestrom
On Wednesday, 2018-08-29 15:19:34 +0100, Emil Velikov wrote: > On 29 August 2018 at 15:01, Eric Engestrom wrote: > > Ping? > > > > I think we should land this now, ie. for 18.3. > > > > By the time Mesa 18.3 comes out (probably December '18), Meson 0.45 will > > be 9 months old (March '18), so I

Re: [Mesa-dev] [PATCH] winsys/virgl: avoid unintended behavior

2018-09-06 Thread Emil Velikov
Hi Erik, On 6 September 2018 at 11:48, Erik Faye-Lund wrote: > If we end up never taking the loop that writes ret, we can end up with > an uninitialized value, and if we're *really* unlucky, that value can > be -1, causing us to go down an error-path instead of a success path. > > This was

Re: [Mesa-dev] [PATCH] virgl: Add command and flags to initiate debugging on the host

2018-09-06 Thread Erik Faye-Lund
On on., sep. 5, 2018 at 5:34 PM, Gert Wollny wrote: From: Gert Wollny On the host VREND_DEBUG=guestallow must be set to let the guest override the debug flags. Signed-off-by: Gert Wollny --- The corresponding code for virglrenderer can be found in this MR:

Re: [Mesa-dev] Etnaviv on mesa master vs. Array._DrawVAO

2018-09-06 Thread Mathias Fröhlich
Hi, I have sent out a patch to introduce the capability in question as well as reducing it for etnaviv. Can you test this one if that really helps for your failure and may be review the patch? Thanks and best Mathias On Friday, 31 August 2018 12:40:01 CEST Guido Günther wrote: > Hi, > I'm

[Mesa-dev] [Bug 107757] [Regression] Xwayland/Present: Black window with "World of Warcraft" under Wine

2018-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107757 Eero Tamminen changed: What|Removed |Added CC||eero.t.tammi...@intel.com -- You are

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/3] android: broadcom/genxml: fix collision with intel/genxml header-gen macro

2018-09-06 Thread Dylan Baker
Quoting Rob Herring (2018-09-06 07:16:07) > On Mon, Sep 3, 2018 at 4:27 PM Eric Anholt wrote: > > > > Mauro Rossi writes: > > > > > Fixes the following building error, happening when building both intel > > > and broadcom: > > > > I wish someone maintaining android Mesa would work on making the

Re: [Mesa-dev] [PATCH v4 0/8] mesa: fix usage of [v][s][n]printf functions

2018-09-06 Thread Eric Engestrom
On Thursday, 2018-09-06 17:43:50 +0300, asimiklit.w...@gmail.com wrote: > From: Andrii Simiklit > > This patch improve usage of [v][s][n]printf functions. > Fixes cross platform implementation of vsnprintf > > v2: Linux man about vXXXprintf functions: > "These functions do not call the

  1   2   >