Re: [Mesa-dev] [PATCH v4 7/7] egl/main: use cross platform implementation 'util_vsnprintf'

2018-09-07 Thread andrey simiklit
On Fri, Sep 7, 2018 at 5:40 AM Ian Romanick wrote: > On 09/06/2018 07:43 AM, asimiklit.w...@gmail.com wrote: > > From: Andrii Simiklit > > > > I guess it makes this implementation more portable. > > > > Signed-off-by: Andrii Simiklit > > --- > > src/amd/vulkan/radv_util.c | 5 +++-- > >

Re: [Mesa-dev] [PATCH v4 5/8] mesa/main: don't use win _vsnprintf. there is 'util_vsnprintf' function

2018-09-07 Thread andrey simiklit
On Fri, Sep 7, 2018 at 5:38 AM Ian Romanick wrote: > It seems like it might better to just replace all the calllers of > _mesa_*printf with util_*printf. > Thanks. Yes you're right. I am going to rework it today. > On 09/06/2018 07:43 AM, asimiklit.w...@gmail.com wrote: > > From: Andrii

[Mesa-dev] imx/etnaviv: loader_open_render_node() fails

2018-09-07 Thread Lukas F. Hartmann
Hi, I've updated to and rebuilt the latest git versions of linux, drm, mesa and kmscube on an imx6qp system. I tried both with etnaviv as a module and compiled into the kernel (no difference). Mesa no longer picks up etnaviv for GL rendering, but always reverts to softpipe. A bit of debugging

Re: [Mesa-dev] [PATCH v2] i965: Workaround the gen9 hw astc5x5 sampler bug

2018-09-07 Thread Pohjolainen, Topi
On Thu, Sep 06, 2018 at 03:50:42PM -0500, Jason Ekstrand wrote: > From: Topi Pohjolainen > > gen9 hardware has a bug in the sampler cache that can cause GPU hangs > whenever an texture with aux compression enabled is in the sampler cache > together with an ASTC5x5 texture. Because we can't

[Mesa-dev] [PATCH 1/4] vl/dri3: add 10 bits format support for front buffer

2018-09-07 Thread Leo Liu
Signed-off-by: Leo Liu --- src/gallium/auxiliary/vl/vl_winsys_dri3.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/vl/vl_winsys_dri3.c b/src/gallium/auxiliary/vl/vl_winsys_dri3.c index 0233f58441..7ac6924c78 100644 ---

[Mesa-dev] [PATCH 3/4] st/vdpau: Use output buffer as DRI3 back buffer with 24 bits color only

2018-09-07 Thread Leo Liu
Using output buffer with 8 bits video RGB as back buffer certainly is not working for 30 bits color depth visual. Signed-off-by: Leo Liu --- src/gallium/state_trackers/vdpau/output.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/vdpau/output.c

[Mesa-dev] [PATCH 2/4] vl/dri: add color depth to vl_winsys

2018-09-07 Thread Leo Liu
It will be used for dri2 and dri3 Signed-off-by: Leo Liu --- src/gallium/auxiliary/vl/vl_winsys.h | 1 + src/gallium/auxiliary/vl/vl_winsys_dri3.c | 1 + 2 files changed, 2 insertions(+) diff --git a/src/gallium/auxiliary/vl/vl_winsys.h b/src/gallium/auxiliary/vl/vl_winsys.h index

Re: [Mesa-dev] [PATCH] meson: remove invalid "opencl" llvm component

2018-09-07 Thread Dylan Baker
Quoting Emil Velikov (2018-09-07 06:58:03) > From: Emil Velikov > > Seeming copy/paste mistake from configure.ac which uses $2 for the > component and $3 for the fancy name printing. > > Cc: Dylan Baker > Signed-off-by: Emil Velikov > --- > meson.build | 2 +- > 1 file changed, 1

Re: [Mesa-dev] [PATCH] i965: Fix calculation of layers array length for isl_view

2018-09-07 Thread Ilia Mirkin
On Fri, Sep 7, 2018 at 12:35 PM, Józef Kucia wrote: > On Fri, Sep 7, 2018 at 4:42 PM Danylo Piliaiev > wrote: > >> @@ -1546,8 +1548,8 @@ update_image_surface(struct brw_context *brw, >> .format = format, >> .base_level = obj->MinLevel + u->Level, >> .levels

Re: [Mesa-dev] [PATCH v3] mesa/meson: 32bit xmlconfig linkage

2018-09-07 Thread Dylan Baker
Quoting Sergii Romantsov (2018-09-07 02:43:41) > Building of 32bit mesa with meson causes linkage issue: > "undefined reference to `util_get_process_name'" > Fixed by adding link-with mesa_util for xmlconfig primary. > > v2: Removed '[]', commit message corrected. > > v3: Reverted changes in gbm

[Mesa-dev] [ANNOUNCE] mesa 18.1.8

2018-09-07 Thread Dylan Baker
Hi list, This mail announces the immediate availability of mesa 18.1.8. This release is a bugfix release, and thought it was previously planned to be the last 18.1 release, it is not, there will be at least 18.1.9. This has been a busier cycle than last time, apart from all of the book keeping

Re: [Mesa-dev] [PATCH] Require Visual Studio 2015.

2018-09-07 Thread Roland Scheidegger
Looks good to me. Reviewed-by: Roland Scheidegger Am 07.09.2018 um 17:59 schrieb Jose Fonseca: > We no longer need or use Visual Studio 2013. > > https://ci.appveyor.com/project/jrfonseca/mesa/build/52 > --- > docs/install.html | 2 +- > include/c11/threads_win32.h | 12

Re: [Mesa-dev] [PATCH v2] i965: Fix calculation of layers array length for isl_view

2018-09-07 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Fri, Sep 7, 2018 at 10:39 AM Danylo Piliaiev wrote: > Comment for array_len field states: > "Indicates the number of array elements starting at >Base Array Layer." > > And most usages of array_len expect it to be equal or less than > total layers - base

[Mesa-dev] [PATCH] Require Visual Studio 2015.

2018-09-07 Thread Jose Fonseca
We no longer need or use Visual Studio 2013. https://ci.appveyor.com/project/jrfonseca/mesa/build/52 --- docs/install.html | 2 +- include/c11/threads_win32.h | 12 +--- include/c99_compat.h| 4 ++-- src/util/macros.h | 4 +--- 4 files changed, 5

Re: [Mesa-dev] [PATCH] i965: Fix calculation of layers array length for isl_view

2018-09-07 Thread Józef Kucia
On Fri, Sep 7, 2018 at 6:44 PM Ilia Mirkin wrote: > > On Fri, Sep 7, 2018 at 12:35 PM, Józef Kucia wrote: > > On Fri, Sep 7, 2018 at 4:42 PM Danylo Piliaiev > > wrote: > > > >> @@ -1546,8 +1548,8 @@ update_image_surface(struct brw_context *brw, > >> .format = format, > >>

Re: [Mesa-dev] [PATCH] i965: Fix calculation of layers array length for isl_view

2018-09-07 Thread Ilia Mirkin
On Fri, Sep 7, 2018 at 11:09 AM, Danylo Piliaiev wrote: > > On 9/7/18 5:48 PM, Ilia Mirkin wrote: >> >> On Fri, Sep 7, 2018 at 10:41 AM, Danylo Piliaiev >> wrote: >>> >>> Comment for array_len field states: >>> "Indicates the number of array elements starting at >>> Base Array Layer." >>>

[Mesa-dev] [PATCH v2] i965: Fix calculation of layers array length for isl_view

2018-09-07 Thread Danylo Piliaiev
Comment for array_len field states: "Indicates the number of array elements starting at Base Array Layer." And most usages of array_len expect it to be equal or less than total layers - base layer v2: Do not subtract base layer if image unit is not layered (Ilia Mirkin) Fixes: 5a8c8903

[Mesa-dev] [Bug 106465] No test for Image Load/Store on format-incompatible texture buffer

2018-09-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106465 Andrés Gómez García changed: What|Removed |Added CC||ago...@igalia.com,

[Mesa-dev] [Bug 106465] No test for Image Load/Store on format-incompatible texture buffer

2018-09-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106465 --- Comment #4 from Andrés Gómez García --- (In reply to Andrés Gómez García from comment #3) > Curro, is this fixed by? [...] My bad, I just realized that the report is about a missing piglit test. In that case, shouldn't we move this

Re: [Mesa-dev] [PATCH 1/4] vl/dri3: add 10 bits format support for front buffer

2018-09-07 Thread Leo Liu
On 09/07/2018 11:09 AM, Michel Dänzer wrote: On 2018-09-07 4:13 p.m., Leo Liu wrote: On 09/07/2018 10:07 AM, Michel Dänzer wrote: On 2018-09-07 3:55 p.m., Leo Liu wrote: Signed-off-by: Leo Liu diff --git a/src/gallium/auxiliary/vl/vl_winsys_dri3.c

Re: [Mesa-dev] [PATCH] i965: Fix calculation of layers array length for isl_view

2018-09-07 Thread Lionel Landwerlin
On 07/09/2018 16:32, Ilia Mirkin wrote: On Fri, Sep 7, 2018 at 11:09 AM, Danylo Piliaiev wrote: On 9/7/18 5:48 PM, Ilia Mirkin wrote: On Fri, Sep 7, 2018 at 10:41 AM, Danylo Piliaiev wrote: Comment for array_len field states: "Indicates the number of array elements starting at Base

Re: [Mesa-dev] [PATCH v2] i965: Fix calculation of layers array length for isl_view

2018-09-07 Thread Ilia Mirkin
FWIW, this looks right. Reviewed-by: Ilia Mirkin On Fri, Sep 7, 2018 at 11:39 AM, Danylo Piliaiev wrote: > Comment for array_len field states: > "Indicates the number of array elements starting at >Base Array Layer." > > And most usages of array_len expect it to be equal or less than >

Re: [Mesa-dev] [PATCH] i965: Fix calculation of layers array length for isl_view

2018-09-07 Thread Józef Kucia
On Fri, Sep 7, 2018 at 4:42 PM Danylo Piliaiev wrote: > @@ -1546,8 +1548,8 @@ update_image_surface(struct brw_context *brw, > .format = format, > .base_level = obj->MinLevel + u->Level, > .levels = 1, > -.base_array_layer = obj->MinLayer +

[Mesa-dev] [PATCH] intel/genxml: remove SLM Enable bit from Gen11

2018-09-07 Thread Lionel Landwerlin
Documentation says this bit is gone and we've indeed set all the slm field to 0 in common/gen_l3_config.c Signed-off-by: Lionel Landwerlin --- src/intel/genxml/gen11.xml | 1 - src/intel/vulkan/genX_cmd_buffer.c | 6 -- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 1/4] vl/dri3: add 10 bits format support for front buffer

2018-09-07 Thread Leo Liu
On 09/07/2018 10:07 AM, Michel Dänzer wrote: On 2018-09-07 3:55 p.m., Leo Liu wrote: Signed-off-by: Leo Liu --- src/gallium/auxiliary/vl/vl_winsys_dri3.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/vl/vl_winsys_dri3.c

Re: [Mesa-dev] [PATCH 0/8] Gallium & RadeonSI optimization for Ryzen CPUs

2018-09-07 Thread Marek Olšák
On Fri, Sep 7, 2018, 4:34 AM Michel Dänzer wrote: > On 2018-09-06 10:56 p.m., Axel Davy wrote: > > Yeah by pinning to cores, I meant to group of cores. > > > > I think a reasonable policy would be for the kernel to put all threads > > of a given process on the same L3 > > as long as the number

Re: [Mesa-dev] [PATCH 0/8] Gallium & RadeonSI optimization for Ryzen CPUs

2018-09-07 Thread Michel Dänzer
On 2018-09-07 4:31 p.m., Marek Olšák wrote: > On Fri, Sep 7, 2018, 4:34 AM Michel Dänzer wrote: >> On 2018-09-06 10:56 p.m., Axel Davy wrote: >> >>> I fear if we begin to do the work manually, there won't be interest to >>> do that in the kernel, >>> and thus all applications will need to include

Re: [Mesa-dev] [PATCH] i965: Fix calculation of layers array length for isl_view

2018-09-07 Thread Danylo Piliaiev
On 9/7/18 5:48 PM, Ilia Mirkin wrote: On Fri, Sep 7, 2018 at 10:41 AM, Danylo Piliaiev wrote: Comment for array_len field states: "Indicates the number of array elements starting at Base Array Layer." And most usages of array_len expect it to be equal or less than total layers - base

Re: [Mesa-dev] [PATCH 1/4] vl/dri3: add 10 bits format support for front buffer

2018-09-07 Thread Michel Dänzer
On 2018-09-07 4:13 p.m., Leo Liu wrote: > On 09/07/2018 10:07 AM, Michel Dänzer wrote: >> On 2018-09-07 3:55 p.m., Leo Liu wrote: >>> Signed-off-by: Leo Liu >>> >>> diff --git a/src/gallium/auxiliary/vl/vl_winsys_dri3.c >>> b/src/gallium/auxiliary/vl/vl_winsys_dri3.c >>> index

Re: [Mesa-dev] [PATCH v5] intel: compiler option msse2 and mstackrealign

2018-09-07 Thread Lionel Landwerlin
It's good, pushed. On 07/09/2018 10:57, Lionel Landwerlin wrote: There was a test that failed, but I think it might be flakyness. I'm retrying one more time. Will get back to you in ~1h. - Lionel On 07/09/2018 10:32, Sergii Romantsov wrote: Hello, Lionel. Any regression with CI? On Thu, Sep

[Mesa-dev] [PATCH] i965: Bump aperture tracking to u64

2018-09-07 Thread Chris Wilson
As a prelude to handling large address spaces, first allow ourselves the luxury of handling the full 4G. Reported-by: Andrey Simiklit Cc: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_context.h | 2 +- src/mesa/drivers/dri/i965/intel_batchbuffer.c | 9 +

Re: [Mesa-dev] [PATCH] i965: compute the right number of array layers use base layer

2018-09-07 Thread Ilia Mirkin
On Fri, Sep 7, 2018 at 10:59 AM, Lionel Landwerlin wrote: > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107856 > Signed-off-by: Lionel Landwerlin > --- > src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git

[Mesa-dev] [PATCH v5 6/8] util: use cross platform implementation 'util_vsnprintf'

2018-09-07 Thread asimiklit . work
From: Andrii Simiklit The win '_vsnprintf' function incompatibility with C99 vsnprintf. At least for case when the input buffer size less than the required size: '_vsnprintf' returns -1 for this case. 'vsnprintf' returns the required size. So use cross platform implementation 'util_vsnprintf'.

[Mesa-dev] [PATCH v2] glsl/linker: Check the invariance of built-in special variables

2018-09-07 Thread Vadym Shovkoplias
From Section 4.6.4 (Invariance and Linkage) of the GLSL ES 1.0 specification "The invariance of varyings that are declared in both the vertex and fragment shaders must match. For the built-in special variables, gl_FragCoord can only be declared invariant if and only if

[Mesa-dev] [PATCH] meson: remove invalid "opencl" llvm component

2018-09-07 Thread Emil Velikov
From: Emil Velikov Seeming copy/paste mistake from configure.ac which uses $2 for the component and $3 for the fancy name printing. Cc: Dylan Baker Signed-off-by: Emil Velikov --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index

Re: [Mesa-dev] [PATCH 1/4] vl/dri3: add 10 bits format support for front buffer

2018-09-07 Thread Michel Dänzer
On 2018-09-07 3:55 p.m., Leo Liu wrote: > Signed-off-by: Leo Liu > --- > src/gallium/auxiliary/vl/vl_winsys_dri3.c | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/src/gallium/auxiliary/vl/vl_winsys_dri3.c > b/src/gallium/auxiliary/vl/vl_winsys_dri3.c > index

Re: [Mesa-dev] [PATCH] i965: Fix calculation of layers array length for isl_view

2018-09-07 Thread Ilia Mirkin
On Fri, Sep 7, 2018 at 10:41 AM, Danylo Piliaiev wrote: > Comment for array_len field states: > "Indicates the number of array elements starting at >Base Array Layer." > > And most usages of array_len expect it to be equal or less than > total layers - base layer > > Fixes: 5a8c8903 >

Re: [Mesa-dev] [PATCH 3/4] gallium/u_inlines: improve pipe_reference_described perf for debug builds

2018-09-07 Thread Michel Dänzer
On 2018-09-06 8:11 p.m., Marek Olšák wrote: > On Thu, Sep 6, 2018 at 6:25 AM, Michel Dänzer wrote: >> On 2018-09-05 11:49 p.m., Marek Olšák wrote: >>> On Tue, Sep 4, 2018 at 2:35 PM, Marek Olšák wrote: On Mon, Sep 3, 2018 at 6:08 AM, Michel Dänzer wrote: > On 2018-09-01 8:54 a.m.,

Re: [Mesa-dev] [PATCH 1/4] gallium/u_inlines: normalize naming, use dst & src, style fixes

2018-09-07 Thread Philipp Zabel
Hi Marek, there are two comments that will be confusing if they are not updated as well: On Sat, 2018-09-01 at 02:54 -0400, Marek Olšák wrote: > From: Marek Olšák > > --- > src/gallium/auxiliary/util/u_inlines.h | 86 +- > 1 file changed, 43 insertions(+), 43

[Mesa-dev] [PATCH 4/4] vl/dri: add 10 bits format support for DRI2

2018-09-07 Thread Leo Liu
Signed-off-by: Leo Liu --- src/gallium/auxiliary/vl/vl_winsys_dri.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/vl/vl_winsys_dri.c b/src/gallium/auxiliary/vl/vl_winsys_dri.c index bb1ff50488..f3ae788f72 100644 ---

[Mesa-dev] [PATCH] i965: Fix calculation of layers array length for isl_view

2018-09-07 Thread Danylo Piliaiev
Comment for array_len field states: "Indicates the number of array elements starting at Base Array Layer." And most usages of array_len expect it to be equal or less than total layers - base layer Fixes: 5a8c8903 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107856 Signed-off-by:

[Mesa-dev] [PATCH] i965: compute the right number of array layers use base layer

2018-09-07 Thread Lionel Landwerlin
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107856 Signed-off-by: Lionel Landwerlin --- src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_wm_surface_state.c

Re: [Mesa-dev] [PATCH] i965/glsl: don't add unused aoa elements to the program resource list

2018-09-07 Thread andrey simiklit
Hi all, Could somebody run it on CI to confirm that this patch fixes one test and not add regressions or maybe even take a look at this patch) Regards, Andrii. On Fri, Aug 31, 2018 at 5:13 PM wrote: > From: Andrii Simiklit > > It fixes a bit incorrectly implemented

Re: [Mesa-dev] [PATCH] i965/batch: don't ignore the 'brw_new_batch' call for a 'new batch'

2018-09-07 Thread andrey simiklit
Hi all, Could somebody check it on CI to confirm that this patch do not add regressions or maybe even take a look at this patch. Regards, Andrii. On Mon, Aug 27, 2018 at 12:39 PM andrey simiklit wrote: > Hi all, > > It would be great if somebody look at this. > I guess that this issue can

Re: [Mesa-dev] [PATCH] intel/genxml: remove SLM Enable bit from Gen11

2018-09-07 Thread Emil Velikov
Hi Lionel, On 7 September 2018 at 14:43, Lionel Landwerlin wrote: > Documentation says this bit is gone and we've indeed set all the slm > field to 0 in common/gen_l3_config.c > > Signed-off-by: Lionel Landwerlin > --- > src/intel/genxml/gen11.xml | 1 - >

Re: [Mesa-dev] [PATCH] i965: Bump aperture tracking to u64

2018-09-07 Thread Kenneth Graunke
On Friday, September 7, 2018 6:34:45 AM PDT Chris Wilson wrote: > As a prelude to handling large address spaces, first allow ourselves the > luxury of handling the full 4G. > > Reported-by: Andrey Simiklit > Cc: Kenneth Graunke > --- > src/mesa/drivers/dri/i965/brw_context.h | 2 +- >

Re: [Mesa-dev] [PATCH v5] intel: compiler option msse2 and mstackrealign

2018-09-07 Thread Sergii Romantsov
Oh, thanks. So maybe that one https://patchwork.freedesktop.org/patch/247572/ one more time :)? And this https://patchwork.freedesktop.org/patch/247729/ ? On Fri, Sep 7, 2018 at 3:46 PM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > It's good, pushed. > > On 07/09/2018 10:57,

Re: [Mesa-dev] [PATCH] i965: Bump aperture tracking to u64

2018-09-07 Thread andrey simiklit
On Fri, Sep 7, 2018 at 4:35 PM Chris Wilson wrote: > As a prelude to handling large address spaces, first allow ourselves the > luxury of handling the full 4G. > > Reported-by: Andrey Simiklit > Cc: Kenneth Graunke > --- > src/mesa/drivers/dri/i965/brw_context.h | 2 +- >

[Mesa-dev] [PATCH v5 5/8] mesa/main: don't use win _vsnprintf. there is 'util_vsnprintf' function

2018-09-07 Thread asimiklit . work
From: Andrii Simiklit The win '_vsnprintf' function incompatibility with C99 vsnprintf. At least for case when the input buffer size less than the required size: '_vsnprintf' returns -1 for this case. 'vsnprintf' returns the required size. v5: remove _mesa_*snprintf functions and replace it by

Re: [Mesa-dev] [PATCH 1/2] intel/genxml: turn SLM Enable bit into boolean

2018-09-07 Thread Jason Ekstrand
Rb On September 7, 2018 05:55:57 Lionel Landwerlin wrote: Signed-off-by: Lionel Landwerlin --- src/intel/genxml/gen10.xml | 2 +- src/intel/genxml/gen8.xml | 2 +- src/intel/genxml/gen9.xml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/intel/genxml/gen10.xml

[Mesa-dev] [PATCH 2/2] travis: adding missing x11-xcb for meson+vulkan

2018-09-07 Thread Emil Velikov
From: Emil Velikov Required by the x11 WSI Fixes: df82012b2cb ("travis: add meson build for vulkan drivers.") Cc: Dylan Baker Signed-off-by: Emil Velikov --- Dylan comparing the list vs the autotools build the meson one is missing x11proto-xf86vidmode-dev. Can I interest you in

[Mesa-dev] [PATCH 1/2] travis: pull xenial for python3.5 (and friends) on meson

2018-09-07 Thread Emil Velikov
From: Emil Velikov The meson requirement was bumped recently to 0.45, which requires python 3.5 On travis that is only available on xenial. Additionally we need to pull setuptools package otherwise pip fails to install meson. Pulling setuptools via pip, attempts to recursively attepmting to

Re: [Mesa-dev] [PATCH 0/8] Gallium & RadeonSI optimization for Ryzen CPUs

2018-09-07 Thread Michel Dänzer
On 2018-09-06 10:56 p.m., Axel Davy wrote: > Yeah by pinning to cores, I meant to group of cores. > > I think a reasonable policy would be for the kernel to put all threads > of a given process on the same L3 > as long as the number of threads is lower than the L3 group size. > When there is more

Re: [Mesa-dev] [PATCH v5] intel: compiler option msse2 and mstackrealign

2018-09-07 Thread Sergii Romantsov
Hello, Lionel. Any regression with CI? On Thu, Sep 6, 2018 at 12:33 PM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > Giving it a run through CI and I'll push after. > > Thanks! > > > On 06/09/2018 09:07, Sergii Romantsov wrote: > >> Seems in case of 32-bit library, usage of msse2

Re: [Mesa-dev] [PATCH v1] mesa/meson: 32bit xmlconfig linkage

2018-09-07 Thread Eric Engestrom
On Friday, 2018-09-07 12:09:46 +0300, Sergii Romantsov wrote: > Hello, Eric. > > but we don't want to remove libmesa_util from the other libs > > > Does it mean to revert src/gbm/meson.build and src/glx/meson.build ? Yes, precisely :) > > On Thu, Sep 6, 2018 at 8:30 PM, Eric Engestrom >

[Mesa-dev] [Bug 100316] Linking GLSL 1.30 shaders with invariant and deprecated variables triggers an 'mismatching invariant qualifiers' error

2018-09-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100316 Danylo changed: What|Removed |Added CC||danylo.pilia...@gmail.com --- Comment #3 from

Re: [Mesa-dev] [PATCH v1] mesa/meson: 32bit xmlconfig linkage

2018-09-07 Thread Sergii Romantsov
Hello, Eric. but we don't want to remove libmesa_util from the other libs Does it mean to revert src/gbm/meson.build and src/glx/meson.build ? On Thu, Sep 6, 2018 at 8:30 PM, Eric Engestrom wrote: > On Thursday, 2018-09-06 17:38:36 +0300, Sergii Romantsov wrote: > > Building of 32bit mesa

Re: [Mesa-dev] [PATCH v4 0/8] mesa: fix usage of [v][s][n]printf functions

2018-09-07 Thread Emil Velikov
On 6 September 2018 at 17:58, Eric Engestrom wrote: > On Thursday, 2018-09-06 17:43:50 +0300, asimiklit.w...@gmail.com wrote: >> From: Andrii Simiklit >> >> This patch improve usage of [v][s][n]printf functions. >> Fixes cross platform implementation of vsnprintf >> >> v2: Linux man about

[Mesa-dev] [PATCH v2] virgl: Add command and flags to initiate debugging on the host

2018-09-07 Thread Gert Wollny
From: Gert Wollny On the host VREND_DEBUG=guestallow must be set to let the guest override the debug flags. v2: Send flag string instead of flags, this avoids the need to keep the flags in sync. Signed-off-by: Gert Wollny --- The corresponding virglrenderer patch series is in this MR:

[Mesa-dev] [PATCH v2] mesa/meson: 32bit xmlconfig linkage

2018-09-07 Thread Sergii Romantsov
Building of 32bit mesa with meson causes linkage issue: "undefined reference to `util_get_process_name'" Fixed by adding link-with mesa_util for xmlconfig primary. v2: Removed '[]', commit message corrected. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107843 Fixes:

Re: [Mesa-dev] [Mesa-stable] [PATCH] glsl: fixer lexer for unreachable defines

2018-09-07 Thread Andres Gomez
Pulled into staging/18.2. Thanks for the heads up. On Thu, 2018-09-06 at 09:24 -0700, Dylan Baker wrote: > Quoting Timothy Arceri (2018-09-05 19:40:34) > > Cc: mesa-sta...@lists.freedesktop.org > > > > On 01/09/18 23:57, Timothy Arceri wrote: > > > If we have something like: > > > > > >

Re: [Mesa-dev] [PATCH] mesa/util: add missing va_end() after va_copy()

2018-09-07 Thread andrey simiklit
On Thu, Sep 6, 2018 at 3:20 PM Emil Velikov wrote: > Hi Andrii, > > I think you might be overthinking my comments. > There's nothing special, nor am I trying to force my opinion. > > If you think my suggestions make sense, great. Otherwise don't bother too > much. > Thanks a lot for your advices

Re: [Mesa-dev] [PATCH v4 0/8] mesa: fix usage of [v][s][n]printf functions

2018-09-07 Thread andrey simiklit
On Thu, Sep 6, 2018 at 7:58 PM Eric Engestrom wrote: > On Thursday, 2018-09-06 17:43:50 +0300, asimiklit.w...@gmail.com wrote: > > From: Andrii Simiklit > > > > This patch improve usage of [v][s][n]printf functions. > > Fixes cross platform implementation of vsnprintf > > > > v2: Linux man

Re: [Mesa-dev] [PATCH v4 0/8] mesa: fix usage of [v][s][n]printf functions

2018-09-07 Thread andrey simiklit
On Fri, Sep 7, 2018 at 12:09 PM Emil Velikov wrote: > On 6 September 2018 at 17:58, Eric Engestrom > wrote: > > On Thursday, 2018-09-06 17:43:50 +0300, asimiklit.w...@gmail.com wrote: > >> From: Andrii Simiklit > >> > >> This patch improve usage of [v][s][n]printf functions. > >> Fixes cross

Re: [Mesa-dev] sorry Was: GLU problem with gluNurbsSurface

2018-09-07 Thread j. scheurich
The problem is in gluNurbsSurface. Sorry, the problem do not exist 8-( so long MUFTI ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] imx/etnaviv: loader_open_render_node() fails

2018-09-07 Thread Emil Velikov
Hi Lukas, Adding the etnaviv ML - people in there may have some tips. On 6 September 2018 at 15:43, Lukas F. Hartmann wrote: > Hi, > > I've updated to and rebuilt the latest git versions of linux, drm, mesa > and kmscube on an imx6qp system. I tried both with etnaviv as a module > and compiled

Re: [Mesa-dev] [PATCH v5] intel: compiler option msse2 and mstackrealign

2018-09-07 Thread Lionel Landwerlin
There was a test that failed, but I think it might be flakyness. I'm retrying one more time. Will get back to you in ~1h. - Lionel On 07/09/2018 10:32, Sergii Romantsov wrote: Hello, Lionel. Any regression with CI? On Thu, Sep 6, 2018 at 12:33 PM, Lionel Landwerlin

Re: [Mesa-dev] [PATCH] glsl/linker: Check the invariance of built-in special variables

2018-09-07 Thread Vadym Shovkoplias
Hi Tapani, Thanks for the review! I'll add the needed space. On Fri, Sep 7, 2018 at 8:16 AM, Tapani Pälli wrote: > LGTM > > It would be nice to have this as part of 'cross_validate_globals' or some > other pass but considering how special/specific rules we are dealing with > here IMO it's fine

[Mesa-dev] [PATCH 1/2] intel/genxml: turn SLM Enable bit into boolean

2018-09-07 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/genxml/gen10.xml | 2 +- src/intel/genxml/gen8.xml | 2 +- src/intel/genxml/gen9.xml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/intel/genxml/gen10.xml b/src/intel/genxml/gen10.xml index 541e4405716..abd5da297d6

[Mesa-dev] [PATCH 2/2] intel/genxml: remove SLM Enable bit on Gen11

2018-09-07 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/genxml/gen11.xml | 1 - 1 file changed, 1 deletion(-) diff --git a/src/intel/genxml/gen11.xml b/src/intel/genxml/gen11.xml index 1b3befbbfc9..f497c2df825 100644 --- a/src/intel/genxml/gen11.xml +++ b/src/intel/genxml/gen11.xml @@ -3544,7 +3544,6 @@

[Mesa-dev] [PATCH v3] mesa/meson: 32bit xmlconfig linkage

2018-09-07 Thread Sergii Romantsov
Building of 32bit mesa with meson causes linkage issue: "undefined reference to `util_get_process_name'" Fixed by adding link-with mesa_util for xmlconfig primary. v2: Removed '[]', commit message corrected. v3: Reverted changes in gbm and glx libraries. Bugzilla:

Re: [Mesa-dev] imx/etnaviv: loader_open_render_node() fails

2018-09-07 Thread Lucas Stach
Am Donnerstag, den 06.09.2018, 16:43 +0200 schrieb Lukas F. Hartmann: > Hi, > > I've updated to and rebuilt the latest git versions of linux, drm, mesa > and kmscube on an imx6qp system. I tried both with etnaviv as a module > and compiled into the kernel (no difference). > > Mesa no longer

Re: [Mesa-dev] imx/etnaviv: loader_open_render_node() fails

2018-09-07 Thread Lucas Stach
Hi Emil, Am Freitag, den 07.09.2018, 10:52 +0100 schrieb Emil Velikov: > Hi Lukas, > > Adding the etnaviv ML - people in there may have some tips. > > > On 6 September 2018 at 15:43, Lukas F. Hartmann wrote: > > Hi, > > > > I've updated to and rebuilt the latest git versions of linux, drm,

[Mesa-dev] [PATCH] gallium: freedreno: fix compile issue

2018-09-07 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin Fixes: daa19363def83c ("gallium: split depth_clip into depth_clip_near & depth_clip_far") --- src/gallium/drivers/freedreno/freedreno_draw.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/freedreno/freedreno_draw.c

Re: [Mesa-dev] [PATCH 3/4] anv: Disable the vertex cache when tessellating on SKL GT4

2018-09-07 Thread Kenneth Graunke
On Tuesday, August 21, 2018 6:57:50 PM PDT Jason Ekstrand wrote: > I have no idea if I'm correct about what's going wrong or if this is the > correct fix. However, in my multiple weeks of banging my head on this > hang, a VUE reference counting bug seems to match all the symptoms and > it

Re: [Mesa-dev] [PATCH 0/8] Gallium & RadeonSI optimization for Ryzen CPUs

2018-09-07 Thread Marek Olšák
I'm changing the initial L3 cache number to this: +static unsigned L3_cache_number; +static once_flag init_cache_number_flag = ONCE_FLAG_INIT; + +static void +util_init_cache_number(void) +{ + /* Get a semi-random number. */ + int64_t t = os_time_get_nano(); + L3_cache_number = (t ^ (t >>

Re: [Mesa-dev] [PATCH 0/8] Gallium & RadeonSI optimization for Ryzen CPUs

2018-09-07 Thread Marek Olšák
On Fri, Sep 7, 2018 at 11:04 AM, Michel Dänzer wrote: > On 2018-09-07 4:31 p.m., Marek Olšák wrote: >> On Fri, Sep 7, 2018, 4:34 AM Michel Dänzer wrote: >>> On 2018-09-06 10:56 p.m., Axel Davy wrote: >>> I fear if we begin to do the work manually, there won't be interest to do that in

Re: [Mesa-dev] [PATCH 4/4] anv: Clamp scissors to the framebuffer boundary

2018-09-07 Thread Kenneth Graunke
On Tuesday, August 21, 2018 6:57:51 PM PDT Jason Ekstrand wrote: > The Vulkan 1.1.81 spec says: > > "It is legal for offset.x + extent.width or offset.y + extent.height > to exceed the dimensions of the framebuffer - the scissor test still > applies as defined above. Rasterization

[Mesa-dev] [AppVeyor] mesa master #8831 failed

2018-09-07 Thread AppVeyor
Build mesa 8831 failed Commit 25ffb84016 by Marek Olšák on 9/6/2018 3:13 AM: radeonsi: pin the winsys thread to the requested L3 cache (v2)\n\nv2: rebase\n\nReviewed-by: Brian Paul Configure your notification preferences

Re: [Mesa-dev] [PATCH 1/4] anv: Re-emit vertex buffers when the pipeline changes

2018-09-07 Thread Kenneth Graunke
On Tuesday, August 21, 2018 6:57:48 PM PDT Jason Ekstrand wrote: > Some of the bits of VERTEX_BUFFER_STATE such as access type, instance > data step rate, and pitch come from the pipeline. > > Cc: mesa-sta...@lists.freedesktop.org > --- > src/intel/vulkan/genX_cmd_buffer.c | 2 ++ > 1 file

Re: [Mesa-dev] [PATCH 2/4] anv: Implement a VF cache invalidate workaround

2018-09-07 Thread Kenneth Graunke
On Tuesday, August 21, 2018 6:57:49 PM PDT Jason Ekstrand wrote: > Known to fix nothing whatsoever but it's in the docs. > --- > src/intel/vulkan/genX_cmd_buffer.c | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/src/intel/vulkan/genX_cmd_buffer.c >

[Mesa-dev] [PATCH] gallium/util: start with a random L3 cache index for AMD Zen

2018-09-07 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/util/u_helpers.c | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/src/gallium/auxiliary/util/u_helpers.c b/src/gallium/auxiliary/util/u_helpers.c index f773360adde..466add53fc9 100644 ---

[Mesa-dev] [PATCH 4/4] gallium/u_inlines: remove the destroy variable in pipe_reference_described

2018-09-07 Thread Marek Olšák
From: Marek Olšák Reviewed-by: Michel Dänzer Tested-by: Dieter Nützel --- src/gallium/auxiliary/util/u_inlines.h | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/gallium/auxiliary/util/u_inlines.h b/src/gallium/auxiliary/util/u_inlines.h index

[Mesa-dev] [PATCH 2/4] gallium/auxiliary: don't dereference counters twice needlessly

2018-09-07 Thread Marek Olšák
From: Marek Olšák +1.2% performance with: piglit/drawoverhead - DrawElements (no state changes) on radeonsi Tested-by: Dieter Nützel --- src/gallium/auxiliary/util/u_inlines.h | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git

[Mesa-dev] [PATCH 1/4] gallium/u_inlines: normalize naming, use dst & src, style fixes (v2)

2018-09-07 Thread Marek Olšák
From: Marek Olšák v2: update comments Reviewed-by: Michel Dänzer Tested-by: Dieter Nützel --- src/gallium/auxiliary/util/u_inlines.h | 94 +- 1 file changed, 47 insertions(+), 47 deletions(-) diff --git a/src/gallium/auxiliary/util/u_inlines.h

[Mesa-dev] [PATCH 3/4] gallium/u_inlines: improve pipe_reference_described perf for debug builds

2018-09-07 Thread Marek Olšák
From: Marek Olšák Tested-by: Dieter Nützel --- src/gallium/auxiliary/util/u_inlines.h | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/gallium/auxiliary/util/u_inlines.h b/src/gallium/auxiliary/util/u_inlines.h index 83013df53f1..820d3080a5c 100644 ---

Re: [Mesa-dev] [PATCH 0/8] Gallium & RadeonSI optimization for Ryzen CPUs

2018-09-07 Thread Marek Olšák
On Fri, Sep 7, 2018 at 3:34 PM, Alan Swanson wrote: > On Fri, 2018-09-07 at 15:01 -0400, Marek Olšák wrote: >> On Fri, Sep 7, 2018 at 11:04 AM, Michel Dänzer >> wrote: >> > On 2018-09-07 4:31 p.m., Marek Olšák wrote: >> > > >> > > I don't think the performance can be worse than it is right now.

Re: [Mesa-dev] [PATCH v2] gallium: Correctly handle no config context creation

2018-09-07 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Thu, Sep 6, 2018 at 5:46 AM, Elie Tournier wrote: > This patch fixes the following Piglit test: > spec@egl_mesa_configless_context@basic > It also fixes few test in a virgl guest. > > v2: Evaluate the value of no_config (Ilia) > > Suggested-by: Emil Velikov >

[Mesa-dev] [AppVeyor] mesa 18.2 #8834 completed

2018-09-07 Thread AppVeyor
Build mesa 8834 completed Commit 7378180e7a by Andres Gomez on 9/7/2018 9:10 PM: docs: update 18.2.0 release notes\n\nSigned-off-by: Andres Gomez Configure your notification preferences ___ mesa-dev

Re: [Mesa-dev] [PATCH 15/15] radeonsi/nir: port some bindless and sampler code from TGSI

2018-09-07 Thread Marek Olšák
Ping On Wed, Aug 29, 2018 at 4:13 PM, Marek Olšák wrote: > From: Marek Olšák > > These might be all missing changes for bindless textures. > --- > src/gallium/drivers/radeonsi/si_shader_nir.c | 80 > 1 file changed, 50 insertions(+), 30 deletions(-) > > diff --git

[Mesa-dev] [ANNOUNCE] mesa 18.2.0

2018-09-07 Thread Andres Gomez
Mesa 18.2.0 is now available. This release consists of nearly 2200 commits from approximately 130 developers. The top highlights include: - OpenGL 4.3 on virgl. - OpenGL 4.4 Compatibility profile on radeonsi. - OpenGL ES 3.2 on radeonsi and virgl. - GL_ARB_ES3_2_compatibility on radeonsi.

Re: [Mesa-dev] [PATCH 0/8] Gallium & RadeonSI optimization for Ryzen CPUs

2018-09-07 Thread Alan Swanson
On Fri, 2018-09-07 at 15:01 -0400, Marek Olšák wrote: > On Fri, Sep 7, 2018 at 11:04 AM, Michel Dänzer > wrote: > > On 2018-09-07 4:31 p.m., Marek Olšák wrote: > > > > > > I don't think the performance can be worse than it is right now. > > > > In the worst case, all processes using OpenGL (or

Re: [Mesa-dev] [PATCH] mesa/st: Prefer RG_float when emulating INTENSITY Float over LA float

2018-09-07 Thread Marek Olšák
RG can't be used to represent intensity, because RG uses swizzle RG01, while intensity uses . Marek On Wed, Sep 5, 2018 at 4:36 AM, Gert Wollny wrote: > From: Gert Wollny > > Gallium picked R16G16_FLOAT to represent GL_INTENSITY16F if no intensity > format is provided by the driver.

[Mesa-dev] [PATCH] mesa: remove duplicate dispatch sanity tests

2018-09-07 Thread Timothy Arceri
This removes duplicate tests from gl_core_functions_possible that are already covered by common_desktop_functions_possible. --- src/mesa/main/tests/dispatch_sanity.cpp | 265 1 file changed, 265 deletions(-) diff --git a/src/mesa/main/tests/dispatch_sanity.cpp

[Mesa-dev] [AppVeyor] mesa master #8837 failed

2018-09-07 Thread AppVeyor
Build mesa 8837 failed Commit ecfe41e690 by Andres Gomez on 9/7/2018 9:40 PM: docs: update calendar, add news item and link release notes for 18.2.0\n\nSigned-off-by: Andres Gomez Configure your notification preferences

Re: [Mesa-dev] [PATCH 15/15] radeonsi/nir: port some bindless and sampler code from TGSI

2018-09-07 Thread Timothy Arceri
On 08/09/18 07:37, Marek Olšák wrote: Ping I had additional patches for bindless somewhere, tbh it's hard to know if this is all thats needed since we can't test but if you think this is correct feel free to push. It's not like it's going to break anything and we can always fix it later

Re: [Mesa-dev] [PATCH 2/2] intel/genxml: remove SLM Enable bit on Gen11

2018-09-07 Thread Lionel Landwerlin
Arg didn't this on anv which sets this be through genxml even though the documentation says it's reserved. Will send an update. On 07/09/2018 11:55, Lionel Landwerlin wrote: Signed-off-by: Lionel Landwerlin --- src/intel/genxml/gen11.xml | 1 - 1 file changed, 1 deletion(-) diff --git

[Mesa-dev] Get Wolfenstein: The Old Blood running (Part 1)

2018-09-07 Thread Timothy Arceri
This enables a couple more extension that the game expects in the core profile (and yes Nvidia exposes them in core). These changes allow the game to start without crashing. The second part adds some EXT_direct_state_access support so I'm sending it separately.

[Mesa-dev] [PATCH 1/2] mesa: enable EXT_framebuffer_object in core profile

2018-09-07 Thread Timothy Arceri
Since user defined names are not allowed in core profile we remove the allow_user_names bool and just check if we have a core profile like all other buffer/texture object handling code does. This extension is required by "Wolfenstein: The Old Blood" and is exposed in core in the Nvidia binary

[Mesa-dev] [PATCH 2/2] mesa: enable ARB_vertex_program in core profile

2018-09-07 Thread Timothy Arceri
This extension is required by "Wolfenstein: The Old Blood". Without it the app causes wine to crash on startup. --- src/mesa/main/extensions_table.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/extensions_table.h b/src/mesa/main/extensions_table.h index

  1   2   >