[Mesa-dev] [Bug 99553] Tracker bug for runnning OpenCL applications on Clover

2018-09-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99553 Bug 99553 depends on bug 91305, which changed state. Bug 91305 Summary: [clover/kaveri] When running JohnTheRipper OpenCL tests: radeon :01:00.0: ring 0 stalled for more than ...msec https://bugs.freedesktop.org/show_bug.cgi?id=91305

[Mesa-dev] [Bug 91305] [clover/kaveri] When running JohnTheRipper OpenCL tests: radeon 0000:01:00.0: ring 0 stalled for more than ...msec

2018-09-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91305 Dennis Schridde changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH 2/2] gallium: try to fix the Windows build

2018-09-10 Thread Jose Fonseca
Sorry Marek, I just pushed an identical patch as I had missed this one. Jose On 09/09/18 02:02, Marek Olšák wrote: From: Marek Olšák Windows doesn't have thrd_current. --- src/gallium/auxiliary/util/u_helpers.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [Mesa-dev] [PATCH] android: util/u_thread: fix building error with bionic pthread

2018-09-10 Thread Mauro Rossi
Hi, Il giorno lun 10 set 2018 alle ore 09:58 Tapani Pälli ha scritto: > > Marek sent a similar fix here: > https://lists.freedesktop.org/archives/mesa-dev/2018-September/204797.html Thanks a lot! So the APU L3 cache optimization will be lost for Android > > On 09/10/2018 10:52 AM, Mauro Rossi

[Mesa-dev] [AppVeyor] mesa master #8844 completed

2018-09-10 Thread AppVeyor
Build mesa 8844 completed Commit 52ca32121b by Jose Fonseca on 9/7/2018 12:27 PM: Require Visual Studio 2015.\n\nWe no longer need or use Visual Studio 2013.\n\nhttps://ci.appveyor.com/project/jrfonseca/mesa/build/52\n\nReviewed-by: Roland Scheidegger

Re: [Mesa-dev] [PATCH 1/2] gallium: New cap PIPE_CAP_MAX_VERTEX_ELEMENT_SRC_OFFSET.

2018-09-10 Thread Mathias Fröhlich
The patches are pushed now. Thanks for the review! best Mathias On Thursday, 6 September 2018 16:42:51 CEST Brian Paul wrote: > The series looks good to me. > > Reviewed-by: Brian Paul > > On 09/06/2018 08:31 AM, mathias.froehl...@gmx.net wrote: > > From: Mathias Fröhlich > > > > Introduce

Re: [Mesa-dev] [PATCH v3] mesa/meson: 32bit xmlconfig linkage

2018-09-10 Thread Sergii Romantsov
Hello, just reminder for case: don't have push-rights... On Fri, Sep 7, 2018 at 8:05 PM, Dylan Baker wrote: > Quoting Sergii Romantsov (2018-09-07 02:43:41) > > Building of 32bit mesa with meson causes linkage issue: > > "undefined reference to `util_get_process_name'" > > Fixed by adding

Re: [Mesa-dev] [PATCH] android: util/u_thread: fix building error with bionic pthread

2018-09-10 Thread Tapani Pälli
Marek sent a similar fix here: https://lists.freedesktop.org/archives/mesa-dev/2018-September/204797.html On 09/10/2018 10:52 AM, Mauro Rossi wrote: This patch is to tackle with shortcomings in Android bionic libc. Even if setting cflag -D__USE__GNU and adding include of cpuset macros may

[Mesa-dev] [Bug 101927] American Conquest via Wine cannot start

2018-09-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101927 Timothy Arceri changed: What|Removed |Added Assignee|dri-devel@lists.freedesktop |mesa-dev@lists.freedesktop.

[Mesa-dev] [PATCH] android: util/u_thread: fix building error with bionic pthread

2018-09-10 Thread Mauro Rossi
This patch is to tackle with shortcomings in Android bionic libc. Even if setting cflag -D__USE__GNU and adding include of cpuset macros may become available, bionic libc does not support pthread_{g,s}etaffinity_np() Wrappers to sched_{g,s]etaffinity() were found to here:

Re: [Mesa-dev] [PATCH 1/2] util: try to fix the Android build

2018-09-10 Thread Jose Fonseca
On 09/09/18 02:02, Marek Olšák wrote: From: Marek Olšák --- src/util/u_thread.h | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/util/u_thread.h b/src/util/u_thread.h index ec0d9a7..0c20ebb 100644 --- a/src/util/u_thread.h +++ b/src/util/u_thread.h @@ -29,20

[Mesa-dev] [PATCH] radeon: fix ColorMask

2018-09-10 Thread Christopher Egert
Since commit af3685d14936844f79e6f372b4b258e29375f21b various OpenGL applications regressed on the classic mesa radeon driver. Signed-off-by: Christopher Egert CC: --- src/mesa/drivers/dri/r200/r200_state.c | 8 src/mesa/drivers/dri/radeon/radeon_state.c | 8 2 files

Re: [Mesa-dev] [PATCH 0/2] Introduce and use cap for MaxVertexAttribRelativeOffset.

2018-09-10 Thread Guido Günther
Hi, On Thu, Sep 06, 2018 at 04:31:12PM +0200, mathias.froehl...@gmx.net wrote: > From: Mathias Fröhlich > > Hi all, > > The following two patches introduce a gallium capability > to feed gl_constants::MaxVertexAttribRelativeOffset. > Then adapt etnyviv to return what it can really handle. >

[Mesa-dev] [Bug 107878] Artifacting Hair on Overwatch vega56

2018-09-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107878 --- Comment #2 from coolo...@gmail.com --- to clarify, this also occurs on mesa 18.1.6 and llvm6 -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

Re: [Mesa-dev] [PATCH] i965: Fix calculation of layers array length for isl_view

2018-09-10 Thread Danylo Piliaiev
Thank you Józef and Ilia for pointing this out! I believe I have fully understood what's happening here and I'll send a final version of the fix soon. On 9/7/18 7:47 PM, Józef Kucia wrote: On Fri, Sep 7, 2018 at 6:44 PM Ilia Mirkin wrote: On Fri, Sep 7, 2018 at 12:35 PM, Józef Kucia

Re: [Mesa-dev] [PATCH] mesa/st: Prefer RG_float when emulating INTENSITY Float over LA float

2018-09-10 Thread Gert Wollny
Am Freitag, den 07.09.2018, 17:57 -0400 schrieb Marek Olšák: > RG can't be used to represent intensity, because RG uses swizzle > RG01, while intensity uses . I see, and thanks, I guess the mesa side then has to check these sizes too, so I'll prepare a patch for this. Best, Gert > >

[Mesa-dev] [PATCH] mesa/texture: Also check for LA texture when querying intensity component size

2018-09-10 Thread Gert Wollny
From: Gert Wollny Gallium may pick L16A16_FLOAT to represent GL_INTENSITY16F if no intensity format is provided by the driver. However, when calling glGetTexLevelParameteriv(..., GL_TEXTURE_INTENSITY_SIZE, ...) mesa will return a zero size because the actually used format has no intensity

Re: [Mesa-dev] [PATCH] mesa: tidy up init_matrix_stack()

2018-09-10 Thread Alejandro Piñeiro
Reviewed-by: Alejandro Piñeiro On 10/09/18 12:41, Timothy Arceri wrote: > --- > src/mesa/main/matrix.c | 10 +++--- > 1 file changed, 3 insertions(+), 7 deletions(-) > > diff --git a/src/mesa/main/matrix.c b/src/mesa/main/matrix.c > index 83f081e88e5..8065a83705c 100644 > ---

Re: [Mesa-dev] [PATCH] i965/batch: don't ignore the 'brw_new_batch' call for a 'new batch'

2018-09-10 Thread Chris Wilson
Quoting andrey simiklit (2018-08-21 13:00:57) > Hi all, > > The bug for this issue was created: > https://bugs.freedesktop.org/show_bug.cgi?id=107626 What about something like diff --git a/src/mesa/drivers/dri/i965/brw_draw.c b/src/mesa/drivers/dri/i965/brw_draw.c index

Re: [Mesa-dev] [PATCH 1/2] travis: pull xenial for python3.5 (and friends) on meson

2018-09-10 Thread Juan A. Suarez Romero
On Fri, 2018-09-07 at 14:58 +0100, Emil Velikov wrote: > From: Emil Velikov > > The meson requirement was bumped recently to 0.45, which requires > python 3.5 > > On travis that is only available on xenial. Additionally we need to pull > setuptools package otherwise pip fails to install meson.

Re: [Mesa-dev] [PATCH] travis: use python3.5 for meson

2018-09-10 Thread Eric Engestrom
On Monday, 2018-09-10 14:15:33 +0200, Juan A. Suarez Romero wrote: > Newer Meson versions require python >=3.5. But in Trusty default python3 > version is 3.4.x. > > Install python3.5 and makes it the default version for Meson using > update-alternatives method. > > CC: Jan Vesely > CC: Andres

[Mesa-dev] [Bug 107878] Artifacting Hair on Overwatch vega56

2018-09-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107878 --- Comment #1 from coolo...@gmail.com --- Created attachment 141504 --> https://bugs.freedesktop.org/attachment.cgi?id=141504=edit screenshot example -- You are receiving this mail because: You are the assignee for the bug. You are the QA

[Mesa-dev] [PATCH] travis: use python3.5 for meson

2018-09-10 Thread Juan A. Suarez Romero
Newer Meson versions require python >=3.5. But in Trusty default python3 version is 3.4.x. Install python3.5 and makes it the default version for Meson using update-alternatives method. CC: Jan Vesely CC: Andres Gomez CC: Emil Velikov CC: Jon Turney CC: Eric Engestrom CC: Dylan Baker ---

[Mesa-dev] [Bug 107777] No 3D in "Vampire: The Masquerade - Bloodlines" when d3d-nine enabled

2018-09-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=10 --- Comment #7 from ilia --- Created attachment 141506 --> https://bugs.freedesktop.org/attachment.cgi?id=141506=edit Fullscreen Pressing alt+tab I eventually got able to see game menu. But it was not interactable - even mouse hover.

[Mesa-dev] [PATCH] mesa: tidy up init_matrix_stack()

2018-09-10 Thread Timothy Arceri
--- src/mesa/main/matrix.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/src/mesa/main/matrix.c b/src/mesa/main/matrix.c index 83f081e88e5..8065a83705c 100644 --- a/src/mesa/main/matrix.c +++ b/src/mesa/main/matrix.c @@ -657,20 +657,16 @@ void

[Mesa-dev] [Bug 107777] No 3D in "Vampire: The Masquerade - Bloodlines" when d3d-nine enabled

2018-09-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=10 --- Comment #6 from ilia --- Yes, results are the same. Moreover, I attached screenshots specifically for this case: 1. wine in desktop mode + fullscreen game https://bugs.freedesktop.org/attachment.cgi?id=141398 2. wine in desktop mode +

[Mesa-dev] [PATCH v2] i965/batch: don't ignore the 'brw_new_batch' call for a 'new batch'

2018-09-10 Thread asimiklit . work
From: Andrii Simiklit If we restore the 'new batch' using 'intel_batchbuffer_reset_to_saved' function we must restore the default state of the batch using 'brw_new_batch' function because the 'intel_batchbuffer_flush' function will not do it for the 'new batch' again. At least the following

Re: [Mesa-dev] [PATCH 2/2] etnaviv: Reduce max offset to available hardware bits.

2018-09-10 Thread Guido Günther
Hi, On Thu, Sep 06, 2018 at 04:31:14PM +0200, mathias.froehl...@gmx.net wrote: > From: Mathias Fröhlich > > Signed-off-by: Mathias Fröhlich I know it's pushed already but for the record (Just came back form vacation): Tested-By: Guido Gúnther > --- >

[Mesa-dev] [PATCH v3] i965: Fix calculation of layers array length for isl_view

2018-09-10 Thread Danylo Piliaiev
Handle all cases in calculation of layers count for isl_view taking into account texture view and image unit. st_convert_image was taken as a reference. When u->Layered is true the whole level is taken with respect to image view. In other case only one layer is taken. v3: (Józef Kucia and Ilia

Re: [Mesa-dev] [PATCH 3/4] gallium/u_inlines: improve pipe_reference_described perf for debug builds

2018-09-10 Thread Michel Dänzer
On 2018-09-07 11:35 p.m., Marek Olšák wrote: > From: Marek Olšák > > Tested-by: Dieter Nützel > --- > src/gallium/auxiliary/util/u_inlines.h | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/src/gallium/auxiliary/util/u_inlines.h >

[Mesa-dev] [PATCH v2] radv: adjust ESGS ring buffer size computation on VI+

2018-09-10 Thread Samuel Pitoiset
Noticed while working in this area. Ported from RadeonSI. v2: fix missing * num_se Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_pipeline.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index

Re: [Mesa-dev] [PATCH] i965/batch: don't ignore the 'brw_new_batch' call for a 'new batch'

2018-09-10 Thread andrey simiklit
Hello, Thanks for your reply. Please find my comments below: On Mon, Sep 10, 2018 at 2:45 PM Chris Wilson wrote: > Quoting andrey simiklit (2018-08-21 13:00:57) > > Hi all, > > > > The bug for this issue was created: > > https://bugs.freedesktop.org/show_bug.cgi?id=107626 > > What about

Re: [Mesa-dev] [PATCH 0/8] Gallium & RadeonSI optimization for Ryzen CPUs

2018-09-10 Thread Michel Dänzer
On 2018-09-07 9:01 p.m., Marek Olšák wrote: > On Fri, Sep 7, 2018 at 11:04 AM, Michel Dänzer wrote: >> On 2018-09-07 4:31 p.m., Marek Olšák wrote: >>> On Fri, Sep 7, 2018, 4:34 AM Michel Dänzer wrote: On 2018-09-06 10:56 p.m., Axel Davy wrote: > I fear if we begin to do the work

Re: [Mesa-dev] [PATCH] radv: adjust ESGS ring buffer size computation on VI+

2018-09-10 Thread Samuel Pitoiset
On 9/10/18 6:12 PM, Ilia Mirkin wrote: On Mon, Sep 10, 2018 at 12:03 PM, Samuel Pitoiset wrote: Noticed while working in this area. Ported from RadeonSI. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_pipeline.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff

[Mesa-dev] [PATCH] radv: adjust ESGS ring buffer size computation on VI+

2018-09-10 Thread Samuel Pitoiset
Noticed while working in this area. Ported from RadeonSI. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_pipeline.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index 1741d5e9047..e362c380453

Re: [Mesa-dev] [PATCH v3] mesa/meson: 32bit xmlconfig linkage

2018-09-10 Thread Dylan Baker
Quoting Sergii Romantsov (2018-09-09 23:52:04) > Hello, > just reminder for case: don't have push-rights... > > On Fri, Sep 7, 2018 at 8:05 PM, Dylan Baker wrote: > > Quoting Sergii Romantsov (2018-09-07 02:43:41) > > Building of 32bit mesa with meson causes linkage issue: > >

Re: [Mesa-dev] [PATCH] utils/u_math: break dependency on gallium/utils

2018-09-10 Thread Dylan Baker
I agree that using code from mesa in util is gross, I'm not planning to leave it like this. I'm in the middle of cleaning up duplication between util and mesa, and I'll plan on pulling u_cpu_detection down into src/util in that series. In this case while gross there shouldn't be any compilation

Re: [Mesa-dev] [PATCH] radv: adjust ESGS ring buffer size computation on VI+

2018-09-10 Thread Ilia Mirkin
On Mon, Sep 10, 2018 at 12:03 PM, Samuel Pitoiset wrote: > Noticed while working in this area. Ported from RadeonSI. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_pipeline.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git

Re: [Mesa-dev] [PATCH 2/4] gallium/auxiliary: don't dereference counters twice needlessly

2018-09-10 Thread Michel Dänzer
On 2018-09-07 11:35 p.m., Marek Olšák wrote: > From: Marek Olšák > > +1.2% performance with: > piglit/drawoverhead - DrawElements (no state changes) on radeonsi No meaningless number (which is most likely the same order of magnitude, maybe even smaller than the deviation between test runs)

Re: [Mesa-dev] Get Wolfenstein: The Old Blood running (Part 2)

2018-09-10 Thread Ian Romanick
On 09/09/2018 06:00 PM, Timothy Arceri wrote: > On 10/09/18 10:40, Ian Romanick wrote: >> On 09/09/2018 05:00 PM, Timothy Arceri wrote: >>> Ian made it pretty clear he didn't want a debate and had already made up >>> his mind. >>> >>> "We decided years ago that we were not going to support this

Re: [Mesa-dev] Get Wolfenstein: The Old Blood running (Part 2)

2018-09-10 Thread Ian Romanick
On 09/09/2018 07:00 PM, Timothy Arceri wrote: > On 10/09/18 11:01, Matt Turner wrote: >> I think it's evident that we can find a way forward based on past >> experiences (compatibility profile is supported in Mesa!). > > I don't really know what you are trying to say here. I continued what >

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/3] android: broadcom/genxml: fix collision with intel/genxml header-gen macro

2018-09-10 Thread Dylan Baker
Quoting Mauro Rossi (2018-09-09 01:56:20) > Hi, > > Il giorno gio 6 set 2018 alle ore 18:20 Dylan Baker > ha scritto: > > > > Quoting Rob Herring (2018-09-06 07:16:07) > > > On Mon, Sep 3, 2018 at 4:27 PM Eric Anholt wrote: > > > > > > > > Mauro Rossi writes: > > > > > > > > > Fixes the

Re: [Mesa-dev] [PATCH 1/2] vulkan: Update the XML and headers to 1.1.84

2018-09-10 Thread Bas Nieuwenhuizen
Acked-by: Bas Nieuwenhuizen On Mon, Sep 10, 2018 at 7:09 PM Jason Ekstrand wrote: > > --- > include/vulkan/vulkan_core.h | 139 +++-- > src/vulkan/registry/vk.xml | 280 +++ > 2 files changed, 345 insertions(+), 74 deletions(-) > > diff --git

[Mesa-dev] [PATCH 2/2] anv: Support v3 of VK_EXT_vertex_attribute_divisor

2018-09-10 Thread Jason Ekstrand
Cc: Bas Nieuwenhuizen --- src/intel/vulkan/anv_device.c | 8 src/intel/vulkan/anv_extensions.py | 2 +- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c index 7ab8543300b..44855dae128 100644 ---

[Mesa-dev] [PATCH 1/2] vulkan: Update the XML and headers to 1.1.84

2018-09-10 Thread Jason Ekstrand
--- include/vulkan/vulkan_core.h | 139 +++-- src/vulkan/registry/vk.xml | 280 +++ 2 files changed, 345 insertions(+), 74 deletions(-) diff --git a/include/vulkan/vulkan_core.h b/include/vulkan/vulkan_core.h index 06c860707b8..fe450142503 100644 ---

[Mesa-dev] [Bug 107890] [bisected] Android build test fails "use of undeclared identifier 'cpu_set_t'/'cpuset'"

2018-09-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107890 Bug ID: 107890 Summary: [bisected] Android build test fails "use of undeclared identifier 'cpu_set_t'/'cpuset'" Product: Mesa Version: git Hardware: Other

[Mesa-dev] [PATCH] radv: Support v3 of VK_EXT_vertex_attribute_divisor.

2018-09-10 Thread Bas Nieuwenhuizen
--- src/amd/vulkan/radv_device.c | 7 +++ src/amd/vulkan/radv_extensions.py | 2 +- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index 53f99a8cecd..7917ed7ffe5 100644 --- a/src/amd/vulkan/radv_device.c +++

[Mesa-dev] [Bug 107890] [bisected] Android build test fails "use of undeclared identifier 'cpu_set_t'/'cpuset'"

2018-09-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107890 --- Comment #1 from Tapani Pälli --- Fix here: https://lists.freedesktop.org/archives/mesa-dev/2018-September/204797.html -- You are receiving this mail because: You are the QA Contact for the

[Mesa-dev] [RFC 2/7] spirv: Update Json and headers from Khronos GitHub master

2018-09-10 Thread Jason Ekstrand
--- src/compiler/spirv/spirv.core.grammar.json | 95 -- src/compiler/spirv/spirv.h | 24 ++ 2 files changed, 114 insertions(+), 5 deletions(-) diff --git a/src/compiler/spirv/spirv.core.grammar.json b/src/compiler/spirv/spirv.core.grammar.json index

[Mesa-dev] [PATCH 1/7] vulkan: Update the XML and headers to 1.1.84

2018-09-10 Thread Jason Ekstrand
--- include/vulkan/vulkan_core.h | 139 +++-- src/vulkan/registry/vk.xml | 280 +++ 2 files changed, 345 insertions(+), 74 deletions(-) diff --git a/include/vulkan/vulkan_core.h b/include/vulkan/vulkan_core.h index 06c860707b8..fe450142503 100644 ---

[Mesa-dev] [RFC 6/7] HACK: Disable the instruction scheduler

2018-09-10 Thread Jason Ekstrand
The instruction scheduler is re-ordering loads which is causing fence values to be loaded after the value they're fencing. In particular, consider the following pseudocode: void try_use_a_thing(int idx) { bool ready = ssbo.arr[idx].ready; vec4 data = ssbo.arr[idx].data;

[Mesa-dev] [RFC 7/7] anv: Advertise support for VK_KHR_vulkan_memory_model

2018-09-10 Thread Jason Ekstrand
--- src/intel/vulkan/anv_device.c | 7 +++ src/intel/vulkan/anv_extensions.py | 1 + src/intel/vulkan/anv_pipeline.c| 1 + 3 files changed, 9 insertions(+) diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c index 47c6c6e93b4..9b15fc0648b 100644 ---

[Mesa-dev] [RFC 5/7] spirv: Add support for the Vulkan memory model

2018-09-10 Thread Jason Ekstrand
--- src/compiler/shader_info.h| 1 + src/compiler/spirv/spirv_to_nir.c | 20 ++-- 2 files changed, 19 insertions(+), 2 deletions(-) diff --git a/src/compiler/shader_info.h b/src/compiler/shader_info.h index 65bc0588d67..a19840666ac 100644 --- a/src/compiler/shader_info.h

[Mesa-dev] [RFC 4/7] spirv: Insert barriers to follow the Vulkan memory model

2018-09-10 Thread Jason Ekstrand
--- src/compiler/spirv/spirv_to_nir.c | 170 ++ 1 file changed, 103 insertions(+), 67 deletions(-) diff --git a/src/compiler/spirv/spirv_to_nir.c b/src/compiler/spirv/spirv_to_nir.c index 96224354057..3378641513c 100644 --- a/src/compiler/spirv/spirv_to_nir.c +++

[Mesa-dev] [RFC 0/7] anv: Support VK_KHR_vulkan_memory_model

2018-09-10 Thread Jason Ekstrand
This patch series adds support to the Intel Vulkan driver for the (currently provisional) VK_KHR_vulkan_memory_model extension. The extension provides a few extra SPIR-V decorations along with some additional guarantees about memory transaction ordering that aim to make better analysis and use of

[Mesa-dev] [RFC 3/7] spirv/info: Add a memorymodel_to_string helper

2018-09-10 Thread Jason Ekstrand
--- src/compiler/spirv/spirv_info.h| 1 + src/compiler/spirv/spirv_info_c.py | 1 + 2 files changed, 2 insertions(+) diff --git a/src/compiler/spirv/spirv_info.h b/src/compiler/spirv/spirv_info.h index 121ffd2febb..9813035e60f 100644 --- a/src/compiler/spirv/spirv_info.h +++

Re: [Mesa-dev] [PATCH 2/2] anv: Support v3 of VK_EXT_vertex_attribute_divisor

2018-09-10 Thread Bas Nieuwenhuizen
I tried, but I can't find from your driver what the HW does, so for this review the same assumption that the CTS tests pass for you. Reviewed-by: Bas Nieuwenhuizen On Mon, Sep 10, 2018 at 7:08 PM Jason Ekstrand wrote: > > Cc: Bas Nieuwenhuizen > --- > src/intel/vulkan/anv_device.c | 8

Re: [Mesa-dev] [PATCH 2/2] anv: Support v3 of VK_EXT_vertex_attribute_divisor

2018-09-10 Thread Jason Ekstrand
On Mon, Sep 10, 2018 at 1:43 PM Bas Nieuwenhuizen wrote: > I tried, but I can't find from your driver what the HW does, so for > this review the same assumption that the CTS tests pass for you. > Our hardware does the DX thing which is also what the spec says. Yes, we pass the tests.

Re: [Mesa-dev] [PATCH] radv: Support v3 of VK_EXT_vertex_attribute_divisor.

2018-09-10 Thread Jason Ekstrand
Assuming you pass the CTS tests (which I'm pretty sure you do), Reviewed-by: Jason Ekstrand Mind reviewing mine? On Mon, Sep 10, 2018 at 1:35 PM Bas Nieuwenhuizen wrote: > --- > src/amd/vulkan/radv_device.c | 7 +++ > src/amd/vulkan/radv_extensions.py | 2 +- > 2 files changed, 8

Re: [Mesa-dev] [PATCH] radv: Support v3 of VK_EXT_vertex_attribute_divisor.

2018-09-10 Thread Jason Ekstrand
I recommend CCing stable (I just did on mine) so that it goes into 18.2. On Mon, Sep 10, 2018 at 1:35 PM Bas Nieuwenhuizen wrote: > --- > src/amd/vulkan/radv_device.c | 7 +++ > src/amd/vulkan/radv_extensions.py | 2 +- > 2 files changed, 8 insertions(+), 1 deletion(-) > > diff --git

Re: [Mesa-dev] [PATCH 0/8] Gallium & RadeonSI optimization for Ryzen CPUs

2018-09-10 Thread Marek Olšák
On Mon, Sep 10, 2018 at 10:45 AM, Michel Dänzer wrote: > On 2018-09-07 9:01 p.m., Marek Olšák wrote: >> On Fri, Sep 7, 2018 at 11:04 AM, Michel Dänzer wrote: >>> On 2018-09-07 4:31 p.m., Marek Olšák wrote: On Fri, Sep 7, 2018, 4:34 AM Michel Dänzer wrote: > On 2018-09-06 10:56 p.m.,

[Mesa-dev] [PATCH] mesa: Validate the result of pipe_transfer_map in make_texture (v2)

2018-09-10 Thread Marek Olšák
From: Josh Pieper When using Freecad, I was getting intermittent segfaults inside of mesa. I traced it down to this path in st_cb_drawpixels.c where the result of pipe_transfer_map wasn't being checked. In my case, it was returning NULL because nouveau_bo_new returned ENOENT. I'm by no means

Re: [Mesa-dev] [PATCH] radv: Support v3 of VK_EXT_vertex_attribute_divisor.

2018-09-10 Thread Jason Ekstrand
On Mon, Sep 10, 2018 at 2:53 PM Bas Nieuwenhuizen wrote: > On Mon, Sep 10, 2018 at 8:59 PM Jason Ekstrand > wrote: > > > > I recommend CCing stable (I just did on mine) so that it goes into 18.2. > > You're right, added the CC in the commit when pushing. This has a > dependency on

[Mesa-dev] [PATCH 1/4] vl/dri: add 10 bits format supports

2018-09-10 Thread Leo Liu
v2: Tell B10G10R10X2 and R10G10B10X2 formats for different HW. Signed-off-by: Leo Liu --- src/gallium/auxiliary/vl/vl_winsys.h | 5 ++ src/gallium/auxiliary/vl/vl_winsys_dri.c | 69 2 files changed, 64 insertions(+), 10 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 1/4] vl/dri: add 10 bits format supports

2018-09-10 Thread Leo Liu
Forget the Patch 1, will re-send shortly. It's ming case 24: +vl_dri2_format_for_depth(struct vl_screen *vscreen, int depth) +{ + switch (depth) { + case 24: + case 30: Leo On 09/10/2018 04:27 PM, Leo Liu wrote: v2: Tell B10G10R10X2 and R10G10B10X2 formats for different HW.

Re: [Mesa-dev] [PATCH 2/4] gallium/auxiliary: don't dereference counters twice needlessly

2018-09-10 Thread Marek Olšák
On Mon, Sep 10, 2018 at 11:41 AM, Michel Dänzer wrote: > On 2018-09-07 11:35 p.m., Marek Olšák wrote: >> From: Marek Olšák >> >> +1.2% performance with: >> piglit/drawoverhead - DrawElements (no state changes) on radeonsi > > No meaningless number (which is most likely the same order of

Re: [Mesa-dev] [PATCH 2/2] anv: Support v3 of VK_EXT_vertex_attribute_divisor

2018-09-10 Thread Jason Ekstrand
This should go into 18.2 which means also back-porting the header update which shouldn't be a big deal. I have a feeling DXVK will add a hard requirement on v3 fairly shortly so it would be good if it works in released mesa. On Mon, Sep 10, 2018 at 1:44 PM Jason Ekstrand wrote: > On Mon, Sep

Re: [Mesa-dev] [PATCH] utils/u_math: break dependency on gallium/utils

2018-09-10 Thread Marek Olšák
On Mon, Sep 10, 2018 at 12:11 PM, Dylan Baker wrote: > I agree that using code from mesa in util is gross, I'm not planning to leave > it > like this. I'm in the middle of cleaning up duplication between util and mesa, > and I'll plan on pulling u_cpu_detection down into src/util in that series.

[Mesa-dev] VMware driver updates

2018-09-10 Thread Brian Paul
I've pushed a series of patches to update the VMware gallium driver. This adds support for MSAA and a few new extensions. See the docs/vmware-guest.html file for details. These features depend on the upcoming releases of VMware Workstation 15 and Fusion 11. -Brian

[Mesa-dev] [PATCH] nir: do not remove varyings used for transform feedback

2018-09-10 Thread Samuel Pitoiset
When a xfb buffer is explicitely declared on a varying variable, we shouldn't remove it at link time. Signed-off-by: Samuel Pitoiset --- src/compiler/nir/nir_linking_helpers.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/compiler/nir/nir_linking_helpers.c

Re: [Mesa-dev] [PATCH] android: util/u_thread: fix building error with bionic pthread

2018-09-10 Thread Marek Olšák
On Mon, Sep 10, 2018 at 4:07 AM, Mauro Rossi wrote: > Hi, > > Il giorno lun 10 set 2018 alle ore 09:58 Tapani Pälli > ha scritto: >> >> Marek sent a similar fix here: >> https://lists.freedesktop.org/archives/mesa-dev/2018-September/204797.html > > Thanks a lot! > So the APU L3 cache

Re: [Mesa-dev] [PATCH] radv: Support v3 of VK_EXT_vertex_attribute_divisor.

2018-09-10 Thread Bas Nieuwenhuizen
On Mon, Sep 10, 2018 at 8:59 PM Jason Ekstrand wrote: > > I recommend CCing stable (I just did on mine) so that it goes into 18.2. You're right, added the CC in the commit when pushing. This has a dependency on 34a17a48d440add1da619efd054b50b210cd869b, which hasn't been marked though. > > On

Re: [Mesa-dev] [PATCH] mesa: Validate the result of pipe_transfer_map in make_texture

2018-09-10 Thread Marek Olšák
Hi, thanks for the patch. I've sent version 2 of the patch with additional fixes to this list. Marek On Sun, Sep 9, 2018 at 10:08 PM, Josh Pieper wrote: > And apparently I am incapable of operating git send-email, so it > failed to include my context: > > When using Freecad, I was getting

[Mesa-dev] [PATCH 4/4] st/vdpau: Use output buffer as back buffer with 24-bit color only

2018-09-10 Thread Leo Liu
Using output buffer with 8 bits video RGB as back buffer certainly is not working for 30 bits color depth visual. Signed-off-by: Leo Liu Reviewed-by: Michel Dänzer --- src/gallium/state_trackers/vdpau/output.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 2/4] vl/dri3: add support for 10 bits format

2018-09-10 Thread Leo Liu
Signed-off-by: Leo Liu --- src/gallium/auxiliary/vl/vl_winsys_dri3.c | 29 +++ 1 file changed, 25 insertions(+), 4 deletions(-) diff --git a/src/gallium/auxiliary/vl/vl_winsys_dri3.c b/src/gallium/auxiliary/vl/vl_winsys_dri3.c index 8e3c4a0e04d..30e732e38eb 100644 ---

[Mesa-dev] [PATCH 3/4] vl/dri: add color depth to vl winsys

2018-09-10 Thread Leo Liu
For VDPAU use later Signed-off-by: Leo Liu Reviewed-by: Michel Dänzer --- src/gallium/auxiliary/vl/vl_winsys.h | 1 + src/gallium/auxiliary/vl/vl_winsys_dri3.c | 1 + 2 files changed, 2 insertions(+) diff --git a/src/gallium/auxiliary/vl/vl_winsys.h

Re: [Mesa-dev] [PATCH] mesa/texture: Also check for LA texture when querying intensity component size

2018-09-10 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Mon, Sep 10, 2018 at 6:39 AM, Gert Wollny wrote: > From: Gert Wollny > > Gallium may pick L16A16_FLOAT to represent GL_INTENSITY16F if no intensity > format is provided by the driver. However, when calling > >glGetTexLevelParameteriv(...,

Re: [Mesa-dev] [PATCH] mesa/texture: Also check for LA texture when querying intensity component size

2018-09-10 Thread Marek Olšák
I think you don't have to check luminance. Returning just the alpha bits should be fine. Marek On Mon, Sep 10, 2018 at 4:33 PM, Marek Olšák wrote: > Reviewed-by: Marek Olšák > > Marek > > On Mon, Sep 10, 2018 at 6:39 AM, Gert Wollny wrote: >> From: Gert Wollny >> >> Gallium may pick

[Mesa-dev] [PATCH 1/4] vl/dri: add 10 bits format supports

2018-09-10 Thread Leo Liu
v2: Tell B10G10R10X2 and R10G10B10X2 formats for different HW. Signed-off-by: Leo Liu --- src/gallium/auxiliary/vl/vl_winsys.h | 5 ++ src/gallium/auxiliary/vl/vl_winsys_dri.c | 70 2 files changed, 65 insertions(+), 10 deletions(-) diff --git

Re: [Mesa-dev] [PATCH v2] gallium: Correctly handle no config context creation

2018-09-10 Thread Marek Olšák
Pushed, thanks for the patch! Marek On Sat, Sep 8, 2018 at 11:57 PM, Elie Tournier wrote: > If you don't mind, can you please push this patch for me? > I don't have git access. > > Thanks a lot, > Elie > On Fri, 7 Sep 2018 at 22:49, Marek Olšák wrote: >> >> Reviewed-by: Marek Olšák >> >>

[Mesa-dev] [Bug 107869] u_thread.h:87:4: error: use of undeclared identifier 'cpu_set_t'

2018-09-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107869 Marek Olšák changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[Mesa-dev] [PATCH] anv: Bump the advertised patch version to 84

2018-09-10 Thread Jason Ekstrand
--- src/intel/vulkan/anv_extensions.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_extensions.py b/src/intel/vulkan/anv_extensions.py index 951505a854e..ea090dc3e5c 100644 --- a/src/intel/vulkan/anv_extensions.py +++

Re: [Mesa-dev] [RESEND PATCH 0/9] Partial redundancy elimination for compares

2018-09-10 Thread Ian Romanick
Bump On 08/29/2018 10:35 PM, Ian Romanick wrote: > This is mostly a resend of this series. Several patches, noted with > "v#", have been updated. > > Patches 3 and 4 are new. Right before sending the series, I decided to > update the shader-db results AND update shader-db. The update to >

Re: [Mesa-dev] [RFC 6/7] HACK: Disable the instruction scheduler

2018-09-10 Thread Jason Ekstrand
On Mon, Sep 10, 2018 at 5:33 PM Bas Nieuwenhuizen wrote: > On Mon, Sep 10, 2018 at 8:05 PM Jason Ekstrand > wrote: > > > > The instruction scheduler is re-ordering loads which is causing fence > > values to be loaded after the value they're fencing. In particular, > > consider the following

Re: [Mesa-dev] [RESEND PATCH 0/5] i965: More cmod propagation

2018-09-10 Thread Ian Romanick
Bump On 08/29/2018 11:40 AM, Ian Romanick wrote: > This is mostly a resend of a series that I originally sent out around > the end of June. I updated some of the shader-db results, and I dropped > one patch (i965/fs: Allow Boolean conditions in CSEL generation). I > decided that I want to try

[Mesa-dev] [Bug 107873] Doom 2016 - Rendering issues

2018-09-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107873 --- Comment #4 from Ahmed Elsayed --- I tried also Mesa 18.3 and I have the same problem. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the

[Mesa-dev] [PATCH] intel/icl: Fix URB size for different SKUs

2018-09-10 Thread Anuj Phogat
Different ICL SKUs have different URB sizes. Signed-off-by: Anuj Phogat --- src/intel/dev/gen_device_info.c | 43 ++--- 1 file changed, 29 insertions(+), 14 deletions(-) diff --git a/src/intel/dev/gen_device_info.c b/src/intel/dev/gen_device_info.c index

[Mesa-dev] [PATCH 00/11] intel/compiler: Optimize sign(x)*y

2018-09-10 Thread Ian Romanick
This series implements a code-generation optimization for sign(x)*y. In GLSL, sign(x) is defined as: Returns 1.0 if x > 0, 0.0 if x = 0, or -1.0 if x < 0. It is silent on the NaN behavior, so I have taken it as "undefined." I don't think the new implementation will produce different

[Mesa-dev] [PATCH 03/11] nir/algebraic: Simplify fsat of fsign

2018-09-10 Thread Ian Romanick
From: Ian Romanick These allows us to not support fsign.sat in the Intel compiler backend, and that will simplify some later changes. No shader-db changes on any Intel platform. Signed-off-by: Ian Romanick --- src/compiler/nir/nir_opt_algebraic.py | 1 + 1 file changed, 1 insertion(+) diff

[Mesa-dev] [PATCH 09/11] nir/algebraic: Recognize open-coded copysign(a, 1.0)

2018-09-10 Thread Ian Romanick
From: Ian Romanick All of the affected shaders are in Mad Max. The inner part of the pattern is itself an open-coded sign(a). I tried using that as a pattern, but the results were not good. A bunch of shaders were helped for instructions, but overall cycles, spill, and fills were hurt. All

[Mesa-dev] [PATCH 01/11] nir: Add helper functions to get the instruction that generated a nir_src

2018-09-10 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/compiler/nir/nir.h | 23 +++ 1 file changed, 23 insertions(+) diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h index bf4bd916d27..69ca1215644 100644 --- a/src/compiler/nir/nir.h +++ b/src/compiler/nir/nir.h

[Mesa-dev] [PATCH 06/11] i965/fs: Refactor code generation for nir_op_fsign to its own function

2018-09-10 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/intel/compiler/brw_fs.h | 1 + src/intel/compiler/brw_fs_nir.cpp | 154 +- 2 files changed, 103 insertions(+), 52 deletions(-) diff --git a/src/intel/compiler/brw_fs.h

[Mesa-dev] [PATCH 08/11] i965/fs: Generate better code for fsign multiplied by a value

2018-09-10 Thread Ian Romanick
From: Ian Romanick shader-db results: Broadwell and Skylake had similar results. (Skylake shown) total instructions in shared programs: 15105981 -> 15090997 (-0.10%) instructions in affected programs: 977852 -> 962868 (-1.53%) helped: 4531 HURT: 0 helped stats (abs) min: 1 max: 221 x̄: 3.31 x̃:

[Mesa-dev] [PATCH 07/11] i965/fs: Add a scale factor to emit_fsign

2018-09-10 Thread Ian Romanick
From: Ian Romanick Normally fsign generates -1, 0, or +1. The new scale factor, S, causes fsign to generate -S, 0, or +S. Signed-off-by: Ian Romanick --- src/intel/compiler/brw_fs.h | 3 +- src/intel/compiler/brw_fs_nir.cpp | 61 +++ 2 files

[Mesa-dev] [PATCH 11/11] nir/algebraic: Recognize open-coded fsign

2018-09-10 Thread Ian Romanick
From: Ian Romanick I don't intend to push this. The results are pretty horrifying. Broadwell total instructions in shared programs: 15387998 -> 15383192 (-0.03%) instructions in affected programs: 1223940 -> 1219134 (-0.39%) helped: 700 HURT: 63 helped stats (abs) min: 1 max: 81 x̄: 7.68 x̃: 5

[Mesa-dev] [PATCH 10/11] nir/algebraic: Replace a pattern where iand with a Boolean is used as a bcsel

2018-09-10 Thread Ian Romanick
From: Ian Romanick All of the affected shaders are in Mad Max. I noticed this while looking at some other things. I tried a couple similar patterns, but the affect on cycles was general negative. It may be worth revisiting this later. All Gen7+ platforms had similar results. (Skylake shown)

[Mesa-dev] [PATCH 02/11] nir/algebraic: sign(x)*x*x is abs(x)*x

2018-09-10 Thread Ian Romanick
From: Ian Romanick shader-db results: All Gen7+ platforms had similar results. (Skylake shown) total instructions in shared programs: 15106023 -> 15105981 (<.01%) instructions in affected programs: 300 -> 258 (-14.00%) helped: 6 HURT: 0 helped stats (abs) min: 7 max: 7 x̄: 7.00 x̃: 7 helped

[Mesa-dev] [PATCH 05/11] i965/fs: Eliminate dead code first

2018-09-10 Thread Ian Romanick
From: Ian Romanick This simplifies the later patch "i965/fs: Generate better code for fsign multiplied by a value". shader-db results: Broadwell and Skylake had similar results. (Skylake shown) total cycles in shared programs: 566050075 -> 566053975 (<.01%) cycles in affected programs: 1342167

[Mesa-dev] [PATCH 04/11] intel/compiler: Don't handle fsign.sat

2018-09-10 Thread Ian Romanick
From: Ian Romanick No shader-db or CI changes on any Intel platform. Signed-off-by: Ian Romanick --- src/intel/compiler/brw_fs_nir.cpp | 14 +- src/intel/compiler/brw_vec4_nir.cpp | 12 ++-- 2 files changed, 3 insertions(+), 23 deletions(-) diff --git

Re: [Mesa-dev] [RFC 6/7] HACK: Disable the instruction scheduler

2018-09-10 Thread Jason Ekstrand
On Mon, Sep 10, 2018 at 5:38 PM Ian Romanick wrote: > On 09/10/2018 11:04 AM, Jason Ekstrand wrote: > > The instruction scheduler is re-ordering loads which is causing fence > > values to be loaded after the value they're fencing. In particular, > > consider the following pseudocode: > > > >

  1   2   >