Re: [Mesa-dev] [PATCH] mesa: Prevent classic swrast crash on a surfaceless context v2.

Pushed that. Thanks! best Mathias On Monday, 27 May 2019 17:34:29 CEST Marek Olšák wrote: > Reviewed-by: Marek Olšák > > M. > > On Mon, May 27, 2019, 4:17 AM wrote: > > > From: Mathias Fröhlich > > > > Hi Emil, > > > > thanks for that hint to look at _mesa_get_incomplete_framebuffer. > >

Re: [Mesa-dev] [PATCH] gallivm: fix default cbuf info.

On Tue, 2019-05-28 at 02:08 +0200, Roland Scheidegger wrote: > Am 27.05.19 um 11:39 schrieb Juan A. Suarez Romero: > > On Fri, 2019-05-24 at 03:08 +0200, srol...@vmware.com wrote: > > > From: Roland Scheidegger > > > > > > The default null_output really needs to be static, otherwise the values >

Re: [Mesa-dev] [PATCH] radeon/uvd: fix poc for hevc encode

It would be better to have those checks in the state tracker than in the backend code. Christian. Am 27.05.19 um 20:41 schrieb boyuan.zh...@amd.com: From: Boyuan Zhang MaxPicOrderCntLsb should be at 16 according to the spec, therefore add minimum value check. Also use poc value passed from

Re: [Mesa-dev] [PATCH 1/7] radv: record if a render pass has depth/stencil resolve attachments

On 5/27/19 6:48 PM, Bas Nieuwenhuizen wrote: On Mon, May 27, 2019 at 5:38 PM Samuel Pitoiset wrote: Only supported with vkCreateRenderPass2(). Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_pass.c| 30 +- src/amd/vulkan/radv_private.h | 3 +++ 2

Re: [Mesa-dev] [PATCH] panfrost: Don't flip scanout

On 5/26/19 1:51 AM, Alyssa Rosenzweig wrote: The mesa/st flips the viewport, so we respect that rather than trying to flip the framebuffer itself and ignoring the viewport and using a messy heuristic. However, this brings an underlying disagreement about the interpretation of winding order to

[Mesa-dev] [PATCH 2/2] radv: use view format when selecting the resolve path for subpasses

Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_meta_resolve.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/src/amd/vulkan/radv_meta_resolve.c b/src/amd/vulkan/radv_meta_resolve.c index b4551a98637..2b97c42fc69 100644 ---

[Mesa-dev] [PATCH] radv: sync before resetting a pool if there is active pending queries

Make sure to sync all previous work if the given command buffer has pending active queries. Otherwise the GPU might write queries data after the reset operation. This fixes a bunch of new dEQP-VK.query_pool.* CTS failures. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c |

[Mesa-dev] [PATCH 1/2] radv: always use view format when performing subpass resolves

It makes sense to use the image view formats when resolving inside subpasses, while we have to use the image formats for normal resolves. Original patch by Philip Rebohle. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110348 Signed-off-by: Samuel Pitoiset ---

[Mesa-dev] [Bug 110357] [REGRESSION] [BISECTED] [OpenGL CTS] cts-runner --type=gl46 fails in new attempted "41" configuration

https://bugs.freedesktop.org/show_bug.cgi?id=110357 --- Comment #4 from Andrés Gómez García --- (In reply to Eric Engestrom from comment #3) > (In reply to Juan A. Suarez from comment #2) > > This bug is a blocker for 19.1.0. > > Is reverting dacb11a585 enough to fix the issue? > > If so, I'd

[Mesa-dev] [MR] Revert "egl: Add a 565 pbuffer-only EGL config under X11."

This reverts commit dacb11a5. The reason for introducing this change was to fulfill CTS's requirement to be able to run a 565-no-depth-no-stencil config for ES 3.0 on X11. Unfortunately, enabling this causes other problems. The most relevant one is that, for i965, CTS was passing for GL 4.5 and

[Mesa-dev] [Bug 110357] [REGRESSION] [BISECTED] [OpenGL CTS] cts-runner --type=gl46 fails in new attempted "41" configuration

https://bugs.freedesktop.org/show_bug.cgi?id=110357 --- Comment #5 from Andrés Gómez García --- https://gitlab.freedesktop.org/mesa/mesa/merge_requests/963 -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

[Mesa-dev] [PATCH] etnaviv: implement set_active_query_state(..) for hw queries

Clear w/ quad uses a normal draw which adds up to OQ. st/meta uses set_active_query_state(..) to tell the driver to pause queries in such cases. Fixes spec@arb_occlusion_query@occlusion_query_meta_save piglit. Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_query.c |

Re: [Mesa-dev] [PATCH 5/7] radv: decompress HTILE if the resolve src image is compressed

On Mon, May 27, 2019 at 5:38 PM Samuel Pitoiset wrote: > > It's required to decompress HTILE before resolving with the > compute path. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_meta_resolve.c | 26 ++ > 1 file changed, 26 insertions(+) > > diff --git

Re: [Mesa-dev] [PATCH 1/2] radv: always use view format when performing subpass resolves

Don't you also need to change it in the pipeline selection? (e.g. your newly added radv_get_resolve_pipeline()) Otherwise r-b for the eries. On Tue, May 28, 2019 at 11:02 AM Samuel Pitoiset wrote: > > It makes sense to use the image view formats when resolving > inside subpasses, while we have

[Mesa-dev] [Bug 110697] glXWaitForMscOML and glXWaitVideoSyncSGI may block indefinitely

https://bugs.freedesktop.org/show_bug.cgi?id=110697 QwertyChouskie changed: What|Removed |Added Keywords||regression --- Comment #6 from

Re: [Mesa-dev] [PATCH 1/7] radv: record if a render pass has depth/stencil resolve attachments

That seems OK. On Tue, May 28, 2019 at 8:25 AM Samuel Pitoiset wrote: > > > On 5/27/19 6:48 PM, Bas Nieuwenhuizen wrote: > > On Mon, May 27, 2019 at 5:38 PM Samuel Pitoiset > > wrote: > >> Only supported with vkCreateRenderPass2(). > >> > >> Signed-off-by: Samuel Pitoiset > >> --- > >>

Re: [Mesa-dev] [PATCH] radv: sync before resetting a pool if there is active pending queries

r-b On Tue, May 28, 2019 at 11:05 AM Samuel Pitoiset wrote: > > Make sure to sync all previous work if the given command buffer > has pending active queries. Otherwise the GPU might write queries > data after the reset operation. > > This fixes a bunch of new dEQP-VK.query_pool.* CTS failures. >

[Mesa-dev] [PATCH] st/glsl: make sure to propagate initialisers to driver storage

This essentially reverts 20234cfe3a20. Fixes piglit test: tests/spec/arb_get_program_binary/execution/uniform-after-restore.shader_test Fixes: 20234cfe3a20 "st/mesa: don't propagate uniforms when restoring from cache" Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110784 ---

Re: [Mesa-dev] [PATCH] list: add some iterator debug

On Mon, May 27, 2019 at 5:06 AM Rob Clark wrote: > > On Mon, May 27, 2019 at 4:39 AM Erik Faye-Lund > wrote: > > > > On Mon, 2019-05-27 at 13:37 +0200, Erik Faye-Lund wrote: > > > On Mon, 2019-05-27 at 04:23 -0700, Rob Clark wrote: > > > > On Mon, May 27, 2019 at 2:50 AM Erik Faye-Lund > > > >

[Mesa-dev] [Bug 110760] Low FPS in Quake Champions with Vega20

https://bugs.freedesktop.org/show_bug.cgi?id=110760 --- Comment #3 from network...@rkmail.ru --- (In reply to Samuel Pitoiset from comment #2) > Not sure what's your expectation about Radeon VII but on my Vega 56, I get > more than 110FPS in Ultra at 4K. This seems *quite* acceptable to me. Well,

[Mesa-dev] [Bug 110760] Low FPS in Quake Champions with Vega20

https://bugs.freedesktop.org/show_bug.cgi?id=110760 --- Comment #2 from Samuel Pitoiset --- Not sure what's your expectation about Radeon VII but on my Vega 56, I get more than 110FPS in Ultra at 4K. This seems *quite* acceptable to me. Btw, the assertion noticed by Tim is fixed with

[Mesa-dev] [Bug 110760] Low FPS in Quake Champions with Vega20

https://bugs.freedesktop.org/show_bug.cgi?id=110760 --- Comment #4 from Samuel Pitoiset --- Make sure to use latest Proton (4.2-5). -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___

Re: [Mesa-dev] [PATCH] radv: allocate more space in the CS when emitting events

r-b On Tue, May 28, 2019 at 12:54 PM Samuel Pitoiset wrote: > > If the driver waits for CP DMA to be idle and emit an EOP event > we need more space. > > This fixes a crash with Quake Champions. > > Cc: > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_cmd_buffer.c | 2 +- > 1 file

Re: [Mesa-dev] [PATCH 00/13] panfrost/midgard: RA improvements (esp. RA)

Patch Series Reviewed-By: Ryan Houdek On Sat, May 25, 2019 at 7:39 PM Alyssa Rosenzweig wrote: > This fairly-lengthy series is focused on improving the register > allocator and by extension the performance of the generated code. > Meanwhile, we cleanup the compiler, refactoring as we go,

[Mesa-dev] [PATCH] radv: allocate more space in the CS when emitting events

If the driver waits for CP DMA to be idle and emit an EOP event we need more space. This fixes a crash with Quake Champions. Cc: Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Mesa-dev] [Bug 110760] Low FPS in Quake Champions with Vega20

https://bugs.freedesktop.org/show_bug.cgi?id=110760 --- Comment #5 from network...@rkmail.ru --- (In reply to Samuel Pitoiset from comment #4) > Make sure to use latest Proton (4.2-5). I'm absolutely sure I already had 4.2-5 when I originally reported the bug. -- You are receiving this mail