Use the alternative more accurate expression from
https://en.wikipedia.org/wiki/Division_algorithm#Newton%E2%80%93Raphson_division
Tested by enabling this code path, and running gloss mesa demo.
---
src/gallium/auxiliary/gallivm/lp_bld_arit.c | 9 +
1 file changed, 5 insertions(+), 4
Hi Chih-Wei,
On Mon, Jun 24, 2019 at 7:26 AM Chih-Wei Huang
wrote:
> Mauro Rossi 於 2019年6月22日 週六 上午2:06寫道：
> >
> > Changelog in Android makefile:
> > - Add LOCAL_MODULE_CLASS, intermediates and LOCAL_GENERATED_SOURCES
> > - Use LOCAL_EXPORT_C_INCLUDE_DIRS to export $(intermediates) path
> > -
On 6/24/19 9:51 PM, Simon Ser wrote:
gbm_{bo,surface}_create_with_modifiers is missing the usage flags. Add a new
function which lets library users specify it.
Signed-off-by: Simon Ser
---
src/gbm/main/gbm.c | 38 ++
src/gbm/main/gbm.h | 17
Hi,
On Mon, 24 Jun 2019 at 19:51, Simon Ser wrote:
> +GBM_EXPORT struct gbm_bo *
> +gbm_bo_create_with_modifiers2(struct gbm_device *gbm,
> + uint32_t width, uint32_t height,
> + uint32_t format,
> + const
Hi,
On Tue, 25 Jun 2019 at 07:26, Simon Ser wrote:
> > I noticed that original patch (v1) for gbm_bo_create_with_modifiers did
> > have usage at first but it was removed during the review. I'm having
> > trouble digging what was the reason for this?
>
> I'm not sure either. Daniel said it was a
> > +struct gbm_bo *
> > +gbm_bo_create_with_modifiers2(struct gbm_device *gbm,
> > + uint32_t width, uint32_t height,
> > + uint32_t format,
> > + const uint64_t *modifiers,
> > +
When the fault_pointer field in the header is set, we can get some idea
of which descriptor the HW isn't happy with if we know their addresses.
Signed-off-by: Tomeu Vizoso
---
.../drivers/panfrost/pandecode/decode.c | 24 +--
1 file changed, 11 insertions(+), 13
Hi,
On Mon, Jun 24, 2019 at 8:55 AM Chih-Wei Huang
wrote:
> Mauro Rossi 於 2019年6月15日 週六 下午1:39寫道：
> >
> > Fixes the following building errors and resolves Bug 110922
> > Fixes gallium_dri target missing symbols at linking.
> >
> > external/mesa/src/gallium/winsys/virgl/drm/Android.mk:
> >
It works, thank you!
At 2019-06-24 16:17:41, "Eric Engestrom" wrote:
>On 2019-06-24 at 08:21, cloudwin wrote:
>> Hi
>> I used to build radeonsi drivers, like radeonsi_dri.so and
>> radeonsi_drv_video.so by autogen in old version mesa, but when I switch
>> to meson which is the only way
Arm's kernel driver mentions how to decode this field, which makes a bit
clearer what had happened.
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/pandecode/decode.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/pandecode/decode.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/gallium/drivers/panfrost/pandecode/decode.c
b/src/gallium/drivers/panfrost/pandecode/decode.c
index 7f58ad033669..d468e10140b7 100644
---
Then we can get some information back about any exception that might
have happened.
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/pan_drm.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/gallium/drivers/panfrost/pan_drm.c
Mesa 19.1.1 is now available.
In this release we have:
Mostly in fixes for different drivers (RADV, ANV,
Nouveau, Virgl, V3D, R300g, ...)
Also different fixes for different parts (Meson build, GLX,
etc).
Alejandro Piñeiro (1):
v3d: fix checking twice auf flag
Bas Nieuwenhuizen (5):
https://bugs.freedesktop.org/show_bug.cgi?id=110921
Juan A. Suarez changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
Add libmesa_nir to a common LOCAL_STATIC_LIBRARIES defined by
ANV_STATIC_LIBRARIES so that its include path can be imported
automatically. Then ANV_INCLUDES is unnecessary and could be
eliminated.
Signed-off-by: Chih-Wei Huang
---
src/intel/Android.vulkan.mk | 36
The vulkan module is the final HAL. No need to export its headers
since none will import it.
Signed-off-by: Chih-Wei Huang
---
src/amd/vulkan/Android.mk | 4
1 file changed, 4 deletions(-)
diff --git a/src/amd/vulkan/Android.mk b/src/amd/vulkan/Android.mk
index 0725fea..a7c31d4 100644
---
The libmesa_anv_entrypoints and libmesa_genxml are dummy libraries.
There is no reason to put them into LOCAL_WHOLE_STATIC_LIBRARIES.
Move libmesa_vulkan_util to the vulkan HAL which really needs it.
Signed-off-by: Chih-Wei Huang
---
src/intel/Android.vulkan.mk | 18 +-
1 file
It's unnecessary to manually add these include paths since they could
be imported automatically.
Signed-off-by: Chih-Wei Huang
---
src/amd/vulkan/Android.mk | 16 +---
1 file changed, 5 insertions(+), 11 deletions(-)
diff --git a/src/amd/vulkan/Android.mk
Export the correct include path so that the libraries use it can
get it automatically.
Signed-off-by: Chih-Wei Huang
---
src/amd/vulkan/Android.mk | 1 -
src/intel/Android.vulkan.mk | 1 -
src/vulkan/Android.mk | 3 +--
3 files changed, 1 insertion(+), 4 deletions(-)
diff --git
The vulkan module is the final HAL. No need to export its headers
since none will import it.
Signed-off-by: Chih-Wei Huang
---
src/intel/Android.vulkan.mk | 2 --
1 file changed, 2 deletions(-)
diff --git a/src/intel/Android.vulkan.mk b/src/intel/Android.vulkan.mk
index 3c257e5..8d978c3 100644
Hi,
On 24.6.2019 19.36, Elie Tournier wrote:
Great topic. For the past few days, I was looking at a CI for Mesa:
https://gitlab.freedesktop.org/hopetech/tracie
OK, it's in a very very alpha stage. ;)
My idea was to use apitrace to dump and replay traces then compare images with
reference
This series is:
Reviewed-by: Alyssa Rosenzweig
---
I will caution you about the fault_pointer -- it doesn't do what you
think it does. I once spent about a week chasing a bug in the FBD, since
that's what the fault_pointer said. It was in the mali_viewport. It was
the right *job* -- still the
The libmesa_git_sha1 is a dummy library. There is no reason to put
it into LOCAL_WHOLE_STATIC_LIBRARIES.
Move libmesa_vulkan_util to the vulkan.radv which really needs it.
Signed-off-by: Chih-Wei Huang
---
src/amd/vulkan/Android.mk | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
The dummy library libmesa_anv_entrypoints is totally unnecessary.
The four VULKAN_GENERATED_FILES could be generated and built in
libmesa_vulkan_common directly. The libraries using the generated
headers should get it via the exported include path.
Signed-off-by: Chih-Wei Huang
---
There are several issues in the current Android makefiles. Though they
may not affect the functionalities, it's ugly and unprofessional.
* Add unnecessary LOCAL_EXPORT_C_INCLUDE_DIRS
* Not export necessary include paths
* Add dummy libraries to LOCAL_WHOLE_STATIC_LIBRARIES
* Use unnecessary dummy
Mauro Rossi 於 2019年6月25日 週二 下午5:52寫道：
>
> Hi,
>
> On Mon, Jun 24, 2019 at 8:55 AM Chih-Wei Huang
> wrote:
>>
>> Mauro Rossi 於 2019年6月15日 週六 下午1:39寫道：
>> >
>> > Fixes the following building errors and resolves Bug 110922
>> > Fixes gallium_dri target missing symbols at linking.
>> >
>> >
On 6/25/19 1:38 AM, Bas Nieuwenhuizen wrote:
why?
We should be regulating enabling it with S_028C70_DCC_ENABLE.
Correct. Please ignore this patch, it's not wrong, just useless.
On Mon, Jun 24, 2019 at 5:00 PM Samuel Pitoiset
wrote:
CB_DCC_BASE should be 0 if no DCC.
Signed-off-by: Samuel
https://bugs.freedesktop.org/show_bug.cgi?id=110995
Bug ID: 110995
Summary: performance regression in Heroes of the Storm with
Mesa 19.1.1 & Polaris
Product: Mesa
Version: 19.1
Hardware: x86-64 (AMD64)
OS:
Ported from RadeonSI, will be emitted for GFX10 too.
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_cmd_buffer.c | 5 -
src/amd/vulkan/radv_device.c | 2 ++
src/amd/vulkan/radv_private.h| 3 +++
3 files changed, 9 insertions(+), 1 deletion(-)
diff --git
https://bugs.freedesktop.org/show_bug.cgi?id=95022
--- Comment #7 from Glenda Rolfson ---
Special educator job is not a simple job rather it requires more patience as
compared to any other job. Coping https://penzu.com/public/64b7c502 and the
special needs of students requires a lot of patience.
r-b
On Tue, Jun 25, 2019 at 4:13 PM Samuel Pitoiset
wrote:
>
> Ported from RadeonSI, will be emitted for GFX10 too.
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_cmd_buffer.c | 5 -
> src/amd/vulkan/radv_device.c | 2 ++
> src/amd/vulkan/radv_private.h| 3 +++
> 3
https://bugs.freedesktop.org/show_bug.cgi?id=110995
--- Comment #1 from Samuel Pitoiset ---
Can you try to revert 410759091173fa61436ba46baeb20a79d5767849 ?
Btw, 158 vs 168 is really a small diff.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee
On Tue, Jun 25, 2019 at 4:04 AM Daniel Stone wrote:
> Hi,
>
> On Tue, 25 Jun 2019 at 07:26, Simon Ser wrote:
> > > I noticed that original patch (v1) for gbm_bo_create_with_modifiers did
> > > have usage at first but it was removed during the review. I'm having
> > > trouble digging what was
Looks good to me, albeit it's potentially minimally slower, so I'm
wondering if the higher precision is actually useful?
I guess though the last two steps could use lp_build_fmuladd?
Reviewed-by: Roland Scheidegger
Am 25.06.19 um 11:17 schrieb Jose Fonseca:
> Use the alternative more accurate
Hi,
On Tue, 25 Jun 2019 at 16:07, Jason Ekstrand wrote:
> On Tue, Jun 25, 2019 at 4:04 AM Daniel Stone wrote:
>> On Tue, 25 Jun 2019 at 07:26, Simon Ser wrote:
>> > > I noticed that original patch (v1) for gbm_bo_create_with_modifiers did
>> > > have usage at first but it was removed during
SMEM and VMEM caches are L0 on gfx10. Ported from RadeonSI.
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_cmd_buffer.c| 16 -
src/amd/vulkan/radv_device.c| 12 +++
src/amd/vulkan/radv_meta_buffer.c | 4 +--
src/amd/vulkan/radv_meta_clear.c
r-b
On Tue, Jun 25, 2019 at 5:54 PM Samuel Pitoiset
wrote:
>
> SMEM and VMEM caches are L0 on gfx10. Ported from RadeonSI.
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_cmd_buffer.c| 16 -
> src/amd/vulkan/radv_device.c| 12 +++
>
This is an attempt at resurrecting Daniel's MR [1] which was already
resurrecting Harish's EGL_KHR_partial_update series [2]. This version
implements Marek's suggestion to pass the set_damage_region() directly
to the gallium driver and let it decide how to handle the request. Some
drivers might
From: Harish Krupo
The intension of the KHR_partial_update was not to send the damage back
to the platform but to send the damage to the driver to ensure that the
following rendering could be restricted to those regions.
This patch removes the set_damage_region from the egl_dri vtbl and all
the
From: Harish Krupo
Use the DRI2 interface callback to pass the damage rects to
the driver.
Signed-off-by: Harish Krupo
Signed-off-by: Boris Brezillon
---
src/egl/drivers/dri2/egl_dri2.c | 55 ++---
src/egl/drivers/dri2/egl_dri2.h | 1 +
2 files changed, 51
From: Daniel Stone
Add a pipe_screen->set_damage_region() hook to propagate
set-damage-region requests to the driver, it's then up to the driver to
decide what to do with this piece of information.
If the hook is left unassigned, the buffer-damage extension is
considered unsupported.
On Tue, 25 Jun 2019 18:37:46 +0200
Boris Brezillon wrote:
> From: Daniel Stone
>
> Add a new DRI2_BufferDamage interface to support the
> EGL_KHR_partial_update extension, informing the driver of an overriding
> scissor region for a particular drawable.
>
> Based on a commit originally
Elie Tournier writes:
> On Mon, Jun 24, 2019 at 11:41:55AM -0700, Eric Anholt wrote:
>> Elie Tournier writes:
>>
>> > Hi there,
>> >
>> > Great topic. For the past few days, I was looking at a CI for Mesa:
>> > https://gitlab.freedesktop.org/hopetech/tracie
>> > OK, it's in a very very alpha
Implement ->set_damage_region() region to support partial updates.
This is a dummy implementation in that it does not try to merge
damage rects. It also does not deal with distinct regions and instead
pick the largest quad as the only damage rect and generate up to 4
reload rects out of it (the
Daniel Stone writes:
> Hi,
>
> On Tue, 25 Jun 2019 at 16:07, Jason Ekstrand wrote:
>> On Tue, Jun 25, 2019 at 4:04 AM Daniel Stone wrote:
>>> On Tue, 25 Jun 2019 at 07:26, Simon Ser wrote:
>>> > > I noticed that original patch (v1) for gbm_bo_create_with_modifiers did
>>> > > have usage at
From: Daniel Stone
Add a new DRI2_BufferDamage interface to support the
EGL_KHR_partial_update extension, informing the driver of an overriding
scissor region for a particular drawable.
Based on a commit originally authored by:
Harish Krupo
renamed extension, retargeted at DRI drawable instead
On Tue, 25 Jun 2019 at 17:46, Boris Brezillon
wrote:
> On Tue, 25 Jun 2019 18:37:46 +0200 Boris Brezillon
> wrote:
> > Add a new DRI2_BufferDamage interface to support the
> > EGL_KHR_partial_update extension, informing the driver of an overriding
> > scissor region for a particular drawable.
>
I needed this patch today so I've pushed it. FYI, we do have MRs for
shader-db which are a bit easier to find than a needle in the hay-stack
that is mesa-dev.
--Jason
On Fri, Jun 7, 2019 at 11:27 AM Emil Velikov
wrote:
> On Fri, 7 Jun 2019 at 00:30, Ian Romanick wrote:
> >
> > From: Ian
https://bugs.freedesktop.org/show_bug.cgi?id=110995
--- Comment #2 from tempel.jul...@gmail.com ---
It's an additional loss on top of DXVK vs. native D3D11 performance, so it sums
up to something worse. :)
I could bisect it to this commit:
Hi Alyssa,
On Tue, 25 Jun 2019 at 19:54, Alyssa Rosenzweig
wrote:
> @@ -2,6 +2,7 @@
> * Copyright (c) 2011-2013 Luc Verhaegen
> * Copyright (c) 2018 Alyssa Rosenzweig
> * Copyright (c) 2018 Vasily Khoruzhick
> + * Copyright (c) 2019 Collabora
Please use 'Collabora, Ltd.' as that's our
Rather than using a magic lookup table with no explanations, let's add
liberal comments to the code to explain what this tiling scheme is and
how to encode/decode it efficiently.
It's not so mysterious after all -- just reordering bits with some XORs
thrown in.
Signed-off-by: Alyssa Rosenzweig
Rather than using a magic lookup table with no explanations, let's add
liberal comments to the code to explain what this tiling scheme is and
how to encode/decode it efficiently.
It's not so mysterious after all -- just reordering bits with some XORs
thrown in.
v2: Correct copyright identifier.
"Collabora, Ltd." should be listed in lieu of simply "Collabora"
Signed-off-by: Alyssa Rosenzweig
Suggested-by: Daniel Stone
---
src/gallium/drivers/panfrost/include/panfrost-job.h| 2 +-
src/gallium/drivers/panfrost/midgard/midgard_ra.c | 2 +-
On 6/25/19 10:23 AM, Jason Ekstrand wrote:
> I needed this patch today so I've pushed it. FYI, we do have MRs for
> shader-db which are a bit easier to find than a needle in the hay-stack
> that is mesa-dev.
Ah... that's good to know. After I sent this patch, I completely forgot
about it. :)
>
On Tuesday, 2019-06-25 18:08:29 +0800, Chih-Wei Huang wrote:
> The libmesa_anv_entrypoints and libmesa_genxml are dummy libraries.
> There is no reason to put them into LOCAL_WHOLE_STATIC_LIBRARIES.
>
> Move libmesa_vulkan_util to the vulkan HAL which really needs it.
>
> Signed-off-by: Chih-Wei
https://bugs.freedesktop.org/show_bug.cgi?id=107822
Alexander Vereeken changed:
What|Removed |Added
Status|REOPENED|RESOLVED
Resolution|---
56 matches
Mail list logo
