Re: [Mesa-dev] [PATCH v3 1/4] drm/i915/uapi: hide kernel doc warnings

2021-04-16 Thread Daniel Vetter
On Fri, Apr 16, 2021 at 10:44:28AM +0200, Daniel Vetter wrote: > On Thu, Apr 15, 2021 at 04:59:55PM +0100, Matthew Auld wrote: > > It's not properly formatted kernel doc, just nerf the warnings for now. > > > > Signed-off-by: Matthew Auld > > Cc: Joonas Lahtinen > > Cc: Jordan Justen > > Cc:

Re: [Mesa-dev] [PATCH v3 3/4] drm/i915/uapi: convert i915_query and friend to kernel doc

2021-04-16 Thread Daniel Vetter
On Fri, Apr 16, 2021 at 12:25 AM Ian Romanick wrote: > On 4/15/21 8:59 AM, Matthew Auld wrote: > > Add a note about the two-step process. > > > > Suggested-by: Daniel Vetter > > Signed-off-by: Matthew Auld > > Cc: Joonas Lahtinen > > Cc: Jordan Justen > > Cc: Daniel Vetter > > Cc: Kenneth

Re: [Mesa-dev] [PATCH v3 4/4] drm/doc/rfc: i915 DG1 uAPI

2021-04-16 Thread Daniel Vetter
On Thu, Apr 15, 2021 at 04:59:58PM +0100, Matthew Auld wrote: > Add an entry for the new uAPI needed for DG1. > > v2(Daniel): > - include the overall upstreaming plan > - add a note for mmap, there are differences here for TTM vs i915 > - bunch of other suggestions from Daniel > v3: >

[Mesa-dev] [PATCH 4/4] drm/i915/uapi: convert i915_query and friend to kernel doc

2021-04-16 Thread Matthew Auld
Add a note about the two-step process. v2(Tvrtko): - Also document the other method of just passing in a buffer which is large enough, which avoids two ioctl calls. Can make sense for smaller query items. Suggested-by: Daniel Vetter Signed-off-by: Matthew Auld Cc: Joonas Lahtinen

[Mesa-dev] [PATCH 3/4] drm/i915/uapi: convert i915_user_extension to kernel doc

2021-04-16 Thread Matthew Auld
Add some example usage for the extension chaining also, which is quite nifty. v2: (Daniel) - clarify that the name is just some integer, also document that the name space is not global Suggested-by: Daniel Vetter Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Jordan Justen Cc:

[Mesa-dev] [PATCH 1/4] drm/i915/uapi: fix kernel doc warnings

2021-04-16 Thread Matthew Auld
Fix the cases where it is almost already valid kernel doc, for the others just nerf the warnings for now. Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Jordan Justen Cc: Daniel Vetter Cc: Kenneth Graunke Cc: Jason Ekstrand Cc: Dave Airlie Cc: dri-de...@lists.freedesktop.org Cc:

[Mesa-dev] [PATCH 2/4] drm/doc: add section for driver uAPI

2021-04-16 Thread Matthew Auld
Add section for drm/i915 uAPI and pull in i915_drm.h. Suggested-by: Daniel Vetter Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Jordan Justen Cc: Daniel Vetter Cc: Kenneth Graunke Cc: Jason Ekstrand Cc: Dave Airlie Cc: dri-de...@lists.freedesktop.org Cc:

Re: [Mesa-dev] [PATCH v3 1/4] drm/i915/uapi: hide kernel doc warnings

2021-04-16 Thread Daniel Vetter
On Thu, Apr 15, 2021 at 04:59:55PM +0100, Matthew Auld wrote: > It's not properly formatted kernel doc, just nerf the warnings for now. > > Signed-off-by: Matthew Auld > Cc: Joonas Lahtinen > Cc: Jordan Justen > Cc: Daniel Vetter > Cc: Kenneth Graunke > Cc: Jason Ekstrand > Cc: Dave Airlie

Re: [Mesa-dev] [PATCH v3 3/4] drm/i915/uapi: convert i915_query and friend to kernel doc

2021-04-16 Thread Daniel Vetter
On Thu, Apr 15, 2021 at 04:59:57PM +0100, Matthew Auld wrote: > Add a note about the two-step process. > > Suggested-by: Daniel Vetter > Signed-off-by: Matthew Auld > Cc: Joonas Lahtinen > Cc: Jordan Justen > Cc: Daniel Vetter > Cc: Kenneth Graunke > Cc: Jason Ekstrand > Cc: Dave Airlie >

Re: [Mesa-dev] [PATCH v3 4/4] drm/doc/rfc: i915 DG1 uAPI

2021-04-16 Thread Jason Ekstrand
On Thu, Apr 15, 2021 at 11:04 AM Matthew Auld wrote: > > Add an entry for the new uAPI needed for DG1. > > v2(Daniel): > - include the overall upstreaming plan > - add a note for mmap, there are differences here for TTM vs i915 > - bunch of other suggestions from Daniel > v3: > (Daniel) >

Re: [Mesa-dev] [PATCH v3 2/4] drm/i915/uapi: convert i915_user_extension to kernel doc

2021-04-16 Thread Daniel Vetter
On Thu, Apr 15, 2021 at 04:59:56PM +0100, Matthew Auld wrote: > Add some example usage for the extension chaining also, which is quite > nifty. > > Suggested-by: Daniel Vetter > Signed-off-by: Matthew Auld > Cc: Joonas Lahtinen > Cc: Jordan Justen > Cc: Daniel Vetter > Cc: Kenneth Graunke >

Re: [Mesa-dev] [PATCH 2/4] drm/doc: add section for driver uAPI

2021-04-16 Thread Daniel Vetter
On Fri, Apr 16, 2021 at 12:37 PM Matthew Auld wrote: > > Add section for drm/i915 uAPI and pull in i915_drm.h. > > Suggested-by: Daniel Vetter > Signed-off-by: Matthew Auld > Cc: Joonas Lahtinen > Cc: Jordan Justen > Cc: Daniel Vetter > Cc: Kenneth Graunke > Cc: Jason Ekstrand > Cc: Dave

Re: [Mesa-dev] [PATCH 3/4] drm/i915/uapi: convert i915_user_extension to kernel doc

2021-04-16 Thread Jason Ekstrand
On April 16, 2021 05:37:52 Matthew Auld wrote: Add some example usage for the extension chaining also, which is quite nifty. v2: (Daniel) - clarify that the name is just some integer, also document that the name space is not global Suggested-by: Daniel Vetter Signed-off-by: Matthew Auld

Re: [Mesa-dev] [PATCH 4/4] drm/i915/uapi: convert i915_query and friend to kernel doc

2021-04-16 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On April 16, 2021 05:37:55 Matthew Auld wrote: Add a note about the two-step process. v2(Tvrtko): - Also document the other method of just passing in a buffer which is large enough, which avoids two ioctl calls. Can make sense for smaller query items.

Re: [Mesa-dev] [PATCH v3 4/4] drm/doc/rfc: i915 DG1 uAPI

2021-04-16 Thread Daniel Vetter
On Fri, Apr 16, 2021 at 6:38 PM Jason Ekstrand wrote: > > On Thu, Apr 15, 2021 at 11:04 AM Matthew Auld wrote: > > > > Add an entry for the new uAPI needed for DG1. > > > > v2(Daniel): > > - include the overall upstreaming plan > > - add a note for mmap, there are differences here for TTM vs

Re: [Mesa-dev] [Intel-gfx] [PATCH v3 3/4] drm/i915/uapi: convert i915_query and friend to kernel doc

2021-04-16 Thread Tvrtko Ursulin
On 15/04/2021 16:59, Matthew Auld wrote: Add a note about the two-step process. Suggested-by: Daniel Vetter Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Jordan Justen Cc: Daniel Vetter Cc: Kenneth Graunke Cc: Jason Ekstrand Cc: Dave Airlie Cc: dri-de...@lists.freedesktop.org