Re: [Mesa-dev] [PATCH 12/21] mesa: Remove GL_MESA_resize_buffers

2013-06-28 Thread Andreas Boll
I think you might squash the attached diff into your patch. Andreas. 2013/6/28 Ian Romanick i...@freedesktop.org From: Ian Romanick ian.d.roman...@intel.com Commit bab755a made the implementation a no-op, and it was only ever enabled by software rasterizers. Signed-off-by: Ian Romanick

[Mesa-dev] [Bug 66149] [HSW] Background of application icon has garbage after update kernelmesa in order to support Graphics [8086: 0a2e]

2013-06-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=66149 Gordon Jin gordon@intel.com changed: What|Removed |Added Status|NEEDINFO|RESOLVED

[Mesa-dev] [Bug 66149] [HSW] Background of application icon has garbage after update kernelmesa in order to support Graphics [8086: 0a2e]

2013-06-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=66149 --- Comment #6 from Andreas Boll andreas.boll@gmail.com --- (In reply to comment #4) The issue can't be reproduced with 9.1 branch. When will 9.1.4 release? Thanks! It's planned to be released on monday.

[Mesa-dev] [Bug 56710] src/mapi/glapi/glapitemp.h:1640:1: warning: no previous prototype for ‘glReadBufferNV’ [-Wmissing-prototypes]

2013-06-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=56710 --- Comment #14 from Jon TURNEY jon.tur...@dronecode.org.uk --- (In reply to comment #13) Could you still reproduce this bug? Appears to be fixed to me. -- You are receiving this mail because: You are the QA Contact for the bug.

[Mesa-dev] [PATCH] build: fix out-of-tree builds in gallium/auxiliary

2013-06-28 Thread Ross Burton
The rules were writing files to e.g. util/u_indices_gen.py, but in an out-of-tree build this directory doesn't exist in the build directory. So, create the directories just in case. Note: This patch is a candidate for the 9.0 and 9.1 branches. Signed-off-by: Ross Burton ross.bur...@intel.com

Re: [Mesa-dev] [PATCH 01/21] i915: Remove GEN = 4 extension support

2013-06-28 Thread Kenneth Graunke
On 06/27/2013 06:20 PM, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com This copy of the source file is only used for GEN = 3, so remove the dead code. Signed-off-by: Ian Romanick ian.d.roman...@intel.com --- src/mesa/drivers/dri/i915/intel_extensions.c | 79

[Mesa-dev] [Bug 56710] src/mapi/glapi/glapitemp.h:1640:1: warning: no previous prototype for ‘glReadBufferNV’ [-Wmissing-prototypes]

2013-06-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=56710 Andreas Boll andreas.boll@gmail.com changed: What|Removed |Added Status|ASSIGNED|RESOLVED

Re: [Mesa-dev] [PATCH] build: fix out-of-tree builds in gallium/auxiliary

2013-06-28 Thread Andreas Boll
2013/6/28 Ross Burton ross.bur...@intel.com The rules were writing files to e.g. util/u_indices_gen.py, but in an out-of-tree build this directory doesn't exist in the build directory. So, create the directories just in case. Note: This patch is a candidate for the 9.0 and 9.1 branches. I

[Mesa-dev] [PATCH][V2] build: fix out-of-tree builds in gallium/auxiliary

2013-06-28 Thread Ross Burton
The rules were writing files to e.g. util/u_indices_gen.py, but in an out-of-tree build this directory doesn't exist in the build directory. So, create the directories just in case. Note: This patch is a candidate for the 9.0 and 9.1 branches. Signed-off-by: Ross Burton ross.bur...@intel.com

Re: [Mesa-dev] [PATCH 19/21] mesa: GL_ARB_texture_storage is not optional

2013-06-28 Thread Brian Paul
On 06/27/2013 07:20 PM, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com In Mesa, this extension is implemented purely in software. Drivers may *optionally* provide optimized paths. NOTE: This has the side effect of enabling the extension in the radeon, r200, and nouveau

Re: [Mesa-dev] [PATCH 00/21] Extension clean up

2013-06-28 Thread Brian Paul
On 06/27/2013 07:20 PM, Ian Romanick wrote: This is my annual extension clean up blob. I don't expect much here to be controversial (or even interesting to read) except patches 12, 17, 18, and 21. LGTM. Just a minor formatting comment on #19. And I second Kenneth's comment on #20. For

Re: [Mesa-dev] [PATCH][V2] build: fix out-of-tree builds in gallium/auxiliary

2013-06-28 Thread Andreas Boll
There is an open bug report about this issue: https://bugs.freedesktop.org/show_bug.cgi?id=60197 Matt, could you take a look at this? Which patch do you prefer? 2013/6/28 Ross Burton ross.bur...@intel.com The rules were writing files to e.g. util/u_indices_gen.py, but in an out-of-tree build

[Mesa-dev] [PATCH 2/2] svga: pass svga_compile_key by reference instead of value

2013-06-28 Thread Brian Paul
--- src/gallium/drivers/svga/svga_tgsi.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/gallium/drivers/svga/svga_tgsi.c b/src/gallium/drivers/svga/svga_tgsi.c index 56529c6..29fbe84 100644 --- a/src/gallium/drivers/svga/svga_tgsi.c +++

Re: [Mesa-dev] [PATCH][V2] build: fix out-of-tree builds in gallium/auxiliary

2013-06-28 Thread Burton, Ross
On 28 June 2013 14:57, Andreas Boll andreas.boll@gmail.com wrote: There is an open bug report about this issue: https://bugs.freedesktop.org/show_bug.cgi?id=60197 Matt, could you take a look at this? Which patch do you prefer? Quentin's patch is more generic as it uses $(dir), so merge

Re: [Mesa-dev] [PATCH 1/2] svga: use switch statement in svga_shader_type()

2013-06-28 Thread Jose Fonseca
- Original Message - Safer in case the PIPE_SHADER_x tokens get renumbered (as Marek wanted to do). Renumbering PIPE_SHADER_x seems a pure time waster -- there is much more code that expects the current order -- and I see no benefit. This patch looks good nevertheles. ---

Re: [Mesa-dev] [PATCH 2/2] svga: pass svga_compile_key by reference instead of value

2013-06-28 Thread Jose Fonseca
Looks good to me - Original Message - --- src/gallium/drivers/svga/svga_tgsi.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/gallium/drivers/svga/svga_tgsi.c b/src/gallium/drivers/svga/svga_tgsi.c index 56529c6..29fbe84 100644 ---

[Mesa-dev] [PATCH] clover: Fix build with LLVM 3.4

2013-06-28 Thread Aaron Watry
PathV1.h has been removed. In theory this can go back before llvm 3.4, but I haven't done the research to find out how far back. Signed-off-by: Aaron Watry awa...@gmail.com --- src/gallium/state_trackers/clover/llvm/invocation.cpp | 12 1 file changed, 12 insertions(+) diff --git

Re: [Mesa-dev] [PATCH 1/2] svga: use switch statement in svga_shader_type()

2013-06-28 Thread Marek Olšák
The renumbering only makes sense for the GLSL linker and the only reason for doing that in gallium too is that PIPE_SHADER_x must be equal to MESA_SHADER_x. Marek On Fri, Jun 28, 2013 at 4:32 PM, Jose Fonseca jfons...@vmware.com wrote: - Original Message - Safer in case the

[Mesa-dev] [Bug 66029] More robust way of detecting LLVM major and minor versions

2013-06-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=66029 --- Comment #4 from Klemens Baum klemensb...@gmail.com --- Sent: http://lists.freedesktop.org/archives/mesa-dev/2013-June/041160.html -- You are receiving this mail because: You are the assignee for the bug.

Re: [Mesa-dev] [PATCH 1/6] mesa, gallium: renumber shader indices according to their placement in pipeline

2013-06-28 Thread Jose Fonseca
- Original Message - See my explanation in mtypes.h. --- src/gallium/include/pipe/p_defines.h |7 --- src/glsl/linker.cpp| 16 src/mesa/drivers/dri/i965/brw_shader.cpp |8 ++-- src/mesa/main/mtypes.h

[Mesa-dev] [PATCH] llvmpipe: fix timer query if there's no bins

2013-06-28 Thread sroland
From: Roland Scheidegger srol...@vmware.com b04a295a4a0cd2defe352b3193b5fa79ca8fc9fc removed seemingly unnecessary code in get_query. Turns out this code could in fact be reached - while timestamps are always binned, if there are no bins (which happens if fb size is 0) then the rasterization

Re: [Mesa-dev] [PATCH 1/6] mesa, gallium: renumber shader indices according to their placement in pipeline

2013-06-28 Thread Brian Paul
On 06/28/2013 08:53 AM, Jose Fonseca wrote: - Original Message - See my explanation in mtypes.h. --- src/gallium/include/pipe/p_defines.h |7 --- src/glsl/linker.cpp| 16 src/mesa/drivers/dri/i965/brw_shader.cpp |8

Re: [Mesa-dev] [PATCH] clover: Fix build with LLVM 3.4

2013-06-28 Thread Aaron Watry
Disregard this patch... Looks like Tom already pushed a fix last night. --Aaron On Fri, Jun 28, 2013 at 9:41 AM, Aaron Watry awa...@gmail.com wrote: PathV1.h has been removed. In theory this can go back before llvm 3.4, but I haven't done the research to find out how far back. Signed-off-by:

Re: [Mesa-dev] [PATCH 0/6] Eliminating unused built-in varyings

2013-06-28 Thread Ian Romanick
On 06/13/2013 05:25 AM, Marek Olšák wrote: Hi everyone, this series adds a new GLSL compiler optimization pass which eliminates unused and set-but-unused built-in varyings and adds a few improvements to the GLSL linker in the process. Before I show you how it works, I wanna say that there

Re: [Mesa-dev] [PATCH 0/6] Eliminating unused built-in varyings

2013-06-28 Thread Ian Romanick
On 06/28/2013 08:42 AM, Ian Romanick wrote: On 06/13/2013 05:25 AM, Marek Olšák wrote: Hi everyone, this series adds a new GLSL compiler optimization pass which eliminates unused and set-but-unused built-in varyings and adds a few improvements to the GLSL linker in the process. Before I show

Re: [Mesa-dev] [PATCH 4/6] glsl/linker: eliminate unused and set-but-unused built-in varyings

2013-06-28 Thread Ian Romanick
On 06/13/2013 05:25 AM, Marek Olšák wrote: This eliminates built-in varyings such as gl_Color, gl_SecondaryColor, gl_TexCoord, and gl_FogFragCoord if they are unused by the next stage or not written at all (e.g. gl_TexCoord elements). The gl_TexCoord array is broken down into separate vec4s if

[Mesa-dev] [Bug 66149] [HSW] Background of application icon has garbage after update kernelmesa in order to support Graphics [8086: 0a2e]

2013-06-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=66149 --- Comment #7 from Ian Romanick i...@freedesktop.org --- Eva, can you clarify for me. 9.1 works correctly, but master does not? If the bug still exists on master, the bug should not be closed. -- You are receiving this mail because: You are

Re: [Mesa-dev] [PATCH 0/6] Eliminating unused built-in varyings

2013-06-28 Thread Marek Olšák
On Fri, Jun 28, 2013 at 5:42 PM, Ian Romanick i...@freedesktop.org wrote: On 06/13/2013 05:25 AM, Marek Olšák wrote: Hi everyone, this series adds a new GLSL compiler optimization pass which eliminates unused and set-but-unused built-in varyings and adds a few improvements to the GLSL

Re: [Mesa-dev] [PATCH v2] r600g: implement fast color clears on evergreen+

2013-06-28 Thread Grigori Goronzy
On 12.06.2013 00:04, Grigori Goronzy wrote: Allows MSAA colorbuffers, which have a CMASK automatically and don't need any further special handling, to be fast cleared. Instead of clearing the buffer, set the clear color and the CMASK to the cleared state. Fast clear is used only when all bound

Re: [Mesa-dev] [PATCH] prog_parameter.c ASAN Patch

2013-06-28 Thread Myles C. Maxfield
Friendly ping regarding this patch :-) --Myles On Wed, Jun 19, 2013 at 12:47 AM, Myles C. Maxfield myles.maxfi...@gmail.com wrote: Any word on this? Thanks, Myles On Mon, Jun 17, 2013 at 12:09 PM, Myles C. Maxfield myles.maxfi...@gmail.com wrote: Sure. I was under the impression

[Mesa-dev] [PATCH] R600/SI: Add processor types for each CIK variant

2013-06-28 Thread alexdeucher
From: Alex Deucher alexander.deuc...@amd.com Signed-off-by: Alex Deucher alexander.deuc...@amd.com --- lib/Target/R600/Processors.td |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/lib/Target/R600/Processors.td b/lib/Target/R600/Processors.td index 81f407e..a0735d4

Re: [Mesa-dev] [PATCH] llvmpipe: fix timer query if there's no bins

2013-06-28 Thread Jose Fonseca
Looks good. - Original Message - From: Roland Scheidegger srol...@vmware.com b04a295a4a0cd2defe352b3193b5fa79ca8fc9fc removed seemingly unnecessary code in get_query. Turns out this code could in fact be reached - while timestamps are always binned, if there are no bins (which

Re: [Mesa-dev] [PATCH 0/6] Eliminating unused built-in varyings

2013-06-28 Thread Ian Romanick
On 06/28/2013 10:55 AM, Marek Olšák wrote: On Fri, Jun 28, 2013 at 5:42 PM, Ian Romanick i...@freedesktop.org wrote: On 06/13/2013 05:25 AM, Marek Olšák wrote: Hi everyone, this series adds a new GLSL compiler optimization pass which eliminates unused and set-but-unused built-in varyings and

Re: [Mesa-dev] [PATCH] R600/SI: Add processor types for each CIK variant

2013-06-28 Thread Tom Stellard
On Fri, Jun 28, 2013 at 03:05:04PM -0400, alexdeuc...@gmail.com wrote: From: Alex Deucher alexander.deuc...@amd.com Signed-off-by: Alex Deucher alexander.deuc...@amd.com Committed, thanks! -Tom --- lib/Target/R600/Processors.td |3 +++ 1 files changed, 3 insertions(+), 0

[Mesa-dev] [PATCH] glsl/builtins: Fix ARB_texture_cube_map_array built-in availability.

2013-06-28 Thread Kenneth Graunke
This patch adds texture() for isamplerCubeArray and usamplerCubeArray, which were entirely missing. It also makes texture() with a LOD bias fragment shader specific. The main GLSL specification explicitly says that texturing with LOD bias should not be allowed for vertex shaders. Affects

[Mesa-dev] [PATCH] draw/translate: fix instancing

2013-06-28 Thread Zack Rusin
We were incorrectly computing the buffer offset when using the instances. The buffer offset is always equal to: start_instance * stride + (instance_num / instance_divisor) * stride We were completely ignoring the start instance quite often producing instances that completely wrong, e.g. if start

Re: [Mesa-dev] R600/SI: Support for local memory and derivatives

2013-06-28 Thread Tom Stellard
On Wed, Jun 19, 2013 at 06:28:21PM +0200, Michel Dänzer wrote: These patches implement enough of local memory support to allow radeonsi to use that for computing derivatives, as suggested by Tom. They also almost allow test/CodeGen/R600/local-memory.ll to generate code for SI. Right now it

Re: [Mesa-dev] [PATCH 2/2] i965: Avoid flushing the batch for every blorp op.

2013-06-28 Thread Eric Anholt
Eric Anholt e...@anholt.net writes: This brings over the batch-wrap-prevention and aperture space checking code from the normal brw_draw.c path, so that we don't need to flush the batch every time. There's a risk here if the intel_emit_post_sync_nonzero_flush() call isn't high enough up in

Re: [Mesa-dev] [PATCH] glsl/builtins: Fix ARB_texture_cube_map_array built-in availability.

2013-06-28 Thread Dave Airlie
On Sat, Jun 29, 2013 at 7:22 AM, Kenneth Graunke kenn...@whitecape.org wrote: This patch adds texture() for isamplerCubeArray and usamplerCubeArray, which were entirely missing. It also makes texture() with a LOD bias fragment shader specific. The main GLSL specification explicitly says that

[Mesa-dev] [PATCH] i965: Delete pre-DRI2.3 viewport hacks.

2013-06-28 Thread Kenneth Graunke
The __DRI_USE_INVALIDATE extension was added in May 11th, 2010 by commit 4258e3a2e1c327. At this point, it's unlikely that anyone's using the right mix of new and old components to hit this path. Deleting it removes an untested code path and cleans up the driver a bit. Cc: Kristian Høgsberg

Re: [Mesa-dev] [PATCH V3 1/2] i965/blorp: Add bilinear filtering of samples for multisample scaled blits

2013-06-28 Thread Anuj Phogat
+void +brw_blorp_blit_program::manual_blend_linear(unsigned num_samples) +{ + if (key-tex_layout == INTEL_MSAA_LAYOUT_CMS) + mcs_fetch(); This won't work. The MCS value we fetch has to match up with the pixel that we're sampling from. Since this function samples from

[Mesa-dev] [PATCH V5 1/2] i965/blorp: Add bilinear filtering of samples for multisample scaled blits

2013-06-28 Thread Anuj Phogat
Current implementation of ext_framebuffer_multisample_blit_scaled in i965/blorp uses nearest filtering for multisample scaled blits. Using nearest filtering produces blocky artifacts and negates the benefits of MSAA. That is the reason why extension was not enabled on i965. This patch implements

[Mesa-dev] [Bug 66346] New: shader_query.cpp:49: error: invalid conversion from 'void*' to 'GLuint'

2013-06-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=66346 Priority: medium Bug ID: 66346 Keywords: regression CC: bri...@vmware.com Assignee: mesa-dev@lists.freedesktop.org Summary: shader_query.cpp:49: error: invalid conversion from

Re: [Mesa-dev] [PATCH V5 1/2] i965/blorp: Add bilinear filtering of samples for multisample scaled blits

2013-06-28 Thread Chris Forbes
Anuj, Yeah -- multisample textures on Gen7 are currently UMS for color. If you wanted to enable support for CMS, it should be reasonably straightforward, but requires some tweaks in the shader backend. This looks like a really nice quality improvement -- for the series: Acked-by: Chris Forbes