Re: [Mesa-dev] [PATCH 3/6] Add support for swrast to the DRM EGL platform

2014-07-24 Thread Pekka Paalanen
On Thu, 24 Jul 2014 01:43:35 +0100 Emil Velikov emil.l.veli...@gmail.com wrote: From: Giovanni Campagna gcampa...@src.gnome.org Turn GBM into a swrast loader (providing putimage/getimage backed by a dumb KMS buffer). This allows to run KMS+DRM GL applications (such as weston or

[Mesa-dev] [Bug 62202] Mesa demo dest window of wincopy flickers while toggle f/b buffer on software render

2014-07-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=62202 Tapani Pälli lem...@gmail.com changed: What|Removed |Added Version|9.1 |git --- Comment #1 from

Re: [Mesa-dev] [PATCH 1/2] i965: Viewport extents on gen8

2014-07-24 Thread Pohjolainen, Topi
On Thu, Jul 03, 2014 at 11:23:13AM -0700, Ben Widawsky wrote: Viewport extents are a 3rd rectangle that defines which pixels get discarded as part of the rasterization process. This can potentially improve performance by reducing cache usage, and freeing up PS cycles. This will get hit if

[Mesa-dev] [Bug 62202] Mesa demo dest window of wincopy flickers while toggle f/b buffer on software render

2014-07-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=62202 --- Comment #2 from Tapani Pälli lem...@gmail.com --- warning: Source file is more recent than executable. Sorry about this, it came from unrelated changes .. however I just tested that the function names match fine with a clean tree. Had also

Re: [Mesa-dev] [PATCH 0/5] [RFC] r600g/compute: Adding support for defragmenting compute_memory_pool

2014-07-24 Thread Bruno Jimenez
On Wed, 2014-07-23 at 10:33 -0400, Tom Stellard wrote: On Fri, Jul 18, 2014 at 01:09:03PM +0200, Bruno Jimenez wrote: On Thu, 2014-07-17 at 22:56 -0400, Tom Stellard wrote: On Wed, Jul 16, 2014 at 11:12:42PM +0200, Bruno Jiménez wrote: Hi, This series finally adds support for

Re: [Mesa-dev] [PATCH 1/3] r600g/compute: Allow compute_memory_move_item to move items between resources

2014-07-24 Thread Bruno Jimenez
On Wed, 2014-07-23 at 10:46 -0400, Tom Stellard wrote: On Sat, Jul 19, 2014 at 07:35:49PM +0200, Bruno Jiménez wrote: --- src/gallium/drivers/r600/compute_memory_pool.c | 43 ++ src/gallium/drivers/r600/compute_memory_pool.h | 1 + 2 files changed, 25

[Mesa-dev] [PATCH v2 1/3] r600g/compute: Allow compute_memory_move_item to move items between resources

2014-07-24 Thread Bruno Jiménez
v2: Remove unnecesary variables --- src/gallium/drivers/r600/compute_memory_pool.c | 31 +- src/gallium/drivers/r600/compute_memory_pool.h | 1 + 2 files changed, 16 insertions(+), 16 deletions(-) diff --git a/src/gallium/drivers/r600/compute_memory_pool.c

Re: [Mesa-dev] [v8 9/9] i965: enable image external sampling for imported dma-buffers

2014-07-24 Thread Pohjolainen, Topi
On Wed, Jun 18, 2014 at 03:11:52PM -0700, Anuj Phogat wrote: On Wed, Jul 24, 2013 at 5:06 PM, Chad Versace chad.vers...@linux.intel.com wrote: This patch is Reviewed-by: Chad Versace chad.vers...@linux.intel.com with the understanding that it depends on previous patches. I'll begin

Re: [Mesa-dev] [PATCH 04/16] glsl: Add is_{matrix, record, interface}_or_array_of predicates

2014-07-24 Thread Timothy Arceri
On Wed, 2014-07-23 at 15:23 -0700, Ian Romanick wrote: On 07/21/2014 08:03 PM, Timothy Arceri wrote: On Mon, 2014-07-21 at 14:04 -0700, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com There are a bunch of places, especially in the UBO code, where we check whether

Re: [Mesa-dev] [PATCH] added functions for binding atomic buffers to extension GL_ARB_shader_atomic_counters for radeonsi and r600 backend

2014-07-24 Thread Marek Olšák
Yes, the commit message and your git username needs to be fixed. Marek On Thu, Jul 24, 2014 at 12:49 AM, Aditya Avinash adityaavina...@gmail.com wrote: Hi, I am sorry. This is my first patch. I'll correct it for the next time. Do you want me to resend it? On Wednesday, July 23, 2014, Ian

Re: [Mesa-dev] [PATCH 1/3] gallium: Add PIPE_CAP_COMPUTE_IMAGES_SUPPORTED

2014-07-24 Thread Marek Olšák
Reviewed-by: Marek Olšák marek.ol...@amd.com Marek On Thu, Jul 24, 2014 at 2:37 AM, Tom Stellard thomas.stell...@amd.com wrote: --- src/gallium/docs/source/screen.rst| 2 ++ src/gallium/drivers/radeon/r600_pipe_common.c | 7 +++ src/gallium/include/pipe/p_defines.h

Re: [Mesa-dev] [PATCH 1/3] gallium: Add PIPE_COMPUTE_CAP_MAX_CONSTANT_BUFFER_SIZE

2014-07-24 Thread Marek Olšák
Isn't this redundant with get_shader_param(PIPE_SHADER_COMPUTE, PIPE_SHADER_CAP_MAX_CONSTS) * 16? Marek On Thu, Jul 24, 2014 at 3:05 AM, Tom Stellard thomas.stell...@amd.com wrote: --- src/gallium/docs/source/screen.rst | 2 ++ src/gallium/include/pipe/p_defines.h | 3 ++- 2 files

[Mesa-dev] [PATCH] mesa/imports.h: VS2013 doesn't provide strcasecmp

2014-07-24 Thread Alon Levy
From: Alon Levy al...@redhat.com Fixed build error at glsl_parser.yy for Visual Studio 2013 Signed-off-by: Alon Levy al...@redhat.com --- Thanks for the review. I verified and VS2013 (vs12) doesn't include strcasecmp, I corrected the file you mentioned, here is a better patch. (this supercedes

Re: [Mesa-dev] [PATCH 2/6] Add the format enums for BPTC-compressed images

2014-07-24 Thread Neil Roberts
On 07/22/2014 12:09 PM, Neil Roberts wrote: + * The spec for GL_ARB_texture_compression_bptc doesn't mention whether it + * should be included in GL_COMPRESSED_TEXTURE_FORMATS. Ian Romanick i...@freedesktop.org writes: What do NVIDIA and AMD do? We should mimic that. I don't have an NVidia

Re: [Mesa-dev] [PATCH] mesa/st: add support for dynamic ubo selection

2014-07-24 Thread Ilia Mirkin
ping On Sat, Jul 19, 2014 at 11:45 PM, Ilia Mirkin imir...@alum.mit.edu wrote: Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- Brian reviewed the first bits of this, but it turns out I had to change src_register as well. Also I realized that instead of doing the UADD I could just

Re: [Mesa-dev] [PATCH 3/6] Add support for swrast to the DRM EGL platform

2014-07-24 Thread Emil Velikov
On 24/07/14 07:23, Pekka Paalanen wrote: On Thu, 24 Jul 2014 01:43:35 +0100 Emil Velikov emil.l.veli...@gmail.com wrote: From: Giovanni Campagna gcampa...@src.gnome.org Turn GBM into a swrast loader (providing putimage/getimage backed by a dumb KMS buffer). This allows to run KMS+DRM GL

Re: [Mesa-dev] [PATCH] egl/gallium: implemlent EGL_KHR_create_context v3

2014-07-24 Thread Knut Andre Tidemann
On 06/27/2014 10:59 AM, Knut Andre Tidemann wrote: v2: fix style and wrong major version comparison. v3: fix version check in context creation. --- src/gallium/state_trackers/egl/common/egl_g3d.c | 1 + src/gallium/state_trackers/egl/common/egl_g3d_api.c | 12 2 files

Re: [Mesa-dev] [PATCH 2/7] glsl/glsl_parser.yy: vs12 doesn't have strcasecmp, use _stricmp instead

2014-07-24 Thread Emil Velikov
On 23/07/14 22:16, Ian Romanick wrote: On 07/22/2014 02:07 PM, Alon Levy wrote: Signed-off-by: Alon Levy al...@redhat.com --- src/glsl/glsl_parser.yy | 4 1 file changed, 4 insertions(+) diff --git a/src/glsl/glsl_parser.yy b/src/glsl/glsl_parser.yy index faaf438..25370cd 100644 ---

Re: [Mesa-dev] [PATCH 3/6] Add support for swrast to the DRM EGL platform

2014-07-24 Thread Pekka Paalanen
On Thu, 24 Jul 2014 13:34:42 +0100 Emil Velikov emil.l.veli...@gmail.com wrote: On 24/07/14 07:23, Pekka Paalanen wrote: On Thu, 24 Jul 2014 01:43:35 +0100 Emil Velikov emil.l.veli...@gmail.com wrote: From: Giovanni Campagna gcampa...@src.gnome.org Turn GBM into a swrast loader

Re: [Mesa-dev] [PATCH 1/3] gallium: Add PIPE_COMPUTE_CAP_MAX_CONSTANT_BUFFER_SIZE

2014-07-24 Thread Tom Stellard
On Thu, Jul 24, 2014 at 01:09:49PM +0200, Marek Olšák wrote: Isn't this redundant with get_shader_param(PIPE_SHADER_COMPUTE, PIPE_SHADER_CAP_MAX_CONSTS) * 16? This is what clover was using, but I was confused about what the value was supposed to represent. Now, I think I understand (number

Re: [Mesa-dev] [PATCH 2/6] Add the format enums for BPTC-compressed images

2014-07-24 Thread Alex Deucher
On Wed, Jul 23, 2014 at 5:57 PM, Ian Romanick i...@freedesktop.org wrote: On 07/22/2014 12:09 PM, Neil Roberts wrote: diff --git a/src/mesa/main/texcompress.c b/src/mesa/main/texcompress.c index 9dbfe9f..b708b49 100644 --- a/src/mesa/main/texcompress.c +++ b/src/mesa/main/texcompress.c @@

Re: [Mesa-dev] [PATCH 1/3] gallium: Add PIPE_COMPUTE_CAP_MAX_CONSTANT_BUFFER_SIZE

2014-07-24 Thread Jan Vesely
On Thu, 2014-07-24 at 06:35 -0700, Tom Stellard wrote: On Thu, Jul 24, 2014 at 01:09:49PM +0200, Marek Olšák wrote: Isn't this redundant with get_shader_param(PIPE_SHADER_COMPUTE, PIPE_SHADER_CAP_MAX_CONSTS) * 16? This is what clover was using, but I was confused about what the value

[Mesa-dev] [PATCH 0/2] Teach some platform checks about Cygwin

2014-07-24 Thread Jon TURNEY
A couple of small fixes to teach platform checks about Cygwin's characteristics Ideally, these would be autoconf checks, and we wouldn't have to do anything here, but it seems that ship has long sailed. Yaakov Selkowitz (2): xmlconfig: Use program_invocation_short_name when building for

[Mesa-dev] [PATCH 1/2] xmlconfig: Use program_invocation_short_name when building for cygwin

2014-07-24 Thread Jon TURNEY
From: Yaakov Selkowitz yselkow...@users.sourceforge.net mesa/mesa/src/mesa/drivers/dri/common/xmlconfig.c:104:10: warning: #warning Per application configuration won't work with your OS version. [-Wcpp] #warning Per application configuration won't work with your OS version.

[Mesa-dev] [PATCH 2/2] os_process.c: Add cygwin as an expected platform

2014-07-24 Thread Jon TURNEY
From: Yaakov Selkowitz yselkow...@users.sourceforge.net mesa/mesa/src/gallium/auxiliary/os/os_process.c:40:2: warning: #warning unexpected platform in os_process.c [-Wcpp] #warning unexpected platform in os_process.c mesa/mesa/src/gallium/auxiliary/os/os_process.c:77:2: warning: #warning

Re: [Mesa-dev] [PATCH 0/6] Add support for BPTC texture compression

2014-07-24 Thread Neil Roberts
Ian Romanick i...@freedesktop.org writes: Is that NVIDIA's off-line compression tool, or is that the compressor in the driver? I was talking about the offline compressor. I don't know what NVidia's online compressor is like. Yes, perhaps if we can get a quick compressor with reasonable results

Re: [Mesa-dev] [PATCH] mesa/imports.h: VS2013 doesn't provide strcasecmp

2014-07-24 Thread Alon Levy
On 07/24/2014 02:12 PM, Alon Levy wrote: From: Alon Levy al...@redhat.com Forgot to add Ian as cc. Fixed build error at glsl_parser.yy for Visual Studio 2013 Signed-off-by: Alon Levy al...@redhat.com --- Thanks for the review. I verified and VS2013 (vs12) doesn't include strcasecmp,

Re: [Mesa-dev] [PATCH 0/6] Add support for BPTC texture compression

2014-07-24 Thread Ilia Mirkin
On Thu, Jul 24, 2014 at 10:37 AM, Neil Roberts n...@linux.intel.com wrote: Ian Romanick i...@freedesktop.org writes: Is that NVIDIA's off-line compression tool, or is that the compressor in the driver? I was talking about the offline compressor. I don't know what NVidia's online compressor

[Mesa-dev] [PATCH] st/wgl: Clamp wglChoosePixelFormatARB's output nNumFormats to nMaxFormats.

2014-07-24 Thread jfonseca
From: José Fonseca jfons...@vmware.com While running https://github.com/nvMcJohn/apitest with apitrace I noticed that Mesa was producing bogus results: wglChoosePixelFormatARB(hdc, piAttribIList = {...}, pfAttribFList = 0, nMaxFormats = 1, piFormats = {19, 65576, 37, 198656, 131075, 0,

Re: [Mesa-dev] [PATCH 1/3] gallium: Add PIPE_COMPUTE_CAP_MAX_CONSTANT_BUFFER_SIZE

2014-07-24 Thread Marek Olšák
OpenGL 3.1 requires 4096 vec4s (65536 bytes) per constant buffer and the hardware supports 16 constant buffers. I'm not sure what the constant registers are, but they cannot have anything to do with the constant buffer limit, because otherwise we wouldn't be able to meet the requirement for

Re: [Mesa-dev] [PATCH 0/6] Add support for BPTC texture compression

2014-07-24 Thread Neil Roberts
Matt Turner matts...@gmail.com writes: I was thinking one of the cool things we might be able to do a ETC2 - BC7 transcode on platforms without ETC2 hardware decompression. We won't be able to do that without a good compressor. That sounds like a fun project. It would be a shame to have to

Re: [Mesa-dev] [PATCH 1/3] gallium: Add PIPE_COMPUTE_CAP_MAX_CONSTANT_BUFFER_SIZE

2014-07-24 Thread Marek Olšák
Sorry, GL 3.1 actually only requires 1024 vec4s. The UBO extension spec contains a mistake. Marek On Thu, Jul 24, 2014 at 4:55 PM, Marek Olšák mar...@gmail.com wrote: OpenGL 3.1 requires 4096 vec4s (65536 bytes) per constant buffer and the hardware supports 16 constant buffers. I'm not sure

Re: [Mesa-dev] [PATCH 0/6] Add support for BPTC texture compression

2014-07-24 Thread Ian Romanick
On 07/24/2014 07:43 AM, Ilia Mirkin wrote: On Thu, Jul 24, 2014 at 10:37 AM, Neil Roberts n...@linux.intel.com wrote: Ian Romanick i...@freedesktop.org writes: Is that NVIDIA's off-line compression tool, or is that the compressor in the driver? I was talking about the offline compressor. I

Re: [Mesa-dev] [PATCH 0/6] Add support for BPTC texture compression

2014-07-24 Thread Ian Romanick
On 07/23/2014 07:41 PM, Matt Turner wrote: On Wed, Jul 23, 2014 at 3:16 PM, Ian Romanick i...@freedesktop.org wrote: On 07/22/2014 12:09 PM, Neil Roberts wrote: Here's a first attempt at a patch series to implement BPTC texture compression in the i965 driver on Gen=7. Getting it to work on

Re: [Mesa-dev] [PATCH 0/6] Add support for BPTC texture compression

2014-07-24 Thread Neil Roberts
Ilia Mirkin imir...@alum.mit.edu writes: Just a thought -- if online compression is highly unexpected, perhaps it'd be reasonably to make a *horrid* compressor that doesn't rely on any external libraries? I don't know how complex the BPTC format is, but I suspect it may be possible to do a

Re: [Mesa-dev] [PATCH 1/3] gallium: Add PIPE_COMPUTE_CAP_MAX_CONSTANT_BUFFER_SIZE

2014-07-24 Thread Henri Verbeet
On 24 July 2014 16:55, Marek Olšák mar...@gmail.com wrote: the hardware supports 16 constant buffers. I'm not sure what the constant registers are, but they cannot have anything to do with the Probably the old CFILE constants, of which there actually only were 256, and which IIRC were removed

Re: [Mesa-dev] [PATCH 1/3] gallium: Add PIPE_COMPUTE_CAP_MAX_CONSTANT_BUFFER_SIZE

2014-07-24 Thread Jan Vesely
On Thu, 2014-07-24 at 17:07 +0200, Marek Olšák wrote: Sorry, GL 3.1 actually only requires 1024 vec4s. The UBO extension spec contains a mistake. Marek On Thu, Jul 24, 2014 at 4:55 PM, Marek Olšák mar...@gmail.com wrote: OpenGL 3.1 requires 4096 vec4s (65536 bytes) per constant buffer

Re: [Mesa-dev] [PATCH 2/7] glsl/glsl_parser.yy: vs12 doesn't have strcasecmp, use _stricmp instead

2014-07-24 Thread Matt Turner
On Thu, Jul 24, 2014 at 5:44 AM, Emil Velikov emil.l.veli...@gmail.com wrote: On 23/07/14 22:16, Ian Romanick wrote: On 07/22/2014 02:07 PM, Alon Levy wrote: Signed-off-by: Alon Levy al...@redhat.com --- src/glsl/glsl_parser.yy | 4 1 file changed, 4 insertions(+) diff --git

Re: [Mesa-dev] [PATCH 3/6] Add support for swrast to the DRM EGL platform

2014-07-24 Thread Emil Velikov
On 24/07/14 14:30, Pekka Paalanen wrote: On Thu, 24 Jul 2014 13:34:42 +0100 Emil Velikov emil.l.veli...@gmail.com wrote: On 24/07/14 07:23, Pekka Paalanen wrote: On Thu, 24 Jul 2014 01:43:35 +0100 Emil Velikov emil.l.veli...@gmail.com wrote: From: Giovanni Campagna gcampa...@src.gnome.org

Re: [Mesa-dev] [PATCH 2/7] glsl/glsl_parser.yy: vs12 doesn't have strcasecmp, use _stricmp instead

2014-07-24 Thread Emil Velikov
On 24/07/14 17:07, Matt Turner wrote: On Thu, Jul 24, 2014 at 5:44 AM, Emil Velikov emil.l.veli...@gmail.com wrote: On 23/07/14 22:16, Ian Romanick wrote: On 07/22/2014 02:07 PM, Alon Levy wrote: Signed-off-by: Alon Levy al...@redhat.com --- src/glsl/glsl_parser.yy | 4 1 file

Re: [Mesa-dev] [PATCH] egl/gallium: implemlent EGL_KHR_create_context v3

2014-07-24 Thread Matt Turner
On Thu, Jul 24, 2014 at 5:37 AM, Knut Andre Tidemann knut.tidem...@gmail.com wrote: On 06/27/2014 10:59 AM, Knut Andre Tidemann wrote: v2: fix style and wrong major version comparison. v3: fix version check in context creation. --- src/gallium/state_trackers/egl/common/egl_g3d.c | 1 +

Re: [Mesa-dev] [PATCH] egl/gallium: implemlent EGL_KHR_create_context v3

2014-07-24 Thread Matt Turner
On Fri, Jun 27, 2014 at 1:59 AM, Knut Andre Tidemann knut.tidem...@gmail.com wrote: v2: fix style and wrong major version comparison. v3: fix version check in context creation. --- src/gallium/state_trackers/egl/common/egl_g3d.c | 1 + src/gallium/state_trackers/egl/common/egl_g3d_api.c

Re: [Mesa-dev] [PATCH 1/2] i965: Viewport extents on gen8

2014-07-24 Thread Ben Widawsky
On Thu, Jul 24, 2014 at 10:29:11AM +0300, Pohjolainen, Topi wrote: On Thu, Jul 03, 2014 at 11:23:13AM -0700, Ben Widawsky wrote: Viewport extents are a 3rd rectangle that defines which pixels get discarded as part of the rasterization process. This can potentially improve performance by

Re: [Mesa-dev] [PATCH 0/6] Add support for BPTC texture compression

2014-07-24 Thread Kristian Høgsberg
On Thu, Jul 24, 2014 at 8:55 AM, Neil Roberts n...@linux.intel.com wrote: Ilia Mirkin imir...@alum.mit.edu writes: Just a thought -- if online compression is highly unexpected, perhaps it'd be reasonably to make a *horrid* compressor that doesn't rely on any external libraries? I don't know

[Mesa-dev] [PATCH] r600g: switch SNORM conversion to DX and GLES behavior

2014-07-24 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com it also matches GL 4.2 further discussion: http://lists.freedesktop.org/archives/mesa-dev/2013-August/042680.html --- src/gallium/drivers/r600/evergreen_state.c | 2 -- src/gallium/drivers/r600/r600_asm.c| 1 - src/gallium/drivers/r600/r600_shader.c

Re: [Mesa-dev] [PATCH 1/2] i965: Viewport extents on gen8

2014-07-24 Thread Pohjolainen, Topi
On Thu, Jul 24, 2014 at 10:22:25AM -0700, Ben Widawsky wrote: On Thu, Jul 24, 2014 at 10:29:11AM +0300, Pohjolainen, Topi wrote: On Thu, Jul 03, 2014 at 11:23:13AM -0700, Ben Widawsky wrote: Viewport extents are a 3rd rectangle that defines which pixels get discarded as part of the

Re: [Mesa-dev] [PATCH 1/3] gallium: Add PIPE_COMPUTE_CAP_MAX_CONSTANT_BUFFER_SIZE

2014-07-24 Thread Alex Deucher
On Thu, Jul 24, 2014 at 12:05 PM, Jan Vesely jan.ves...@rutgers.edu wrote: On Thu, 2014-07-24 at 17:07 +0200, Marek Olšák wrote: Sorry, GL 3.1 actually only requires 1024 vec4s. The UBO extension spec contains a mistake. Marek On Thu, Jul 24, 2014 at 4:55 PM, Marek Olšák mar...@gmail.com

Re: [Mesa-dev] [PATCH 2/7] glsl/glsl_parser.yy: vs12 doesn't have strcasecmp, use _stricmp instead

2014-07-24 Thread Alon Levy
On 07/24/2014 07:50 PM, Emil Velikov wrote: On 24/07/14 17:07, Matt Turner wrote: On Thu, Jul 24, 2014 at 5:44 AM, Emil Velikov emil.l.veli...@gmail.com wrote: On 23/07/14 22:16, Ian Romanick wrote: On 07/22/2014 02:07 PM, Alon Levy wrote: Signed-off-by: Alon Levy al...@redhat.com ---

[Mesa-dev] [PATCH] gallium: rename shader cap MAX_CONSTS to MAX_CONST_BUFFER_SIZE

2014-07-24 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com This new name isn't so confusing. I also changed the gallivm limit, because it looked wrong. --- src/gallium/auxiliary/gallivm/lp_bld_limits.h | 4 ++-- src/gallium/auxiliary/tgsi/tgsi_exec.h| 8 src/gallium/auxiliary/util/u_caps.c

[Mesa-dev] [PATCH] main/mesa: missing atomic buffer bindings to mesa are added in this patch

2014-07-24 Thread Aditya Atluri
--- src/mesa/main/bufferobj.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index 7b1bba0..1dfcda3 100644 --- a/src/mesa/main/bufferobj.c +++ b/src/mesa/main/bufferobj.c @@ -832,6 +832,9 @@

Re: [Mesa-dev] [PATCH] main/mesa: missing atomic buffer bindings to mesa are added in this patch

2014-07-24 Thread Matt Turner
The commit message should be something like mesa: Add missing atomic buffer bindings and unbindings. On Thu, Jul 24, 2014 at 12:18 PM, Aditya Atluri adityaavina...@gmail.com wrote: --- src/mesa/main/bufferobj.c | 31 +++ 1 file changed, 31 insertions(+) diff

Re: [Mesa-dev] [PATCH v2] gbm: Replace GBM_DRIVERS_PATH with LIBGL_DRIVERS_PATH

2014-07-24 Thread Emil Velikov
On 22/07/14 19:43, Dylan Baker wrote: GBM_DRIVERS_PATH is not documented, and only used to set the location of gbm drivers, while LIBGL_DRIVERS_PATH is used for everything else, and is documented. Generally this split leads to confusion as to why gbm doesn't work. This patch makes

Re: [Mesa-dev] [PATCH] main/mesa: missing atomic buffer bindings to mesa are added in this patch

2014-07-24 Thread Aditya Avinash
Hi, Do you want me to resend it? On Thursday, July 24, 2014, Matt Turner matts...@gmail.com wrote: The commit message should be something like mesa: Add missing atomic buffer bindings and unbindings. On Thu, Jul 24, 2014 at 12:18 PM, Aditya Atluri adityaavina...@gmail.com javascript:;

Re: [Mesa-dev] [PATCH v2] gbm: Replace GBM_DRIVERS_PATH with LIBGL_DRIVERS_PATH

2014-07-24 Thread Kristian Høgsberg
On Thu, Jul 24, 2014 at 1:32 PM, Emil Velikov emil.l.veli...@gmail.com wrote: On 22/07/14 19:43, Dylan Baker wrote: GBM_DRIVERS_PATH is not documented, and only used to set the location of gbm drivers, while LIBGL_DRIVERS_PATH is used for everything else, and is documented. Generally this

Re: [Mesa-dev] [PATCH] main/mesa: missing atomic buffer bindings to mesa are added in this patch

2014-07-24 Thread Matt Turner
On Thu, Jul 24, 2014 at 1:40 PM, Aditya Avinash adityaavina...@gmail.com wrote: Do you want me to resend it? Not just for those comments. If there are other comments that necessitate resending, please fix the two things I mentioned. Otherwise someone will just fix them when they commit your

Re: [Mesa-dev] [PATCH v2] gbm: Replace GBM_DRIVERS_PATH with LIBGL_DRIVERS_PATH

2014-07-24 Thread Kristian Høgsberg
On Thu, Jul 24, 2014 at 1:43 PM, Kristian Høgsberg k...@bitplanet.net wrote: On Thu, Jul 24, 2014 at 1:32 PM, Emil Velikov emil.l.veli...@gmail.com wrote: On 22/07/14 19:43, Dylan Baker wrote: GBM_DRIVERS_PATH is not documented, and only used to set the location of gbm drivers, while

[Mesa-dev] [PATCH 3/3] glsl: Rebuild the symbol table without unreachable symbols

2014-07-24 Thread Kenneth Graunke
From: Ian Romanick ian.d.roman...@intel.com Previously we had to keep unreachable global symbols in the symbol table because the symbol table is used during linking. Having the symbol table retain pointers to freed memory... what could possibly go wrong? At the same time, this meant that we kept

[Mesa-dev] [PATCH 1/3] glsl: Make it possible to ignore built-ins when matching signatures.

2014-07-24 Thread Kenneth Graunke
Historically, we've implemented the rules for overriding built-in functions by creating multiple ir_functions and relying on the symbol table to hide the one containing built-in functions. That works, but has a few drawbacks, so the next patch will change it. Instead, we'll have a single

[Mesa-dev] [PATCH 2/3] glsl: Only create one ir_function for a given name.

2014-07-24 Thread Kenneth Graunke
Piglit's spec/glsl-1.10/linker/override-builtin-{const,uniform}-05 tests do the following: 1. Call abs(float) - a built-in function. 2. Create a user-defined replacement for abs(float). 3. Call abs(float) again - now the user function. At step 1, we created an ir_function which included the

Re: [Mesa-dev] [PATCH 02/26] glsl: Rebuild the symbol table without unreachable symbols

2014-07-24 Thread Kenneth Graunke
On Tuesday, July 15, 2014 08:05:31 PM Kenneth Graunke wrote: On Monday, July 14, 2014 03:48:34 PM Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com Previously we had to keep unreachable global symbols in the symbol table because the symbol table is used during linking.

Re: [Mesa-dev] [PATCH v2] gbm: Replace GBM_DRIVERS_PATH with LIBGL_DRIVERS_PATH

2014-07-24 Thread Dylan Baker
On Thursday, July 24, 2014 09:32:38 PM Emil Velikov wrote: On 22/07/14 19:43, Dylan Baker wrote: GBM_DRIVERS_PATH is not documented, and only used to set the location of gbm drivers, while LIBGL_DRIVERS_PATH is used for everything else, and is documented. Generally this split leads to

[Mesa-dev] [PATCH] winsys/radeon: fix nop packet padding.

2014-07-24 Thread j . glisse
From: Jerome Glisse jgli...@redhat.com The gpu packet prefetcher hates the ugly big nop packet those leads to prefetching some invalid memory in some case. Apparently hawaii is particularly sensible to this. Note this only partialy fix hawaii issues and some zbuffer tiling issues are still

[Mesa-dev] [PATCH] radeonsi: add support for trace buffer.

2014-07-24 Thread j . glisse
From: Jérôme Glisse jgli...@redhat.com Trace buffer allow to dump a command buffer which is fully repliable as a standalone c program. This make debuging lockup immensively simpler. This patch only plug the core minimal stuff and is still missing the more fancy aspect that are in r600g. It

[Mesa-dev] [PATCH 2/2] configure.ac: drop enable_dri check in gallium_gbm

2014-07-24 Thread Emil Velikov
A while back we've mandated that gbm requires enable_dri, thus this check is no longer required. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- configure.ac | 4 1 file changed, 4 deletions(-) diff --git a/configure.ac b/configure.ac index 4482161..46ed001 100644 ---

[Mesa-dev] [PATCH 1/2] configure.ac: bail out if building gallium_gbm without gallium_egl

2014-07-24 Thread Emil Velikov
The former is the only user of the latter. As such building gbm without egl makes little to no sense. Cc: 10.2 mesa-sta...@lists.freedesktop.org Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- configure.ac | 4 1 file changed, 4 insertions(+) diff --git a/configure.ac

Re: [Mesa-dev] [PATCH] winsys/radeon: fix nop packet padding.

2014-07-24 Thread Jerome Glisse
On Thu, Jul 24, 2014 at 05:42:21PM -0400, j.gli...@gmail.com wrote: From: Jerome Glisse jgli...@redhat.com The gpu packet prefetcher hates the ugly big nop packet those leads to prefetching some invalid memory in some case. Apparently hawaii is particularly sensible to this. Note this

[Mesa-dev] [PATCH] winsys/radeon: fix nop packet padding v2.

2014-07-24 Thread j . glisse
From: Jerome Glisse jgli...@redhat.com The ucode we got for hawaii does not support 0x1000 special nop packet type 3 and this leads to gpu reading invalid memory. As packet type 2 still exist just use packet type 2. Note this only partialy fix hawaii issues and some zbuffer tiling issues are

Re: [Mesa-dev] [PATCH] radeonsi: add support for trace buffer.

2014-07-24 Thread Marek Olšák
Reviewed-by: Marek Olšák marek.ol...@amd.com Marek On Fri, Jul 25, 2014 at 12:07 AM, j.gli...@gmail.com wrote: From: Jérôme Glisse jgli...@redhat.com Trace buffer allow to dump a command buffer which is fully repliable as a standalone c program. This make debuging lockup immensively

Re: [Mesa-dev] [PATCH 1/3] gallium: Add PIPE_COMPUTE_CAP_MAX_CONSTANT_BUFFER_SIZE

2014-07-24 Thread Jan Vesely
On Thu, 2014-07-24 at 13:52 -0400, Alex Deucher wrote: On Thu, Jul 24, 2014 at 12:05 PM, Jan Vesely jan.ves...@rutgers.edu wrote: On Thu, 2014-07-24 at 17:07 +0200, Marek Olšák wrote: Sorry, GL 3.1 actually only requires 1024 vec4s. The UBO extension spec contains a mistake. Marek

[Mesa-dev] [PATCH 2/2] glsl/cs: Add several GLSL compute shader variables

2014-07-24 Thread Jordan Justen
This fixes piglit (with GL_ARB_compute_shader force enabled): built-in-constants tests/spec/arb_compute_shader/minimum-maximums.txt (Also requires piglit patch arb_compute_shader glsl min/max: Update gl_MaxComputeUniformComponents) Signed-off-by: Jordan Justen jordan.l.jus...@intel.com ---

[Mesa-dev] [PATCH 1/2] main/cs: Add additional compute shader constant values

2014-07-24 Thread Jordan Justen
This fixes piglit's arb_compute_shader-minmax test. Signed-off-by: Jordan Justen jordan.l.jus...@intel.com --- Re-send (originally sent June 9) src/mesa/main/config.h | 11 +++ src/mesa/main/get_hash_params.py | 7 +++ 2 files changed, 18 insertions(+) diff --git

Re: [Mesa-dev] [PATCH 1/2] main/cs: Add additional compute shader constant values

2014-07-24 Thread Ilia Mirkin
On Thu, Jul 24, 2014 at 6:44 PM, Jordan Justen jordan.l.jus...@intel.com wrote: This fixes piglit's arb_compute_shader-minmax test. Signed-off-by: Jordan Justen jordan.l.jus...@intel.com --- Re-send (originally sent June 9) Is there any point in making these Const.Foo so that individual

Re: [Mesa-dev] [PATCH 1/2] main/cs: Add additional compute shader constant values

2014-07-24 Thread Jordan Justen
On Thu, Jul 24, 2014 at 3:56 PM, Ilia Mirkin imir...@alum.mit.edu wrote: On Thu, Jul 24, 2014 at 6:44 PM, Jordan Justen jordan.l.jus...@intel.com wrote: This fixes piglit's arb_compute_shader-minmax test. Signed-off-by: Jordan Justen jordan.l.jus...@intel.com --- Re-send (originally sent

Re: [Mesa-dev] [PATCH 1/2] main/cs: Add additional compute shader constant values

2014-07-24 Thread Chris Forbes
These are Reviewed-by: Chris Forbes chr...@ijw.co.nz On Fri, Jul 25, 2014 at 11:04 AM, Jordan Justen jljus...@gmail.com wrote: On Thu, Jul 24, 2014 at 3:56 PM, Ilia Mirkin imir...@alum.mit.edu wrote: On Thu, Jul 24, 2014 at 6:44 PM, Jordan Justen jordan.l.jus...@intel.com wrote: This fixes

Re: [Mesa-dev] [PATCH] winsys/radeon: fix nop packet padding v2.

2014-07-24 Thread Alex Deucher
On Thu, Jul 24, 2014 at 6:28 PM, j.gli...@gmail.com wrote: From: Jerome Glisse jgli...@redhat.com The ucode we got for hawaii does not support 0x1000 special nop packet type 3 and this leads to gpu reading invalid memory. As packet type 2 still exist just use packet type 2. Note this

[Mesa-dev] [PATCH 3/6] util: Move the open-addressing linear-probing hash_table to src/util.

2014-07-24 Thread Jason Ekstrand
From: Kenneth Graunke kenn...@whitecape.org This hash table is used in core Mesa, the GLSL compiler, and the i965 driver, which makes it a good candidate for the new src/util module. It's much faster than program/hash_table.[ch] (see commit 6991c2922f5 for data), and José's u_hash_table.c has a

[Mesa-dev] [PATCH 4/6] util: Gather some common macros

2014-07-24 Thread Jason Ekstrand
This gathers macros that have been included across components into util so that the include chain can be more vertical. In particular, this makes util stand on its own without any dependence whatsoever on the rest of mesa. Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com ---

[Mesa-dev] [PATCH 1/6] mesa/SConscript: Use Makefile.sources instead of duplicating the file lists

2014-07-24 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com --- src/mesa/Makefile.sources | 3 + src/mesa/SConscript | 341 ++ 2 files changed, 11 insertions(+), 333 deletions(-) diff --git a/src/mesa/Makefile.sources b/src/mesa/Makefile.sources

[Mesa-dev] [PATCH 6/6] mesa/main: Use the RGB - sRGB conversion functions in libmesautil

2014-07-24 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com --- src/mesa/main/format_pack.c | 102 ++- src/mesa/main/format_unpack.c| 69 -- src/mesa/main/format_unpack.h| 3 -- src/mesa/main/texcompress_etc.c | 19

[Mesa-dev] [PATCH 2/6] util: Move ralloc to a new src/util directory.

2014-07-24 Thread Jason Ekstrand
From: Kenneth Graunke kenn...@whitecape.org For a long time, we've wanted a place to put utility code which isn't directly tied to Mesa or Gallium internals. This patch creates a new src/util directory for exactly that purpose, and builds the contents as libmesautil.la. ralloc seemed like a

[Mesa-dev] [PATCH 5/6] gallium: Move sRGB - RGB handling to libmesautil

2014-07-24 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com --- src/gallium/Automake.inc | 2 + src/gallium/auxiliary/Makefile.am | 4 - src/gallium/auxiliary/Makefile.sources| 1 - src/gallium/auxiliary/SConscript | 8 +-

[Mesa-dev] [PATCH 0/6] Add a libmesautil library for sharing code between

2014-07-24 Thread Jason Ekstrand
There is a lot of code duplicated or awkwardly shared right now between mesa/main, glsl, and gallium. It would be good to gather these useful things into a central place that does not depend on any of the above. People have talked about doing this from time to time; this series aims to get the

Re: [Mesa-dev] [PATCH v2] gbm: Replace GBM_DRIVERS_PATH with LIBGL_DRIVERS_PATH

2014-07-24 Thread Emil Velikov
On 24/07/14 22:08, Dylan Baker wrote: On Thursday, July 24, 2014 09:32:38 PM Emil Velikov wrote: On 22/07/14 19:43, Dylan Baker wrote: GBM_DRIVERS_PATH is not documented, and only used to set the location of gbm drivers, while LIBGL_DRIVERS_PATH is used for everything else, and is documented.

Re: [Mesa-dev] [PATCH v2] gbm: Replace GBM_DRIVERS_PATH with LIBGL_DRIVERS_PATH

2014-07-24 Thread Matt Turner
On Thu, Jul 24, 2014 at 5:17 PM, Emil Velikov emil.l.veli...@gmail.com wrote: On 24/07/14 22:08, Dylan Baker wrote: On Thursday, July 24, 2014 09:32:38 PM Emil Velikov wrote: On 22/07/14 19:43, Dylan Baker wrote: GBM_DRIVERS_PATH is not documented, and only used to set the location of gbm

[Mesa-dev] [PATCH 09/20] i965/cfg: Add a function to remove a block from the cfg.

2014-07-24 Thread Matt Turner
--- src/mesa/drivers/dri/i965/brw_cfg.cpp | 58 +-- src/mesa/drivers/dri/i965/brw_cfg.h | 4 ++- 2 files changed, 58 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_cfg.cpp b/src/mesa/drivers/dri/i965/brw_cfg.cpp index 9cd8b9f..c39edad

[Mesa-dev] [PATCH 05/20] i965/cfg: Add a foreach_inst_in_block_safe macro.

2014-07-24 Thread Matt Turner
--- src/mesa/drivers/dri/i965/brw_cfg.h | 8 1 file changed, 8 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_cfg.h b/src/mesa/drivers/dri/i965/brw_cfg.h index a5d2df5..913a1ed 100644 --- a/src/mesa/drivers/dri/i965/brw_cfg.h +++ b/src/mesa/drivers/dri/i965/brw_cfg.h @@

[Mesa-dev] [PATCH 00/20] i965: Preserve CFG

2014-07-24 Thread Matt Turner
These 19 patches reduce the number of times we calculate the CFG by 61.74% (after the previous series, which already reduced it by 55%). To do so, I've added some infrastructure to the CFG code to combine blocks, and to insert and remove instructions while preserving the information stored in the

[Mesa-dev] [PATCH 04/20] i965/cfg: Add a foreach_block_safe macro.

2014-07-24 Thread Matt Turner
--- src/mesa/drivers/dri/i965/brw_cfg.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_cfg.h b/src/mesa/drivers/dri/i965/brw_cfg.h index f7203e2..a5d2df5 100644 --- a/src/mesa/drivers/dri/i965/brw_cfg.h +++ b/src/mesa/drivers/dri/i965/brw_cfg.h @@ -112,6

[Mesa-dev] [PATCH 01/20] i965/cfg: Embed link in bblock_t for main block list.

2014-07-24 Thread Matt Turner
The next patch adds a foreach_block (block, cfg) macro, which works better if it provides a direct bblock_t pointer, rather than a bblock_link pointer that you have to use to find the actual block. --- src/mesa/drivers/dri/i965/brw_cfg.cpp | 10 +- src/mesa/drivers/dri/i965/brw_cfg.h |

[Mesa-dev] [PATCH 06/20] !UPSTREAM: print cfg counts

2014-07-24 Thread Matt Turner
--- src/mesa/drivers/dri/i965/brw_fs.cpp | 1 + src/mesa/drivers/dri/i965/brw_shader.cpp | 4 +++- src/mesa/drivers/dri/i965/brw_shader.h | 1 + src/mesa/drivers/dri/i965/brw_vec4.cpp | 1 + 4 files changed, 6 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp

[Mesa-dev] [PATCH 02/20] i965: Add and use foreach_block macro.

2014-07-24 Thread Matt Turner
Use this as an opportunity to rename 'block_num' to 'num'. block-num is clear, and block-block_num has always been redundant. --- src/mesa/drivers/dri/i965/brw_cfg.cpp | 17 ++--- src/mesa/drivers/dri/i965/brw_cfg.h| 5 +-

[Mesa-dev] [PATCH 03/20] i965: Pass a cfg pointer to generate_{code, assembly}.

2014-07-24 Thread Matt Turner
--- src/mesa/drivers/dri/i965/brw_blorp_blit_eu.cpp | 4 +++- src/mesa/drivers/dri/i965/brw_fs.cpp | 10 ++ src/mesa/drivers/dri/i965/brw_fs.h| 12 ++-- src/mesa/drivers/dri/i965/brw_fs_generator.cpp| 22 +-

[Mesa-dev] [PATCH 11/20] i965: Add basic-block aware backend_instruction::insert_* methods.

2014-07-24 Thread Matt Turner
--- src/mesa/drivers/dri/i965/brw_shader.cpp | 80 src/mesa/drivers/dri/i965/brw_shader.h | 5 ++ 2 files changed, 85 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_shader.cpp b/src/mesa/drivers/dri/i965/brw_shader.cpp index 47535a9..ba93cbc 100644

[Mesa-dev] [PATCH 08/20] i965/cfg: Add functions to test if a block is a successor/predecessor.

2014-07-24 Thread Matt Turner
--- src/mesa/drivers/dri/i965/brw_cfg.cpp | 24 src/mesa/drivers/dri/i965/brw_cfg.h | 2 ++ 2 files changed, 26 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_cfg.cpp b/src/mesa/drivers/dri/i965/brw_cfg.cpp index d806b83..9cd8b9f 100644 ---

[Mesa-dev] [PATCH 07/20] i965/cfg: Add a foreach_block_and_inst_safe macro.

2014-07-24 Thread Matt Turner
--- src/mesa/drivers/dri/i965/brw_cfg.h | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_cfg.h b/src/mesa/drivers/dri/i965/brw_cfg.h index 913a1ed..29e31e7 100644 --- a/src/mesa/drivers/dri/i965/brw_cfg.h +++ b/src/mesa/drivers/dri/i965/brw_cfg.h @@ -109,6

[Mesa-dev] [PATCH 15/20] i965/cfg: Point to bblock_t containing associated control flow

2014-07-24 Thread Matt Turner
... rather than pointing directly to the associated instruction. This will let us set the block containing the IF statement's else-pointer to NULL, when we delete a useless ELSE instruction, as in the case (+f0) if(8) ... else(8) endif(8) Also, remove the pointer to the ENDIF, since

[Mesa-dev] [PATCH 14/20] i965/fs: Preserve CFG in register allocation.

2014-07-24 Thread Matt Turner
--- src/mesa/drivers/dri/i965/brw_fs.h| 4 ++-- src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp | 20 2 files changed, 14 insertions(+), 10 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.h b/src/mesa/drivers/dri/i965/brw_fs.h index

[Mesa-dev] [PATCH 17/20] i965: Preserve CFG when deleting dead control flow.

2014-07-24 Thread Matt Turner
This pass deletes an IF/ELSE/ENDIF or IF/ENDIF sequence, or the ELSE in an ELSE/ENDIF sequence. In the typical case (where IF and ENDIF) aren't the only instructions in their basic blocks, we can simply remove the instructions (implicitly deleting the block containing only the ELSE), and attempt

[Mesa-dev] [PATCH 12/20] i965: Add invalidate_cfg parameter to invalidate_live_intervals().

2014-07-24 Thread Matt Turner
Will let us avoid invalidating the CFG if the optimization pass has removed instructions using the new basic block methods. --- src/mesa/drivers/dri/i965/brw_fs.h| 2 +- src/mesa/drivers/dri/i965/brw_fs_live_variables.cpp | 5 +++-- src/mesa/drivers/dri/i965/brw_shader.h

[Mesa-dev] [PATCH 13/20] i965: Use basic-block aware insertion/removal functions.

2014-07-24 Thread Matt Turner
To avoid invalidating and recreating the control flow graph. Also stop invalidating the CFG in places we didn't add or remove an instruction. cfg calculations: 202951 - 80307 (-60.43%) --- src/mesa/drivers/dri/i965/brw_fs.cpp | 45 +-

  1   2   >