On 07/03/15 19:38, Emil Velikov wrote:
On 07/03/15 07:23, Jose Fonseca wrote:
...
we still
didn't eliminate the use of non-portable _MTX_INITIALIZER_NP from Mesa
tree gave me pause.
The only way I can think about resolving this, is to use call_once() to
initialize the mutex,
Yes, I'm afraid
Giuseppe Bilotta giuseppe.bilo...@gmail.com writes:
The pipe's get_vendor method returns something more akin to a driver
vendor string in most cases, instead of the actual device vendor. Use
get_device_vendor instead, which was introduced specifically for this
purpose.
For this patch:
Hello,
Thanks for the email. I am currently updating the proposal now.
Best,
Juliet
On Mon, Mar 9, 2015 at 12:32 PM, Emil Velikov emil.l.veli...@gmail.com
wrote:
On 04/03/15 11:21, Juliet Fru wrote:
Hello,
Here is my proposal for Adding Porting Glean tests to piglit. I'll like
to get
My passing --force autoreconf will update all the aux files, which would
otherwise be ignored if one updates autoconf/automake.
Quote the ORIGDIR variable to prevent fall-outs, when it's name contains
space.
Signed-off-by: Emil Velikov emil.l.veli...@gmail.com
---
autogen.sh | 4 ++--
1 file
On 04/03/15 11:21, Juliet Fru wrote:
Hello,
Here is my proposal for Adding Porting Glean tests to piglit. I'll like
to get your comments and tweaks.
Thanks,
Juliet
Porting Glean tests to Piglit framework OPW Proposal
Hello,
Here is my proposal:
Porting Glean Tests to Piglit GSoC Proposal
Contact Informaion:Names:Achere Juliet F. Forchibe
E-mail address: juliet...@gmail.com
IRC Nick: Jul13t
Mentors: Brian Paul, Laura Ekstrand
Project Information
Porting Glean Tests to the Piglit framework.
Brief
Hi Emil,
The resolve looks good, however I think it would also make sense to
cherry pick a44606 to the stable branch. It doesn't do any harm either
way but it should be slightly faster and cleaner with that patch as
well.
Regards,
- Neil
Emil Velikov emil.l.veli...@gmail.com writes:
On 4
Haswell hardware seems to ignore Render Stream Select bits from
3DSTATE_STREAMOUT packet when the SOL stage is disabled even if
the PRM says otherwise. Because of this, all primitives are sent
down the pipeline for rasterization, which is wrong. If SOL is
enabled, Render Stream Select is honored
On Thursday 05 March 2015, Ian Romanick wrote:
On 03/05/2015 10:56 AM, Fredrik Höglund wrote:
There is no need to check if these extensions are supported here;
if the data type is not supported, we will already have returned a
GL_INVALID_ENUM error.
From where would GL_INVALID_ENUM have
This fixes the GL_COMPRESSED_RED_RGTC1 part of piglit's rgtc-teximage-01
test as well as the precision part of Wine's 3dc format test (fd.o bug
89156).
The Z component seems to contain a lower precision version of the
result, probably a temporary value from the decompression computation.
The Y
On Fri, Mar 6, 2015 at 10:10 PM, Vinson Lee v...@freedesktop.org wrote:
brw_shader.cpp: In function ‘bool brw_saturate_immediate(brw_reg_type,
brw_reg*)’:
brw_shader.cpp:618:31: warning: ‘sat_imm.brw_saturate_immediate(brw_reg_type,
brw_reg*)::anonymous union::ud’ may be used uninitialized
On Fri, Mar 6, 2015 at 9:56 PM, Vinson Lee v...@freedesktop.org wrote:
i915_fragprog.c: In function ‘i915ValidateFragmentProgram’:
i915_fragprog.c:1453:11: warning: variable ‘k’ set but not used
[-Wunused-but-set-variable]
int k;
^
Signed-off-by: Vinson Lee
On Mon, Mar 9, 2015 at 12:26 PM, Stefan Dösinger stefandoesin...@gmx.at wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Am 2015-03-09 um 17:19 schrieb Ilia Mirkin:
It also has the additional problem that it doesn't do the swizzle
workaround which apparently is necessary even for
On Mon, Mar 9, 2015 at 11:15 AM, Stefan Dösinger stefandoesin...@gmx.at wrote:
This fixes the GL_COMPRESSED_RED_RGTC1 part of piglit's rgtc-teximage-01
test as well as the precision part of Wine's 3dc format test (fd.o bug
89156).
This is often identified in the commit message with
Bugzilla:
On Wed, Mar 4, 2015 at 4:41 PM, Laura Ekstrand la...@jlekstrand.net wrote:
Adds a useful comment and some whitespace. Fixes an error message.
v2: Review from Anuj Phogat
- Split rebase of Tex[ture]Buffer[Range]
---
src/mesa/main/teximage.c | 12 ++--
1 file changed, 10
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hi,
Thanks for the quick feedback!
Am 2015-03-09 um 16:20 schrieb Ilia Mirkin:
I don't suppose you've tried adding RGTC1_SNORM/LATC1_SNORM into
that condition?
No, because the codepath isn't entered for them at all. There's an
if(format !=
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Am 2015-03-09 um 17:19 schrieb Ilia Mirkin:
It also has the additional problem that it doesn't do the swizzle
workaround which apparently is necessary even for single-component
textures.
Do you mean the change I made in my patch? That part works
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Am 2015-03-09 um 16:53 schrieb Stefan Dösinger:
I did test if LATC_UNORM and LATC_SNORM still work after my fix.
LATC_SNORM is unchanged (broken in the same way as RGTC_SNORM) and
LATC_UNORM now has the proper precision like RGTC_UNORM.
I think
On 07/03/15 22:09, Vinson Lee wrote:
Suggested-by: Emil Velikov emil.l.veli...@gmail.com
Signed-off-by: Vinson Lee v...@freedesktop.org
Reviewed-by: Emil Velikov emil.l.veli...@gmail.com
Looks great. Thanks.
Emil
---
configure.ac | 1 +
scons/gallium.py | 1 +
src/util/macros.h | 6
On Mon, Mar 9, 2015 at 4:52 AM, Emil Velikov emil.l.veli...@gmail.com wrote:
My passing --force autoreconf will update all the aux files, which would
s/My/By/
otherwise be ignored if one updates autoconf/automake.
Quote the ORIGDIR variable to prevent fall-outs, when it's name contains
https://bugs.freedesktop.org/show_bug.cgi?id=89477
Mark Janes mark.a.ja...@intel.com changed:
What|Removed |Added
Status|NEW |RESOLVED
On Wed, Mar 4, 2015 at 4:41 PM, Laura Ekstrand la...@jlekstrand.net wrote:
This divides a major rework of Tex[ture]Buffer[Range] into multiple patches as
recommended by Anuj Phogat.
Laura Ekstrand (7):
main: Add utility function _mesa_lookup_bufferobj_err.
main: Use
On Mon, Mar 9, 2015 at 11:09 AM, Anuj Phogat anuj.pho...@gmail.com wrote:
On Wed, Mar 4, 2015 at 3:44 PM, Laura Ekstrand la...@jlekstrand.net wrote:
This cleans up ARB_direct_state_access texture cube map functions
(mostly in response to reviews from Anuj Phogat).
Laura Ekstrand (6):
main:
On Mon, Mar 9, 2015 at 12:11 PM, Stefan Dösinger stefandoesin...@gmx.at wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Am 2015-03-09 um 16:53 schrieb Stefan Dösinger:
I did test if LATC_UNORM and LATC_SNORM still work after my fix.
LATC_SNORM is unchanged (broken in the same way as
On Mon, Mar 9, 2015 at 9:43 AM, Laura Ekstrand la...@jlekstrand.net wrote:
I'm confused which hunk you talking about. Can you be more specific?
On Mon, Mar 9, 2015 at 8:47 AM, Anuj Phogat anuj.pho...@gmail.com wrote:
On Wed, Mar 4, 2015 at 4:41 PM, Laura Ekstrand la...@jlekstrand.net
wrote:
On Wed, Mar 4, 2015 at 3:44 PM, Laura Ekstrand la...@jlekstrand.net wrote:
This cleans up ARB_direct_state_access texture cube map functions
(mostly in response to reviews from Anuj Phogat).
Laura Ekstrand (6):
main: _mesa_cube_level_complete checks NumLayers.
main: Remove redundant
In Skylake the order of the arguments for sample messages with the LD
type are u, v, lod, r whereas previously they were u, lod, v, r.
This fixes 144 Piglit tests including ones that directly use
texelFetch and also some using the meta stencil blit path which
appears to use texelFetch in its
I'm confused which hunk you talking about. Can you be more specific?
On Mon, Mar 9, 2015 at 8:47 AM, Anuj Phogat anuj.pho...@gmail.com wrote:
On Wed, Mar 4, 2015 at 4:41 PM, Laura Ekstrand la...@jlekstrand.net
wrote:
Adds a useful comment and some whitespace. Fixes an error message.
v2:
LGTM
Reviewed-by: Jason Ekstrand jason.ekstr...@intel.com
On Mon, Mar 9, 2015 at 1:58 AM, Kenneth Graunke kenn...@whitecape.org
wrote:
Array variable copy splitting generates a bunch of stuff we want to
clean up before proceeding.
Signed-off-by: Kenneth Graunke kenn...@whitecape.org
Cc:
GL_AMD_performance_monitor is supported by nvc0, svga, freedreno,
r600 and radeonsi.
Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com
---
docs/relnotes/10.6.0.html | 1 +
1 file changed, 1 insertion(+)
diff --git a/docs/relnotes/10.6.0.html b/docs/relnotes/10.6.0.html
index
On 03/09/2015 10:43 PM, Marek Olšák wrote:
It would be better to add this function to u_helpers.c/.h instead of
adding new files.
Mmh, I'll probably introduce other functions related to queries when
nouveau-perfkit will be ready.
Are you sure it's a good idea to drop this file?
Marek
On 03/09/2015 11:00 PM, Marek Olšák wrote:
If you plan to add more functions, this file can stay.
Yes, it's my plan.
Marek
On Mon, Mar 9, 2015 at 10:54 PM, Samuel Pitoiset
samuel.pitoi...@gmail.com wrote:
On 03/09/2015 10:43 PM, Marek Olšák wrote:
It would be better to add this
It looks like this has existed since
commit f5a477ab76b6e0b268387699cd2253a43db0dfae
Author: Ian Romanick ian.d.roman...@intel.com
Date: Mon Dec 16 11:54:08 2013 -0800
meta: Refactor shader generation code out of mipmap generation path
Valgrind was complaining on fbo-generatemipmap-formats
According to the spec of GL_AMD_performance_monitor, valid type values
returned are UNSIGNED_INT, UNSIGNED_INT64_AMD, PERCENTAGE_AMD, FLOAT.
This also introduces the new field group_id in order to categorize
queries into groups.
Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com
---
This will be used by GL_AMD_performance_monitor.
Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com
---
src/gallium/include/pipe/p_defines.h | 8
1 file changed, 8 insertions(+)
diff --git a/src/gallium/include/pipe/p_defines.h
b/src/gallium/include/pipe/p_defines.h
index
This enables GL_AMD_performance_monitor for freedreno.
Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com
---
src/gallium/drivers/freedreno/freedreno_query.c | 9 +
src/gallium/drivers/freedreno/freedreno_query.h | 1 +
2 files changed, 10 insertions(+)
diff --git
Done.
On Mon, Mar 9, 2015 at 1:37 PM, Laura Ekstrand la...@jlekstrand.net wrote:
Can you go and manually mark this commit and the Add entry point for
TextureBufferRange as accepted in Patchwork? I don't have admin access,
and my refactor of the new line caused a rebase.
Thanks.
Laura
On
Reviewed-by: Marek Olšák marek.ol...@amd.com
Marek
On Mon, Mar 9, 2015 at 10:09 PM, Samuel Pitoiset
samuel.pitoi...@gmail.com wrote:
This enables GL_AMD_performance_monitor for radeon.
Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com
---
Pushed, thanks.
Marek
On Wed, Feb 25, 2015 at 7:50 AM, Alexandre Demers
alexandre.f.dem...@gmail.com wrote:
Lets define R600_MAX_VIEWPORTS instead of using 16 here and there
in the code when looping through viewports and scissors. It is
easier to understand what this number represents.
v2:
On Mon, Mar 9, 2015 at 10:09 PM, Samuel Pitoiset
samuel.pitoi...@gmail.com wrote:
According to the spec of GL_AMD_performance_monitor, valid type values
returned are UNSIGNED_INT, UNSIGNED_INT64_AMD, PERCENTAGE_AMD, FLOAT.
This also introduces the new field group_id in order to categorize
It would be better to add this function to u_helpers.c/.h instead of
adding new files.
Marek
On Mon, Mar 9, 2015 at 10:09 PM, Samuel Pitoiset
samuel.pitoi...@gmail.com wrote:
This function can be used to get a generic group of driver-specific
queries when a driver doesn't expose any groups.
This enables GL_AMD_performance_monitor for radeon.
Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com
---
src/gallium/drivers/radeon/r600_pipe_common.c | 9 +
src/gallium/drivers/radeon/r600_pipe_common.h | 1 +
2 files changed, 10 insertions(+)
diff --git
From: Christoph Bumiller e0425...@student.tuwien.ac.at
This is based on the original patch of Christoph Bumiller.
(source: http://people.freedesktop.org/~chrisbmr/perfmon.diff)
As for the Gallium HUD, we keep a list of busy queries in a ring
buffer in order to prevent stalls when reading
Driver queries are organized as a single hierarchy where queries are
categorized into groups. Each goup has a list of queries and a maximum
number of queries that can be sampled. The list of available groups can
be obtained using pipe_screen::get_driver_query_group_info.
This will be used by
This enables GL_AMD_performance_monitor for nvc0.
Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com
---
src/gallium/drivers/nouveau/nvc0/nvc0_query.c | 10 ++
src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 1 +
src/gallium/drivers/nouveau/nvc0/nvc0_screen.h | 3 +++
3 files
GL_AMD_performance_monitor must return an error when a monitoring
session cannot be started.
Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com
---
src/gallium/drivers/freedreno/freedreno_query.c| 4 ++--
src/gallium/drivers/freedreno/freedreno_query.h| 2 +-
This enables GL_AMD_performance_monitor for svga.
Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com
---
src/gallium/drivers/svga/svga_context.h | 1 +
src/gallium/drivers/svga/svga_screen.c | 11 +++
2 files changed, 12 insertions(+)
diff --git
Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com
---
src/gallium/drivers/nouveau/nvc0/nvc0_query.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_query.c
b/src/gallium/drivers/nouveau/nvc0/nvc0_query.c
index
On Monday, March 09, 2015 11:44:18 AM Ben Widawsky wrote:
It looks like this has existed since
commit f5a477ab76b6e0b268387699cd2253a43db0dfae
Author: Ian Romanick ian.d.roman...@intel.com
Date: Mon Dec 16 11:54:08 2013 -0800
meta: Refactor shader generation code out of mipmap
Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com
---
src/gallium/drivers/nouveau/nvc0/nvc0_query.c | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_query.c
b/src/gallium/drivers/nouveau/nvc0/nvc0_query.c
index
This function can be used to get a generic group of driver-specific
queries when a driver doesn't expose any groups.
Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com
---
src/gallium/auxiliary/Makefile.sources | 1 +
src/gallium/auxiliary/util/u_query.c | 50
Hello,
A series I have waited too long to re-submit, but I recently refactored the
code and fixed some minor issues.
This patchset enables GL_AMD_performance_monitor for svga, freedreno, r600,
radeonsi and nvc0 drivers.
This code has been tested with Nouveau (NVD9 and NVE7) but it should also
This patch exposes Driver statistics and MP counters groups.
Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com
---
src/gallium/drivers/nouveau/nvc0/nvc0_query.c | 61 --
src/gallium/drivers/nouveau/nvc0/nvc0_screen.h | 11 +
2 files changed, 69 insertions(+),
On 03/09/2015 10:36 PM, Marek Olšák wrote:
On Mon, Mar 9, 2015 at 10:09 PM, Samuel Pitoiset
samuel.pitoi...@gmail.com wrote:
According to the spec of GL_AMD_performance_monitor, valid type values
returned are UNSIGNED_INT, UNSIGNED_INT64_AMD, PERCENTAGE_AMD, FLOAT.
This also introduces the
If you plan to add more functions, this file can stay.
Marek
On Mon, Mar 9, 2015 at 10:54 PM, Samuel Pitoiset
samuel.pitoi...@gmail.com wrote:
On 03/09/2015 10:43 PM, Marek Olšák wrote:
It would be better to add this function to u_helpers.c/.h instead of
adding new files.
Mmh, I'll
Can you go and manually mark this commit and the Add entry point for
TextureBufferRange as accepted in Patchwork? I don't have admin access,
and my refactor of the new line caused a rebase.
Thanks.
Laura
On Mon, Mar 9, 2015 at 1:13 PM, Laura Ekstrand la...@jlekstrand.net wrote:
Oh, thanks!
On Sun, Mar 8, 2015 at 1:08 AM, Kenneth Graunke kenn...@whitecape.org wrote:
Welcome to the rabbit trail. In order to fix Football Manager, I had to
rework INTEL_DEBUG=shader_time in the FS backend. While doing that, I
hit two assertion failures. After fixing that, I compared numbers.
I
Oh, thanks! I didn't see the new line there when I read your review. I
will remove it.
On Mon, Mar 9, 2015 at 10:45 AM, Anuj Phogat anuj.pho...@gmail.com wrote:
On Mon, Mar 9, 2015 at 9:43 AM, Laura Ekstrand la...@jlekstrand.net
wrote:
I'm confused which hunk you talking about. Can you be
I'm going to push this shortly. Thanks.
Marek
On Mon, Mar 9, 2015 at 4:15 PM, Stefan Dösinger stefandoesin...@gmx.at wrote:
This fixes the GL_COMPRESSED_RED_RGTC1 part of piglit's rgtc-teximage-01
test as well as the precision part of Wine's 3dc format test (fd.o bug
89156).
The Z component
On Sun, Mar 8, 2015 at 1:08 AM, Kenneth Graunke kenn...@whitecape.org wrote:
This makes another part of the INTEL_DEBUG=shader_time code emittable
at arbitrary locations, rather than just at the end of the instruction
stream.
v2: Don't lose smear! Caught by Topi Pohjolainen.
v3: Don't set
On Thu, Feb 26, 2015 at 6:14 PM, Ben Widawsky
benjamin.widaw...@intel.com wrote:
Recomendation [sic] is to set this field to 1 always. Programming it to
default
value of 0, may have -ve impact on performance for MSAA WLs.
Another don't suck bit which needs to get set.
Totally untested.
https://bugs.freedesktop.org/show_bug.cgi?id=77449
Bug 77449 depends on bug 86747, which changed state.
Bug 86747 Summary: Noise in Football Manager 2014 textures
https://bugs.freedesktop.org/show_bug.cgi?id=86747
What|Removed |Added
On Thu, Mar 5, 2015 at 12:20 AM, Eduardo Lima Mitev el...@igalia.com
wrote:
Internal PBO functions such as _mesa_map_validate_pbo_source() and
_mesa_validate_pbo_compressed_teximage() perform validation and buffer
mapping
within the same call.
This patch takes out the validation into
Pohjolainen, Topi topi.pohjolai...@intel.com writes:
On Sat, Mar 07, 2015 at 04:15:08PM +0200, Francisco Jerez wrote:
Topi Pohjolainen topi.pohjolai...@intel.com writes:
The original patch from Curro was based on something that is not
present in the master yet. This patch tries to mimick
On Tue, Feb 24, 2015 at 09:34:30PM -0800, Kenneth Graunke wrote:
We haven't implemented proper unsynchronized map support on !LLC systems
(pre-SNB, Atom). MapBufferRange with GL_MAP_UNSYNCHRONIZE_BIT will
actually do a synchronized map, probably killing performance.
Also warn on
The blit engine in GEN hardware has constraints. These constraints are a
function of tile parameters as well as height. The current code is very dumb in
terms of determine max blit parameters. Since we'll be expanding on it, having
the abstraction makes things easier.
Note that this doesn't
This patch will use a new calculation to determine if a surface can be blitted
from or to. Previously, the total_height member was used. Total_height in the
case of 2d, 3d, and cube map arrays is the height of each slice/layer/face.
Since the GL map APIS only ever deal with a slice at a time
IMHO, intel_miptree_choose_tiling() is an unfortunate incarnation because it
conflates what is permitted vs. what is desirable. This makes doing any sort of
fallback operations after the fact somewhat kludgey.
The original code basically says:
if we requested x XOR y-tiled, and the region
The spec does say that the blitter is capable of transferring 64k scanlines in a
single blit operation. Perhaps this was true, or is still true on some
operations, but for all commands that we use, we are restricted to 16b signed:
For example, from the XY_SRC_COPY_CHROMA_BLT definition:
The blit engine is limited to 32Kx32K transfer. In cases where we have to fall
back to the blitter, and when trying to blit a slice of a 2d texture array, or
face of a cube map, we don't need to transfer the entire texture.
I doubt this patch will get exercised at this point since we'll always
With the direct PBO upload, I guess the main thing this series offers (other
than cleanups), is we can now allocate large BOs as Y-tiled since the code
permits them to be blitted. Originally, the patch series did enable the use of
blitter more often, and it resulted in some huge perf gains. There
Signed-off-by: Ben Widawsky b...@bwidawsk.net
---
src/mesa/drivers/dri/i965/intel_blit.c| 11 ++-
src/mesa/drivers/dri/i965/intel_blit.h| 3 +++
src/mesa/drivers/dri/i965/intel_copy_image.c | 7 ---
src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 9 +
4
On Fri, Feb 20, 2015 at 10:31:08PM +, Neil Roberts wrote:
The render surface state command for Skylake doesn't have the surface
array spacing bit so I don't think it's possible to select this
layout. This avoids a kernel panic when running the piglit test below:
Kernel panic!? Please, go
Looks good to me.
Reviewed-by: Laura Ekstrand la...@jlekstrand.net
On Thu, Mar 5, 2015 at 12:20 AM, Eduardo Lima Mitev el...@igalia.com
wrote:
This patch adds two types of checks to the gl(Compressed)Tex(Sub)Imgage
family
of functions when a pixel buffer object is bound to
Reviewed-by: Connor Abbott cwabbo...@gmail.com
On Mon, Mar 9, 2015 at 9:36 PM, Kenneth Graunke kenn...@whitecape.org wrote:
From: Jason Ekstrand jason.ekstr...@intel.com
__next and __prev are pointers to the structure containing the exec_node
link, not the embedded exec_node. NULL checks
Push it!
On Mar 9, 2015 7:03 PM, Connor Abbott cwabbo...@gmail.com wrote:
Reviewed-by: Connor Abbott cwabbo...@gmail.com
I was in the middle of rewriting this pass for making derefs
instructions, which hasn't been going nearly as nicely as I would like
(ugh...), so if it pans out then I'll
On Mon, Mar 9, 2015 at 7:28 PM, Matt Turner matts...@gmail.com wrote:
On Mon, Mar 9, 2015 at 7:04 PM, Jason Ekstrand ja...@jlekstrand.net
wrote:
Push it!
Our policy is to wait a day for most things.
Sure. Not really arguing for early pushing. Mostly just surprised that
Connor picked up
On Mon, Mar 9, 2015 at 7:24 PM, Matt Turner matts...@gmail.com wrote:
On Mon, Mar 9, 2015 at 6:36 PM, Kenneth Graunke kenn...@whitecape.org wrote:
From: Jason Ekstrand jason.ekstr...@intel.com
__next and __prev are pointers to the structure containing the exec_node
link, not the embedded
On Mon, Mar 9, 2015 at 7:58 PM, Matt Turner matts...@gmail.com wrote:
On Mon, Mar 9, 2015 at 7:32 PM, Jason Ekstrand ja...@jlekstrand.net
wrote:
On Mon, Mar 9, 2015 at 7:24 PM, Matt Turner matts...@gmail.com wrote:
On Mon, Mar 9, 2015 at 6:36 PM, Kenneth Graunke kenn...@whitecape.org
Previously, we stored derefs in a hash table, using the malloc'd pointer
as the key. Then, we walked through the hash table and generated code,
based on the order of the hash table's elements.
Memory addresses returned by malloc are pretty much random, which meant
that the hash was random, and
From: Jason Ekstrand jason.ekstr...@intel.com
__next and __prev are pointers to the structure containing the exec_node
link, not the embedded exec_node. NULL checks would fail unless the
embedded exec_node happened to be at offset 0 in the parent struct.
Signed-off-by: Jason Ekstrand
On Mon, Mar 9, 2015 at 6:36 PM, Kenneth Graunke kenn...@whitecape.org wrote:
From: Jason Ekstrand jason.ekstr...@intel.com
__next and __prev are pointers to the structure containing the exec_node
link, not the embedded exec_node. NULL checks would fail unless the
embedded exec_node happened
On Mon, Mar 9, 2015 at 7:24 PM, Matt Turner matts...@gmail.com wrote:
On Mon, Mar 9, 2015 at 6:36 PM, Kenneth Graunke kenn...@whitecape.org
wrote:
From: Jason Ekstrand jason.ekstr...@intel.com
__next and __prev are pointers to the structure containing the exec_node
link, not the
On Mon, Mar 9, 2015 at 7:48 PM, Connor Abbott cwabbo...@gmail.com wrote:
On Mon, Mar 9, 2015 at 10:35 PM, Matt Turner matts...@gmail.com wrote:
On Mon, Mar 9, 2015 at 7:24 PM, Matt Turner matts...@gmail.com wrote:
On Mon, Mar 9, 2015 at 6:36 PM, Kenneth Graunke kenn...@whitecape.org
wrote:
On Mon, Mar 9, 2015 at 11:02 PM, Jason Ekstrand ja...@jlekstrand.net wrote:
On Mon, Mar 9, 2015 at 7:59 PM, Connor Abbott cwabbo...@gmail.com wrote:
On Mon, Mar 9, 2015 at 10:54 PM, Jason Ekstrand ja...@jlekstrand.net
wrote:
On Mon, Mar 9, 2015 at 7:48 PM, Connor Abbott
Reviewed-by: Connor Abbott cwabbo...@gmail.com
I was in the middle of rewriting this pass for making derefs
instructions, which hasn't been going nearly as nicely as I would like
(ugh...), so if it pans out then I'll have to think about it a little
more to make sure the new version is
On Mon, Mar 9, 2015 at 10:35 PM, Matt Turner matts...@gmail.com wrote:
On Mon, Mar 9, 2015 at 7:24 PM, Matt Turner matts...@gmail.com wrote:
On Mon, Mar 9, 2015 at 6:36 PM, Kenneth Graunke kenn...@whitecape.org
wrote:
From: Jason Ekstrand jason.ekstr...@intel.com
__next and __prev are
On Fri, Feb 20, 2015 at 10:31:07PM +, Neil Roberts wrote:
On Skylake it is possible to choose your own alignment values for
compressed textures but they are expressed as a multiple of the block
size. The minimum alignment value we can use is 4 so we effectively
have to align to 4 times the
*I am interested on write tests for OpenGL 4.0 /GLSL 4.00 .*
*But can you be more specify what areas you are expecting to be
tested, Thank you!*
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
From: Marius Predut marius.pre...@intel.com
Brain Paul review suggestion: there's more macro use here than necessary.
Removed and redefine some #define preprocessing directives.
Removed the directive input parameter 'T' .
No functional changes.
Signed-off-by: Marius Predut
On Mon, Mar 9, 2015 at 7:04 PM, Jason Ekstrand ja...@jlekstrand.net wrote:
Push it!
Our policy is to wait a day for most things.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
On 09.03.2015 18:06, Giuseppe Bilotta wrote:
On Mon, Mar 9, 2015 at 5:01 AM, Michel Dänzer mic...@daenzer.net wrote:
The shortlog of patch 4 should be prefixed by gallium: as well.
Duh, I forgot the prefix everywhere. And the signoff line.
Specifically about the last patch, the one that
On Mon, Mar 9, 2015 at 7:32 PM, Jason Ekstrand ja...@jlekstrand.net wrote:
On Mon, Mar 9, 2015 at 7:24 PM, Matt Turner matts...@gmail.com wrote:
On Mon, Mar 9, 2015 at 6:36 PM, Kenneth Graunke kenn...@whitecape.org
wrote:
From: Jason Ekstrand jason.ekstr...@intel.com
__next and __prev
On Mon, Mar 9, 2015 at 10:54 PM, Jason Ekstrand ja...@jlekstrand.net wrote:
On Mon, Mar 9, 2015 at 7:48 PM, Connor Abbott cwabbo...@gmail.com wrote:
On Mon, Mar 9, 2015 at 10:35 PM, Matt Turner matts...@gmail.com wrote:
On Mon, Mar 9, 2015 at 7:24 PM, Matt Turner matts...@gmail.com wrote:
On Mon, Mar 9, 2015 at 7:59 PM, Connor Abbott cwabbo...@gmail.com wrote:
On Mon, Mar 9, 2015 at 10:54 PM, Jason Ekstrand ja...@jlekstrand.net
wrote:
On Mon, Mar 9, 2015 at 7:48 PM, Connor Abbott cwabbo...@gmail.com
wrote:
On Mon, Mar 9, 2015 at 10:35 PM, Matt Turner
On Mon, Mar 9, 2015 at 5:01 AM, Michel Dänzer mic...@daenzer.net wrote:
The shortlog of patch 4 should be prefixed by gallium: as well.
Duh, I forgot the prefix everywhere. And the signoff line.
Specifically about the last patch, the one that actually touches
clover, is there a criteria for
No functional change. In preparation for supporting vertex shaders,
this adds a switch statement on shader stage (since vertex attributes
and fragment shader varyings will need different handling). It also
renames varying to input, to be more general.
Signed-off-by: Kenneth Graunke
Adapted from fs_visitor::visit(ir_variable *).
Signed-off-by: Kenneth Graunke kenn...@whitecape.org
---
src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 16 +++-
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp
Array variable copy splitting generates a bunch of stuff we want to
clean up before proceeding.
Signed-off-by: Kenneth Graunke kenn...@whitecape.org
Cc: Jason Ekstrand ja...@jlekstrand.net
---
src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 3 +++
1 file changed, 3 insertions(+)
diff --git
Signed-off-by: Kenneth Graunke kenn...@whitecape.org
---
src/mesa/drivers/dri/i965/brw_fs.cpp | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp
b/src/mesa/drivers/dri/i965/brw_fs.cpp
index 428234f..ee5bc4a 100644
---
1 - 100 of 107 matches
Mail list logo
