Re: [Mesa-dev] [PATCH 3/3] llvmpipe: add sse code for fixed position calculation

2016-01-04 Thread Jose Fonseca
On 02/01/16 20:39, srol...@vmware.com wrote: From: Roland Scheidegger This is quite a few less instructions, albeit still do the 2 64bit muls with scalar c code (they'd need way more shuffles, plus fixup for the signed mul so it totally doesn't seem worth it - x86 can do

Re: [Mesa-dev] [PATCH 5/5] nvc0: add ARB_indirect_parameters support

2016-01-04 Thread Samuel Pitoiset
Did you write piglit tests for this new extension? I don't see any tests which use MultiDrawArraysIndirectCountARB() or MultiDrawElementsIndirectCountARB(). Are you going to submit the rest of the series for nvc0? On 01/02/2016 09:38 PM, Ilia Mirkin wrote: I chose to make separate macros

Re: [Mesa-dev] [PATCH] nir: few missing struct names

2016-01-04 Thread eocallaghan
Reviewed-by: Edward O'Callaghan On 2016-01-05 05:27, Rob Clark wrote: From: Rob Clark nir.h is a bit inconsistent about 'typedef struct {} nir_foo' vs 'typedef struct nir_foo {} nir_foo'. But missing struct name tags is inconvenient

Re: [Mesa-dev] [PATCH 5/5] nvc0: add ARB_indirect_parameters support

2016-01-04 Thread Ilia Mirkin
On Mon, Jan 4, 2016 at 3:04 PM, Samuel Pitoiset wrote: > Did you write piglit tests for this new extension? > I don't see any tests which use MultiDrawArraysIndirectCountARB() or > MultiDrawElementsIndirectCountARB(). http://patchwork.freedesktop.org/patch/69334/ > >

Re: [Mesa-dev] [PATCH 1/8] tgsi: add ureg support for image decls

2016-01-04 Thread Ilia Mirkin
On Mon, Jan 4, 2016 at 3:25 PM, Ilia Mirkin wrote: > On Mon, Jan 4, 2016 at 3:13 PM, Samuel Pitoiset > wrote: >> On 01/03/2016 05:37 AM, Ilia Mirkin wrote: >>> Signed-off-by: Ilia Mirkin >>> diff --git

Re: [Mesa-dev] [PATCH 1/8] tgsi: add ureg support for image decls

2016-01-04 Thread Samuel Pitoiset
On 01/04/2016 09:25 PM, Ilia Mirkin wrote: On Mon, Jan 4, 2016 at 3:13 PM, Samuel Pitoiset wrote: On 01/03/2016 05:37 AM, Ilia Mirkin wrote: Signed-off-by: Ilia Mirkin diff --git a/src/gallium/auxiliary/tgsi/tgsi_strings.c

Re: [Mesa-dev] [PATCH 1/8] tgsi: add ureg support for image decls

2016-01-04 Thread Samuel Pitoiset
On 01/03/2016 05:37 AM, Ilia Mirkin wrote: Signed-off-by: Ilia Mirkin --- src/gallium/auxiliary/tgsi/tgsi_build.c| 62 + src/gallium/auxiliary/tgsi/tgsi_dump.c | 10 +-- src/gallium/auxiliary/tgsi/tgsi_parse.c| 4

Re: [Mesa-dev] [PATCH 2/8] ureg: add buffer support to ureg

2016-01-04 Thread Ilia Mirkin
RES is split into two -- BUFFER and IMAGE. On Mon, Jan 4, 2016 at 3:22 PM, Samuel Pitoiset wrote: > I assume this is going to replace the old RES stuff? > > > On 01/03/2016 05:37 AM, Ilia Mirkin wrote: >> >> Signed-off-by: Ilia Mirkin >> --- >>

Re: [Mesa-dev] [PATCH 1/8] tgsi: add ureg support for image decls

2016-01-04 Thread Ilia Mirkin
On Mon, Jan 4, 2016 at 3:13 PM, Samuel Pitoiset wrote: > On 01/03/2016 05:37 AM, Ilia Mirkin wrote: >> Signed-off-by: Ilia Mirkin >> diff --git a/src/gallium/auxiliary/tgsi/tgsi_strings.c >> b/src/gallium/auxiliary/tgsi/tgsi_strings.c >> index

Re: [Mesa-dev] [PATCH 5/5] nvc0: add ARB_indirect_parameters support

2016-01-04 Thread Samuel Pitoiset
On 01/04/2016 09:18 PM, Ilia Mirkin wrote: On Mon, Jan 4, 2016 at 3:04 PM, Samuel Pitoiset wrote: Did you write piglit tests for this new extension? I don't see any tests which use MultiDrawArraysIndirectCountARB() or MultiDrawElementsIndirectCountARB().

Re: [Mesa-dev] [PATCH 2/8] ureg: add buffer support to ureg

2016-01-04 Thread Samuel Pitoiset
I assume this is going to replace the old RES stuff? On 01/03/2016 05:37 AM, Ilia Mirkin wrote: Signed-off-by: Ilia Mirkin --- src/gallium/auxiliary/tgsi/tgsi_dump.c | 5 +++ src/gallium/auxiliary/tgsi/tgsi_strings.c | 1 +

[Mesa-dev] [Bug 93570] the image of llvmpipe has a low quality on arm (with too many points on it)

2016-01-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93570 --- Comment #9 from Icenowy Zheng --- I'm sorry, but my device is not capable to build a svn version of LLVM. (The original version of LLVM (3.7) is built on a buildbot, so does Mesa 11.0) Can you provide me a simple

Re: [Mesa-dev] [PATCH v3] mesa: use gl_shader_variable in program resource list

2016-01-04 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Mon, Jan 4, 2016 at 8:55 AM, Tapani Pälli wrote: > Patch changes linker to allocate gl_shader_variable instead of using > ir_variable. This makes it possible to get rid of ir_variables and ir > in memory after

Re: [Mesa-dev] [PATCH v2 1/2] mesa: Map program UBOs and SSBOs to Interface Blocks

2016-01-04 Thread Iago Toral
On Thu, 2015-12-31 at 11:20 -0800, Jordan Justen wrote: > v2: > * Fill UboInterfaceBlockIndex and SsboInterfaceBlockIndex in >split_ubos_and_ssbos (Iago) > > Cc: Samuel Iglesias Gonsálvez > Cc: Iago Toral > Signed-off-by: Jordan Justen

Re: [Mesa-dev] [PATCH v2 2/2] mesa: Use separate indices for UBO & SSBO during binding

2016-01-04 Thread Iago Toral
On Thu, 2015-12-31 at 11:20 -0800, Jordan Justen wrote: > Previously we were treating the binding index for Uniform Buffer > Objects and Shader Storage Buffer Objects as being part of the > combined BufferInterfaceBlocks array. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93322 >

Re: [Mesa-dev] [PATCH] st/mesa: make KHR_debug output independent of context creation flags

2016-01-04 Thread Ilia Mirkin
On Mon, Jan 4, 2016 at 5:34 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Instead, keep track of GL_DEBUG_OUTPUT and (un)install the pipe_debug_callback > accordingly. Hardware drivers can still use the absence of the callback to > skip more

[Mesa-dev] [PATCH v2] st/va: count number of slices

2016-01-04 Thread Julien Isorce
From: Julien Isorce The counter was not set but used by the nouveau driver. It is required otherwise visual output is garbage. Signed-off-by: Julien Isorce --- src/gallium/state_trackers/va/picture.c| 8

[Mesa-dev] [PATCH] st/mesa: make KHR_debug output independent of context creation flags

2016-01-04 Thread Nicolai Hähnle
From: Nicolai Hähnle Instead, keep track of GL_DEBUG_OUTPUT and (un)install the pipe_debug_callback accordingly. Hardware drivers can still use the absence of the callback to skip more expensive operations in the normal case, and users can no longer be surprised by the

Re: [Mesa-dev] [PATCH v2] st/mesa: make KHR_debug output independent of context creation flags (v2)

2016-01-04 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Mon, Jan 4, 2016 at 5:47 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Instead, keep track of GL_DEBUG_OUTPUT and (un)install the pipe_debug_callback > accordingly. Hardware drivers can still

[Mesa-dev] [PATCH v2] st/mesa: make KHR_debug output independent of context creation flags (v2)

2016-01-04 Thread Nicolai Hähnle
From: Nicolai Hähnle Instead, keep track of GL_DEBUG_OUTPUT and (un)install the pipe_debug_callback accordingly. Hardware drivers can still use the absence of the callback to skip more expensive operations in the normal case, and users can no longer be surprised by the

[Mesa-dev] [PATCH 8/8] mesa: minor clean-up of some memcpy/sizeof() calls in m_matrix.c

2016-01-04 Thread Brian Paul
--- src/mesa/math/m_matrix.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/mesa/math/m_matrix.c b/src/mesa/math/m_matrix.c index 6522200..b3cfcd2 100644 --- a/src/mesa/math/m_matrix.c +++ b/src/mesa/math/m_matrix.c @@ -654,7 +654,7 @@ static GLboolean

[Mesa-dev] [PATCH 6/8] mesa: check for z=0 in _mesa_Vertex3dv()

2016-01-04 Thread Brian Paul
It's very rare that a GL app calls glVertex3dv(), but one in particular calls it lot, always with Z = 0. Check for that condition and convert the call into glVertex2f. This reduces VBO memory used and reduces the number of times we have to switch between float[2] and float[3] vertex formats in

[Mesa-dev] [PATCH 3/8] svga: change svga_hw_view_state::dirty to boolean

2016-01-04 Thread Brian Paul
Since it's a true/false value. --- src/gallium/drivers/svga/svga_context.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/svga/svga_context.h b/src/gallium/drivers/svga/svga_context.h index d21b071..e4f29b8 100644 ---

[Mesa-dev] [PATCH 7/8] util: add debug_dump_ubyte_rgba_bmp()

2016-01-04 Thread Brian Paul
Like debug_dump_float_rgba_bmp() but takes ubyte values. --- src/gallium/auxiliary/util/u_debug.c | 59 src/gallium/auxiliary/util/u_debug.h | 4 +++ 2 files changed, 63 insertions(+) diff --git a/src/gallium/auxiliary/util/u_debug.c

[Mesa-dev] [PATCH 5/8] svga: fix test for SVGA_NEW_STIPPLE

2016-01-04 Thread Brian Paul
We only want to set the SVGA_NEW_STIPPLE dirty flag when the polygon stipple state changes. Before, we only set the flag when we were enabling stipple, but not disabling. We don't really have to add SVGA_NEW_STIPPLE to the dirty FS state set since it's a subset of SVGA_NEW_RAST, but let's be

[Mesa-dev] [PATCH 2/2] i965/wm: use binding size for ubo/ssbo when automatic size is unset

2016-01-04 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin Cc: Samuel Iglesias Gonsálvez Cc: Marta Lofstedt --- I have not tested whether this fixes your CTS tests (as I don't have access to them). But it should... and if it doesn't, it'll be a variation

[Mesa-dev] [PATCH 1/2] Revert "i965/wm: use proper API buffer size for the surfaces."

2016-01-04 Thread Ilia Mirkin
This reverts commit 8cf2e892fca20c4776b4a07c39918343cb2d4e0e. It's entirely bogus to attempt to store anything about the binding the buffer object itself, which might be bound any number of times. Signed-off-by: Ilia Mirkin Cc: Samuel Iglesias Gonsálvez

Re: [Mesa-dev] [PATCH 0/4] Actual ARB_multi_draw_indirect support

2016-01-04 Thread Ilia Mirkin
On Mon, Jan 4, 2016 at 10:07 PM, Ian Romanick wrote: > On 12/31/2015 11:55 AM, Ilia Mirkin wrote: >> The current support in mesa for ARB_multi_draw_indirect is pretty >> shameful... it just does N separate draws. Instead make it possible >> for drivers to handle this in a

Re: [Mesa-dev] [PATCH 1/4] vbo: create a new draw function interface for indirect draws

2016-01-04 Thread Ian Romanick
On 12/31/2015 11:55 AM, Ilia Mirkin wrote: > This is optional for now in the transition period, but optimally all > backends that support indirect draws would switch over to it and we can > remove the support for indirect in the "regular" draw function. > > This should allow a backend to properly

Re: [Mesa-dev] [PATCH 1/6] gallium: document PK2H/UP2H

2016-01-04 Thread Ilia Mirkin
On Mon, Jan 4, 2016 at 8:32 PM, Ian Romanick wrote: > On 01/03/2016 10:02 AM, Ilia Mirkin wrote: >> On Sun, Jan 3, 2016 at 12:33 PM, Roland Scheidegger >> wrote: >>> Am 03.01.2016 um 01:37 schrieb Ilia Mirkin: Signed-off-by: Ilia Mirkin

[Mesa-dev] [PATCH v2] vbo: create a new draw function interface for indirect draws

2016-01-04 Thread Ilia Mirkin
All indirect draws are passed to the new draw function. By default there's a fallback implementation which pipes it right back to draw_prims, but eventually both the fallback and draw_prim's support for indirect drawing should be removed. This should allow a backend to properly support

[Mesa-dev] [PATCH 2/8] svga: avoid emitting redundant SetVertexBuffers() commands

2016-01-04 Thread Brian Paul
--- src/gallium/drivers/svga/svga_context.h | 5 + src/gallium/drivers/svga/svga_draw.c| 26 +- 2 files changed, 26 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/svga/svga_context.h b/src/gallium/drivers/svga/svga_context.h index

[Mesa-dev] [PATCH 1/8] svga: check for no-ops in svga_bind_sampler_states()

2016-01-04 Thread Brian Paul
and svga_set_sampler_views(). If there's no change, return early and don't set a SVGA_NEW_x dirty state flag. --- src/gallium/drivers/svga/svga_pipe_sampler.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/svga/svga_pipe_sampler.c

[Mesa-dev] [PATCH 4/8] svga: add some comments in svga_state_vs.c

2016-01-04 Thread Brian Paul
--- src/gallium/drivers/svga/svga_state_vs.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/drivers/svga/svga_state_vs.c b/src/gallium/drivers/svga/svga_state_vs.c index 24574c1..a103dab 100644 --- a/src/gallium/drivers/svga/svga_state_vs.c +++

[Mesa-dev] [PATCH shader-db] si-report: Track max waves per CU

2016-01-04 Thread Tom Stellard
--- si-report.py | 56 ++-- 1 file changed, 54 insertions(+), 2 deletions(-) diff --git a/si-report.py b/si-report.py index ec88112..e717af0 100755 --- a/si-report.py +++ b/si-report.py @@ -65,6 +65,12 @@ def get_scratch_str(value, suffixes =

Re: [Mesa-dev] [PATCH 1/4] vbo: create a new draw function interface for indirect draws

2016-01-04 Thread Ilia Mirkin
On Mon, Jan 4, 2016 at 10:10 PM, Ian Romanick wrote: > On 12/31/2015 11:55 AM, Ilia Mirkin wrote: >> This is optional for now in the transition period, but optimally all >> backends that support indirect draws would switch over to it and we can >> remove the support for

Re: [Mesa-dev] [PATCH 1/4] vbo: create a new draw function interface for indirect draws

2016-01-04 Thread Ilia Mirkin
[adding Ian and Ken, who may or may not be interested] I'd like to push this out in the next couple of days (along with my ARB_indirect_parameters series), but I'd really like to get an ack from someone on the Intel team that such an interface would be acceptable to them. You can see the full

Re: [Mesa-dev] [PATCH 1/6] gallium: document PK2H/UP2H

2016-01-04 Thread Ian Romanick
On 01/03/2016 10:02 AM, Ilia Mirkin wrote: > On Sun, Jan 3, 2016 at 12:33 PM, Roland Scheidegger > wrote: >> Am 03.01.2016 um 01:37 schrieb Ilia Mirkin: >>> Signed-off-by: Ilia Mirkin >>> --- >>> src/gallium/docs/source/tgsi.rst | 10 -- >>> 1

Re: [Mesa-dev] [shader-db PATCH 1/5] run: create debug contexts

2016-01-04 Thread Tom Stellard
On Wed, Dec 30, 2015 at 09:32:38PM -0500, Nicolai Hähnle wrote: > For Gallium-based drivers, this is required for receiving shader information > via debug messages. Patches 2-5 are Acked-by: Tom Stellard > --- > run.c | 1 + > 1 file changed, 1 insertion(+) > > diff

Re: [Mesa-dev] [shader-db PATCH 1/5] run: create debug contexts

2016-01-04 Thread Ian Romanick
On 12/31/2015 09:36 AM, Matt Turner wrote: > On Thu, Dec 31, 2015 at 12:25 PM, Ilia Mirkin wrote: >> On Thu, Dec 31, 2015 at 12:17 PM, Matt Turner wrote: >>> On Thu, Dec 31, 2015 at 9:45 AM, Ilia Mirkin wrote: On Dec 31, 2015

[Mesa-dev] [PATCH] i965: quieten compiler warning about out-of-bounds access

2016-01-04 Thread Ilia Mirkin
gcc 4.9.3 shows the following error: brw_vue_map.c:260:20: warning: array subscript is above array bounds [-Warray-bounds] return brw_names[slot - VARYING_SLOT_MAX]; This is because BRW_VARYING_SLOT_COUNT is a valid value for the enum type. Adding an assert will generate no additional code

[Mesa-dev] ipers performance regression (Was: u_upload_mgr changes)

2016-01-04 Thread Jose Fonseca
On 21/12/15 22:35, Marek Olšák wrote: Hi, This patch series adds more flexibility to u_upload_mgr. First, it adds the ability to specify the alignment per suballocation. The idea is that several users can use the same upload buffer, but each may need a different alignment. Finally, it allows

Re: [Mesa-dev] [PATCH 1/8] tgsi: add ureg support for image decls

2016-01-04 Thread Marek Olšák
For the series: Reviewed-by: Marek Olšák Marek ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] ipers performance regression (Was: u_upload_mgr changes)

2016-01-04 Thread Marek Olšák
On Mon, Jan 4, 2016 at 2:09 PM, Jose Fonseca wrote: > On 04/01/16 12:25, Jose Fonseca wrote: >> >> On 21/12/15 22:35, Marek Olšák wrote: >>> >>> Hi, >>> >>> This patch series adds more flexibility to u_upload_mgr. First, it >>> adds the ability to specify the alignment per

Re: [Mesa-dev] [PATCH 3/8] tgsi: provide a way to encode memory qualifiers for SSBO

2016-01-04 Thread Marek Olšák
On Sun, Jan 3, 2016 at 5:37 AM, Ilia Mirkin wrote: > Each load/store on most hardware can specify what caching to do. Since > SSBO allows individual variables to also have separate caching modes, > allow loads/stores to have the qualifiers instead of attempting to > encode

[Mesa-dev] [GSoC] RFC / Suggestions for project

2016-01-04 Thread Thomas Helland
Hi everyone, and Happy New Year! As most of you are probably aware I participated in GSoC last summer. (Loop analysis and range propagation for NIR). This was a very valuable and fun experience, and something I'd like to have another shot at. So why am I writing in this early? Last year I was a

Re: [Mesa-dev] ipers performance regression (Was: u_upload_mgr changes)

2016-01-04 Thread Jose Fonseca
On 04/01/16 14:03, Marek Olšák wrote: On Mon, Jan 4, 2016 at 2:09 PM, Jose Fonseca wrote: On 04/01/16 12:25, Jose Fonseca wrote: On 21/12/15 22:35, Marek Olšák wrote: Hi, This patch series adds more flexibility to u_upload_mgr. First, it adds the ability to specify

Re: [Mesa-dev] [PATCH 3/6] i965/gen6-7: Implement stall and flushes required prior to switching pipelines.

2016-01-04 Thread Kenneth Graunke
On Sunday, January 3, 2016 3:41:08 PM PST Francisco Jerez wrote: > Kenneth Graunke writes: > > > On Saturday, January 2, 2016 10:48:02 PM PST Francisco Jerez wrote: > >> Switching the current pipeline while it's not completely idle or the > >> read and write caches aren't

Re: [Mesa-dev] [PATCH 4/5] st/mesa: expose ARB_indirect_parameters when the backend driver allows

2016-01-04 Thread Marek Olšák
Patches 1-4: Reviewed-by: Marek Olšák Marek On Sat, Jan 2, 2016 at 9:38 PM, Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin > --- > src/mesa/state_tracker/st_cb_bufferobjects.c | 1 + > src/mesa/state_tracker/st_extensions.c

Re: [Mesa-dev] [PATCH 3/3] i965/wm: use proper API buffer size for the surfaces.

2016-01-04 Thread Ilia Mirkin
Buffer range is a property of the binding, not the buffer. What if one buffer is bound twice with diff ranges to diff bindings? Also please don't make core changes in commits with a driver prefix... I nearly missed this one because it said i965. On Dec 15, 2015 6:52 AM, "Iago Toral Quiroga"

Re: [Mesa-dev] ipers performance regression (Was: u_upload_mgr changes)

2016-01-04 Thread Jose Fonseca
On 04/01/16 12:25, Jose Fonseca wrote: On 21/12/15 22:35, Marek Olšák wrote: Hi, This patch series adds more flexibility to u_upload_mgr. First, it adds the ability to specify the alignment per suballocation. The idea is that several users can use the same upload buffer, but each may need a

Re: [Mesa-dev] [PATCH 2/2] i965/wm: use binding size for ubo/ssbo when automatic size is unset

2016-01-04 Thread Samuel Iglesias Gonsálvez
On Mon, 2016-01-04 at 20:01 -0500, Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin > Cc: Samuel Iglesias Gonsálvez > Cc: Marta Lofstedt > --- > > I have not tested whether this fixes your CTS tests (as I don't have > access

[Mesa-dev] [Bug 27512] Illegal instruction _mesa_x86_64_transform_points4_general

2016-01-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=27512 --- Comment #6 from mhard...@gmail.com --- I am experiencing a crash with a SIGILL, Illegal instruction in Debian when using Kodi. [Thread debugging using libthread_db enabled] Using host libthread_db library

Re: [Mesa-dev] ipers performance regression (Was: u_upload_mgr changes)

2016-01-04 Thread Brian Paul
On 01/04/2016 07:24 AM, Jose Fonseca wrote: On 04/01/16 14:03, Marek Olšák wrote: > Also, do we have know any real apps using glBitmap? Yes, Brian Paul came across real world apps that use glBitmap for text drawing or thin wrappers around them like wglUseFontBitmaps/glXUseXFont, and IIRC

[Mesa-dev] [Bug 93570] the image of llvmpipe has a low quality on arm (with too many points on it)

2016-01-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93570 --- Comment #10 from Icenowy Zheng --- I've finally built a git version of mesa with a svn version of llvm. Now the image is fixed, but the performace is 1/4 to the original. -- You are receiving this mail because: You

Re: [Mesa-dev] [PATCH 1/8] tgsi: add ureg support for image decls

2016-01-04 Thread Rob Clark
On Sat, Jan 2, 2016 at 11:37 PM, Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin > --- > src/gallium/auxiliary/tgsi/tgsi_build.c| 62 + > src/gallium/auxiliary/tgsi/tgsi_dump.c | 10 +-- >

Re: [Mesa-dev] [PATCH 2/2] glsl: Handle bits=32 case in bitfieldInsert/bitfieldExtract.

2016-01-04 Thread Matt Turner
On Wed, Dec 30, 2015 at 4:26 PM, Ilia Mirkin wrote: > On Wed, Dec 30, 2015 at 3:26 PM, Matt Turner wrote: >> The OpenGL specifications for these functions say: >> >>The result will be undefined if or is negative, or if >>the sum of and is

Re: [Mesa-dev] [PATCH 2/2] glsl: Handle bits=32 case in bitfieldInsert/bitfieldExtract.

2016-01-04 Thread Matt Turner
On Wed, Dec 30, 2015 at 8:55 PM, Roland Scheidegger wrote: > Am 30.12.2015 um 21:26 schrieb Matt Turner: >> The OpenGL specifications for these functions say: >> >>The result will be undefined if or is negative, or if >>the sum of and is greater than the number of

Re: [Mesa-dev] [PATCH 1/3] llvmpipe: don't store eo as 64bit int

2016-01-04 Thread Brian Paul
Looks OK to me. For the series, Reviewed-by: Brian Paul On 01/02/2016 01:39 PM, srol...@vmware.com wrote: From: Roland Scheidegger eo, just like dcdx and dcdy, cannot overflow 32bit. Store it as unsigned though just in case (it cannot be negative, but

Re: [Mesa-dev] [PATCH 1/8] draw: rework hanndling of non-existing outputs in emit code

2016-01-04 Thread Brian Paul
I didn't do a detailed review, but these changes look like good clean-ups. For the series, Reviewed-by: Brian Paul On 12/21/2015 08:00 PM, srol...@vmware.com wrote: From: Roland Scheidegger Previously the code would just redirect requests for

Re: [Mesa-dev] [PATCH 2/2] glsl: Handle bits=32 case in bitfieldInsert/bitfieldExtract.

2016-01-04 Thread Ilia Mirkin
On Mon, Jan 4, 2016 at 12:44 PM, Matt Turner wrote: > On Wed, Dec 30, 2015 at 4:26 PM, Ilia Mirkin wrote: >> On Wed, Dec 30, 2015 at 3:26 PM, Matt Turner wrote: >>> The OpenGL specifications for these functions say: >>> >>>The

[Mesa-dev] [Bug 93570] the image of llvmpipe has a low quality on arm (with too many points on it)

2016-01-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93570 Rob Clark changed: What|Removed |Added CC|

Re: [Mesa-dev] [PATCH 1/8] tgsi: add ureg support for image decls

2016-01-04 Thread Rob Clark
On Mon, Jan 4, 2016 at 11:03 AM, Ilia Mirkin wrote: > On Mon, Jan 4, 2016 at 10:30 AM, Rob Clark wrote: >> On Sat, Jan 2, 2016 at 11:37 PM, Ilia Mirkin wrote: >>> Signed-off-by: Ilia Mirkin >>> --- >>>

[Mesa-dev] [Bug 93570] the image of llvmpipe has a low quality on arm (with too many points on it)

2016-01-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93570 --- Comment #12 from Icenowy Zheng --- Yes. And it's still faster than softpipe. It seems that loading a scene cost too much time, as when the animation started, it's smooth. (but the result is low fps number)

[Mesa-dev] [Bug 93570] the image of llvmpipe has a low quality on arm (with too many points on it)

2016-01-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93570 Peter changed: What|Removed |Added CC||pbrobin...@gmail.com --

Re: [Mesa-dev] [PATCH 1/8] tgsi: add ureg support for image decls

2016-01-04 Thread Ilia Mirkin
On Mon, Jan 4, 2016 at 10:30 AM, Rob Clark wrote: > On Sat, Jan 2, 2016 at 11:37 PM, Ilia Mirkin wrote: >> Signed-off-by: Ilia Mirkin >> --- >> src/gallium/auxiliary/tgsi/tgsi_build.c| 62 + >>

[Mesa-dev] [Bug 93570] the image of llvmpipe has a low quality on arm (with too many points on it)

2016-01-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93570 --- Comment #11 from Rob Clark --- (In reply to Icenowy Zheng from comment #10) > I've finally built a git version of mesa with a svn version of llvm. > > Now the image is fixed, but the performace is 1/4 to the

Re: [Mesa-dev] [PATCH 1/8] tgsi: add ureg support for image decls

2016-01-04 Thread Ilia Mirkin
On Mon, Jan 4, 2016 at 11:14 AM, Rob Clark wrote: > On Mon, Jan 4, 2016 at 11:03 AM, Ilia Mirkin wrote: >> On Mon, Jan 4, 2016 at 10:30 AM, Rob Clark wrote: >>> On Sat, Jan 2, 2016 at 11:37 PM, Ilia Mirkin

Re: [Mesa-dev] [PATCH 2/2] glsl: Handle bits=32 case in bitfieldInsert/bitfieldExtract.

2016-01-04 Thread Ilia Mirkin
On Mon, Jan 4, 2016 at 12:52 PM, Ilia Mirkin wrote: > On Mon, Jan 4, 2016 at 12:44 PM, Matt Turner wrote: >> On Wed, Dec 30, 2015 at 4:26 PM, Ilia Mirkin wrote: >>> On Wed, Dec 30, 2015 at 3:26 PM, Matt Turner

Re: [Mesa-dev] [PATCH 2/2] glsl: Handle bits=32 case in bitfieldInsert/bitfieldExtract.

2016-01-04 Thread Matt Turner
On Mon, Jan 4, 2016 at 12:52 PM, Ilia Mirkin wrote: > On Mon, Jan 4, 2016 at 12:44 PM, Matt Turner wrote: >> On Wed, Dec 30, 2015 at 4:26 PM, Ilia Mirkin wrote: >>> On Wed, Dec 30, 2015 at 3:26 PM, Matt Turner

[Mesa-dev] [PATCH] nir: few missing struct names

2016-01-04 Thread Rob Clark
From: Rob Clark nir.h is a bit inconsistent about 'typedef struct {} nir_foo' vs 'typedef struct nir_foo {} nir_foo'. But missing struct name tags is inconvenient when you need a fwd declaration without pulling in all of nir. So add missing struct name tag for