[Mesa-dev] [PATCH 1/2] i965/fs: Allow spilling for SIMD16 compute shaders

For fragment shaders, we can always use a SIMD8 program. Therefore, if we detect spilling with a SIMD16 program, then it is better to skip generating a SIMD16 program to only rely on a SIMD8 program. Unfortunately, this doesn't work for compute shaders. For a compute shader, we may be required to

[Mesa-dev] [PATCH 2/2] i965/compute: Skip SIMD8 generation if it can't be used

If the local workgroup size is sufficiently large, then the SIMD8 program can't be used. In this case we can skip generating the SIMD8 program. For complex programs this can save a significant amount of time. Signed-off-by: Jordan Justen ---

Re: [Mesa-dev] [PATCH 2.5/3] glsl: only apply default stream to output blocks

On Fri, 2016-02-26 at 07:41 +0100, Samuel Iglesias Gonsálvez wrote: > > On Fri, Feb 26, 2016 at 11:51:16AM +1100, Timothy Arceri wrote: > > This is needed to allow invalid qualifier checks on inputs. > > > > Cc: Samuel Iglesias Gonsálvez > > --- > >  I missed this in the

[Mesa-dev] [PATCH] i965: set VIEWPORT_BOUNDS_RANGE value depending of the supported OpenGL version

From ARB_viewport_array spec: " * On GL3-capable hardware the VIEWPORT_BOUNDS_RANGE should be at least [-16384, 16383]. * On GL4-capable hardware the VIEWPORT_BOUNDS_RANGE should be at least [-32768, 32767]." Signed-off-by: Samuel Iglesias Gonsálvez ---

Re: [Mesa-dev] [PATCH 2/3] gallium/r600: Don't let h/w do endian swap for colorformat

On Fri, Feb 26, 2016 at 9:32 AM, Michel Dänzer wrote: > On 26.02.2016 16:14, Oded Gabbay wrote: >> On Fri, Feb 26, 2016 at 5:01 AM, Michel Dänzer wrote: >>> >>> [ Dropping mesa-stable list from Cc, since sending patches there by >>> e-mail before they've

Re: [Mesa-dev] [PATCH 2/3] gallium/r600: Don't let h/w do endian swap for colorformat

On 26.02.2016 16:14, Oded Gabbay wrote: > On Fri, Feb 26, 2016 at 5:01 AM, Michel Dänzer wrote: >> >> [ Dropping mesa-stable list from Cc, since sending patches there by >> e-mail before they've landed on master is basically noise ] > > Problem is that I sometimes later

[Mesa-dev] [Bug 94295] [swrast] piglit shader_runner fast_color_clear/all-colors regression

https://bugs.freedesktop.org/show_bug.cgi?id=94295 Plamena Manolova changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop.

[Mesa-dev] [Bug 29192] Kwin crashed after checking an advanced setting in Desktop Effects

https://bugs.freedesktop.org/show_bug.cgi?id=29192 Christopher M. Penalver changed: What|Removed |Added CC|

Re: [Mesa-dev] [PATCH 2/3] gallium/r600: Don't let h/w do endian swap for colorformat

On Fri, Feb 26, 2016 at 5:01 AM, Michel Dänzer wrote: > > [ Dropping mesa-stable list from Cc, since sending patches there by > e-mail before they've landed on master is basically noise ] Problem is that I sometimes later forget to add stable :) > > On 26.02.2016 06:09, Oded

[Mesa-dev] [Bug 29148] KWin segfaults when OpenGL desktop effects are enabled

https://bugs.freedesktop.org/show_bug.cgi?id=29148 Christopher M. Penalver changed: What|Removed |Added Status|NEW

[Mesa-dev] [Bug 28799] Shared textures not working in 7.7.1

https://bugs.freedesktop.org/show_bug.cgi?id=28799 Christopher M. Penalver changed: What|Removed |Added Resolution|---

[Mesa-dev] [Bug 12895] 3D on ATI 9200SE video card?

https://bugs.freedesktop.org/show_bug.cgi?id=12895 Christopher M. Penalver changed: What|Removed |Added Resolution|---

[Mesa-dev] [PATCH] android: re-generate git_sha1.h if git HEAD updated

The git_sha1.h has to depend on the git HEAD otherwise it will never be updated. Signed-off-by: Chih-Wei Huang --- src/mesa/Android.gen.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/Android.gen.mk b/src/mesa/Android.gen.mk index

Re: [Mesa-dev] [PATCH] anv: remove stray ; after if

On Feb 25, 2016 5:33 PM, "Matt Turner" wrote: > > Indeed, that looks like a mistake. Yes, yes it is. Good catch. Reviewed-by: Jason Ekstrand > Reviewed-by: Matt Turner > ___ > mesa-dev

Re: [Mesa-dev] [PATCH 2.5/3] glsl: only apply default stream to output blocks

On Fri, Feb 26, 2016 at 11:51:16AM +1100, Timothy Arceri wrote: > This is needed to allow invalid qualifier checks on inputs. > > Cc: Samuel Iglesias Gonsálvez > --- > I missed this in the first series as no tests hit this, I guess that means > we have no gs tests that

Re: [Mesa-dev] [PATCH 1/6] winsys/radeon: drop support for DRM 2.12.0

On 25.02.2016 08:09, Marek Olšák wrote: > From: Marek Olšák > > in order to make some winsys interface changes easier Reviewed-by: Michel Dänzer -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast

Re: [Mesa-dev] [PATCH 2/2] radeonsi: dump full shader disassemblies into ddebug logs

On 26.02.2016 01:42, Marek Olšák wrote: > From: Marek Olšák Reviewed-by: Michel Dänzer -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer

Re: [Mesa-dev] [PATCH 1/2] radeonsi: allow dumping shader disassemblies to a file

What's the purpose of this change? Unless I'm missing something, only stderr is ever passed in. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer ___

Re: [Mesa-dev] [PATCH 26/28] glsl: lower tessellation varyings packed with component layout qualifier

On Thu, 2016-02-25 at 18:32 -0800, Kenneth Graunke wrote: > On Tuesday, December 29, 2015 4:00:26 PM PST Timothy Arceri wrote: > > For tessellation shaders we cannot just copy everything to the > > packed > > varyings like we do in other stages as tessellation uses shared > > memory for > >

Re: [Mesa-dev] [PATCH 1/3] gallium/radeon: remove separate BE path in r600_translate_colorswap

On 26.02.2016 06:09, Oded Gabbay wrote: > After further testing, it appears there is no need for > separate BE path in r600_translate_colorswap() > > The only fix remaining is the change of the last if statement, in the 4 > channels case. Originally, it contained an invalid swizzle configuration

Re: [Mesa-dev] [PATCH 2/3] gallium/r600: Don't let h/w do endian swap for colorformat

[ Dropping mesa-stable list from Cc, since sending patches there by e-mail before they've landed on master is basically noise ] On 26.02.2016 06:09, Oded Gabbay wrote: > Since the rework on gallium pipe formats, there is no more need to do > endian swap of the colorformat in the h/w, because the

Re: [Mesa-dev] [PATCH 26/28] glsl: lower tessellation varyings packed with component layout qualifier

On Tuesday, December 29, 2015 4:00:26 PM PST Timothy Arceri wrote: > For tessellation shaders we cannot just copy everything to the packed > varyings like we do in other stages as tessellation uses shared memory for > varyings, therefore it is only safe to copy array elements that the shader >

Re: [Mesa-dev] [PATCH 3/5] i965/cfg: Eliminate an empty then-branch of an if/else/endif

Ian Romanick writes: > From: Ian Romanick > > On BDW, > > total instructions in shared programs: 8448571 -> 8448367 (-0.00%) > instructions in affected programs: 21000 -> 20796 (-0.97%) > helped: 116 > HURT: 0 > > Signed-off-by: Ian Romanick

Re: [Mesa-dev] [PATCH 5/5] i965/cfg: Split out dead control flow paths to simplify both paths

Ian Romanick writes: > From: Ian Romanick > > Signed-off-by: Ian Romanick > --- > .../drivers/dri/i965/brw_dead_control_flow.cpp | 93 > +- > 1 file changed, 38 insertions(+), 55 deletions(-) >

Re: [Mesa-dev] [PATCH] anv: remove stray ; after if

Indeed, that looks like a mistake. Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 12/28] glsl: update explicit location matching to support component qualifier

On Tuesday, December 29, 2015 4:00:12 PM PST Timothy Arceri wrote: > This is needed so we don't optimise away the varying when more than > one shares the same location. > --- > src/glsl/linker.cpp | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH V3 11/28] glsl: cross validate varyings with a component qualifier

On Friday, January 8, 2016 10:15:58 AM PST Timothy Arceri wrote: > This change checks for component overlap, including handling overlap of > locations and components by doubles. Previously there was no validation > for assigning explicit locations to a location used by the second half > of a

Re: [Mesa-dev] [PATCH 10/28] glsl: fix cross validation for explicit locations on structs and arrays

On Tuesday, December 29, 2015 4:00:10 PM PST Timothy Arceri wrote: > --- > src/glsl/link_varyings.cpp | 43 ++- > 1 file changed, 30 insertions(+), 13 deletions(-) > > diff --git a/src/glsl/link_varyings.cpp b/src/glsl/link_varyings.cpp > index

[Mesa-dev] [Bug 91556] Struct / union sizes being calculated incorrectly

https://bugs.freedesktop.org/show_bug.cgi?id=91556 Pavan Yalamanchili changed: What|Removed |Added Summary|clSetKernelArg from OpenCL |Struct / union

[Mesa-dev] [Bug 91556] clSetKernelArg from OpenCL is erroring out incorrectly

https://bugs.freedesktop.org/show_bug.cgi?id=91556 --- Comment #5 from Pavan Yalamanchili --- @Fernando, the updated code sample only includes native types inside a struct. But I will look at the file you mention to see if anything fishy is happening. -- You are receiving

[Mesa-dev] [PATCH 2.5/3] glsl: only apply default stream to output blocks

This is needed to allow invalid qualifier checks on inputs. Cc: Samuel Iglesias Gonsálvez --- I missed this in the first series as no tests hit this, I guess that means we have no gs tests that have an input block with a layout qualifier :( Transform feedback qualifiers

[Mesa-dev] [PATCH] anv: remove stray ; after if

Both logic and indentation suggests that the ; were not intended here. --- src/intel/vulkan/anv_cmd_buffer.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/intel/vulkan/anv_cmd_buffer.c b/src/intel/vulkan/anv_cmd_buffer.c index b060828..827c3ed 100644 ---

[Mesa-dev] [Bug 91556] clSetKernelArg from OpenCL is erroring out incorrectly

https://bugs.freedesktop.org/show_bug.cgi?id=91556 --- Comment #4 from Francisco Jerez --- I haven't run the program myself either, but it's likely that the module::argument::size value is calculated incorrectly in the compiler glue code, check out the definition of

[Mesa-dev] [Bug 91556] clSetKernelArg from OpenCL is erroring out incorrectly

https://bugs.freedesktop.org/show_bug.cgi?id=91556 Pavan Yalamanchili changed: What|Removed |Added Priority|medium |high -- You

[Mesa-dev] [Bug 91556] clSetKernelArg from OpenCL is erroring out incorrectly

https://bugs.freedesktop.org/show_bug.cgi?id=91556 Pavan Yalamanchili changed: What|Removed |Added Version|10.6|11.1 -- You

[Mesa-dev] [Bug 91556] clSetKernelArg from OpenCL is erroring out incorrectly

https://bugs.freedesktop.org/show_bug.cgi?id=91556 Pavan Yalamanchili changed: What|Removed |Added Attachment #117515|0 |1 is

Re: [Mesa-dev] [PATCH 1/2] i965/fs: fix precision of f2b

On Thu, Feb 25, 2016 at 6:16 PM, Francisco Jerez wrote: > Ian Romanick writes: > >> On 02/25/2016 12:13 PM, Francisco Jerez wrote: >>> Ian Romanick writes: >>> On 02/25/2016 08:46 AM, Roland Scheidegger wrote: > Am

Re: [Mesa-dev] [PATCH 1/2] i965/fs: fix precision of f2b

Ian Romanick writes: > On 02/25/2016 12:13 PM, Francisco Jerez wrote: >> Ian Romanick writes: >> >>> On 02/25/2016 08:46 AM, Roland Scheidegger wrote: Am 25.02.2016 um 11:15 schrieb Iago Toral Quiroga: > From the OpenGL 4.2 spec: > >

[Mesa-dev] [PATCH 2/5] i965/cfg: Track prev_block and prev_inst explicitly in the whole function

From: Ian Romanick This provides a trivial simplification now, and it makes some future changes more straight forward. Signed-off-by: Ian Romanick --- src/mesa/drivers/dri/i965/brw_dead_control_flow.cpp | 12 +++- 1 file changed, 7

[Mesa-dev] [PATCH 5/5] i965/cfg: Split out dead control flow paths to simplify both paths

From: Ian Romanick Signed-off-by: Ian Romanick --- .../drivers/dri/i965/brw_dead_control_flow.cpp | 93 +- 1 file changed, 38 insertions(+), 55 deletions(-) diff --git

[Mesa-dev] [PATCH 0/5] Make dead control follow elimination handle empty then-branches

This series replaces the previous single patch. Doing it in dead control flow elimination helps 4 additional shaders versus doing during translation from NIR. As Curro mentioned in his review of the earlier patch, this also has the potential to help vec4 shaders in addition to scalar shaders. I

[Mesa-dev] [PATCH 4/5] i965/cfg: Don't handle fully empty if/else/endif

From: Ian Romanick This will now never occur. The empty if-else part would have already been removed leaving an empty if-endif part. No shader-db changes. Signed-off-by: Ian Romanick --- src/mesa/drivers/dri/i965/brw_dead_control_flow.cpp

[Mesa-dev] [PATCH 3/5] i965/cfg: Eliminate an empty then-branch of an if/else/endif

From: Ian Romanick On BDW, total instructions in shared programs: 8448571 -> 8448367 (-0.00%) instructions in affected programs: 21000 -> 20796 (-0.97%) helped: 116 HURT: 0 Signed-off-by: Ian Romanick ---

[Mesa-dev] [PATCH 1/5] i965/cfg: Slightly rearrange dead_control_flow_eliminate

From: Ian Romanick 'git diff -w' is a bit more illustrative. A couple declarations were moved, the continue was removed, and the code was reindented. This will simplify future changes. Signed-off-by: Ian Romanick ---

Re: [Mesa-dev] [PATCH 1/2] i965/fs: fix precision of f2b

On 02/25/2016 12:13 PM, Francisco Jerez wrote: > Ian Romanick writes: > >> On 02/25/2016 08:46 AM, Roland Scheidegger wrote: >>> Am 25.02.2016 um 11:15 schrieb Iago Toral Quiroga: From the OpenGL 4.2 spec: "When a constructor is used to convert any integer or

Re: [Mesa-dev] [PATCH 2/3] gallium/r600: Don't let h/w do endian swap for colorformat

On Thu, Feb 25, 2016 at 11:23 PM, Matt Turner wrote: > On Thu, Feb 25, 2016 at 1:19 PM, Oded Gabbay wrote: >> On Thu, Feb 25, 2016 at 11:16 PM, Matt Turner wrote: >>> On Thu, Feb 25, 2016 at 1:09 PM, Oded Gabbay

Re: [Mesa-dev] [PATCH 2/3] gallium/r600: Don't let h/w do endian swap for colorformat

On Thu, Feb 25, 2016 at 1:19 PM, Oded Gabbay wrote: > On Thu, Feb 25, 2016 at 11:16 PM, Matt Turner wrote: >> On Thu, Feb 25, 2016 at 1:09 PM, Oded Gabbay wrote: >>> Since the rework on gallium pipe formats, there is no more need

Re: [Mesa-dev] [PATCH 11/11] program: Remove extra reference_program()

On 02/25/2016 10:01 PM, Marek Olšák wrote: On Thu, Feb 25, 2016 at 9:31 PM, Miklós Máté wrote: I noticed that this has been reviewed, but has not been committed. Does it require further action from me, or was it just forgotten? Ideally you would ask somebody to push the

Re: [Mesa-dev] [PATCH 2/3] gallium/r600: Don't let h/w do endian swap for colorformat

On Thu, Feb 25, 2016 at 11:16 PM, Matt Turner wrote: > On Thu, Feb 25, 2016 at 1:09 PM, Oded Gabbay wrote: >> Since the rework on gallium pipe formats, there is no more need to do >> endian swap of the colorformat in the h/w, because the conversion

Re: [Mesa-dev] [PATCH 2/3] gallium/r600: Don't let h/w do endian swap for colorformat

On Thu, Feb 25, 2016 at 1:09 PM, Oded Gabbay wrote: > Since the rework on gallium pipe formats, there is no more need to do > endian swap of the colorformat in the h/w, because the conversion between > mesa format and gallium (pipe) format takes endianess into account (see

[Mesa-dev] [PATCH 2/3] gallium/r600: Don't let h/w do endian swap for colorformat

Since the rework on gallium pipe formats, there is no more need to do endian swap of the colorformat in the h/w, because the conversion between mesa format and gallium (pipe) format takes endianess into account (see the big #if in p_format.h). Signed-off-by: Oded Gabbay

[Mesa-dev] [PATCH 3/3] gallium/radeon: disable evergreen_do_fast_color_clear for BE

This function is currently broken for BE. I assume it's because of util_pack_color(). Until I fix this path, I prefer to disable it so users would be able to see correct colors on their desktop and applications. Together with the two following patches: - gallium/r600: Don't let h/w do endian swap

[Mesa-dev] [PATCH 1/3] gallium/radeon: remove separate BE path in r600_translate_colorswap

After further testing, it appears there is no need for separate BE path in r600_translate_colorswap() The only fix remaining is the change of the last if statement, in the 4 channels case. Originally, it contained an invalid swizzle configuration that never got hit, in LE or BE. So the fix is

[Mesa-dev] [PATCH 0/3] Fix desktop colors for r600g on Big-Endian machines

So I finally managed to get the desktop colors to work correctly. Apparently, my previous fixes were partially wrong (but also partially correct). There are two major points: 1. Because the mesa <--> pipe format conversion takes into account endianess (see p_format.h), there is no need to do

Re: [Mesa-dev] [PATCH 11/11] program: Remove extra reference_program()

On Thu, Feb 25, 2016 at 9:31 PM, Miklós Máté wrote: > I noticed that this has been reviewed, but has not been committed. Does it > require further action from me, or was it just forgotten? Ideally you would ask somebody to push the patch for you. I'll do it. Marek

Re: [Mesa-dev] [PATCH 1/7] mesa: optionally associate a gl_program to ati_fragment_shader

On 02/25/2016 07:38 PM, Ian Romanick wrote: On 02/24/2016 05:37 PM, Brian Paul wrote: On 02/24/2016 04:35 PM, Miklós Máté wrote: the state tracker will use it Signed-off-by: Miklós Máté --- src/mesa/drivers/common/driverfuncs.c | 3 +++ src/mesa/main/atifragshader.c

Re: [Mesa-dev] [PATCH 11/11] program: Remove extra reference_program()

I noticed that this has been reviewed, but has not been committed. Does it require further action from me, or was it just forgotten? MM On 02/03/2016 10:06 AM, Marek Olšák wrote: Reviewed-by: Marek Olšák Marek On Wed, Dec 16, 2015 at 12:05 AM, Miklós Máté

Re: [Mesa-dev] [PATCH] build/nir: Remove unused Makefile.sources from nir folder

Redoing the Android/SCons got extra messy, so I opted for this 'hack'. There was even plan B of doing a "Open vSwitch", where we use it (and makes all the the whole build parallel). As plan B is off the table for now (quite evasive) I'll beat things in shape to remove this file. -Emil On 25

Re: [Mesa-dev] [PATCH 1/2] i965/fs: fix precision of f2b

Ian Romanick writes: > On 02/25/2016 08:46 AM, Roland Scheidegger wrote: >> Am 25.02.2016 um 11:15 schrieb Iago Toral Quiroga: >>> From the OpenGL 4.2 spec: >>> >>> "When a constructor is used to convert any integer or floating-point type >>> to a >>> bool, 0 and 0.0 are

[Mesa-dev] [Bug 94295] [swrast] piglit shader_runner fast_color_clear/all-colors regression

https://bugs.freedesktop.org/show_bug.cgi?id=94295 Bug ID: 94295 Summary: [swrast] piglit shader_runner fast_color_clear/all-colors regression Product: Mesa Version: 11.2 Hardware: x86-64 (AMD64) OS: Linux

Re: [Mesa-dev] [PATCH 1/2] i965/fs: fix precision of f2b

Roland Scheidegger writes: > Am 25.02.2016 um 11:15 schrieb Iago Toral Quiroga: >> From the OpenGL 4.2 spec: >> >> "When a constructor is used to convert any integer or floating-point type to >> a >> bool, 0 and 0.0 are converted to false, and non-zero values are converted

Re: [Mesa-dev] [PATCH 1/2] i965/fs: fix precision of f2b

On 02/25/2016 08:46 AM, Roland Scheidegger wrote: > Am 25.02.2016 um 11:15 schrieb Iago Toral Quiroga: >> From the OpenGL 4.2 spec: >> >> "When a constructor is used to convert any integer or floating-point type to >> a >> bool, 0 and 0.0 are converted to false, and non-zero values are converted

[Mesa-dev] [PATCH 1/3] install-gallium-links: port changes from install-lib-links

From: Emil Velikov Namely: b662d5282f7 mesa: Add clean-local rule to remove .lib links. 5c1aac17adf install-lib-links: don't depend on .libs directory fece147be53 install-lib-links: remove the .install-lib-links file With these in place, make distcheck now passes and

[Mesa-dev] [PATCH 2/3] automake: add more missing options for make distcheck

From: Emil Velikov Namely - opencl, osmesa (only the gallium flavour as it conflicts with the classic one), surfaceless egl platform and a couple gallium drivers (virgl and vc4). Cc: "11.1 11.2" Signed-off-by: Emil Velikov

[Mesa-dev] [PATCH 3/3] automake: explicitly set distcheck configure flags

From: Emil Velikov Pretty much all of these are enabled by default. Considering the recent updates (see previous commits) one might as well list most/all of these here. Signed-off-by: Emil Velikov --- Makefile.am | 5 + 1 file

Re: [Mesa-dev] [PATCH 03/10] i965: Always do NIR IO lowering at specialization time.

First 3 are Reviewed-by: Jason Ekstrand It'll take real work to review the others. On Thu, Feb 25, 2016 at 11:01 AM, Kenneth Graunke wrote: > We've now hit literally every case other than geometry shaders (and > compute shaders, but those are a

Re: [Mesa-dev] [PATCH 4/7] main: rework the compatibility check of visuals in glXMakeCurrent

On 02/25/2016 07:48 AM, Brian Paul wrote: > On 02/25/2016 08:26 AM, Miklós Máté wrote: >> On 02/25/2016 02:37 AM, Brian Paul wrote: >>> On 02/24/2016 04:35 PM, Miklós Máté wrote: Now it follows the GLX 1.4 specification. >>> >>> Can you elaborate on that a bit? >> Section 2.1 of the GLX spec

[Mesa-dev] [PATCH 06/10] i965: Split brw_nir_lower_inputs/outputs into per-stage functions.

These functions are both giant switch statements where most cases don't overlap at all. Let's put the bulk of the work in per-stage helpers. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_nir.c | 304 +--- 1 file changed,

[Mesa-dev] [PATCH 02/10] i965: Make an is_scalar boolean in brw_compile_gs().

Shorter than compiler->scalar_stage[MESA_SHADER_GEOMETRY], which can help with line-wrapping. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_vec4_gs_visitor.cpp | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[Mesa-dev] [PATCH 03/10] i965: Always do NIR IO lowering at specialization time.

We've now hit literally every case other than geometry shaders (and compute shaders, but those are a no-op). So, let's just move geometry shaders over too and be done with it. The only advantage to doing this at link time was to save the expense of running the pass on recompiles. But we're

[Mesa-dev] [PATCH 10/10] i965: Simplify brw_nir_lower_vue_inputs() slightly.

The same code appeared in both branches; pull it above the if statement. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_nir.c | 17 ++--- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_nir.c

[Mesa-dev] [PATCH 09/10] i965: Avoid recalculating the normal VUE map for IO lowering.

The caller already computes it. Now that we have stage specific functions, it's really easy to pass this in. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_nir.c | 27 ++--- src/mesa/drivers/dri/i965/brw_nir.h |

[Mesa-dev] [PATCH 01/10] i965/nir: Do lower_io late for fragment shaders

From: Jason Ekstrand The Vulkan driver wants to be able to delete fragment outputs that are beyond key.nr_color_regions; this is a lot easier if we lower outputs at specialization time rather than link time. (Rationale added to commit message by Ken) ---

[Mesa-dev] [PATCH 08/10] i965: Avoid recalculating the tessellation VUE map for IO lowering.

The caller already computes it. Now that we have stage specific functions, it's really easy to pass this in. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_nir.c| 19 --- src/mesa/drivers/dri/i965/brw_nir.h| 4 ++--

[Mesa-dev] [PATCH 04/10] i965: Move optimizations from brw_nir_lower_io to brw_postprocess_nir.

This simplifies things. Every caller of brw_nir_lower_io() immediately calls brw_postprocess_nir(). The only real change this will have is that we get an extra brw_nir_optimize() call when compiling compute shaders, but that seems fine. Signed-off-by: Kenneth Graunke ---

[Mesa-dev] [PATCH 07/10] i965: Eliminate brw_nir_lower_{inputs, outputs, io} functions.

Now that each stage is directly calling brw_nir_lower_io(), and we have per-stage helper functions, it makes sense to just call the relevant one directly, rather than going through multiple switch statements. This also eliminates stupid function parameters, such as the two that only apply to

[Mesa-dev] [PATCH 05/10] i965: Remove catch-all nir_lower_io call with specific cases.

Most cases already call nir_lower_io explicitly for input and output lowering. This catch all isn't very useful anymore - we can just add it to the remaining cases. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_nir.c | 5 - 1 file changed, 4

Re: [Mesa-dev] [PATCH 7/7] mesa: optimize out the realloc from glCopyTexImagexD()

On 02/24/2016 03:35 PM, Miklós Máté wrote: > v2: comment about the purpose of the code > v3: also compare texFormat, > add a perf debug message, > formatting fixes > > Signed-off-by: Miklós Máté > --- > src/mesa/main/teximage.c | 35 +++ > 1

Re: [Mesa-dev] [PATCH 1/7] mesa: optionally associate a gl_program to ati_fragment_shader

On 02/24/2016 05:37 PM, Brian Paul wrote: > On 02/24/2016 04:35 PM, Miklós Máté wrote: >> the state tracker will use it >> >> Signed-off-by: Miklós Máté >> --- >> src/mesa/drivers/common/driverfuncs.c | 3 +++ >> src/mesa/main/atifragshader.c | 13 - >>

Re: [Mesa-dev] [PATCH] radeonsi: also dump shaders on a VM fault

Am 25.02.2016 um 17:54 schrieb Marek Olšák: From: Marek Olšák Clearly a good idea. Patch is Reviewed-by: Christian König --- src/gallium/drivers/radeonsi/si_debug.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 0/8] Fixes for building AOSP master

Hi, On 25 February 2016 at 01:47, Emil Velikov wrote: > On 24 February 2016 at 18:56, Rob Herring wrote: >> AOSP master branch has switched to clang from gcc and has major build >> system changes moving away from GNU make. > > Out of curiosity: what

Re: [Mesa-dev] [PATCH 3/3] nvc0: rework nvc0_compute_validate_program()

On Thu, Feb 25, 2016 at 12:42 PM, Samuel Pitoiset wrote: > It would be easy to make the validate functions return a boolean to handle > errors. I will think more about that stuff. But currently, I prefer to > follow the existing design and drop this boolean. This would

Re: [Mesa-dev] [PATCH 0/8] Fixes for building AOSP master

2016-02-26 1:27 GMT+08:00 Emil Velikov : > On 25 February 2016 at 17:22, Chih-Wei Huang wrote: >> 2016-02-25 9:47 GMT+08:00 Emil Velikov : >>> On 24 February 2016 at 18:56, Rob Herring wrote: AOSP

Re: [Mesa-dev] [PATCH 3/3] nvc0: rework nvc0_compute_validate_program()

On 02/25/2016 06:44 PM, Ilia Mirkin wrote: On Thu, Feb 25, 2016 at 12:42 PM, Samuel Pitoiset wrote: It would be easy to make the validate functions return a boolean to handle errors. I will think more about that stuff. But currently, I prefer to follow the existing

Re: [Mesa-dev] [PATCH 3/3] nvc0: rework nvc0_compute_validate_program()

On 02/25/2016 06:35 PM, Ilia Mirkin wrote: On Wed, Feb 24, 2016 at 12:44 PM, Samuel Pitoiset wrote: Reduce the amount of duplicated code by re-using nvc0_program_validate(). While we are at it, change the prototype to return void and remove nvc0_compute.h which is

Re: [Mesa-dev] [PATCH 3/3] nvc0: rework nvc0_compute_validate_program()

On Wed, Feb 24, 2016 at 12:44 PM, Samuel Pitoiset wrote: > Reduce the amount of duplicated code by re-using > nvc0_program_validate(). While we are at it, change the prototype > to return void and remove nvc0_compute.h which is now useless. > > Signed-off-by: Samuel

Re: [Mesa-dev] [PATCH 0/8] Fixes for building AOSP master

On 25 February 2016 at 17:22, Chih-Wei Huang wrote: > 2016-02-25 9:47 GMT+08:00 Emil Velikov : >> On 24 February 2016 at 18:56, Rob Herring wrote: >>> AOSP master branch has switched to clang from gcc and has major build >>>

Re: [Mesa-dev] [PATCH 0/8] Fixes for building AOSP master

2016-02-25 9:47 GMT+08:00 Emil Velikov : > On 24 February 2016 at 18:56, Rob Herring wrote: >> AOSP master branch has switched to clang from gcc and has major build >> system changes moving away from GNU make. > > Out of curiosity: what are they moving

Re: [Mesa-dev] [PATCH] build/nir: Remove unused Makefile.sources from nir folder

I would really like to see this happen. However, I seem to recall Emil having some reason for keeping it. Emil? --Jason On Thu, Feb 25, 2016 at 4:50 AM, Eduardo Lima Mitev wrote: > NIR sources are added in src/compiler/Makefile.sources. > --- >

Re: [Mesa-dev] [PATCH 1/2] i965/fs: fix precision of f2b

On Thu, Feb 25, 2016 at 8:19 AM, Matt Turner wrote: > On Thu, Feb 25, 2016 at 2:15 AM, Iago Toral Quiroga > wrote: > > From the OpenGL 4.2 spec: > > > > "When a constructor is used to convert any integer or floating-point > type to a > > bool, 0 and 0.0

[Mesa-dev] [PATCH] radeonsi: also dump shaders on a VM fault

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_debug.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_debug.c b/src/gallium/drivers/radeonsi/si_debug.c index 7c2b745..eb0cabb 100644 ---

Re: [Mesa-dev] [PATCH 1/2] i965/fs: fix precision of f2b

Am 25.02.2016 um 11:15 schrieb Iago Toral Quiroga: > From the OpenGL 4.2 spec: > > "When a constructor is used to convert any integer or floating-point type to a > bool, 0 and 0.0 are converted to false, and non-zero values are converted to > true." > > Thus, even the smallest non-zero

[Mesa-dev] [PATCH 1/2] radeonsi: allow dumping shader disassemblies to a file

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_compute.c | 2 +- src/gallium/drivers/radeonsi/si_shader.c | 46 +-- src/gallium/drivers/radeonsi/si_shader.h | 3 +- 3 files changed, 29 insertions(+), 22 deletions(-) diff --git

[Mesa-dev] [PATCH 2/2] radeonsi: dump full shader disassemblies into ddebug logs

From: Marek Olšák including prolog and epilog disassemblies --- src/gallium/drivers/radeonsi/si_debug.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_debug.c b/src/gallium/drivers/radeonsi/si_debug.c

Re: [Mesa-dev] [PATCH 1/2] i965/fs: fix precision of f2b

On Thu, Feb 25, 2016 at 2:15 AM, Iago Toral Quiroga wrote: > From the OpenGL 4.2 spec: > > "When a constructor is used to convert any integer or floating-point type to a > bool, 0 and 0.0 are converted to false, and non-zero values are converted to > true." > > Thus, even the

Re: [Mesa-dev] [PATCH 2/7] st/mesa: implement GL_ATI_fragment_shader

On Thu, Feb 25, 2016 at 4:18 PM, Miklós Máté wrote: > On 02/25/2016 11:40 AM, Marek Olšák wrote: >> >> On Thu, Feb 25, 2016 at 12:35 AM, Miklós Máté wrote: >>> >>> v2: fix arithmetic for special opcodes, >>> fix fog state, cleanup >>> v3: simplify handling

Re: [Mesa-dev] [PATCH 4/7] main: rework the compatibility check of visuals in glXMakeCurrent

On 02/25/2016 08:26 AM, Miklós Máté wrote: On 02/25/2016 02:37 AM, Brian Paul wrote: On 02/24/2016 04:35 PM, Miklós Máté wrote: Now it follows the GLX 1.4 specification. Can you elaborate on that a bit? Section 2.1 of the GLX spec lists a few criteria for a context and a drawable to be

Re: [Mesa-dev] [PATCH 2/7] st/mesa: implement GL_ATI_fragment_shader

On 02/25/2016 08:20 AM, Miklós Máté wrote: On 02/25/2016 02:37 AM, Brian Paul wrote: + if (texinst->Opcode == ATI_FRAGMENT_SHADER_SAMPLE_OP) { + /* use the current texture target for the sample operation + * note: this implementation doesn't support re-using an ATI_fs + *

Re: [Mesa-dev] [PATCH 5/7] st/mesa: fix handling the fallback texture

On 02/25/2016 02:40 AM, Brian Paul wrote: On 02/24/2016 04:35 PM, Miklós Máté wrote: This fixes post-processing in SW:KotOR. Can you elaborate on exactly what's happening and why this change fixes things? Sometimes no texture is bound during the post-processing, which results in msamp=0,

Re: [Mesa-dev] [PATCH 4/7] main: rework the compatibility check of visuals in glXMakeCurrent

On 02/25/2016 02:37 AM, Brian Paul wrote: On 02/24/2016 04:35 PM, Miklós Máté wrote: Now it follows the GLX 1.4 specification. Can you elaborate on that a bit? Section 2.1 of the GLX spec lists a few criteria for a context and a drawable to be compatible. This fixes post-processing in

  1   2   >