[Mesa-dev] [PATCH 3/4] mesa: Allow relax various desktop-only checks for cube arrays

2016-05-30 Thread Chris Forbes
Signed-off-by: Chris Forbes --- src/mesa/main/get.c | 2 +- src/mesa/main/get_hash_params.py | 6 +++--- src/mesa/main/teximage.c | 3 ++- src/mesa/main/texobj.c | 2 +- src/mesa/main/texparam.c | 3 ++- src/mesa/main/texstorage.c

[Mesa-dev] [PATCH 4/4] docs: Note that OES_texture_cube_map_array is done.

2016-05-30 Thread Chris Forbes
Signed-off-by: Chris Forbes --- docs/GL3.txt | 2 +- docs/relnotes/12.1.0.html | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index e8d401d..eeaed52 100644 --- a/docs/GL3.txt +++ b/docs/GL3.txt @@ -269,7

[Mesa-dev] [PATCH 2/4] glsl: Add support for cube arrays in ES.

2016-05-30 Thread Chris Forbes
Signed-off-by: Chris Forbes --- src/compiler/glsl/builtin_functions.cpp | 12 src/compiler/glsl/builtin_types.cpp | 23 --- src/compiler/glsl/glsl_lexer.ll | 14 +++--- 3 files changed, 31 insertions(+), 18 deletions(-)

[Mesa-dev] [PATCH 1/4] mesa: Add scaffolding for OES_texture_cube_map_array

2016-05-30 Thread Chris Forbes
This is the same as ARB_texture_cube_map_array plus some image interactions. Signed-off-by: Chris Forbes --- src/compiler/glsl/glcpp/glcpp-parse.y| 5 - src/compiler/glsl/glsl_parser_extras.cpp | 2 ++ src/compiler/glsl/glsl_parser_extras.h | 4

Re: [Mesa-dev] [Mesa-stable] [PATCH] glx: fix crash with bad fbconfig

2016-05-30 Thread Tapani Pälli
On 05/31/2016 07:44 AM, Tapani Pälli wrote: Hi; On 05/30/2016 04:48 PM, Emil Velikov wrote: Hi gents, On 30 May 2016 at 10:13, Tapani Pälli wrote: From: Daniel Czarnowski GLX documentation states: glXCreateNewContext can

Re: [Mesa-dev] [PATCH 1/3] mesa: add scaffolding for OES/EXT_primitive_bounding_box

2016-05-30 Thread Ilia Mirkin
[re-adding mesa-dev] Thanks for the review, Chris! On Tue, May 31, 2016 at 12:48 AM, Chris Forbes wrote: > Oh, I accidentally dropped the list at the start. Feel free to copy the list > on this whole discussion. > > - Chris > > On Tue, May 31, 2016 at 4:47 PM, Ilia Mirkin

Re: [Mesa-dev] [Mesa-stable] [PATCH] glx: fix crash with bad fbconfig

2016-05-30 Thread Tapani Pälli
Hi; On 05/30/2016 04:48 PM, Emil Velikov wrote: Hi gents, On 30 May 2016 at 10:13, Tapani Pälli wrote: From: Daniel Czarnowski GLX documentation states: glXCreateNewContext can generate the following errors: (...)

Re: [Mesa-dev] [PATCH] glsl/linker: fix multiple streams transform feedback.

2016-05-30 Thread Timothy Arceri
On Tue, 2016-05-31 at 12:54 +1000, Dave Airlie wrote: > From: Dave Airlie > > e2791b38b42f83add5b07298c39741bf0a6d7d4b > mesa/program_interface_query: fix transform feedback varyings. > > caused a regression in > GL45- >

[Mesa-dev] [PATCH 2/2] nv50/ir: fix error finding free element in bitset in some situations

2016-05-30 Thread Ilia Mirkin
This really only hits for bitsets with a size of a multiple of 32. We can end up with pos = -1 as a result of the ffs, which we in turn decide is a valid position (since we fall through the loop and i == 1, we end up adding 32 to it, so end up returning 31 again). Up until recently this was

[Mesa-dev] [PATCH 1/2] nv50/ir: print relevant file's bitset when showing RA info

2016-05-30 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/gallium/drivers/nouveau/codegen/nv50_ir_ra.cpp | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_ra.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_ra.cpp index

[Mesa-dev] [Bug 95374] ARK:survival of the fittest fails when GL4.3 is enabled.

2016-05-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95374 --- Comment #3 from Shawn Starr --- Copying the GLSL 150 shader cache to the missing file reveals the game crashes unable to find the shader. [spstarr@segfault Engine]$ cp GlobalShaderCache-GLSL_150.bin

Re: [Mesa-dev] [PATCH] radeonsi: lower SQRT to RSQ+RCP to fix the game Risen

2016-05-30 Thread Roland Scheidegger
Not sure if it's a good idea trying to fix wine bugs via driver hacks? Roland Am 31.05.2016 um 01:19 schrieb Marek Olšák: > From: Marek Olšák > > Sadly, I haven't been able to find any other way to fix the bug > for radeonsi. The game seems to expect DX9 behavior. > >

[Mesa-dev] [PATCH] swr: [rasterizer common] avoid divison by zero

2016-05-30 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/gallium/drivers/swr/rasterizer/common/rdtsc_buckets.cpp | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/common/rdtsc_buckets.cpp

[Mesa-dev] [PATCH] st/va: restore old buffer format on error

2016-05-30 Thread Eric Engestrom
CoverityID: 1337953 Signed-off-by: Eric Engestrom --- Note that I do not know this code at all; I'm blindly following Coverity's advice on this one :] --- src/gallium/state_trackers/va/image.c | 1 + 1 file changed, 1 insertion(+) diff --git

[Mesa-dev] [PATCH] target/d3dadapter9: make sure strings are null-terminated

2016-05-30 Thread Eric Engestrom
From strncpy's man page: Warning: If there is no null byte among the first n bytes of src, the string placed in dest will not be null-terminated. CoverityID: 1320457, 1320458, 1255671 Signed-off-by: Eric Engestrom --- src/gallium/targets/d3dadapter9/description.c | 39

[Mesa-dev] [PATCH] st/glsl_to_tgsi: prevent infinite loop

2016-05-30 Thread Eric Engestrom
`unsigned j` would never fail `j >= 0`, leading to an infinite loop as `j--` wraps around. Signed-off-by: Eric Engestrom --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH] .gitignore: Ignore tags generated by `make tags`

2016-05-30 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 7db5639..d3f3589 100644 --- a/.gitignore +++ b/.gitignore @@ -48,3 +48,4 @@ Makefile Makefile.in .install-mesa-links .install-gallium-links +TAGS

[Mesa-dev] [PATCH] glsl: Remove tautological check

2016-05-30 Thread Eric Engestrom
`size_t offset` can never be `< 0` Signed-off-by: Eric Engestrom --- src/compiler/glsl/blob.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/glsl/blob.c b/src/compiler/glsl/blob.c index dd4341b..ef17255 100644 --- a/src/compiler/glsl/blob.c

[Mesa-dev] [PATCH] st/osmesa: remove double-write (overwriting)

2016-05-30 Thread Eric Engestrom
These two lines have been here since the file was created. I'm guessing the second one was just for testing during dev, so it's the one that's going away. CoverityID: 1296205 Signed-off-by: Eric Engestrom --- This should probably be tested by someone who knows what they're

[Mesa-dev] [PATCH] anv: limit string copy to target buffer size

2016-05-30 Thread Eric Engestrom
CoverityID: 1358935 Signed-off-by: Eric Engestrom --- src/intel/vulkan/anv_device.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c index 046777d..e451138 100644 ---

[Mesa-dev] [PATCH] glsl/linker: fix multiple streams transform feedback.

2016-05-30 Thread Dave Airlie
From: Dave Airlie e2791b38b42f83add5b07298c39741bf0a6d7d4b mesa/program_interface_query: fix transform feedback varyings. caused a regression in GL45-CTS.gtf40.GL3Tests.transform_feedback3.transform_feedback3_multiple_streams on radeonsi. The problem was it was using the

Re: [Mesa-dev] [PATCH 0/2] fix load of unpacked double vector input varyings

2016-05-30 Thread Timothy Arceri
On Mon, 2016-05-30 at 15:46 +0200, Samuel Iglesias Gonsálvez wrote: > > On 27/05/16 08:39, Samuel Iglesias Gonsálvez wrote: > > > > > > > > On 26/05/16 09:46, Timothy Arceri wrote: > > > > > > On Thu, 2016-05-26 at 17:44 +1000, Timothy Arceri wrote: > > > > > > > > On Thu, 2016-05-26 at

Re: [Mesa-dev] [PATCH 0/3] r600g removal of unnecessary cache flushes

2016-05-30 Thread Grazvydas Ignotas
On Tue, May 31, 2016 at 2:58 AM, Grazvydas Ignotas wrote: > I've patched the CS validator and there seem to be some regressions: > > arb_map_buffer_range 11/11 5/11 > copybuffersubdata decrement-offset > copybuffersubdata increment-offset > copybuffersubdata offset=0 >

[Mesa-dev] Set of 2 patches to fix building errors with kitkat-x86

2016-05-30 Thread Mauro Rossi
Hello there, the following two patches are proposed to avoid building errors on kitkat-x86 in order to enhance compatibility. Please consider that these patches are applicable to both mesa-dev and mesa-stable, please pardon me if I may have just caused double posting on mesa-stable. [PATCH

[Mesa-dev] [PATCH 2/2] egl: use CLOCK_MONOTONIC only when available

2016-05-30 Thread Mauro Rossi
Fixes the following building error: external/mesa/src/egl/drivers/dri2/egl_dri2.c:2476: error: undefined reference to 'pthread_condattr_setclock' collect2: error: ld returned 1 exit status Cc: --- src/egl/drivers/dri2/egl_dri2.c | 16 1 file

[Mesa-dev] [PATCH 1/2] android: fix building error in st_glsl_to_tgsi

2016-05-30 Thread Mauro Rossi
Fixes the following building error: bionic/libc/include/string.h:105:33: error: call to '__memcpy_dest_size_error' declared with attribute error: memcpy called with size bigger than destination Cc: --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 2 +- 1 file

Re: [Mesa-dev] [PATCH 0/3] r600g removal of unnecessary cache flushes

2016-05-30 Thread Grazvydas Ignotas
I've patched the CS validator and there seem to be some regressions: arb_map_buffer_range 11/11 5/11 copybuffersubdata decrement-offset copybuffersubdata increment-offset copybuffersubdata offset=0 map_invalidate_range_bit decrement-offset map_invalidate_range_bit increment-offset

[Mesa-dev] [PATCH] radeonsi: lower SQRT to RSQ+RCP to fix the game Risen

2016-05-30 Thread Marek Olšák
From: Marek Olšák Sadly, I haven't been able to find any other way to fix the bug for radeonsi. The game seems to expect DX9 behavior. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94627 (against nouveau) --- .../drivers/radeon/radeon_setup_tgsi_llvm.c| 22

[Mesa-dev] [PATCH] st/mesa: change SQRT lowering to fix the game Risen

2016-05-30 Thread Marek Olšák
From: Marek Olšák Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94627 (against nouveau) --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp

Re: [Mesa-dev] [PATCH] radeon/uvd: fix the H264 level for Tonga

2016-05-30 Thread Grigori Goronzy
On 2016-05-27 15:16, Emil Velikov wrote: The odd things is that VLC uses/used to? check that information before feeding the video to the decoder, while others implementations (like the original one in mplayer done by the Nvidia devs) do/did? not bother. Many files either have an incorrect

[Mesa-dev] [Bug 95553] Requesting a new account for mesa and piglit (Andres Gomez)

2016-05-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95553 Andrés Gómez García changed: What|Removed |Added Product|Mesa|freedesktop.org

Re: [Mesa-dev] [PATCH 0/3] r600g removal of unnecessary cache flushes

2016-05-30 Thread Marek Olšák
On Tue, May 31, 2016 at 12:17 AM, Grazvydas Ignotas wrote: > I've tried it on AMD JUNIPER (DRM 2.43.0 / 4.6.0) and it does not pass > the kernel CS validator with > [drm:evergreen_packet3_check.isra.14 [radeon]] *ERROR* Packet3 opcode > 42 not supported > printed many times. >

Re: [Mesa-dev] [PATCH 2/2] winsys/amdgpu: disable CE preamble until the kernel is fixed

2016-05-30 Thread Marek Olšák
I'm dropping the patch. It makes UE4 Elemental hang. We have a bigger CE issue than I thought. It could be a Mesa issue too. Marek On Fri, May 27, 2016 at 12:12 PM, Marek Olšák wrote: > On Fri, May 27, 2016 at 11:12 AM, Christian König > wrote: >> Am

[Mesa-dev] [PATCH 2/3] android: libmesa_glsl: add a dependency on libmesa_nir static

2016-05-30 Thread Mauro Rossi
Fixes the following building error: target C++: libmesa_glsl <= external/mesa/src/compiler/glsl/glsl_to_nir.cpp In file included from external/mesa/src/compiler/glsl/glsl_to_nir.h:28:0, from external/mesa/src/compiler/glsl/glsl_to_nir.cpp:28:

[Mesa-dev] [PATCH 3/3] isl: add support for Android libmesa_isl static library

2016-05-30 Thread Mauro Rossi
isl library is needed to build i965, libmesa_isl static library is added to fix related Android building errors. Any attempt to build libmesa_genxml as phony package module failed to deliver gen{7,75,8,9}_pack.h autogenerated headers, needed to build libmesa_isl_gen{7,75,8,9} Due to constraints

[Mesa-dev] [PATCH 1/3] android: define MESA_EGL_NO_X11_HEADERS

2016-05-30 Thread Mauro Rossi
In order to avoid building errors due to missing X11 headers Cc: --- Android.common.mk | 1 + 1 file changed, 1 insertion(+) diff --git a/Android.common.mk b/Android.common.mk index cdba85f..5df9b7e 100644 --- a/Android.common.mk +++ b/Android.common.mk @@

Re: [Mesa-dev] [PATCH 0/3] r600g removal of unnecessary cache flushes

2016-05-30 Thread Grazvydas Ignotas
I've tried it on AMD JUNIPER (DRM 2.43.0 / 4.6.0) and it does not pass the kernel CS validator with [drm:evergreen_packet3_check.isra.14 [radeon]] *ERROR* Packet3 opcode 42 not supported printed many times. I guess it needs some kernel patch? I haven't found anything relevant in Alex's kernel

Re: [Mesa-dev] [PATCH 2/4] automake: rework the git_sha1.h rule, include in tarball

2016-05-30 Thread Emil Velikov
On 30 May 2016 at 22:22, Emil Velikov wrote: > On 30 May 2016 at 22:02, Jason Ekstrand wrote: >> On May 30, 2016 1:56 PM, "Grazvydas Ignotas" wrote: >>> >>> On Mon, May 30, 2016 at 3:46 PM, Emil Velikov

Re: [Mesa-dev] [PATCH 2/4] automake: rework the git_sha1.h rule, include in tarball

2016-05-30 Thread Emil Velikov
On 30 May 2016 at 22:02, Jason Ekstrand wrote: > On May 30, 2016 1:56 PM, "Grazvydas Ignotas" wrote: >> >> On Mon, May 30, 2016 at 3:46 PM, Emil Velikov >> wrote: >> > From: Emil Velikov >> > >> > As

Re: [Mesa-dev] [PATCH 2/4] automake: rework the git_sha1.h rule, include in tarball

2016-05-30 Thread Jason Ekstrand
On May 30, 2016 1:56 PM, "Grazvydas Ignotas" wrote: > > On Mon, May 30, 2016 at 3:46 PM, Emil Velikov wrote: > > From: Emil Velikov > > > > As we'll need the file in the release tarball, rework the rule so that > > the

Re: [Mesa-dev] [PATCH] mesa: Enable LTO compilation

2016-05-30 Thread Jason Ekstrand
On May 30, 2016 1:31 PM, "Emil Velikov" wrote: > > On 30 May 2016 at 21:10, Jason Ekstrand wrote: >> >> On Mon, May 30, 2016 at 12:27 PM, Emil Velikov wrote: >>> >>> Hi there, >>> On 30 May 2016 at 18:28, ⚛

[Mesa-dev] [Bug 95346] Stellaris - Black/super dark planets

2016-05-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95346 --- Comment #9 from Nicolai Hähnle --- There are several draw calls involved in rendering the planet, the last one is 803895. It's not clear which of them gives the incorrect result. It would be helpful if somebody could

Re: [Mesa-dev] [PATCH 2/4] automake: rework the git_sha1.h rule, include in tarball

2016-05-30 Thread Grazvydas Ignotas
On Mon, May 30, 2016 at 3:46 PM, Emil Velikov wrote: > From: Emil Velikov > > As we'll need the file in the release tarball, rework the rule so that > the file is regenerated _only_ if we're in a git repository. > > With this in place we can

Re: [Mesa-dev] [PATCH] mesa: Enable LTO compilation

2016-05-30 Thread Emil Velikov
On 30 May 2016 at 21:10, Jason Ekstrand wrote: > On Mon, May 30, 2016 at 12:27 PM, Emil Velikov > wrote: > >> Hi there, >> On 30 May 2016 at 18:28, ⚛ <0xe2.0x9a.0...@gmail.com> wrote: >> > This patch enables compilation with -flto. >> > >> > The

Re: [Mesa-dev] [PATCH 2/4] automake: rework the git_sha1.h rule, include in tarball

2016-05-30 Thread Emil Velikov
On 30 May 2016 at 21:11, Matt Turner wrote: > On Mon, May 30, 2016 at 5:46 AM, Emil Velikov > wrote: >> From: Emil Velikov >> >> As we'll need the file in the release tarball, rework the rule so that >> the file is

Re: [Mesa-dev] [PATCH] i965: Shrink stage_prog_data param array length

2016-05-30 Thread Jason Ekstrand
On Mon, May 30, 2016 at 9:50 AM, Emil Velikov wrote: > On 29 May 2016 at 07:01, Jordan Justen wrote: > > It appears we were over-allocating these arrays. > > > > Previously we would use nir->num_uniforms directly for scalar > > programs, and

Re: [Mesa-dev] [PATCH 2/4] automake: rework the git_sha1.h rule, include in tarball

2016-05-30 Thread Matt Turner
On Mon, May 30, 2016 at 5:46 AM, Emil Velikov wrote: > From: Emil Velikov > > As we'll need the file in the release tarball, rework the rule so that > the file is regenerated _only_ if we're in a git repository. > > With this in place we can

Re: [Mesa-dev] [PATCH] mesa: Enable LTO compilation

2016-05-30 Thread Jason Ekstrand
On Mon, May 30, 2016 at 12:27 PM, Emil Velikov wrote: > Hi there, > On 30 May 2016 at 18:28, ⚛ <0xe2.0x9a.0...@gmail.com> wrote: > > This patch enables compilation with -flto. > > > > The performance benefits of LTO (GCC 4.9 & 6.1) are about 1% for > glxgears. > >

Re: [Mesa-dev] [PATCH 4/4] mesa: remove MESA_GIT_SHA1 guard

2016-05-30 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Mon, May 30, 2016 at 5:46 AM, Emil Velikov wrote: > From: Emil Velikov > > As of a few commits ago the header will always contain the macro. > > Signed-off-by: Emil Velikov

Re: [Mesa-dev] [PATCH 2/4] automake: rework the git_sha1.h rule, include in tarball

2016-05-30 Thread Jason Ekstrand
On Mon, May 30, 2016 at 5:46 AM, Emil Velikov wrote: > From: Emil Velikov > > As we'll need the file in the release tarball, rework the rule so that > the file is regenerated _only_ if we're in a git repository. > > With this in place we can

Re: [Mesa-dev] [PATCH] mesa: Enable LTO compilation

2016-05-30 Thread Emil Velikov
Hi there, On 30 May 2016 at 18:28, ⚛ <0xe2.0x9a.0...@gmail.com> wrote: > This patch enables compilation with -flto. > > The performance benefits of LTO (GCC 4.9 & 6.1) are about 1% for glxgears. > Performance changes in OpenGL games haven't been measured yet, my feeling is > that they are

[Mesa-dev] Mesa 12.0.0 release candidate 1

2016-05-30 Thread Emil Velikov
The first release candidate for Mesa 12.0.0 is now available. The plan is to have one release candidate every Friday, until the final release on June 10th or June 17th 2016. As a reminder, with the 12.0 branch now created, patches nominated with: CC:

[Mesa-dev] [Bug 95005] Unreal engine demos segfault after shader compilation error with OpenGL 4.3

2016-05-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95005 --- Comment #16 from Marek Olšák --- Can this bug be closed then? -- You are receiving this mail because: You are on the CC list for the bug.___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH v3 04/14] i965/anv: Add uniform for a CS thread local base ID

2016-05-30 Thread Jason Ekstrand
I don't think "anv" is the right prefix for this patch. Really, it's adding local_id_index to cs_prog_data. By and large, I think the code at the end of the series is what we want. I made a few comments but not many. However, I think we could make it a bit more bisectable if we wanted. If you

Re: [Mesa-dev] [PATCH] mesa: Enable LTO compilation

2016-05-30 Thread Pierre Moreau
Ok, I found the answer to my question regarding the `-fno-lto`. IMHO that should be in the commit message, since the patch only checks for availability and disables LTO in one case, never enabling it explicitely. Please ignore my previous mail. Pierre On 11:06 AM - May 30 2016, Matt Turner

Re: [Mesa-dev] [PATCH] mesa: Enable LTO compilation

2016-05-30 Thread
On Mon, May 30, 2016 at 8:07 PM, Pierre Moreau wrote: > On 07:28 PM - May 30 2016, ⚛ wrote: >> +if COMPILER_UNDERSTANDS_LTO >> +CFLAGS += -fno-lto >> +CXXFLAGS += -fno-lto > > This should be `-flto` if I’m not mistaken. > > Pierre -fno-lto is correct because GCC has issues

Re: [Mesa-dev] [PATCH] mesa: Enable LTO compilation

2016-05-30 Thread Matt Turner
On Mon, May 30, 2016 at 11:02 AM, ⚛ <0xe2.0x9a.0...@gmail.com> wrote: > > On Mon, May 30, 2016 at 7:39 PM, Matt Turner wrote: >> >> On Mon, May 30, 2016 at 10:28 AM, <0xe2.0x9a.0...@gmail.com> wrote: >> > This patch enables compilation with -flto. >> > >> > The performance

Re: [Mesa-dev] [PATCH] mesa: Enable LTO compilation

2016-05-30 Thread Pierre Moreau
On 07:28 PM - May 30 2016, ⚛ wrote: > This patch enables compilation with -flto. > > The performance benefits of LTO (GCC 4.9 & 6.1) are about 1% for glxgears. > Performance changes in OpenGL games haven't been measured yet, my feeling > is that they are negligible. > diff --git a/configure.ac

Re: [Mesa-dev] [PATCH 2/2] vc4: Fix doxygen warnings

2016-05-30 Thread Emil Velikov
On 25 May 2016 at 22:10, Rhys Kidd wrote: > Now that vc4 automated code documentation can be generated with > doxygen, fix the warnings issued by Doxygen 1.8.11. > > Signed-off-by: Rhys Kidd > --- > src/gallium/drivers/vc4/vc4_qir_schedule.c | 4 ++-- >

[Mesa-dev] [PATCH 3/3] glsl: add gl_BoundingBox and associated varying slots

2016-05-30 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/compiler/glsl/builtin_variables.cpp | 10 ++ src/compiler/glsl/ir_set_program_inouts.cpp | 4 +++- src/compiler/shader_enums.c | 2 ++ src/compiler/shader_enums.h | 4

[Mesa-dev] [PATCH 2/3] mesa: add support for GL_PRIMITIVE_BOUNDING_BOX storage and query

2016-05-30 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/mesa/main/bbox.c | 19 +++ src/mesa/main/get.c | 28 src/mesa/main/get_hash_params.py | 3 +++ src/mesa/main/mtypes.h | 7 +++ 4 files changed, 57

[Mesa-dev] [PATCH 1/3] mesa: add scaffolding for OES/EXT_primitive_bounding_box

2016-05-30 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/compiler/glsl/glsl_parser_extras.cpp | 2 ++ src/compiler/glsl/glsl_parser_extras.h | 4 +++ src/mapi/glapi/gen/es_EXT.xml| 49 src/mapi/glapi/gen/gl_genexec.py | 1 +

Re: [Mesa-dev] [PATCH] mesa: Enable LTO compilation

2016-05-30 Thread Rob Clark
On Mon, May 30, 2016 at 1:39 PM, Matt Turner wrote: > On Mon, May 30, 2016 at 10:28 AM, ⚛ <0xe2.0x9a.0...@gmail.com> wrote: >> This patch enables compilation with -flto. >> >> The performance benefits of LTO (GCC 4.9 & 6.1) are about 1% for glxgears. >> Performance changes in

Re: [Mesa-dev] [PATCH v3 08/14] i965: Add CS push constant info to brw_cs_prog_data

2016-05-30 Thread Jason Ekstrand
On Sun, May 29, 2016 at 3:38 PM, Jordan Justen wrote: > We need information about push constants in a few places for the GL > driver, and another couple places for the vulkan driver. > > When we add support for uploading both a common (cross-thread) set of > push

Re: [Mesa-dev] [PATCH v3 07/14] i965: Store number of threads in brw_cs_prog_data

2016-05-30 Thread Jason Ekstrand
Can the Vulkan driver take advantage of this too? On Sun, May 29, 2016 at 3:38 PM, Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > src/mesa/drivers/dri/i965/brw_compiler.h | 1 + > src/mesa/drivers/dri/i965/brw_fs.cpp |

Re: [Mesa-dev] [PATCH v3 06/14] i965: Add nir based intrinsic lowering and thread ID uniform

2016-05-30 Thread Jason Ekstrand
On Sun, May 29, 2016 at 3:38 PM, Jordan Justen wrote: > We add a lowering pass for nir intrinsics. This pass can replace nir > intrinsics with driver specific nir lower code. > > We lower the gl_LocalInvocationIndex intrinsic based on a uniform > which is loaded with a

Re: [Mesa-dev] [PATCH] mesa: Enable LTO compilation

2016-05-30 Thread Matt Turner
On Mon, May 30, 2016 at 10:28 AM, ⚛ <0xe2.0x9a.0...@gmail.com> wrote: > This patch enables compilation with -flto. > > The performance benefits of LTO (GCC 4.9 & 6.1) are about 1% for glxgears. > Performance changes in OpenGL games haven't been measured yet, my feeling is > that they are

Re: [Mesa-dev] [PATCH 23/25] i965/fs: Allow scalar source regions on SNB math instructions.

2016-05-30 Thread Matt Turner
On Fri, May 27, 2016 at 7:06 PM, Francisco Jerez wrote: > I haven't found any evidence that this isn't supported by the > hardware, in fact according to the SNB hardware spec: > > "The supported regioning modes for math instructions are align16, > align1 with the

[Mesa-dev] [PATCH] mesa: Enable LTO compilation

2016-05-30 Thread
This patch enables compilation with -flto. The performance benefits of LTO (GCC 4.9 & 6.1) are about 1% for glxgears. Performance changes in OpenGL games haven't been measured yet, my feeling is that they are negligible. diff --git a/configure.ac b/configure.ac index fc0b1db..e84a1ad 100644 ---

Re: [Mesa-dev] [PATCH 00/25] i965: Scalar back-end support for SIMD32, part 4.

2016-05-30 Thread Jason Ekstrand
On Sun, May 29, 2016 at 12:01 PM, Francisco Jerez wrote: > Francisco Jerez writes: > > > Jason Ekstrand writes: > > > >> On Fri, May 27, 2016 at 7:05 PM, Francisco Jerez > > >> wrote: > >> > >>> This

Re: [Mesa-dev] [PATCH 20/25] i965/fs: Extend compute_to_mrf() to coalesce VGRFs initialized by multiple single-GRF writes.

2016-05-30 Thread Jason Ekstrand
On Fri, May 27, 2016 at 7:06 PM, Francisco Jerez wrote: > This requires using a bitset instead of a boolean flag to keep track > of the GRFs we've seen a generating instruction for already. The > search loop continues until all instructions initializing the value of > the

Re: [Mesa-dev] [PATCH] i965: Shrink stage_prog_data param array length

2016-05-30 Thread Emil Velikov
On 29 May 2016 at 07:01, Jordan Justen wrote: > It appears we were over-allocating these arrays. > > Previously we would use nir->num_uniforms directly for scalar > programs, and multiply it by 4 for vec4 programs. > > Instead we should have been dividing by 4 in both

[Mesa-dev] [Bug 95294] Support importing R8 and GR88 dma_bufs on ARM

2016-05-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95294 Emil Velikov changed: What|Removed |Added Status|NEW |RESOLVED

Re: [Mesa-dev] [PATCH v3 3/3] gallium: push offset down to driver

2016-05-30 Thread Stanimir Varbanov
Cc Rob. Sorry I forgot to Cc you on this v3. On 05/27/2016 08:24 PM, Emil Velikov wrote: > Hi Stan > > On Thursday, 26 May 2016, Stanimir Varbanov > wrote: > >> Push offset down to drivers when importing dmabuf. This is needed >> to more fully support

[Mesa-dev] [Bug 95294] Support importing R8 and GR88 dma_bufs on ARM

2016-05-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95294 --- Comment #2 from Stanimir --- Please see the patchset at https://patchwork.freedesktop.org/series/7206/ -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the

[Mesa-dev] [Bug 95110] Some Ogre 2.1 demos doesn't render properly

2016-05-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95110 Marek Olšák changed: What|Removed |Added Resolution|--- |NOTOURBUG

[Mesa-dev] [Bug 95246] Segfault in glBindFramebuffer()

2016-05-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95246 --- Comment #2 from Marek Olšák --- Fix: https://lists.freedesktop.org/archives/mesa-dev/2016-May/118763.html -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

[Mesa-dev] [PATCH] mesa: fix crash in driver_RenderTexture_is_safe

2016-05-30 Thread Marek Olšák
From: Marek Olšák This just fixed the crash with the apitrace in bug report. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=95246 Cc: 11.1 11.2 --- src/mesa/main/fbobject.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

[Mesa-dev] [Bug 95128] [Gallium] uninitialized once_flag causes unregistered targets

2016-05-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95128 Marek Olšák changed: What|Removed |Added Resolution|--- |FIXED

Re: [Mesa-dev] [Mesa-stable] [PATCH] glx: fix crash with bad fbconfig

2016-05-30 Thread Emil Velikov
Hi gents, On 30 May 2016 at 10:13, Tapani Pälli wrote: > From: Daniel Czarnowski > > GLX documentation states: > glXCreateNewContext can generate the following errors: (...) > GLXBadFBConfig if config is not a valid

Re: [Mesa-dev] [PATCH 0/2] fix load of unpacked double vector input varyings

2016-05-30 Thread Samuel Iglesias Gonsálvez
On 27/05/16 08:39, Samuel Iglesias Gonsálvez wrote: > > > On 26/05/16 09:46, Timothy Arceri wrote: >> On Thu, 2016-05-26 at 17:44 +1000, Timothy Arceri wrote: >>> On Thu, 2016-05-26 at 07:56 +0200, Samuel Iglesias Gonsálvez wrote: Hello, Timothy found that tests with

[Mesa-dev] [PATCH 3/2] i965/gs/scalar: Fix load input for doubles

2016-05-30 Thread Samuel Iglesias Gonsálvez
Signed-off-by: Samuel Iglesias Gonsálvez --- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 72 1 file changed, 54 insertions(+), 18 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp

Re: [Mesa-dev] [PATCH] radeon/uvd: fix the H264 level for Tonga

2016-05-30 Thread Andy Furniss
Christian König wrote: Am 28.05.2016 um 00:45 schrieb Andy Furniss: Emil Velikov wrote: On 27 May 2016 at 15:40, Christian König wrote: No, what I'm saying is that it is a number and not an enum. This way you don't need to change the specification when you want to

Re: [Mesa-dev] [PATCH v3] glx: fix error code when there is no context bound

2016-05-30 Thread Emil Velikov
On 30 May 2016 at 07:53, Tapani Pälli wrote: > From: Bernard Kilarski > > v2: change all related NULL checks to check against dummyContext > v3: really check for dummyContext *only* when ctx was from > __glXGetCurrentContext > >

Re: [Mesa-dev] [PATCH v2 14/18] mesa_glinterop: remove mesa_glinterop typedefs

2016-05-30 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Mon, May 30, 2016 at 2:47 PM, Emil Velikov wrote: > From: Emil Velikov > > As is there are two places that do the typedefs - dri_interface.h and > this header. As we cannot include the

[Mesa-dev] [PATCH v2 14/18] mesa_glinterop: remove mesa_glinterop typedefs

2016-05-30 Thread Emil Velikov
From: Emil Velikov As is there are two places that do the typedefs - dri_interface.h and this header. As we cannot include the former in here, just drop the typedefs and use the struct directly (as needed). This is required because typedef redefinition is C11 feature

[Mesa-dev] [PATCH 4/4] mesa: remove MESA_GIT_SHA1 guard

2016-05-30 Thread Emil Velikov
From: Emil Velikov As of a few commits ago the header will always contain the macro. Signed-off-by: Emil Velikov --- src/mesa/main/version.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/mesa/main/version.c

[Mesa-dev] [PATCH 1/4] scons: move the git_sha1.h rule a level up

2016-05-30 Thread Emil Velikov
From: Emil Velikov Analogous to the previous commit. Cc: Brian Paul Cc: Jose Fonseca Signed-off-by: Emil Velikov --- src/SConscript | 39 +++

[Mesa-dev] [PATCH 2/4] automake: rework the git_sha1.h rule, include in tarball

2016-05-30 Thread Emil Velikov
From: Emil Velikov As we'll need the file in the release tarball, rework the rule so that the file is regenerated _only_ if we're in a git repository. With this in place we can build vulkan (anv) from a release tarball. Cc: Jason Ekstrand

[Mesa-dev] [PATCH 3/4] scons: rework the git_sha1.h generation rule

2016-05-30 Thread Emil Velikov
From: Emil Velikov Analogous to the previous commit Cc: Brian Paul Cc: Jose Fonseca Signed-off-by: Emil Velikov --- Note: this may cause "false positives" if one extracts the release tarball in

Re: [Mesa-dev] [PATCH] radeon/uvd: fix the H264 level for Tonga

2016-05-30 Thread Christian König
Am 28.05.2016 um 00:45 schrieb Andy Furniss: Emil Velikov wrote: On 27 May 2016 at 15:40, Christian König wrote: No, what I'm saying is that it is a number and not an enum. This way you don't need to change the specification when you want to support a new level.

[Mesa-dev] [PATCH] radeon/uvd: fix the H264 level for Tonga v2

2016-05-30 Thread Christian König
From: Christian König We support 5.2 for a while now. v2: we even support 5.2 for H264, 5.1 is for HEVC. Signed-off-by: Christian König Cc: --- src/gallium/drivers/radeon/radeon_video.c | 2 +- 1 file

Re: [Mesa-dev] Drivers/Gallium/swr is missing from the list of Mesa components when entering a new bug

2016-05-30 Thread Emil Velikov
On 28 May 2016 at 12:40, Rowley, Timothy O wrote: > > Maybe I wasn’t clear about my opinion when Emil asked before: I’m fine with a > swr component in bugzilla if that’s what the people in charge of bugzilla > would like. I come with past experience in mozilla

[Mesa-dev] [Bug 96238] swr fails to build outside of the main directory

2016-05-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96238 Emil Velikov changed: What|Removed |Added Status|NEW |RESOLVED

Re: [Mesa-dev] [PATCH 1/2] gallium/util: fix coverity MIXED_ENUMS warning

2016-05-30 Thread Marek Olšák
On Sun, May 29, 2016 at 6:32 PM, Rob Clark wrote: > From: Rob Clark > > CID 1362171, 1362170 > > Looks like it should be pipe_transfer_usage in the prototype, based on > how the parameter is used. Note that I don't see any users of u_staging > so

[Mesa-dev] [PATCH] glx: fix crash with bad fbconfig

2016-05-30 Thread Tapani Pälli
From: Daniel Czarnowski GLX documentation states: glXCreateNewContext can generate the following errors: (...) GLXBadFBConfig if config is not a valid GLXFBConfig Function checks if the given config is a valid config and sets proper error code.

Re: [Mesa-dev] [PATCH] nvc0: fix some compute texture validation bits on kepler

2016-05-30 Thread Samuel Pitoiset
We should just try to refactor nve4_validate_tic() and nve4_compute_validate_textures() because it's quite similar now. Anyway, this patch is: Reviewed-by: Samuel Pitoiset On 05/30/2016 04:18 AM, Ilia Mirkin wrote: (a) Make sure to update the TIC in case of an

[Mesa-dev] [PATCH v3] glx: fix error code when there is no context bound

2016-05-30 Thread Tapani Pälli
From: Bernard Kilarski v2: change all related NULL checks to check against dummyContext v3: really check for dummyContext *only* when ctx was from __glXGetCurrentContext Signed-off-by: Bernard Kilarski Signed-off-by: Matt Roper