Re: [Mesa-dev] [PATCH] radv: drop unused fields in physical device.

2016-12-12 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan On 12/13/2016 02:58 PM, Dave Airlie wrote: > From: Dave Airlie > > Signed-off-by: Dave Airlie > --- > src/amd/vulkan/radv_private.h | 6 -- > 1 file changed, 6 deletions(-) > > diff

Re: [Mesa-dev] [PATCH 1/9] i965/gen6+: Invalidate constant cache on brw_emit_mi_flush().

2016-12-12 Thread Kenneth Graunke
On Friday, December 9, 2016 11:03:24 AM PST Francisco Jerez wrote: > In order to make sure that the constant cache is coherent with > previous rendering when we start using it for pull constant loads. > --- > src/mesa/drivers/dri/i965/brw_pipe_control.c | 1 + > 1 file changed, 1 insertion(+) >

Re: [Mesa-dev] [PATCH v2 2/7] nir/lower_tex: add lowering for texture gradient on cube maps

2016-12-12 Thread Iago Toral
On Mon, 2016-12-12 at 23:14 -0800, Kenneth Graunke wrote: > On Monday, December 12, 2016 2:11:43 PM PST Iago Toral Quiroga wrote: > > > > This is ported from the Intel lowering pass that we use with GLSL > > IR. > > The NIR pass only handles cube maps, not shadow samplers, which are > > also

Re: [Mesa-dev] [PATCH v2 2/7] nir/lower_tex: add lowering for texture gradient on cube maps

2016-12-12 Thread Kenneth Graunke
On Monday, December 12, 2016 2:11:43 PM PST Iago Toral Quiroga wrote: > This is ported from the Intel lowering pass that we use with GLSL IR. > The NIR pass only handles cube maps, not shadow samplers, which are > also lowered for gen < 8 on Intel hardware. We will add support for > that in a

Re: [Mesa-dev] [PATCH] glsl: Make copy propagation not panic when it sees an intrinsic.

2016-12-12 Thread Kenneth Graunke
On Monday, December 12, 2016 4:35:46 PM PST Marek Olšák wrote: [snip] > Yeah, the GLSL compiler can't really do anything if it sees a bitcast. > I tried to write a pass that removes bitcasts, but it's a PITA because > you can have a vec4 where xzw are used as float and y as int. > > I just gave

[Mesa-dev] [PATCH 2/2] glsl: Make copy propagation not panic when it sees an intrinsic.

2016-12-12 Thread Kenneth Graunke
A number of games have large arrays of constants, which we promote to uniforms. This introduces copies from the uniform array to the original temporary array. Normally, copy propagation eliminates those copies, making everything refer to the uniform array directly. A number of shaders in "Deus

[Mesa-dev] [PATCH 1/2] i965: Make DCE set null destinations on messages with side effects.

2016-12-12 Thread Kenneth Graunke
(Co-authored by Matt Turner.) Image atomics, for example, return a value - but the shader may not want to use it. We assigned a useless VGRF destination. This seemed harmless, but it can actually be quite harmful. The register allocator has to assign that VGRF to a real register. It may

[Mesa-dev] [PATCH] [rfc] radv: add initial prime support. (v2)

2016-12-12 Thread Dave Airlie
From: Dave Airlie This is a repost of the prime support with some minor changes, you no longer need to set DRI_PRIME for this code to figure out it's on a different GPU and do the linear transfers. In order to decide the default GPU I'll have to write a layer so I'll try and

[Mesa-dev] [PATCH] radv: drop unused fields in physical device.

2016-12-12 Thread Dave Airlie
From: Dave Airlie Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_private.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/src/amd/vulkan/radv_private.h b/src/amd/vulkan/radv_private.h index 3d4b111..2ecc48e 100644 ---

[Mesa-dev] [PATCH 3/6] nir/builder: Add a helper for getting the most recently added instruction

2016-12-12 Thread Jason Ekstrand
--- src/compiler/nir/nir_builder.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/compiler/nir/nir_builder.h b/src/compiler/nir/nir_builder.h index 44d03c8..27d9844 100644 --- a/src/compiler/nir/nir_builder.h +++ b/src/compiler/nir/nir_builder.h @@ -68,6 +68,13 @@

[Mesa-dev] [PATCH 6/6] i965/compiler: Use the new nir_opt_copy_prop_vars pass

2016-12-12 Thread Jason Ekstrand
We run this after nir_lower_vars_to_ssa so that as many load/store_var intrinsics as possible before copy_prop_vars executes. This is because the pass isn't particularly efficient (it does a lot of linear walks of a linked list) so we'd like as much of the work as possible to be done before

[Mesa-dev] [PATCH 2/6] nir/builder: Add a load_deref_var helper

2016-12-12 Thread Jason Ekstrand
--- src/compiler/nir/nir_builder.h | 16 1 file changed, 16 insertions(+) diff --git a/src/compiler/nir/nir_builder.h b/src/compiler/nir/nir_builder.h index 0ee7d1a..44d03c8 100644 --- a/src/compiler/nir/nir_builder.h +++ b/src/compiler/nir/nir_builder.h @@ -411,6 +411,22 @@

[Mesa-dev] [PATCH 1/6] nir/dead_variables: Remove shader-local variables that are only written

2016-12-12 Thread Jason Ekstrand
--- src/compiler/nir/nir_remove_dead_variables.c | 66 1 file changed, 58 insertions(+), 8 deletions(-) diff --git a/src/compiler/nir/nir_remove_dead_variables.c b/src/compiler/nir/nir_remove_dead_variables.c index f7429eb..d22b7f5 100644 ---

[Mesa-dev] [PATCH 5/6] i965: use nir_lower_indirect_derefs() for GLSL

2016-12-12 Thread Jason Ekstrand
From: Timothy Arceri This moves the nir_lower_indirect_derefs() call into brw_preprocess_nir() so thats is called by both OpenGL and Vulkan and removes that call to the old GLSL IR pass lower_variable_index_to_cond_assign() We want to do this pass in nir to be able

[Mesa-dev] [PATCH 4/6] nir: Add a local variable-based copy propagation pass

2016-12-12 Thread Jason Ekstrand
--- src/compiler/Makefile.sources | 1 + src/compiler/nir/nir.h| 2 + src/compiler/nir/nir_opt_copy_prop_vars.c | 799 ++ 3 files changed, 802 insertions(+) create mode 100644 src/compiler/nir/nir_opt_copy_prop_vars.c diff --git

Re: [Mesa-dev] [Mesa-maintainers] Proposal of date-based Mesa versioning for 2017

2016-12-12 Thread Jonathan Gray
On Mon, Dec 12, 2016 at 03:28:45PM +, Emil Velikov wrote: > [adding mesa-maintainers to the mix] > > On 1 October 2016 at 20:46, Marek Olk wrote: > > Hi, > > > > I propose that we use versioning in the form of "year.quarter". > > > > 2017 would start with 17.0, then

[Mesa-dev] [PATCH] swr: Implement fence attached work queues for deferred deletion.

2016-12-12 Thread Bruce Cherniak
Work can now be added to fences and triggered by fence completion. This allows for deferred resource deletion, and other asynchronous tasks. --- src/gallium/drivers/swr/Makefile.sources | 2 + src/gallium/drivers/swr/swr_context.cpp| 7 +- src/gallium/drivers/swr/swr_fence.cpp |

[Mesa-dev] [Bug 99055] Games hang / freeze completely

2016-12-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99055 --- Comment #11 from Michel Dänzer --- (In reply to Etienne Bruines from comment #8) > The issue was introduced after updating all package, among which most likely > glibc ones. However, I was unable to find any glibc package

Re: [Mesa-dev] [Mesa-maintainers] Proposal of date-based Mesa versioning for 2017

2016-12-12 Thread Igor Gnatenko
On Mon, Dec 12, 2016 at 4:28 PM, Emil Velikov wrote: > [adding mesa-maintainers to the mix] > > On 1 October 2016 at 20:46, Marek Olšák wrote: >> Hi, >> >> I propose that we use versioning in the form of "year.quarter". >> >> 2017 would start with

[Mesa-dev] [Bug 98869] Electronic Super Joy graphic artefacts (regression)

2016-12-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98869 --- Comment #8 from cosiek...@o2.pl --- Similar bug is present in sequel. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___ mesa-dev

[Mesa-dev] [Bug 98869] Electronic Super Joy graphic artefacts (regression)

2016-12-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98869 --- Comment #7 from cosiek...@o2.pl --- Created attachment 128445 --> https://bugs.freedesktop.org/attachment.cgi?id=128445=edit apitrace -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

[Mesa-dev] [Bug 98869] Electronic Super Joy graphic artefacts (regression)

2016-12-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98869 --- Comment #6 from cosiek...@o2.pl --- Created attachment 128444 --> https://bugs.freedesktop.org/attachment.cgi?id=128444=edit Log from aplication -- You are receiving this mail because: You are the QA Contact for the bug. You are the

Re: [Mesa-dev] [PATCH v2 6/7] i965: Enable arb_transform_feedback_overflow_query.

2016-12-12 Thread Rafael Antognolli
On Mon, Dec 12, 2016 at 02:40:28PM -0500, Ilia Mirkin wrote: > On Mon, Dec 12, 2016 at 1:56 PM, Rafael Antognolli > wrote: > > On Mon, Dec 12, 2016 at 01:51:01PM -0500, Ilia Mirkin wrote: > >> On Mon, Dec 12, 2016 at 1:47 PM, Rafael Antognolli > >>

Re: [Mesa-dev] [PATCH] swr: [rasterizer core/memory] StoreTile: AVX512 progress

2016-12-12 Thread Cherniak, Bruce
Reviewed-by: Bruce Cherniak > On Dec 12, 2016, at 1:30 PM, Rowley, Timothy O > wrote: > > Fixes to 128-bit formats. > --- > src/gallium/drivers/swr/rasterizer/core/utils.h| 8 +- > .../drivers/swr/rasterizer/memory/StoreTile.h |

Re: [Mesa-dev] [PATCH v2 6/7] i965: Enable arb_transform_feedback_overflow_query.

2016-12-12 Thread Ilia Mirkin
On Mon, Dec 12, 2016 at 1:56 PM, Rafael Antognolli wrote: > On Mon, Dec 12, 2016 at 01:51:01PM -0500, Ilia Mirkin wrote: >> On Mon, Dec 12, 2016 at 1:47 PM, Rafael Antognolli >> wrote: >> >> > It is possible to query for overflow on gen6,

[Mesa-dev] [PATCH] swr: [rasterizer core/memory] StoreTile: AVX512 progress

2016-12-12 Thread Tim Rowley
Fixes to 128-bit formats. --- src/gallium/drivers/swr/rasterizer/core/utils.h| 8 +- .../drivers/swr/rasterizer/memory/StoreTile.h | 352 - 2 files changed, 138 insertions(+), 222 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/core/utils.h

Re: [Mesa-dev] Proposal of date-based Mesa versioning for 2017

2016-12-12 Thread Laurent Carlier
Le lundi 12 décembre 2016 19:01:12 CET, vous avez écrit : > Similar to the "libudev is no longer required by mesa" in the 13.0.0 > release notes ;-) > Sorry I could not resist. > "Sticks and stones may break my bones, but words will never hurt me." :) -- Laurent Carlier

Re: [Mesa-dev] Proposal of date-based Mesa versioning for 2017

2016-12-12 Thread Emil Velikov
[Re-adding mesa-maintainers] On 12 December 2016 at 18:08, Laurent Carlier wrote: > Le lundi 12 décembre 2016, 17:57:28 CET Marek Olšák a écrit : >> >> I second that. YY.AA where YY=year, AA \in {0,1,2,3}. >> >> Marek > > I agree, using month is really confusing > Similar

Re: [Mesa-dev] [PATCH v2 6/7] i965: Enable arb_transform_feedback_overflow_query.

2016-12-12 Thread Rafael Antognolli
On Mon, Dec 12, 2016 at 01:51:01PM -0500, Ilia Mirkin wrote: > On Mon, Dec 12, 2016 at 1:47 PM, Rafael Antognolli > wrote: > >> > It is possible to query for overflow on gen6, so in theory there's no > >> > reason to not enable it. > >> > >> The code (gen6+) doesn't

Re: [Mesa-dev] [PATCH v2 6/7] i965: Enable arb_transform_feedback_overflow_query.

2016-12-12 Thread Ilia Mirkin
On Mon, Dec 12, 2016 at 1:47 PM, Rafael Antognolli wrote: >> > It is possible to query for overflow on gen6, so in theory there's no >> > reason to not enable it. >> >> The code (gen6+) doesn't match with the doc changes (gen7+). >> >> I think the patch subject should

Re: [Mesa-dev] [PATCH v2 6/7] i965: Enable arb_transform_feedback_overflow_query.

2016-12-12 Thread Rafael Antognolli
On Mon, Dec 12, 2016 at 10:00:42AM -0800, Jordan Justen wrote: > On 2016-12-12 07:06:50, Rafael Antognolli wrote: > > On Fri, Dec 09, 2016 at 10:35:58PM -0800, Jordan Justen wrote: > > > On 2016-12-09 13:39:52, Rafael Antognolli wrote: > > > > This extension adds new query types which can be used

Re: [Mesa-dev] Proposal of date-based Mesa versioning for 2017

2016-12-12 Thread Laurent Carlier
Le lundi 12 décembre 2016, 17:57:28 CET Marek Olšák a écrit : > > I second that. YY.AA where YY=year, AA \in {0,1,2,3}. > > Marek I agree, using month is really confusing -- Laurent Carlier http://www.archlinux.org signature.asc Description: This is a digitally signed message part.

Re: [Mesa-dev] [PATCH v2 6/7] i965: Enable arb_transform_feedback_overflow_query.

2016-12-12 Thread Jordan Justen
On 2016-12-12 07:06:50, Rafael Antognolli wrote: > On Fri, Dec 09, 2016 at 10:35:58PM -0800, Jordan Justen wrote: > > On 2016-12-09 13:39:52, Rafael Antognolli wrote: > > > This extension adds new query types which can be used to detect overflow > > > of transform feedback buffers. The new query

Re: [Mesa-dev] Proposal of date-based Mesa versioning for 2017

2016-12-12 Thread Matt Turner
On Mon, Dec 12, 2016 at 7:28 AM, Emil Velikov wrote: > * Should we drop the $VERSION directory in the URL, since it causes a > fair bit of nuisance during RC stage. > Namely from: > https://mesa.freedesktop.org/archive/$VERSION/mesa-$VERSION.tar.{xz,gz} > to: >

Re: [Mesa-dev] Proposal of date-based Mesa versioning for 2017

2016-12-12 Thread Jason Ekstrand
On Mon, Dec 12, 2016 at 8:57 AM, Marek Olšák wrote: > On Mon, Dec 12, 2016 at 4:46 PM, Nicolai Hähnle > wrote: > > On 12.12.2016 16:41, Daniel Stone wrote: > >> > >> On 12 December 2016 at 15:28, Emil Velikov > >> wrote: > >>> >

Re: [Mesa-dev] Proposal of date-based Mesa versioning for 2017

2016-12-12 Thread Marek Olšák
On Mon, Dec 12, 2016 at 6:04 PM, Jason Ekstrand wrote: > On Mon, Dec 12, 2016 at 8:57 AM, Marek Olšák wrote: >> >> On Mon, Dec 12, 2016 at 4:46 PM, Nicolai Hähnle >> wrote: >> > On 12.12.2016 16:41, Daniel Stone wrote: >> >> >> >> On

Re: [Mesa-dev] Proposal of date-based Mesa versioning for 2017

2016-12-12 Thread Marek Olšák
On Mon, Dec 12, 2016 at 4:46 PM, Nicolai Hähnle wrote: > On 12.12.2016 16:41, Daniel Stone wrote: >> >> On 12 December 2016 at 15:28, Emil Velikov >> wrote: >>> >>> As mentioned by others - having the second number represent the month >>> would be

[Mesa-dev] [Bug 99055] Games hang / freeze completely

2016-12-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99055 --- Comment #10 from Etienne Bruines --- > Do you mean that the freeze happens also with latest Mesa, it just takes a > bit more time? The freeze also happens, it just takes a bit more time, yes. Meaning: a while it's

[Mesa-dev] [Bug 99055] Games hang / freeze completely

2016-12-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99055 --- Comment #9 from Eero Tamminen --- (In reply to Etienne Bruines from comment #8) > However, it was brought to my attention that this issue wasn't fixed, just > delayed a bit :-( > This time it lasted 45 minutes

[Mesa-dev] [Bug 99055] Games hang / freeze completely

2016-12-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99055 Etienne Bruines changed: What|Removed |Added Status|RESOLVED|REOPENED

Re: [Mesa-dev] Proposal of date-based Mesa versioning for 2017

2016-12-12 Thread Emil Velikov
On 12 December 2016 at 15:41, Daniel Stone wrote: > Hi, > > On 12 December 2016 at 15:28, Emil Velikov wrote: >> As mentioned by others - having the second number represent the month >> would be better, afaict. >> Namely: YY.MM.PP. Thus 17.02.01

Re: [Mesa-dev] Proposal of date-based Mesa versioning for 2017

2016-12-12 Thread Nicolai Hähnle
On 12.12.2016 16:41, Daniel Stone wrote: On 12 December 2016 at 15:28, Emil Velikov wrote: As mentioned by others - having the second number represent the month would be better, afaict. Namely: YY.MM.PP. Thus 17.02.01 provides direct and clear feedback that - 2017

Re: [Mesa-dev] [PATCH] glsl: Make copy propagation not panic when it sees an intrinsic.

2016-12-12 Thread Marek Olšák
On Mon, Dec 12, 2016 at 6:28 AM, Timothy Arceri wrote: > On Mon, 2016-12-12 at 11:35 +1100, Timothy Arceri wrote: >> On Sun, 2016-12-11 at 00:00 -0800, Kenneth Graunke wrote: >> > >> > On Saturday, December 10, 2016 12:37:16 PM PST Matt Turner wrote: >> > > >> > > >>

Re: [Mesa-dev] Proposal of date-based Mesa versioning for 2017

2016-12-12 Thread Daniel Stone
Hi, On 12 December 2016 at 15:28, Emil Velikov wrote: > As mentioned by others - having the second number represent the month > would be better, afaict. > Namely: YY.MM.PP. Thus 17.02.01 provides direct and clear feedback that > - 2017 release, from the second month

[Mesa-dev] [Bug 99055] Games hang / freeze completely

2016-12-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99055 --- Comment #7 from Eero Tamminen --- (In reply to Etienne Bruines from comment #5) > Created attachment 128433 [details] > Backtrace upon crash If that's the whole backtrace command output, deadlock doesn't seem be

[Mesa-dev] [Bug 99055] Games hang / freeze completely

2016-12-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99055 Etienne Bruines changed: What|Removed |Added Status|NEW |RESOLVED

Re: [Mesa-dev] [PATCH shader-db] run: don't use alloca to avoid random crashes in the GLSL compiler

2016-12-12 Thread Eero Tamminen
Hi, On 07.12.2016 20:03, Ian Romanick wrote: On 12/07/2016 09:44 AM, Marek Olšák wrote: On Wed, Dec 7, 2016 at 6:42 PM, Ilia Mirkin wrote: What's wrong with feeding it stack memory? I don't really have an answer to that. > Does valgrind provide any clues? Valgrind

Re: [Mesa-dev] Proposal of date-based Mesa versioning for 2017

2016-12-12 Thread Emil Velikov
[adding mesa-maintainers to the mix] On 1 October 2016 at 20:46, Marek Olšák wrote: > Hi, > > I propose that we use versioning in the form of "year.quarter". > > 2017 would start with 17.0, then 17.1, 17.2, 17.3 for following > quarters of the year, respectively. > 2018 would

Re: [Mesa-dev] [PATCH v2 6/7] i965: Enable arb_transform_feedback_overflow_query.

2016-12-12 Thread Rafael Antognolli
On Fri, Dec 09, 2016 at 10:35:58PM -0800, Jordan Justen wrote: > On 2016-12-09 13:39:52, Rafael Antognolli wrote: > > This extension adds new query types which can be used to detect overflow > > of transform feedback buffers. The new query types are also accepted by > > conditional rendering

Re: [Mesa-dev] [PATCH v2 1/2] virgl: Fix a strict-aliasing violation in the encoder

2016-12-12 Thread Emil Velikov
On 8 December 2016 at 00:03, Edward O'Callaghan wrote: > On 12/08/2016 02:53 AM, Emil Velikov wrote: >> On 6 December 2016 at 22:34, Edward O'Callaghan >> wrote: >>> On 12/07/2016 12:36 AM, Emil Velikov wrote: On 6 December 2016 at

[Mesa-dev] [Bug 99055] Games hang / freeze completely

2016-12-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99055 --- Comment #5 from Etienne Bruines --- Created attachment 128433 --> https://bugs.freedesktop.org/attachment.cgi?id=128433=edit Backtrace upon crash -- You are receiving this mail because: You are the assignee for the

[Mesa-dev] [Bug 99055] Games hang / freeze completely

2016-12-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99055 --- Comment #4 from Etienne Bruines --- @Eero Tamminen: I have attached gdb. Upon crashing, one of these two errors was shown in gdb: # This is the first error Using host libthread_db library

[Mesa-dev] [Bug 99055] Games hang / freeze completely

2016-12-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99055 Eero Tamminen changed: What|Removed |Added CC|

Re: [Mesa-dev] [PATCH] treewide: s/comparitor/comparator/

2016-12-12 Thread Nicolai Hähnle
On 12.12.2016 14:34, Ilia Mirkin wrote: git grep -l comparitor | xargs sed -i 's/comparitor/comparator/g' Just happened to notice this in a patch that was sent and included one of the tokens in question. Signed-off-by: Ilia Mirkin --- I will regenerate this before

[Mesa-dev] [Bug 99055] Games hang / freeze completely

2016-12-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99055 --- Comment #3 from Eero Tamminen --- Could you attach to the game process with GDB: sudo gdb PATH PID (PID is the game process ID. PATH is path to the game binary: ls -l /proc/PID/exe ) And attach here backtrace

[Mesa-dev] [Bug 77449] Tracker bug for all bugs related to Steam titles

2016-12-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77449 Bug 77449 depends on bug 72902, which changed state. Bug 72902 Summary: [IVB/HSW/BDW] DOTA2 segfaults unless Mesa is configured with (non-default) --enable-glx-tls https://bugs.freedesktop.org/show_bug.cgi?id=72902 What|Removed

[Mesa-dev] [PATCH] treewide: s/comparitor/comparator/

2016-12-12 Thread Ilia Mirkin
git grep -l comparitor | xargs sed -i 's/comparitor/comparator/g' Just happened to notice this in a patch that was sent and included one of the tokens in question. Signed-off-by: Ilia Mirkin --- I will regenerate this before pushing in case there are changes in the tree

[Mesa-dev] [PATCH v2 5/7] i965/nir: enable lowering of texture gradient for shadow samplers

2016-12-12 Thread Iago Toral Quiroga
This gets the lowering on the Vulkan driver too, which is required for hardware that does not have the sample_l_d message (up to IvyBridge). --- src/mesa/drivers/dri/i965/brw_nir.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_nir.c

[Mesa-dev] [PATCH v2 6/7] i965: remove brw_lower_texture_gradients

2016-12-12 Thread Iago Toral Quiroga
This has been ported to NIR now so we don'tneed to keep the GLSL IR lowering any more. --- src/mesa/drivers/dri/i965/Makefile.sources | 1 - src/mesa/drivers/dri/i965/brw_context.h| 2 - src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 2 +-

[Mesa-dev] [PATCH v2 1/7] nir/lower_tex: generalize get_texture_size()

2016-12-12 Thread Iago Toral Quiroga
This was written specifically for RECT samplers. Make it more generic so we can call this from the gradient lowerings too. --- src/compiler/nir/nir_lower_tex.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/src/compiler/nir/nir_lower_tex.c

[Mesa-dev] [PATCH v2 7/7] nir/lower_tex: lower gradients on shadow cube maps if lower_txd_shadow is set

2016-12-12 Thread Iago Toral Quiroga
Even if lower_txd_cube_map isn't. Suggested by Ken to make the flag more consistent with its name. --- src/compiler/nir/nir_lower_tex.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/compiler/nir/nir_lower_tex.c b/src/compiler/nir/nir_lower_tex.c index

[Mesa-dev] [PATCH v2 4/7] nir/lower_tex: add lowering for texture gradient on shadow samplers

2016-12-12 Thread Iago Toral Quiroga
This is ported from the Intel lowering pass that we use with GLSL IR. This takes care of lowering texture gradients on shadow samplers other than cube maps. Intel hardware requires this for gen < 8. v2 (Ken): - Use the helper function to retrieve ddx/ddy - Swizzle away size components we are

[Mesa-dev] [PATCH v2 3/7] i965/nir: enable lowering of texture gradient for cube maps

2016-12-12 Thread Iago Toral Quiroga
This gets the lowering on the Vulkan driver too. Fixes Vulkan CTS cube map texture gradient tests in: dEQP-VK.glsl.texture_functions.texturegrad.* --- src/mesa/drivers/dri/i965/brw_nir.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/brw_nir.c

[Mesa-dev] [PATCH v2 2/7] nir/lower_tex: add lowering for texture gradient on cube maps

2016-12-12 Thread Iago Toral Quiroga
This is ported from the Intel lowering pass that we use with GLSL IR. The NIR pass only handles cube maps, not shadow samplers, which are also lowered for gen < 8 on Intel hardware. We will add support for that in a later patch, at which point we should be able to remove the GLSL IR lowering pass.

[Mesa-dev] [PATCH v2 0/7] i965: port texture gradient lowering to NIR

2016-12-12 Thread Iago Toral Quiroga
Changes in v2: - Add a get_ddx_ddy() helper to get correct ddx/ddy srcs (patches 2 and 4) - Properly swizzle away components of the texture size that we don't want (patches 2 and 4) - Lower gradients on shadow cube samplers if lower_txd_shadow is set even if lower_txd_cubemap isn't

[Mesa-dev] [PATCH v3] main: use new driver flag for conservative rasterization state

2016-12-12 Thread Lionel Landwerlin
Suggested by Marek. v2: Use new driver flag (Marek) v3: Fix i965 comments (Lionel) Signed-off-by: Lionel Landwerlin Cc: Ilia Mirkin Cc: Marek Olšák --- src/mesa/drivers/dri/i965/brw_context.h | 2 ++

[Mesa-dev] [PATCH v2] mesa: main: use new driver flag for conservative rasterization state

2016-12-12 Thread Lionel Landwerlin
Suggested by Marek. Signed-off-by: Lionel Landwerlin Cc: Ilia Mirkin Cc: Marek Olšák --- src/mesa/drivers/dri/i965/brw_context.h | 2 ++ src/mesa/drivers/dri/i965/brw_state_upload.c | 2 ++

Re: [Mesa-dev] [PATCH] mesa: Clamp GetUniformuiv values to be >= 0.

2016-12-12 Thread Nicolai Hähnle
On 12.12.2016 00:25, Kenneth Graunke wrote: Section 2.2.2 (Data Conversions For State Query Commands) of the OpenGL 4.5 October 24th 2016 specification says: "If a command returning unsigned integer data is called, such as GetSamplerParameterIuiv, negative values are clamped to zero." Fixes

Re: [Mesa-dev] [PATCH 02/10] i965: use nir_lower_indirect_derefs() for GLSL

2016-12-12 Thread Timothy Arceri
On Mon, 2016-12-12 at 01:20 -0800, Jason Ekstrand wrote: > On Mon, Dec 5, 2016 at 5:12 PM, Timothy Arceri ora.com> wrote: > > This moves the nir_lower_indirect_derefs() call into > > brw_preprocess_nir() so thats is called by both OpenGL and Vulkan > > and removes that

Re: [Mesa-dev] [PATCH 04/10] nir: Add a LCSAA-pass

2016-12-12 Thread Timothy Arceri
On Sat, 2016-12-10 at 14:21 +0200, Pohjolainen, Topi wrote: > On Tue, Dec 06, 2016 at 12:12:22PM +1100, Timothy Arceri wrote: > > > > From: Thomas Helland > > > > V2: Do a "depth first search" to convert to LCSSA > > > > V3: Small comment fixup > > > > V4: Rebase,

Re: [Mesa-dev] [PATCH 02/10] i965: use nir_lower_indirect_derefs() for GLSL

2016-12-12 Thread Jason Ekstrand
On Mon, Dec 5, 2016 at 5:12 PM, Timothy Arceri wrote: > This moves the nir_lower_indirect_derefs() call into > brw_preprocess_nir() so thats is called by both OpenGL and Vulkan > and removes that call to the old GLSL IR pass > lower_variable_index_to_cond_assign()