Looks great to me. Thanks!
Reviewed-by: Roland Scheidegger
Am 06.09.2018 um 06:10 schrieb Marek Olšák:
> From: Marek Olšák
>
> ---
> src/gallium/auxiliary/util/u_screen.c | 3 +++
> src/gallium/docs/source/screen.rst | 2 ++
> src/gallium/drivers/r600/r600_pipe.c | 1 +
>
On 06/09/18 07:57, Andres Gomez wrote:> Hello list,
The sixth release candidate for the Mesa 18.2.0 is now available. This
is the final planned RC.
Currently we have:
- 32 queued.
- 2 nominated (outstanding).
- and 1 rejected patch.
We have in the queue:
The GLSL compiler has
construct correct gen xml filename when we try to load hardware xml
description from a given path
v2: remove temporary variable (Francesco Ansanelli)
Signed-off-by: Sagar Ghuge
Reviewed-by: Lionel Landwerlin
---
src/intel/common/gen_decoder.c | 15 +++
1 file changed, 7
v2: Free ctx.spec if error while reading genxml (Lionel Landwerlin)
Signed-off-by: Sagar Ghuge
---
src/intel/common/gen_decoder.c | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/src/intel/common/gen_decoder.c b/src/intel/common/gen_decoder.c
index
From: Marek Olšák
---
src/gallium/auxiliary/util/u_screen.c | 3 +++
src/gallium/docs/source/screen.rst | 2 ++
src/gallium/drivers/r600/r600_pipe.c | 1 +
src/gallium/drivers/radeonsi/si_get.c | 1 +
src/gallium/include/pipe/p_defines.h | 1 +
src/mesa/state_tracker/st_extensions.c |
Yeah I wanted to add the CAP but forgot.
Marek
On Wed, Sep 5, 2018 at 7:26 PM, Roland Scheidegger wrote:
> I really think it makes no sense to hack some more around this.
>
> GLES (even 3.2) doesn't even support non-integer viewports.
> As I mentioned before, it's incorrect to report more than
Initialize gen_spec instance properly when loading hardware xml
description from specifc directory to avoid segmentation fault.
v2: correct function definition (Lionel Landwerlin)
Signed-off-by: Sagar Ghuge
Reviewed-by: Lionel Landwerlin
---
src/intel/common/gen_decoder.c | 51
From: Marek Olšák
---
src/gallium/auxiliary/util/u_helpers.c | 40 ++
src/gallium/auxiliary/util/u_helpers.h | 4 ++
src/mesa/state_tracker/st_context.c| 3 ++
src/mesa/state_tracker/st_manager.c| 9
src/util/u_thread.h| 57
From: Marek Olšák
---
src/gallium/drivers/radeon/radeon_winsys.h| 8
src/gallium/drivers/radeonsi/si_pipe.c| 8
src/gallium/winsys/amdgpu/drm/amdgpu_winsys.c | 10 ++
src/gallium/winsys/radeon/drm/radeon_drm_winsys.c | 13 +
4
From: Marek Olšák
State trackers will not use this directly, but will instead use a helper
in MakeCurrent that does the right thing.
---
.../auxiliary/driver_ddebug/dd_context.c | 10 ++
src/gallium/auxiliary/driver_noop/noop_pipe.c | 6 ++
From: Marek Olšák
---
.../auxiliary/util/u_threaded_context.c | 23 +++
.../auxiliary/util/u_threaded_context.h | 1 +
.../auxiliary/util/u_threaded_context_calls.h | 1 +
3 files changed, 25 insertions(+)
diff --git
From: Marek Olšák
---
src/gallium/auxiliary/util/u_cpu_detect.c | 18 ++
1 file changed, 10 insertions(+), 8 deletions(-)
diff --git a/src/gallium/auxiliary/util/u_cpu_detect.c
b/src/gallium/auxiliary/util/u_cpu_detect.c
index 14003aa7692..93cf58011db 100644
---
From: Marek Olšák
According to:
https://support.amd.com/TechDocs/54945_PPR_Family_17h_Models_00h-0Fh.pdf
Also Intel:
https://www.microbe.cz/docs/CPUID.pdf
---
src/gallium/auxiliary/util/u_cpu_detect.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
Hi,
When the Ryzen CPUs were launched, they didn't perform very well in
games, and it took a while before games were patched. Guess what,
Mesa drivers have suffered from the same inefficincies until now.
The AMD Zen architecture has multiple core complexes (CCX) where each
CCX has e.g. 4C/8T and
From: Marek Olšák
---
src/gallium/auxiliary/os/os_thread.h | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/src/gallium/auxiliary/os/os_thread.h
b/src/gallium/auxiliary/os/os_thread.h
index f2629c5ffe5..322888b825f 100644
--- a/src/gallium/auxiliary/os/os_thread.h
+++
From: Marek Olšák
---
src/gallium/auxiliary/util/u_cpu_detect.c | 24 +++
src/gallium/auxiliary/util/u_cpu_detect.h | 1 +
2 files changed, 25 insertions(+)
diff --git a/src/gallium/auxiliary/util/u_cpu_detect.c
b/src/gallium/auxiliary/util/u_cpu_detect.c
index
On 06/09/18 13:16, Jason Ekstrand wrote:
On September 5, 2018 19:46:06 Timothy Arceri wrote:
On 01/09/18 13:11, Jason Ekstrand wrote:
We were going out of our way to disable dual-location re-mapping in NIR
only to then do the remapping in st_glsl_to_nir.cpp. Presumably, this
was so that
This extension is required by "Wolfenstein: The Old Blood".
All the functions are just alias of the core functions so
there should be nothing more to do.
---
src/mesa/main/extensions_table.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/main/extensions_table.h
On September 5, 2018 19:46:06 Timothy Arceri wrote:
On 01/09/18 13:11, Jason Ekstrand wrote:
We were going out of our way to disable dual-location re-mapping in NIR
only to then do the remapping in st_glsl_to_nir.cpp. Presumably, this
was so that double_inputs would be correct for the core
Cc: mesa-sta...@lists.freedesktop.org
On 01/09/18 23:57, Timothy Arceri wrote:
If we have something like:
#ifdef NOT_DEFINED
#define A_MACRO(x) \
if (x)
#endif
The # on the #define is not skipped but the define itself is so
this then gets recognised as #if.
Until
https://bugs.freedesktop.org/show_bug.cgi?id=80185
Timothy Arceri changed:
What|Removed |Added
Resolution|--- |WONTFIX
Status|NEW
https://bugs.freedesktop.org/show_bug.cgi?id=107778
Timothy Arceri changed:
What|Removed |Added
Resolution|--- |DUPLICATE
Status|NEW
On 01/09/18 13:11, Jason Ekstrand wrote:
We were going out of our way to disable dual-location re-mapping in NIR
only to then do the remapping in st_glsl_to_nir.cpp. Presumably, this
was so that double_inputs would be correct for the core state tracker.
However, now that we've it to
On 06/09/18 02:35, Emil Velikov wrote:
From: Emil Velikov
Remove all the desktop GL and GLX entries from the list.
Former are pulled by the gl.h and glext.h includes at the top while the
latter are not longer needed.
not -> no
Series:
Reviewed-by: Timothy Arceri
Are you considering
https://bugs.freedesktop.org/show_bug.cgi?id=107670
Timothy Arceri changed:
What|Removed |Added
Status|NEEDINFO|RESOLVED
Resolution|---
It took me a bit to wrap my head around this, but I believe it's
correct. It also fixes things like this (which we didn't notice were
broken):
#ifdef NOT_DEFINED
#define A_MACRO(x) \
#if 0
x
#endif
#endif
Reviewed-by: Ian Romanick
On 09/01/2018 06:57 AM, Timothy Arceri wrote:
> If we
Ping!
If I don't have any other feedback by tomorrow I'll push this with the
Tested-by.
Thanks.
On 01/09/18 23:57, Timothy Arceri wrote:
If we have something like:
#ifdef NOT_DEFINED
#define A_MACRO(x) \
if (x)
#endif
The # on the #define is not skipped but the define
Hi List,
This email is to announce that barring a major bug or a critically nominated
patch, that 18.1.8 will be released this Friday, September 7th at or about 10am
PDT.
https://gitlab.freedesktop.org/mesa/mesa/commit/01967a97bf48f8254c5c834c69c7e8e06c2a5713
will be used as the revision for the
https://bugs.freedesktop.org/show_bug.cgi?id=97516
Timothy Arceri changed:
What|Removed |Added
CC||t_arc...@yahoo.com.au
--- Comment #2
I really think it makes no sense to hack some more around this.
GLES (even 3.2) doesn't even support non-integer viewports.
As I mentioned before, it's incorrect to report more than 0 bits for
viewport subpixels if a driver only supports integer viewports.
To fix this for real really 2 caps would
After this patch, is 'grep -r _mesa_bitcount' empty?
On 09/05/2018 02:55 PM, Dylan Baker wrote:
> and _mesa_bitcount_64 with util_bitcount_64. This fixes a build problem
> in nir for platforms that don't have popcount or popcountll, such as
> 32bit msvc.
>
> v2: - Fix additional uses of
After this patch, are
grep -r '"u_math.h"'
and
grep -r 'auxiliary/util/u_math.h'
empty?
On 09/05/2018 02:55 PM, Dylan Baker wrote:
> Currently we have two sets of functions for bit counts, one in gallium
> and one in core mesa. The ones in core mesa are header only in many
> cases,
Reviewed-by: Marek Olšák
Marek
On Wed, Sep 5, 2018 at 10:56 AM, Eric Anholt wrote:
> This is the minimum value for GLES2, and 0 certainly wouldn't be valid.
> Fixes dEQP-GLES2.functional.state_query.integers.subpixel_bits_getfloat
> and friends.
> ---
> src/gallium/auxiliary/util/u_screen.c |
Hello list,
The sixth release candidate for the Mesa 18.2.0 is now available. This
is the final planned RC.
Currently we have:
- 32 queued.
- 2 nominated (outstanding).
- and 1 rejected patch.
We have in the queue:
The GLSL compiler has received a couple of fixes, including one that
solves
and _mesa_bitcount_64 with util_bitcount_64. This fixes a build problem
in nir for platforms that don't have popcount or popcountll, such as
32bit msvc.
v2: - Fix additional uses of _mesa_bitcount added after this was
originally written
---
src/compiler/glsl/ir_constant_expression.cpp |
Currently we have two sets of functions for bit counts, one in gallium
and one in core mesa. The ones in core mesa are header only in many
cases, since they reduce to "#define _mesa_bitcount popcount", but they
provide a fallback implementation. This is important because 32bit msvc
doesn't have
On Tue, Sep 4, 2018 at 2:35 PM, Marek Olšák wrote:
> On Mon, Sep 3, 2018 at 6:08 AM, Michel Dänzer wrote:
>> On 2018-09-01 8:54 a.m., Marek Olšák wrote:
>>> From: Marek Olšák
>>>
>>> +41% performance in debug builds
>>> (testing piglit/drawoverhead + u_threaded_context)
>>
>> Nice, but please
Quoting Dylan Baker (2018-09-05 11:51:48)
> This is out of my series to add meson support for non-cygwin windows. Since
> that's been kinda slow to review and this seems like a good cleanup in
> general,
> I thought I'd send this out separately.
>
> Dylan Baker (2):
> move u_math to src/util
>
I was about to make the claim to someone that every field in isl_surf
is either an enum or has explicit units. Then I looked at isl_surf and
discovered this claim was wrong. We should fix that.
Cc: Chad Versace
---
src/intel/blorp/blorp_blit.c | 4 +-
On Wednesday, 2018-09-05 11:51:48 -0700, Dylan Baker wrote:
> This is out of my series to add meson support for non-cygwin windows. Since
> that's been kinda slow to review and this seems like a good cleanup in
> general,
> I thought I'd send this out separately.
Sounds reasonable, and I glanced
Quoting Eric Engestrom (2018-09-05 11:44:30)
> On Wednesday, 2018-09-05 11:38:30 -0700, Dylan Baker wrote:
> > Quoting Eric Engestrom (2018-09-05 11:19:43)
> > > On Wednesday, 2018-09-05 10:26:14 -0700, Dylan Baker wrote:
> > > > Quoting Eric Anholt (2018-09-05 10:05:15)
> > > > > Eric Engestrom
On 09/05/2018 04:30 PM, Timothy Arceri wrote:
On 05/09/18 23:36, Thomas Hellstrom wrote:
On 09/05/2018 02:36 PM, Timothy Arceri wrote:
On 05/09/18 22:09, Thomas Hellstrom wrote:
On 09/05/2018 01:45 PM, Timothy Arceri wrote:
On 16/08/17 04:31, Thomas Hellstrom wrote:
Implement
Quoting Brian Paul (2018-09-05 11:50:36)
> On 09/05/2018 11:57 AM, Dylan Baker wrote:
> > Quoting Eric Engestrom (2018-08-23 10:13:17)
> >> On Wednesday, 2018-08-22 10:04:35 -0700, Dylan Baker wrote:
> >>> Signed-off-by: Dylan Baker
> >>> Reviewed-by: Eric Anholt
> >>> ---
> >>> meson.build |
Currently we have two sets of functions for bit counts, one in gallium
and one in core mesa. The ones in core mesa are header only in many
cases, since they reduce to "#define _mesa_bitcount popcount", but they
provide a fallback implementation. This is important because 32bit msvc
doesn't have
and _mesa_bitcount_64 with util_bitcount_64. This fixes a build problem
in nir for platforms that don't have popcount or popcountll, such as
32bit msvc.
---
src/compiler/glsl/ir_constant_expression.cpp | 2 +-
src/compiler/glsl/ir_expression_operation.py | 2 +-
This is out of my series to add meson support for non-cygwin windows. Since
that's been kinda slow to review and this seems like a good cleanup in general,
I thought I'd send this out separately.
Dylan Baker (2):
move u_math to src/util
Replace uses of _mesa_bitcount with util_bitcount
On 09/05/2018 11:57 AM, Dylan Baker wrote:
Quoting Eric Engestrom (2018-08-23 10:13:17)
On Wednesday, 2018-08-22 10:04:35 -0700, Dylan Baker wrote:
Signed-off-by: Dylan Baker
Reviewed-by: Eric Anholt
---
meson.build | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git
Quoting Eric Engestrom (2018-09-05 11:16:28)
> On Thursday, 2018-08-23 10:27:17 -0700, Dylan Baker wrote:
> > Quoting Eric Engestrom (2018-08-23 10:13:17)
> > > On Wednesday, 2018-08-22 10:04:35 -0700, Dylan Baker wrote:
> > > > Signed-off-by: Dylan Baker
> > > > Reviewed-by: Eric Anholt
> > > >
On Wednesday, 2018-09-05 11:38:30 -0700, Dylan Baker wrote:
> Quoting Eric Engestrom (2018-09-05 11:19:43)
> > On Wednesday, 2018-09-05 10:26:14 -0700, Dylan Baker wrote:
> > > Quoting Eric Anholt (2018-09-05 10:05:15)
> > > > Eric Engestrom writes:
> > > >
> > > > > Anccording to
Quoting Eric Engestrom (2018-09-05 11:19:43)
> On Wednesday, 2018-09-05 10:26:14 -0700, Dylan Baker wrote:
> > Quoting Eric Anholt (2018-09-05 10:05:15)
> > > Eric Engestrom writes:
> > >
> > > > Anccording to 4fc0ebdff55419965919e "broadcom/vc4: Bump libdrm
> > > > requirement",
> > > > vc4 is
On 09/05/2018 11:06 AM, Lionel Landwerlin wrote:
> On 05/09/2018 19:02, Sagar Ghuge wrote:
>> Hi Lionel,
>>
>> Thanks for reviewing patches and comments.
>>
>> On 09/05/2018 10:29 AM, Lionel Landwerlin wrote:
>>> On 05/09/2018 18:19, Sagar Ghuge wrote:
Signed-off-by: Sagar Ghuge
---
On Wednesday, 2018-09-05 10:26:14 -0700, Dylan Baker wrote:
> Quoting Eric Anholt (2018-09-05 10:05:15)
> > Eric Engestrom writes:
> >
> > > According to 4fc0ebdff55419965919e "broadcom/vc4: Bump libdrm
> > > requirement",
> > > vc4 is a special case here as it does not use its libdrm_vc4, but
On Thursday, 2018-08-23 10:27:17 -0700, Dylan Baker wrote:
> Quoting Eric Engestrom (2018-08-23 10:13:17)
> > On Wednesday, 2018-08-22 10:04:35 -0700, Dylan Baker wrote:
> > > Signed-off-by: Dylan Baker
> > > Reviewed-by: Eric Anholt
> > > ---
> > > meson.build | 8 ++--
> > > 1 file
On 05/09/2018 19:02, Sagar Ghuge wrote:
Hi Lionel,
Thanks for reviewing patches and comments.
On 09/05/2018 10:29 AM, Lionel Landwerlin wrote:
On 05/09/2018 18:19, Sagar Ghuge wrote:
Signed-off-by: Sagar Ghuge
---
src/intel/common/gen_decoder.c | 4
1 file changed, 4 deletions(-)
Hi Lionel,
Thanks for reviewing patches and comments.
On 09/05/2018 10:29 AM, Lionel Landwerlin wrote:
> On 05/09/2018 18:19, Sagar Ghuge wrote:
>> Signed-off-by: Sagar Ghuge
>> ---
>> src/intel/common/gen_decoder.c | 4
>> 1 file changed, 4 deletions(-)
>>
>> diff --git
On 05/09/2018 13:19, Jason Ekstrand wrote:
On September 5, 2018 05:35:40 Lionel Landwerlin
wrote:
On 05/09/2018 11:24, Lionel Landwerlin wrote:
On 05/09/2018 00:04, Jason Ekstrand wrote:
The brw_vs_prog_data::double_inputs_read field comes directly from
shader_info::double_inputs which may
Quoting Eric Engestrom (2018-08-23 10:13:17)
> On Wednesday, 2018-08-22 10:04:35 -0700, Dylan Baker wrote:
> > Signed-off-by: Dylan Baker
> > Reviewed-by: Eric Anholt
> > ---
> > meson.build | 8 ++--
> > 1 file changed, 6 insertions(+), 2 deletions(-)
> >
> > diff --git a/meson.build
On Wed, Sep 5, 2018 at 1:04 PM, Elie Tournier wrote:
> This patch fixes the following Piglit test:
> spec@egl_mesa_configless_context@basic
> It also fixes few test in a virgl guest.
>
> Suggested-by: Emil Velikov
> Signed-off-by: Elie Tournier
> ---
> I cc'ed some Gallium driver people.
> Can
On 30 August 2018 at 14:52, Brian Paul wrote:
> On 08/30/2018 07:32 AM, Eric Engestrom wrote:
>>
>> On Thursday, 2018-08-30 11:12:11 +0100, Emil Velikov wrote:
>>>
>>> From: Emil Velikov
>>>
>>> The memory is allocated with the uppercase wrapper. Tear down should
>>> match that.
>>
>>
>> You're
Quoting Sergii Romantsov (2018-09-05 04:40:37)
> Seems in case of 32-bit library, usage of msse2 makes
> some stack corruption or incorrect instructions.
> Usage with mstackrealign fixes that case.
>
> v2: Fixed meson.
>
> v3: Definition of c_sse2_args moved on the top (L.Landwerlin).
>
Quoting Emil Velikov (2018-09-05 03:25:06)
> On 4 September 2018 at 22:47, Dylan Baker wrote:
> > We require a single version of libdrm for all of our libdrm
> > dependencies (core and driver), but the way this is structured can make
> > the error message less than helpful, as one driver might be
On 05/09/2018 18:19, Sagar Ghuge wrote:
Signed-off-by: Sagar Ghuge
Reviewed-by: Lionel Landwerlin
---
src/intel/tools/aubinator.c | 25 +
1 file changed, 25 insertions(+)
diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c
index
On 05/09/2018 18:19, Sagar Ghuge wrote:
construct correct gen xml filename when we try to load hardware xml
description from a given path
Signed-off-by: Sagar Ghuge
Reviewed-by: Lionel Landwerlin
---
src/intel/common/gen_decoder.c | 18 --
1 file changed, 12
Quoting Eric Engestrom (2018-09-05 02:14:47)
> On Tuesday, 2018-09-04 14:47:01 -0700, Dylan Baker wrote:
> > We require a single version of libdrm for all of our libdrm
> > dependencies (core and driver), but the way this is structured can make
> > the error message less than helpful, as one
On 05/09/2018 18:19, Sagar Ghuge wrote:
Signed-off-by: Sagar Ghuge
---
src/intel/common/gen_decoder.c | 4
1 file changed, 4 deletions(-)
diff --git a/src/intel/common/gen_decoder.c b/src/intel/common/gen_decoder.c
index dbd060d53c..c44b8f060d 100644
---
On 05/09/2018 18:19, Sagar Ghuge wrote:
Initialize gen_spec instance properly when loading hardware xml
description from specifc directory to avoid segmentation fault.
Signed-off-by: Sagar Ghuge
---
src/intel/common/gen_decoder.c | 51 +++---
1 file changed, 35
Quoting Eric Anholt (2018-09-05 10:05:15)
> Eric Engestrom writes:
>
> > According to 4fc0ebdff55419965919e "broadcom/vc4: Bump libdrm requirement",
> > vc4 is a special case here as it does not use its libdrm_vc4, but only
> > depends
> > on core libdrm.
> >
> > The way the version check was
Signed-off-by: Sagar Ghuge
---
src/intel/common/gen_decoder.c | 4
1 file changed, 4 deletions(-)
diff --git a/src/intel/common/gen_decoder.c b/src/intel/common/gen_decoder.c
index dbd060d53c..c44b8f060d 100644
--- a/src/intel/common/gen_decoder.c
+++ b/src/intel/common/gen_decoder.c
@@
construct correct gen xml filename when we try to load hardware xml
description from a given path
Signed-off-by: Sagar Ghuge
---
src/intel/common/gen_decoder.c | 18 --
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/src/intel/common/gen_decoder.c
Signed-off-by: Sagar Ghuge
---
src/intel/tools/aubinator.c | 25 +
1 file changed, 25 insertions(+)
diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c
index 55672fa073..ef0f7650b1 100644
--- a/src/intel/tools/aubinator.c
+++
I was just playing around with aubinator and I found out that it's
constructing incorrect gen xml filename when xml option is specified.
For e.g it's trying to locate Gen90.xml instead of Gen9.xml
This patch series fix memory leaks and construct correct gen xml
filename with/without xml option.
Initialize gen_spec instance properly when loading hardware xml
description from specifc directory to avoid segmentation fault.
Signed-off-by: Sagar Ghuge
---
src/intel/common/gen_decoder.c | 51 +++---
1 file changed, 35 insertions(+), 16 deletions(-)
diff --git
On Wednesday, 2018-09-05 15:09:19 +0100, Emil Velikov wrote:
> On 4 September 2018 at 20:34, Eric Engestrom wrote:
> > On Tuesday, 2018-09-04 20:33:33 +0100, Eric Engestrom wrote:
> >> On Tuesday, 2018-09-04 19:32:58 +0100, Emil Velikov wrote:
> >> > From: Emil Velikov
> >> >
> >> > Introduce
Eric Engestrom writes:
> According to 4fc0ebdff55419965919e "broadcom/vc4: Bump libdrm requirement",
> vc4 is a special case here as it does not use its libdrm_vc4, but only depends
> on core libdrm.
>
> The way the version check was added however means that the core libdrm
> dependency() needs
This patch fixes the following Piglit test:
spec@egl_mesa_configless_context@basic
It also fixes few test in a virgl guest.
Suggested-by: Emil Velikov
Signed-off-by: Elie Tournier
---
I cc'ed some Gallium driver people.
Can you check if this patch doesn't introduce any bug on your HW?
Sorry for
Emil Velikov writes:
> Hi Eric,
>
> On 24 August 2018 at 14:11, Emil Velikov wrote:
>> From: Emil Velikov
>>
>> As the comment above globalDriverAPI (in dri_util.c) says, if the loader
>> is unaware of createNewScreen2 there is a race condition.
>>
>> In which globalDriverAPI, will be set in
On Tuesday, September 4, 2018 3:30:42 AM PDT Lionel Landwerlin wrote:
> Both brw_bo_map_cpu() & brw_bo_map_wc() assert if mapping the
> underlying BO fails. Failing back to brw_bo_map_gtt() doesn't seem to
> make any sense for that reason.
>
> We also only call brw_bo_map_gtt() for tiled buffers
From: Emil Velikov
Somewhat recently Thomas Hellstrom added the respective DRI tokens
and updated the drivers. Update the documentation to match reality.
Signed-off-by: Emil Velikov
---
src/mesa/drivers/dri/common/utils.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff
From: Emil Velikov
Earlier commit updated the code to use the DRI tokens, yet forgot to
update the comment.
Signed-off-by: Emil Velikov
---
src/mesa/drivers/dri/i965/intel_screen.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/drivers/dri/i965/intel_screen.c
From: Emil Velikov
Earlier commit updated the code to use the DRI tokens, yet forgot to
update the comment.
Signed-off-by: Emil Velikov
---
src/mesa/drivers/dri/i915/intel_screen.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/drivers/dri/i915/intel_screen.c
From: Emil Velikov
Split into different sections, document each one as well as strange
cases like GL_ATI_texture_compression_3dc.
Signed-off-by: Emil Velikov
---
src/mesa/main/glheader.h | 39 +++
1 file changed, 23 insertions(+), 16 deletions(-)
diff
From: Emil Velikov
Will allow us to remove even bigger hack elsewhere. But more
importantly, we should not be using _any_ GLX tokens in DRI.
Document the gory details about the current side-effects.
Signed-off-by: Emil Velikov
---
src/mesa/drivers/dri/common/utils.c | 14 ++
1
From: Emil Velikov
Remove all the desktop GL and GLX entries from the list.
Former are pulled by the gl.h and glext.h includes at the top while the
latter are not longer needed.
Signed-off-by: Emil Velikov
---
src/mesa/main/glheader.h | 54
1 file
From: Emil Velikov
With commit c6c0f947142, back in 2006 Brian removed the
_glapi_check_multithread() call from core mesa - _mesa_make_current.
It was done to remove fairly awkward #ifdef guard which caused subtle
differences in core mesa.
Since that guard is long gone, we can drop the
From: Gert Wollny
On the host VREND_DEBUG=guestallow must be set to let the guest override
the debug flags.
Signed-off-by: Gert Wollny
---
The corresponding code for virglrenderer can be found in this MR:
https://gitlab.freedesktop.org/virgl/virglrenderer/merge_requests/39
Hi gents,
On 31 July 2018 at 11:23, Tapani Pälli wrote:
> Hi;
>
> Maybe something went wrong since patches 4,6 are missing from this series?
>
> Functionally at least propagating mutableRenderBuffer boolean from driver to
> driCreateConfigs is missing.
>
> // Tapani
>
> On 07/31/2018 08:00 AM,
This is the minimum value for GLES2, and 0 certainly wouldn't be valid.
Fixes dEQP-GLES2.functional.state_query.integers.subpixel_bits_getfloat
and friends.
---
src/gallium/auxiliary/util/u_screen.c | 4
1 file changed, 4 insertions(+)
diff --git a/src/gallium/auxiliary/util/u_screen.c
This should be fine. It was, effectively, happening in the back-end so
moving it later is fine.
Reviewed-by: Jason Ekstrand
On Wed, Sep 5, 2018 at 9:11 AM Alejandro Piñeiro
wrote:
> At this moment that lowering is using info coming from the
> UniformStorage, so for the ARB_gl_spirv codepath,
On Wed, Sep 5, 2018 at 9:11 AM Alejandro Piñeiro
wrote:
> This is the second patch needed to fix the following piglit tests:
>
>tests/spec/arb_gl_spirv/linker/uniform/multisampler.shader_test
>tests/spec/arb_gl_spirv/linker/uniform/multisampler-array.shader_test
>
> Although in this case
On 05/09/18 23:36, Thomas Hellstrom wrote:
On 09/05/2018 02:36 PM, Timothy Arceri wrote:
On 05/09/18 22:09, Thomas Hellstrom wrote:
On 09/05/2018 01:45 PM, Timothy Arceri wrote:
On 16/08/17 04:31, Thomas Hellstrom wrote:
Implement back-to-fake-front flips,
Fix EGL_BUFFER_PRESERVED path.
First two are R-b me
On September 5, 2018 09:11:18 Alejandro Piñeiro wrote:
To brw_nir_lower_gl_images, as it will be also used on the
ARB_gl_spirv codepath, that doesn't involves GLSL at all. So the
lowering is about images following the OpenGL semantics. In any case
This is the second patch needed to fix the following piglit tests:
tests/spec/arb_gl_spirv/linker/uniform/multisampler.shader_test
tests/spec/arb_gl_spirv/linker/uniform/multisampler-array.shader_test
Although in this case it doesn't affect so many borrowed tests, as
there aren't too many
---
src/mesa/drivers/dri/i965/brw_nir_uniforms.cpp | 2 --
1 file changed, 2 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_nir_uniforms.cpp
b/src/mesa/drivers/dri/i965/brw_nir_uniforms.cpp
index 0b028afdce7..34cabdc2977 100644
--- a/src/mesa/drivers/dri/i965/brw_nir_uniforms.cpp
+++
At this moment that lowering is using info coming from the
UniformStorage, so for the ARB_gl_spirv codepath, it needs to be done
after calling gl_nir_link_uniforms. As for the GLSL codepath it can
also be called later, we just move the call on both cases, to avoid
adding several shader->spirv_data
To brw_nir_lower_gl_images, as it will be also used on the
ARB_gl_spirv codepath, that doesn't involves GLSL at all. So the
lowering is about images following the OpenGL semantics. In any case
"brw_nir_lower_opengl_images" seemed too long to me, so I just used
gl. That shortening is already used
On 4 September 2018 at 20:34, Eric Engestrom wrote:
> On Tuesday, 2018-09-04 20:33:33 +0100, Eric Engestrom wrote:
>> On Tuesday, 2018-09-04 19:32:58 +0100, Emil Velikov wrote:
>> > From: Emil Velikov
>> >
>> > Introduce the API for device query and enumeration. Those at the moment
>> > produce
https://bugs.freedesktop.org/show_bug.cgi?id=107839
Danylo changed:
What|Removed |Added
CC||danylo.pilia...@gmail.com
--- Comment #2 from
In all GLSL ES versions output variables in fragment shader are allowed
to be invariant.
From Section 4.6.1 ("The Invariant Qualifier") GLSL ES 1.00 spec:
"Only the following variables may be declared as invariant:
...
- Built-in special variables output from the fragment shader."
From
https://bugs.freedesktop.org/show_bug.cgi?id=107839
--- Comment #1 from Tapani Pälli ---
But passes fine on Chrome, better check if Firefox is giving sensible input to
the driver.
--
You are receiving this mail because:
You are the assignee for the
On 09/05/2018 02:36 PM, Timothy Arceri wrote:
On 05/09/18 22:09, Thomas Hellstrom wrote:
On 09/05/2018 01:45 PM, Timothy Arceri wrote:
On 16/08/17 04:31, Thomas Hellstrom wrote:
Implement back-to-fake-front flips,
Fix EGL_BUFFER_PRESERVED path.
Implement dri3 support for
1 - 100 of 144 matches
Mail list logo
