[Mesa-dev] [PATCH 1/3] vl: Add cropping flags for H264

2019-04-11 Thread Sahu, Satyajit
From: suresh guttula This patch adds cropping flags for H264 in pipe_h264_enc_pic_control. Signed-off-by: Satyajit Sahu --- src/gallium/include/pipe/p_video_state.h | 5 + 1 file changed, 5 insertions(+) diff --git a/src/gallium/include/pipe/p_video_state.h

[Mesa-dev] [PATCH v2 2/3] radeon/vce:Add support for frame_cropping_flag of VAEncSequenceParameterBufferH264

2019-04-11 Thread Sahu, Satyajit
From: suresh guttula This patch will add support for frame_cropping when the input size is not matched with aligned size. Currently vaapi driver ignores frame cropping values provided by client. This change will update SPS nalu with proper cropping values. v2: Moving default crop setting to

[Mesa-dev] [PATCH 3/3] st/va/enc: Add support for frame_cropping_flag of VAEncSequenceParameterBufferH264

2019-04-11 Thread Sahu, Satyajit
From: suresh guttula This patch will add support for frame_cropping when the input size is not matched with aligned size. Currently vaapi driver ignores frame cropping values provided by client. This change will update SPS nalu with proper cropping values. Signed-off-by: Satyajit Sahu ---

Re: [Mesa-dev] 2019 X.Org Foundation Elections Results... and a Redo

2019-04-11 Thread Wentland, Harry
Correction on the link for the mock election. That should be https://members.x.org/ballot/3/vote, not /admin. It will also be linked from the members homepage and shown as the current ballot. Harry On 2019-04-11 8:03 p.m., Harry Wentland wrote: > To all X.Org Foundation Members: > > The 2019

[Mesa-dev] 2019 X.Org Foundation Elections Results... and a Redo

2019-04-11 Thread Wentland, Harry
To all X.Org Foundation Members: The 2019 X.Org ballot closed yesterday. There is some good and some bad news. The Good News: The vote on the bylaw changes passed with 53 for, 1 against, and 2 abstaining. The Bad News: Due to some issues with our new members website all votes for new board

Re: [Mesa-dev] [PATCH v4 1/6] glsl/linker: location aliasing requires types to have the same width

2019-04-11 Thread Andres Gomez
On Tue, 2019-04-09 at 08:40 -0700, Dylan Baker wrote: > Hi Andres, > > This doesn't apply cleanly to the 19.0 branch, and I'm not even sure where to > start resolving the conflicts. If you still want this in 19.0 can you backport > this and either create an MR against the staging/19.0 branch and

Re: [Mesa-dev] [PATCH 2/3] radeon/vce:Add support for frame_cropping_flag of VAEncSequenceParameterBufferH264

2019-04-11 Thread Liu, Leo
On 2019-04-11 6:36 a.m., Sahu, Satyajit wrote: > From: suresh guttula > > This patch will add support for frame_cropping when the input size is not > matched with aligned size. Currently vaapi driver ignores frame cropping > values provided by client. This change will update SPS nalu with proper

[Mesa-dev] [Bug 110345] Unrecoverable GPU crash with DiRT 4

2019-04-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110345 --- Comment #10 from Thomas Rohloff --- (In reply to Thomas Rohloff from comment #9) > So I'll re-run with RADV_DEBUG=nodcc,nohiz,nofastclears,zerovram to confirm > it was just luck before. And it froze, too. -- You are receiving this mail

Re: [Mesa-dev] Low interpolation precision for 8 bit textures using llvmpipe

2019-04-11 Thread Roland Scheidegger
What version of mesa are you using? The debug flags were changed a while ago (so that those perf tweaks can be disabled on release builds too), it needs to be either: GALLIVM_PERF=no_rho_approx,no_brilinear,no_quad_lod or easier GALLIVM_PERF=no_filter_hacks (which disables these 3 things above

Re: [Mesa-dev] [PATCH 1/2] draw: fix undefined shift of (1 << 31)

2019-04-11 Thread Roland Scheidegger
For the series, and the other one (undefined shifts in swrast/draw), Reviewed-by: Roland Scheidegger Am 11.04.19 um 12:32 schrieb Dave Airlie: > From: Dave Airlie > > Pointed out by a coverity scan. > --- > src/gallium/auxiliary/draw/draw_pipe_aapoint.c | 2 +- > 1 file changed, 1

Re: [Mesa-dev] [PATCH 1/3] llvmpipe: add lp_fence_timedwait() helper

2019-04-11 Thread Gustaw Smolarczyk
czw., 11 kwi 2019 o 18:06 Emil Velikov napisał(a): > > The function is analogous to lp_fence_wait() while taking at timeout > (ns) parameter, as needed for EGL fence/sync. > > Cc: Roland Scheidegger > Signed-off-by: Emil Velikov > --- > src/gallium/drivers/llvmpipe/lp_fence.c | 22

[Mesa-dev] [PATCH 1/3] llvmpipe: add lp_fence_timedwait() helper

2019-04-11 Thread Emil Velikov
The function is analogous to lp_fence_wait() while taking at timeout (ns) parameter, as needed for EGL fence/sync. Cc: Roland Scheidegger Signed-off-by: Emil Velikov --- src/gallium/drivers/llvmpipe/lp_fence.c | 22 ++ src/gallium/drivers/llvmpipe/lp_fence.h | 3 +++ 2

[Mesa-dev] [PATCH 3/3] llvmpipe: Always return some fence in flush (v2)

2019-04-11 Thread Emil Velikov
From: Tomasz Figa If there is no last fence, due to no rendering happening yet, just create a new signaled fence and return it, to match the expectations of the EGL sync fence API. Fixes random "Could not create sync fence 0x3003" assertion failures from Skia on Android, coming from the

[Mesa-dev] [PATCH 2/3] llvmpipe: correctly handle waiting in llvmpipe_fence_finish

2019-04-11 Thread Emil Velikov
Currently if the timeout differs from 0, we'll end up with infinite wait... even if the user is perfectly clear they don't want that. Use the new lp_fence_timedwait() helper guarding both waits in an !lp_fence_signalled block like the rest of llvmpipe. Cc: Roland Scheidegger Signed-off-by: Emil

Re: [Mesa-dev] [PATCH 1/1] anv/ehl: 36bits ppgtt support

2019-04-11 Thread Lionel Landwerlin
I started this MR : https://gitlab.freedesktop.org/mesa/mesa/merge_requests/637 On 11/04/2019 13:06, Lionel Landwerlin wrote: Sorry, upon rereading the code of the various drivers, it seems i965/iris handle this properly already. I have some comments below. On 11/04/2019 11:36, Lionel

Re: [Mesa-dev] Low interpolation precision for 8 bit textures using llvmpipe

2019-04-11 Thread Dominik Drees
Running with the suggested flags in the environment does not change the result for the test case I described below. The results with and without the environment variables set are pixel-wise equal. By the way, and if this of interest: For GL_NEAREST sampling the results from hardware and

Re: [Mesa-dev] [PATCH] panfrost: split asserts in pandecode

2019-04-11 Thread Alyssa Rosenzweig
Both patches are R-b: Alyssa Rosenzweig Thanks! ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 110345] Unrecoverable GPU crash with DiRT 4

2019-04-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110345 --- Comment #9 from Thomas Rohloff --- Sorry to say but all of these combinations froze: RADV_DEBUG=nodcc,nohiz RADV_DEBUG=nofastclears RADV_DEBUG=zerovram So I'll re-run with RADV_DEBUG=nodcc,nohiz,nofastclears,zerovram to confirm it was

Re: [Mesa-dev] Low interpolation precision for 8 bit textures using llvmpipe

2019-04-11 Thread Ilia Mirkin
llvmpipe takes a number of shortcuts in the interest of speed which cause inaccurate texturing. Try running with GALLIVM_DEBUG=no_rho_approx,no_brilinear,no_quad_lod and see if the issue still occurs. Cheers, -ilia On Thu, Apr 11, 2019 at 8:30 AM Dominik Drees wrote: > > Hello, everyone!

Re: [Mesa-dev] [PATCH] panfrost: split asserts in pandecode

2019-04-11 Thread Eric Engestrom
On Thursday, 2019-04-11 09:11:12 +0200, Tomeu Vizoso wrote: > Signed-off-by: Tomeu Vizoso Reviewed-by: Eric Engestrom > --- > src/gallium/drivers/panfrost/pandecode/mmap.h | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git

[Mesa-dev] Low interpolation precision for 8 bit textures using llvmpipe

2019-04-11 Thread Dominik Drees
Hello, everyone! I have a question regarding the interpolation precision of llvmpipe. Feel free to redirect me to somewhere else if this is not the right place to ask. Consider the following scenario: In a fragment shader we are sampling from a 16x16, 8 bit texture with values between 0 and 3

Re: [Mesa-dev] [PATCH 2/2] intel/compiler: fix uninit non-static variable.

2019-04-11 Thread Lionel Landwerlin
To be honest we're not initializing nir_locals either :/ Reviewed-by: Lionel Landwerlin On 11/04/2019 11:32, Dave Airlie wrote: From: Dave Airlie Pointed out by coverity. --- src/intel/compiler/brw_vec4_visitor.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [Mesa-dev] [PATCH v6 32/35] intel/compiler: validate region restrictions for mixed float mode

2019-04-11 Thread Juan A. Suarez Romero
On Wed, 2019-04-10 at 17:13 -0700, Francisco Jerez wrote: > "Juan A. Suarez Romero" writes: > > > From: Iago Toral Quiroga > > > > v2: > > - Adapted unit tests to make them consistent with the changes done > >to the validation of half-float conversions. > > > > v3 (Curro): > > - Check

Re: [Mesa-dev] [PATCH 1/1] anv/ehl: 36bits ppgtt support

2019-04-11 Thread Lionel Landwerlin
Sorry, upon rereading the code of the various drivers, it seems i965/iris handle this properly already. I have some comments below. On 11/04/2019 11:36, Lionel Landwerlin wrote: Hi James, Thanks a lot for reporting this. I think this is something we should store in the gen_device_info and

Re: [Mesa-dev] [PATCH 1/2] draw: fix undefined shift of (1 << 31)

2019-04-11 Thread Eric Engestrom
On Thursday, 2019-04-11 20:32:18 +1000, Dave Airlie wrote: > From: Dave Airlie > > Pointed out by a coverity scan. This patch is: Reviewed-by: Eric Engestrom > --- > src/gallium/auxiliary/draw/draw_pipe_aapoint.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [Mesa-dev] [PATCH 1/2] swrast: fix undefined shift of 1 << 31

2019-04-11 Thread Eric Engestrom
On Thursday, 2019-04-11 20:40:13 +1000, Dave Airlie wrote: > From: Dave Airlie > > Pointed out by coverity Series is: Reviewed-by: Eric Engestrom > --- > src/mesa/swrast/s_span.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/mesa/swrast/s_span.c

[Mesa-dev] [Bug 110337] Mesa 19.0.0(1) freeze system on Oland with amdgpu driver

2019-04-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110337 Andre Klapper changed: What|Removed |Added Severity|critical|normal Priority|high

Re: [Mesa-dev] [PATCH v6 32/35] intel/compiler: validate region restrictions for mixed float mode

2019-04-11 Thread Juan A. Suarez Romero
On Wed, 2019-04-10 at 17:13 -0700, Francisco Jerez wrote: > "Juan A. Suarez Romero" writes: > > > From: Iago Toral Quiroga > > > > v2: > > - Adapted unit tests to make them consistent with the changes done > >to the validation of half-float conversions. > > > > v3 (Curro): > > - Check

[Mesa-dev] [PATCH 1/2] swrast: fix undefined shift of 1 << 31

2019-04-11 Thread Dave Airlie
From: Dave Airlie Pointed out by coverity --- src/mesa/swrast/s_span.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/swrast/s_span.c b/src/mesa/swrast/s_span.c index f50b549a97f..184a37c99b8 100644 --- a/src/mesa/swrast/s_span.c +++ b/src/mesa/swrast/s_span.c @@

[Mesa-dev] [PATCH 2/2] llvmpipe: fix undefined shift 1 << 31.

2019-04-11 Thread Dave Airlie
From: Dave Airlie Pointed out by coverity. --- src/gallium/drivers/llvmpipe/lp_setup_point.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/llvmpipe/lp_setup_point.c b/src/gallium/drivers/llvmpipe/lp_setup_point.c index 2192789bd4c..fc1d5ef6e36 100644

[Mesa-dev] [PATCH 1/3] vl: Add cropping flags for H264

2019-04-11 Thread Sahu, Satyajit
From: suresh guttula This patch adds cropping flags for H264 in pipe_h264_enc_pic_control. Signed-off-by: Satyajit Sahu --- src/gallium/include/pipe/p_video_state.h | 5 + 1 file changed, 5 insertions(+) diff --git a/src/gallium/include/pipe/p_video_state.h

[Mesa-dev] [PATCH 2/3] radeon/vce:Add support for frame_cropping_flag of VAEncSequenceParameterBufferH264

2019-04-11 Thread Sahu, Satyajit
From: suresh guttula This patch will add support for frame_cropping when the input size is not matched with aligned size. Currently vaapi driver ignores frame cropping values provided by client. This change will update SPS nalu with proper cropping values. Signed-off-by: Satyajit Sahu ---

Re: [Mesa-dev] [PATCH 1/1] anv/ehl: 36bits ppgtt support

2019-04-11 Thread Lionel Landwerlin
Hi James, Thanks a lot for reporting this. I think this is something we should store in the gen_device_info and update with kernel ioctl when supported. This affects other drivers, not just anv. -Lionel On 10/04/2019 23:55, James Xiong wrote: From: "Xiong, James" The vma high heap's

[Mesa-dev] [PATCH 3/3] st/va/enc: Add support for frame_cropping_flag of VAEncSequenceParameterBufferH264

2019-04-11 Thread Sahu, Satyajit
From: suresh guttula This patch will add support for frame_cropping when the input size is not matched with aligned size. Currently vaapi driver ignores frame cropping values provided by client. This change will update SPS nalu with proper cropping values. Signed-off-by: Satyajit Sahu ---

[Mesa-dev] [PATCH 2/2] intel/compiler: fix uninit non-static variable.

2019-04-11 Thread Dave Airlie
From: Dave Airlie Pointed out by coverity. --- src/intel/compiler/brw_vec4_visitor.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/intel/compiler/brw_vec4_visitor.cpp b/src/intel/compiler/brw_vec4_visitor.cpp index 16ee31d730a..fa3d7fc13b7 100644 ---

[Mesa-dev] [PATCH 1/2] draw: fix undefined shift of (1 << 31)

2019-04-11 Thread Dave Airlie
From: Dave Airlie Pointed out by a coverity scan. --- src/gallium/auxiliary/draw/draw_pipe_aapoint.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/draw/draw_pipe_aapoint.c b/src/gallium/auxiliary/draw/draw_pipe_aapoint.c index

[Mesa-dev] [Bug 110337] Mesa 19.0.0(1) freeze system on Oland with amdgpu driver

2019-04-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110337 Berg changed: What|Removed |Added Priority|medium |high Severity|normal

[Mesa-dev] [Bug 110337] Mesa 19.0.0(1) freeze system on Oland with amdgpu driver

2019-04-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110337 Berg changed: What|Removed |Added Summary|Mesa 19.0.0(1) freeze |Mesa 19.0.0(1) freeze |system

[Mesa-dev] [Bug 110337] Mesa 19.0.0(1) freeze system on Oland with amdgpu

2019-04-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110337 Berg changed: What|Removed |Added Summary|Mesa 19.0.0(1) |Mesa 19.0.0(1) freeze |

[Mesa-dev] [Bug 110345] Unrecoverable GPU crash with DiRT 4

2019-04-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110345 --- Comment #8 from Samuel Pitoiset --- Very nice, thanks for your time! -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___ mesa-dev

Re: [Mesa-dev] [PATCH 1/2] radeonsi: set AC_FUNC_ATTR_READNONE for image opcodes where it was missing

2019-04-11 Thread Samuel Pitoiset
Reviewed-by: Samuel Pitoiset On 4/11/19 3:30 AM, Marek Olšák wrote: From: Marek Olšák --- src/amd/common/ac_llvm_build.c| 1 + src/gallium/drivers/radeonsi/si_shader_tgsi_mem.c | 4 2 files changed, 5 insertions(+) diff --git a/src/amd/common/ac_llvm_build.c

Re: [Mesa-dev] [PATCH 2/2] ac: use the common helper ac_apply_fmask_to_sample

2019-04-11 Thread Samuel Pitoiset
On 4/11/19 3:30 AM, Marek Olšák wrote: From: Marek Olšák --- src/amd/common/ac_nir_to_llvm.c | 70 +++-- 1 file changed, 5 insertions(+), 65 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index

Re: [Mesa-dev] [PATCH] nir: initialise some variables in opt_if_loop_last_continue()

2019-04-11 Thread Tapani Pälli
Reviewed-by: Tapani Pälli On 4/11/19 2:38 AM, Timothy Arceri wrote: Fixes a couple of Coverity warnings CID 1444626. Fixes: e30804c6024f ("nir/radv: remove restrictions on opt_if_loop_last_continue()") --- src/compiler/nir/nir_opt_if.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[Mesa-dev] [PATCH] panfrost: split asserts in pandecode

2019-04-11 Thread Tomeu Vizoso
Signed-off-by: Tomeu Vizoso --- src/gallium/drivers/panfrost/pandecode/mmap.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/panfrost/pandecode/mmap.h b/src/gallium/drivers/panfrost/pandecode/mmap.h index 1a208336e814..e9acae877f7f 100644 ---

[Mesa-dev] [PATCH] panfrost: Guard against reading past end of buffer

2019-04-11 Thread Tomeu Vizoso
Signed-off-by: Tomeu Vizoso --- src/gallium/drivers/panfrost/pan_swizzle.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/drivers/panfrost/pan_swizzle.c b/src/gallium/drivers/panfrost/pan_swizzle.c index 291bd1f88aea..52a907ddd55d 100644 ---

Re: [Mesa-dev] [PATCH] mesa: don't overwrite existing shader files with MESA_SHADER_CAPTURE_PATH

2019-04-11 Thread Tapani Pälli
On 4/11/19 3:32 AM, Marek Olšák wrote: From: Marek Olšák --- src/mesa/main/shaderapi.c | 20 +--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c index 01342c04e8f..6b73e6c7e7a 100644 ---

[Mesa-dev] [PATCH v3] st/nine: skip position checks in SetCursorPosition()

2019-04-11 Thread Andre Heider
For HW cursors, "cursor.pos" doesn't hold the current position of the pointer, just the position of the last call to SetCursorPosition(). Skip the check against stale values and bump the d3dadapter9 drm version to expose this change of behaviour. Signed-off-by: Andre Heider --- V3: improve

[Mesa-dev] [Bug 110402] checking validations

2019-04-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110402 Bug ID: 110402 Summary: checking validations Product: Mesa Version: 5.0.2 Hardware: PowerPC URL: http://219.91.142.54:1515/GreyOrder OS: Windows (All)