[Mesa-dev] [PATCH] configure.ac: check for libexpat when no pkg-config is available

Previously, when no pkg-config was available for libexpat we would just add the needed linking flags without any extra check. Now, we check that the library and the headers are also installed in the building environment. --- configure.ac | 15 +++ 1 file changed, 7 insertions(+), 8

[Mesa-dev] [PATCH] glsl: Update and fix typos in README.

--- src/glsl/README | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/glsl/README b/src/glsl/README index 0a0afcc..2f93f12 100644 --- a/src/glsl/README +++ b/src/glsl/README @@ -8,7 +8,7 @@ passed straight through. See glcpp/* 2) lex and yacc-based

[Mesa-dev] [PATCH] glsl: Standardize names and fix typos

--- src/glsl/linker.cpp | 4 ++-- src/glsl/lower_offset_array.cpp | 10 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cpp index 47a722d..c3f435c 100644 --- a/src/glsl/linker.cpp +++ b/src/glsl/linker.cpp @@ -1679,7

[Mesa-dev] [PATCH] glsl_compiler: Add binding hash tables to avoid SIGSEVs on linking stage

When using the stand alone compiler, if we try to link a shader with vertex attributes it will segfault on linking as the binding hash tables are not included in the shader program. Obviously, we cannot make the linking stage succeed without the bound attributes but we can prevent the crash and

Re: [Mesa-dev] [PATCH] glsl_compiler: Add binding hash tables to avoid SIGSEVs on linking stage

On Mon, 2014-11-17 at 09:25 -0700, Brian Paul wrote: Please split up this patch into: 1. gallium comment fixes 2. linker string fixes 3. hash table code changes Sure. I thought it was not worth given the small changes but I suppose it is always better to have different topics in different

[Mesa-dev] [PATCH 3/3] glsl_compiler: Add binding hash tables to avoid SIGSEVs on linking stage

When using the stand alone compiler, if we try to link a shader with vertex attributes it will segfault on linking as the binding hash tables are not included in the shader program. Obviously, we cannot make the linking stage succeed without the bound attributes but we can prevent the crash and

[Mesa-dev] [PATCH] i965: negative and abs modifiers in derivative operators

This patch is intended to fix: https://bugs.freedesktop.org/show_bug.cgi?id=82991 Which is now also exposed through the piglit patch sent at: http://lists.freedesktop.org/archives/piglit/2014-December/013648.html Andres Gomez (1): i965/brw_reg: struct constructor now needs explicit negate

[Mesa-dev] [PATCH] i965/brw_reg: struct constructor now needs explicit negate and abs values.

We were asuming, when constructing a new brw_reg struct, that the negate and abs register modifiers would not be present by default in the new register. Now, we force explicitly setting these values when constructing a new register. This will avoid problems like forgetting to properly set them

Re: [Mesa-dev] [PATCH] i965/brw_reg: struct constructor now needs explicit negate and abs values.

On Mon, 2014-12-15 at 11:24 -0800, Matt Turner wrote: On Mon, Dec 15, 2014 at 11:03 AM, Matt Turner matts...@gmail.com wrote: Reviewed-by: Matt Turner matts...@gmail.com Cc: 10.4 10.3 mesa-sta...@lists.freedesktop.org Oh, I suppose I need to commit this and the piglit test? Just confirm

[Mesa-dev] [PATCH] glsl: atomic counters are different than their uniforms

-CTS.arrays_of_arrays_gl.AtomicDeclaration Signed-off-by: Andres Gomez <ago...@igalia.com> --- src/compiler/glsl/link_atomics.cpp | 83 -- 1 file changed, 44 insertions(+), 39 deletions(-) diff --git a/src/compiler/glsl/link_atomics.cpp b/src/compile

[Mesa-dev] [PATCH] glsl/ast: Implicit conversion from double to float is not allowed

Also, renamed get_conversion_operation to avoid future misunderstandings. --- src/compiler/glsl/ast_to_hir.cpp | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/compiler/glsl/ast_to_hir.cpp b/src/compiler/glsl/ast_to_hir.cpp index 75abef6..db5ec9a 100644 ---

Re: [Mesa-dev] About border values in fp64 conversion tests

On Tue, 2016-03-15 at 12:38 -0400, Ilia Mirkin wrote: > Not really an answer to your question, but you may be interested in > this model of the NVIDIA Tesla FPU that mwk RE'd, including fp64 > (which was available on the G200 only in that series). I have no > reason to believe that Fermi+ are

Re: [Mesa-dev] About the usage of the "flat" interpolation qualifier with input (unsigned) integers and doubles in fragment shaders

ent shader for (unsigned) integers and doubles. * Open a bug in Khronos specs bugzilla about the ambiguity of this. Br. On Fri, 2016-03-04 at 15:43 +0200, Andres Gomez wrote: > Hi, > > as complementary work to the one done to "Add FP64 support to the i965 > s

[Mesa-dev] About border values in fp64 conversion tests

Hi, as complementary work to the one done to "Add FP64 support to the i965 shader backends" at: https://bugs.freedesktop.org/show_bug.cgi?id=92760 I've been working to add piglit tests that would check the new features added by this addition. One of the topics we have been creating tests for is

Re: [Mesa-dev] About tests for extensions that are later integrated in the core specs

On Fri, 2016-03-04 at 11:49 -0800, Matt Turner wrote: ... > So to answer your main question, I would generate tests for both > glsl-4.00 and arb_gpu_shader_fp64, but only manually write tests for > arb_gpu_shader_fp64. Thanks for the early reply, Matt! We will do as you suggest. -- Br, Andres

[Mesa-dev] About tests for extensions that are later integrated in the core specs

Hi, as complementary work to the one done to "Add FP64 support to the i965 shader backends" at: https://bugs.freedesktop.org/show_bug.cgi?id=92760 We've been working to add piglit tests that would check the new features added by this addition. Because of this, we have created several generators.

[Mesa-dev] About the usage of the "flat" interpolation qualifier with input (unsigned) integers and doubles in fragment shaders

Hi, as complementary work to the one done to "Add FP64 support to the i965 shader backends" at: https://bugs.freedesktop.org/show_bug.cgi?id=92760 I've been working to add piglit tests that would check the new features added by this addition. Checking the specification of the extension, when

Re: [Mesa-dev] About the usage of the "flat" interpolation qualifier with input (unsigned) integers and doubles in fragment shaders

I tried to be careful, and still I introduced a mistake ... On Fri, 2016-03-04 at 15:43 +0200, Andres Gomez wrote: ... > The situation with the glslangValidator is (it doesn't support doubles): > * When using a non-flat integer as a fragment input in the form of >

Re: [Mesa-dev] About border values in fp64 conversion tests

Hi, I haven't had any other feedback than Ilia's (thanks Ilia!) so my doubts still stand. I'd welcome more info regarding this topic. Thanks! Br. On Tue, 2016-03-15 at 17:46 +0200, Andres Gomez wrote: > Hi, > > as complementary work to the one done to "Add FP64 support to the &

[Mesa-dev] [PATCH] glsl: Checks for interpolation into its own function.

-by: Andres Gomez <ago...@igalia.com> --- src/compiler/glsl/ast_to_hir.cpp | 316 +-- 1 file changed, 171 insertions(+), 145 deletions(-) diff --git a/src/compiler/glsl/ast_to_hir.cpp b/src/compiler/glsl/ast_to_hir.cpp index 7c9be81..e4ebc6b 100644 ---

Re: [Mesa-dev] About the usage of the "flat" interpolation qualifier with input (unsigned) integers and doubles in fragment shaders

Fri, Mar 4, 2016 at 5:43 AM, Andres Gomez <ago...@igalia.com > > <mailto:ago...@igalia.com>> wrote: > > > > Hi, > > > > as complementary work to the one done to "Add FP64 support to > > the i965 > > shader backends" at

Re: [Mesa-dev] [PATCH] glsl: Checks for interpolation into its own function.

On Tue, 2016-04-26 at 12:16 +0200, Samuel Iglesias Gonsálvez wrote: > On 04/04/16 18:50, Andres Gomez wrote: > > > > This generalizes the validation also to be done for variables > > inside > > interface blocks, which, for some cases, was missing. > > > >

[Mesa-dev] [PATCH] configure: added xcb to dri3 modules to pkg-conf

This fixes a recent linking error in libvulkan_common Signed-off-by: Andres Gomez <ago...@igalia.com> --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 6eee2bc..de62e8b 100644 --- a/configure.ac +++ b/configure.ac @@ -

[Mesa-dev] About tolerance calculation on specific (builtin) functions

Hi, as part of the work done to "Add FP64 support to the i965 shader backends" at: https://bugs.freedesktop.org/show_bug.cgi?id=92760 I've been working to add piglit tests that would check the new features added by this addition. Due to this, I've been checking and making modifications into the

Re: [Mesa-dev] [PATCH] glsl: Checks for interpolation into its own function.

Hi, I would really appreciate if you could find some time to review this patch. Thanks! On Mon, 2016-04-04 at 19:50 +0300, Andres Gomez wrote: > This generalizes the validation also to be done for variables inside > interface blocks, which, for some cases, was missing. > > For

Re: [Mesa-dev] About border values in fp64 conversion tests

tination type range, and NaN gets > converted to 0. Hence why implementations tend to do this. But still > undefined in glsl (which, of course, doesn't mean someone might not > rely > on d3d10 behaviour there...). > > Roland > > > Am 05.04.2016 um 09:33 schrieb Andres Gomez:

Re: [Mesa-dev] [PATCH] glsl: Checks for interpolation into its own function.

Hi, this patch is still unreviewed. I'd welcome some help to get this into mesa :) -- Br, Andres signature.asc Description: This is a digitally signed message part ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH] glsl: Checks for interpolation into its own function.

Hi, On Tue, 2016-04-19 at 08:53 +1000, Timothy Arceri wrote: > On Mon, 2016-04-18 at 19:44 +0300, Andres Gomez wrote: > > > > Hi, > > > > I would really appreciate if you could find some time to review > > this > > patch. > Is there a patch somewhere

Re: [Mesa-dev] About tolerance calculation on specific (builtin) functions

On Wed, 2016-05-04 at 13:48 -0400, Ilia Mirkin wrote: > On Wed, May 4, 2016 at 1:41 PM, Connor Abbott <cwabbo...@gmail.com> > wrote: > > > > On Wed, May 4, 2016 at 1:05 PM, Andres Gomez <ago...@igalia.com> > > wrote: > > > > > > Hi, >

Re: [Mesa-dev] [PATCH] glsl: subroutine types cannot be compared

On Fri, 2016-07-22 at 06:07 +1000, Dave Airlie wrote: > > > > On Mon, 2016-07-18 at 16:39 +0300, Andres Gomez wrote: > > > subroutine variables are to be used just in the way functions are > > > called. Although the spec doesn't say it explicitely, this me

Re: [Mesa-dev] [PATCH 1/2] glsl/types: disallow implicit conversions before GLSL 1.20

On Mon, 2016-08-01 at 09:35 +1000, Timothy Arceri wrote: > On Sun, 2016-07-31 at 18:43 +0300, Andres Gomez wrote: > > Implicit conversions were added in the GLSL 1.20 spec version. > > Does this help fix the CTS test or are you just adding it because you > noticed it? I

Re: [Mesa-dev] [PATCH 2/2] glsl: struct constructors/initializers only allow implicit conversions

On Mon, 2016-08-01 at 10:01 +1000, Timothy Arceri wrote: > On Sun, 2016-07-31 at 18:43 +0300, Andres Gomez wrote: [snip] > diff --git a/src/compiler/glsl/ast_function.cpp > > b/src/compiler/glsl/ast_function.cpp > > index 9dcec50..9b09cb6 100644 > > --- a/src/compil

Re: [Mesa-dev] [PATCH 2/2] glsl: struct constructors/initializers only allow implicit conversions

On Mon, 2016-08-01 at 12:05 +0300, Andres Gomez wrote: [snip] > it allows conversions from a vector or a bigger dimension to a vector of ---^^ > or a smaller dimension. That was making the CTS test fail. of^^ (Wake up, Andrés!!!) --  Br,

[Mesa-dev] [PATCH 0/2] struct constructors/initializers only allow implicit conversions

When an argument for a structure constructor or initializer doesn't match the expected type, only Section 4.1.10 “Implicit Conversions” are allowed to try to match that expected type. Fixes GL44-CTS.shading_language_420pack.initializer_list_negative Andres Gomez (2): glsl/types: disallow

[Mesa-dev] [PATCH 2/2] glsl: struct constructors/initializers only allow implicit conversions

0 "Implicit Conversions". In the latter case, an implicit conversion will be done on the initializer before the assignment is done." Fixes GL44-CTS.shading_language_420pack.initializer_list_negative Signed-off-by: Andres Gomez <ago...@igalia.com> --- src

[Mesa-dev] [PATCH 1/2] glsl/types: disallow implicit conversions before GLSL 1.20

Implicit conversions were added in the GLSL 1.20 spec version. Signed-off-by: Andres Gomez <ago...@igalia.com> --- src/compiler/glsl_types.cpp | 4 1 file changed, 4 insertions(+) diff --git a/src/compiler/glsl_types.cpp b/src/compiler/glsl_types.cpp index 8a06695..24aec25 100644 ---

[Mesa-dev] [PATCH] ast: Updated AST_NUM_OPERATORS for coherence with ast_operators

AST_NUM_OPERATORS stores the dimension of the ast_operators enumeration but was not updated after its last modification. This doesn't add any real modification for any code paths but it makes sense for coherence. Signed-off-by: Andres Gomez <ago...@igalia.com> --- src/compiler/glsl

Re: [Mesa-dev] [PATCH] ast: Updated AST_NUM_OPERATORS for coherence with ast_operators

On Mon, 2016-08-01 at 14:02 +0100, Eric Engestrom wrote: > On Sun, Jul 31, 2016 at 07:07:34PM +0300, Andres Gomez wrote: [snip] > > diff --git a/src/compiler/glsl/ast.h b/src/compiler/glsl/ast.h > > index 157895d..89f531c 100644 > > --- a/src/compiler/glsl/ast.h > > ++

[Mesa-dev] [PATCH] dir-locals.el: show-trailing-whitespace and whitespace support

Signed-off-by: Andres Gomez <ago...@igalia.com> --- .dir-locals.el | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/.dir-locals.el b/.dir-locals.el index 4b53931..9c89a63 100644 --- a/.dir-locals.el +++ b/.dir-locals.el @@ -1,4 +1,5 @@ -((prog-mode +((nil .

Re: [Mesa-dev] [PATCH] ast: Updated AST_NUM_OPERATORS for coherence with ast_operators

On Tue, 2016-08-02 at 17:04 +0100, Eric Engestrom wrote: > On Tue, Aug 02, 2016 at 12:20:54PM +0300, Andres Gomez wrote: [snip] > > I'm not sure I'm understanding what you mean. > > > > If you mean to remove the #define and add the value as and additional > > element

Re: [Mesa-dev] [PATCH] [rfc] glsl: allow invariant on fragment shader outputs.

Hi, On Mon, 2016-05-23 at 14:18 +1000, Dave Airlie wrote: > From: Dave Airlie > > A CTS test manages to generate this: > GL45-CTS.shading_language_420pack.qualifier_order > > I cannot find definitive evidence in the spec that it isn't > allowed. The specs mentions some

Re: [Mesa-dev] [PATCH 1/5] mesa/subroutines: start adding per-context subroutine index support

On Tue, 2016-06-07 at 16:23 +0200, Iago Toral wrote: > On Tue, 2016-06-07 at 15:25 +1000, Dave Airlie wrote: > > From: Dave Airlie > > > > One piece of ARB_shader_subroutine I ignored was the fact that it > > needs to store the subroutine index data per context and not per >

Re: [Mesa-dev] shader subroutine per-context uniform support

FTR, I rebased this series on top of current master (minimal changes) and run a full CTS and piglit run with the i965 [gen 8]. The failing CTS now passes and I have not observed any regression nor in CTS neither in piglit. On Tue, 2016-06-07 at 15:25 +1000, Dave Airlie wrote: > So when I

Re: [Mesa-dev] [PATCH 2/5] mesa: add api to write subroutine indicies to the program storage.

ct gl_context *ctx, > + gl_shader_stage stage); > extern void GLAPIENTRY > _mesa_AttachObjectARB(GLhandleARB, GLhandleARB); > Other than the small nitpick, this is: Reviewed-by: Andres Gomez <ago...@igalia.com> -- Br, Andres ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 4/5] st/mesa: use the new subroutine index upload API.

gl_context *ctx, GLint x, GLint y, > * into the constant buffer, we need to update them > */ >st_upload_constants(st, st->fp->Base.Base.Parameters, > - PIPE_SHADER_FRAGMENT); > + MESA_SHADER_FRAGMENT); >

Re: [Mesa-dev] [PATCH 5/5] mesa/subroutines: drop the old subroutine index uploads.

gt; } > > > @@ -2844,8 +2840,6 @@ _mesa_shader_init_subroutine_defaults(struct gl_context > *ctx, > continue; >ctx->SubroutineIndex[sh->Stage].IndexPtr[i] = > find_compat_subroutine(sh, uni->type); > } > - > - _mesa_shader_write_subroutine_index

Re: [Mesa-dev] [PATCH 3/5] i965: use new subroutine index uploader.

erapi.h" > > static void > gen7_upload_tes_push_constants(struct brw_context *brw) > @@ -37,6 +38,7 @@ gen7_upload_tes_push_constants(struct brw_context *brw) > if (tep) { >/* BRW_NEW_TES_PROG_DATA */ >const struct brw_stage_prog_data *prog_data

Re: [Mesa-dev] [PATCH 1/5] mesa/subroutines: start adding per-context subroutine index support

above). > + ctx->SubroutineIndex[sh->Stage].NumIndex = > sh->NumSubroutineUniformRemapTable; > + } > + > + for (i = 0; i < sh->NumSubroutineUniformRemapTable; i++) { > + struct gl_uniform_storage *uni = sh->SubroutineUniformRemapTable[i];

Re: [Mesa-dev] [PATCH 2/2] glsl: struct constructors/initializers only allow implicit conversions

On Mon, 2016-08-01 at 12:05 +0300, Andres Gomez wrote: > On Mon, 2016-08-01 at 10:01 +1000, Timothy Arceri wrote: > > On Sun, 2016-07-31 at 18:43 +0300, Andres Gomez wrote: > > [snip] > > > diff --git a/src/compiler/glsl/ast_function.cpp > > > b/src/compiler/

[Mesa-dev] [PATCH 5/5] glsl: fix indentation, comments and line lengths in ast_function.cpp

Signed-off-by: Andres Gomez <ago...@igalia.com> --- src/compiler/glsl/ast_function.cpp | 880 +++-- 1 file changed, 460 insertions(+), 420 deletions(-) diff --git a/src/compiler/glsl/ast_function.cpp b/src/compiler/glsl/ast_function.cpp index 52cbf1f..8

[Mesa-dev] [PATCH 3/5] glsl: struct constructors/initializers only allow implicit conversions

0 "Implicit Conversions". In the latter case, an implicit conversion will be done on the initializer before the assignment is done." Fixes GL44-CTS.shading_language_420pack.initializer_list_negative Signed-off-by: Andres Gomez <ago...@igalia.com> --- src

[Mesa-dev] [PATCH v2 0/5] struct constructors/initializers only allow implicit conversions

When an argument for a structure constructor or initializer doesn't match the expected type, only Section 4.1.10 “Implicit Conversions” are allowed to try to match that expected type. Fixes GL44-CTS.shading_language_420pack.initializer_list_negative Andres Gomez (5): glsl/types: disallow

[Mesa-dev] [PATCH 2/5] glsl: Refactor implicit conversion into its own helper

Signed-off-by: Andres Gomez <ago...@igalia.com> --- src/compiler/glsl/ast_function.cpp | 79 +++--- 1 file changed, 47 insertions(+), 32 deletions(-) diff --git a/src/compiler/glsl/ast_function.cpp b/src/compiler/glsl/ast_function.cpp index 9dcec50..5

[Mesa-dev] [PATCH 4/5] glsl: apply_implicit_conversion is static again

Signed-off-by: Andres Gomez <ago...@igalia.com> --- src/compiler/glsl/ast_function.cpp | 4 src/compiler/glsl/ast_to_hir.cpp | 2 +- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/src/compiler/glsl/ast_function.cpp b/src/compiler/glsl/ast_function.cpp index ccd070f..5

[Mesa-dev] [PATCH 1/5] glsl/types: disallow implicit conversions before GLSL 1.20

Implicit conversions were added in the GLSL 1.20 spec version. Signed-off-by: Andres Gomez <ago...@igalia.com> --- src/compiler/glsl_types.cpp | 4 1 file changed, 4 insertions(+) diff --git a/src/compiler/glsl_types.cpp b/src/compiler/glsl_types.cpp index 8a06695..24aec25 100644 ---

[Mesa-dev] [PATCH] glsl: subroutine types cannot be compared

h that variable will call that particular function." Fixes GL44-CTS.shader_subroutine.subroutines_cannot_be_assigned_float_int_values_or_be_compared Signed-off-by: Andres Gomez <ago...@igalia.com> --- src/compiler/glsl/ast_to_hir.cpp | 4 1 file changed, 4 insertions(+) diff

Re: [Mesa-dev] [PATCH] glsl: subroutine types cannot be compared

Dropping this patch. It seems I overlooked: https://lists.freedesktop.org/archives/mesa-dev/2016-June/119616.html On Mon, 2016-07-18 at 16:39 +0300, Andres Gomez wrote: > subroutine variables are to be used just in the way functions are > called. Although the spec doesn't say it expli

Re: [Mesa-dev] [PATCH] glsl/ast: don't allow subroutine uniform comparisons

Hi, Just dropped: https://lists.freedesktop.org/archives/mesa-dev/2016-July/123485.html I didn't realize there was already this thread open. On Tue, 2016-06-07 at 09:59 -0700, Ian Romanick wrote: > On 06/06/2016 10:20 PM, Dave Airlie wrote: > > From: Dave Airlie > > > >

Re: [Mesa-dev] [PATCH] glsl/ast: don't allow subroutine uniform comparisons

we use type->contains_subroutine() ? That way we would be having into account subroutine arrays too. Other than the open discussion about whether this is allowed by the specs or not, this is: Reviewed-by: Andres Gomez <ago...@igalia.com> -- Br, Andres ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] glsl/ast: don't allow subroutine uniform comparisons

On Tue, 2016-07-19 at 13:45 -0700, Ian Romanick wrote: > On 07/19/2016 06:54 AM, Andres Gomez wrote: ... > > So, what would be the conclusion? Do we allow subroutine variables > > comparison? > > There is no conclusion yet. I opened a Khronos gitlab tracker (right > afte

[Mesa-dev] [PATCH 2/5] glsl: Refactor implicit conversion into its own helper

v2: Refactor also the conversion to constant and replacement code (Timothy). Signed-off-by: Andres Gomez <ago...@igalia.com> --- src/compiler/glsl/ast_function.cpp | 166 +++-- 1 file changed, 86 insertions(+), 80 deletions(-) diff --git a/src/compile

[Mesa-dev] [PATCH 3/5] glsl: struct constructors/initializers only allow implicit conversions

ode (Timothy). Fixes GL44-CTS.shading_language_420pack.initializer_list_negative Signed-off-by: Andres Gomez <ago...@igalia.com> --- src/compiler/glsl/ast_function.cpp | 104 - 1 file changed, 55 insertions(+), 49 deletions(-) diff --git a/src/compiler/glsl/ast_function.cpp

Re: [Mesa-dev] [PATCH 3/5] glsl: struct constructors/initializers only allow implicit conversions

On Fri, 2016-08-05 at 08:35 +1000, Timothy Arceri wrote: > Thanks for you patience with this series :)  The parameter check above The other way around, thanks to you for reviewing! ☺ > is a nice cleanup too thanks. Patches 2 and 3 are: > > Reviewed-by: Timothy Arceri

Re: [Mesa-dev] [PATCH 1/5] glsl/types: disallow implicit conversions before GLSL 1.20

On Thu, 2016-08-04 at 08:53 +1000, Timothy Arceri wrote: > On Wed, 2016-08-03 at 23:51 +0300, Andres Gomez wrote: > > Implicit conversions were added in the GLSL 1.20 spec version. > > > > Signed-off-by: Andres Gomez <ago...@igalia.com> > > --- > >  src/

[Mesa-dev] [PATCH 1/5] glsl/types: disallow implicit conversions before GLSL 1.20

Implicit conversions were added in the GLSL 1.20 spec version. v2 (Timothy): Join the checks for GLSL 1.10 and ESSL. Signed-off-by: Andres Gomez <ago...@igalia.com> --- src/compiler/glsl_types.cpp | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/co

Re: [Mesa-dev] [PATCH] glsl: atomic counters are different than their uniforms

On Thu, 2016-06-30 at 00:29 -0700, Ian Romanick wrote: > On 06/29/2016 05:55 PM, Timothy Arceri wrote: ... > > > > So, I don't think there is a clear part of the spec to quote here, > and > I looked. :)  While the spec doesn't come right out and say it, I > think > we can infer that this

Re: [Mesa-dev] [PATCH] glsl: atomic counters are different than their uniforms

On Thu, 2016-06-30 at 10:55 +1000, Timothy Arceri wrote: > On Mon, 2016-06-27 at 18:28 +0300, Andres Gomez wrote: > > The linker deals with atomic counters in terms of uniforms. This is > > OK > > but when we want to know the number of used atomic counters since a >

Re: [Mesa-dev] [PATCH] Revert "i965: get PrimitiveMode from the program rather than the shader struct"

On Thu, 2016-06-30 at 10:21 +1000, Timothy Arceri wrote: > On Wed, 2016-06-29 at 17:23 +0300, Andres Gomez wrote: > > On Thu, 2016-06-30 at 00:09 +1000, Timothy Arceri wrote: > > > > > > On 29 June 2016 11:29:17 pm AEST, Andres Gomez <ago...@igalia.com > > &

Re: [Mesa-dev] [PATCH] glsl: atomic counters are different than their uniforms

On Wed, 2016-06-29 at 18:37 -0700, Ian Romanick wrote: > On 06/27/2016 08:28 AM, Andres Gomez wrote: > > The linker deals with atomic counters in terms of uniforms. This is > > OK > > but when we want to know the number of used atomic counters since a > > 2 > &g

[Mesa-dev] [PATCH] Revert "i965: get PrimitiveMode from the program rather than the shader struct"

This reverts commit 644e015f0b9236e955d679cac4bcc7a1523fc475. PrimitiveMode from the program doesn't hold the proper value when reaching this code. We rather take it from the linked shader. Signed-off-by: Andres Gomez <ago...@igalia.com> --- src/mesa/drivers/dri/i965/brw_tcs.c | 5 +++--

Re: [Mesa-dev] [PATCH] Revert "i965: get PrimitiveMode from the program rather than the shader struct"

On Thu, 2016-06-30 at 00:09 +1000, Timothy Arceri wrote: > > On 29 June 2016 11:29:17 pm AEST, Andres Gomez <ago...@igalia.com> > wrote: > > This reverts commit 644e015f0b9236e955d679cac4bcc7a1523fc475. > > > > PrimitiveMode from the program doesn't hold t

Re: [Mesa-dev] [PATCH 2/5] configure.ac: add swr to the gallium drivers list.

LGTM Reviewed-by: Andres Gomez <ago...@igalia.com> On Wed, 2017-02-01 at 22:30 +, Emil Velikov wrote: > From: Emil Velikov <emil.veli...@collabora.com> > > Signed-off-by: Emil Velikov <emil.veli...@collabora.com> > --- > configure.ac | 2 +- > 1 file

Re: [Mesa-dev] [PATCH 1/5] configure.ac: list all the dri-drivers in the help string

^ Otherwise, LGTM. Reviewed-by: Andres Gomez <ago...@igalia.com> > available. > > Signed-off-by: Emil Velikov <emil.veli...@collabora.com> > --- > configure.ac | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure.ac b/configure.ac >

Re: [Mesa-dev] [PATCH 4/5] travis: add nearly all gallium drivers to the list

LGTM Reviewed-by: Andres Gomez <ago...@igalia.com> On Wed, 2017-02-01 at 22:30 +, Emil Velikov wrote: > From: Emil Velikov <emil.veli...@collabora.com> > > Note: we need the explicit --enable-freedreno for libdrm since the > latter is 'smart' and disables it if bu

Re: [Mesa-dev] [PATCH 3/5] travis: correct libdrm required regex to also track libdrm itself

LGTM Reviewed-by: Andres Gomez <ago...@igalia.com> On Wed, 2017-02-01 at 22:30 +, Emil Velikov wrote: > From: Emil Velikov <emil.veli...@collabora.com> > > The current regex was tracking only the libdrm_foo packages, while with > recent changed we bumped only (a

[Mesa-dev] [PATCH] glsl: binding qualifier must match with opaque-uniforms only

Fixes GL45-CTS.enhanced_layouts.ssb_layout_qualifier_conflict Signed-off-by: Andres Gomez <ago...@igalia.com> --- src/compiler/glsl/linker.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/glsl/linker.cpp b/src/compiler/glsl/linker.cpp index b768a6e5285..ae

Re: [Mesa-dev] [PATCH] glsl: Fix missing-braces warning.

This is: Reviewed-by: Andres Gomez <ago...@igalia.com> On Thu, 2017-02-23 at 22:31 +, Vinson Lee wrote: > CXXglsl/ast_to_hir.lo > glsl/ast_to_hir.cpp: In member function 'virtual ir_rvalue* > ast_declarator_list::hir(exec_list*, _mesa_glsl_parse_state*)': > glsl/ast_

Re: [Mesa-dev] [PATCH] glsl: add missing blend_support qualifier in validate_flags()

This is: Reviewed-by: Andres Gomez <ago...@igalia.com> On Thu, 2017-02-23 at 19:17 +0100, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> > --- > src/compiler/glsl/ast_type.cpp | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(

Re: [Mesa-dev] [PATCH] glsl: use an enum for AMD_conservative_depth layout qualifiers

>data.depth_layout = ir_depth_layout_greater; > - else if (qual->flags.q.depth_less) > + else if (qual->depth_type == ast_depth_less) >var->data.depth_layout = ir_depth_layout_less; > - else if (qual->flags.q.depth_unchanged) > + else if (qual->depth_type == ast_depth_unchanged) > var->data.depth_layout = ir_depth_layout_unchanged; > else > var->data.depth_layout = ir_depth_layout_none; Maybe replace this with a ? switch(qual->depth_type) { case ast_depth_any: ... } Other than that nitpick, this is: Reviewed-by: Andres Gomez <ago...@igalia.com> -- Br, Andres ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] glsl: Corrected some typos, error messages and formatting

Signed-off-by: Andres Gomez <ago...@igalia.com> --- src/compiler/glsl/ast_to_hir.cpp | 37 + 1 file changed, 21 insertions(+), 16 deletions(-) diff --git a/src/compiler/glsl/ast_to_hir.cpp b/src/compiler/glsl/ast_to_hir.cpp index b90ad97b1de..d7a2b

Re: [Mesa-dev] [PATCH] glsl: Raise a link error for non-SSO ES programs with a TES but no TCS.

I would welcome a reference to the text in Secption 7.3 of the OpenGL ES 3.2 specs as a code comment and commit text but, other than that, this is: Reviewed-by: Andres Gomez <ago...@igalia.com> On Wed, 2017-02-22 at 17:54 -0800, Kenneth Graunke wrote: > OpenGL allows the TCS to b

[Mesa-dev] [PATCH 0/3] Validate IB bindings through its name, no instance

ld succeed on linking: "# VS layout(binding = 1) Block1 { vec4 color; } uni_block; ... # FS layout(binding = 2) Block2 { vec4 color; } uni_block; ..." Currently, it fails. Fixes: - GL45-CTS.enhanced_layouts.ssb_layout_qualifier_conflict Andr

[Mesa-dev] [PATCH 1/3] glsl: on UBO/SSBOs link error, the number of active blocks remains 0

a segmentation fault if trying to use the index of a block in a link failed program. Signed-off-by: Andres Gomez <ago...@igalia.com> Cc: Timothy Arceri <tarc...@itsqueeze.com> --- src/compiler/glsl/linker.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/compiler/glsl/link

[Mesa-dev] [PATCH 2/3] glsl: UBOs and SSBOs must match the binding qualifier too

} uni_block2; ..." Signed-off-by: Andres Gomez <ago...@igalia.com> Cc: Ian Romanick <ian.d.roman...@intel.com> --- src/compiler/glsl/link_uniform_blocks.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/compiler/glsl/link_uniform_blocks.cpp b/src/compiler/glsl/link_unif

[Mesa-dev] [PATCH 3/3] glsl: Interface Block instances don't need linking validation

t no link error will be reported on a program like this: "# VS layout(binding = 1) Block1 { vec4 color; } uni_block; ... # FS layout(binding = 2) Block2 { vec4 color; } uni_block; ..." Fixes GL45-CTS.enhanced_layouts.ssb_layout_qualifier_conflict Si

Re: [Mesa-dev] [PATCH] glsl: binding qualifier must match with opaque-uniforms only

Dropping this patch due to the discussion I opened at: https://cvs.khronos.org/bugzilla/show_bug.cgi?id=16238 The layout qualification among Uniform and Shader Storage Blocks across a linked program must match. Br. On Sun, 2017-02-05 at 20:53 +0200, Andres Gomez wrote: > The binding po

Re: [Mesa-dev] [PATCH] dir-locals.el: show-trailing-whitespace and whitespace support

If nobody says otherwise, I will land this by the beginning of next week. On Tue, 2016-08-02 at 19:14 +0300, Andres Gomez wrote: > Signed-off-by: Andres Gomez <ago...@igalia.com> > --- > .dir-locals.el | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) >

Re: [Mesa-dev] [PATCH] dir-locals.el: show-trailing-whitespace and whitespace support

On Thu, 2016-09-08 at 09:59 -0400, Ilia Mirkin wrote: > On Tue, Aug 2, 2016 at 12:14 PM, Andres Gomez <ago...@igalia.com> wrote: > > Signed-off-by: Andres Gomez <ago...@igalia.com> > > --- > > .dir-locals.el | 9 +++-- > > 1 file changed, 7 insertions

Re: [Mesa-dev] [PATCH 3/5] i965: use new subroutine index uploader.

On Tue, 2016-08-23 at 10:45 +1000, Dave Airlie wrote: > > > > > #include "main/mtypes.h" > > > #include "program/prog_parameter.h" > > > - > > > +#include "main/shaderapi.h" > > > > Why the extra empty line? If so, I would put it after the new include. > > It actually removes the empty line,

Re: [Mesa-dev] [PATCH] dir-locals.el: show-trailing-whitespace and whitespace support

On Thu, 2016-09-08 at 12:04 -0400, Ilia Mirkin wrote: > On Thu, Sep 8, 2016 at 12:01 PM, Andres Gomez <ago...@igalia.com> wrote: > > It will highlight malformed indentation > > Malformed meaning what? Usage of tabs, instead of spaces. > > and change color of t

[Mesa-dev] [PATCH 1/5] glsl: last duplicated layout-qualifier-name in a layout-qualifier overrides the former

if the "is_single_layout_merge" parameter is on, since the GLSL parser works in this case from right to left. Signed-off-by: Andres Gomez <ago...@igalia.com> --- src/compiler/glsl/ast_type.cpp | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/compiler/glsl

[Mesa-dev] [PATCH 0/5] deal with multiple appearances of the same layout-qualifier-name in a single declaration

ader are valid. Fixes: - GL44-CTS.shading_language_420pack.qualifier_override_layout - GL44-CTS.enhanced_layouts.xfb_duplicated_stride Andres Gomez (5): glsl: last duplicated layout-qualifier-name in a layout-qualifier overrides the former glsl: last duplicated layout-qualifier-name in multiple layout-q

[Mesa-dev] [PATCH 3/5] glsl: push layout-qualifier-name values from variable declarations to global

are pushing this to the global values since before it was mixed in the merging call and we only run this once all the processing for layout-qualifiers in a declaration has happened. Signed-off-by: Andres Gomez <ago...@igalia.com> --- src/compiler/glsl/ast.h | 6 + src/compile

[Mesa-dev] [PATCH 2/5] glsl: last duplicated layout-qualifier-name in multiple layout-qualifiers overrides the former

xpression is now done prepending instead of appending since the processing of the qualifier constant returns the first value in the list and the last appearing declaration of a variable or default overrides the previous declarations. Fixes GL44-CTS.shading_language_420pack.qualifier_override_layout Signed

[Mesa-dev] [PATCH 4/5] glsl: by default, any ast_layout_expression variable value must match its previous appearances

e error to have different values specified for the stride for the same buffer." Fixes GL44-CTS.enhanced_layouts.xfb_duplicated_stride Signed-off-by: Andres Gomez <ago...@igalia.com> --- src/compiler/glsl/ast.h | 2 +- src/compiler/glsl/glsl_parser_extras.cpp | 2 +- 2 files chan

[Mesa-dev] [PATCH 5/5] glsl: simplified ast_type_qualifier::merge_[in|out]_qualifier API

Since we modified the way in which multiple repetitions of the same layout-qualifier-name in a single declaration collapse into the ast_type_qualifier class, we can simplify the merge_[in|out]_qualifier APIs through removing the create_node parameter. Signed-off-by: Andres Gomez <

[Mesa-dev] [PATCH 3/8] glsl: ignore all but the rightmost layout qualifier name from the rightmost layout qualifier

nguage_420pack.qualifier_override_layout Signed-off-by: Andres Gomez <ago...@igalia.com> --- src/compiler/glsl/ast.h | 3 +- src/compiler/glsl/ast_type.cpp | 28 ++--- src/compiler/glsl/glsl_parser.yy | 125 ++- 3 files changed, 79 insertions(

[Mesa-dev] [PATCH 7/8] Revert "glsl: allow layout qualifier overrides with ARB_shading_language_420pack"

) of the GLSL 4.40 spec: " While xfb_stride can be declared multiple times for the same buffer, it is a compile-time or link-time error to have different values specified for the stride for the same buffer." Fixes GL44-CTS.enhanced_layouts.xfb_duplicated_stride Reviewed-by: Ti

Re: [Mesa-dev] [PATCH 2/9] glsl: merge layouts into the default one as the last step in interface blocks

On Mon, 2016-10-24 at 12:23 +1100, Timothy Arceri wrote: > On Sat, 2016-10-22 at 23:09 +0300, Andres Gomez wrote: > > Consider this example: > > > > " #version 150 core > >   #extension GL_ARB_shading_language_420pack: require > >   #extension GL

[Mesa-dev] [PATCH v3 0/8] deal with multiple appearances of the same layout-qualifier-name in a single declaration

alifier_override_layout - GL44-CTS.enhanced_layouts.xfb_duplicated_stride Andres Gomez (8): glsl: ignore all but the rightmost layout-qualifier-name glsl: merge layouts into the default one as the last step in interface blocks glsl: ignore all but the rightmost layout qualifier name

  1   2   3   4   5   6   7   >