Re: [Mesa-dev] [PATCH 09/12] intel: Handle MapRenderbuffer of fake packed depth/stencil using miptree maps.

2011-12-06 Thread Chad Versace
, 2 insertions(+), 138 deletions(-) Reviewed-by: Chad Versace chad.vers...@linux.intel.com -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBAgAGBQJO3mTiAAoJEAIvNt057x8igj4P/itBdd3swRhJRRLqdIgSv2Vm

Re: [Mesa-dev] [PATCH 10/12] intel: Add support for LLC-cached reads of X-tiled miptrees using a blit.

2011-12-06 Thread Chad Versace
fails, the code should just jump to 'fail'. +fail: + drm_intel_bo_unreference(map-bo); + map-ptr = NULL; + map-stride = 0; +} + - Chad Versace chad.vers...@linux.intel.com -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http

Re: [Mesa-dev] [PATCH 11/12] intel: Rely on miptree mapping for all renderbuffer maps.

2011-12-06 Thread Chad Versace
/mesa/drivers/dri/intel/intel_fbo.h |4 - 2 files changed, 21 insertions(+), 202 deletions(-) Yes. It's good to see the rb_map and tex_map code unified. Reviewed-by: Chad Versace chad.vers...@linux.intel.com -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG

Re: [Mesa-dev] [PATCH 12/12] intel: Update comment about how depth/stencil miptrees are handled.

2011-12-06 Thread Chad Versace
files changed, 18 insertions(+), 6 deletions(-) Reviewed-by: Chad Versace chad.vers...@linux.intel.com -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBAgAGBQJO3mbCAAoJEAIvNt057x8iDKkP/R9cJnYnHPT8VUbOcF4ncLNq

Re: [Mesa-dev] [PATCH 08/12] intel: Track miptrees for fake packed depth/stencil renderbuffers.

2011-12-06 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/06/2011 02:43 PM, Eric Anholt wrote: On Tue, 06 Dec 2011 10:43:15 -0800, Chad Versace chad.vers...@linux.intel.com wrote: On 12/05/2011 11:42 AM, Eric Anholt wrote: --- a/src/mesa/drivers/dri/intel/intel_mipmap_tree.c +++ b/src/mesa

Re: [Mesa-dev] [PATCH] i965: Don't use BRW_DEPTHFORMAT_D24_UNORM_X8_UINT on Gen4.

2011-12-21 Thread Chad Versace
. Signed-off-by: Kenneth Graunke kenn...@whitecape.org Reviewed-by: Eric Anholt e...@anholt.net - Chad Versace chad.vers...@linux.intel.com -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

Re: [Mesa-dev] [PATCH] i965: Don't use BRW_DEPTHFORMAT_D24_UNORM_X8_UINT on Gen4.

2011-12-21 Thread Chad Versace
MESA_FORMAT_S8_Z24: return BRW_DEPTHFORMAT_D24_UNORM_S8_UINT; case MESA_FORMAT_Z32_FLOAT_X24S8: Reviewed-by: Chad Versace chad.vers...@linux.intel.com - Chad Versace chad.vers...@linux.intel.com -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG

[Mesa-dev] [PATCH 0/2] i965: Add alpha support for Android IceCreamSandwich

2011-12-21 Thread Chad Versace
This series adds a mock implementation of GL_OES_EGL_image_external that enables SurfaceFlinger to provide a home screen. Chad Versace (2): meta: Disable GL_TEXTURE_EXTERNAL_OES in meta_begin() i965: Create mock implementation of GL_OES_EGL_image_external src/mesa/drivers/common/meta.c

[Mesa-dev] [PATCH 1/2] meta: Disable GL_TEXTURE_EXTERNAL_OES in meta_begin()

2011-12-21 Thread Chad Versace
If the meta flag MESA_META_TEXTURE is present, then disable the texture target GL_TEXTURE_EXTERNAL_OES. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- src/mesa/drivers/common/meta.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/mesa/drivers/common

[Mesa-dev] [PATCH 2/2] i965: Create mock implementation of GL_OES_EGL_image_external

2011-12-21 Thread Chad Versace
. Some of it is even incorrect. When we begin to really implement GL_OES_EGL_image_external, much of the patch will need reverting. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- src/mesa/drivers/dri/i965/brw_wm_emit.c |2 ++ src/mesa/drivers/dri/i965/brw_wm_pass1.c

Re: [Mesa-dev] [PATCH 1/4] mesa: simplify Driver.TexSubImage() parameters

2011-12-27 Thread Chad Versace
review everything, since much of the change was mechanical. A clean build with the patches applied didn't generate additional warnings, so I assume all is good with this series. For the series, Reviewed-by: Chad Versace chad.vers...@linux.intel.com - Chad Versace chad.vers...@linux.intel.com

[Mesa-dev] [PATCH] intel: Fix memory leak in intel_miptree_create()

2011-12-27 Thread Chad Versace
On failure, intel_miptree_create() needs to *release* the miptree, not just free it, so that the stencil_mt gets released too. CC: Eric Anholt e...@anholt.net Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- src/mesa/drivers/dri/intel/intel_mipmap_tree.c |4 ++-- 1 files changed

Re: [Mesa-dev] [PATCH 1/3] intel: Fix bad read/write flags on self-copies for glCopyBufferSubData().

2011-12-29 Thread Chad Versace
| +GL_MAP_WRITE_BIT, +dst); memmove(ptr + write_offset, ptr + read_offset, size); intel_bufferobj_unmap(ctx, dst); } else { Reviewed-by: Chad Versace chad.vers...@linux.intel.com

Re: [Mesa-dev] [PATCH 2/3] intel: Fix pitch handling for linear blits.

2011-12-29 Thread Chad Versace
, 0, 0, /* src x/y */ 0, 0, /* dst x/y */ size, 1, /* w, h */ Reviewed-by: Chad Versace chad.vers...@linux.intel.com - Chad Versace chad.vers...@linux.intel.com -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux

Re: [Mesa-dev] [PATCH 20/20] tests/glx: Add unit tests for GLX_ARB_create_context GLX protocol

2011-12-29 Thread Chad Versace
of adding unit tests to Mesa with gtest. Acked-by: Chad Versace chad.vers...@linux.intel.com - Chad Versace chad.vers...@linux.intel.com -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBAgAGBQJO

Re: [Mesa-dev] [PATCH] intel/intel_decode.c: Remove #include intel_decode.h.

2011-12-30 Thread Chad Versace
+28,6 @@ #include stdarg.h #include string.h -#include intel_decode.h #include intel_chipset.h #include intel_bufmgr.h Pushed. Thanks. Chad Versace chad.vers...@linux.intel.com ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http

[Mesa-dev] [PATCH 1/3] i965: Fix misnamed GEN7_WM_DEPTH_RESOLVE

2012-01-09 Thread Chad Versace
It was named GEN6_WM_DEPTH_RESOLVE. Luckily, this caused no conflict, because the value is identical for gen6 and gen7. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- src/mesa/drivers/dri/i965/brw_defines.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

[Mesa-dev] [PATCH 3/3] i965/gen7: Enable HiZ

2012-01-09 Thread Chad Versace
://people.freedesktop.org/~anholt/linux.git branch=gen7-reset-sol sha=23360e4 Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- src/mesa/drivers/dri/i965/gen7_clip_state.c | 20 - src/mesa/drivers/dri/i965/gen7_misc_state.c | 31 --- src/mesa/drivers/dri/i965

[Mesa-dev] [PATCH 0/3] i965/gen7: Enable HiZ

2012-01-09 Thread Chad Versace
Chad Versace (3): i965: Fix misnamed GEN7_WM_DEPTH_RESOLVE i965: Replace references to stencil region size with buffer size i965/gen7: Enable HiZ src/mesa/drivers/dri/i965/brw_defines.h |2 +- src/mesa/drivers/dri/i965/brw_misc_state.c |8 +++--- src/mesa/drivers/dri/i965

[Mesa-dev] [PATCH] Revert i965: Replace references to stencil region size with buffer size

2012-01-11 Thread Chad Versace
...@anholt.net CC: Kenneth Graunke kenn...@whitecape.org Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- src/mesa/drivers/dri/i965/brw_misc_state.c | 10 ++ src/mesa/drivers/dri/i965/gen7_misc_state.c |8 2 files changed, 10 insertions(+), 8 deletions(-) diff

[Mesa-dev] [PATCH] i965/hiz: Don't bind GL_DRAW_FRAMEBUFFER on GLES

2012-01-11 Thread Chad Versace
...@linux.intel.com Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- src/mesa/drivers/dri/i965/gen6_hiz.c | 37 + 1 files changed, 32 insertions(+), 5 deletions(-) diff --git a/src/mesa/drivers/dri/i965/gen6_hiz.c b/src/mesa/drivers/dri/i965/gen6_hiz.c index e282511

Re: [Mesa-dev] [PATCH] i965/hiz: Don't bind GL_DRAW_FRAMEBUFFER on GLES

2012-01-13 Thread Chad Versace
that the extension bit for EXT_framebuffer_blit was off in an ES context, since the extension doesn't exist there. But that's not how Mesa's extension works, which I should have known; I plumbed it before. Neil, your original patch is pushed and the bug report updated. Chad Versace chad.vers

Re: [Mesa-dev] [PATCH 2/4] intel: Drop the version override code now that we don't have any left.

2012-01-13 Thread Chad Versace
/version.c:override_version(). Reviewed-by: Chad Versace chad.vers...@linux.intel.com -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBAgAGBQJPELQ9AAoJEAIvNt057x8iAs4P/13cQLkh9fFOoqdbNUItK7Tg 92olOV0ce0LTtdY

Re: [Mesa-dev] [PATCH 4/4] mesa: Enable silent automake rules when available.

2012-01-13 Thread Chad Versace
], [AM_SILENT_RULES([yes])]) + LT_PREREQ([2.2]) LT_INIT([disable-static]) I like silence. For this and patch 1/4: Reviewed-by: Chad Versace chad.vers...@linux.intel.com I don't know autotools, so I'm not touching patch 3/4. Chad Versace chad.vers...@linux.intel.com

[Mesa-dev] [PATCH] i965: Fix gen6, gen7 when used with a non-HiZ capable DDX

2012-01-13 Thread Chad Versace
://bugs.freedesktop.org/show_bug.cgi?id=44103 CC: Ian Romanick i...@freedesktop.org Note: This is a candidate for the 8.0 branch. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- src/mesa/drivers/dri/intel/intel_mipmap_tree.c | 17 + 1 files changed, 13 insertions(+), 4 deletions(-) diff

Re: [Mesa-dev] [Intel-gfx] [PATCH] intel: Fix stencil buffer to be W tiled

2011-07-19 Thread Chad Versace
On 07/18/2011 01:20 AM, Paul Menzel wrote: Am Montag, den 18.07.2011, 00:55 -0700 schrieb Chad Versace: There are alignment/white space issues above. + unsigned stride = irb-region-pitch;\ + unsigned height = 2 * irb-region-height

Re: [Mesa-dev] [PATCH 1/4] mesa: Add an ifndef guard around the definition of the INLINE macro

2011-07-20 Thread Chad Versace
(+), 20 deletions(-) Ifdef-guarding such a commonly defined macro is a good idea. Reviewed-by: Chad Versace c...@chad-versace.us -- Chad Versace c...@chad-versace.us signature.asc Description: OpenPGP digital signature ___ mesa-dev mailing list mesa

Re: [Mesa-dev] [PATCH 2/4] glsl: Move initialize_context() to glsl_parser_extras.cpp so it can be re-used.

2011-07-20 Thread Chad Versace
-Const.MaxTextureImageUnits = 2; - ctx-Const.FragmentProgram.MaxUniformComponents = 64; - - ctx-Const.MaxDrawBuffers = 2; - ctx-Driver.NewShader = _mesa_new_shader; } -- Chad Versace c...@chad-versace.us signature.asc Description: OpenPGP digital signature

Re: [Mesa-dev] [PATCH 3/4] glsl: Create a standalone executable for testing optimization passes.

2011-07-20 Thread Chad Versace
*) realloc(result, len + bytes_read + 1); memcpy(result + len, buffer, bytes_read); len += bytes_read; } result[len] = '\0'; return result; } -- Chad Versace c...@chad-versace.us signature.asc Description: OpenPGP digital signature

Re: [Mesa-dev] [PATCH 4/4] glsl: Add unit tests for lower_jumps.cpp

2011-07-20 Thread Chad Versace
create mode 100644 src/glsl/tests/sexps.py I'm in favor of adding these unit tests. I can think of no reliable way, other than unit testing, to prevent regressions of optpass explosion lolz. And I feel that these particular unit tests are a good approach. Acked-by: Chad Versace c...@chad

Re: [Mesa-dev] [PATCH 1/3 v2] i965: Check actual tile offsets in Gen4 miptree workaround.

2011-07-26 Thread Chad Versace
and tile_y and check those, as that way both places are checking the same thing. NOTE: This is a candidate for stable release branches. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=34009 Cc: Chad Versace c...@chad-versace.us Cc: Eric Anholt e...@anholt.net Signed-off-by: Kenneth Graunke

[Mesa-dev] [PATCH 1/3] glsl: Document parameters_lists_match()

2011-07-26 Thread Chad Versace
The function's parameter do not indicate which parameter list belongs to the function signature and which is the actual parameter list. So clarify this in a Doxygen comment. Signed-off-by: Chad Versace c...@chad-versace.us --- src/glsl/ir_function.cpp |6 ++ 1 files changed, 6 insertions

[Mesa-dev] [PATCH 2/3] glsl: Clarify and document type_compare()

2011-07-26 Thread Chad Versace
The parameters were named 'a' and 'b', but there was no documentation indicating which was being converted to which. So rename 'a' - 'to' and 'b' - 'from'. Also add a Doxygen comment. Signed-off-by: Chad Versace c...@chad-versace.us --- src/glsl/ir_function.cpp | 27

[Mesa-dev] [PATCH 3/3] glsl: Fix illegal implicit type conversions in type_compare()

2011-07-26 Thread Chad Versace
type_compare() allowed the following illegal implicit conversions: bool - float bvecN - vecN Fixes Piglit tests spec/glsl-1.20/compiler/built-in-functions/outerProduct-bvec*.vert. Note: This is a candidate for the 7.10 and 7.11 branches. Signed-off-by: Chad Versace c...@chad-versace.us

[Mesa-dev] [PATCH 0/4] Fix implicit conversions

2011-07-27 Thread Chad Versace
These fixes are candidates for the stable branches. Chad Versace (4): glsl: Document parameters_lists_match() glsl: Refactor ast_function.cpp:type_compare() into a glsl_type method glsl: Fix illegal implicit type conversions glsl: Fix implicit conversions in array constructors src

[Mesa-dev] [PATCH 1/4] glsl: Document parameters_lists_match()

2011-07-27 Thread Chad Versace
The function's parameter do not indicate which parameter list belongs to the function signature and which is the actual parameter list. So clarify this in a Doxygen comment. Signed-off-by: Chad Versace c...@chad-versace.us --- src/glsl/ir_function.cpp |6 ++ 1 files changed, 6 insertions

[Mesa-dev] [PATCH 2/4] glsl: Refactor ast_function.cpp:type_compare() into a glsl_type method

2011-07-27 Thread Chad Versace
On a subsequent commit, ast_function_expression::hir() will need access to type_compare(), but it is defined in a different file. So refactor type_compare() into glsl_type::implicit_conversion_compare(). CC: Ian Romanick ian.d.roman...@intel.com Signed-off-by: Chad Versace c...@chad-versace.us

[Mesa-dev] [PATCH 3/4] glsl: Fix illegal implicit type conversions

2011-07-27 Thread Chad Versace
*.vert. If cherry-picked, the following commit is required: glsl: Refactor ast_function.cpp:type_compare() into a glsl_type method Note: This is a candidate for the 7.10 and 7.11 branches. CC: Ian Romanick ian.d.roman...@intel.com Signed-off-by: Chad Versace c...@chad-versace.us --- src/glsl

[Mesa-dev] [PATCH 4/4] glsl: Fix implicit conversions in array constructors

2011-07-27 Thread Chad Versace
commits are required: glsl: Refactor ast_function.cpp:type_compare() into a glsl_type method glsl: Fix illegal implicit type conversions Note: This is a candidate for the 7.10 and 7.11 branches. CC: Ian Romanick ian.d.roman...@intel.com Signed-off-by: Chad Versace c...@chad-versace.us --- src

Re: [Mesa-dev] [PATCH 3/3] glsl: Fix illegal implicit type conversions in type_compare()

2011-07-27 Thread Chad Versace
On 07/26/2011 05:43 PM, Ian Romanick wrote: On 07/26/2011 04:08 PM, Chad Versace wrote: type_compare() allowed the following illegal implicit conversions: bool - float bvecN - vecN Fixes Piglit tests spec/glsl-1.20/compiler/built-in-functions/outerProduct-bvec*.vert. Does

[Mesa-dev] [PATCH 0/4 v2] Fix implicit conversion

2011-07-27 Thread Chad Versace
These fixes are candidates for the 7.10 and 7.11 branches. (v1 of the series contained an Eclipse reformatting bomb). Chad Versace (4): glsl: Document parameters_lists_match() glsl: Refactor ast_function.cpp:type_compare() into a glsl_type method glsl: Fix illegal implicit type

[Mesa-dev] [PATCH 2/4] glsl: Refactor ast_function.cpp:type_compare() into a glsl_type method

2011-07-27 Thread Chad Versace
On a subsequent commit, ast_function_expression::hir() will need access to type_compare(), but it is defined in a different file. So refactor type_compare() into glsl_type::implicit_conversion_compare(). CC: Ian Romanick ian.d.roman...@intel.com Signed-off-by: Chad Versace c...@chad-versace.us

[Mesa-dev] [PATCH 3/4] glsl: Fix illegal implicit type conversions

2011-07-27 Thread Chad Versace
*.vert. If cherry-picked, the following commit is required: glsl: Refactor ast_function.cpp:type_compare() into a glsl_type method Note: This is a candidate for the 7.10 and 7.11 branches. CC: Ian Romanick ian.d.roman...@intel.com Signed-off-by: Chad Versace c...@chad-versace.us --- src/glsl

Re: [Mesa-dev] [PATCH 0/4] Fix implicit conversions

2011-07-27 Thread Chad Versace
On 07/26/2011 11:35 PM, Chad Versace wrote: These fixes are candidates for the stable branches. Chad Versace (4): glsl: Document parameters_lists_match() glsl: Refactor ast_function.cpp:type_compare() into a glsl_type method glsl: Fix illegal implicit type conversions glsl

[Mesa-dev] [PATCH 4/4] glsl: Fix implicit conversions in array constructors

2011-07-27 Thread Chad Versace
commits are required: glsl: Refactor ast_function.cpp:type_compare() into a glsl_type method glsl: Fix illegal implicit type conversions Note: This is a candidate for the 7.10 and 7.11 branches. CC: Ian Romanick ian.d.roman...@intel.com Signed-off-by: Chad Versace c...@chad-versace.us --- src

[Mesa-dev] [PATCH 0/5] Fix implicit type conversion errors

2011-07-27 Thread Chad Versace
*.vert Chad Versace (5): glsl: Add method glsl_type::can_implicitly_convert_to() glsl: Fix implicit conversions in non-constructor function calls glsl: Remove ir_function.cpp:type_compare() glsl: Fix conversions in array constructors glsl: Clarify ir_function::matching_sigature() src

[Mesa-dev] [PATCH 1/5] glsl: Add method glsl_type::can_implicitly_convert_to()

2011-07-27 Thread Chad Versace
glsl: Fix implicit conversions in array constructors Note: This is a candidate for the 7.10 and 7.11 branches. CC: Ian Romanick ian.d.roman...@intel.com CC: Kenneth Graunke kenn...@whitecape.org Signed-off-by: Chad Versace c...@chad-versace.us --- src/glsl/glsl_types.cpp | 30

[Mesa-dev] [PATCH 2/5] glsl: Fix implicit conversions in non-constructor function calls

2011-07-27 Thread Chad Versace
...@whitecape.org Signed-off-by: Chad Versace c...@chad-versace.us --- src/glsl/glsl_types.cpp | 23 +++ src/glsl/ir_function.cpp | 52 + 2 files changed, 37 insertions(+), 38 deletions(-) diff --git a/src/glsl/glsl_types.cpp b/src/glsl

[Mesa-dev] [PATCH 3/5] glsl: Remove ir_function.cpp:type_compare()

2011-07-27 Thread Chad Versace
The function is no longer used and has been replaced by glsl_type::can_implicitly_convert_to(). Note: This is a candidate for the 7.10 and 7.11 branches. CC: Ian Romanick ian.d.roman...@intel.com CC: Kenneth Graunke kenn...@whitecape.org Signed-off-by: Chad Versace c...@chad-versace.us --- src

[Mesa-dev] [PATCH 4/5] glsl: Fix conversions in array constructors

2011-07-27 Thread Chad Versace
branches. CC: Ian Romanick ian.d.roman...@intel.com CC: Kenneth Graunke kenn...@whitecape.org Signed-off-by: Chad Versace c...@chad-versace.us --- src/glsl/ast_function.cpp | 12 ++-- 1 files changed, 10 insertions(+), 2 deletions(-) diff --git a/src/glsl/ast_function.cpp b/src/glsl

[Mesa-dev] [PATCH 5/5] glsl: Clarify ir_function::matching_sigature()

2011-07-27 Thread Chad Versace
The function used a variable named 'score', which was an outright lie. A signature matches or it doesn't; there is no fuzzy scoring. CC: Ian Romanick ian.d.roman...@intel.com CC: Kenneth Graunke kenn...@whitecape.org Signed-off-by: Chad Versace c...@chad-versace.us --- src/glsl/ir_function.cpp

Re: [Mesa-dev] [PATCH v3] i965: Check actual tile offsets in Gen4 miptree workaround.

2011-07-28 Thread Chad Versace
: Chad Versace c...@chad-versace.us Cc: Eric Anholt e...@anholt.net Signed-off-by: Kenneth Graunke kenn...@whitecape.org --- src/mesa/drivers/dri/intel/intel_fbo.c | 26 -- 1 files changed, 24 insertions(+), 2 deletions(-) v3: The depth wrapper chasing apparently

Re: [Mesa-dev] [PATCH 4/5] glsl: Fix conversions in array constructors

2011-07-29 Thread Chad Versace
On 07/29/2011 01:57 PM, Kenneth Graunke wrote: On 07/27/2011 10:55 PM, Chad Versace wrote: Array constructors obey narrower conversion rules than other constructors [1] --- they use the implicit conversion rules [2] instead of the scalar constructor conversions [3

[Mesa-dev] [v2 PATCH 0/5] Fix implicit type conversion errors

2011-07-29 Thread Chad Versace
/glsl-1.20/compiler/structure-and-array-operations/array-ctor-implicit-conversion-bvec*-vec*.vert v2: - Fix the squash issues identified by Ken in patches 1 and 2. - Fix all other issues identifed by Ken, noted in each patch. Chad Versace (5): glsl: Add method glsl_type

[Mesa-dev] [PATCH 1/5] glsl: Add method glsl_type::can_implicitly_convert_to()

2011-07-29 Thread Chad Versace
...@whitecape.org Signed-off-by: Chad Versace c...@chad-versace.us --- src/glsl/glsl_types.cpp | 16 src/glsl/glsl_types.h | 35 +++ 2 files changed, 51 insertions(+), 0 deletions(-) diff --git a/src/glsl/glsl_types.cpp b/src/glsl/glsl_types.cpp index

[Mesa-dev] [PATCH 4/5] glsl: Fix conversions in array constructors

2011-07-29 Thread Chad Versace
: This is a candidate for the 7.10 and 7.11 branches. CC: Ian Romanick ian.d.roman...@intel.com Reviewed-by: Kenneth Graunke kenn...@whitecape.org Signed-off-by: Chad Versace c...@chad-versace.us --- src/glsl/ast_function.cpp | 12 ++-- 1 files changed, 10 insertions(+), 2 deletions

[Mesa-dev] [PATCH 5/5] glsl: Clarify ir_function::matching_sigature()

2011-07-29 Thread Chad Versace
...@intel.com CC: Kenneth Graunke kenn...@whitecape.org Signed-off-by: Chad Versace c...@chad-versace.us --- src/glsl/ir_function.cpp | 53 - 1 files changed, 33 insertions(+), 20 deletions(-) diff --git a/src/glsl/ir_function.cpp b/src/glsl/ir_function.cpp index

[Mesa-dev] PUSHED [v2 PATCH 0/5] Fix implicit type conversion errors

2011-07-30 Thread Chad Versace
Pushed. On 07/29/2011 06:58 PM, Chad Versace wrote: Fix implicit type conversion errors Fixes Piglit tests: spec/glsl-1.20/compiler/built-in-functions/outerProduct-bvec*.vert spec/glsl-1.20/compiler/structure-and-array-operations/array-ctor-implicit-conversion-bool-float.vert

Re: [Mesa-dev] [PATCH 5/5] glsl: Clarify ir_function::matching_sigature()

2011-08-01 Thread Chad Versace
On 08/01/2011 08:05 AM, Chris Bandy wrote: On 07/29/2011 08:59 PM, Chad Versace wrote: The function used a variable named 'score', which was an outright lie. A signature matches or it doesn't; there is no fuzzy scoring. Change the return type of parameter_lists_match() to an enum, and let

[Mesa-dev] [PATCH 00/15] i965, mesa, glapi: Build libi965_dri on Android

2011-08-04 Thread Chad Versace
://anongit.freedesktop.git/~chadversary/android.manifeset.git -b gingerbread-i965 Chad Versace (15): mesa: Add toplevel Android.mk glapi: Build libmesa_glapi on Android mesa/sources.mak: Convert all variables to be simply-expanded mesa/sources.mak: Cleanup include paths for Android mesa/sources.mak

[Mesa-dev] [PATCH 01/15] mesa: Add toplevel Android.mk

2011-08-04 Thread Chad Versace
-drivers=i965 --with-gallium-drivers= Note: This is in preparation for porting i965 to Android. CC: Chia-I Wu o...@lunarg.com, CC: Chih-Wei Huang cwhu...@android-x86.org Signed-off-by: Chad Versace c...@chad-versace.us --- Android.mk | 66

[Mesa-dev] [PATCH 02/15] glapi: Build libmesa_glapi on Android

2011-08-04 Thread Chad Versace
naming collisions in the build tree. (For an example, grep for `libc_` in bionic's Makefiles). Note: This is in preparation for porting i965 to Android. CC: Chia-I Wu o...@lunarg.com, CC: Chih-Wei Huang cwhu...@android-x86.org Signed-off-by: Chad Versace c...@chad-versace.us --- Android.mk

[Mesa-dev] [PATCH 03/15] mesa/sources.mak: Convert all variables to be simply-expanded

2011-08-04 Thread Chad Versace
tree. 2. Android is built with a single, non-recursive invocation of `make`. Note: This is in preparation for porting i965 to Android. CC: Chia-I Wu o...@lunarg.com, CC: Chih-Wei Huang cwhu...@android-x86.org Signed-off-by: Chad Versace c...@chad-versace.us --- src/mesa/sources.mak | 54

[Mesa-dev] [PATCH 04/15] mesa/sources.mak: Cleanup include paths for Android

2011-08-04 Thread Chad Versace
...@android-x86.org Signed-off-by: Chad Versace c...@chad-versace.us --- src/mesa/sources.mak | 20 ++-- 1 files changed, 14 insertions(+), 6 deletions(-) diff --git a/src/mesa/sources.mak b/src/mesa/sources.mak index e45c99f..6800c47 100644 --- a/src/mesa/sources.mak +++ b/src/mesa

[Mesa-dev] [PATCH 05/15] mesa/sources.mak: Change handling of lex and yacc files for Android

2011-08-04 Thread Chad Versace
Signed-off-by: Chad Versace c...@chad-versace.us --- src/mesa/sources.mak | 11 +-- 1 files changed, 9 insertions(+), 2 deletions(-) diff --git a/src/mesa/sources.mak b/src/mesa/sources.mak index 6800c47..9923133 100644 --- a/src/mesa/sources.mak +++ b/src/mesa/sources.mak @@ -244,11

[Mesa-dev] [PATCH 07/15] main: Add -o option to es_generator.py

2011-08-04 Thread Chad Versace
-x86.org Signed-off-by: Chad Versace c...@chad-versace.us --- src/mesa/main/es_generator.py | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/src/mesa/main/es_generator.py b/src/mesa/main/es_generator.py index c0b0a44..21f59b4 100644 --- a/src/mesa/main

[Mesa-dev] [PATCH 08/15] mesa: Build libmesa_main for Android

2011-08-04 Thread Chad Versace
tree. (For an example, grep for `libc_` in bionic's Makefiles). Note: This is in preparation for porting i965 to Android. CC: Chia-I Wu o...@lunarg.com, CC: Chih-Wei Huang cwhu...@android-x86.org Signed-off-by: Chad Versace c...@chad-versace.us --- src/mesa/Android.mk | 56

[Mesa-dev] [PATCH 09/15] dri/Makefile.defines: Remove non-existent dir from include paths

2011-08-04 Thread Chad Versace
Remove src/egl/drivers/dri from SHARED_INCLUDES. That directory no longer exists. Signed-off-by: Chad Versace c...@chad-versace.us --- src/mesa/drivers/dri/Makefile.defines |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/src/mesa/drivers/dri/Makefile.defines b/src/mesa

[Mesa-dev] [PATCH 10/15] dri/Makefile.defines: Convert all variables to be simply-expanded

2011-08-04 Thread Chad Versace
-by: Chad Versace c...@chad-versace.us --- src/mesa/drivers/dri/Makefile.defines | 15 +-- src/mesa/drivers/dri/Makefile.targets |5 + 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/src/mesa/drivers/dri/Makefile.defines b/src/mesa/drivers/dri/Makefile.defines

[Mesa-dev] [PATCH 11/15] dri/Makefile.defines: Only add -Iserver to includes if the dir exists

2011-08-04 Thread Chad Versace
Without this change, the next commit breaks the i915 and i965 builds. CC: Chia-I Wu o...@lunarg.com, CC: Chih-Wei Huang cwhu...@android-x86.org Signed-off-by: Chad Versace c...@chad-versace.us --- src/mesa/drivers/dri/Makefile.defines |5 - 1 files changed, 4 insertions(+), 1 deletions

[Mesa-dev] [PATCH 12/15] dri/Makefile.defines: Cleanup filepaths for Android

2011-08-04 Thread Chad Versace
for porting i965 to Android. CC: Chia-I Wu o...@lunarg.com, CC: Chih-Wei Huang cwhu...@android-x86.org Signed-off-by: Chad Versace c...@chad-versace.us --- src/mesa/drivers/dri/Makefile.defines | 50 +--- 1 files changed, 33 insertions(+), 17 deletions(-) diff --git a/src

[Mesa-dev] [PATCH 13/15] i965: New file sources.mk

2011-08-04 Thread Chad Versace
: Chih-Wei Huang cwhu...@android-x86.org Signed-off-by: Chad Versace c...@chad-versace.us --- src/mesa/drivers/dri/i965/sources.mk | 115 ++ 1 files changed, 115 insertions(+), 0 deletions(-) create mode 100644 src/mesa/drivers/dri/i965/sources.mk diff --git a/src/mesa

[Mesa-dev] [PATCH 15/15] i965: Build libi965_dri on Android

2011-08-04 Thread Chad Versace
The driver doesn't work yet, it just builds. Currently, it's not being linked to libdrm. Note: This is in preparation for porting i965 to Android. CC: Chia-I Wu o...@lunarg.com, CC: Chih-Wei Huang cwhu...@android-x86.org Signed-off-by: Chad Versace c...@chad-versace.us --- src/mesa/Android.mk

Re: [Mesa-dev] [PATCH] glsl: empty declarations should be valid

2011-08-04 Thread Chad Versace
the spec grammar intentionally allows empty declarations. C allows it, and GLSL tries to mimic C. Even though I don't like empty declarations, this patch is Reviewed-by: Chad Versace c...@chad-versace.us -- Chad Versace c...@chad-versace.us signature.asc Description: OpenPGP digital signature

Re: [Mesa-dev] [PATCH 1/3] glsl: Make is_lvalue() and variable_referenced() const.

2011-08-04 Thread Chad Versace
Versace c...@chad-versace.us -- Chad Versace c...@chad-versace.us signature.asc Description: OpenPGP digital signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 3/3] glsl: Perform implicit type conversions on function call out parameters.

2011-08-04 Thread Chad Versace
= prototype_string(NULL, name, actual_parameters); With Ian's formatting fixes, the commit message fix, and my comment addition, I'm content with this patch, and you can call it Reviewed-by: Chad Versace c...@chad-versace.us -- Chad Versace c...@chad-versace.us signature.asc Description

Re: [Mesa-dev] [PATCH 06/15] main: Remove problematic #include on Android

2011-08-04 Thread Chad Versace
On 08/04/2011 08:43 AM, Eric Anholt wrote: On Thu, 4 Aug 2011 02:47:15 -0700, Chad Versace c...@chad-versace.us wrote: Remove ``#include fpu_control.h`` from compiler.h. Note: This is in preparation for porting i965 to Android. CC: Chia-I Wu o...@lunarg.com, CC: Chih-Wei Huang cwhu

Re: [Mesa-dev] [PATCH 11/15] dri/Makefile.defines: Only add -Iserver to includes if the dir exists

2011-08-04 Thread Chad Versace
On 08/04/2011 08:45 AM, Eric Anholt wrote: On Thu, 4 Aug 2011 02:47:20 -0700, Chad Versace c...@chad-versace.us wrote: Without this change, the next commit breaks the i915 and i965 builds. CC: Chia-I Wu o...@lunarg.com, CC: Chih-Wei Huang cwhu...@android-x86.org Signed-off-by: Chad Versace

Re: [Mesa-dev] [PATCH 01/15] mesa: Add toplevel Android.mk

2011-08-04 Thread Chad Versace
On 08/04/2011 04:17 PM, Jose Fonseca wrote: - Original Message - On Thu, Aug 4, 2011 at 2:47 AM, Chad Versace c...@chad-versace.us wrote: This is the first step in porting libGLES* and libEGL to Android. The makefile doesn't build anything yet; it just defines common variables

Re: [Mesa-dev] [PATCH 00/15] i965, mesa, glapi: Build libi965_dri on Android

2011-08-04 Thread Chad Versace
On 08/04/2011 11:25 AM, Chia-I Wu wrote: Hi Chad, On Thu, Aug 4, 2011 at 6:47 PM, Chad Versace c...@chad-versace.us wrote: This is the first step in porting i965 to Android, initially to Gingerbread. Android is ubiquituous now, and the platform's importance can't be denied. The Intel

Re: [Mesa-dev] [PATCH] glsl: empty declarations should be valid

2011-08-04 Thread Chad Versace
On 08/04/2011 06:18 PM, Chad Versace wrote: On 08/04/2011 01:29 PM, Eric Anholt wrote: On Thu, 4 Aug 2011 12:59:35 +0900, Chia-I Wu olva...@gmail.com wrote: From: Chia-I Wu o...@lunarg.com Unlike C++, empty declarations such as float; should be valid. The spec is not explicit about

Re: [Mesa-dev] Mesa (master): egl/gbm: Fix EGL_DEFAULT_DISPLAY

2011-08-05 Thread Chad Versace
On 08/05/2011 12:30 AM, Benjamin Franzke wrote: 2011/8/5 Chad Versace c...@chad-versace.us: This commit *really* needs a more descriptive commit message. Ok, I thought its clear what is to be done for EGL_DEFAULT_DISPLAY. But your right, it should have more descriptive. In future I'll try

Re: [Mesa-dev] [PATCH] glsl: empty declarations should be valid

2011-08-05 Thread Chad Versace
On 08/05/2011 12:41 AM, Chia-I Wu wrote: On Fri, Aug 5, 2011 at 1:48 PM, Chad Versace c...@chad-versace.us wrote: Also, please update the commit message to say that `gcc --std=c99` allows empty declrations and include the appropriate quotation from the GLSL 1.20 spec's grammar. Without

Re: [Mesa-dev] [PATCH] glsl: empty declarations should be valid

2011-08-05 Thread Chad Versace
On 08/05/2011 11:45 AM, Paul Berry wrote: On 4 August 2011 18:18, Chad Versace c...@chad-versace.us wrote: On 08/04/2011 01:29 PM, Eric Anholt wrote: On Thu, 4 Aug 2011 12:59:35 +0900, Chia-I Wu olva...@gmail.com wrote: From: Chia-I Wu o...@lunarg.com Unlike C++, empty declarations

Re: [Mesa-dev] [PATCH 01/15] mesa: Add toplevel Android.mk

2011-08-05 Thread Chad Versace
On 08/05/2011 05:41 AM, Dan Nicholson wrote: On Thu, Aug 4, 2011 at 7:55 PM, Chad Versace c...@chad-versace.us wrote: On 08/04/2011 04:17 PM, Jose Fonseca wrote: - Original Message - On Thu, Aug 4, 2011 at 2:47 AM, Chad Versace c...@chad-versace.us wrote: This is the first step

Re: [Mesa-dev] [PATCH 00/15] i965, mesa, glapi: Build libi965_dri on Android

2011-08-05 Thread Chad Versace
On 08/04/2011 11:42 PM, Chia-I Wu wrote: On Fri, Aug 5, 2011 at 12:27 PM, Chad Versace c...@chad-versace.us wrote: On 08/04/2011 11:25 AM, Chia-I Wu wrote: Hi Chad, On Thu, Aug 4, 2011 at 6:47 PM, Chad Versace c...@chad-versace.us wrote: This is the first step in porting i965 to Android

Re: [Mesa-dev] upstreaming Android support [Was: i965, mesa, glapi: Build libi965_dri on Android]

2011-08-05 Thread Chad Versace
to handle the build system issue, when you email the patches please strip the makefiles out. Thanks. -- Chad Versace c...@chad-versace.us signature.asc Description: OpenPGP digital signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http

Re: [Mesa-dev] [PATCH] mesa: In validate_program(), initialize errMsg for safety.

2011-08-05 Thread Chad Versace
; - char errMsg[100]; + char errMsg[100] = ; shProg = _mesa_lookup_shader_program_err(ctx, program, glValidateProgram); if (!shProg) { Reviewed-by: Chad Versace c...@chad-versace.us -- Chad Versace c...@chad-versace.us signature.asc Description: OpenPGP digital signature

Re: [Mesa-dev] [PATCH 01/15] mesa: Add toplevel Android.mk

2011-08-08 Thread Chad Versace
On 08/07/2011 02:25 AM, Jose Fonseca wrote: - Original Message - On Sat, Aug 6, 2011 at 5:07 AM, Chad Versace c...@chad-versace.us wrote: On 08/05/2011 05:41 AM, Dan Nicholson wrote: I haven't seen any Android.mk files show up in freetype or expat or anything like that. In the same

[Mesa-dev] [PATCH] x86-64: Fix compile error with clang

2011-08-10 Thread Chad Versace
Remove the 'f' suffix from a float literal. - .float 0.0f+1.0 + .float 1.0 This fixes the following compile error with clang: error: unexpected token in directive .float 0.0f+1.0 ^ Signed-off-by: Chad Versace c...@chad-versace.us --- src/mesa/x86-64/xform4.S |2

Re: [Mesa-dev] [PATCH] mesa: Do not include fpu_control.h

2011-08-15 Thread Chad Versace
have no problem with removing it. -Brian I've posted a new patch that removes the debug bits too. According to `grep -ri fpu_`, that was the sole use of fpu_control.h. - -- Chad Versace c...@chad-versace.us -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG

[Mesa-dev] [PATCH 1/3] mesa: Add toplevel Android.mk

2011-08-16 Thread Chad Versace
. --disable-gallium --enable-32-bit --enable-gles2 --enable-gles1 --enable-texture-float --with-dri-drivers=i965 --with-gallium-drivers= Note: This is in preparation for porting i965 to Android. CC: Chia-I Wu o...@lunarg.com, Signed-off-by: Chad Versace c...@chad-versace.us

[Mesa-dev] [PATCH 2/3] mapi: Add -o option to mapi_abi.py

2011-08-16 Thread Chad Versace
...@lunarg.com, Signed-off-by: Chad Versace c...@chad-versace.us --- src/mapi/mapi/mapi_abi.py |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/src/mapi/mapi/mapi_abi.py b/src/mapi/mapi/mapi_abi.py index e3d3f65..23b3b5a 100644 --- a/src/mapi/mapi/mapi_abi.py +++ b/src

[Mesa-dev] [PATCH 3/3] glapi: Build libmesa_glapi on Android

2011-08-16 Thread Chad Versace
to prevent naming collisions in the build tree. (For an example, grep for `libc_` in bionic's Makefiles). Note: This is in preparation for porting i965 to Android. CC: Chia-I Wu o...@lunarg.com, Signed-off-by: Chad Versace c...@chad-versace.us --- Android.mk |2 + src

Re: [Mesa-dev] [PATCH 1/3] mesa: Add toplevel Android.mk

2011-08-16 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/16/2011 12:30 AM, Chia-I Wu wrote: Hi Chad, On Tue, Aug 16, 2011 at 2:14 PM, Chad Versace c...@chad-versace.us wrote: This is the first step in porting libGLES* and libEGL to Android. I also has a branch[1] that is ready for merge IMHO

Re: [Mesa-dev] [PATCH 1/3] mesa: Add toplevel Android.mk

2011-08-16 Thread Chad Versace
(I accidentally hit the send button mid-sentence on the last email. Please ignore it). On Tue, Aug 16, 2011 at 16:38, Chia-I Wu o...@lunarg.com wrote: On Wed, Aug 17, 2011 at 5:59 AM, Chad Versace c...@chad-versace.us wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/16/2011 12:30

Re: [Mesa-dev] [PATCH 01/18] mesa: fix !FEATURE_GL build

2011-08-17 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Reviewed-by: Chad Versace c...@chad-versace.us On 08/16/2011 11:28 PM, Chia-I Wu wrote: Move vbo_exec_FlushVertices_internal out of FEATURE_beginend. --- src/mesa/vbo/vbo_exec_api.c | 36 ++-- 1 files changed

Re: [Mesa-dev] [PATCH 02/18] glsl: remove an unnecessary header include

2011-08-17 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Reviewed-by: Chad Versace c...@chad-versace.us On 08/16/2011 11:28 PM, Chia-I Wu wrote: --- src/glsl/main.cpp |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/src/glsl/main.cpp b/src/glsl/main.cpp index 9b8a507..0192137

Re: [Mesa-dev] [PATCH 04/18] ralloc: SIZE_MAX is missing on Android

2011-08-17 Thread Chad Versace
:#include machine/limits.h include/limits.h:#include sys/limits.h - -- Chad Versace c...@chad-versace.us -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBAgAGBQJOS+wbAAoJEAIvNt057x8ierUQAJgnbYYKyj9wxkTqs6nUb3r4

Re: [Mesa-dev] [PATCH 06/18] egl: add _EGL_PLATFORM_ANDROID

2011-08-17 Thread Chad Versace
, this is Reviewed-by: Chad Versace c...@chad-versace.us #elif defined(__unix__) || defined(__unix) #ifdef MESA_EGL_NO_X11_HEADERS diff --git a/src/egl/main/egldisplay.c b/src/egl/main/egldisplay.c index 512ad50..1d05e57 100644 --- a/src/egl/main/egldisplay.c +++ b/src/egl/main/egldisplay.c @@ -72,7

<    1   2   3   4   5   6   7   8   9   10   >