Re: [Mesa-dev] [PATCH] Return corresponding offset of EGLImage instead of 0.

Weng <chuanbo.w...@intel.com> LGTM :) Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > --- > include/GL/internal/dri_interface.h | 2 ++ > src/egl/drivers/dri2/egl_dri2.c | 3 ++- > src/mesa/drivers/dri/i965/intel_screen.c | 3 +++ > 3

[Mesa-dev] [PATCH 1/2] i965: remove unnecessary `if`

if (x) return true; else return false; can be simplified as: return x; since both `x` are already boolean expressions. Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- src/mesa/drivers/dri/i965/intel_screen.c | 8 ++-- 1 file changed, 2 insertions(+), 6 del

[Mesa-dev] [PATCH] ilo: move `const` attribute to be useful

The duplicate `const` was simply being ignored, but const'ing the pointer can be a weak but useful protection, so let's do that instead. Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- src/gallium/drivers/ilo/core/ilo_state_raster.c | 2 +- 1 file changed, 1 insertion

Re: [Mesa-dev] [PATCH] glsl: fix heap-buffer-overflow

cludes the final '\0' in the move to terminate the string. What's happening is that since we start the move at `end+1`, the length becomes off by one. With that fixed, this is: Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> That said, a better fix IMO would be: - memmo

Re: [Mesa-dev] [PATCH v4] i965: Prevent coverity warning

On Wednesday, 2017-02-01 11:24:39 -0500, Robert Foss wrote: > Add assert checking that num_sources is never larger than 3. > > This prevents Coverity from concluding that the unhandled > cases of num_sources not being 0-3 are relevant. > > Coverity-Id: 1399480-1399489 > Signed-off-by: Robert

[Mesa-dev] [PATCH mesa 2/2] etnaviv: fix boolean test

CID: 1400128 Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- src/gallium/drivers/etnaviv/etnaviv_screen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/etnaviv/etnaviv_screen.c b/src/gallium/drivers/etnaviv/etnaviv_screen.c index 8f28

[Mesa-dev] [PATCH mesa 1/2] etnaviv: avoid null dereference in failure path

CID: 1400129 Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- src/gallium/drivers/etnaviv/etnaviv_context.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/etnaviv/etnaviv_context.c b/src/gallium/drivers/etnaviv/etnaviv_context.c index d767

Re: [Mesa-dev] [PATCH 2/2] docs: update intro.html to mention new APIs, etc

Thanks Brian! I would've used https for the links, but I'll just fix that later. Series is: Reviewed-by: Eric Engestrom <e...@engestrom.ch> And pushed :) On Wednesday, 2017-02-08 12:31:44 -0700, Brian Paul wrote: > --- > docs/intro.html | 42 +++

[Mesa-dev] [PATCH mesa 3/3] docs: https all the links \o/

Most of them already redirected to https anyway, so we might as well avoid the redirection and the security implications by linking directly to the right protocol. Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- docs/README.WIN32 | 2 +- docs/application-issue

[Mesa-dev] [PATCH mesa 1/3] docs: update 'thanks' for hosting

Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- docs/thanks.html | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/docs/thanks.html b/docs/thanks.html index 685cb31e64..bca4b3424f 100644 --- a/docs/thanks.html +++ b/docs/thanks.html @@ -40,14

[Mesa-dev] [PATCH mesa 2/3] docs: fix gallium wiki link in relnotes

Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- docs/relnotes/7.5.1.html | 2 +- docs/relnotes/7.5.2.html | 2 +- docs/relnotes/7.5.html | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/relnotes/7.5.1.html b/docs/relnotes/7.5.1.html index cf5a5691de..5afd

[Mesa-dev] [PATCH mesa 0/4] docs: update download page

This page was severely out of date... essentially everything was wrong by now :P Eric Engestrom (4): docs: add a note about the new version scheme docs: remove dead 'beta' link docs: fix unpacking instructions docs: update package contents docs/download.html | 39

[Mesa-dev] [PATCH mesa 2/4] docs: remove dead 'beta' link

Release candidates haven't been in a 'beta' subdir in a long time, so let's replace the dead link with an explanation instead. Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- docs/download.html | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/downloa

[Mesa-dev] [PATCH mesa 4/4] docs: update package contents

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- Do we want to list all the modules under src/ ? The current list seems a bit arbitrary: src/- source code for libraries src/mesa- sources for the main Mesa library and device drivers src/gallium - s

[Mesa-dev] [PATCH mesa 1/4] docs: add a note about the new version scheme

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- docs/download.html | 8 1 file changed, 8 insertions(+) diff --git a/docs/download.html b/docs/download.html index e90c1bbbf2..1cbfded575 100644 --- a/docs/download.html +++ b/docs/download.html @@ -24,6

[Mesa-dev] [PATCH mesa 3/4] docs: fix unpacking instructions

File names were wrong, file formats were wrong, bunzip command was wrong... I also removed all but the simplest example; people who use pipes already know how to untar, so let's simplify and remove potential confusion for non-tech-savvy users. Signed-off-by: Eric Engestrom <eric.eng

Re: [Mesa-dev] [RFC] EGL extension for additional DRM_BUFFER_FORMATs

pec says, the code looks good and the enum are in Mesa's private range, so patches #2 & #3 are: Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > > On 26.01.2017 12:50, Nicolai Hähnle wrote: > > Hi all, > > > > this is mostly motivated by the need to sup

Re: [Mesa-dev] [PATCH] gbm-dri: Duplicate image after checking its format.

; not being destroyed. > > Signed-off-by: Mateusz Polrola <mateuszx.potr...@intel.com> You are correct, so this patch is: Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> However, when I looked at the code, it looks like a lot more places leak `image`. I'll send another

[Mesa-dev] [PATCH mesa] gbm/dri: fix memory leaks in error path

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- src/gbm/backends/dri/gbm_dri.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/gbm/backends/dri/gbm_dri.c b/src/gbm/backends/dri/gbm_dri.c index 45cb42a862..ef96185848 100644 --- a/src/gbm/backen

Re: [Mesa-dev] [PATCH mesa] drirc: remove spurious tabs

On Friday, 2017-01-06 19:08:39 +1100, Edward O'Callaghan wrote: > Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> Thanks; can you push this for me please? Cheers, Eric > > On 01/06/2017 08:06 AM, Eric Engestrom wrote: > > Signed-off-by: Eric Engestr

[Mesa-dev] [PATCH mesa 2/2] egl: EGL_PLATFORM_SURFACELESS_MESA is now upstream

EGL_PLATFORM_SURFACELESS_MESA is in eglext.h as of last commit. Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- include/EGL/eglmesaext.h | 5 - 1 file changed, 5 deletions(-) diff --git a/include/EGL/eglmesaext.h b/include/EGL/eglmesaext.h index 405d0e9ee4..3a1b88e3d1

[Mesa-dev] [PATCH mesa 1/2] egl: update headers from registry

Khronos introduced a new macro (suggested by Google) to avoid using C-style casts in C++ code, as those generate warnings. Khronos Bugzilla: https://cvs.khronos.org/bugzilla/show_bug.cgi?id=16113 Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- include/EGL/egl.h

Re: [Mesa-dev] [PATCH 1/9] android: always set __STDC_*_MACROS for C++ sources

the workarounds through the code. > > Cc: Rob Herring <r...@kernel.org> > Cc: Chih-Wei Huang <cwhu...@android-x86.org> > Signed-off-by: Emil Velikov <emil.veli...@collabora.com> Assuming android and scons behave as expected, the series is:

Re: [Mesa-dev] [PATCH] anv: don't assert on out of memory descriptor pool in debug mode

On Thursday, 2017-01-26 11:27:00 +, Lionel Landwerlin wrote: > Fixes: >dEQP-VK.api.descriptor_pool.out_of_pool_memory > > Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> But is there any r

[Mesa-dev] [PATCH mesa 1/2] anv: add missing core errors in vk_errorf()

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- src/intel/vulkan/anv_util.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/intel/vulkan/anv_util.c b/src/intel/vulkan/anv_util.c index 5fbc7cc113..289d01ecb0 100644 --- a/src/intel/vulkan/anv_util.c +++ b/src/intel/

[Mesa-dev] [PATCH mesa 2/2] anv: add missing extension errors in vk_errorf()

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- Feel free to reject this if you prefer to add extension errors when each extension is implemented :) --- src/intel/vulkan/anv_util.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/intel/vulkan/anv_util.c b/src

[Mesa-dev] [PATCH mesa 1/2] radv: add missing core errors in vk_errorf()

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- Similar to the anvil series: https://lists.freedesktop.org/archives/mesa-dev/2017-January/142187.html --- src/amd/vulkan/radv_util.c | 4 1 file changed, 4 insertions(+) diff --git a/src/amd/vulkan/radv_util.c b/src/amd/

[Mesa-dev] [PATCH mesa 2/2] radv: add missing extension errors in vk_errorf()

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- Feel free to reject this if you prefer to add extension errors when each extension is implemented :) --- src/amd/vulkan/radv_util.c | 8 1 file changed, 8 insertions(+) diff --git a/src/amd/vulkan/radv_util.c b/src/amd/

[Mesa-dev] [PATCH mesa] docs/repository: fix name of main branch

This is git, not svn :P Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- I also noticed some difference between this file and the one on mesa3d.org; it might be worth making sure everything is sync'ed between the two (most likely just push the version on git to the web

Re: [Mesa-dev] Directly using upstream headers (Was Re: [PATCH] vulkan: Don't install vk_platform.h or vulkan.h.)

On Thursday, 2017-01-26 18:54:59 +, Emil Velikov wrote: > On 25 January 2017 at 22:10, Chad Versace wrote: > > On Tue 24 Jan 2017, Jason Ekstrand wrote: > >> On Tue, Jan 24, 2017 at 11:25 AM, Emil Velikov > > >> > I'd rather not. That

Re: [Mesa-dev] [PATCH] anv: handle VK_ERROR_OUT_OF_POOL_MEMORY_KHR error

On Friday, 2017-01-27 17:00:18 +0100, Juan A. Suarez Romero wrote: > This fixes dEQP-VK.api.descriptor_pool.out_of_pool_memory test > > Signed-off-by: Juan A. Suarez Romero Thanks, this is correct, but Lionel Landwerlin already sent [1] a more complete patch. Lionel, can

[Mesa-dev] [PATCH mesa v2] gbm/dri: fix memory leaks in error path

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- v2: add another missing destroy (Emil) --- src/gbm/backends/dri/gbm_dri.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/gbm/backends/dri/gbm_dri.c b/src/gbm/backends/dri/gbm_dri.c index 45cb

Re: [Mesa-dev] [PATCH] docs/releasing.html: reword "distro breaking changes" hunk

On Tuesday, 2017-02-21 09:41:18 +0100, Nicolai Hähnle wrote: > On 20.02.2017 20:27, Emil Velikov wrote: > > From: Emil Velikov <emil.veli...@collabora.com> > > > > Suggested-by: Eric Engestrom <eric.engest...@imgtec.com> > > Signed-off-by: E

[Mesa-dev] [PATCH mesa 3/5] gallium/docs: add missing newlines

Without these, mathjax considers these as the continuation of the previous line. Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- src/gallium/docs/source/tgsi.rst | 33 + 1 file changed, 33 insertions(+) diff --git a/src/gallium/docs/source/tg

[Mesa-dev] [PATCH mesa 0/5] gallium/docs: formatting fixes

Rob Clark <robcl...@freedesktop.org> Eric Engestrom (5): gallium/docs: fix sublist formatting gallium/docs: add missing math formatting gallium/docs: add missing newlines gallium/docs: fix section title formatting gallium/docs: use imgmath instead of pngmath src/gallium/docs/source/

[Mesa-dev] [PATCH mesa 5/5] gallium/docs: use imgmath instead of pngmath

WARNING: sphinx.ext.pngmath has been deprecated. Please use sphinx.ext.imgmath instead. Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- src/gallium/docs/source/conf.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/docs/

[Mesa-dev] [PATCH mesa 1/5] gallium/docs: fix sublist formatting

src/gallium/docs/source/context.rst:95: ERROR: Unexpected indentation. Sub lists need to be surrounded by a blank line. Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- src/gallium/docs/source/context.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/g

[Mesa-dev] [PATCH mesa 2/5] gallium/docs: add missing math formatting

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- src/gallium/docs/source/tgsi.rst | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/docs/source/tgsi.rst b/src/gallium/docs/source/tgsi.rst index c296447b5c..b9b9d6ca34 100644 --- a/src/gallium/docs/source/tg

[Mesa-dev] [PATCH mesa 4/5] gallium/docs: fix section title formatting

src/gallium/docs/source/tgsi.rst:3488: WARNING: Title underline too short. Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- src/gallium/docs/source/tgsi.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/docs/source/tgsi.rst

[Mesa-dev] [PATCH mesa v2] glx: add GLXdispatchIndex sort check

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- v2: make sure the list is in the order C's strcmp uses (Ilia) Ilia: I used LC_ALL instead of LANG, as it takes precedence (ie. LANG=C in this script would be overridden by LC_ALL=en_US in the envir

[Mesa-dev] [PATCH mesa 3/9] eglapi: add entrypoint for eglClientWaitSyncKHR

Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- src/egl/main/eglapi.c | 31 --- 1 file changed, 24 insertions(+), 7 deletions(-) diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c index e149c0f8d1..e44375a106 100644 --- a/src/egl/main/eglapi.c +++

[Mesa-dev] [PATCH mesa v2 6/9] eglapi: move entrypoints list out to its own file

This will allow us to make sure the list is always sorted in the next commit. Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- v2: use .h extension for the new file, and track it in LIBEGL_C_FILES (Emil) --- src/egl/Makefile.sources | 1 + src/egl/main/eglapi.c

[Mesa-dev] [PATCH mesa 2/9] eglapi: add entrypoint for eglDestroySyncKHR

Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- src/egl/main/eglapi.c | 28 +--- 1 file changed, 21 insertions(+), 7 deletions(-) diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c index 251855cc3b..e149c0f8d1 100644 --- a/src/egl/main/eglapi.c +++ b/s

[Mesa-dev] [PATCH mesa] egl/dri3: implement query surface hook

From: Brendan King This is a DRI3 version of a change made for DRI2 (4d6d4f939e0af4252e0b, "egl/dri2: implement query surface hook"), that fixed failures in dEQP-EGL.functional.resize.surface_size.grow and dEQP-EGL.functional.resize.surface_size.shrink. Cc: Tapani Pälli

[Mesa-dev] mesa3d.org is now synced to docs/

Hey all, I (finally) set up the git hook, which means that the website [1] is now automagically updated whenever a change in docs/* on master is pushed. There might be bugs, and I'll be doing some other git hook related changes later on; if you see anything weird when pushing or if the website's

Re: [Mesa-dev] [PATCH v2 6/14] anv: convert header generation in anv_entrypoints_gen.py to mako

On Thursday, 2017-02-23 10:46:19 -0800, Dylan Baker wrote: > This produces an identical file except for whitespace. > > Signed-off-by: Dylan Baker > --- > src/intel/vulkan/anv_entrypoints_gen.py | 75 ++ > 1 file changed, 41 insertions(+), 34

Re: [Mesa-dev] [PATCH v2 8/14] anv: generate anv_entrypoints.{h, c} in one command

On Thursday, 2017-02-23 10:46:21 -0800, Dylan Baker wrote: > This changes the python generator to write the files itself, rather than > piping them out. This has a couple of advantages: first, it encapsulates > the encoding. Second, it ensures that the header file and code file are > generated at

Re: [Mesa-dev] [PATCH 1/4] glsl/tests/optimisation-test: make sure that $PYTHON2 is set/available

On Thursday, 2017-02-23 16:43:07 +, Emil Velikov wrote: > From: Emil Velikov > > Otherwise we'll fail when invoking the script outside of "make check" > > Signed-off-by: Emil Velikov > --- > src/compiler/glsl/tests/optimization-test

Re: [Mesa-dev] [PATCH mesa v2] glx: add GLXdispatchIndex sort check

On Friday, 2017-02-24 16:46:36 +, Emil Velikov wrote: > On 24 February 2017 at 14:58, Eric Engestrom <eric.engest...@imgtec.com> > wrote: > > On Thursday, 2017-02-23 16:07:36 +, Emil Velikov wrote: > >> You're a star Eric, thank you ! > >> > >>

Re: [Mesa-dev] [PATCH 4/4] glsl/tests/optimization-test: correctly manage srcdir/pwd and co

On Thursday, 2017-02-23 16:43:10 +, Emil Velikov wrote: > From: Emil Velikov > > At the moment things are completely bonkers (as can be seen from last > commit). Regardless if we run the test as part of "make check" or > standalone the most of the paths are wrong.

Re: [Mesa-dev] [PATCH 3/4] glsl/tests/optimization-test: error out if we fail to generate any tests

.py; cd .. > +cd $dir; > +$PYTHON2 create_test_cases.py > +if [ "x$?" = x0 ]; then if $PYTHON2 create_test_cases.py; then ... With or without these nit-pick, patches 1-3 are: Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > +has_

Re: [Mesa-dev] [PATCH 2/4] glsl/tests/optimisation-test: ensure that compare_ir is available

On Thursday, 2017-02-23 16:43:08 +, Emil Velikov wrote: > From: Emil Velikov > > Bail out early if the script is not where we expect it to be. > > Signed-off-by: Emil Velikov > --- > src/compiler/glsl/tests/optimization-test | 5

Re: [Mesa-dev] [PATCH mesa v2] glx: add GLXdispatchIndex sort check

On Thursday, 2017-02-23 16:07:36 +, Emil Velikov wrote: > You're a star Eric, thank you ! > > On 22 February 2017 at 11:24, Eric Engestrom <eric.engest...@imgtec.com> > wrote: > > Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> > > --- > >

[Mesa-dev] [PATCH mesa 1/8] eglapi: add entrypoint for eglDestroyImageKHR

Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- src/egl/main/eglapi.c | 28 +--- 1 file changed, 21 insertions(+), 7 deletions(-) diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c index cab05c2301..251855cc3b 100644 --- a/src/egl/main/eglapi.c +++ b/s

[Mesa-dev] [PATCH mesa 2/8] eglapi: add entrypoint for eglDestroySyncKHR

Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- src/egl/main/eglapi.c | 28 +--- 1 file changed, 21 insertions(+), 7 deletions(-) diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c index 251855cc3b..e149c0f8d1 100644 --- a/src/egl/main/eglapi.c +++ b/s

[Mesa-dev] [PATCH mesa 6/8] eglapi: move list out to its own file

This will allow us to make sure the list is always sorted in the next commit. Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- src/egl/main/eglapi.c | 78 +- src/egl/main/eglentrypoint.def | 77 ++

[Mesa-dev] [PATCH mesa 3/8] eglapi: add entrypoint for eglClientWaitSyncKHR

Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- src/egl/main/eglapi.c | 31 --- 1 file changed, 24 insertions(+), 7 deletions(-) diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c index e149c0f8d1..e44375a106 100644 --- a/src/egl/main/eglapi.c +++

[Mesa-dev] [PATCH mesa 8/8] eglapi: replace linear entrypoint search with binary search

Tested with dEQP-EGL.functional.get_proc_address.* Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- src/egl/main/eglapi.c | 37 - 1 file changed, 24 insertions(+), 13 deletions(-) diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c

[Mesa-dev] [PATCH mesa 7/8] eglapi: make sure list is always sorted

Starting with the next commit, badly sorting this list will break the eglGetProcAddress(). Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- src/egl/Makefile.am | 3 ++- src/egl/egl-entrypoint-check | 4 2 files changed, 6 insertions(+), 1 deletion(-) create mode 1007

[Mesa-dev] [PATCH mesa 5/8] eglapi: sort list

Let's make that comment true. If will also be necessary in a couple commits (using bsearch). Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- src/egl/main/eglapi.c | 74 +-- 1 file changed, 37 insertions(+), 37 deletions(-) diff --git

[Mesa-dev] [PATCH mesa 4/8] eglapi: use macro to map entrypoints to functions

As of the last 3 commits, there's a function for each entrypoint. Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- src/egl/main/eglapi.c | 149 +- 1 file changed, 75 insertions(+), 74 deletions(-) diff --git a/src/egl/main/eglapi.c b/s

Re: [Mesa-dev] [PATCH mesa 3/8] eglapi: add entrypoint for eglClientWaitSyncKHR

out, but honestly I just thought this looked cleaner. Also, I think the debug extension would print the wrong function names before these patches? Not tested though, maybe it somehow worked. > > On Sun, Feb 19, 2017 at 6:23 PM, Eric Engestrom <e...@engestrom.ch> wrote: > >

Re: [Mesa-dev] [PATCH mesa 8/8] eglapi: replace linear entrypoint search with binary search

On Sunday, 2017-02-19 15:38:05 -0800, Matt Turner wrote: > On Sun, Feb 19, 2017 at 3:23 PM, Eric Engestrom <e...@engestrom.ch> wrote: > > Tested with dEQP-EGL.functional.get_proc_address.* > > > > Signed-off-by: Eric Engestrom <e...@engestrom.ch> > &

Re: [Mesa-dev] [PATCH mesa 3/8] eglapi: add entrypoint for eglClientWaitSyncKHR

On Sunday, 2017-02-19 18:54:51 -0500, Ilia Mirkin wrote: > On Sun, Feb 19, 2017 at 6:51 PM, Eric Engestrom <e...@engestrom.ch> wrote: > > On Sunday, 2017-02-19 18:33:16 -0500, Ilia Mirkin wrote: > >> Why are patches 1-3 necessary? > > > > They allow patch #4, wh

[Mesa-dev] [PATCH mesa] glx: add GLXdispatchIndex sort check

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- src/glx/tests/Makefile.am | 2 +- src/glx/tests/dispatch-index-check | 24 2 files changed, 25 insertions(+), 1 deletion(-) create mode 100755 src/glx/tests/dispatch-index-check diff --git a/s

Re: [Mesa-dev] [PATCH mesa 7/8] eglapi: make sure list is always sorted

On Monday, 2017-02-20 19:49:59 +, Emil Velikov wrote: > On 19 February 2017 at 23:23, Eric Engestrom <e...@engestrom.ch> wrote: > > Starting with the next commit, badly sorting this list will break the > > eglGetProcAddress(). > > > > Signed-off-by:

[Mesa-dev] [PATCH mesa 9/9] eglapi: replace linear entrypoint search with binary search

Tested with dEQP-EGL.functional.get_proc_address.* Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- src/egl/main/eglapi.c | 37 - 1 file changed, 24 insertions(+), 13 deletions(-) diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c

[Mesa-dev] [PATCH mesa 1/9] eglapi: add entrypoint for eglDestroyImageKHR

Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- Note for Ilia: I'm not opposed to removing the first 3 patches and adding a macro for the special cases, but I'll wait until someone else wants it too. And if the request comes after this lands, these 3 patches are easy enough to revert

[Mesa-dev] [PATCH mesa v2 8/9] egl: make sure entrypoints list is always sorted

Starting with the next commit, badly sorting this list will break the eglGetProcAddress(). Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- v2: use sh instead of bash (Emil) --- src/egl/Makefile.am | 3 ++- src/egl/egl-entrypoint-check | 5 + 2 files changed, 7 insertions

[Mesa-dev] [PATCH mesa 4/9] eglapi: use macro to map entrypoints to functions

As of the last 3 commits, there's a function for each entrypoint. Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- src/egl/main/eglapi.c | 149 +- 1 file changed, 75 insertions(+), 74 deletions(-) diff --git a/src/egl/main/eglapi.c b/s

[Mesa-dev] [PATCH mesa 5/9] eglapi: sort entrypoints list

Let's make that comment true. If will also be necessary in a couple commits (using bsearch). Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- src/egl/main/eglapi.c | 74 +-- 1 file changed, 37 insertions(+), 37 deletions(-) diff --git

[Mesa-dev] [PATCH mesa 7/9] egl: distribute all tests

Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- src/egl/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/egl/Makefile.am b/src/egl/Makefile.am index bd8903f666..d36a786ab4 100644 --- a/src/egl/Makefile.am +++ b/src/egl/Makefile.am @@ -129,7

Re: [Mesa-dev] [PATCH 3/6] docs/releasing: update the website section

On Monday, 2017-02-13 13:42:20 +, Emil Velikov wrote: > From: Emil Velikov <emil.vel...@collabora.com> > > Things are automated via git hooks. > > Cc: Brian Paul <bri...@vmware.com> > Cc: Eric Engestrom <eric.engest...@imgtec.com> > Signed-off-by: E

[Mesa-dev] [PATCH mesa] docs: fix gamma correction link

That link has been dead for 15 years... We could link to Archive.org [1] to get the last time this page existed, but I feel like Wikipedia is a better choice. [1] http://web.archive.org/web/20021211151318/http://www.inforamp.net/~poynton/notes/colour_and_gamma/GammaFAQ.html Signed-off-by: Eric

Re: [Mesa-dev] [PATCH 4/6] docs: add hyperlink to the releasing documentation

On Monday, 2017-02-13 13:42:21 +, Emil Velikov wrote: > From: Emil Velikov > I just noticed xlibdriver.html and versions.html are also missing from contents.html, if you want to add them as well :) > Signed-off-by: Emil Velikov > ---

Re: [Mesa-dev] [PATCH 2/3] etnaviv: move pctx initialisation to avoid a null dereference

L; > > + pctx = >base; With this, you can also drop the `pctx = NULL` a couple lines above. Series is: Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> Cheers, Eric > + pctx->priv = ctx; > + pctx->screen = pscreen; > + > screen = etna_screen(

Re: [Mesa-dev] [PATCH] loader: unconditionally include unistd.h and stdlib.h

"loader: Add an environment variable to override driver > name choice. Missing ") These are posix headers, so I'm assuming *BSD systems won't be affected? Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=997

Re: [Mesa-dev] Allow linear texture allocation for eglCreateDRMImageMESA

On Friday, 2017-02-10 09:27:51 +0100, Volker Vogelhuber wrote: > Hi, > I'm currently try to stream video data to an OpenGL texture. > While using the EGL_DRM_BUFFER_USE_SCANOUT_MESA flag > when creating the memory for the texture makes it at least > a bit easier (only X-tiling instead of Y-tiling

Re: [Mesa-dev] [PATCH 2/6] docs/releasing: tweak the glxinfo/glxgear/etc. command lines

On Monday, 2017-02-13 13:42:19 +, Emil Velikov wrote: > From: Emil Velikov > > Print only the information needed. Namely: > *info: the DRI module picked and the vendor/renderer strings > *gears: everything but the "...configuration file..." line(s) > >

Re: [Mesa-dev] [PATCH] glx/glvnd: Fix GLXdispatchIndex sorting

d > games not working. > > Fixes: 8bca8d89ef3b ("glx/glvnd: Fix dispatch function names and indices") > Cc: "13.0" <mesa-sta...@lists.freedesktop.org> > Cc: "17.0" <mesa-sta...@lists.freedesktop.org> > Cc: Adam Jackson <

[Mesa-dev] [PATCH mesa] docs: add link to gallium doc

Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- docs/sourcedocs.html | 5 + 1 file changed, 5 insertions(+) diff --git a/docs/sourcedocs.html b/docs/sourcedocs.html index 454ea7d677..660dcb2ef0 100644 --- a/docs/sourcedocs.html +++ b/docs/sourcedocs.html @@ -41,6 +41,11 @@

[Mesa-dev] [PATCH mesa] egl: remove duplicate 0 assignment

From: Eric Engestrom <eric.engest...@imgtec.com> The memset on the line before already takes care of this. Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- src/egl/main/eglimage.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/egl/main/eglimage.c b/

[Mesa-dev] [PATCH mesa v2] docs: fix gamma correction link

From: Eric Engestrom <eric.engest...@imgtec.com> That link has been dead for 15 years... We could link to Archive.org [1] to get the last time this page existed, but I feel like Wikipedia is a better choice. [1] http://web.archive.org/web/20021211151318/http://www.inforamp.net/~poynton

Re: [Mesa-dev] [PATCH] util/disk_cache: error check asprintf()

Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> On Thursday, 2017-02-09 22:42:51 +1100, Timothy Arceri wrote: > --- > src/util/disk_cache.c | 12 +++- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/src/util/disk_cache.c b/src/util/disk_ca

[Mesa-dev] [PATCH mesa] docs: reword sentence that my brain can't parse

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- docs/egl.html | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/egl.html b/docs/egl.html index 6868448bc4..c22aa4a338 100644 --- a/docs/egl.html +++ b/docs/egl.html @@ -83,9 +83,9 @@ List the pla

Re: [Mesa-dev] [PATCH] util: Fix a typo in Makefile.sources

Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> On Wednesday, 2017-02-15 09:30:01 -0800, Jason Ekstrand wrote: > --- > src/util/Makefile.sources | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/util/Makefile.sources b/src/util/Makefile.so

Re: [Mesa-dev] [PATCH] egl: _eglFilterArray's filter is always non-null

On Wednesday, 2017-02-15 15:36:00 +, Emil Velikov wrote: > From: Emil Velikov <emil.veli...@collabora.com> > > Drop the extra handling and assert() if things change in the future. > > Signed-off-by: Emil Velikov <emil.veli...@collabora.com> Reviewed-by:

Re: [Mesa-dev] [PATCH] anv: Give the installed intel_icd.json file an absolute path

> provide a filename. Distros can carry a revert of this commit if they want > an intel_icd.json file without the path. > > Signed-off-by: Jason Ekstrand <ja...@jlekstrand.net> > Cc: Mark Janes <mark.a.ja...@intel.com> I have one question (below), but this patch is good reg

[Mesa-dev] [PATCH mesa] st/va: add missing mutex_unlock

Fixes: c59628d11b134fc01638 ("st/va: enable dual instances encode by sync surface") Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- src/gallium/state_trackers/va/surface.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/va/

Re: [Mesa-dev] [PATCH mesa] st/va: add missing mutex_unlock

CC'ing Boyuan Zhang (author of the original patch), who got somehow removed from the CC list when sending my patch. On Sun, Aug 21, 2016 at 10:11:48PM +0100, Eric Engestrom wrote: > Fixes: c59628d11b134fc01638 ("st/va: enable dual instances encode by sync > surface") >

Re: [Mesa-dev] [PATCH] glx/tests: Fix bash-specific code in dispatch-index-check

On Friday, 2017-02-24 22:03:36 -0600, Aaron Watry wrote: > Using <<< for variable redirection is bash-specific behavior. > Ubuntu redirects sh -> dash, so this was erroring out. > > Also, the initial error that led me to this was that srcdir is null when > running make check > so I just copied

Re: [Mesa-dev] [PATCH] android: vulkan: add support for libmesa_vulkan_{util, wsi}

On Tuesday, 2017-02-28 14:06:14 +, Emil Velikov wrote: > On 28 February 2017 at 11:58, Eric Engestrom <eric.engest...@imgtec.com> > wrote: > > On Tuesday, 2017-02-28 01:31:01 +0100, Mauro Rossi wrote: > >> Thanks a lot for your feedbacks. > >> He

Re: [Mesa-dev] [PATCH] android: vulkan: add support for libmesa_vulkan_{util, wsi}

util/gen_enum_to_str.py > $(vulkan_api_xml) > $(MKDIR_GEN) > - $(PYTHON_GEN) $(srcdir)/util/gen_enum_to_str.py > + $(PYTHON_GEN) $(srcdir)/util/gen_enum_to_str.py -o > $(top_builddir)/src/vulkan/util Just like the other Makefile patch a few days ago, this rule will run the

Re: [Mesa-dev] problem on building vmwgfx

On Tuesday, 2017-02-28 14:04:15 +0100, Zhiguang Liu wrote: > Hi, > > I try to build vmwgfx on Ubuntu 12.04 with gcc-4.8.1, make 3.8.1. I clone > the source files using the following command: > > git clone git://anongit.freedesktop.org/git/mesa/vmwgfx > > However, when I use 'make' command to

Re: [Mesa-dev] problem on building vmwgfx

[1]: *** [_module_/home/zg/vmware/vmwgfx] Error 2 > make[1]: Leaving directory `/usr/src/linux-headers-3.13.0-108-generic' > make: *** [modules] Error 2 > > === Looks like there are more issues than I thought. I don't know this

[Mesa-dev] [PATCH mesa 2/5] egl: take new string into account when checking for overflow

Otherwise the check would detect that the previous append() resulted in a buffer overflow, which would not even be caught if the last extension in the string is the one that goes over (which is likely). Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- src/egl/main/eglapi.c | 3 ++-

[Mesa-dev] [PATCH mesa 4/5] egl: add assert on the max length of the extension string

Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- src/egl/main/eglapi.c | 4 1 file changed, 4 insertions(+) diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c index 274dcde01d..2d7077f88b 100644 --- a/src/egl/main/eglapi.c +++ b/src/egl/main/eglapi.c @@ -467,6

[Mesa-dev] [PATCH mesa 1/5] egl: move assert *before* the buffer overflow

Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- src/egl/main/eglapi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c index 5694b5a4ca..d964b4d289 100644 --- a/src/egl/main/eglapi.c +++ b/src/egl/main/eglapi.c @@

[Mesa-dev] [PATCH mesa 5/5] egl: remove space at the end of extension string

Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- src/egl/main/eglapi.c | 4 1 file changed, 4 insertions(+) diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c index 2d7077f88b..a7a1976535 100644 --- a/src/egl/main/eglapi.c +++ b/src/egl/main/eglapi.c @@ -529,6 +

[Mesa-dev] [PATCH mesa 3/5] egl: add note about checking the extension string length

The current string uses up to 910/1000 chars, so a couple more extensions will bring it over, but would go unnoticed if not tested with all extensions active. Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- src/egl/main/eglapi.c | 4 +++- 1 file changed, 3 insertions(+), 1 de

<    1   2   3   4   5   6   7   8   9   10   >