Re: [Mesa-dev] [PATCH v2] wayland-drm: static inline wayland_drm_buffer_get

On Tuesday, 2017-10-24 17:14:20 +0100, Emil Velikov wrote: > From: Emil Velikov > > The function is effectively a direct function call into > libwayland-server.so. > > Thus GBM no longer depends on the wayland-drm static library, making the > build more straight

Re: [Mesa-dev] [PATCH v2] wayland-drm: static inline wayland_drm_buffer_get

On Monday, 2017-10-30 13:39:00 +, Emil Velikov wrote: > On 30 October 2017 at 12:02, Eric Engestrom <eric.engest...@imgtec.com> wrote: > > On Tuesday, 2017-10-24 17:14:20 +0100, Emil Velikov wrote: > >> From: Emil Velikov <emil.veli...@collabora.com> > &g

[Mesa-dev] [PATCH mesa] i965: remove unused variable

Fixes: 2c873060d3578c7004c0 "i965: Delete unused brw_vs_prog_data::nr_attributes field." Cc: Kenneth Graunke <kenn...@whitecape.org> Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- src/intel/compiler/brw_vec4.cpp | 3 --- 1 file changed, 3 deletions(-)

Re: [Mesa-dev] [PATCH mesa] meson: bring MESA_GIT_SHA1 in line with other build systems

On Wednesday, 2017-10-25 00:02:49 -0700, Jordan Justen wrote: > On 2017-10-24 14:54:10, Eric Engestrom wrote: > > Meson's vcs_tag() uses the output of `git describe`, eg. > > 17.3-branchpoint-5-gfbf29c3cd15ae831e249+ > > > > Whereas the other build systems used

[Mesa-dev] [PATCH mesa] vc4: fix release build

Mesa's DEBUG and assert's NDEBUG are not tied to each other, so we need to explicitly compile this code out. Fixes: 3df78928786134874eafa "vc4: Drop reloc_count tracking for debug asserts on non-debug builds." Cc: Eric Anholt <e...@anholt.net> Signed-off-by: Eric Engest

Re: [Mesa-dev] [PATCH mesa] meson: be explicit about the version required

On Tuesday, 2017-10-24 14:48:25 -0700, Dylan Baker wrote: > Quoting Eric Engestrom (2017-10-24 10:32:36) > > On Tuesday, 2017-10-24 09:40:22 -0700, Dylan Baker wrote: > > > This seems reasonable, could you wrap the hanging indent like > > > meson_options with > >

Re: [Mesa-dev] [PATCH v3] egl/wayland: Support for KHR_partial_update

) > Add not supported list to commit message. (Eric Engestrom) > > v3: Remove explicit with_damage variable. (Eric Engestrom) > > Signed-off-by: Harish Krupo <harish.krupo@intel.com> > --- > src/egl/drivers/dri2/platform_wayland.c | 54 > ++-

Re: [Mesa-dev] [PATCH] meson: do not search for needless deps

it's logically a tiny bit better, but also makes the code a tiny bit more complicated, so I'm not sure what's best. Either way, this is a small change that looks good to me, and it really doesn't matter much, so: Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > >

Re: [Mesa-dev] [PATCH 7/9] meson: Add generated files to non-shared glapi

On Wednesday, 2017-10-25 15:58:21 -0700, Dylan Baker wrote: > Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> Series up to this patch is: Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > --- > src/mapi/glapi/meson.build | 3 +++ > 1 file changed, 3 inser

Re: [Mesa-dev] [PATCH 8/9] meson: build classic osmesa

+osmesa_link_with = [] > + > +if with_shared_glapi > + osmesa_link_with += libglapi > +endif > + > +libosmesa = shared_library( > + osmesa_lib_name, > + ['osmesa.c', glapitable_h, glapitemp_h], > + c_args : c_vis_args, > + cpp_args : cpp_vis_args, > + link_args

Re: [Mesa-dev] [PATCH 9/9] meson: build gallium based osmesa

> +libosmesa = shared_library( > + osmesa_lib_name, > + 'target.c', > + c_args : [c_vis_args, osmesa_comp_args], > + cpp_args : [cpp_vis_args, osmesa_comp_args], > + link_args : [ld_args_gc_sections, osmesa_link_args], > + include_directories : [ > +inc_include,

Re: [Mesa-dev] [PATCH] automake: intel: correctly append to the LIBADD variable

discarded from the link chain when > building with Android. > > Fixes: 05fc62d89f5 ("automake: intel: move expat handling where it's > used") > Cc: Hongxu Jia <hongxu@windriver.com> > Signed-off-by: Emil Velikov <emil.veli...@collabora.com> Reviewed-by

Re: [Mesa-dev] [PATCH 5/5] util: use OpenBSD/NetBSD code on FreeBSD/DragonFly

__DragonFly__) This is a long line, maybe split it there? ^ Cosmetics aside, this and patch 3 are Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > #include > #include > > -- > 2.14.2 > ___ mesa-dev mailing list mesa-

Re: [Mesa-dev] [PATCH 2/5] loader: use drmGetDeviceNameFromFd2 from libdrm

4.74, and we already require 2.4.75 globally, so this is fine. Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> That said, the drm_get_device_name_for_fd() function is now a plain alias for drmGetDeviceNameFromFd2(), and is only used in one place. Might as well drop it, but this can be

Re: [Mesa-dev] [PATCH 1/3] freedreno/ir3: use a flag instead of setting PYTHONPATH

ail.com> Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > --- > src/gallium/drivers/freedreno/Android.gen.mk | 2 +- > src/gallium/drivers/freedreno/Makefile.am | 2 +- > src/gallium/drivers/freedreno/ir3/ir3_nir_trig.py | 25 > +++--

Re: [Mesa-dev] [PATCH] gallium/util: use util_snprintf() in u_socket_connect()

On Monday, 2017-10-23 15:27:31 -0600, Brian Paul wrote: > Instead of plain snprintf(). To fix the MSVC build. > > snprintf() is used in various places in Mesa/gallium, but apparently, > not in code built with MSVC. Not sure I understand this sentence, but the patch is Revie

Re: [Mesa-dev] [PATCH] configure: Allow android as an EGL platform

On Monday, 2017-10-23 15:39:48 -0600, Benjamin Gordon wrote: > On Mon, Oct 23, 2017 at 11:10 AM, Eric Engestrom <eric.engest...@imgtec.com> > wrote: > > > On Friday, 2017-10-20 15:34:57 -0600, Benjamin Gordon wrote: > > > I'm working on radeonsi support in t

Re: [Mesa-dev] [PATCH 2/3] meson: extract out variable for nir_algebraic.py

_workarounds.c', >command : [prog_python2, '@INPUT@', '-p', > join_paths(meson.source_root(), 'src/compiler/nir/')], > - depend_files : files('../../compiler/nir/nir_algebraic.py'), > + depend_files : files(nir_algebraic_py), And this becomes: depend_files : nir_algebrai

[Mesa-dev] [PATCH mesa] meson: be explicit about the version required

This way, we know what we're allowed to use (no nested include lists for instance) and users get immediate feedback when trying to use unsupported versions, rather than a cryptic crash or things being silently not built correctly. Cc: Dylan Baker <dy...@pnwbakers.com> Signed-off-by

Re: [Mesa-dev] [PATCH v3] egl/wayland: Support for KHR_partial_update

found. > >>> > >>> v2: Remove unnecessary return statement. Keep function names > >>> consistent. (Emil Velikov) > >>> Add not supported list to commit message. (Eric Engestrom) > >>> > >>> v3: Remove explici

Re: [Mesa-dev] [PATCH 3/3] meson: build freedreno

> + command : [prog_python2, '@INPUT@', '-p', > + join_paths(meson.source_root(), 'src/compiler/nir/')], This is kind of ugly, but I don't think there's a better way of doing this :( > + capture : true, > + depend_files : files( > +'ir3/ir3_nir_trig.py', >

Re: [Mesa-dev] [PATCH mesa] meson: be explicit about the version required

I have no idea how much effort it would be to support some previous version. > > Quoting Eric Engestrom (2017-10-24 07:04:01) > > This way, we know what we're allowed to use (no nested include lists > > for instance) and users get immediate feedback when trying to use > > un

[Mesa-dev] [PATCH mesa] meson: bring MESA_GIT_SHA1 in line with other build systems

eson.build b/bin/meson.build new file mode 100644 index 00..b8b44baf7d --- /dev/null +++ b/bin/meson.build @@ -0,0 +1,21 @@ +# Copyright © 2017 Eric Engestrom + +# Permission is hereby granted, free of charge, to any person obtaining a copy +# of this software and associated documentation file

[Mesa-dev] [PATCH mesa] meson: bump libdrm version required by amdgpu

Fixes: f03b7c9ad92c1656a221 "winsys/amdgpu: Add R600_DEBUG flag to reserve VMID per ctx." Cc: Andrey Grodzovsky <andrey.grodzov...@amd.com> Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- meson.build | 2 +- 1 file changed, 1 in

[Mesa-dev] [PATCH mesa] travis: build meson first for quicker feedback

Meson is much quicker to build Mesa, giving quicker feedback if executed first. Cc: Dylan Baker <dy...@pnwbakers.com> Cc: Emil Velikov <emil.l.veli...@gmail.com> Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> ---

[Mesa-dev] [PATCH mesa] mapi: fix .so path in ABI-check

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- Didn't find when this was broken, but it looks like the tests had been silently ignored by `make check` for a long time... --- src/mapi/es1api/ABI-check | 2 +- src/mapi/es2api/ABI-check | 2 +- 2 files changed, 2 insertions

[Mesa-dev] [PATCH mesa] git_sha1_gen: create empty file in fallback path

I missed this part in my conversion, the old stream redirection meant the file was always created. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103496 Fixes: 7088622e5fb506b64c90 "buildsys: move file regeneration logic to the script itself" Signed-off-by: Eric En

Re: [Mesa-dev] [PATCH] meson: use dep_m in libgallium

On Monday, 2017-10-30 21:06:25 +0100, Erik Faye-Lund wrote: > The u_format_other.c users sqrtf, which on some systems require > a math-library. So let's make sure we link with it. > > Signed-off-by: Erik Faye-Lund <kusmab...@gmail.com> Reviewed-by: Eric Engestrom <eric.enge

Re: [Mesa-dev] [PATCH] meson: Use true and false instead of yes and no for tristate options

.com> > Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > --- > meson.build | 6 +++--- > meson_options.txt | 6 +++--- > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/meson.build

Re: [Mesa-dev] [PATCH 1/2] meson: do not search for needless deps

On Tuesday, 2017-10-31 11:37:25 +0100, Erik Faye-Lund wrote: > On Tue, Oct 31, 2017 at 11:24 AM, Eric Engestrom > <eric.engest...@imgtec.com> wrote: > > On Tuesday, 2017-10-31 08:29:28 +0100, Erik Faye-Lund wrote: > >> If we don't want to use these deps, there

[Mesa-dev] [PATCH mesa 04/11] gles1: fail symbol check if lib is missing

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- src/mapi/es1api/ABI-check | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/mapi/es1api/ABI-check b/src/mapi/es1api/ABI-check index 223658b32e08edf77558..25970bc41419eac5b544 100755 --- a/src/mapi/

[Mesa-dev] [PATCH mesa 01/11] egl: fail symbol check if lib is missing

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- src/egl/egl-symbols-check | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/egl/egl-symbols-check b/src/egl/egl-symbols-check index 4c5232cb6c031397b423..ae867d04bca91f22b070 100755 --- a/src/e

[Mesa-dev] [PATCH mesa 00/11] fix tests

and gbm-symbols-check are still failing, because of too many symbols exposed (Dylan's patch [1] removes one of the gbm ones). [1] https://lists.freedesktop.org/archives/mesa-dev/2017-October/174804.html Eric Engestrom (11): egl: fail symbol check if lib is missing wayland-egl: fail symbol check

[Mesa-dev] [PATCH mesa 03/11] gbm: fail symbol check if lib is missing

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- src/gbm/gbm-symbols-check | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/gbm/gbm-symbols-check b/src/gbm/gbm-symbols-check index 2444131e990228513d8f..cf57a08d5728cfff480c 100755 --- a/src/g

[Mesa-dev] [PATCH mesa 05/11] gles2: fail symbol check if lib is missing

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- src/mapi/es2api/ABI-check | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/mapi/es2api/ABI-check b/src/mapi/es2api/ABI-check index 5c9e82662461ab367ef3..2c2764e7fb94fb9494d2 100755 --- a/src/mapi/

[Mesa-dev] [PATCH mesa 07/11] automake+meson: don't run egl symbol check on libglvnd lib

We might want to add a symbol check for the glvnd variant though. Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- src/egl/Makefile.am | 9 +++-- src/egl/meson.build | 12 2 files changed, 15 insertions(+), 6 deletions(-) diff --git a/src/egl/Makefile.am b/s

[Mesa-dev] [PATCH mesa 08/11] meson: pass correct args to wayland-egl symbol test

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- src/egl/wayland/wayland-egl/meson.build | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/egl/wayland/wayland-egl/meson.build b/src/egl/wayland/wayland-egl/meson.build index f380e96ee32d7f

[Mesa-dev] [PATCH mesa 02/11] wayland-egl: fail symbol check if lib is missing

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- src/egl/wayland/wayland-egl/wayland-egl-symbols-check | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/egl/wayland/wayland-egl/wayland-egl-symbols-check b/src/egl/wayland/wayland-egl/wayla

[Mesa-dev] [PATCH mesa 11/11] meson: pass correct args to gles2 ABI test

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- src/mapi/es2api/meson.build | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/mapi/es2api/meson.build b/src/mapi/es2api/meson.build index f4922d755adee30c0efb..3d6888a4b8f789cf355a 100644 --- a/src/mapi/

[Mesa-dev] [PATCH mesa 06/11] meson: pass correct env/args to egl tests

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- src/egl/meson.build | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/egl/meson.build b/src/egl/meson.build index cc51671f9d8f24708405..254e7e7a1778a5abc654 100644 --- a/src/egl/meson.build +++

[Mesa-dev] [PATCH mesa 09/11] meson: pass correct args to gbm symbol test

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- src/gbm/meson.build | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/gbm/meson.build b/src/gbm/meson.build index 1bb3c94c38788b2e42fc..fa40f00374e0039631e1 100644 --- a/src/gbm/meson.build +++ b/s

[Mesa-dev] [PATCH mesa 10/11] meson: pass correct args to gles1 ABI test

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- src/mapi/es1api/meson.build | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/mapi/es1api/meson.build b/src/mapi/es1api/meson.build index 57cfb1e8d8580fcae2a2..84a21cd6b7697d687328 100644 --- a/src/mapi/

Re: [Mesa-dev] [PATCH 1/2] meson: do not search for needless deps

', 'yes', 'no'], > + description : 'Build with valgrind support' > ) > option( >'libunwind', > - type : 'boolean', > - value : true, > - description : 'Use libunwind for stack-traces if possible' > + type : 'combo', > + value : 'auto', > + choices : ['auto', '

Re: [Mesa-dev] [PATCH 2/2] meson: set visibility flags on gbm

inc_src, inc_loader, > include_directories('../egl/wayland/wayland-drm')], > - c_args : args_gbm, > + c_args : [c_vis_args, args_gbm], both patches are Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> and this one is also Tested-by: Eric Engestrom <eric.engest...@i

Re: [Mesa-dev] [PATCH] meson: implement default driver arguments

On Monday, 2017-10-30 10:21:50 -0700, Dylan Baker wrote: > This allows drivers to be set by OS/arch in a sane manner. > > Signed-off-by: Dylan Baker > --- > meson.build | 37 +++-- > meson_options.txt | 8 > 2 files

[Mesa-dev] [PATCH mesa 3/3] egl: don't try the software path twice

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- src/egl/main/egldriver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/egl/main/egldriver.c b/src/egl/main/egldriver.c index c7d5aa18056518c51fc0..b20652ed8c1d0182b5d5 100644 --- a/src/egl/main/egldr

[Mesa-dev] [PATCH mesa 2/3] egl: rename LIBGL_ALWAYS_SOFTWARE variable from UseFallback to ForceSoftware

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- src/egl/drivers/dri2/platform_android.c | 2 +- src/egl/drivers/dri2/platform_drm.c | 2 +- src/egl/drivers/dri2/platform_surfaceless.c | 2 +- src/egl/drivers/dri2/platform_wayland.c | 2 +- src/egl/driver

[Mesa-dev] [PATCH mesa 1/3] egl: let each platform decided how to handle LIBGL_ALWAYS_SOFTWARE

restriction. platform_{surfaceless,x11,wayland} were already handling it themselves. Fixes: 47273d7312cb5b5b6b0b9 "egl: set UseFallback if LIBGL_ALWAYS_SOFTWARE is set" Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- src/egl/drivers/dri2/egl_dri2.c | 4 src/

Re: [Mesa-dev] [PATCH] autotools, meson: add tileset.h

@@ files_swr_arch = files( >'rasterizer/core/threads.h', >'rasterizer/core/tilemgr.cpp', >'rasterizer/core/tilemgr.h', > + 'rasterizer/core/tileset.h', Meson tracks #includes, so adding this is actually a noop, but for consistency let's add it in for now. Reviewed-by: Eric E

Re: [Mesa-dev] [PATCH] docs: add 18.0.5 in the release calendar

On Monday, 2018-05-14 11:34:43 +0200, Juan A. Suarez Romero wrote: > Mesa 18.1 series has not been released yet, so let's extend 18.0 lifetime. > > CC: Andres Gomez > CC: Emil Velikov > --- > docs/release-calendar.html | 7 ++- > 1 file changed,

Re: [Mesa-dev] [PATCH mesa 4/5] meson: fix platforms=[]

On Friday, 2018-05-11 08:54:13 -0700, Dylan Baker wrote: > Quoting Eric Engestrom (2018-05-11 07:12:29) > > Fixes: 5608d0a2cee47c7d037f ("meson: use array type options") > > Signed-off-by: Eric Engestrom <eric.engest...@intel.com> > > --- > > meson.b

Re: [Mesa-dev] [PATCH] autotools, meson: add tileset.h

On Monday, 2018-05-14 16:02:02 +0200, Juan A. Suarez Romero wrote: > On Mon, 2018-05-14 at 14:09 +0100, Eric Engestrom wrote: > > On Monday, 2018-05-14 13:53:37 +0200, Juan A. Suarez Romero wrote: > > > Fixes: 4e52cb51b5 ("swr/rast: Thread locked tiles improvement")

[Mesa-dev] [PATCH mesa 4/4] docs/meson: mark code/commands as

Signed-off-by: Eric Engestrom <eric.engest...@intel.com> --- docs/meson.html | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/docs/meson.html b/docs/meson.html index 009aebd817057f3e73da..29907a60a9cb02975065 100644 --- a/docs/meson.html +++

[Mesa-dev] [PATCH mesa 3/4] docs/meson: replace plaintext url with a link

Signed-off-by: Eric Engestrom <eric.engest...@intel.com> --- docs/meson.html | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/meson.html b/docs/meson.html index 3c0e3a168b1a706a99be..009aebd817057f3e73da 100644 --- a/docs/meson.html +++ b/docs/meson.html @@

[Mesa-dev] [PATCH mesa 2/4] docs/meson: fix various html issues

Signed-off-by: Eric Engestrom <eric.engest...@intel.com> --- docs/meson.html | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/docs/meson.html b/docs/meson.html index 841a0d5b9d8d65b71da5..3c0e3a168b1a706a99be 100644 --- a/docs/meson.html +++ b/docs/meson.html @@

[Mesa-dev] [PATCH mesa 1/4] docs/meson: fix various typos

Signed-off-by: Eric Engestrom <eric.engest...@intel.com> --- docs/meson.html | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/docs/meson.html b/docs/meson.html index c260b703902083045e27..841a0d5b9d8d65b71da5 100644 --- a/docs/meson.html +++ b/docs/meso

[Mesa-dev] [PATCH mesa 2/2] docs/meson: mention how to use array options

Signed-off-by: Eric Engestrom <eric.engest...@intel.com> --- docs/meson.html | 8 1 file changed, 8 insertions(+) diff --git a/docs/meson.html b/docs/meson.html index d05b5fe347b67bad9f8d..c260b703902083045e27 100644 --- a/docs/meson.html +++ b/docs/meson.html @@ -67,6 +67,1

[Mesa-dev] [PATCH mesa 1/2] meson: remove "empty array"/"array of an empty string" confusion

Signed-off-by: Eric Engestrom <eric.engest...@intel.com> --- meson_options.txt | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/meson_options.txt b/meson_options.txt index ce7d87f1ebd74a4ecc2c..b851f086a2b756142d8d 100644 --- a/meson_options.txt +++ b/meson_optio

Re: [Mesa-dev] [PATCH mesa 2/5] meson: fix gallium-drivers=[]

On Friday, 2018-05-11 08:48:34 -0700, Dylan Baker wrote: > Quoting Eric Engestrom (2018-05-11 07:12:27) > > Fixes: 5608d0a2cee47c7d037f ("meson: use array type options") > > Signed-off-by: Eric Engestrom <eric.engest...@intel.com>

[Mesa-dev] [PATCH mesa] meson: remove dependency antipattern

to be the recommended way to deal with non-existant dependency, but these don't work with `.found()`, so now the recommended way is to declare a impossible dependency, which null_dep does for us in Mesa. In short, we don't need and shouldn't check for `!= []` anywhere anymore. Signed-off-by: Eric Engestrom

[Mesa-dev] [PATCH mesa 1/5] meson: fix dri-drivers=[]

Fixes: 5608d0a2cee47c7d037f ("meson: use array type options") Signed-off-by: Eric Engestrom <eric.engest...@intel.com> --- meson.build | 27 +++ 1 file changed, 11 insertions(+), 16 deletions(-) diff --git a/meson.build b/meson.build index e52b

[Mesa-dev] [PATCH mesa 4/5] meson: fix platforms=[]

Fixes: 5608d0a2cee47c7d037f ("meson: use array type options") Signed-off-by: Eric Engestrom <eric.engest...@intel.com> --- meson.build | 26 +++--- 1 file changed, 11 insertions(+), 15 deletions(-) diff --git a/meson.build b/meson.build index a899

[Mesa-dev] [PATCH mesa 3/5] meson: fix vulkan-drivers=[]

Fixes: 5608d0a2cee47c7d037f ("meson: use array type options") Signed-off-by: Eric Engestrom <eric.engest...@intel.com> --- meson.build | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/meson.build b/meson.build index 6b069ae5dfc52adba1b7..a8999f37bd0

[Mesa-dev] [PATCH mesa 2/5] meson: fix gallium-drivers=[]

Fixes: 5608d0a2cee47c7d037f ("meson: use array type options") Signed-off-by: Eric Engestrom <eric.engest...@intel.com> --- meson.build | 73 +++-- 1 file changed, 32 insertions(+), 41 deletions(-) diff --git a/meson.build b/m

[Mesa-dev] [PATCH mesa 0/5] meson: fix empty array options

I'm guessing these were tested using `-D platforms=`, which actually sets the array to contain 1 element, an empty string. Rework the code to handle both that, and emptying the array (`-D platforms=[]`). Eric Engestrom (5): meson: fix dri-drivers=[] meson: fix gallium-drivers=[] meson

[Mesa-dev] [PATCH mesa 5/5] meson: drop unused empty string array element

Signed-off-by: Eric Engestrom <eric.engest...@intel.com> --- meson.build | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/meson.build b/meson.build index 5dd5168eb95dc823bbbe..bd48e343d30c1024c104 100644 --- a/meson.build +++ b/meson.build @@ -100,13 +

Re: [Mesa-dev] meson: Fix build for egl platform_x11 with dri3

vers/dri2/egl_dri2.c:61:0: > ../src/egl/drivers/dri2/egl_dri2.h:41:32: fatal error: loader_dri3_helper.h: > No such file or directory > > Cc: Dylan Baker <dy...@pnwbakers.com> > Signed-off-by: Ville Syrjälä <ville.syrj...@linux.intel.com> Reviewed-by: Eric Engestrom &

Re: [Mesa-dev] [PATCH] autotools, meson: add tileset.h

On Monday, 2018-05-14 11:05:34 -0700, Dylan Baker wrote: > Quoting Eric Engestrom (2018-05-14 06:09:59) > > > > Dylan, what do you think? Do we want to remove all the unnecessary > > files() from meson, or keep them to mirror what was needed by autotools? > > I'd vote

[Mesa-dev] [PATCH mesa] i965: Check result of make_surface() for miptree_create

From: Andrea Azzarone <azzaro...@gmail.com> Since make_surface() can fail we need to check the result before dereferencing it. Bug: https://github.com/mesa3d/mesa/pull/5 Bug: https://bugs.launchpad.net/ubuntu/+source/gnome-shell/+bug/1760415 Reviewed-by: Eric Engestrom <eric.engest...@

[Mesa-dev] [PATCH mesa v2 2/7] meson: fix gallium-drivers=[]

Fixes: 5608d0a2cee47c7d037f ("meson: use array type options") Signed-off-by: Eric Engestrom <eric.engest...@intel.com> --- v2: handle both `-D gallium-drivers=[]` and `-D gallium-drivers=` --- meson.build | 66 - 1 file change

[Mesa-dev] [PATCH mesa v2 1/7] meson: fix dri-drivers=[]

Fixes: 5608d0a2cee47c7d037f ("meson: use array type options") Signed-off-by: Eric Engestrom <eric.engest...@intel.com> --- v2: handle both `-D dri-drivers=[]` and `-D dri-drivers=` --- meson.build | 25 + 1 file changed, 9 insertions(+), 16 deletion

[Mesa-dev] [PATCH mesa v2 5/7] meson: drop unused empty string array element

Signed-off-by: Eric Engestrom <eric.engest...@intel.com> --- meson.build | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/meson.build b/meson.build index 7d3db81c887d82c6fe57..a8fd0980010babae8c9f 100644 --- a/meson.build +++ b/meson.build @@ -100,13 +

[Mesa-dev] [PATCH mesa v2 6/7] docs/meson: mention how to use array options

Signed-off-by: Eric Engestrom <eric.engest...@intel.com> --- docs/meson.html | 8 1 file changed, 8 insertions(+) diff --git a/docs/meson.html b/docs/meson.html index f394a22fc2a7d058828e..29907a60a9cb02975065 100644 --- a/docs/meson.html +++ b/docs/meson.html @@ -67,6 +67,1

[Mesa-dev] [PATCH mesa v2 3/7] meson: fix vulkan-drivers=[]

Fixes: 5608d0a2cee47c7d037f ("meson: use array type options") Signed-off-by: Eric Engestrom <eric.engest...@intel.com> --- v2: handle both `-D vulkan-drivers=[]` and `-D vulkan-drivers=` --- meson.build | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git

[Mesa-dev] [PATCH mesa v2 4/7] meson: fix platforms=[]

Fixes: 5608d0a2cee47c7d037f ("meson: use array type options") Signed-off-by: Eric Engestrom <eric.engest...@intel.com> --- v2: handle both `-D platforms=[]` and `-D platforms=` --- meson.build | 28 +--- 1 file changed, 13 insertions(+), 15 deletion

[Mesa-dev] [PATCH mesa v2 7/7] meson: remove "empty array"/"array of an empty string" confusion

by removing the empty-string option. Cc: Dylan Baker <dy...@pnwbakers.com> Cc: Eric Anholt <e...@anholt.net> Cc: Matt Turner <matts...@gmail.com> Cc: Daniel Stone <dan...@fooishbar.org> Cc: Jason Ekstrand <jason.ekstr...@gmail.com> Cc: Kenneth Graunke <kenn...@whitecape.o

Re: [Mesa-dev] [PATCH 3/5] egl/x11: Handle both depth 30 formats for eglCreateImage(). (v3)

uct dri2_egl_display *dri2_dpy, int depth) > +{ > + unsigned int red_mask = 0; > + xcb_visualtype_t *visual = get_xcb_visualtype_for_depth(dri2_dpy, depth); > + if (visual) > + red_mask = visual->red_mask; > + > + return red_mask; Nit: drop the local `red_mask`

Re: [Mesa-dev] [PATCH 4/5] egl/wayland: Allow client->server format conversion for PRIME offload.

On Saturday, 2018-05-19 05:32:41 +0200, Mario Kleiner wrote: > Support PRIME render offload between a Wayland server gpu and a Wayland > client gpu with different channel ordering for their color formats, > e.g., between Intel drivers which currently only support ARGB2101010 > and XRGB2101010

Re: [Mesa-dev] [PATCH mesa] i965: Check result of make_surface() for miptree_create

On Monday, 2018-05-21 11:42:37 -0700, Ian Romanick wrote: > On 05/17/2018 05:05 AM, Eric Engestrom wrote: > > From: Andrea Azzarone <azzaro...@gmail.com> > > > > Since make_surface() can fail we need to check the result before > > dereferencing it. > >

[Mesa-dev] [PATCH mesa] vulkan: don't free uninitialised memory

The modifiers array hasn't been initialised by then, much less with data that would need freeing. Move the label after the loop to fix this. Signed-off-by: Eric Engestrom <eric.engest...@intel.com> --- src/vulkan/wsi/wsi_common_x11.c | 6 +++--- 1 file changed, 3 insertions(+), 3 del

Re: [Mesa-dev] [PATCH v2 1/9] util: Add a virtual memory allocator

On Wednesday, 2018-05-23 00:25:11 -0700, Jordan Justen wrote: > On 2018-05-22 14:52:28, Scott D Phillips wrote: > > From: Jason Ekstrand > > > > This is simple linear-walk first-fit allocator roughly based on the > > allocator in the radeon winsys code. This allocator

Re: [Mesa-dev] [PATCH 3/3] docs/releasing: Add note about using a staging branch

+ > + > +git checkout X.Y > +git checkout -b X.Y-proposed > + > + > +This branch should be reported to any teams using a CI to track upcoming > stable Might be worth adding a section with a list of the CI teams and their contact person? Series (with typo fixes already menti

Re: [Mesa-dev] [PATCH 1/2] util/u_math: Implement a logbase2 function for unsigned long

4ll; } > + if (n >= 1ll<< 2ll) { n >>= 2ll; pos += 2ll; } > + if (n >= 1ll<< 1ll) { pos += 1ll; } ^^ `ll` is being added a bit too much (although it's harmless); for instance, in this function I believe this one is the only one that does

Re: [Mesa-dev] [PATCH 4/5] egl/wayland: Allow client->server format conversion for PRIME offload.

On Wednesday, 2018-05-23 06:51:12 +0200, Mario Kleiner wrote: > On Mon, May 21, 2018 at 4:42 PM, Eric Engestrom > <eric.engest...@intel.com> wrote: > > On Saturday, 2018-05-19 05:32:41 +0200, Mario Kleiner wrote: > >> Support PRIME render offload between a Wayla

[Mesa-dev] [PATCH mesa 3/3] docs: drop unnecessary out-of-frame target

I'm guessing an earlier version of the website used to have the page contents in , but this isn't the case anymore so just drop the unnecessary `target="_main"` :) Signed-off-by: Eric Engestrom <eric.engest...@intel.com> --- docs/viewperf.html | 21 + 1

[Mesa-dev] [PATCH mesa 1/3] docs: fix `<` & `>` used in html code

Signed-off-by: Eric Engestrom <eric.engest...@intel.com> --- docs/codingstyle.html | 4 ++-- docs/submittingpatches.html | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/docs/codingstyle.html b/docs/codingstyle.html index 7e9f470a1005d39320e0..34acae27fe6846

[Mesa-dev] [PATCH mesa 2/3] docs: fix various html tags mistakes

Signed-off-by: Eric Engestrom <eric.engest...@intel.com> --- docs/egl.html | 1 + docs/precompiled.html | 2 ++ docs/utilities.html | 2 +- 3 files changed, 4 insertions(+), 1 deletion(-) diff --git a/docs/egl.html b/docs/egl.html index 3d8a85b4e7eecb1c07a1..2bc8f2372728822c69d6

Re: [Mesa-dev] [PATCH 02/16] docs: Add python script that converts html to rst.

On Thursday, 2018-05-24 17:27:05 -0700, Laura Ekstrand wrote: > Use Beautiful Soup to fix bad html, then use pandoc for converting to > rst. > --- > docs/rstConverter.py | 23 +++ > 1 file changed, 23 insertions(+) > create mode 100755 docs/rstConverter.py > > diff --git

Re: [Mesa-dev] [PATCH 01/16] Added ci yaml file for Gitlab.

On Thursday, 2018-05-24 17:27:04 -0700, Laura Ekstrand wrote: > For now, all this does is copy our current webpage into a public folder. > Daniel Stone has the server configured to check this public folder and > host the index.html as mesa-test.freedesktop.org. When this patch series > is

Re: [Mesa-dev] [PATCH] egl/x11: Move dri2_format_for_depth prototype.

On Friday, 2018-05-25 16:06:26 +0100, Eric Engestrom wrote: > On Friday, 2018-05-25 06:52:25 +, Vinson Lee wrote: > > Fix build error without DRI3. > > D'uh! > I forgot building dri3 was optional, sorry :/ > > Reviewed-by: Eric Engestrom <eric.engest...

Re: [Mesa-dev] [PATCH v2 1/2] util/u_math: Implement a logbase2 function for unsigned long

On Thursday, 2018-05-24 11:47:52 +0200, Karol Herbst wrote: > From: Pierre Moreau <pierre.mor...@free.fr> > > v2 (Karol Herbst <kher...@redhat.com>): > * removed unneeded ll > * ll -> ull Reviewed-by: Eric Engestrom <eric.engest...@intel.com> > > Signe

Re: [Mesa-dev] [PATCH 15/16] docs: Human edits to the website code for clarity.

On Thursday, 2018-05-24 17:27:18 -0700, Laura Ekstrand wrote: > There's a lot here. If you're interested, it's mostly whitespace fixes, > switching variable names and function names to the Sphinx orange variable > highlight style, and naming code blocks to take advantage of Pygments > syntax

Re: [Mesa-dev] [PATCH 12/16] docs: Fix Sphinx compile errors.

On Thursday, 2018-05-24 17:27:15 -0700, Laura Ekstrand wrote: > This just involves some quick fixes to formatting of the affected pages. > --- > docs/autoconf.rst| 1 + > docs/conf.py | 2 +- > docs/dispatch.rst| 72 > ++--

Re: [Mesa-dev] [PATCH] egl/x11: Move dri2_format_for_depth prototype.

On Friday, 2018-05-25 06:52:25 +, Vinson Lee wrote: > Fix build error without DRI3. D'uh! I forgot building dri3 was optional, sorry :/ Reviewed-by: Eric Engestrom <eric.engest...@intel.com> > > CC drivers/dri2/platform_x11.lo > drivers/dri2/platform_x

Re: [Mesa-dev] [PATCH 16/16] docs: Remove unneeded mesa css file.

ab :) For patch 1 (the yaml file), with or without my comment (can be done later), patch 2 (the python conversion script, which btw I guess we should probably delete once the conversion is done), patch 7 (the sphinx-build yml line), and 12-16 are: Reviewed-by: Eric Engestrom <eric.engest...

[Mesa-dev] [PATCH mesa 1/2] dri: fix error value returned by driGLFormatToImageFormat()

0 is not a valid value for the __DRI_IMAGE_FORMAT_* enum. It is, however, the value of MESA_FORMAT_NONE, which two of the callers (i915 & i965) checked for. The other callers (that check for errors, ie. st/dri) already check for __DRI_IMAGE_FORMAT_NONE. Signed-off-by: Eric Engestrom <eric

[Mesa-dev] [PATCH mesa 2/2] dri: replace two-way switch case with a table lookup

Signed-off-by: Eric Engestrom <eric.engest...@intel.com> --- src/mesa/drivers/dri/common/dri_util.c | 142 + 1 file changed, 76 insertions(+), 66 deletions(-) diff --git a/src/mesa/drivers/dri/common/dri_util.c b/src/mesa/drivers/dri/common/dri_util.c

[Mesa-dev] [PATCH mesa] egl/x11: deduplicate depth-to-format logic

Suggested-by: Emil Velikov <emil.l.veli...@gmail.com> Signed-off-by: Eric Engestrom <eric.engest...@intel.com> --- src/egl/drivers/dri2/platform_x11.c | 35 ++-- src/egl/drivers/dri2/platform_x11_dri3.c | 21 ++ src/egl/drivers/dri2/platform_x11

[Mesa-dev] [PATCH mesa 1/2] egl: add missing includes

Signed-off-by: Eric Engestrom <eric.engest...@intel.com> --- src/egl/drivers/dri2/egl_dri2.c | 1 + src/egl/main/eglapi.c | 2 ++ src/egl/main/eglapi.h | 1 + src/egl/main/eglglobals.c | 2 ++ src/egl/main/eglsurface.c | 2 ++ 5 files changed, 8 insertions(+)

[Mesa-dev] [PATCH mesa 2/2] egl: remove unused include

Signed-off-by: Eric Engestrom <eric.engest...@intel.com> --- src/egl/main/egldefines.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/egl/main/egldefines.h b/src/egl/main/egldefines.h index d0502f33091a9ecb06bd..c925e0ca55338f73dbec 100644 --- a/src/egl/main/egldefines.h +++ b/s

<    6   7   8   9   10   11   12   13   14   15   >