Re: [Mesa-dev] [PATCH v11 12/15] x11/dri3: Don't open-code ARRAY_SIZE

On Wednesday, 2018-02-21 14:05:56 +, Daniel Stone wrote: > Signed-off-by: Daniel Stone <dani...@collabora.com> > --- > src/loader/loader_dri3_helper.c | 5 +++-- > src/loader/meson.build | 2 +- Assuming automake already has the right include path, Reviewed-

Re: [Mesa-dev] [PATCH] glx: Properly handle cases where screen creation fails

On Wednesday, 2018-02-21 09:26:34 -0500, Chuck Atkins wrote: > This fixes a segfault exposed by a29d63ecf7 which occurs when swr is > used on an unsupported architecture. > > Signed-off-by: Chuck Atkins > Cc: mesa-sta...@lists.freedesktop.org > Cc: George Kyriazis

Re: [Mesa-dev] [PATCH v11 13/15] x11/dri3: Store raw present completion mode

' > field to the raw present completion mode from the server. > > Signed-off-by: Daniel Stone <dani...@collabora.com> Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > --- > src/loader/loader_dri3_helper.c | 12 +++- > src/loader/loader_dri3_helper.h |

Re: [Mesa-dev] [PATCH] configure.ac: pthread-stubs not present on OpenBSD

*BSD people, can you confirm whether pthread-stubs is still needed on FreeBSD, DragonflyBSD and NetBSD? Either Mesa is missing this code, or libdrm doesn't need it anymore. This patch itself is Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > > Signed-off-by: Jonathan Gr

Re: [Mesa-dev] [PATCH] meson: Add Haiku platform support v4

copy, modify, merge, publish, distribute, sublicense, and/or sell > +# copies of the Software, and to permit persons to whom the Software is > +# furnished to do so, subject to the following conditions: > + > +# The above copyright notice and this permission notice shall be inclu

Re: [Mesa-dev] [PATCH] meson: Add Haiku platform support v4

On Monday, 2018-02-19 11:20:37 +, Eric Engestrom wrote: > On Friday, 2018-02-16 14:27:03 -0600, Alexander von Gluck IV wrote: > > --- > > include/meson.build| 8 + > > meson.build| 16 +++--- >

[Mesa-dev] [PATCH mesa] docs: fix patent url

Reported-by: Pierre Moreau <pierre.mor...@free.fr> Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- docs/patents.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/patents.txt b/docs/patents.txt index b20a045d4b579cba36c3..91c5757d14dc8c7

Re: [Mesa-dev] [PATCH] egl/dri2: fix segfault when display initialisation fails

quot;loader_dri3/glx/egl: Optionally use a blit > context for blitting operations") > Signed-off-by: Frank Binns <francisbi...@gmail.com> Error paths are basically never tested... You're entirely right, thanks for catching this! Reviewed-by: Eric Engestrom <eric.engest...@im

[Mesa-dev] [PATCH mesa] *-symbol-check: use correct `nm` path when cross-compiling

Inspired-by: a similar patch for libdrm by Heiko Becker Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- configure.ac | 1 + meson.build | 3 +++ src/egl/egl-symbols

[Mesa-dev] [RFC PATCH mesa 3/5] meson: avoid changing types for the dri3 option

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- meson.build | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/meson.build b/meson.build index 28d068742ff914a623f6..6c22601f9e8864f08e08 100644 --- a/meson.build +++ b/meson.build @@ -380,11 +

[Mesa-dev] [RFC PATCH mesa 1/5] meson: give different names to the vars containing dri drivers vs gallium drivers

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- meson.build | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/meson.build b/meson.build index e470e62074da9a46767c..2d474b140373292e49e7 100644 --- a/meson.build +++ b/meson

[Mesa-dev] [RFC PATCH mesa 4/5] meson: store the result of whether we have gallium-extra-hud and lmsensors

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- meson.build | 4 1 file changed, 4 insertions(+) diff --git a/meson.build b/meson.build index 6c22601f9e8864f08e08..770fdc7e50653bcfa7c2 100644 --- a/meson.build +++ b/meson.build @@ -1187,15 +1187,19 @@ if with_platfo

[Mesa-dev] [RFC PATCH mesa 5/5] WIP - meson: add a message block at the end of the configuration stage

The messages are basically the same as the ones in configure.ac Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- Sent out because it's as much as I could do before the weekend, and before I try to figure out the last bits I'd love some confirmation that this is what w

[Mesa-dev] [RFC PATCH mesa 2/5] meson: simplify the gbm option code, and avoid changing types

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- meson.build | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/meson.build b/meson.build index 2d474b140373292e49e7..28d068742ff914a623f6 100644 --- a/meson.build +++ b/meson.build @@ -303,16 +

Re: [Mesa-dev] [PATCH] glx: Properly handle cases where screen creation fails

On Wednesday, 2018-02-21 09:48:54 -0500, Chuck Atkins wrote: > > > - if (xmdpy->smapi->destroy) > > > - xmdpy->smapi->destroy(xmdpy->smapi); > > > - free(xmdpy->smapi); > > > + if (xmdpy->smapi) > > > + { > > > + if (xmdpy->smapi->destroy) > > > +

Re: [Mesa-dev] [PATCH] egl: link libEGL against the dynamic version of libglapi

On Wednesday, 2017-12-27 10:54:56 +, Emil Velikov wrote: > On 18 December 2017 at 16:33, Eric Engestrom <eric.engest...@imgtec.com> > wrote: > > From: Brendan King <brendan.k...@imgtec.com> > > > > DRI modules store the address of the dispatch table in a T

Re: [Mesa-dev] [PATCH mesa 3/3] egl: don't try the software path twice

On Wednesday, 2017-12-27 11:14:24 +, Emil Velikov wrote: > For the series: > > Reviewed-by: Emil Velikov > > Modulo any objections, I'll push it later on today. Thanks; can you also add to 1/3 and 3/3: Reported-by: Brendan King Cheers

Re: [Mesa-dev] [PATCH] egl/android: Fix build break with dri2_initialize_android _EGLDisplay parameter

roid.c:1183:8: error: use of undeclared > identifier 'disp' > > Rather than just fixing 'disp', rename the function parameter 'dpy' to > 'disp' to align with the other EGL platforms' implementations. > > Fixes: 2f421651aca9 ("egl: let each platform decided how to handle > LIBGL_

Re: [Mesa-dev] [PATCH] meson: fix building without GL

On Monday, 2018-02-26 16:56:46 +, Eric Engestrom wrote: > On Monday, 2018-02-26 08:46:54 -0800, Dylan Baker wrote: > > libgl will be undefined if with_glx == 'disabled', so move that check > > inside the `if with_glx == 'disabled'` block immediately after

Re: [Mesa-dev] [PATCH] swr: bump minimum supported LLVM version to 5.0

On Thursday, 2018-06-21 11:42:29 +0200, Juan A. Suarez Romero wrote: > On Tue, 2018-06-19 at 11:53 +0200, Juan A. Suarez Romero wrote: > > On Mon, 2018-06-18 at 16:29 +0100, Eric Engestrom wrote: > > > On Monday, 2018-06-18 16:23:41 +0200, Juan A. Suarez Romero wrote: > &g

Re: [Mesa-dev] [PATCH 1/3] meson: Correct behavior of vdpau=auto

s, that was me :] Series is Reviewed-by: Eric Engestrom > --- > meson.build | 17 + > 1 file changed, 9 insertions(+), 8 deletions(-) > > diff --git a/meson.build b/meson.build > index a2d59776c05..429865c9442 100644 > --- a/meson.build > +++ b/me

[Mesa-dev] [PATCH mesa] i915g: allow staging textures to be used

Fixes: 1a69b50b3b441ce8f7a00 "i915g: Fix point sprites." Cc: Stéphane Marchesin Signed-off-by: Eric Engestrom --- Stéphane, I assume this was an accident, given that there's no mention of forcing it off in the commit message or in any comment? Intel CI is happy with this patch, so

Re: [Mesa-dev] [PATCH mesa] meson: fix i965/anv/isl genX static lib names

On Monday, 2018-06-18 13:30:49 -0700, Dylan Baker wrote: > Quoting Eric Engestrom (2018-06-15 04:15:31) > > Shouldn't make any functional difference, just that `liblibanv_gen90.a` > > will now be called `libanv_gen90.a`. > > > > Fixes: 3218056e0eb375eeda470 "

Re: [Mesa-dev] [2/5] gbm: Add support for 10bpp BGR formats

On Wednesday, 2018-06-13 06:04:12 +0200, Mario Kleiner wrote: > From: Daniel Stone > > Add support for XBGR2101010 and ABGR2101010 formats. > > Signed-off-by: Daniel Stone > Reviewed-by: Mario Kleiner > Tested-by: Mario Kleiner > Tested-by: Ilia Mirkin Reviewed-

Re: [Mesa-dev] [PATCH mesa] anv: don't crash on vkDestroyDevice(NULL)

On Thursday, 2018-07-26 02:03:58 -0700, Jason Ekstrand wrote: > On Thu, Jul 26, 2018 at 1:50 AM Eric Engestrom > wrote: > > > On Wednesday, 2018-07-25 14:00:29 -0700, Dylan Baker wrote: > > > Quoting Eric Engestrom (2018-07-25 11:45:56) > > > > CovID:

Re: [Mesa-dev] [PATCH mesa] anv: don't crash on vkDestroyDevice(NULL)

On Wednesday, 2018-07-25 14:00:29 -0700, Dylan Baker wrote: > Quoting Eric Engestrom (2018-07-25 11:45:56) > > CovID: 1438132 > > Signed-off-by: Eric Engestrom > > --- > > src/intel/vulkan/anv_device.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-

Re: [Mesa-dev] loader_dri3: Handle mismatched depth 30 formats for Prime renderoffload.

swizzling of glamor and we end up with the proper pixel formatting in > the scanout buffer :). This so far tested on a NVA5 Tesla card under KDE5 > Plasma as shipping with Ubuntu 16.04.4 LTS. > > Signed-off-by: Mario Kleiner > Cc: Ilia Mirkin > Cc: Eric Engestrom Reviewed-by:

[Mesa-dev] [PATCH mesa] loader: fix indentation

Signed-off-by: Eric Engestrom --- src/loader/loader.c | 4 ++-- src/loader/loader_dri3_helper.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/loader/loader.c b/src/loader/loader.c index 43275484cc2e0c845e10..fda49521aae4056214d5 100644 --- a/src/loader

Re: [Mesa-dev] [PATCH 0/1] swr: Remove unnecessary memset call

On Wednesday, 2018-08-01 20:56:22 +0300, Vlad Golovkin wrote: > This patch is identical to the previous one, but that time I forgot to > mention that I didn't have commit rights, so I am sending the rebased > patch for the review. Reviewed and pushed, thanks :) > > Vlad Golovkin (1): > swr:

[Mesa-dev] [PATCH mesa] egl/main: fix indentation

Signed-off-by: Eric Engestrom --- egl platforms are full of randomly-indented lines, so I won't bother to avoid rebase conflicts and blurring the history. --- src/egl/main/eglconfig.c | 2 +- src/egl/main/egldisplay.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src

Re: [Mesa-dev] [PATCH 1/2] loader: add loader_open_name(..)

On Wednesday, 2018-08-01 23:07:02 +0200, Christian Gmeiner wrote: > Add an improved drmOpenWithType(..) clone which fixes some serious > flaws. Some highlights: > - using busid works only with PCI devices > - open() w/o O_CLOEXEC > - when build w/o udev - it creates a node: mkdir, chown(root),

Re: [Mesa-dev] [PATCH] meson: use correct keyword to fix a meson warning

r.links(args:) is meant here. > > Signed-off-by: Jon Turney Noticed that warning too, but hadn't looked at what caused it. Reviewed-and-Tested-by: Eric Engestrom > --- > meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meson.build b/

Re: [Mesa-dev] [PATCH 1/2] xmlconfig: read more config files from drirc.d/

0-foo.conf to override /etc/drirc; in other words, I would swap 2 & 3 in that list (and in the code). With that, the patch itself is: Reviewed-by: Eric Engestrom ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 05/14] intel: aubinator: simplify decoding

gt; #define MAKE_GEN(major, minor) ( ((major) << 8) | (minor) ) > > -enum { > - AUB_ITEM_DECODE_OK, > - AUB_ITEM_DECODE_FAILED, > - AUB_ITEM_DECODE_NEED_MORE_DATA, > -}; > - > -static int > +static bool You'll need to add #include With that, 2-6 ar

Re: [Mesa-dev] [PATCH v2 7/9] python: Simplify list sorting

On Thursday, 2018-08-09 10:27:24 +0200, Mathieu Bridon wrote: > Instead of copying the list, then sorting the copy in-place, we can just > get a new sorted copy directly. > > Signed-off-by: Mathieu Bridon 4-7 are Reviewed-by: Eric Engestrom > --- > src/mapi/mapi_abi.py |

Re: [Mesa-dev] [PATCH v2] vulkan: simplify VK_USE_PLATFORM_*_KHR handling

ntion from the kernel. > > v2: Also handle PLATFORM_DISPLAY > > Signed-off-by: Emil Velikov > Reviewed-by: Eric Engestrom (v1) > --- > src/vulkan/wsi/wsi_common.c | 12 > src/vulkan/wsi/wsi_common_private.h | 47 + > 2 files chan

Re: [Mesa-dev] [PATCH] egl: Fix leak of X11 pixmaps backing pbuffers in DRI3.

/x11: Implement dri3 support with loader's dri3 > helper") Good catch, you're right! Reviewed-by: Eric Engestrom > --- > src/egl/drivers/dri2/platform_x11_dri3.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/src/egl/drivers/dri2/platform_x11_dri3.c > b/sr

Re: [Mesa-dev] [PATCH v3 08/48] meson: fix dl detection on non cygwin windows

pre_args += '-DHAVE_DLADDR' > endif With that, 1-4 and 7-8 are: Reviewed-by: Eric Engestrom > -- > 2.18.0 > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/

[Mesa-dev] [PATCH mesa] intel/tools: add missing variable initialisation

Cc: Lionel Landwerlin Signed-off-by: Eric Engestrom --- src/intel/tools/error2aub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/tools/error2aub.c b/src/intel/tools/error2aub.c index 3407dcec0b795168c4c8..2030593691cc4ba6dba0 100644 --- a/src/intel/tools

Re: [Mesa-dev] [PATCH mesa] intel/tools: add missing variable initialisation

On Wednesday, 2018-08-08 15:27:13 +0100, Eric Engestrom wrote: > Cc: Lionel Landwerlin Actually: Cc: Jason Ekstrand Fixes: 6a60beba4089315685b8 "intel/tools: Add an error state to aub translator" > Signed-off-by: Eric Engestrom > --- > src/intel/tools/error2aub.c | 2 +

Re: [Mesa-dev] [PATCH mesa] intel/tools: add missing variable initialisation

On Wednesday, 2018-08-08 15:29:49 +0100, Lionel Landwerlin wrote: > Reviewed-by: Lionel Landwerlin > > bo_addr doesn't have a warning? Nope; I guess bo_type guards it perfectly ;) > > On 08/08/18 15:27, Eric Engestrom wrote: > > Cc: Lionel Landwerlin > > Si

[Mesa-dev] [PATCH mesa] anv: set error in all failure paths

Cc: Jason Ekstrand Fixes: 5b196f39bddc689742d3 "anv/pipeline: Compile to NIR in compile_graphics" Signed-off-by: Eric Engestrom --- src/intel/vulkan/anv_pipeline.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_pipeline.c b/src/in

Re: [Mesa-dev] [PATCH] travis: make drivers explicit in Meson targets

> CC: Emil Velikov Technically, we could simply always put the [] around the list, but then it would become a shell glob so we would have to quote it, but it's already inside quotes, so escape... Yeah, let's just leave it like you did :) Reviewed-by: Eric Engestrom > --- > .travis.yml | 17

Re: [Mesa-dev] [PATCH v2 1/5] meson: Ensure that mako is >= 0.8.0

t; mako.__version__ >= "0.8.0"') You should use distutils.version here too, the string comparison will not behave the way you want; with that: Reviewed-by: Eric Engestrom > if has_mako.returncode() != 0 > - error('Python (3.x) mako module required to build mesa.') > + error

Re: [Mesa-dev] [PATCH v2 2/5] meson: use python3 module to find python3

On Wednesday, 2018-08-15 09:18:05 -0700, Dylan Baker wrote: > This handy helper is nice for OSes that are not linux or BSD like (mac > and windows) as it knows how to find python3 in odd places. > --- > meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [Mesa-dev] [PATCH v2 4/5] scons: Require python 2.7

On Wednesday, 2018-08-15 09:18:07 -0700, Dylan Baker wrote: > less than 2.7 is not supported. > > v2: - Remove check for python >= 2.0, since we've already enforced 2.7 Reviewed-by: Eric Engestrom > --- > SConstruct | 1 + > scons/gallium.py | 4 > 2 fi

Re: [Mesa-dev] [PATCH v2 3/5] configure: Enforce python 2.7.x

On Wednesday, 2018-08-15 09:18:06 -0700, Dylan Baker wrote: > We don't want to support older versions of python 2 anymore, and we > don't support python 3.x in autotools currently. Reviewed-by: Eric Engestrom > --- > configure.ac | 7 +++ > 1 file changed, 7 insertions(+)

Re: [Mesa-dev] [PATCH v2 5/5] scons: Check for mako 0.8.0

On Wednesday, 2018-08-15 09:18:08 -0700, Dylan Baker wrote: > v2: - Use distutils to do the version checking > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107565 Acked-by: Eric Engestrom > --- > scons/gallium.py | 13 + > 1 file changed, 13 inser

Re: [Mesa-dev] [PATCH 1/2] util: better handle program names from wine

char * arg = strrchr(program_invocation_name, '\\'); Probably best to avoid variable shadowing :) With `char *` dropped here and the `else` flattened: Reviewed-by: Eric Engestrom > + if (arg) > + return arg+1; > + > + return program_invocation_name

Re: [Mesa-dev] [PATCH v2 2/5] meson: use python3 module to find python3

On Thursday, 2018-08-16 12:25:07 +0200, Mathieu Bridon wrote: > On Thu, 2018-08-16 at 11:00 +0100, Eric Engestrom wrote: > > On Wednesday, 2018-08-15 09:18:05 -0700, Dylan Baker wrote: > > > This handy helper is nice for OSes that are not linux or BSD like > > > (mac >

Re: [Mesa-dev] [PATCH mesa 2/3] bin: make MESA_GIT_SHA1 directly usable in code

On Thursday, 2018-08-16 12:00:10 +0100, Emil Velikov wrote: > On 14 August 2018 at 18:24, Eric Engestrom wrote: > > Signed-off-by: Eric Engestrom > > --- > > bin/git_sha1_gen.py| 2 +- > > src/gallium/drivers/svga/svga_screen.c

Re: [Mesa-dev] [PATCH v2] egl/android: use drmDevice instead of the manual /dev/dri iteration

On Tuesday, 2018-08-14 10:05:06 +0100, Emil Velikov wrote: > From: Emil Velikov > > Replace the manual handling of /dev/dri in favor of the drmDevice API. > The latter provides a consistent way of enumerating the devices, > providing device details as needed. > > v2: > - Use ARRAY_SIZE (Frank)

[Mesa-dev] [PATCH mesa 3/3] bin: whitespace cleanup

Signed-off-by: Eric Engestrom --- bin/git_sha1_gen.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/bin/git_sha1_gen.py b/bin/git_sha1_gen.py index bcc29de1c6218ab3af79..dd967a7ee2b654c1ab92 100755 --- a/bin/git_sha1_gen.py +++ b/bin/git_sha1_gen.py @@ -42,14 +42,14

[Mesa-dev] [PATCH mesa 2/3] bin: make MESA_GIT_SHA1 directly usable in code

Signed-off-by: Eric Engestrom --- bin/git_sha1_gen.py| 2 +- src/gallium/drivers/svga/svga_screen.c | 6 +- src/gallium/state_trackers/clover/api/device.cpp | 6 +- src/gallium/state_trackers/clover/api/platform.cpp | 6 +- src/git_sha1

[Mesa-dev] [PATCH mesa 1/3] bin: split `write_if_different()` out

Signed-off-by: Eric Engestrom --- bin/git_sha1_gen.py | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/bin/git_sha1_gen.py b/bin/git_sha1_gen.py index 68a87e72ec563ce6298f..bc0279ccef16d42bb88d 100755 --- a/bin/git_sha1_gen.py +++ b/bin/git_sha1_gen.py

Re: [Mesa-dev] [PATCH v2] egl: implement EXT_surface_SMPTE2086_metadata and EXT_surface_CTA861_3_metadata

t; + surface->HdrMetadata.white_point.x = value; > + break; > + case EGL_SMPTE2086_WHITE_POINT_Y_EXT: > + surface->HdrMetadata.white_point.y = value; > + break; > + case EGL_SMPTE2086_MAX_LUMINANCE_EXT: > + surface->HdrMetadata

[Mesa-dev] [PATCH mesa] egl: check for buffer overflow *before* corrupting our memory

Signed-off-by: Eric Engestrom --- src/egl/main/eglapi.c | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c index 19fae12f5b7596e07959..5e5048c4d69fdcf02a15 100644 --- a/src/egl/main/eglapi.c +++ b/src/egl/main

Re: [Mesa-dev] [PATCH mesa 3/3] bin: whitespace cleanup

On Tuesday, 2018-08-14 10:41:41 -0700, Dylan Baker wrote: > With the one nit, patches 1 and 3 are: > Reviewed-by: Dylan Baker Thanks! I fixed the typo and pushed both. > > I'm not confident on patch 2 to give you an rb. > > Quoting Eric Engestrom (2018-08-14 10:24:13) >

[Mesa-dev] [PATCH mesa v2 1/3] git_sha1: simplify logic

Signed-off-by: Eric Engestrom --- bin/git_sha1_gen.py | 6 +- src/Makefile.am | 2 +- src/git_sha1.h.in| 1 - src/mesa/Android.libmesa_git_sha1.mk | 2 +- 4 files changed, 3 insertions(+), 8 deletions(-) delete mode 100644 src

[Mesa-dev] [PATCH mesa] egl/wayland: remove sign from bitfield `formats`

Signed-off-by: Eric Engestrom --- src/egl/drivers/dri2/egl_dri2.h | 2 +- src/egl/drivers/dri2/platform_wayland.c | 10 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/egl/drivers/dri2/egl_dri2.h b/src/egl/drivers/dri2/egl_dri2.h index f8001ec4b661f6dce20b

[Mesa-dev] [PATCH mesa] mailmap: add various typos of Emil's address from the log

Cc: Emil Velikov Signed-off-by: Eric Engestrom --- .mailmap | 5 + 1 file changed, 5 insertions(+) diff --git a/.mailmap b/.mailmap index ff60ba7ea8548ee2c6b0..848d71400c0e146c9eab 100644 --- a/.mailmap +++ b/.mailmap @@ -145,6 +145,11 @@ Edward O'Callaghan Emeric Grange Emeric

Re: [Mesa-dev] [PATCH] fixup! anv: Use central api generation scripts.

On Thursday, 2018-08-16 15:47:11 +0100, Emil Velikov wrote: > --- > src/intel/Android.vulkan.mk | 8 > src/intel/Makefile.vulkan.am| 10 +- > src/intel/vulkan/anv_entrypoints_gen.py | 9 ++--- > src/intel/vulkan/anv_extensions_gen.py | 9 ++---

[Mesa-dev] [PATCH mesa v2 2/3] bin: always define MESA_GIT_SHA1 to make it directly usable in code

Signed-off-by: Eric Engestrom Reviewed-by: Emil Velikov (v1) --- v2: added previous patch to move all the logic in one place, making the actual change in this patch easier to understand. --- bin/git_sha1_gen.py| 4 ++-- src/gallium/drivers/svga/svga_screen.c

[Mesa-dev] [PATCH mesa v2 3/3] svga: simplify Mesa version string

Suggested-by: Emil Velikov Signed-off-by: Eric Engestrom --- src/gallium/drivers/svga/svga_screen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/svga/svga_screen.c b/src/gallium/drivers/svga/svga_screen.c index 2a8825774623ea8d2745

[Mesa-dev] [PATCH mesa] anv: use safer snprintf() to ensure NULL string-terminator

Signed-off-by: Eric Engestrom --- src/intel/vulkan/anv_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c index c40b94d69f349828b964..897249baa6aea4958c23 100644 --- a/src/intel/vulkan/anv_device.c +++ b/src

[Mesa-dev] [PATCH mesa] util/xmlpool: make indentation coherent

Signed-off-by: Eric Engestrom --- src/util/xmlpool/t_options.h | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/src/util/xmlpool/t_options.h b/src/util/xmlpool/t_options.h index f0537e965b8a3cda894c..a31fafac14c6ffb55bb2 100644 --- a/src/util

[Mesa-dev] [PATCH mesa] intel: various python cleanups

Signed-off-by: Eric Engestrom --- Didn't feel like sending 15 patches for these, but I can split out some of it if needed. --- src/intel/genxml/gen_bits_header.py | 1 - src/intel/genxml/gen_pack_header.py | 29 ++--- src/intel/genxml/gen_zipped_file.py | 1 - src/intel

[Mesa-dev] [PATCH mesa] i965: drop duplicate assignments

These are all already assigned when declared, a few lines above. Signed-off-by: Eric Engestrom --- Note: I'm not 100% certain the value can never change by the time this second assignment is done, so maybe it's the initial one that should be dropped? --- src/mesa/drivers/dri/i965/brw_cs.c | 1

[Mesa-dev] [PATCH mesa v2 1/3] git_sha1: simplify logic

Signed-off-by: Eric Engestrom --- bin/git_sha1_gen.py | 6 +- src/Makefile.am | 2 +- src/git_sha1.h.in| 1 - src/mesa/Android.libmesa_git_sha1.mk | 2 +- 4 files changed, 3 insertions(+), 8 deletions(-) delete mode 100644 src

[Mesa-dev] [PATCH mesa] i965: drop unused assignment

Signed-off-by: Eric Engestrom --- src/mesa/drivers/dri/i965/brw_bufmgr.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_bufmgr.c b/src/mesa/drivers/dri/i965/brw_bufmgr.c index b0f83fb832066094f044..f1675b191c1003883f90 100644 --- a/src/mesa/drivers/dri/i965

[Mesa-dev] [PATCH mesa] intel/batch-decoder: replace local ARRAY_LENGTH() macro with global ARRAY_SIZE()

Signed-off-by: Eric Engestrom --- src/intel/common/gen_batch_decoder.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/intel/common/gen_batch_decoder.c b/src/intel/common/gen_batch_decoder.c index f5be0018afce507685b4..f93f4df0066b8191ca5f 100644 --- a/src/intel

Re: [Mesa-dev] [PATCH 1/2] configure: use AM_PATH_PYTHON to look for the python version

On Thursday, 2018-08-16 17:18:56 +0100, Emil Velikov wrote: > From: Emil Velikov > > Currently we use AC_CHECK_PROGS looking for python2.7, python2 and > finally python. That is due to the varying names used across the > different OS. > > Use the handy AM_PATH_PYTHON which finds the correct

[Mesa-dev] [PATCH mesa] egl/wayland: upcast before bitwise ops

Signed-off-by: Eric Engestrom --- src/egl/drivers/dri2/platform_wayland.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/egl/drivers/dri2/platform_wayland.c b/src/egl/drivers/dri2/platform_wayland.c index 0913394b365255f6af63..f1680495210987d57ba6 100644

[Mesa-dev] [PATCH mesa] anv: drop cast-to-void of used variable

`device` is used 2 lines below, even visible in the diff context printed. Signed-off-by: Eric Engestrom --- src/intel/vulkan/anv_device.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c index 897249baa6aea4958c23

[Mesa-dev] [PATCH mesa] configure: install KHR/khrplatform.h when needed

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107511 Fixes: f7d42ee7d319256608ad "include: update GL & GLES headers (v2)" Signed-off-by: Eric Engestrom --- configure.ac | 1 + 1 file changed, 1 insertion(+) diff --git a/configure.ac b/configure.ac index 7d898a

[Mesa-dev] [PATCH mesa v2] i965: searching the cache doesn't need to modify it

Signed-off-by: Eric Engestrom --- v2: forgot the hunk that was the point of this :facepalm: --- src/mesa/drivers/dri/i965/brw_program_cache.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_program_cache.c b/src/mesa/drivers/dri

[Mesa-dev] [PATCH mesa] i965: gen_shader_sha1() doesn't use the brw_context

Signed-off-by: Eric Engestrom --- src/mesa/drivers/dri/i965/brw_disk_cache.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_disk_cache.c b/src/mesa/drivers/dri/i965/brw_disk_cache.c index 9a6f2ff570c275e7ad53..65fcab24b7f93661d348

Re: [Mesa-dev] [PATCH] intel: don't build tools without -Dtools=intel

On Tuesday, 2018-08-07 11:42:52 +0100, Lionel Landwerlin wrote: > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107487 > Fixes: 4334196ab325c6w ("intel: tools: simplify meson build") > Signed-off-by: Lionel Landwerlin Reviewed-by: Eric Engestrom > --- &g

[Mesa-dev] [PATCH mesa] i965: searching the cache doesn't need to modify it

Signed-off-by: Eric Engestrom --- src/mesa/drivers/dri/i965/brw_program_cache.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_program_cache.c b/src/mesa/drivers/dri/i965/brw_program_cache.c index 600b0611c8b89095e393

[Mesa-dev] [PATCH mesa] meson: install KHR/khrplatform.h when needed

Fixes: f7d42ee7d319256608ad "include: update GL & GLES headers (v2)" Signed-off-by: Eric Engestrom --- For some reason I didn't think to fix meson when I fixed autotools... --- include/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/meson.b

[Mesa-dev] [PATCH mesa] travis: install correct version of mako for each build system

Meson now uses python3, so let's add a block for Autotools, move that line into the buildsys-specific blocks, and set the correct version for Meson. Fixes: 2ee1c86d71bee5ddca2c "meson: Build with Python 3" Signed-off-by: Eric Engestrom --- .travis.yml | 9 +++-- 1 file changed, 7

Re: [Mesa-dev] [PATCH] glx: fill out GLX_DONT_CARE values

me; what about a for loop instead? for (int i = 0; core->indexConfigAttrib(driConfig, i, , ); i++) Either way: Reviewed-by: Eric Engestrom > + switch (attrib) { > + case __DRI_ATTRIB_RENDER_TYPE: > + case __DRI_ATTRIB_CONFIG_CAVEAT: > + case __DRI_ATTRIB_BI

Re: [Mesa-dev] [PATCH 1/3] egl/drm: use gbm_dri_device() wrapper

On Monday, 2018-08-13 15:42:21 +0100, Emil Velikov wrote: > From: Emil Velikov > > Remove the explicit cast, using the appropriate wrapper instead. > > Signed-off-by: Emil Velikov Series is: Reviewed-by: Eric Engestrom > --- > src/egl/drivers/dri2/platform_drm.c | 2 +-

Re: [Mesa-dev] [PATCH v3 08/48] meson: fix dl detection on non cygwin windows

On Thursday, 2018-08-09 10:32:35 -0700, Dylan Baker wrote: > Quoting Eric Engestrom (2018-08-09 08:36:55) > > On Monday, 2018-08-06 17:50:48 -0700, Dylan Baker wrote: > > > --- > > > meson.build | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) &

Re: [Mesa-dev] [PATCH v3 09/48] meson: build getopt when using msvc

rc/meson.build b/src/meson.build > index 6213b7d8a36..bc0508bce3f 100644 > --- a/src/meson.build > +++ b/src/meson.build > @@ -47,6 +47,11 @@ sha1_h = custom_target( > ) > > subdir('gtest') > +if cc.get_id() == 'msvc' > + su

Re: [Mesa-dev] [Mesa-stable] [PATCH v4 1/2] wayland/egl: initialize window surface size to window size

gt; v2: > > - Do not modify attached_{width,height} (Daniel) > > - Do not update size on resizing window (Brendan) > > > > CC: Daniel Stone > > CC: Brendan King > > CC: mesa-sta...@lists.freedesktop.org > > Tested-by: Eric Engestrom > > --- > > sr

Re: [Mesa-dev] [PATCH 3/4] anv: Use central api generation scripts.

On Wednesday, 2018-08-08 11:31:09 +0100, Emil Velikov wrote: > On 8 August 2018 at 00:14, Bas Nieuwenhuizen wrote: > > This became kind of messy as python imports cannot really look up > > parent/sibling directories. I saw some scripts use sys.path but > > that became even more messy due to

Re: [Mesa-dev] [PATCH 3/4] anv: Use central api generation scripts.

On Tuesday, 2018-08-07 16:49:17 -0700, Dylan Baker wrote: > Quoting Bas Nieuwenhuizen (2018-08-07 16:14:33) > > > > anv_extensions_c = custom_target( > > @@ -36,10 +37,11 @@ anv_extensions_c = custom_target( > >input : ['anv_extensions_gen.py', vk_api_xml], > >output : 'anv_extensions.c',

Re: [Mesa-dev] [PATCH] swr: bump minimum supported LLVM version to 6.0

or LLVM 5.0") > Cc: Tim Rowley > Cc: Emil Velikov > Cc: Dylan Baker > Cc: Eric Engestrom Same bump is needed in meson, but with that: Reviewed-by: Eric Engestrom 8< diff --git a/meson.build b/meson.build index 123956ed1b8b3b7872d8..90d3b0c0146fcafdab89 100644 ---

[Mesa-dev] [PATCH shader-db] run: simplify filename handling

); Signed-off-by: Eric Engestrom --- run.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/run.c b/run.c index 200c0f4d6ffb1a2be467..43f1bf5bdd5f160e86fd 100644 --- a/run.c +++ b/run.c @@ -959,11 +959,8 @@ main(int argc, char **argv

Re: [Mesa-dev] [PATCH v2] egl: implement EXT_surface_SMPTE2086_metadata and EXT_surface_CTA861_3_metadata

On Tuesday, 2018-08-14 14:49:28 +0300, Tapani Pälli wrote: > > > On 08/14/2018 01:54 PM, Eric Engestrom wrote: > > On Tuesday, 2018-08-14 11:58:52 +0300, Tapani Pälli wrote: > > > Patch implements common bits for EXT_surface_SMPTE2086_metadata > > > and EXT_sur

Re: [Mesa-dev] [PATCH v2] meson, install_megadrivers: Also remove stale symlinks

consider that the folder has already been created and is ready for use. I think here we should either just ignore that case, or if we want to handle it then it should be: if not exists(to): if lexists(to): unlink(to) makedirs(to) The other two below are Reviewed

Re: [Mesa-dev] [PATCH mesa] i965: drop duplicate assignments

On Thursday, 2018-08-16 09:39:28 -0700, Caio Marcelo de Oliveira Filho wrote: > On Thu, Aug 16, 2018 at 04:00:16PM +0100, Eric Engestrom wrote: > > These are all already assigned when declared, a few lines above. > > > > Signed-off-by: Eric Engestrom > > --- >

Re: [Mesa-dev] [PATCH] autotools: include git_sha1.h in dist tarball

On Monday, 2018-08-20 14:23:28 +, Juan A. Suarez Romero wrote: > This fixes `make distcheck`. > > Fixes: 471f708ed6 ("git_sha1: simplify logic") > CC: Eric Engestrom > --- > src/Makefile.am | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > &g

[Mesa-dev] [PATCH mesa] autotools: don't ship the git_sha1.h generated in git in the tarballs

z Romero Signed-off-by: Eric Engestrom --- I double-checked; as is, the git hash of the current HEAD would be stored in the tarball, and the file would get overwritten with an empty hash when mesa is built from the tarball; with this patch, the incorrect file is not shipped, and is still generated

Re: [Mesa-dev] [PATCH 1/3] bin/git_sha1_gen.py: remove execute bit/shebang

On Thursday, 2018-08-23 15:34:28 +0100, Emil Velikov wrote: > From: Emil Velikov > > The script is executed explicitly via the build system, that uses > PYTHON/prog_python and equivalent. All 4 build systems actually do the same thing there, almost hard to believe :] Revie

Re: [Mesa-dev] [PATCH 2/3] configure: allow building with python3

version > - python3 is chosen prior to python2 > > Signed-off-by: Emil Velikov Not fully double-checked, but +1 on the idea and a skim through didn't notice anything. Acked-by: Eric Engestrom > --- > configure.ac | 8 +++- > m4/ax_chec

Re: [Mesa-dev] [PATCH 3/3] travis: use python3 for the autoconf builds

On Thursday, 2018-08-23 15:34:30 +0100, Emil Velikov wrote: > From: Emil Velikov > > Signed-off-by: Emil Velikov Reviewed-by: Eric Engestrom > --- > .travis.yml | 12 +++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/.travis.y

Re: [Mesa-dev] [PATCH v4 12/49] meson: don't build glx or dri by default on windows

_glx = 'disabled' Otherwise this opens the door to a weird `(gallium + x11 + gl - vk) on windows` bug here. With that: Reviewed-by: Eric Engestrom >elif with_gallium > -# Even when building just gallium drivers the user probably wants dri > -with_glx = 'dri' > +if h

Re: [Mesa-dev] [PATCH 1/5] meson: Actually load translation files

, meson.current_source_dir(), > +'ca', 'es', 'de', 'nl', 'sv', 'fr', > + ], >capture : true, >depend_files : files('ca.po', 'es.po', 'de.po', 'nl.po', 'sv.po', 'fr.po'), Nit: I would put that lang list in an array and reuse it to generate the list of `depend_files` here, to keep

<    9   10   11   12   13   14   15   16   17   18   >