Re: [Mesa-dev] [PATCH 2/3] egl/x11: store xcb_screen_t *screen instead of int screen

;conn = xcb_connect(NULL, ); >dri2_dpy->own_device = true; > } else { >Display *dpy = disp->PlatformDisplay; > >dri2_dpy->conn = XGetXCBConnection(dpy); > - dri2_dpy->screen = DefaultScreen(dpy); > + screen = DefaultScreen(dpy); &

Re: [Mesa-dev] [PATCH mesa] egl: fix helper function name

ames and add `static` where appropriate. > > On 11/16/2016 01:43 AM, Eric Engestrom wrote: > > Signed-off-by: Eric Engestrom <e...@engestrom.ch> > > --- > > src/egl/main/eglapi.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > d

Re: [Mesa-dev] [PATCH 10/13] gallium: introduce format modifier querying

On Tuesday, 2016-11-15 12:27:44 -0500, Rob Clark wrote: > see drm_fourcc.h (if the extension txt didn't mention that, perhaps it should) It does :) These attribute values together form an unsigned 64-bit value called a format modifier. Format modifiers are specified by

Re: [Mesa-dev] [PATCH 2/3] egl/wayland: remove non-applicable destroyDrawable from error path

rest of this series needs more work, but this patch is self-contained so it can be pushed already, and is: Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > --- > src/egl/drivers/dri2/platform_wayland.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > d

Re: [Mesa-dev] [PATCH mesa] egl: fix helper function name

On Tuesday, 2016-11-15 22:49:52 -0800, Matt Turner wrote: > On Tue, Nov 15, 2016 at 3:43 PM, Eric Engestrom <e...@engestrom.ch> wrote: > > Signed-off-by: Eric Engestrom <e...@engestrom.ch> > > --- > > src/egl/main/eglapi.c | 6 +++--- > > 1 fil

Re: [Mesa-dev] [PATCH] docs: document MESA_DEBUG=context

context - create a debug context (see GLX_CONTEXT_DEBUG_BIT_ARB) and > + print error and performance messages to stderr (or > MESA_LOG_FILE). > > MESA_LOG_FILE - specifies a file name for logging all errors, warnings, > etc., rather than stderr > -- > 1

[Mesa-dev] [PATCH mesa] egl: fix function name in debug string

Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- src/egl/main/eglconfig.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/egl/main/eglconfig.c b/src/egl/main/eglconfig.c index 6161d26..876c8f0 100644 --- a/src/egl/main/eglconfig.c +++ b/src/egl/main/eglco

[Mesa-dev] [PATCH mesa] egl: fix helper function name

Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- src/egl/main/eglapi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c index 53340bf..934d585 100644 --- a/src/egl/main/eglapi.c +++ b/src/egl/main/eglapi.c @@ -

[Mesa-dev] [PATCH mesa] egl/wayland: avoid double-return

Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- src/egl/drivers/dri2/platform_wayland.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/egl/drivers/dri2/platform_wayland.c b/src/egl/drivers/dri2/platform_wayland.c index 4fd4289..64eb4ef 100644 --- a/s

[Mesa-dev] [PATCH mesa] egl/x11: misc style fixes

Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- src/egl/drivers/dri2/platform_x11.c | 2 +- src/egl/drivers/dri2/platform_x11_dri3.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/egl/drivers/dri2/platform_x11.c b/src/egl/drivers/dri2/platform_x11.c

Re: [Mesa-dev] [PATCH 1/2] egl: fix type mismatch error type in _eglInitSurface

TYPE >attribute does not contain EGL_PIXMAP_BIT ), an EGL_BAD_MATCH error is >generated." > > Fixes following dEQP test: > >dEQP-EGL.functional.negative_api.create_pbuffer_surface > > Signed-off-by: Tapani Pälli <tapani.pa...@intel.com> Reviewed-by: E

Re: [Mesa-dev] [PATCH 2/2] egl: add check that eglCreateContext gets a valid config

On Thursday, 2016-10-20 15:34:52 +0100, Eric Engestrom wrote: > On Thursday, 2016-10-20 14:55:25 +0300, Tapani Pälli wrote: > > Fixes following dEQP test: > > > >dEQP-EGL.functional.negative_api.create_context > > > > Signed-off-by: Tapani Pälli <tapani.p

Re: [Mesa-dev] [PATCH 2/2] egl: add check that eglCreateContext gets a valid config

& !disp->Extensions.KHR_no_config_context) >RETURN_EGL_ERROR(disp, EGL_BAD_CONFIG, EGL_NO_CONTEXT); Move the line to this `if` (ie. instead of the RETURN_EGL_ERROR here), and you can have my: Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > -- > 2.7.4 ___

Re: [Mesa-dev] [PATCH 1/3] vulkan/wsi/x11: Better handle wsi_x11_connection_create failure

Cc: "13.0" <mesa-sta...@lists.freedesktop.org> > Cc: Dave Airlie <airl...@redhat.com> Series is: Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > --- > src/vulkan/wsi/wsi_common_x11.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/vu

Re: [Mesa-dev] [PATCH 1/2] vulkan/wsi/x11: Fix behavior of vkGetPhysicalDeviceSurfacePresentModesKHR

then pPresentModeCount elements are copied, > and the call returns VK_INCOMPLETE. > > This fix is similar (but simpler and more readable) than the one I provided > in 750d8cad72a for vkGetPhysicalDeviceSurfaceFormatsKHR, which was suffering > from the same problem. Series is: Reviewed-by:

Re: [Mesa-dev] [PATCH 1/3] glx/glvnd: Don't modify the dummy slot in the dispatch table

On Wednesday, 2016-09-14 14:06:18 -0400, Adam Jackson wrote: > Signed-off-by: Adam Jackson > --- It has been pointed out recently [1] that this series hasn't landed yet. Has it simply fallen through the cracks, or is something holding it up? Cheers, Eric [1]

Re: [Mesa-dev] [PATCH] glcpp: initializes version to -1

On Friday, 2016-11-04 13:22:07 +0100, Juan A. Suarez Romero wrote: > Shader can define #version as an integer, including 0. > > Initializes version to -1 to know later if shader has defined a #version > or not. > > It fixes 4 piglit tests: > spec/glsl-1.10/compiler/version-0.frag: crash pass >

Re: [Mesa-dev] [PATCH 3/3] dri: fixup driver names if needed

XTENSIONS, driver_name) > < 0) > return NULL; > > + const size_t len = strlen(name); > + for (size_t i = 0; i < len; i++) { > + if (name[i] == '-') > + name[i] = '_'; Why not replace all non-alnum chars? Either way,

Re: [Mesa-dev] [PATCH 1/2] vulkan/wsi: Add a thread-safe queue implementation

read_condattr_init(); > + if (ret) > + goto fail_vector; > + > + ret = pthread_condattr_setclock(, CLOCK_MONOTONIC); > + if (ret) > + goto fail_condattr; > + > + ret = pthread_cond_init(>cond, ); > + if (ret) > + goto fail_condattr; > + &g

Re: [Mesa-dev] [PATCH] compiler: avoid warning about redefinition of PYTHON_GEN

-off-by: Erik Faye-Lund <kusmab...@gmail.com> Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> Tested-by: Eric Engestrom <eric.engest...@imgtec.com> > --- > src/compiler/Makefile.am | 1 + > src/compiler/Makefile.glsl.am | 1 - > src/compiler/Makefile.nir.

Re: [Mesa-dev] [PATCH] egl: set preserved behavior for surface only if config supports it

09e9475da0eb8 ("egl: make pixmaps and pbuffers EGL_BUFFER_PRESERVED") Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > --- > src/egl/main/eglsurface.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/src/egl/main/eglsurface.c b/src/egl/main/e

Re: [Mesa-dev] [PATCH] mapi: fix out-of-tree build dependencies

On Tue, Oct 11, 2016 at 06:36:11PM +0200, Nicolai Hähnle wrote: > On 11.10.2016 18:17, Eric Engestrom wrote: > > On Tue, Oct 11, 2016 at 03:26:04PM +0100, Emil Velikov wrote: > > > On 11 October 2016 at 14:46, Nicolai Hähnle <nhaeh...@gmail.com> wrote: > > > >

Re: [Mesa-dev] [PATCH] mapi: fix out-of-tree build dependencies

On Tue, Oct 11, 2016 at 03:26:04PM +0100, Emil Velikov wrote: > On 11 October 2016 at 14:46, Nicolai Hähnle wrote: > > From: Nicolai Hähnle > > > > Pick up changes to API XML files also when Mesa is built outside the source > > tree. > > --- > >

Re: [Mesa-dev] [PATCH mesa] egl: add eglSwapBuffersWithDamageKHR

On Mon, Oct 10, 2016 at 01:07:57PM +0100, Emil Velikov wrote: > Hi Eric, > > On 4 October 2016 at 10:30, Eric Engestrom <eric.engest...@imgtec.com> wrote: > > EGL_KHR_swap_buffers_with_damage is actually already supported, as it is > > techn

Re: [Mesa-dev] [PATCH 4/4] i965: Silence unused parameter warnings

On Friday, 2016-10-14 19:26:38 -0700, Ian Romanick wrote: > On 10/14/2016 05:44 PM, Eric Engestrom wrote: > >> Subject: [PATCH 4/4] i965: Silence unused parameter warnings > > > > How about "remove unused parameters" instead? > > Silencing the war

[Mesa-dev] [PATCH mesa] gbm: add a couple missing includes

Needed for memset() and drmIoctl(). Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- src/gbm/backends/dri/gbm_driint.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gbm/backends/dri/gbm_driint.h b/src/gbm/backends/dri/gbm_driint.h index 1644fac..26376ef 100644 ---

Re: [Mesa-dev] [PATCH] egl/android: fix error in droid_add_configs_for_visuals()

0903 ("egl/android: tweak droid_add_configs_for_visuals()") Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > --- > src/egl/drivers/dri2/platform_android.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/src/egl/drivers/dri2/platform_android.c &g

Re: [Mesa-dev] [PATCH] egl/dri2: add a libname to dlopen for OpenBSD

On Monday, 2016-10-17 22:53:20 +1100, Jonathan Gray wrote: > On Mon, Oct 17, 2016 at 12:39:11PM +0100, Emil Velikov wrote: > > On 17 October 2016 at 10:53, Eric Engestrom <eric.engest...@imgtec.com> > > wrote: > > > On Sunday, 2016-10-16 16:38:35 +1100, Jonathan Gra

Re: [Mesa-dev] [PATCH] egl/android: fix error in droid_add_configs_for_visuals()

On Monday, 2016-10-17 12:04:00 +0100, Emil Velikov wrote: > On 17 October 2016 at 07:04, Tapani Pälli wrote: > > This was some kind of leftover in commit acd35c8 and format_count > > array variable (declared in outer scope) should be used instead. > > > Which brings the

[Mesa-dev] [PATCH mesa] docs: fix small typo

Fixes: ba28f2136febca32fe56 ("docs: add note about r-b/other tags when resending") CC: Emil Velikov <emil.l.veli...@gmail.com> Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- docs/submittingpatches.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [Mesa-dev] [PATCH 09/28] XXX:configure: set HAVE_PLATFORM_foo as applicable

you use later in your series? The patches so far look good to me; everything up to #8 is: Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> (with the change in #6 that you suggested) On a related note, this series will break something I'm working on, but isn't anywhere near ready y

Re: [Mesa-dev] [PATCH 06/28] configure: rename --with-{egl-, }platforms

On Thursday, 2016-12-08 19:21:46 +, Emil Velikov wrote: > From: Emil Velikov > > Since day 1, Vulkan has depended on --with-egl-platforms to select the > platforms build. > > With earlier commits, we've attributed for that internally by renaming > the [internal]

Re: [Mesa-dev] [PATCH mesa] egl/x11: cleanup init code

On Thursday, 2016-12-08 20:17:21 +, Emil Velikov wrote: > On 8 December 2016 at 00:30, Eric Engestrom <e...@engestrom.ch> wrote: > > No functional change, just rewriting it in an easier-to-understand way. > > > I might be mislead by the diff, but it seems that there's

Re: [Mesa-dev] [PATCH] egl: wayland: bufferAge: only request a back buffer if there isn't one

On Tuesday, 2016-12-06 12:13:32 +, Lionel Landwerlin wrote: > On 06/12/16 11:36, Eric Engestrom wrote: > > On Saturday, 2016-12-03 22:47:17 +, Lionel Landwerlin wrote: > > > Seeing gtk+ application lockup when they query the buffer age of a > > > surface. &

[Mesa-dev] [PATCH mesa] egl/x11: cleanup init code

No functional change, just rewriting it in an easier-to-understand way. Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- src/egl/drivers/dri2/platform_x11.c | 24 ++-- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/src/egl/drivers/dri2/platform_x1

[Mesa-dev] [PATCH mesa 1/2] egl: rename static functions to match convention

Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- src/egl/main/eglapi.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c index 9950a72..925e881 100644 --- a/src/egl/main/eglapi.c +++ b/src/egl/main/eg

[Mesa-dev] [PATCH mesa 2/2] egl: unexport _eglConvertIntsToAttribs

Nobody else makes use of this function. We can always re-export it if someone ever needs it. Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- src/egl/main/eglapi.c | 2 +- src/egl/main/eglapi.h | 3 --- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/src/egl/main/egla

[Mesa-dev] [PATCH mesa 1/2] radv: name memory heaps

Give explicit names to the various memory heaps, reducing the risk of bugs when adding or modifying them. While at it, use a static_assert to make sure we don't have too many memory heaps. Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- I'm sure there are better name

[Mesa-dev] [PATCH mesa 2/2] radv: name memory types

Following the previous patch, give explicit names to the various memory types, reducing the risk of bugs when adding or modifying them. While at it, use a static_assert to make sure we don't have too many memory types. Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- This one isn't

Re: [Mesa-dev] [PATCH] android: add support for EGL_EXT_buffer_age extension

On Thursday, 2016-11-24 11:38:07 +0200, Tapani Pälli wrote: > From: Kalyan Kondapally > > - initialize buffer age as 0 (Tapani) > > Signed-off-by: Kalyan Kondapally > --- > src/egl/drivers/dri2/egl_dri2.h | 2 ++ >

Re: [Mesa-dev] [PATCH] virgl: Fix a strict-aliasing violation in the encoder

e depth, unsigned stencil) > { > int i; > + uint64_t qword; > + > + assert(sizeof(qword) == sizeof(depth)); These sizes won't change at runtime; make it a static_assert()? With that changed, Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> Cheers, Eric

Re: [Mesa-dev] [PATCH 6/6] anv: do not open random render node(s)

if (devices[i]->available_nodes & 1 << DRM_NODE_RENDER && > + devices[i]->bustype == DRM_BUS_PCI && > + devices[i]->deviceinfo.pci->vendor_id == 0x8086) { Yay, magic values! I feel like we should replace all those wit

Re: [Mesa-dev] [PATCH 03/27] gbm: Export a plane getter function

On Thursday, 2016-12-01 14:09:44 -0800, Ben Widawsky wrote: > From: Ben Widawsky > > This will be used by clients that need to know the number of planes > allocated for them on behalf of the GL or other API. The best current > example of this is when an extra "plane" is

Re: [Mesa-dev] [PATCH 02/27] gbm: Fix width height getters return type (trivial)

On Thursday, 2016-12-01 14:09:43 -0800, Ben Widawsky wrote: > From: Ben Widawsky > > Signed-off-by: Ben Widawsky > --- > src/gbm/main/gbm.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/gbm/main/gbm.h

Re: [Mesa-dev] [PATCH 08/27] dri: Add an image creation with modifiers

+ const unsigned count, > + void *loaderPrivate) > +{ > + return __intel_create_image(dri_screen, width, height, format, use, NULL, > 0, I think you meant to use `modifiers` and `count` here :P If you really want to leave

Re: [Mesa-dev] [PATCH 07/27] i965/dri: Store the screen associated with the image

On Thursday, 2016-12-01 14:09:48 -0800, Ben Widawsky wrote: > From: Ben Widawsky > > I intend to need to get to the devinfo structure, and storing the screen > is an easy way to do that. > > It seems to be the consensus that you cannot share an image between > multiple

Re: [Mesa-dev] [PATCH 04/27] gbm: Create a gbm_device getter for stride

On Thursday, 2016-12-01 14:09:45 -0800, Ben Widawsky wrote: > From: Ben Widawsky > > This will be used so we can query information per plane. > > Signed-off-by: Ben Widawsky > --- > src/gbm/backends/dri/gbm_dri.c | 7 +++ > src/gbm/main/gbm.c

Re: [Mesa-dev] [PATCH v2 1/2] virgl: Fix a strict-aliasing violation in the encoder

On Tuesday, 2016-12-06 22:56:54 +1100, Edward O'Callaghan wrote: > > > On 12/06/2016 10:48 PM, Eric Engestrom wrote: > > On Tuesday, 2016-12-06 22:30:58 +1100, Edward O'Callaghan wrote: > >> As per the C spec, it is illegal to alias pointers to different > >>

Re: [Mesa-dev] [PATCH] egl: wayland: bufferAge: only request a back buffer if there isn't one

On Saturday, 2016-12-03 22:47:17 +, Lionel Landwerlin wrote: > Seeing gtk+ application lockup when they query the buffer age of a surface. > > Since we update the buffer age field only when creating buffers & swaping > them on the client side, there shouldn't be any need for requesting a new

Re: [Mesa-dev] [PATCH v2 1/2] virgl: Fix a strict-aliasing violation in the encoder

> Use a memcpy() as a well defined coercion between the double > to uint64_t interpretations of the memory. > > V.2: Use static_assert() instead of assert(). > > Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > Signed-off-by: Edward O'Callaghan <funfunc...@folklor

Re: [Mesa-dev] [PATCH 1/2] egl/surfaceless: remove duplicate KHR_image_base enablement

emil.veli...@collabora.com> Both patches are Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > --- > src/egl/drivers/dri2/platform_surfaceless.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/src/egl/drivers/dri2/platform_surfaceless.c > b/src/egl/

[Mesa-dev] [PATCH mesa] drirc: remove spurious tabs

Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- src/mesa/drivers/dri/common/drirc | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/mesa/drivers/dri/common/drirc b/src/mesa/drivers/dri/common/drirc index af84ee82e8..97297b7a1c 100644 --- a/sr

Re: [Mesa-dev] [PATCH] egl: Fix for not setting EGL_BAD_ALLOC on try to create multiple window surfaces on single window v2.

Hi Adrian, Thanks for this patch! I have only had a quick look at the logic itself, but it looks correct. Inline are a few comments to address before we can merge this patch. I also recommend reading our guidelines on submitting patches: https://mesa3d.org/submittingpatches.html > Subject:

[Mesa-dev] [PATCH mesa] docs/submittingpatches: add mention about legal disclaimers

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- docs/submittingpatches.html | 10 ++ 1 file changed, 10 insertions(+) diff --git a/docs/submittingpatches.html b/docs/submittingpatches.html index 7910ae98f7..5310b1d8c1 100644 --- a/docs/submittingpatches.html +++

Re: [Mesa-dev] [PATCH kmscube 3/3] meson build support (v2)

> + install: true) > -- > 2.9.3 > If/when you commit this, I suggest removing the old build-system, so as to avoid having to maintain both in parallel. Of course, you can keep both around for a while, but this is a demo/teaching project, not a production project, so I don't think it's nece

[Mesa-dev] [PATCH mesa 2/2] REVIEWERS: add autogen.sh to the autoconf group

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- REVIEWERS | 1 + 1 file changed, 1 insertion(+) diff --git a/REVIEWERS b/REVIEWERS index 40db33f67f..0b5d9a4fd3 100644 --- a/REVIEWERS +++ b/REVIEWERS @@ -85,6 +85,7 @@ F: src/gallium/targets/ AUTOCONF BUILD R: Emil V

[Mesa-dev] [PATCH mesa 1/2] REVIEWERS: add myself as a reviewer for EGL and docs

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- REVIEWERS | 5 + 1 file changed, 5 insertions(+) diff --git a/REVIEWERS b/REVIEWERS index 6bd1676cb9..40db33f67f 100644 --- a/REVIEWERS +++ b/REVIEWERS @@ -58,6 +58,7 @@ F:src/compiler/nir/ DOCUMENTATION R: Emil V

Re: [Mesa-dev] [PATCH v2] configure.ac: Use POSIX word boundary regex.

ally care though, and the patch itself looks good :) Reviewed-by: Eric Engestrom <e...@engestrom.ch> Cheers, Eric > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100236 > Suggested-by: Jan Beich <jbe...@freebsd.org> > Suggested-by: Michel Dänzer <mic...@dae

Re: [Mesa-dev] [PATCH v2 01/23] glsl/tests: automake: cleanup all artefacts during clean-local

On Friday, 2017-03-17 13:19:27 +, Emil Velikov wrote: > From: Emil Velikov > > With later commits we'll fix the generators to produce the files in the > correct location. That in itself will cause an issue since the files > will be left dangling and make distcheck

Re: [Mesa-dev] [PATCH] docs/releasing: do not pass any arguments to autogen.sh

Emil Velikov <emil.veli...@collabora.com> Reviewed-by: Eric Engestrom <e...@engestrom.ch> > --- > docs/releasing.html | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/docs/releasing.html b/docs/releasing.html > index b5a9a5c85bf..fc7f2a5aff9 100644 &

Re: [Mesa-dev] [PATCH v2 11/23] glsl/tests/optimisation-test: ensure that compare_ir is available

On Friday, 2017-03-17 13:19:37 +, Emil Velikov wrote: > From: Emil Velikov > > Bail out early if the script is not where we expect it to be. > > v2: use -f instead of -e. latter returns true on folder(s) > > Signed-off-by: Emil Velikov

Re: [Mesa-dev] [PATCH v2] configure.ac: Use POSIX word boundary regex.

On Sunday, 2017-03-19 13:44:30 +, Jan Beich wrote: > Vinson Lee writes: > > > --e 's/[[[:space:]]]+-DNDEBUG\>//g' \ > > --e 's/[[[:space:]]]+-D_GNU_SOURCE\>//g' \ > > --e 's/[[[:space:]]]+-pedantic\>//g' \ > > +-e

Re: [Mesa-dev] [PATCH kmscube] kmscube: Remove unneeded brackets

On Sunday, 2017-03-19 10:50:37 -0300, Fabio Estevam wrote: > Hi Emil, > > On Sun, Mar 19, 2017 at 7:57 AM, Emil Velikov > wrote: > > On 18 March 2017 at 21:47, Fabio Estevam wrote: > >> There is no need to use brackets for single line if

Re: [Mesa-dev] [PATCH v2 03/23] glsl/tests/warnings-test: error out if glsl_compiler is missing

On Friday, 2017-03-17 13:19:29 +, Emil Velikov wrote: > From: Emil Velikov > > ... or non-executable, in particular. You'll want to add `-x` if you want to test that too. > > Signed-off-by: Emil Velikov > --- >

Re: [Mesa-dev] [PATCH v2 12/23] glsl/tests/optimization-test: correctly manage srcdir/builddir

On Friday, 2017-03-17 13:19:38 +, Emil Velikov wrote: > From: Emil Velikov > > At the moment we look for generator script(s) in builddir while they > are in srcdir, and we proceed to generate the tests and expected output > in srcdir, which is not allowed. > > To

Re: [Mesa-dev] [PATCH kmscube] Makefile.am: Add -std=c99 to CFLAGS

On Tuesday, 2017-03-21 10:04:13 -0300, Fabio Estevam wrote: > Currently the following build errors are seen on mips64el: > > cube-tex.c: In function 'get_fd_rgba': > cube-tex.c:230:2: error: 'for' loop initial declarations are only allowed in > C99 mode > for (uint32_t i = 0; i < texh; i++) {

Re: [Mesa-dev] [PATCH kmscube] cube-tex: Handle SMOOTH switch case

ube-tex.c > @@ -442,6 +442,9 @@ static int init_tex(enum mode mode) > return init_tex_nv12_2img(); > case NV12_1IMG: > return init_tex_nv12_1img(); > + /* should never reach here */ > + case SMOOTH: I think adding an `assert(!"unreachabl

Re: [Mesa-dev] [PATCH kmscube] drm-legacy: Include

On Monday, 2017-03-20 12:49:07 -0300, Fabio Estevam wrote: > Include to fix the following build error seen on mips64el: > > drm-legacy.c: In function 'legacy_run': > drm-legacy.c:45:2: error: unknown type name 'fd_set' > fd_set fds; > ^ > drm-legacy.c:55:2: warning: implicit declaration of

Re: [Mesa-dev] [PATCH v2 kmscube] cube-tex: Do not declare counter inside 'for' loop

On Monday, 2017-03-20 09:33:50 -0300, Fabio Estevam wrote: > Do not declare counter inside 'for' loop to fix the following build errors > on mips64el: > > cube-tex.c: In function 'get_fd_rgba': > cube-tex.c:230:2: error: 'for' loop initial declarations are only allowed in > C99 mode > for

Re: [Mesa-dev] [PATCH 2/3] docs/releasing: release.sh is located in xorg-modular

> Subject: docs/releasing: release.sh is located in xorg-modular s|xorg-modular|xorg/util-modular| On Wednesday, 2017-03-15 17:34:25 +, Emil Velikov wrote: > From: Emil Velikov > > Correct the silly typo s/macros/modular/ and add a reference to the > repository.

Re: [Mesa-dev] [PATCH 3/3] docs/releasing: document how to squash/announce queued patches

te: If a patch in the current queue, needs and additional s/,//; s/and/any/ With that, series is: Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > +fix(es), then they should be squashed together. > + > +The commit messages and the cherry picked from tags must be &

[Mesa-dev] [PATCH mesa] docs/specs: update Khronos registries URLs

The registries were migrated to git and are now hosted on GitHub. The old svn is now read-only, and will not be updated anymore. Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- docs/specs/enums.txt | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

Re: [Mesa-dev] [PATCHi V2] spec: MESA_program_binary

On Thursday, 2017-03-16 14:36:48 +1100, Timothy Arceri wrote: > In order to add functionality for OES_get_program_binary and > ARB_get_program_binary we need a binary format enum. > > V2: share a single enum for all mesa drivers. > > Cc: Ian Romanick > --- > > Hi Ian, >

Re: [Mesa-dev] [PATCH 2/2] bin/get-{extra, fixes}-pick-list.sh: improve output

`git log -n1 --pretty=oneline $candidate`" \ "$sha" With either fix, series is: Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > done > done > > diff --git a/bin/get-fixes-pick-list.sh b/bin/get-fixes-pick-list.sh > index 1817300..89

Re: [Mesa-dev] [RFC 07/11] glsl: Add "built-in" functions to do mul(fp64, fp64)

On Friday, 2017-03-03 16:23:03 +, Elie Tournier wrote: > Signed-off-by: Elie Tournier > --- > src/compiler/glsl/builtin_float64.h | 2558 > +++ > src/compiler/glsl/builtin_functions.cpp |4 + >

Re: [Mesa-dev] [PATCH 04/37] glsl/tests: suffix .sh/.py files as applicable

version is supported in the script itself instead of pushing the responsibility to the callers, but it seems like this wasn't really done here, so no objection on removing them. Series is:: Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> Cheers, Eric ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] Convert sed(1) syntax to be compatible with FreeBSD and OpenBSD

On Monday, 2017-03-13 11:56:45 +, Jan Beich wrote: > Eric Engestrom <eric.engest...@imgtec.com> writes: > > >> +echo " `$1`" | sed -E \ > >> +-e 's/[[[:space:]]]+-m[[^[:space:]]]*//g' \ > > > > These only work for me if I rem

Re: [Mesa-dev] [PATCH] Convert sed(1) syntax to be compatible with FreeBSD and OpenBSD

n *BSD? I don't have one available to test this myself. With that changed, it works on GNU sed, so if you send a v2 with that fixed, it gets my: Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> Tested-by: Eric Engestrom <eric.engest...@imgtec.com> Cheers, Eric > +-e '

Re: [Mesa-dev] [PATCH 1/2] drm.h: Include libdrm headers

On Monday, 2017-03-13 11:08:01 -0300, Fabio Estevam wrote: > On Mon, Mar 13, 2017 at 11:07 AM, Ilia Mirkin wrote: > > On Mon, Mar 13, 2017 at 10:04 AM, Fabio Estevam wrote: > >> Hi Ilia, > >> > >> On Mon, Mar 13, 2017 at 11:03 AM, Ilia Mirkin

Re: [Mesa-dev] [PATCH kmscube 5/5] Remove unneeded GL_GLEXT_PROTOTYPES define

ode" Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> OK, now I need to check which changes are left locally once rebased on top of yours :P > these, simply drop the quirky define. > > Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> > --- > common.h |

[Mesa-dev] [PATCH kmscube] drm-common.h: forward-declare needed structs

’ declared inside parameter list will not be visible outside of this definition or declaration int (*run)(const struct gbm *gbm, const struct egl *egl); ^~~ Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- drm-common.h | 3 +++ 1 file changed, 3 insertions(+)

Re: [Mesa-dev] [PATCH kmscube 1/5] configure.ac: wire -Wall -Wextra directly into the build

ov <emil.l.veli...@gmail.com> > --- > This will prompt some warnings, but we can sort this at a later stage. I already started tackling these, patches coming later today/tonight. Series is: Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > --- > M

[Mesa-dev] [PATCH kmscube 2/7] cube-tex.c: fix signed comparison

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- cube-tex.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/cube-tex.c b/cube-tex.c index 1e7741d..a543e83 100644 --- a/cube-tex.c +++ b/cube-tex.c @@ -227,7 +227,7 @@ static int get_fd_rgba(uint32_t *p

[Mesa-dev] [PATCH kmscube 1/7] kmscube.c: remove uninitialized var returned

`ret` isn't used by anything, so remove it as well. Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- kmscube.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kmscube.c b/kmscube.c index 91e0104..8057e66 100644 --- a/kmscube.c +++ b/kmscube.c @@ -67,7

[Mesa-dev] [PATCH kmscube 6/7] drm-common.c: remove unused variable `gbm`

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- drm-common.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drm-common.c b/drm-common.c index 764ffa2..0262816 100644 --- a/drm-common.c +++ b/drm-common.c @@ -35,7 +35,6 @@ drm_fb_destroy_callback(struct gbm_bo *bo, void

[Mesa-dev] [PATCH kmscube 3/7] drm-atomic.c: fix signed comparison

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- drm-atomic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drm-atomic.c b/drm-atomic.c index 3362eac..01fa35a 100644 --- a/drm-atomic.c +++ b/drm-atomic.c @@ -362,7 +362,7 @@ const struct drm * init_drm_

[Mesa-dev] [PATCH kmscube 4/7] drm-atomic.c: remove unused variables `i`

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- drm-atomic.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drm-atomic.c b/drm-atomic.c index 01fa35a..5d64e50 100644 --- a/drm-atomic.c +++ b/drm-atomic.c @@ -108,7 +108,6 @@ static int drm_atomic_

[Mesa-dev] [PATCH kmscube 5/7] drm-atomic.c: remove unused variables `gpu_fence_fd`, `kms_fence_fd`

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- I feel like I might be missing something here; is copying the fields into these vars of any use when debugging? --- drm-atomic.c | 4 1 file changed, 4 deletions(-) diff --git a/drm-atomic.c b/drm-atomic.c index 5d64e50..2

[Mesa-dev] [PATCH kmscube 7/7] drm-legacy.c: suppress 'unused parameter warnings

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- drm-legacy.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drm-legacy.c b/drm-legacy.c index 2392a3d..8e49075 100644 --- a/drm-legacy.c +++ b/drm-legacy.c @@ -33,6 +33,9 @@ static struct drm drm; static void page_flip_h

Re: [Mesa-dev] [PATCH kmscube 1/7] kmscube.c: remove uninitialized var returned

> Subject: kmscube.c: remove uninitialized var returned Huh? Not sure what my brain was thinking; changed that locally to "don't return uninitialized variable" :) On Tuesday, 2017-03-14 13:33:51 +, Eric Engestrom wrote: > `ret` isn't used by anything, so remove it as well.

Re: [Mesa-dev] [PATCH] android: fix segfault within swap_buffers

0011329 /system/lib/libEGL.so (eglSwapBuffersWithDamageKHR+553) > #04 pc 000118e7 /system/lib/libEGL.so (eglSwapBuffers+55) > #05 pc 000754dc /system/lib/libandroid_runtime.so > > Fixes: 2acc69d ("EGL/Android: Add EGL_EXT_buffer_age extension") > Signed-off-by: Tapani Päll

Re: [Mesa-dev] [Request for Comments] - Port documentation to Markdown

On Monday, 2017-03-06 18:36:32 +, Jean Hertel wrote: > Hello guys, > > > I want to propose a port of the current HTML documentation to a markdown-like > syntax. > I was thinking of doing essentially the same thing, just haven't had the time to do so yet. Please CC me (e...@engestrom.ch)

Re: [Mesa-dev] [PATCH 1/2] configure.ac: require pthread-stubs only where available

t;randy.fis...@oracle.com> > Cc: Niveditha Rau <niveditha@oracle.com> > Signed-off-by: Emil Velikov <emil.veli...@collabora.com> This patch has been on ArchLinux for a while, and is therefore Tested-by: Eric Engestrom <eric.engest...@imgtec.com> (as well as thousands of othe

Re: [Mesa-dev] [PATCH] android: fix outdir for gen_enum_to_str files

il") > Signed-off-by: Tapani Pälli <tapani.pa...@intel.com> Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> This can probably be applied to a lot of other places; even though it might not be fixing bugs there, it's still cleaner to reuse the var than copying the path

Re: [Mesa-dev] [PATCH] configure.ac: add --enable-sanitize option

s: running > the address sanitizer requires additional symbols which should be provided > by a preloaded libasan.so (preloaded for hooking into malloc & friends > globally), and the undefined symbols check gets tripped up by that. Yes please! :) Reviewed-by: Eric Engestrom <eric.engest...

Re: [Mesa-dev] [PATCH 11/14] travis: add "make swr" to the build matrix

On Friday, 2017-04-21 13:08:26 +0100, Emil Velikov wrote: > From: Emil Velikov > > Signed-off-by: Emil Velikov > --- > .travis.yml | 39 --- > 1 file changed, 36 insertions(+), 3 deletions(-) > > diff

Re: [Mesa-dev] [RFC] - Rewrite mesa website in Sphinx

Sorry I haven't had time to look at this until now. I just had a look, and besides style that can be tweaked later, I think the main issue is that the homepage a visitor lands on when just typing 'mesa3d.org' should be more than a simple duplicate of the ToC. The 'recent releases' list we

Re: [Mesa-dev] [PATCH 08/14] travis: split out matrix from env

On Friday, 2017-04-21 13:08:23 +0100, Emil Velikov wrote: > From: Emil Velikov > > With next commits we'll add a couple of more options. > > v2: Rework check target. > > Signed-off-by: Emil Velikov > --- > .travis.yml | 18

Re: [Mesa-dev] [PATCH] docs: add release calendar page and references to it

t;Release notes" pages. > > Cc: Andres Gomez <ago...@igalia.com> > Signed-off-by: Emil Velikov <emil.veli...@collabora.com> LGTM: Reviewed-by: Eric Engestrom <e...@engestrom.ch> This looks very error-prone though; did you generate it by hand, or did you write

Re: [Mesa-dev] [PATCH 1/2] egl: Update headers from Khronos

MINANCE_EXT 0x334A > +#define EGL_METADATA_SCALING_EXT 5 > #endif /* EGL_EXT_surface_SMPTE2086_metadata */ > > #ifndef EGL_EXT_swap_buffers_with_damage > diff --git a/include/KHR/khrplatform.h b/include/KHR/khrplatform.h > index 790de44b8f..93acb076a0 100644 >

<    1   2   3   4   5   6   7   8   9   10   >