[Mesa-dev] [PATCH mesa 2/2] meson: add variable for mapi_abi.py instead of going back up the tree

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- src/mapi/es1api/meson.build | 2 +- src/mapi/es2api/meson.build | 2 +- src/mapi/glapi/gen/meson.build| 2 +- src/mapi/meson.build | 2 ++ src/mapi/shared-glapi/meson.build | 2 +- 5 files chan

[Mesa-dev] [PATCH mesa 1/2] meson: reorder subdirs to avoid directly including more than one level

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- src/mapi/glapi/meson.build | 2 ++ src/mapi/meson.build | 2 +- src/meson.build| 1 - 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/mapi/glapi/meson.build b/src/mapi/glapi/meson.build

Re: [Mesa-dev] [PATCH v2] meson: add logic to select apple and windows dri

On Tuesday, 2017-11-21 10:21:07 -0800, Dylan Baker wrote: > This is still not fully correct (haiku and BSD is notably probably not > correct), but Linux is not regressed and this should be correct for > macOS and Windows. > > v2: - set the dri_platform to windows on Cygwin as well (Jon) R-b

[Mesa-dev] [PATCH mesa v3] REVIEWERS: add Jérôme & Alexander as a reviewer for Haiku files

There's been some Haiku-related activity lately, so let's document who to cc on these patches. Cc: Jérôme Duval <jerome.du...@gmail.com> Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> Acked-by: Alexander von Gluck IV <kallis...@unixzen.com> --- Jérôme, are you o

Re: [Mesa-dev] Has anyone stressed radeonsi memory?

On Wednesday, 2017-11-15 17:39:26 +0100, Kai Wasserbäch wrote: > Hey Matias, > Matias N. Goldberg wrote on 15.11.2017 16:51: > >> Why, doesn't your distro have LLVM development packages? > > They aren't as up to date. Keeping up-to-date with everything mesa needs is > > exhausting. > > I started

Re: [Mesa-dev] [PATCH] util: add new ASSERT_BITFIELD_SIZE() macro (v2)

On Wednesday, 2017-11-15 17:16:52 -0700, Brian Paul wrote: > For checking that bitfields are large enough to hold the largest > expected value. > > v2: move into existing util/macros.h header where STATIC_ASSERT() lives. > --- > src/util/macros.h | 16 > 1 file changed, 16

Re: [Mesa-dev] [PATCH mesa v2] REVIEWERS: add Jérôme & Alexander as a reviewer for Haiku files

On Thursday, 2017-11-16 11:05:27 -0600, kallisti5 wrote: > On 2017-11-16 10:18, Eric Engestrom wrote: > > Cc: Alexander von Gluck IV <kallis...@unixzen.com> > > Cc: Jérôme Duval <jerome.du...@gmail.com> > > Signed-off-by: Eric Engestrom <eric.engest...@imgte

[Mesa-dev] [PATCH mesa] egl: fix var type

queryImage() takes an `int*`, compiler is warning about the signed<->unsigned pointer mismatch. Fixes: 0db36caa192b129cb4f2 "egl/wayland: Add a fallback when fourcc query isn't supported" Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- src/egl/drivers/d

Re: [Mesa-dev] [PATCH] mapi: Use correct shared library name on macOS.

On Tuesday, 2017-11-14 17:57:38 -0800, Dylan Baker wrote: > I think "suffix" would be better for the title "name". Also, library -> > libraries. > > With that changed: > Reviewed-by: Dylan Baker <dy...@pnwbakers.com> Reviewed-by: Eric Engestrom <

Re: [Mesa-dev] Difference between Meson and autotools release builds

On Wednesday, 2017-11-15 09:43:59 +, Rogovin, Kevin wrote: > Hi, > > I do not know if anyone has noticed or if it is deliberate, but the meson > builds have that assert()'s are active but the autotools release builds have > that assert() is inactive. Hi, Yep, this is by design, meson

[Mesa-dev] [PATCH mesa 2/2] egl: drop EGL driver `name`

: b174a1ae720cb404738c ("egl: Simplify the "driver" interface") Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- src/egl/drivers/dri2/egl_dri2.c | 2 -- src/egl/drivers/haiku/egl_haiku.cpp | 2 -- src/egl/main/eglapi.c | 3 +-- src/egl/

[Mesa-dev] [PATCH mesa 1/2] egl: move alloc & init out of _eglBuiltInDriver{DRI2, Haiku}

From: Eric Engestrom <e...@engestrom.ch> This is a revert of Marek's 84f3afc2e122cb418573 revert, with a missing line added back. I failed a rebase and dropped that crucial line, and didn't do a runtime test after my rebase, and as a result broke EGL for everyone. This commit has been

Re: [Mesa-dev] [PATCH 11/24] spirv_extensions: add list of extensions and to_string method

On Wednesday, 2017-11-15 14:22:14 +0100, Eduardo Lima Mitev wrote: > From: Alejandro Piñeiro > > Ideally this should be generated somehow. One option would be gather > all the extension dependencies listed on the core grammar, but there > would be the possibility of not

Re: [Mesa-dev] Difference between Meson and autotools release builds

; -Kevin > > -Original Message----- > From: Eric Engestrom [mailto:eric.engest...@imgtec.com] > Sent: Wednesday, November 15, 2017 1:39 PM > To: Rogovin, Kevin <kevin.rogo...@intel.com> > Cc: mesa-dev@lists.freedesktop.org > Subject: Re: [Mesa-dev] Difference betwee

Re: [Mesa-dev] [PATCH 10/24] spirv_extensions: add GL_ARB_spirv_extensions boilerplate

On Wednesday, 2017-11-15 14:22:13 +0100, Eduardo Lima Mitev wrote: > From: Alejandro Piñeiro > > --- > src/mapi/glapi/gen/ARB_spirv_extensions.xml | 13 > src/mapi/glapi/gen/Makefile.am | 1 + > src/mapi/glapi/gen/gl_API.xml | 2 ++ >

Re: [Mesa-dev] [PATCH v2] threads, configure.ac, meson.build: define and use HAVE_TIMESPEC_GET

tructured, but maybe you can use check_functions() from scons/gallium.py, or move it maybe? Other than that, the rest of the patch looks good to me: Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > + > Export('env') > > ##

Re: [Mesa-dev] [AppVeyor] mesa master #6163 failed

On Wednesday, 2017-11-15 10:35:04 +, Jose Fonseca wrote: > I could post a remark on AppVeyor's forums, but it sounds from the > logs the issue could be on our (freedesktop.org's) side. > > > I've reconfigured AppVeyor to use > https://anongit.freedesktop.org/git/mesa/mesa.git/ instead of >

Re: [Mesa-dev] [PATCH 01/24] mesa: add GL_ARB_gl_spirv boilerplate

On Wednesday, 2017-11-15 14:22:04 +0100, Eduardo Lima Mitev wrote: > From: Nicolai Hähnle > > --- > src/mapi/glapi/gen/ARB_gl_spirv.xml | 21 ++ > src/mapi/glapi/gen/Makefile.am | 1 + > src/mapi/glapi/gen/gl_API.xml | 4 +++ >

Re: [Mesa-dev] [PATCH] meson: Don't define HAVE_PTHREAD only on linux

ect, but avoid > defining it there, just in case. Might be worth checking that to see if we can drop the os check, but in the mean time this should be fine: Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > > Signed-off-by: Jon Turney <jon.tur...@dronecode.org.uk> >

Re: [Mesa-dev] [PATCH 03/10] spirv: Import the latest 1.0.12 header and JSON from Khronos

On Friday, 2017-11-10 14:32:43 -0800, Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick > --- > src/compiler/spirv/spirv.core.grammar.json | 417 > - > src/compiler/spirv/spirv.h

Re: [Mesa-dev] [PATCH 1/9] egl/dri2: Factor out context attribute initialization

goto cleanup; > - > - dri2_ctx->dri_context = > -dri2_dpy->dri2->createContextAttribs(dri2_dpy->dri_screen, > + dri2_ctx->dri_context = > + dri2_dpy->dri2->createContextAttribs(dri2_dpy-&

Re: [Mesa-dev] [PATCH 6/9] egl: Implement EGL_KHR_context_flush_control

On Thursday, 2017-11-02 15:01:45 -0400, Adam Jackson wrote: > Signed-off-by: Adam Jackson <a...@redhat.com> Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > --- > src/egl/drivers/dri2/egl_dri2.c | 11 ++- > src/egl/drivers/dri2/egl_dri2.h | 1 +

Re: [Mesa-dev] [PATCH v2 11/11] intel: add aubinator ui

; + > aubinator_error_decode = executable( >'aubinator_error_decode', >files('aubinator_error_decode.c', 'disasm.c', 'gen_disasm.h'), > @@ -37,3 +58,12 @@ aubinator_error_decode = executable( >c_args : [c_vis_args, no_override

[Mesa-dev] [PATCH mesa 1/2] meson: switch default build type to debugoptimized

r <matts...@gmail.com> Cc: Christian Schmidbauer <ch.schmidba...@gmail.com> Cc: Eero Tamminen <eero.t.tammi...@intel.com> Cc: Ernst Sjöstrand <ern...@gmail.com> Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- Sorry for the massive Cc-list, I wanted to incl

[Mesa-dev] [PATCH mesa 2/2] meson: only turn on Mesa's DEBUG for buildtype==debug

Cc: Dylan Baker <dy...@pnwbakers.com> Cc: Chad Versace <chadvers...@chromium.org> Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 6e

Re: [Mesa-dev] Meson's default build type

On Monday, 2017-11-06 08:07:21 -0800, Chad Versace wrote: > On Thu 02 Nov 2017, Dylan Baker wrote: > > Quoting Matt Turner (2017-11-02 10:06:43) > > > On Thu, Nov 2, 2017 at 9:51 AM, Michel Dänzer wrote: > > > > FWIW, my vote is for debugoptimized: Assertions are enabled and

Re: [Mesa-dev] [PATCH mesa 2/2] meson: only turn on Mesa's DEBUG for buildtype==debug

On Monday, 2017-11-06 17:19:35 +, Eric Engestrom wrote: > Cc: Dylan Baker <dy...@pnwbakers.com> > Cc: Chad Versace <chadvers...@chromium.org> > Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> > --- > meson.build | 2 +- > 1 file changed, 1 inserti

Re: [Mesa-dev] [PATCH] gallium: Guard assertions by NDEBUG instead of DEBUG

On Monday, 2017-11-06 18:39:54 +0100, Michel Dänzer wrote: > From: Michel Dänzer <michel.daen...@amd.com> > > This matches the standard assert.h header. > > Signed-off-by: Michel Dänzer <michel.daen...@amd.com> Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com

Re: [Mesa-dev] [PATCH 1/2] configure.ac: append to existing MSVC compat flags

-arith], > [MSVC2013_COMPAT_CFLAGS="$MSVC2013_COMPAT_CFLAGS-Werror=pointer-arith"]) Missing space between `$MSVC2013_COMPAT_CFLAGS` and `-Werror` With that fixed, both patches are Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > +AX_

Re: [Mesa-dev] [PATCH] etnaviv: bugfix: Don't do resolve-in-place without valid TS

On Wednesday, 2017-11-01 11:17:53 +0100, Wladimir J. van der Laan wrote: > GC3000 resolve-in-place assumes that the TS state is configured. > If it is not, this will result in MMU errors. This is especially > apparent when using glGenMipmaps(). > > Fixes a problem introduced in

Re: [Mesa-dev] [PATCH v2] meson: implement default driver arguments

On Tuesday, 2017-10-31 15:50:49 -0700, Dylan Baker wrote: > This allows drivers to be set by OS/arch in a sane manner. > > v2: - set _drivers to a list of drivers instead of manually assigning > each with_* > > cc: Eric Engestrom <e...@engestrom.ch> >

Re: [Mesa-dev] Meson's default build type

On Thursday, 2017-11-02 17:39:53 +, Eric Engestrom wrote: > On Thursday, 2017-11-02 09:46:05 -0700, Chad Versace wrote: > > On Wed 01 Nov 2017, Dylan Baker wrote: > > > Quoting Ilia Mirkin (2017-11-01 16:05:17) > > > > On Wed, Nov 1, 2017 at 7:03 PM, Dylan Bak

Re: [Mesa-dev] Meson's default build type

On Thursday, 2017-11-02 09:46:05 -0700, Chad Versace wrote: > On Wed 01 Nov 2017, Dylan Baker wrote: > > Quoting Ilia Mirkin (2017-11-01 16:05:17) > > > On Wed, Nov 1, 2017 at 7:03 PM, Dylan Baker wrote: > > > > Quoting Ilia Mirkin (2017-11-01 15:52:56) > > > >> On Wed, Nov

Re: [Mesa-dev] [PATCH 2/3] es2api/ABI-check: Add es3.x symbols

freedesktop.org/archives/mesa-stable/2016-June/004545.html > for the discussion about exposing these symbols > > These are added to the top to ease review. > > cc: Ian Romanick <i...@freedesktop.org> > Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> Tested-

Re: [Mesa-dev] [PATCH 1/3] meson: Set c visibility args for wayland-drm

On Tuesday, 2017-10-31 11:57:33 -0700, Dylan Baker wrote: > Because otherwise gbm will expose wayland symbols that it shouldn't. > > Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> Reviewed-and-Tested-by: Eric Engestrom <eric.engest...@imgtec.com> > --- >

Re: [Mesa-dev] [PATCH 1/2] configure: loosen --enable-glvnd check to honour egl

lt > case "x$enable_glx" in > -xno) > -AC_MSG_ERROR([cannot build libglvnd without GLX]) > -;; > xxlib | xgallium-xlib ) > AC_MSG_ERROR([cannot build libgvnd when Xlib-GLX or Gallium-Xlib-GLX > is enabled]) > ;;

Re: [Mesa-dev] [PATCH] meson: Allow building glvnd with EGL and non-dri based GLX

essage('glvnd requires dri based glx') > +if with_glvnd > + if with_glx == 'xlib' or with_glx == 'gallium-xlib' > +error('Cannot build glvnd support for GLX that is not DRI based.') > + if with_glx == 'disabled' and not with_egl s/if/elif/ with that fixed: Reviewed-by: Eric

[Mesa-dev] [PATCH mesa 2/2] meson: drop GLESv1 .so version back to 1.0.0

autotools generates libGLESv1_CM.so.1.0.0, so let's make sure meson does the same. Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- src/mapi/es1api/meson.build | 2 +- src/mapi/shared-glapi/meson.build | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/sr

[Mesa-dev] [PATCH mesa 1/2] meson: standardize .so version to major.minor.patch

components. (The soname isn't affected, and is always .so.$major) Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- src/egl/meson.build| 2 +- src/gallium/targets/osmesa/meson.build | 2 +- src/gbm/meson.build| 2 +- src/glx/meson

Re: [Mesa-dev] create src/wsi

sed by EGL, GBM, and vulkan > wayland-wsi. > > I think there's more that could be moved into wsi, we could move EGL, GBM, and > GLX, and vulkan/wsi, for example. The patches themselves are Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> (and 1 & 2 should land regardless of

Re: [Mesa-dev] [PATCH 1/2] st/mesa: use enum types instead of int/unsigned

DEX */ > + gl_texture_index tex_target:5; This bump is an unrelated bug fix, which should be in its own commit (before this patch) with: Cc: Marek Olšák <marek.ol...@amd.com> Fixes: dbf64ea28bb20bafe5a7d "glsl_to_tgsi: reduce the size of glsl_to_tgsi_instruction using

Re: [Mesa-dev] [PATCH] docs: Fix GL_MESA_program_debug enums

nt" names instead of using the "vertex" names.) Fixes: 13b303ff9265b89bdd91 "docs: Update the list of used MESA GL enums." Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > --- > docs/specs/enums.txt | 26 -- > 1 file chan

[Mesa-dev] Announcement: Meson build type change

Hi all, As a result of the discussion that started with this message: https://lists.freedesktop.org/archives/mesa-dev/2017-November/175104.html The default build type for Meson builds has been changed to `debugoptimized` in commit d5597f09c6a18a3ed2dd [1]. For you devs, this means that some

Re: [Mesa-dev] Announcement: Meson build type change

On Tuesday, 2017-11-07 06:54:59 -0700, Brian Paul wrote: > On 11/07/2017 05:25 AM, Eric Engestrom wrote: > > Hi all, > > > > As a result of the discussion that started with this message: > > https://lists.freedesktop.org/archives/mesa-dev/2017-November/175104.html >

Re: [Mesa-dev] [PATCH 4/4] meson: Enable VC4's NEON assembly support.

ling asm') > >> +if meson.is_cross_build() and (host_machine.cpu_family() == 'x86' or > >> + host_machine.cpu_family() == 'x86_64') > > > > How about: > > if meson.is_cross_build() and host_machine.cpu_fami

Re: [Mesa-dev] [PATCH] i965: implement (un)mapImage

On Thursday, 2017-11-09 17:03:13 +, Julien Isorce wrote: > v2: add early return if (flag & MAP_INTERNAL_MASK) > v3: take input rect into account and test with kmscube and piglit. > v4: handle wraparound and bo reference. > > Already implemented for Gallium drivers. > > Useful for

Re: [Mesa-dev] [PATCH] egl: EXT_pixel_format_float plumbing

start, as it requires floating point configs to be present if the extension is advertised. Other than that, it looks all good to me: Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > > With this change, following dEQP test starts to

Re: [Mesa-dev] [PATCH 0/3] docs/releasing: enhance the releasing documentation

On Thursday, 2017-11-09 16:58:20 +0200, Andres Gomez wrote: > Just some small updates on the releasing documentation. Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > > Andres Gomez (3): > docs/releasing: drop custom LLVM_CONFIG if previously manually set >

Re: [Mesa-dev] [PATCH] anv/meson: Generate dev_icd.json

On Wednesday, 2017-11-08 13:40:13 -0800, Chad Versace wrote: > On Tue 07 Nov 2017, Dylan Baker wrote: > > Quoting Eric Engestrom (2017-11-07 07:25:53) > > > On Wednesday, 2017-11-01 13:49:03 -0700, Chad Versace wrote: > > > > I tested this in a setup where the buil

Re: [Mesa-dev] non-shared glapi

Cc: mesa-maintainers, who might be interested in this discussion :) On Tuesday, 2017-11-07 16:33:57 -0800, Dylan Baker wrote: > Jason let me know today that non-shared glapi is broken in meson. The tests > for > non-shared glapi are broken in autotools and meson. Is anyone still using >

Re: [Mesa-dev] [PATCH] meson: Add threads dependencies to glsl_compiler executable

On Tuesday, 2017-11-07 16:13:44 -0800, Dylan Baker wrote: > Quoting Dylan Baker (2017-10-27 11:22:09) > > Fixes compiling the optional standalone glsl compiler. > > > > Reported-by: DrNick (on irc) > > Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> Revie

Re: [Mesa-dev] [PATCH] docs: add documentation for building with meson

dtype > - add note about b_ndebug > - Clarify meson configure a bit > > Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> > Reviewed-by: Eric Engestrom <e...@engestrom.ch> (v3) > --- > docs/contents.html | 1 + > docs/meson.html| 151 >

Re: [Mesa-dev] [PATCH] meson: Add script to use VERSION file for getting version

on['MESON_SOURCE_ROOT'], 'VERSION') > +with open(filename) as f: > +version = f.read().strip() > +print(version, end='') > + > + > +if __name__ == '__main__': > +main() Seems like overkill, but why not. Change `main()` to `print_mesa_version()` or something th

Re: [Mesa-dev] [PATCH 1/3] broadcom/vc5: Add vc5_drm.h to the release tarball

gt; > Signed-off-by: Andreas Boll <andreas.boll....@gmail.com> Series is Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > --- > src/gallium/drivers/vc5/Makefile.sources | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/gallium/drivers/vc5/Makef

Re: [Mesa-dev] [PATCH] egl/wayland: Add a fallback when fourcc query isn't supported

> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> > Acked-by: Daniel Stone <dani...@collabora.com> Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > --- > src/egl/drivers/dri2/platform_wayland.c | 32 ++-- > 1 file changed, 30

Re: [Mesa-dev] [PATCH] meson: Add script to use VERSION file for getting version

On 8 November 2017 19:32:22 GMT, Dylan Baker <dy...@pnwbakers.com> wrote: > Quoting Eric Engestrom (2017-11-08 04:21:41) > > On Wednesday, 2017-11-01 11:58:16 -0700, Dylan Baker wrote: > > > Meson has up until this point set it's version in the root > meso

Re: [Mesa-dev] [PATCH 04/13] meson: build r600 driver

On Thursday, 2017-11-02 11:32:44 +0100, Marc Dietrich wrote: > Hi Dylan, > > Am Mittwoch, 1. November 2017, 23:49:39 CET schrieb Dylan Baker: > > Signed-off-by: Dylan Baker > > Tested-by: Aaron Watry > > --- > > meson.build |

Re: [Mesa-dev] [PATCH] Revert "meson: bump libdrm version required by amdgpu"

d065d37555f21c8ae8 >"Revert "winsys/amdgpu: Add R600_DEBUG flag to reserve VMID per ctx."" > Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > --- > meson.build | 2 +- > 1 file chang

Re: [Mesa-dev] [PATCH v3] meson: implement default driver arguments

obably more accurate (that way Solaris and other *nix systems > aren't excluded) > - rename softpipe to swrast, as swrast is the actual option name > > cc: Eric Engestrom <e...@engestrom.ch> Not sure about the duplicate error(), but that nitpick aside, this is: Review

Re: [Mesa-dev] [PATCH mesa 2/2] meson: drop GLESv1 .so version back to 1.0.0

On 2 November 2017 23:42:12 GMT, Eric Engestrom <e...@engestrom.ch> wrote: > autotools generates libGLESv1_CM.so.1.0.0, so let's make sure meson > does the same. > > Signed-off-by: Eric Engestrom <e...@engestrom.ch> > --- > src/mapi/es1api/meson.build |

Re: [Mesa-dev] [PATCH] docs: Fix GL_MESA_program_debug enums

On Tuesday, 2017-11-07 16:20:09 +0100, Roland Scheidegger wrote: > Am 07.11.2017 um 11:42 schrieb Eric Engestrom: > > On Tuesday, 2017-11-07 01:44:49 +0100, srol...@vmware.com wrote: > >> From: Roland Scheidegger <srol...@vmware.com> > >> > >> 13b3

Re: [Mesa-dev] Announcement: Meson build type change

ug builds, but I've found that it still optimises out many variables for instance, making debugging quite a pain. I think it would be a good fit for `debugoptimized`, but I wouldn't want `debug` to have anything other than -O0. > > Regards > //Ernst > > 2017-11-07 13:25 GMT+01:00 Eri

Re: [Mesa-dev] [PATCH] anv/meson: Generate dev_icd.json

rget_machine' cpu; they should be fixed as well IMO. Other than that, looks good to me: Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> [1] http://mesonbuild.com/Cross-compilation.html > + command : [prog_python2, '@INPUT@', > + '--lib-path', meson.current_build_dir(),

Re: [Mesa-dev] [PATCH] etnaviv: automake: include common_3d.xml.h in the sources lists

On Tuesday, 2017-11-07 16:18:55 +0100, Juan A. Suarez Romero wrote: > Fixes: f1e1c60ff6 ("etnaviv: Update from rnndb") > --- > src/gallium/drivers/etnaviv/Makefile.sources | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/gallium/drivers/etnaviv/Makefile.sources >

Re: [Mesa-dev] [PATCH] automake: include git_sha1.h.in in release tarball

recipe for target 'all-recursive' failed > > Signed-off-by: Juan A. Suarez Romero <jasua...@igalia.com> Oops :( Fixes: 16be271c6ee618e79c7d "git_sha1_gen: use git_sha1.h.in on all build systems" Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> Thanks! > -

Re: [Mesa-dev] [PATCH] st/va: Enable vaExportSurfaceHandle()

On Friday, 2017-12-01 00:31:48 +, Mark Thompson wrote: > It will be present from libva 2.1 (VAAPI 1.1.0 or higher). > > Signed-off-by: Mark Thompson > --- > See: > >

Re: [Mesa-dev] [PATCH 1/2] meson: install dri internal headers.

On Thursday, 2017-11-30 10:40:11 -0800, Dylan Baker wrote: > Reported-by: Marc Dietrich <marvi...@gmx.de> > Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> Both patches are: Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > --- > include/meson.build

Re: [Mesa-dev] [PATCH] glx/dri3: Remove unused deviceName variable

1582e ("Add DRI3+Present loader") Indeed, been like this since creation, never changed. Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> and pushed, thanks :) > > Signed-off-by: Vadym Shovkoplias <vadym.shovkopl...@globallogic.com> > > --- > src/glx/dri3_g

Re: [Mesa-dev] [PATCH] egl/x11: Remove unneeded free() on always null string

On Friday, 2017-12-01 17:08:53 +0200, vadim.shovkopl...@gmail.com wrote: > From: Vadym Shovkoplias > > In this condition dri2_dpy->driver_name string always equals > NULL, so call to free() is useless > > Signed-off-by: Vadym Shovkoplias

[Mesa-dev] [PATCH mesa] i915: add missing 0 defines

Thanks to Emil's -Wundef, t_dd_dmatmp.h now complains that intel_render.c is missing a couple `#define`s. Assigning them to 0 keeps the existing behaviour; I'll let someone else turn them on if this is the behaviour that was intended. Signed-off-by: Eric Engestrom <eric.engest...@imgtec.

Re: [Mesa-dev] [PATCH] freedreno: add -Wno-packed-bitfield-compat for meson build

ed me how to do this in meson. > > Cc: Eric Engestrom <eric.engest...@imgtec.com> > Signed-off-by: Rob Clark <robdcl...@gmail.com> Not sure it makes much sense to r-b my own patch, but... ^^ Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > --- >

[Mesa-dev] [PATCH mesa] meson: fix pl111 dependency on vc4

src/gallium/winsys/pl111/drm/libpl111winsys.a(pl111_drm_winsys.c.o): In function `pl111_drm_screen_create': pl111_drm_winsys.c:(.text+0x33): undefined reference to `vc4_drm_screen_create_renderonly' Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- meson

Re: [Mesa-dev] [PATCH 00/14] meson: most of gallium

On Thursday, 2017-11-30 10:34:06 -0800, Dylan Baker wrote: > Quoting Eric Engestrom (2017-11-29 07:44:08) > > On Tuesday, 2017-11-28 15:30:21 -0800, Dylan Baker wrote: > > > This series is the gallium media state trackers, the "nine" Direct3D state > > >

Re: [Mesa-dev] [PATCH] meson: Install dri.pc file when building gallium dri drivers

Dietrich <marvi...@gmx.de> > Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > --- > src/mesa/drivers/dri/meson.build | 18 +++--- > 1 file changed, 11 insertions(+), 7 deletions(-) > > dif

Re: [Mesa-dev] [PATCH 0/3] Fix linkage for libEGL and libGLX without dri3

ri3 > meson: Fix overlinkage of dri3 loader Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > > src/egl/meson.build| 2 +- > src/glx/meson.build| 14 +- > src/loader/meson.build | 3 +-- > 3 files changed, 11 inser

Re: [Mesa-dev] [PATCH] Android: disable warnings causing errors

On Thursday, 2017-11-30 14:20:08 +, Emil Velikov wrote: > On 29 November 2017 at 18:12, Rob Herring wrote: > > On Wed, Nov 29, 2017 at 11:01 AM, Emil Velikov > > wrote: > >> On 27 November 2017 at 19:36, Rob Herring wrote: > >>>

Re: [Mesa-dev] [PATCH 3/3] nv50/ir: Fix unused var warnings in release build

> > + MAYBE_UNUSED bool ret = def->src(0).getImmediate(val); > > Can you write a comment mentioning that getImmediate() has > side-effects on the argument, so this *shouldn't* get folded into the > assert? My concern is that with the MAYBE_UNUSED there,

[Mesa-dev] [PATCH mesa] meson: add dep_thread to every lib that includes threads.h

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104141 Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- src/broadcom/meson.build| 2 +- src/gallium/auxiliary/meson.build | 2 +- src/gallium/state_trackers/nine/meson.build | 1 + src/g

Re: [Mesa-dev] [PATCH] egl/android: Provide an option for the backend to expose KHR_image

ec > does not mandate the existence of both the extensions. Indeed, the spec even explicitly states so: > The specifications of EGL_KHR_image_base and EGL_KHR_image_pixmap are > required to determine the specification of this extension, although > those extentions may not be supporte

Re: [Mesa-dev] [PATCH] meson: Fix building gallium media targets with gallium-xlib glx

his, on both meson 43 and 44; I'm guessing meson 42 fails to parse this? Either way, it doesn't hurt, so: Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > dep_xcb = dependency('xcb') > dep_x11_xcb = dependency('x11-xcb') >endif > -- > 2.15.0 > __

[Mesa-dev] [PATCH mesa v2] meson: fix pl111 dependency on vc4

src/gallium/winsys/pl111/drm/libpl111winsys.a(pl111_drm_winsys.c.o): In function `pl111_drm_screen_create': pl111_drm_winsys.c:(.text+0x33): undefined reference to `vc4_drm_screen_create_renderonly' Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> Reviewed-by: Dylan Bak

Re: [Mesa-dev] [PATCH] util/disk_cache: Remove unneeded free() on always null string

On Monday, 2017-12-04 11:47:33 +0200, vadim.shovkopl...@gmail.com wrote: > From: Vadym Shovkoplias > > At this point dc_job->cache_item_metadata.keys always equals > NULL, so call to free() is useless > > Fixes: b86ecea3446 ("util/disk_cache: write cache item

Re: [Mesa-dev] [PATCH] meson: Fix building gallium media targets with gallium-xlib glx

On Thursday, 2017-12-07 09:16:24 -0800, Dylan Baker wrote: > Quoting Eric Engestrom (2017-12-07 04:17:58) > > On Tuesday, 2017-12-05 09:40:53 -0800, Dylan Baker wrote: > > > Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> > > > --- > > > meson

Re: [Mesa-dev] [PATCH mesa 1/6] meson: dedup gallium-vdpau logic

a few more bits of code that can be removed, but I think I'll send a single patch with all of them. I'll push the lot later, once you've seen that final patch too. > > Quoting Eric Engestrom (2017-12-07 08:52:17) > > Signed-off-by: Eric Engestrom <eric.engest...@im

[Mesa-dev] [PATCH mesa 4/6] meson: dedup gallium-va logic

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- meson.build | 40 +++- 1 file changed, 19 insertions(+), 21 deletions(-) diff --git a/meson.build b/meson.build index 1917b474b1ff4505651a..5a957ad13d1b39b5f709 100644 --- a/meson.build

[Mesa-dev] [PATCH mesa 5/6] meson: dedup gallium-xa logic

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- meson.build | 27 +++ 1 file changed, 11 insertions(+), 16 deletions(-) diff --git a/meson.build b/meson.build index 5a957ad13d1b39b5f709..04e2fdd19d7274aa5ecf 100644 --- a/meson.build +++ b/meson

[Mesa-dev] [PATCH mesa 6/6] meson: simplify dri3 logic

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- meson.build | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/meson.build b/meson.build index 04e2fdd19d7274aa5ecf..1ab790462daeef8b56e0 100644 --- a/meson.build +++ b/meson.build @@ -344,15 +344,9 @@

[Mesa-dev] [PATCH mesa 3/6] meson: dedup gallium-omx logic

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- meson.build | 40 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/meson.build b/meson.build index 08c9c4b92313e97f0eb1..1917b474b1ff4505651a 100644 --- a/meson.build

[Mesa-dev] [PATCH mesa 2/6] meson: dedup gallium-xvmc logic

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- meson.build | 40 +++- 1 file changed, 19 insertions(+), 21 deletions(-) diff --git a/meson.build b/meson.build index d8f317e1aaf350c26687..08c9c4b92313e97f0eb1 100644 --- a/meson.build

[Mesa-dev] [PATCH mesa 1/6] meson: dedup gallium-vdpau logic

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- meson.build | 45 + 1 file changed, 21 insertions(+), 24 deletions(-) diff --git a/meson.build b/meson.build index 1ea63fb12915c93a67d5..d8f317e1aaf350c26687 100644 --- a/meson.build

Re: [Mesa-dev] [PATCH] meson: Add lmsensors to gallium libgl-xlib target.

t; > libgallium, libmesa_util, libmesa_gallium, gallium_xlib_link_with, > >], > > - dependencies : [dep_clock, dep_unwind, gallium_xlib_depends], > > + dependencies : [dep_clock, dep_unwind, dep_lmsensors, > > gallium_xlib_depends], needed because `link_with: libgallium`

Re: [Mesa-dev] [PATCH] meson: Fix building gallium media targets with gallium-xlib glx

On Thursday, 2017-12-07 09:57:19 -0800, Dylan Baker wrote: > Quoting Eric Engestrom (2017-12-07 09:37:47) > > On Thursday, 2017-12-07 09:16:24 -0800, Dylan Baker wrote: > > > Quoting Eric Engestrom (2017-12-07 04:17:58) > > > > On Tuesday, 2017-12-05 09:

Re: [Mesa-dev] [PATCH] meson: Add lmsensors to gallium libgl-xlib target.

On Thursday, 2017-12-07 10:16:01 -0800, Dylan Baker wrote: > Quoting Eric Engestrom (2017-12-07 09:49:30) > > On Thursday, 2017-12-07 09:32:39 -0800, Dylan Baker wrote: > > > I don't suppose someone would like to ack this? > > > > > > Quoting Dylan Baker

Re: [Mesa-dev] [PATCH 2/4] meson: Turn on swr for relevant targets

> @@ -56,6 +55,7 @@ libgl = shared_library( >], >dependencies : [ > dep_thread, dep_clock, dep_unwind, dep_lmsensors, driver_swrast, > +driver_swr, Nit: separate lines for dep_* and driver_* ? Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> >]

Re: [Mesa-dev] [PATCH 3/4] meson: set opencl flags for r600

On Friday, 2017-12-08 16:27:21 -0800, Dylan Baker wrote: > Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> Should come after the current 4/4, but Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > --- > src/gallium/drivers/r600/meson.build | 7 +--

Re: [Mesa-dev] [PATCH 4/4] meson: build clover

; +error('OpenCL Clover implementation requires at least one gallium > driver.') > + endif > + > + # TODO: alitvec? > + dep_clc = dependency('libclc') > + with_gallium_opencl = true > +else > + dep_clc = [] > + with_gallium_opencl = false > +endif > +wit

Re: [Mesa-dev] [PATCH 1/4] meson: Build SWR driver

On Friday, 2017-12-08 16:27:19 -0800, Dylan Baker wrote: > This enables the SWR driver, but doesn't actually hook it up to any of > the targets yet. I felt like this patch was big and complicated enough > without adding that. > > Signed-off-by: Dylan Baker > --- >

[Mesa-dev] [PATCH mesa] meson: fix keyword argument in declare_dependency()

`declare_dependency()` takes `compile_args`, not `c_args`. It was correct in all the other `declare_dependency()` from that commit. Fixes: 0bbecc5a8548883f76a71 "meson: define driver dependencies" Cc: Dylan Baker <dy...@pnwbakers.com> Signed-off-by: Eric Engestrom <eric.e

Re: [Mesa-dev] [PATCH 3/4] meson: set opencl flags for r600

On Monday, 2017-12-11 11:50:01 -0800, Dylan Baker wrote: > Quoting Eric Engestrom (2017-12-11 07:55:30) > > On Friday, 2017-12-08 16:27:21 -0800, Dylan Baker wrote: > > > Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> > > > > Should come after the cu

Re: [Mesa-dev] [PATCH] egl/x11: Remove unneeded free() on always null string

e grouped, whereas different kind of issues or different modules should be separate. Don't worry too much about it though, if people ask you to merge or split commits, it's not that complicated to do for a v2 :) > > 2017-12-01 17:41 GMT+02:00 Eric Engestrom <eric.engest...@imgtec.com>

<    5   6   7   8   9   10   11   12   13   14   >