[Mesa-dev] [PATCH] gbm: Fix comments

--- src/gbm/main/gbm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gbm/main/gbm.c b/src/gbm/main/gbm.c index 0f4657a..31202ed 100644 --- a/src/gbm/main/gbm.c +++ b/src/gbm/main/gbm.c @@ -132,7 +132,7 @@ _gbm_mesa_get_device(int fd) * the file descriptor

[Mesa-dev] [PATCH] st/va: Check NULL pointer

Call to handle_table_get in vlVaDestroySurfaces can return NULL on failure. CID: 1243522 Signed-off-by: Gurkirpal Singh <gurkirpal...@gmail.com> --- src/gallium/state_trackers/va/surface.c | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/state_trackers/va/surface.c

[Mesa-dev] [PATCH 1/2] gallium: Silence unused variable warnings

Signed-off-by: Gurkirpal Singh <gurkirpal...@gmail.com> --- src/gallium/drivers/nouveau/codegen/nv50_ir_emit_nv50.cpp | 2 ++ src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp | 1 + src/gallium/drivers/nouveau/nv50/nv98_video.c | 1 + src/gallium/drivers/nouvea

[Mesa-dev] [PATCH 2/2] mesa: Silence unused variable warning

Signed-off-by: Gurkirpal Singh <gurkirpal...@gmail.com> --- src/mesa/state_tracker/st_glsl_to_nir.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/state_tracker/st_glsl_to_nir.cpp b/src/mesa/state_tracker/st_glsl_to_nir.cpp index a880564..a914c8d 100644 --- a/sr

[Mesa-dev] [PATCH 1/2 v2] gallium: Silence unused variable warnings

v2: Use MAYBE_UNUSED as suggested by Ian Romanick Signed-off-by: Gurkirpal Singh <gurkirpal...@gmail.com> --- src/gallium/drivers/nouveau/codegen/nv50_ir_emit_nv50.cpp | 4 +++- src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp | 4 +++- src/gallium/drivers/nouveau/nv50/nv98_v

[Mesa-dev] [PATCH 2/2 v2] mesa/st: Silence unused variable warning

v2: Use MAYBE_UNUSED Changed commit tag (Suggested by Ian Romanick) Signed-off-by: Gurkirpal Singh <gurkirpal...@gmail.com> --- src/mesa/state_tracker/st_glsl_to_nir.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_glsl_to_nir.

Re: [Mesa-dev] [PATCH v2 2/4] st/omx_tizonia: Add --enable-omx-tizonia flag and build files

il saying that it was too large has been put aside for mod approval. The changes I made were to just rename the st/omx directory to st/omx_bellagio (the reason it became large) and renaming bits in the configure.ac and Makefiles. > > > > On 08/12/2017 12:07 PM, Gurkirpal Singh wrote: >

Re: [Mesa-dev] [PATCH v2 2/4] st/omx_tizonia: Add --enable-omx-tizonia flag and build files

On Mon, Aug 14, 2017 at 10:05 PM, Leo Liu <leo@amd.com> wrote: > > > On 08/14/2017 12:25 PM, Gurkirpal Singh wrote: > > > > On Mon, Aug 14, 2017 at 8:55 PM, Leo Liu <leo@amd.com> wrote: > >> >> >> On 08/14/2017 11:19 AM, Gurkirpal Si

[Mesa-dev] [PATCH v2 2/4] st/omx_tizonia: Add --enable-omx-tizonia flag and build files

PKG_CHECK_MODULES for omx_tizonia checks (Emil) Use spaces instead of tabs Add checks around omx-tizonia GSoC Project link: https://summerofcode.withgoogle.com/projects/#4737166321123328 Signed-off-by: Gurkirpal Singh <gurkirpal...@gmail.com> Reviewed-and-Tested-by: Julien Isorce <j

[Mesa-dev] [PATCH v2 3/4] st/omx_tizonia: Add entrypoint

Adds common structure for adding components and screen creation v2: Separate commits for entrypoint and decoder (Christian) Preserve copyright for copied files (Emil) Signed-off-by: Gurkirpal Singh <gurkirpal...@gmail.com> Reviewed-and-Tested-by: Julien Isorce <julien.iso...@

[Mesa-dev] [PATCH v2 0/4] gallium/st: Add Tizonia based state tracker

Sending patches in separate thread since I can't see some patches in reply to the original thread. Gurkirpal Singh (4): st/omx_bellagio: Rename state tracker and option st/omx_tizonia: Add --enable-omx-tizonia flag and build files st/omx_tizonia: Add entrypoint st/omx_tizonia: Add H.264

[Mesa-dev] [PATCH v2 3/4] st/omx_tizonia: Add entrypoint

Adds common structure for adding components and screen creation v2: Separate commits for entrypoint and decoder (Christian) Preserve copyright for copied files (Emil) Signed-off-by: Gurkirpal Singh <gurkirpal...@gmail.com> Reviewed-and-Tested-by: Julien Isorce <julien.iso...@

[Mesa-dev] [PATCH v2 2/4] st/omx_tizonia: Add --enable-omx-tizonia flag and build files

PKG_CHECK_MODULES for omx_tizonia checks (Emil) Use spaces instead of tabs Add checks around omx-tizonia GSoC Project link: https://summerofcode.withgoogle.com/projects/#4737166321123328 Signed-off-by: Gurkirpal Singh <gurkirpal...@gmail.com> Reviewed-and-Tested-by: Julien Isorce <j

Re: [Mesa-dev] [PATCH v2 2/4] st/omx_tizonia: Add --enable-omx-tizonia flag and build files

On Mon, Aug 14, 2017 at 8:55 PM, Leo Liu <leo@amd.com> wrote: > > > On 08/14/2017 11:19 AM, Gurkirpal Singh wrote: > > > > On Mon, Aug 14, 2017 at 8:05 PM, Leo Liu <leo@amd.com> wrote: > >> >> >> On 08/14/2017 05:46 AM, Julien Isorce

[Mesa-dev] [PATCH 1/2] st/omx_tizonia: add --enable-omx-tizonia flag and build files

Signed-off-by: Gurkirpal Singh <gurkirpal...@gmail.com> --- configure.ac| 30 +++ src/gallium/Makefile.am | 4 ++ src/gallium/targets/omx-tizonia/Makefile.am | 77 + src/gallium/targets/omx-tizonia/o

[Mesa-dev] [PATCH 2/2] st/omx_tizonia: Add AVC decoder

Signed-off-by: Gurkirpal Singh <gurkirpal...@gmail.com> --- src/gallium/state_trackers/omx_tizonia/Makefile.am | 35 + .../state_trackers/omx_tizonia/Makefile.sources|9 + .../state_trackers/omx_tizonia/entrypoint.c| 152 ++ .../state_trackers/omx_tizonia/entryp

[Mesa-dev] How to write using EGLImage?

Hi, As a part of my GSoC project[1] I'm working on adding OMX_UseEGLImage support in gallium/st/omx. I have an egl_display[1] (OMX_NATIVE_WINDOWTYPE) and the EGLImage[2] in the H.264 decoder component. I'm looking some sort of method to get mesa pipe screen pointer (or some other pipe structure)

Re: [Mesa-dev] [PATCH 1/2] st/omx_tizonia: add --enable-omx-tizonia flag and build files

m 11.08.2017 um 14:32 schrieb Emil Velikov: >> >>> Hi Gurkirpal, >>> >>> Thanks for working on this. I believe Christian has some good points. >>> There's only one small question + suggestion from me. >>> >>> On 11 August 2017 at 05:31, G

[Mesa-dev] [GSOC] Community bonding discussion

Hi, I was recently accepted as a Google Summer of Code (GSoC) student to work on adding omx state tracker in Mesa/Gallium that uses tizonia instead of bellagio. My mentor for this project, Julien Isorce, suggested that I should take this opportunity to interact with the mesa community and core

Re: [Mesa-dev] [PATCH 1/2] st/omx_tizonia: add --enable-omx-tizonia flag and build files

wrote: > Thanks, I'll try something similar. > > One more question - WRT gst-omx, what target should I build - > generic or is something else/patch needed? I don't see tizonia with > current git. > > > Gurkirpal Singh wrote: > >> Hi, >> >> It is a

[Mesa-dev] [PATCH 4/7] st/omx/tizonia: Add entrypoint

Adds base files for adding components --- .../state_trackers/omx/tizonia/Makefile.sources| 4 ++- .../state_trackers/omx/tizonia/entrypoint.c| 37 ++ .../state_trackers/omx/tizonia/entrypoint.h| 35 3 files changed, 75 insertions(+), 1

[Mesa-dev] [PATCH 6/7] st/omx/tizonia: Add H.264 encoder

Example Gstreamer pipeline : gst-launch-1.0 filesrc location=movie.mp4 ! qtdemux ! h264parse ! avdec_h264 ! videoconvert ! omxh264enc ! h264parse ! avdec_h264 ! videoconvert ! ximagesink --- src/gallium/state_trackers/omx/Makefile.sources| 4 +-

[Mesa-dev] [PATCH 7/7] st/omx/tizonia/h264d: Add EGLImage support

Example Gstreamer pipeline : MESA_ENABLE_OMX_EGLIMAGE=1 GST_GL_API=gles2 GST_GL_PLATFORM=egl gst-launch-1.0 filesrc location=movie.mp4 ! qtdemux ! h264parse ! omxh264dec ! glimagesink --- src/gallium/state_trackers/omx/Makefile.am | 1 +

[Mesa-dev] [PATCH 3/7] st/omx/tizonia: Add --enable-omx-tizonia flag and build files

Allow only bellagio or tizonia to be used at the same time. Detect tizonia package config file Generate libomx_mesa.so and install it to libtizcore.pc::pluginsdir Only compile empty source (target.c) for now. GSoC Project link: https://summerofcode.withgoogle.com/projects/#4737166321123328 ---

[Mesa-dev] Refactored st/omx/tizonia commits

These are the refactored commits related to the GSoC project involving adding a st/omx state tracker using tizonia. There are still some parts of code that i didn't refactor yet as explained below: 1) I wasn't sure if it's okay to use #if-#else declaratives for function declarations. For eg: One

[Mesa-dev] [PATCH 1/7] gallium: Refactor out vl_put_screen and vl_get_screen

--- src/gallium/auxiliary/Makefile.sources | 2 + src/gallium/auxiliary/vl/vl_screen.c | 107 + src/gallium/auxiliary/vl/vl_screen.h | 33 +++ .../state_trackers/omx_bellagio/entrypoint.c | 83

Re: [Mesa-dev] Refactored st/omx/tizonia commits

, Leo Liu <leo@amd.com> wrote: > > > On 11/29/2017 12:23 PM, Christian König wrote: > > Am 29.11.2017 um 18:08 schrieb Gurkirpal Singh: > > > > On Wed, Nov 29, 2017 at 3:20 PM, Christian König < > ckoenig.leichtzumer...@gmail.com> wrote: > >

[Mesa-dev] [PATCH v2 5/6] st/omx/tizonia: Add H.264 encoder

v2: Refactor out screen functions to st/omx Example Gstreamer pipeline : gst-launch-1.0 filesrc location=movie.mp4 ! qtdemux ! h264parse ! avdec_h264 ! videoconvert ! omxh264enc ! h264parse ! avdec_h264 ! videoconvert ! ximagesink --- src/gallium/state_trackers/omx/Makefile.sources| 4 +-

[Mesa-dev] [PATCH v2 2/6] st/omx/tizonia: Add --enable-omx-tizonia flag and build files

Allow only bellagio or tizonia to be used at the same time. Detect tizonia package config file Generate libomx_mesa.so and install it to libtizcore.pc::pluginsdir Only compile empty source (target.c) for now. GSoC Project link: https://summerofcode.withgoogle.com/projects/#4737166321123328 ---

[Mesa-dev] [PATCH v2 3/6] st/omx/tizonia: Add entrypoint

Adds base files for adding components --- .../state_trackers/omx/tizonia/Makefile.sources| 4 ++- .../state_trackers/omx/tizonia/entrypoint.c| 37 ++ .../state_trackers/omx/tizonia/entrypoint.h| 35 3 files changed, 75 insertions(+), 1

[Mesa-dev] [PATCH v2 6/6] st/omx/tizonia/h264d: Add EGLImage support

Example Gstreamer pipeline : MESA_ENABLE_OMX_EGLIMAGE=1 GST_GL_API=gles2 GST_GL_PLATFORM=egl gst-launch-1.0 filesrc location=movie.mp4 ! qtdemux ! h264parse ! omxh264dec ! glimagesink --- src/gallium/state_trackers/omx/Makefile.am | 1 +

Re: [Mesa-dev] [PATCH 1/7] gallium: Refactor out vl_put_screen and vl_get_screen

ode in > st/omx. > > Yes. Please move them back to st/omx. > > With that fixed, the series are: > > Acked-by: Leo Liu <leo@amd.com> <leo@amd.com> > > Thanks for the work! > > Leo > > > > > Another reason is that the env var "OMX_REND

[Mesa-dev] [PATCH 2/6] st/omx/tizonia: Add --enable-omx-tizonia flag and build files

Allow only bellagio or tizonia to be used at the same time. Detect tizonia package config file Generate libomx_mesa.so and install it to libtizcore.pc::pluginsdir Only compile empty source (target.c) for now. GSoC Project link: https://summerofcode.withgoogle.com/projects/#4737166321123328

Re: [Mesa-dev] [PATCH 2/6] st/omx/tizonia: Add --enable-omx-tizonia flag and build files

son build in the current set. > I wasn't sure if the changes needed to be added to this commit or add a new commit. > > @Dylan, if possible, could you give an update for the Meson build on the > current set? > > > Thanks, > > Leo > > > > > On 01/17/2018 08

[Mesa-dev] [PATCH 6/6] st/omx/tizonia/h264d: Add EGLImage support

Example Gstreamer pipeline : MESA_ENABLE_OMX_EGLIMAGE=1 GST_GL_API=gles2 GST_GL_PLATFORM=egl gst-launch-1.0 filesrc location=movie.mp4 ! qtdemux ! h264parse ! omxh264dec ! glimagesink Acked-by: Leo Liu Reviewed-by: Julien Isorce ---

[Mesa-dev] [PATCH 5/6] st/omx/tizonia: Add H.264 encoder

v2: Refactor out screen functions to st/omx Example Gstreamer pipeline : gst-launch-1.0 filesrc location=movie.mp4 ! qtdemux ! h264parse ! avdec_h264 ! videoconvert ! omxh264enc ! h264parse ! avdec_h264 ! videoconvert ! ximagesink Acked-by: Leo Liu Reviewed-by: Julien Isorce

[Mesa-dev] [PATCH 3/6] st/omx/tizonia: Add entrypoint

Adds base files for adding components Acked-by: Leo Liu Reviewed-by: Julien Isorce --- .../state_trackers/omx/tizonia/Makefile.sources| 4 ++- .../state_trackers/omx/tizonia/entrypoint.c| 37 ++

Re: [Mesa-dev] [PATCH 1/7] gallium: Refactor out vl_put_screen and vl_get_screen

encoder on this machine right now. It could take a few weeks until I could do so. > > Leo > > On 12/04/2017 08:58 AM, Leo Liu wrote: > > > > On 12/03/2017 10:04 AM, Gurkirpal Singh wrote: > > I sent the modified patches in another thread a while ago. > Please revi

Re: [Mesa-dev] [PATCH 2/6] st/omx/tizonia: Add --enable-omx-tizonia flag and build files

put_screen’ > [-Werror=implicit-function-declaration] >omx_put_screen(); >^~ > cc1: some warnings being treated as errors > Makefile:682: recipe for target 'vid_enc.lo' failed > make[5]: *** [vid_enc.lo] Error 1 > > > Leo > > > > >

Re: [Mesa-dev] [PATCH 2/6] st/omx/tizonia: Add --enable-omx-tizonia flag and build files

Since patch 1 was rejected this time around for being too large I've also sent the series directly to Leo and Julien. On Sat, Jan 20, 2018 at 8:01 AM, Gurkirpal Singh <gurkirpal...@gmail.com> wrote: > I've added the right patches as a reply. > > Sry again for the inconvenience >

Re: [Mesa-dev] [PATCH 2/6] st/omx/tizonia: Add --enable-omx-tizonia flag and build files

Cheers > > Dylan > > Quoting Leo Liu (2018-01-17 08:23:54) > > > > > > On 01/17/2018 11:19 AM, Gurkirpal Singh wrote: > > > > > > > > On Wed, Jan 17, 2018 at 8:22 PM, Leo Liu <leo@amd.com> wrote: > > > >

[Mesa-dev] [PATCH 2/6] st/omx/tizonia: Add --enable-omx-tizonia flag and build files

Allow only bellagio or tizonia to be used at the same time. Detect tizonia package config file Generate libomx_mesa.so and install it to libtizcore.pc::pluginsdir Only compile empty source (target.c) for now. GSoC Project link: https://summerofcode.withgoogle.com/projects/#4737166321123328

[Mesa-dev] [PATCH 3/6] st/omx/tizonia: Add entrypoint

Adds base files for adding components Acked-by: Leo Liu Reviewed-by: Julien Isorce --- .../state_trackers/omx/tizonia/Makefile.sources| 4 ++- .../state_trackers/omx/tizonia/entrypoint.c| 37 ++

Re: [Mesa-dev] [PATCH 2/6] st/omx/tizonia: Add --enable-omx-tizonia flag and build files

I've added the right patches as a reply. Sry again for the inconvenience On Sat, Jan 20, 2018 at 3:38 AM, Gurkirpal Singh <gurkirpal...@gmail.com> wrote: > > > On Fri, Jan 19, 2018 at 8:30 PM, Leo Liu <leo@amd.com> wrote: > >> >> >> On 01/19/2018 0

[Mesa-dev] [PATCH 6/6] st/omx/tizonia/h264d: Add EGLImage support

Example Gstreamer pipeline : MESA_ENABLE_OMX_EGLIMAGE=1 GST_GL_API=gles2 GST_GL_PLATFORM=egl gst-launch-1.0 filesrc location=movie.mp4 ! qtdemux ! h264parse ! omxh264dec ! glimagesink Acked-by: Leo Liu Reviewed-by: Julien Isorce ---

[Mesa-dev] [PATCH 5/6] st/omx/tizonia: Add H.264 encoder

v2: Refactor out screen functions to st/omx Example Gstreamer pipeline : gst-launch-1.0 filesrc location=movie.mp4 ! qtdemux ! h264parse ! avdec_h264 ! videoconvert ! omxh264enc ! h264parse ! avdec_h264 ! videoconvert ! ximagesink Acked-by: Leo Liu Reviewed-by: Julien Isorce