Re: [Mesa-dev] [PATCH v4 1/8] tgsi/ureg: add ureg_UARL shortcut (v2)

2014-11-17 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin imir...@alum.mit.edu On Mon, Nov 17, 2014 at 10:58 AM, Axel Davy axel.d...@ens.fr wrote: From: Christoph Bumiller christoph.bumil...@speed.at v2: moved in in same order as in p_shader_tokens (thanks Brian) Reviewed-by: Marek Olšák marek.olsak at amd.com Signed-off

Re: [Mesa-dev] [PATCH v4 4/8] gallium/auxiliary: add inc and dec alternative with return (v2)

2014-11-17 Thread Ilia Mirkin
On Mon, Nov 17, 2014 at 10:58 AM, Axel Davy axel.d...@ens.fr wrote: From: Christoph Bumiller christoph.bumil...@speed.at At this moment we use only zero or positive values. v2: Implement it for also for Solaris, MSVC assembly and enable for other combinations. Signed-off-by: David

Re: [Mesa-dev] [PATCH v4 0/8] Gallium Nine

2014-11-17 Thread Ilia Mirkin
I'm not, in principle, opposed to merging st/nine into the tree. I've reviewed all the patches that I'm qualified to review (which is the vast minority of them -- 3 total), and I have outstanding feedback on one of them (the atomic stuff). I've asked Axel to provide a sample program which could

Re: [Mesa-dev] [PATCH v5] gallium/auxiliary: add inc and dec alternative with return (v3)

2014-11-17 Thread Ilia Mirkin
On Mon, Nov 17, 2014 at 1:20 PM, Axel Davy axel.d...@ens.fr wrote: From: Christoph Bumiller christoph.bumil...@speed.at At this moment we use only zero or positive values. v2: Implement it for also for Solaris, MSVC assembly and enable for other combinations. v3: Replace MSVC assembly

Re: [Mesa-dev] [PATCH] gallium/auxiliary: add inc and dec alternative with return (v4)

2014-11-17 Thread Ilia Mirkin
by assert + warning during compilation v4: remove inc and dec with return for MSVC assembly Reviewed-by: Ilia Mirkin imir...@alum.mit.edu I guess the people who care about MSVC will have to supply the implementation when something other than st/nine starts using these helpers. I think that's

Re: [Mesa-dev] [PATCH v5] gallium/auxiliary: add inc and dec alternative with return (v3)

2014-11-17 Thread Ilia Mirkin
On Mon, Nov 17, 2014 at 2:15 PM, Patrick Baggett baggett.patr...@gmail.com wrote: On Mon, Nov 17, 2014 at 12:20 PM, Axel Davy axel.d...@ens.fr wrote: From: Christoph Bumiller christoph.bumil...@speed.at At this moment we use only zero or positive values. v2: Implement it for also for

Re: [Mesa-dev] [PATCH] gallium/include/pipe: Added interface for atomic counter buffers in pipe

2014-11-17 Thread Ilia Mirkin
. You have mentioned in our previous conversation about the un-necessity of store. The spec for ARB_shader_image_load_store says imageStore(). If we are implementing the same for atomics, then we have to use store for it too. Thank you!! On Mon, Nov 17, 2014 at 11:28 AM, Ilia Mirkin imir

Re: [Mesa-dev] [PATCH] st/mesa: copy sampler_array_size field when copying instructions

2014-11-17 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin imir...@alum.mit.edu Ooops, I thought I had caught all of that :( On Mon, Nov 17, 2014 at 4:42 PM, Brian Paul bri...@vmware.com wrote: The sampler_array_size field was added by mesa/st: add support for dynamic sampler offsets. But the field wasn't getting copied

Re: [Mesa-dev] Mesa 10.3.4 candidate

2014-11-17 Thread Ilia Mirkin
I plan on checking in the multi-layer clear in the presence of scissor/color mask fix today or tomorrow, which should fix things for llvmpipe and nouveau. IMHO it'd be worth pulling that one in as well. It's not in yet, but just a heads-up. [Or were you planning on re-pulling on Wed?] On Mon, Nov

[Mesa-dev] [PATCH] nv50/ir: saturate FRC result to avoid completely bogus values

2014-11-17 Thread Ilia Mirkin
For values above integer accuracy in floats, val - floor(val) might actually produce a value greater than 1. For such large floats, it's reasonable to be imprecise, but it's unreasonable for FRC to return a value that is not between 0 and 1. Signed-off-by: Ilia Mirkin imir...@alum.mit.edu

Re: [Mesa-dev] [PATCH] nv50/ir: saturate FRC result to avoid completely bogus values

2014-11-18 Thread Ilia Mirkin
On Tue, Nov 18, 2014 at 8:54 AM, Roland Scheidegger srol...@vmware.com wrote: Am 18.11.2014 um 05:03 schrieb Ilia Mirkin: For values above integer accuracy in floats, val - floor(val) might actually produce a value greater than 1. For such large floats, it's reasonable to be imprecise

Re: [Mesa-dev] [PATCH] nv50/ir: saturate FRC result to avoid completely bogus values

2014-11-18 Thread Ilia Mirkin
On Tue, Nov 18, 2014 at 9:53 AM, Jose Fonseca jfons...@vmware.com wrote: On 18/11/14 14:34, Roland Scheidegger wrote: Am 18.11.2014 um 15:05 schrieb Ilia Mirkin: On Tue, Nov 18, 2014 at 8:54 AM, Roland Scheidegger srol...@vmware.com wrote: Am 18.11.2014 um 05:03 schrieb Ilia Mirkin

Re: [Mesa-dev] [PATCH v2 2/3] nvc0: use NV_VRAM_DOMAIN() macro

2014-11-18 Thread Ilia Mirkin
On Wed, Nov 19, 2014 at 12:41 AM, Alexandre Courbot acour...@nvidia.com wrote: Use the newly-introduced NV_VRAM_DOMAIN() macro to support alternative VRAM domains for chips that do not use dedicated video memory. Signed-off-by: Alexandre Courbot acour...@nvidia.com ---

[Mesa-dev] Bug in 48157b904a9 found by Coverity

2014-11-19 Thread Ilia Mirkin
Hey guys, Just got around to looking at the Coverity email about newly introduced bugs, and this seems like a legit issue. Based on the context of the code, I'm guessing you meant to do (input_index - 16) 1. Cheers, -ilia ** CID 1251308: Bad bit shift operation (BAD_SHIFT)

Re: [Mesa-dev] Bug in 48157b904a9 found by Coverity

2014-11-19 Thread Ilia Mirkin
On Wed, Nov 19, 2014 at 12:28 PM, Damien Lespiau damien.lesp...@intel.com wrote: On Wed, Nov 19, 2014 at 12:13:41PM -0500, Ilia Mirkin wrote: Hey guys, Just got around to looking at the Coverity email about newly introduced bugs, and this seems like a legit issue. Based on the context

Re: [Mesa-dev] Removing unused opcodes (TGSI, Mesa IR)

2014-11-19 Thread Ilia Mirkin
On Wed, Nov 19, 2014 at 2:32 PM, Eric Anholt e...@anholt.net wrote: Eric Anholt e...@anholt.net writes: This series removes a bunch of unused opcodes, mostly from TGSI. It doesn't go as far as we could possibly go -- while I welcome discussion for future patch series deleting more, I hope

Re: [Mesa-dev] Removing unused opcodes (TGSI, Mesa IR)

2014-11-19 Thread Ilia Mirkin
On Wed, Nov 19, 2014 at 3:45 PM, Jose Fonseca jfons...@vmware.com wrote: On 19/11/14 19:45, Ilia Mirkin wrote: On Wed, Nov 19, 2014 at 2:32 PM, Eric Anholt e...@anholt.net wrote: Eric Anholt e...@anholt.net writes: This series removes a bunch of unused opcodes, mostly from TGSI

Re: [Mesa-dev] [PATCH 1/3] glapi: Remove dead extension_helper.py.

2014-11-21 Thread Ilia Mirkin
On Fri, Nov 21, 2014 at 1:35 PM, Matt Turner matts...@gmail.com wrote: Dead since commit 3d16088f. --- src/mapi/glapi/gen/Makefile.am | 2 - src/mapi/glapi/gen/extension_helper.py | 324 - 2 files changed, 326 deletions(-) delete mode 100644

Re: [Mesa-dev] [PATCH 3/3] glapi: Remove dead mesadef.py.

2014-11-21 Thread Ilia Mirkin
What about src/mesa/drivers/windows/gdi/mesa.def -- it claims to be generated by mesadef.py. I have no idea what it is, but it should either also be deleted, or the mesadef.py script kept around. On Fri, Nov 21, 2014 at 1:35 PM, Matt Turner matts...@gmail.com wrote: Dead since commit 4e120c97,

Re: [Mesa-dev] [PATCH] glsl: Remove unused ast copy constructors.

2014-11-21 Thread Ilia Mirkin
On Fri, Nov 21, 2014 at 1:47 PM, Matt Turner matts...@gmail.com wrote: These were added in commits a760c738 and 43757135 to be used in implementing C-style aggregate initializers (commit 1b0d6aef). Paul rewrote that code in commit 0da1a2cc to use GLSL types, rather than AST types, leaving

Re: [Mesa-dev] [PATCH] glsl: Remove unused ast copy constructors.

2014-11-21 Thread Ilia Mirkin
On Fri, Nov 21, 2014 at 1:56 PM, Matt Turner matts...@gmail.com wrote: On Fri, Nov 21, 2014 at 10:52 AM, Ilia Mirkin imir...@alum.mit.edu wrote: On Fri, Nov 21, 2014 at 1:47 PM, Matt Turner matts...@gmail.com wrote: These were added in commits a760c738 and 43757135 to be used in implementing C

Re: [Mesa-dev] [PATCH] util: Prefer atomic intrinsics to inline assembly.

2014-11-21 Thread Ilia Mirkin
On Fri, Nov 21, 2014 at 6:18 PM, Matt Turner matts...@gmail.com wrote: Cuts a little more than 1k of .text size from i915g. This was previously done in commit 5f66b340 and subsequently reverted in commit 3661f757 after bug 30514 was filed. I believe the cause of bug 30514 wasn't anything

Re: [Mesa-dev] [PATCH 3/4] nine: handle D3DISSUE_END without previous D3DISSUE_BEGIN

2014-11-21 Thread Ilia Mirkin
On Fri, Nov 21, 2014 at 10:13 PM, David Heidelberg da...@ixit.cz wrote: From: John Ettedgui john.etted...@gmail.com This patch fixes black screen with games based on the Unreal Engine 3. It was tested that it fixed the issue in Tera Online, Borderlands 2 and Homefront. What's the actual

Re: [Mesa-dev] [PATCH 3/4] nine: handle D3DISSUE_END without previous D3DISSUE_BEGIN

2014-11-21 Thread Ilia Mirkin
On Sat, Nov 22, 2014 at 12:44 AM, John Ettedgui john.etted...@gmail.com wrote: On Fri Nov 21 2014 at 7:50:03 PM Ilia Mirkin imir...@alum.mit.edu wrote: What's the actual problem? If you mean in-game, a blocking black screen, the game wants to display something but is unable to and keeps

Re: [Mesa-dev] [PATCH 3/4] nine: handle D3DISSUE_END without previous D3DISSUE_BEGIN

2014-11-21 Thread Ilia Mirkin
On Sat, Nov 22, 2014 at 12:57 AM, Ilia Mirkin imir...@alum.mit.edu wrote: On Sat, Nov 22, 2014 at 12:44 AM, John Ettedgui john.etted...@gmail.com wrote: On Fri Nov 21 2014 at 7:50:03 PM Ilia Mirkin imir...@alum.mit.edu wrote: What's the actual problem? If you mean in-game, a blocking black

Re: [Mesa-dev] [PATCH 3/4] nine: handle D3DISSUE_END without previous D3DISSUE_BEGIN

2014-11-21 Thread Ilia Mirkin
On Sat, Nov 22, 2014 at 1:28 AM, John Ettedgui john.etted...@gmail.com wrote: On Fri Nov 21 2014 at 10:14:19 PM Ilia Mirkin imir...@alum.mit.edu wrote: Oh, I think i see the problem. In GetData: user_assert(This-state != NINE_QUERY_STATE_RUNNING, D3DERR_INVALIDCALL); should

Re: [Mesa-dev] [PATCH 3/4] nine: handle D3DISSUE_END without previous D3DISSUE_BEGIN

2014-11-21 Thread Ilia Mirkin
On Sat, Nov 22, 2014 at 1:45 AM, John Ettedgui john.etted...@gmail.com wrote: On Fri Nov 21 2014 at 10:36:29 PM Ilia Mirkin imir...@alum.mit.edu wrote: Right, I figured as much. My point is that doing what I'm proposing there would allow such usage even though it is illegal based on the API

Re: [Mesa-dev] [PATCH] i965: implement ARB_pipeline_statistics_query

2014-11-22 Thread Ilia Mirkin
On Sat, Nov 22, 2014 at 6:52 PM, Ben Widawsky benjamin.widaw...@intel.com wrote: This patch implements ARB_pipeline_statistics_query. This addition to GL does not add a new API. Instead, it adds new tokens to the existing query APIs. The work to hook up the new tokens is trivial due to it's

[Mesa-dev] [PATCH] nv50/ir: set neg modifiers on min/max args

2014-11-23 Thread Ilia Mirkin
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=86618 Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- src/gallium/drivers/nouveau/codegen/nv50_ir_emit_nv50.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_nv50.cpp b/src/gallium

Re: [Mesa-dev] [PATCH] i965: implement ARB_pipeline_statistics_query

2014-11-23 Thread Ilia Mirkin
On Sun, Nov 23, 2014 at 1:31 PM, Ben Widawsky b...@bwidawsk.net wrote: On Sun, Nov 23, 2014 at 02:12:10AM -0500, Ilia Mirkin wrote: On Sat, Nov 22, 2014 at 6:52 PM, Ben Widawsky benjamin.widaw...@intel.com wrote: This patch implements ARB_pipeline_statistics_query. This addition to GL does

Re: [Mesa-dev] [PATCH] i965: implement ARB_pipeline_statistics_query

2014-11-23 Thread Ilia Mirkin
On Sun, Nov 23, 2014 at 1:55 PM, Ben Widawsky benjamin.widaw...@intel.com wrote: On Sun, Nov 23, 2014 at 01:50:08PM -0500, Ilia Mirkin wrote: On Sun, Nov 23, 2014 at 1:31 PM, Ben Widawsky b...@bwidawsk.net wrote: On Sun, Nov 23, 2014 at 02:12:10AM -0500, Ilia Mirkin wrote: On Sat, Nov 22

Re: [Mesa-dev] [PATCH 06/11] st/nine: fix wrong variable reset

2014-11-23 Thread Ilia Mirkin
-by: David Heidelberg da...@ixit.cz Reviewed-by: Ilia Mirkin imir...@alum.mit.edu --- src/gallium/state_trackers/nine/nine_state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/nine/nine_state.c b/src/gallium/state_trackers/nine/nine_state.c

Re: [Mesa-dev] [PATCH 07/11] st/nine: remove unused pipe_viewport_state::translate[3] and scale[3]

2014-11-23 Thread Ilia Mirkin
Reviewed-by: Axel Davy axel.d...@ens.fr Signed-off-by: David Heidelberg da...@ixit.cz Reviewed-by: Ilia Mirkin imir...@alum.mit.edu --- src/gallium/state_trackers/nine/nine_state.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/gallium/state_trackers/nine/nine_state.c b/src/gallium

Re: [Mesa-dev] [PATCH 08/11] st/nine: Fix setting of the shift modifier in nine_shader

2014-11-23 Thread Ilia Mirkin
-by: David Heidelberg da...@ixit.cz Signed-off-by: Axel Davy axel.d...@ens.fr Reviewed-by: Ilia Mirkin imir...@alum.mit.edu --- src/gallium/state_trackers/nine/nine_shader.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/gallium/state_trackers/nine/nine_shader.c

Re: [Mesa-dev] [PATCH 01/11] st/nine: Refactor Resource9 BaseTexture9 Surface9 and Texture9 initialization

2014-11-23 Thread Ilia Mirkin
On Sun, Nov 23, 2014 at 5:40 PM, David Heidelberg da...@ixit.cz wrote: From: Axel Davy axel.d...@ens.fr First change is to pass initResource argument to initialise the resource field in Resource9 instead of in the parents. Second change is to pass Usage argument, instead of letting the

Re: [Mesa-dev] [PATCH 02/11] st/nine: call DBG() at more external entry points

2014-11-23 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin imir...@alum.mit.edu I wouldn't really bother with backporting this to 10.4, but similar comment as for previous change -- probably fine for this release. --- src/gallium/state_trackers/nine/basetexture9.c | 17 src/gallium/state_trackers/nine/cubetexture9.c

Re: [Mesa-dev] [PATCH 03/11] st/nine: propertly declare constants

2014-11-23 Thread Ilia Mirkin
also need this hack? If not, why not? In any case, this change is Reviewed-by: Ilia Mirkin imir...@alum.mit.edu -- 2.1.3 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 05/11] st/nine: return GetAvailableTextureMem in bytes as expected (v2)

2014-11-23 Thread Ilia Mirkin
...@lists.freedesktop.org Tested-by: Yaroslav Andrusyak pontost...@gmail.com Reviewed-by: Axel Davy axel.d...@ens.fr Signed-off-by: David Heidelberg da...@ixit.cz Reviewed-by: Ilia Mirkin imir...@alum.mit.edu --- src/gallium/state_trackers/nine/device9.c | 6 +- 1 file changed, 5 insertions(+), 1

Re: [Mesa-dev] [PATCH 09/11] st/nine: Rework queries

2014-11-23 Thread Ilia Mirkin
On Sun, Nov 23, 2014 at 5:40 PM, David Heidelberg da...@ixit.cz wrote: From: Axel Davy axel.d...@ens.fr From this moment we should handle errors same way as Wine does. Original patch from John Ettedgui john.etted...@gmail.com Cc: 10.4 mesa-sta...@lists.freedesktop.org Tested-by: David

Re: [Mesa-dev] [PATCH 10/11] st/nine: Handle queries not supported by the driver

2014-11-23 Thread Ilia Mirkin
On Sun, Nov 23, 2014 at 5:40 PM, David Heidelberg da...@ixit.cz wrote: From: Axel Davy axel.d...@ens.fr Cc: 10.4 mesa-sta...@lists.freedesktop.org Signed-off-by: Axel Davy axel.d...@ens.fr --- src/gallium/state_trackers/nine/device9.c | 2 +- src/gallium/state_trackers/nine/query9.c | 52

Re: [Mesa-dev] [PATCH 11/11] st/nine: return S_FALSE instead of INVALIDCALL when in building query state

2014-11-23 Thread Ilia Mirkin
On Sun, Nov 23, 2014 at 5:40 PM, David Heidelberg da...@ixit.cz wrote: From: Axel Davy axel.d...@ens.fr It is the same behaviour as wine has. Cc: 10.4 mesa-sta...@lists.freedesktop.org Reviewed-by: David Heidelberg da...@ixit.cz Signed-off-by: Axel Davy axel.d...@ens.fr ---

Re: [Mesa-dev] [PATCH] i965/Gen6-7: Do not replace texcoords with point coord if not drawing points

2014-11-24 Thread Ilia Mirkin
On Mon, Nov 24, 2014 at 2:33 PM, Chris Forbes chr...@ijw.co.nz wrote: Partially fixes broken rendering in Windows-based QtQuick2 apps run through Wine. This library sets all texture units' GL_COORD_REPLACE, leaves point sprite mode enabled, and then draws a triangle fan. Will need a

Re: [Mesa-dev] [PATCH 2/2] nouveau: Avoid pasting TGSI_OPCODE_ tokens together.

2014-11-24 Thread Ilia Mirkin
I like the macros Nouveau, and probably other drivers, do lits of token pasting on all sorts of gallium tokens. I think it makes the code considerably easier to read. On Nov 24, 2014 7:07 PM, Eric Anholt e...@anholt.net wrote: This made it harder to modify TGSI_OPCODE_ enums without breaking

Re: [Mesa-dev] [PATCH] mesa/glsl/glapi: enable GL_EXT_draw_buffers extension

2014-11-25 Thread Ilia Mirkin
On Tue, Nov 25, 2014 at 6:23 AM, Tapani Pälli tapani.pa...@intel.com wrote: Patch enables ES2 extension that utilizes existing ES3 functionality. Changes make all the subtests to run and pass in WebGL conformance test 'webgl-draw-buffers' when running Chrome on OpenGL ES. Signed-off-by:

Re: [Mesa-dev] [RFC] tegra: Initial support

2014-11-27 Thread Ilia Mirkin
On Thu, Nov 27, 2014 at 11:39 AM, Thierry Reding thierry.red...@gmail.com wrote: Tegra K1 and later use a GPU that can be driven by the Nouveau driver. But the GPU is a pure render node and has no display engine, hence the scanout needs to happen on the Tegra display hardware. The GPU and the

[Mesa-dev] sampler types in tgsi

2014-11-28 Thread Ilia Mirkin
Hello, It appears that the A3XX ISA (freedreno) requires the texture instruction to properly specify its output type (or at least f32 vs u32). Now I could stick this into a driver-local shader key, but it seems unfortunate since in glsl, it knows whether it's an int or float sampler. Would there

Re: [Mesa-dev] sampler types in tgsi

2014-11-29 Thread Ilia Mirkin
is complete except for component ordering. e.g. a shader can declare rgba16_snorm, but it cannot declare bgra16_snorm. Marek On Sat, Nov 29, 2014 at 8:43 AM, Jose Fonseca jfons...@vmware.com wrote: On 29/11/14 06:07, Roland Scheidegger wrote: Am 29.11.2014 um 06:12 schrieb Ilia Mirkin

Re: [Mesa-dev] sampler types in tgsi

2014-11-29 Thread Ilia Mirkin
was suggesting? Jose From: ibmir...@gmail.com [ibmir...@gmail.com] on behalf of Ilia Mirkin [imir...@alum.mit.edu] Sent: 29 November 2014 18:05 To: Marek Olšák Cc: Jose Fonseca; Roland Scheidegger; mesa-dev@lists.freedesktop.org Subject: Re: [Mesa-dev

[Mesa-dev] [PATCH] st/mesa: avoid exposing EXT_texture_integer for pre-GLSL 1.30

2014-11-29 Thread Ilia Mirkin
For drivers building up to GL(ES)3, only expose the actual extension if the API will let it be used (e.g. via overrides/debug flags that enable higher versions). Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- Technically this can also be used with EXT_gpu_shader4 and NV_gpu_shader4, neither

Re: [Mesa-dev] [PATCH 2/2] st/nine: Fix vertex declarations for non-standard (usage/index)

2014-12-01 Thread Ilia Mirkin
) as you're using, or the start, or probably other things. Count is unambiguous. I won't pretend to having looked at this whole patch with a high level of attention, but the concept seems fine in principle. Series is Acked-by: Ilia Mirkin imir...@alum.mit.edu

Re: [Mesa-dev] [PATCH v2 06/23] mesa: Fix incorrect assertion in init_teximage_fields_ms

2014-12-01 Thread Ilia Mirkin
On Mon, Dec 1, 2014 at 6:04 AM, Iago Toral Quiroga ito...@igalia.com wrote: _BaseFormat is a GLenum (unsigned int) so testing if its value is greater than 0 to detect the cases where _mesa_base_tex_format returns -1 doesn't work. Fixing the assertion breaks the

Re: [Mesa-dev] [PATCH v2 06/23] mesa: Fix incorrect assertion in init_teximage_fields_ms

2014-12-02 Thread Ilia Mirkin
On Tue, Dec 2, 2014 at 3:05 AM, Iago Toral ito...@igalia.com wrote: On Mon, 2014-12-01 at 13:25 -0500, Ilia Mirkin wrote: On Mon, Dec 1, 2014 at 6:04 AM, Iago Toral Quiroga ito...@igalia.com wrote: _BaseFormat is a GLenum (unsigned int) so testing if its value is greater than 0 to detect

Re: [Mesa-dev] [PATCH v2 06/23] mesa: Fix incorrect assertion in init_teximage_fields_ms

2014-12-02 Thread Ilia Mirkin
On Tue, Dec 2, 2014 at 8:24 AM, Ilia Mirkin imir...@alum.mit.edu wrote: On Tue, Dec 2, 2014 at 3:05 AM, Iago Toral ito...@igalia.com wrote: On Mon, 2014-12-01 at 13:25 -0500, Ilia Mirkin wrote: On Mon, Dec 1, 2014 at 6:04 AM, Iago Toral Quiroga ito...@igalia.com wrote: _BaseFormat

Re: [Mesa-dev] [Patch v3] Mesa: Add support for GL_OES_texture_*float* extensions.

2014-12-02 Thread Ilia Mirkin
On Tue, Dec 2, 2014 at 3:36 PM, Ian Romanick i...@freedesktop.org wrote: On 11/28/2014 01:08 PM, Kalyan Kondapally wrote: This patch adds support for following GLES2 Texture Float extensions: 1)GL_OES_texture_float, 2)GL_OES_texture_half_float, 3)GL_OES_texture_float_linear,

Re: [Mesa-dev] [PATCH 3/8] st/nine: Queries: Use gallium caps to get if queries are supported. (v2)

2014-12-02 Thread Ilia Mirkin
On Tue, Dec 2, 2014 at 4:12 PM, Axel Davy axel.d...@ens.fr wrote: Some queries need the driver to advertise a cap to be supported. For example r300 doesn't support them. v2 (David): check also for PIPE_CAP_QUERY_PIPELINE_STATISTICS, fix wine tests on r300g Reviewed-by: David

Re: [Mesa-dev] [PATCH 5/8] st/nine: Queries: Fix D3DISSUE_END behaviour.

2014-12-02 Thread Ilia Mirkin
On Tue, Dec 2, 2014 at 4:12 PM, Axel Davy axel.d...@ens.fr wrote: Issuing D3DISSUE_END should: . reset previous queries if possible . end the query Previous behaviour wasn't calling end_query for queries not needing D3DISSUE_BEGIN, no resetting noR resetting previous queries. This fixes

Re: [Mesa-dev] [PATCH 8/8] st/nine: Queries: Always return D3D_OK when issuing with D3DISSUE_BEGIN

2014-12-02 Thread Ilia Mirkin
With the very minor corrections I've mentioned earlier, series is Reviwed-by: Ilia Mirkin imir...@alum.mit.edu On Tue, Dec 2, 2014 at 4:12 PM, Axel Davy axel.d...@ens.fr wrote: This is the behaviour that wine tests. Reviewed-by: David Heidelberg da...@ixit.cz Signed-off-by: Axel Davy axel.d

Re: [Mesa-dev] [PATCH] [v2] i965: implement ARB_pipeline_statistics_query

2014-12-02 Thread Ilia Mirkin
it to relnotes though... the file's been created already - Move the new tokens to a new XML doc instead of using the main GL4x.xml (Ilia) - Add a fallthrough comment (Ilia) - Only divide PS invocations by 4 on HSW+ (Ben) Cc: Ilia Mirkin imir...@alum.mit.edu Signed-off-by: Ben Widawsky b

Re: [Mesa-dev] [PATCH] [v2] i965: implement ARB_pipeline_statistics_query

2014-12-02 Thread Ilia Mirkin
On Tue, Dec 2, 2014 at 11:20 PM, Ben Widawsky b...@bwidawsk.net wrote: On Tue, Dec 02, 2014 at 10:47:37PM -0500, Ilia Mirkin wrote: On Tue, Dec 2, 2014 at 9:33 PM, Ben Widawsky benjamin.widaw...@intel.com wrote: This patch implements ARB_pipeline_statistics_query. This addition to GL does

[Mesa-dev] [PATCH] mesa: expose GL_EXT_texture_sRGB_decode in ES2 contexts

2014-12-04 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- https://www.opengl.org/registry/specs/EXT/texture_sRGB_decode.txt Explicitly talks about ES, other drivers seem to expose it. Not sure about ES1. src/mesa/main/extensions.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH] mesa: expose GL_EXT_texture_sRGB_decode in ES2 contexts

2014-12-04 Thread Ilia Mirkin
Oh hm. Apparently EXT_sRGB is required for this [or ES3, but that's not available on the driver I'm interested quite yet]. I'll see if that can be added easily. On Thu, Dec 4, 2014 at 12:42 PM, Ilia Mirkin imir...@alum.mit.edu wrote: Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- https

[Mesa-dev] [PATCH 1/3] util/primconvert: pass index bias through

2014-12-04 Thread Ilia Mirkin
The index_bias (aka base_vertex) applies to the downstream draw just as much, since the actual index values are never modified. Signed-off-by: Ilia Mirkin imir...@alum.mit.edu Cc: 10.3 10.4 mesa-sta...@lists.freedesktop.org --- src/gallium/auxiliary/indices/u_primconvert.c | 1 + 1 file changed

[Mesa-dev] [PATCH 3/3] util/primconvert: take ib offset into account

2014-12-04 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin imir...@alum.mit.edu Cc: 10.4 10.3 mesa-sta...@lists.freedesktop.org --- src/gallium/auxiliary/indices/u_primconvert.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/indices/u_primconvert.c b/src/gallium/auxiliary/indices

[Mesa-dev] [PATCH 2/3] util/primconvert: support instanced rendering

2014-12-04 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin imir...@alum.mit.edu Cc: 10.3 10.4 mesa-sta...@lists.freedesktop.org --- src/gallium/auxiliary/indices/u_primconvert.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/auxiliary/indices/u_primconvert.c b/src/gallium/auxiliary/indices/u_primconvert.c

Re: [Mesa-dev] [PATCH 2/3] util/primconvert: support instanced rendering

2014-12-04 Thread Ilia Mirkin
On Thu, Dec 4, 2014 at 7:34 PM, Brian Paul bri...@vmware.com wrote: On 12/04/2014 05:01 PM, Ilia Mirkin wrote: Signed-off-by: Ilia Mirkin imir...@alum.mit.edu Cc: 10.3 10.4 mesa-sta...@lists.freedesktop.org --- src/gallium/auxiliary/indices/u_primconvert.c | 2 ++ 1 file changed, 2

Re: [Mesa-dev] [PATCH 3/3] util/primconvert: take ib offset into account

2014-12-05 Thread Ilia Mirkin
On Fri, Dec 5, 2014 at 9:10 AM, Jose Fonseca jfons...@vmware.com wrote: On 05/12/14 00:01, Ilia Mirkin wrote: Signed-off-by: Ilia Mirkin imir...@alum.mit.edu Cc: 10.4 10.3 mesa-sta...@lists.freedesktop.org --- src/gallium/auxiliary/indices/u_primconvert.c | 2 +- 1 file changed, 1

Re: [Mesa-dev] [PATCH] util/primconvert: Avoid point arithmetic; apply offset on all cases.

2014-12-05 Thread Ilia Mirkin
On Fri, Dec 5, 2014 at 9:16 AM, Jose Fonseca jfons...@vmware.com wrote: From: José Fonseca jfons...@vmware.com Matches what u_vbuf_get_minmax_index() does. Hm, nouveau nv50 (and probably nvc0) does: if (ib-buffer) { nv50-idxbuf.offset = ib-offset;

Re: [Mesa-dev] [PATCH] util/primconvert: Avoid point arithmetic; apply offset on all cases.

2014-12-05 Thread Ilia Mirkin
On Fri, Dec 5, 2014 at 9:18 AM, Ilia Mirkin imir...@alum.mit.edu wrote: On Fri, Dec 5, 2014 at 9:16 AM, Jose Fonseca jfons...@vmware.com wrote: From: José Fonseca jfons...@vmware.com Matches what u_vbuf_get_minmax_index() does. Hm, nouveau nv50 (and probably nvc0) does: if (ib-buffer

Re: [Mesa-dev] [PATCH] util/primconvert: Avoid point arithmetic; apply offset on all cases.

2014-12-05 Thread Ilia Mirkin
On Fri, Dec 5, 2014 at 9:29 AM, Jose Fonseca jfons...@vmware.com wrote: On 05/12/14 14:18, Ilia Mirkin wrote: On Fri, Dec 5, 2014 at 9:16 AM, Jose Fonseca jfons...@vmware.com wrote: From: José Fonseca jfons...@vmware.com Matches what u_vbuf_get_minmax_index() does. Hm, nouveau nv50

Re: [Mesa-dev] [PATCH] tgsi/lowering: add support to lower TXP

2014-12-06 Thread Ilia Mirkin
. Reviewed-by: Ilia Mirkin imir...@alum.mit.edu src/gallium/auxiliary/tgsi/tgsi_lowering.c | 35 -- src/gallium/auxiliary/tgsi/tgsi_lowering.h | 3 +++ 2 files changed, 27 insertions(+), 11 deletions(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_lowering.c b/src

Re: [Mesa-dev] [PATCH 08/18] radeonsi: get info about VS outputs from tgsi_shader_info

2014-12-09 Thread Ilia Mirkin
On Tue, Dec 9, 2014 at 6:39 AM, Marek Olšák mar...@gmail.com wrote: From: Marek Olšák marek.ol...@amd.com --- src/gallium/drivers/radeonsi/si_shader.c | 27 src/gallium/drivers/radeonsi/si_shader.h | 11 +-

Re: [Mesa-dev] [PATCH 08/18] radeonsi: get info about VS outputs from tgsi_shader_info

2014-12-09 Thread Ilia Mirkin
? 0 : sctx-queued.named.rasterizer-clip_plane_enable SIX_BITS) Marek On Tue, Dec 9, 2014 at 3:48 PM, Ilia Mirkin imir...@alum.mit.edu wrote: On Tue, Dec 9, 2014 at 6:39 AM, Marek Olšák mar...@gmail.com wrote: From: Marek Olšák marek.ol...@amd.com --- src/gallium/drivers/radeonsi

Re: [Mesa-dev] [PATCH 08/18] radeonsi: get info about VS outputs from tgsi_shader_info

2014-12-09 Thread Ilia Mirkin
On Tue, Dec 9, 2014 at 10:22 AM, Marek Olšák mar...@gmail.com wrote: It looks like clip planes are deprecated, so you can only use them with the compatibility profile. Right. Sure we could support 8 clip planes if ClipVertex is written, but: - we can only support 6 clip planes if ClipVertex

Re: [Mesa-dev] [PATCH 1/5] gallium/util: add a helper util_create_shader_from_text, cleanup some code

2014-12-09 Thread Ilia Mirkin
On Tue, Dec 9, 2014 at 6:28 AM, Marek Olšák mar...@gmail.com wrote: diff --git a/src/gallium/auxiliary/util/u_simple_shaders.h b/src/gallium/auxiliary/util/u_simple_shaders.h index dd282e0..12f50f8 100644 --- a/src/gallium/auxiliary/util/u_simple_shaders.h +++

Re: [Mesa-dev] [PATCH 1/3] gallium: add TGSI_SEMANTIC_VERTEXID_ZEROBASE and TGSI_SEMANTIC_BASEVERTEX

2014-12-11 Thread Ilia Mirkin
On Thu, Dec 11, 2014 at 11:39 AM, Jose Fonseca jfons...@vmware.com wrote: Overall I think this is a great cleanup. Just a remark about the chosen names. On 10/12/14 21:22, srol...@vmware.com wrote: From: Roland Scheidegger srol...@vmware.com Plus a new PIPE_CAP_VERTEXID_NOOFFSET query.

Re: [Mesa-dev] Precision of float and trigonometric functions on i965

2014-12-11 Thread Ilia Mirkin
On Thu, Dec 11, 2014 at 2:10 PM, Chris Forbes chr...@ijw.co.nz wrote: Iago, This doesn't matter for GL conformance -- but the impression I get is that dEQP is aiming at something more. In any case, the usual problem with this is inaccurate range reduction, which is fixable in software at

Re: [Mesa-dev] [PATCH v3 13/24] configure: require python mako module

2014-12-11 Thread Ilia Mirkin
On Tue, Dec 9, 2014 at 7:06 AM, Iago Toral Quiroga ito...@igalia.com wrote: From: Samuel Iglesias Gonsalvez sigles...@igalia.com It is now a hard dependency because of the autogeneration of format pack and unpack functions. Update the documentation to reflect this change. v2: - Inline

Re: [Mesa-dev] [PATCH] tgsi: lowering support for alpha test

2014-12-19 Thread Ilia Mirkin
On Fri, Dec 19, 2014 at 2:11 PM, Rob Clark robdcl...@gmail.com wrote: From: Rob Clark robcl...@freedesktop.org This emulates alpha-test with a compare + KILL_IF. The alpha-ref value is passed to the shader via constant tagged with new ALPHAREF semantic. For example: FRAG PROPERTY

Re: [Mesa-dev] [PATCH] tgsi: lowering support for alpha test

2014-12-19 Thread Ilia Mirkin
On Fri, Dec 19, 2014 at 4:04 PM, Rob Clark robdcl...@gmail.com wrote: On Fri, Dec 19, 2014 at 3:50 PM, Ilia Mirkin imir...@alum.mit.edu wrote: On Fri, Dec 19, 2014 at 2:11 PM, Rob Clark robdcl...@gmail.com wrote: From: Rob Clark robcl...@freedesktop.org This emulates alpha-test with a compare

Re: [Mesa-dev] [PATCH] tgsi: lowering support for alpha test

2014-12-19 Thread Ilia Mirkin
On Fri, Dec 19, 2014 at 4:47 PM, Rob Clark robdcl...@gmail.com wrote: On Fri, Dec 19, 2014 at 4:26 PM, Ilia Mirkin imir...@alum.mit.edu wrote: On Fri, Dec 19, 2014 at 4:04 PM, Rob Clark robdcl...@gmail.com wrote: On Fri, Dec 19, 2014 at 3:50 PM, Ilia Mirkin imir...@alum.mit.edu wrote: On Fri

Re: [Mesa-dev] [PATCH] gallium: add double opcodes and TGSI execution (v2.1)

2014-12-23 Thread Ilia Mirkin
On Tue, Dec 23, 2014 at 10:42 PM, Dave Airlie airl...@gmail.com wrote: +#define TGSI_OPCODE_DRCP208 /* eg, cayman */ +#define TGSI_OPCODE_DSQRT 209 /* eg, cayman also has DRSQ */ Adding DRSQ seems like a good idea, at least for graphics with floats its more

Re: [Mesa-dev] [PATCH 1/2] gallium/st: Clean up Haiku depth mapping, fix colorspace errors

2014-12-27 Thread Ilia Mirkin
On Sat, Dec 27, 2014 at 1:13 AM, Alexander von Gluck IV kallis...@unixzen.com wrote: --- src/gallium/state_trackers/hgl/hgl.c | 48 + 1 files changed, 19 insertions(+), 29 deletions(-) diff --git a/src/gallium/state_trackers/hgl/hgl.c

[Mesa-dev] [PATCH 1/2] nv50: regenerate rnndb headers

2014-12-30 Thread Ilia Mirkin
of the headergen'd headers was done. Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- src/gallium/drivers/nouveau/nv50/nv50_2d.xml.h | 133 +++--- src/gallium/drivers/nouveau/nv50/nv50_3d.xml.h | 449 +++-- src/gallium/drivers/nouveau/nv50/nv50_3ddefs.xml.h | 55 ++- src

[Mesa-dev] [PATCH 1/4] glapi: add GL_EXT_polygon_offset_clamp

2014-12-30 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- src/mapi/glapi/gen/gl_API.xml | 11 +++ src/mesa/main/polygon.c | 6 ++ src/mesa/main/polygon.h | 5 - 3 files changed, 21 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/gl_API.xml b/src/mapi/glapi

[Mesa-dev] [PATCH 3/4] i965/gen6+: enable EXT_polygon_offset_clamp

2014-12-30 Thread Ilia Mirkin
Replace the hard-coded 0's with the context clamp value. Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- docs/relnotes/10.5.0.html| 1 + src/mesa/drivers/dri/i965/gen6_sf_state.c| 2 +- src/mesa/drivers/dri/i965/gen7_sf_state.c| 2 +- src/mesa/drivers/dri/i965

[Mesa-dev] [PATCH 4/4] st/mesa: add EXT_polygon_offset_clamp support

2014-12-30 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- docs/relnotes/10.5.0.html | 2 +- src/mesa/state_tracker/st_atom_rasterizer.c | 1 + src/mesa/state_tracker/st_extensions.c | 5 + 3 files changed, 7 insertions(+), 1 deletion(-) diff --git a/docs/relnotes/10.5.0.html

[Mesa-dev] [PATCH 2/4] mesa: add support for GL_EXT_polygon_offset_clamp

2014-12-30 Thread Ilia Mirkin
Nothing enables the extension yet, but the values are now available. The spec calls for it to only be exposed for GL 3.3+, which is core-only in mesa. Restrict it as such so that drivers enabling the extension don't end up accidentally exposing the function in compat contexts. Signed-off-by: Ilia

Re: [Mesa-dev] [PATCH 4/4] st/mesa: add EXT_polygon_offset_clamp support

2014-12-31 Thread Ilia Mirkin
On Wed, Dec 31, 2014 at 3:03 PM, Eric Anholt e...@anholt.net wrote: Ilia Mirkin imir...@alum.mit.edu writes: Signed-off-by: Ilia Mirkin imir...@alum.mit.edu VC4 doesn't support this, so it shouldn't be enabled by default. VC4 also doesn't support core contexts. The extension is supposed

[Mesa-dev] [PATCH] nv50/ir: fold MAD when one of the multiplicands is const

2014-12-31 Thread Ilia Mirkin
Fold MAD dst, src0, immed, src2 (or src0/immed swapped) when - immed = 0 - MOV dst, src2 - immed = +/- 1 - ADD dst, src0, src2 These types of MAD pattersn were observed in some st/nine shaders. Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- Haven't tested this enough to push yet

Re: [Mesa-dev] [PATCH 2/4] mesa: add support for GL_EXT_polygon_offset_clamp

2015-01-02 Thread Ilia Mirkin
On Thu, Jan 1, 2015 at 4:58 AM, Ilia Mirkin imir...@alum.mit.edu wrote: On Thu, Jan 1, 2015 at 4:44 AM, Kenneth Graunke kenn...@whitecape.org wrote: On Wednesday, December 31, 2014 02:38:12 AM Ilia Mirkin wrote: Nothing enables the extension yet, but the values are now available. The spec

Re: [Mesa-dev] [PATCH 2/4] mesa: add support for GL_EXT_polygon_offset_clamp

2015-01-01 Thread Ilia Mirkin
On Thu, Jan 1, 2015 at 4:44 AM, Kenneth Graunke kenn...@whitecape.org wrote: On Wednesday, December 31, 2014 02:38:12 AM Ilia Mirkin wrote: Nothing enables the extension yet, but the values are now available. The spec calls for it to only be exposed for GL 3.3+, which is core-only in mesa

Re: [Mesa-dev] [PATCH 1/2] mesa: Add support for the ARB_pipeline_statisticcs_Query extension

2015-01-02 Thread Ilia Mirkin
shader support still won't build, so it's stubbed out. Cc: Jordan Justen jljus...@gmail.com Cc: Ilia Mirkin imir...@alum.mit.edu Signed-off-by: Ben Widawsky b...@bwidawsk.net --- .../glapi/gen/ARB_pipeline_statistics_query.xml| 24 +++ src/mapi/glapi/gen/Makefile.am

Re: [Mesa-dev] [PATCH 3/3] tgsi: add support for flt64 constants

2015-02-04 Thread Ilia Mirkin
constants against a flt32 constant in the matching code, we need to make sure we treat both parts of the flt64 as an single structure. Cleaned up printing/parsing by Ilia Mirkin imir...@alum.mit.edu Signed-off-by: Dave Airlie airl...@redhat.com Reviewed-by: Ilia Mirkin imir...@alum.mit.edu

Re: [Mesa-dev] [PATCH 1/3] gallium: add double opcodes and TGSI execution (v3.1)

2015-02-04 Thread Ilia Mirkin
On Wed, Feb 4, 2015 at 8:08 PM, Dave Airlie airl...@gmail.com wrote: This patch adds support for a set of double opcodes to TGSI. It is an update of work done originally by Michal Krol on the gallium-double-opcodes branch. The opcodes have a hint where they came from in the header file.

Re: [Mesa-dev] [PATCH 00/13] add fp64 support to mesa and glsl compiler

2015-02-04 Thread Ilia Mirkin
Oh, and you can find this branch at https://github.com/imirkin/mesa.git fp64-2 https://github.com/imirkin/mesa/commits/fp64-2 This includes the gallium, st/mesa, and nvc0 patches as well. On Thu, Feb 5, 2015 at 2:27 AM, Ilia Mirkin imir...@alum.mit.edu wrote: These patches have been around

[Mesa-dev] [PATCH 01/13] glapi: add ARB_gpu_shader_fp64 (v2)

2015-02-04 Thread Ilia Mirkin
From: Dave Airlie airl...@redhat.com Just add the xml file covering this extension, and dummy interface files in mesa, and fix up sanity tests. v2: Enable ProgramUniform*d* from ARB_separate_shader_objects (Ian) use 40 instead of 43 for dispatch_sanity.cpp (Chris) uncomment PU sanity tests.

[Mesa-dev] [PATCH 02/13] mesa: add ARB_gpu_shader_fp64 extension info (v2)

2015-02-04 Thread Ilia Mirkin
From: Dave Airlie airl...@redhat.com This just adds the entries to extensions.c and mtypes.h v2: use core profile only (Ian) Signed-off-by: Dave Airlie airl...@redhat.com --- src/mesa/main/extensions.c | 1 + src/mesa/main/mtypes.h | 1 + 2 files changed, 2 insertions(+) diff --git

[Mesa-dev] [PATCH 03/13] mesa: add mesa_type_is_double helper function (v2)

2015-02-04 Thread Ilia Mirkin
From: Dave Airlie airl...@gmail.com This is a helper to return if a type is based on a double. v2: GLboolean-bool (Ian) Reviewed-by: Ian Romanick ian.d.roman...@intel.com Signed-off-by: Dave Airlie airl...@redhat.com --- src/mesa/program/prog_parameter.h | 22 ++ 1 file

[Mesa-dev] [PATCH 04/13] glsl: add double type

2015-02-04 Thread Ilia Mirkin
From: Dave Airlie airl...@redhat.com This just adds a placeholder for the GLSL_TYPE_DOUBLE. This causes a lot of warnings about unchecked type in switch statements - fix them later. Signed-off-by: Dave Airlie airl...@redhat.com --- src/glsl/glsl_types.h | 1 + 1 file changed, 1 insertion(+)

[Mesa-dev] [PATCH 12/13] glsl: lower double optional passes (v2)

2015-02-04 Thread Ilia Mirkin
From: Dave Airlie airl...@gmail.com These lowering passes are optional for the backend to request, currently the TGSI softpipe backend most likely the r600g backend would want to use these passes as is. They aim to hit the gallium opcodes from the standard rounding/truncation functions. v2: also

<    5   6   7   8   9   10   11   12   13   14   >