Re: [Mesa-dev] Gallium pixel formats on big-endian

2013-01-31 Thread Michel Dänzer
the best solution is. I'm mainly trying to raise awareness of the issues. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Debian, X and DRI developer ___ mesa-dev mailing list mesa-dev

Re: [Mesa-dev] Regading OpenGLES2 on Linux

2013-01-31 Thread Michel Dänzer
without opengl and openles2, we want to know whether mesa-demos opengles2 folder will compile without any issues? or any code changes required to compile the es2 demos? for X11. None of this should matter for the compilation of the demos. -- Earthling Michel Dänzer

Re: [Mesa-dev] [PATCH 1/3] trace: allow GALLIUM_TRACE=stdout/stderr

2013-01-31 Thread Michel Dänzer
'? :) Slightly more seriously, I have /dev/std{out,err} files for the purpose of this patch, but I suppose those probably aren't available everywhere this code can run... -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Debian

Re: [Mesa-dev] [PATCH] mesa: adjust usage of swapBytes/littleEndian in format_matches_format_and_type

2013-01-31 Thread Michel Dänzer
for GL_INT. :) - for 8_8 formats, instead of littleEndian !swapBytes, use littleEndian != swapBytes to include big endian hosts Based on suggestions from Michel Dänzer. Thanks for tackling this! case MESA_FORMAT_DUDV8: return (format == GL_DU8DV8_ATI || format == GL_DUDV_ATI

[Mesa-dev] [PATCH v2] configure.ac: Disable GLX if OpenGL is not enabled

2013-01-31 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com GLX uses mapi/glapi/libglapi.la, which is only built for OpenGL. NOTE: This is a candidate for the stable branches. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=59364 Tested-by: Tom Stellard thomas.stell...@amd.com Signed-off-by: Michel

Re: [Mesa-dev] [PATCH] mesa: adjust usage of swapBytes/littleEndian in format_matches_format_and_type

2013-01-31 Thread Michel Dänzer
On Don, 2013-01-31 at 18:03 +0100, Marek Olšák wrote: On Thu, Jan 31, 2013 at 5:39 PM, Michel Dänzer mic...@daenzer.net wrote: I'm afraid these are not quite correct yet. I'm not 100% sure after looking at the red book and the GL 3.x spec — this is head spinning material, isn't

Re: [Mesa-dev] [PATCH 2/2] radeonsi: port some of get_shader_param changes from r600g

2013-01-31 Thread Michel Dänzer
; - else - return 32; + return 32; case PIPE_SHADER_CAP_MAX_TEMPS: return 256; /* Max native temporaries. */ case PIPE_SHADER_CAP_MAX_ADDRS: Reviewed-by: Michel Dänzer michel.daen...@amd.com P.S. The subject of patch 1 should say

[Mesa-dev] [PATCH 3/4] R600/SI: Make sample intrinsic address parameter type overloaded.

2013-02-01 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com Handle vectors of 1 to 16 integers. Change the intrinsic names to prevent the wrong one from being selected at runtime due to the overloading. Signed-off-by: Michel Dänzer michel.daen...@amd.com --- lib/Target/R600/SIInstrInfo.td|2 +- lib

[Mesa-dev] [PATCH 1/4] R600: Consolidate sub register indices.

2013-02-01 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com Use sub0-15 everywhere. Signed-off-by: Michel Dänzer michel.daen...@amd.com --- lib/Target/R600/AMDGPUInstructions.td |4 +-- lib/Target/R600/AMDGPURegisterInfo.cpp | 32 ++--- lib/Target/R600/AMDGPURegisterInfo.td |7

[Mesa-dev] [PATCH 0/4] R600: SI sample intrinsic improvements

2013-02-01 Thread Michel Dänzer
This series and the corresponding radeonsi series get shadow samplers and texture arrays mostly working and fix a bunch of other piglit failures, gaining just shy of 100 piglits. [PATCH 1/4] R600: Consolidate sub register indices. [PATCH 2/4] R600/SI: Add basic support for more integer vector

[Mesa-dev] [PATCH 2/4] R600/SI: Add basic support for more integer vector types.

2013-02-01 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com v1i32, v2i32, v8i32 and v16i32. Only add VGPR register classes for integer vector types, to avoid attempts copying from VGPR to SGPR registers, which is not possible. Signed-off-by: Michel Dänzer michel.daen...@amd.com --- lib/Target/R600

[Mesa-dev] [PATCH 4/4] R600/SI: Use proper instructions for array/shadow samplers.

2013-02-01 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com Signed-off-by: Michel Dänzer michel.daen...@amd.com --- lib/Target/R600/R600Instructions.td | 16 - lib/Target/R600/SIInstructions.td | 42 --- 2 files changed, 54 insertions(+), 4 deletions(-) diff

[Mesa-dev] [PATCH 2/4] radeonsi: Improve packing of texture address parameters.

2013-02-01 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com In particular, the LOD bias and depth comparison values are packed before the 'normal' texture coordinates, and the array slice and LOD values are appended. Signed-off-by: Michel Dänzer michel.daen...@amd.com --- src/gallium/drivers/radeonsi

[Mesa-dev] [PATCH 1/4] radeonsi: Adapt to sample intrinsics changes.

2013-02-01 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com Fix up intrinsic names, and bitcast texture address parameters to integers. Signed-off-by: Michel Dänzer michel.daen...@amd.com --- src/gallium/drivers/radeon/radeon_llvm.h |2 +- .../drivers/radeon/radeon_setup_tgsi_llvm.c| 50

[Mesa-dev] [PATCH 3/4] radeonsi: Enable texture arrays.

2013-02-01 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com 28/30 piglit tests pass. Signed-off-by: Michel Dänzer michel.daen...@amd.com --- src/gallium/drivers/radeonsi/radeonsi_pipe.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/radeonsi_pipe.c b/src

[Mesa-dev] [PATCH 4/4] radeonsi: Remove spurious traces of R16G16B16 support.

2013-02-01 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com The hardware can't do it, and these were causing warnings in some piglit tests. Signed-off-by: Michel Dänzer michel.daen...@amd.com --- src/gallium/drivers/radeonsi/si_state.c |3 --- 1 file changed, 3 deletions(-) diff --git a/src/gallium/drivers

Re: [Mesa-dev] [PATCH 0/3] structurizer bugfixes

2013-02-01 Thread Michel Dänzer
Tom provided without causing any regression. So please test again, and apply if it now works correctly. Git complained about the patches introducing trailing whitespace, but the series is Tested-by: Michel Dänzer michel.daen...@amd.com -- Earthling Michel Dänzer

Re: [Mesa-dev] [PATCH 2/4] gallium: add facilities for indirect drawing

2013-02-03 Thread Michel Dänzer
; /* SWTCL-only features. */ Thanks for adding the cap to r300g, but what about r600g and radeonsi? -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Debian, X and DRI developer ___ mesa-dev

[Mesa-dev] [PATCH] R600/SI: Add pattern for flog2.

2013-02-04 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com 22 more little piglits with radeonsi. Signed-off-by: Michel Dänzer michel.daen...@amd.com --- lib/Target/R600/SIInstructions.td |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/Target/R600/SIInstructions.td b/lib/Target

Re: [Mesa-dev] [PATCH 1/2] R600/SI: add proper 64bit immediate support

2013-02-04 Thread Michel Dänzer
(HI32 imm:$imm)), high) +; You need to rebase this onto my changes Tom just pushed to his master branch, using 'sub0' instead of 'low' and 'sub1' instead of 'high'. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Debian

[Mesa-dev] [PATCH] R600/SI: Add pattern for mul.

2013-02-04 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com 20 more little piglits with radeonsi. Signed-off-by: Michel Dänzer michel.daen...@amd.com --- lib/Target/R600/SIInstructions.td |4 1 file changed, 4 insertions(+) diff --git a/lib/Target/R600/SIInstructions.td b/lib/Target/R600

Re: [Mesa-dev] Gallium pixel formats on big-endian

2013-02-04 Thread Michel Dänzer
? :) But I'm happy to let those that will do this work decide. Likewise. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Debian, X and DRI developer ___ mesa-dev mailing list mesa-dev

Re: [Mesa-dev] Gallium pixel formats on big-endian

2013-02-05 Thread Michel Dänzer
On Mon, 2013-02-04 at 20:17 +0100, Michel Dänzer wrote: [...] how about something like this: Define the packing to be in the host byte order. However, do not define array formats as packed values (which makes little sense e.g. for *32*32*32*32 anyway) but really just as arrays. 16- or 32

Re: [Mesa-dev] [PATCH 2/2] radeonsi: remove constant index limitation v2

2013-02-05 Thread Michel Dänzer
*/ case PIPE_SHADER_CAP_MAX_CONSTS: - return 64; + return 4096; Where does the value 4096 come from? Maybe add a comment. Other than that, this series is Reviewed-by: Michel Dänzer michel.daen...@amd.com Also, this series and the LLVM series are Tested-by: Michel

[Mesa-dev] [PATCH 1/2] radeonsi: Don't advertise PIPE_FORMAT_L8A8_SRGB support.

2013-02-05 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com The hardware can't do it. Signed-off-by: Michel Dänzer michel.daen...@amd.com --- src/gallium/drivers/radeonsi/si_state.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium

[Mesa-dev] [PATCH 2/2] radeonsi: Make sampler number format logic match that for render targets.

2013-02-05 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com 18 more little piglits. Signed-off-by: Michel Dänzer michel.daen...@amd.com --- src/gallium/drivers/radeonsi/si_state.c | 27 ++- 1 file changed, 18 insertions(+), 9 deletions(-) diff --git a/src/gallium/drivers/radeonsi

[Mesa-dev] [PATCH] R600/SI: Handle VGPR64 destination in copyPhysReg().

2013-02-05 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com Allows nexuiz to run with radeonsi. Signed-off-by: Michel Dänzer michel.daen...@amd.com --- lib/Target/R600/SIInstrInfo.cpp | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/lib/Target/R600/SIInstrInfo.cpp b/lib/Target

[Mesa-dev] [PATCH] radeonsi: Use unique names for referring to texture sampling intrinsics.

2013-02-06 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com Append the overloaded vector type used for passing in the addressing parameters. Without this, LLVM uses the same function signature for all those types, which cannot work. Fixes problems e.g. with FlightGear and Red Eclipse. Signed-off-by: Michel

[Mesa-dev] [PATCH] radeonsi: Handle scaled and integer formats for samplers and vertex elements.

2013-02-06 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com Also, add assertions to stress that render targets don't support scaled formats. 20 more little piglits. Signed-off-by: Michel Dänzer michel.daen...@amd.com --- Updated, more extensive patch for 2 extra little piglits. src/gallium/drivers/radeonsi

[Mesa-dev] [PATCH] R600/SI: Use V_ADD_F32 instead of V_MOV_B32 for clamp/neg/abs modifiers.

2013-02-07 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com The modifiers don't seem to have any effect with V_MOV_B32, supposedly it's meant to just move bits untouched. Fixes 46 piglit tests with radeonsi, though unfortunately 11 of those had just regressed because they started using the clamp modifier

Re: [Mesa-dev] [PATCH v2] configure.ac: Disable GLX if OpenGL is not enabled

2013-02-08 Thread Michel Dänzer
On Don, 2013-02-07 at 21:34 -0800, Ian Romanick wrote: On 01/31/2013 08:50 AM, Michel Dänzer wrote: From: Michel Dänzer michel.daen...@amd.com GLX uses mapi/glapi/libglapi.la, which is only built for OpenGL. NOTE: This is a candidate for the stable branches. Bugzilla: https

Re: [Mesa-dev] [PATCH] configure.ac: Do not check for rt on Mac OS X.

2013-02-08 Thread Michel Dänzer
for librt because 'there is no librt'. :) -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Debian, X and DRI developer ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http

Re: [Mesa-dev] [PATCH] radeon: Remove dead STANDALONE_MMIO defines

2013-02-08 Thread Michel Dänzer
by either of these two files and the radeon driver still works on Alpha, so the definitions are dead and not needed. Reviewed-by: Michel Dänzer michel.daen...@amd.com -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Debian

Re: [Mesa-dev] [PATCH] R600: Use MULADD_IEEE instruction for mad pattern

2013-02-08 Thread Michel Dänzer
sense for (fadd (fmul))) while mine used V_MAD_F32. Same problem using V_FMA_F32 as well. Still not sure why it breaks. :( -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Debian, X and DRI developer

Re: [Mesa-dev] [PATCH 2/2] R600: Add a pattern for fma (fused multiply add)

2013-02-08 Thread Michel Dänzer
but only the final sum? Patch 1 looks nice and is Reviewed-by: Michel Dänzer michel.daen...@amd.com -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Debian, X and DRI developer

Re: [Mesa-dev] [PATCH] R600/SI: Use MULADD_IEEE/V_MAD_F32 instruction for mad pattern

2013-02-11 Thread Michel Dänzer
this for the Mesa stable branch... Tom / Christian, what's your opinion on this? -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Debian, X and DRI developer ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH] R600/SI: Use MULADD_IEEE/V_MAD_F32 instruction for mad pattern

2013-02-11 Thread Michel Dänzer
On Mon, 2013-02-11 at 16:12 +0100, Tom Stellard wrote: On Mon, Feb 11, 2013 at 03:35:44PM +0100, Michel Dänzer wrote: On Son, 2013-02-10 at 19:38 +0100, Vincent Lejeune wrote: diff --git a/lib/Target/R600/SIInstructions.td b/lib/Target/R600/SIInstructions.td index a09f243

[Mesa-dev] [PATCH] R600: Fix regression with shadow array sampler on pre-SI GPUs.

2013-02-11 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com 'R600/SI: Use proper instructions for array/shadow samplers.' removed two cases from TEX_SHADOW. Vincent Lejeune reported on IRC that this broke some shadow array piglit tests with the r600g driver. Reinstating the removed cases should fix

Re: [Mesa-dev] [PATCH] gallium: fix tgsi SAMPLE_L opcode to use separate source for explicit lod

2013-02-11 Thread Michel Dänzer
. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Debian, X and DRI developer ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/2] r600g: fix lockup when hyperz alpha test are enabled together. v2

2013-02-11 Thread Michel Dänzer
spelling would be 'intrust' or 'entrust', but I think the proper verb here is simply 'trust'. Same comments apply to r600_state.c. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Debian, X and DRI developer

[Mesa-dev] [PATCH] R600: Add lit tests for texture sampling instruction selection.

2013-02-12 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com Signed-off-by: Michel Dänzer michel.daen...@amd.com --- test/CodeGen/R600/llvm.AMDGPU.tex.ll | 42 + test/CodeGen/R600/llvm.SI.sample.ll | 71 2 files changed, 113 insertions(+) create mode

Re: [Mesa-dev] [PATCH 1/2] R600/SI: Turn BUILD_VECTOR into Reg_Sequence

2013-02-12 Thread Michel Dänzer
On Die, 2013-02-12 at 15:26 +0100, Tom Stellard wrote: On Tue, Feb 12, 2013 at 10:24:24AM +0100, Michel Dänzer wrote: On Mon, 2013-02-11 at 19:39 +0100, Vincent Lejeune wrote: --- lib/Target/R600/AMDILISelDAGToDAG.cpp | 24 1 file changed, 24 insertions

[Mesa-dev] [PATCH] radeonsi: Handle TGSI_PROPERTY_FS_COLOR0_WRITES_ALL_CBUFS

2013-02-12 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com 8 more little piglits. Signed-off-by: Michel Dänzer michel.daen...@amd.com --- src/gallium/drivers/radeonsi/radeonsi_shader.c | 29 ++ 1 file changed, 29 insertions(+) diff --git a/src/gallium/drivers/radeonsi/radeonsi_shader.c

Re: [Mesa-dev] [PATCH 09/12] R600/SI: replace AllReg_* with [SV]Src_*

2013-02-12 Thread Michel Dänzer
()); Imm.F = Op.getFPImm(); } -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Debian, X and DRI developer ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http

Re: [Mesa-dev] [PATCH 10/12] R600/SI: cleanup literal handling

2013-02-12 Thread Michel Dänzer
value. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Debian, X and DRI developer ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman

Re: [Mesa-dev] [PATCH 09/12] R600/SI: replace AllReg_* with [SV]Src_*

2013-02-13 Thread Michel Dänzer
On Mit, 2013-02-13 at 10:16 +0100, Christian König wrote: Am 12.02.2013 21:49, schrieb Michel Dänzer: On Die, 2013-02-12 at 18:13 +0100, Christian König wrote: From: Christian König christian.koe...@amd.com Mark all the operands that can also have an immediate. Signed-off

[Mesa-dev] [PATCH] R600/SI: Fix INTERP_CONST.

2013-02-13 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com The important fix is that the constant interpolation value is stored in the parameter slot P0, which is encoded as 2. In addition, pass the parameter slot as an operand to V_INTERP_MOV_F32 instead of hardcoding it there, and add a special register class

[Mesa-dev] [PATCH] radeonsi: Fix up and enable flat shading.

2013-02-13 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com Requires corresponding LLVM R600 backend fix to work correctly, but even without that it doesn't hang anymore. 13 more little piglits. NOTE: This is a candidate for the 9.1 branch. Signed-off-by: Michel Dänzer michel.daen...@amd.com --- src/gallium

[Mesa-dev] [PATCH] radeonsi: Fix w component of TGSI_SEMANTIC_POSITION fragment shader inputs.

2013-02-13 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com It's the reciprocal of the register value. Fixes piglit fragcoord_w and glsl-fs-fragcoord-zw-perspective. NOTE: This is a candidate for the 9.1 branch. Signed-off-by: Michel Dänzer michel.daen...@amd.com --- src/gallium/drivers/radeonsi

[Mesa-dev] [PATCH v2] R600/SI: Fix INTERP_CONST.

2013-02-13 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com The important fix is that the constant interpolation value is stored in the parameter slot P0, which is encoded as 2. In addition, pass the parameter slot as an operand to V_INTERP_MOV_F32 instead of hardcoding it there, and add a special register class

Re: [Mesa-dev] [PATCH 01/12] R600/structurizer: add class to find the Nearest Common Dominator

2013-02-13 Thread Michel Dänzer
such as Vincent's MAD changes or switching to the Source scheduler from breaking stuff. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Debian, X and DRI developer ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH 01/12] R600/structurizer: add class to find the Nearest Common Dominator

2013-02-13 Thread Michel Dänzer
On Mit, 2013-02-13 at 18:17 +0100, Christian König wrote: Am 13.02.2013 18:11, schrieb Michel Dänzer: On Mit, 2013-02-13 at 11:34 -0500, Tom Stellard wrote: There's just the one cleanup on patch 10 that you mentioned, but otherwise the series looks good to me. Should we mark all

[Mesa-dev] [PATCH 3/3] R600/SI: Add pattern for fceil.

2013-02-13 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com 9 more little piglits with radeonsi. NOTE: This is a candidate for the Mesa stable branch. Signed-off-by: Michel Dänzer michel.daen...@amd.com --- lib/Target/R600/SIInstructions.td | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 1/3] R600/SI: Add pattern for sign extension of i1 to i32.

2013-02-13 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com 16 more little piglits with radeonsi. NOTE: This is a candidate for the Mesa stable branch. Signed-off-by: Michel Dänzer michel.daen...@amd.com --- lib/Target/R600/SIInstructions.td | 5 + 1 file changed, 5 insertions(+) diff --git a/lib/Target

[Mesa-dev] [PATCH 2/3] R600/SI: Add pattern for logical or of i1 values.

2013-02-13 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com 24 more little piglits with radeonsi. NOTE: This is a candidate for the Mesa stable branch. Signed-off-by: Michel Dänzer michel.daen...@amd.com --- lib/Target/R600/SIInstructions.td | 4 1 file changed, 4 insertions(+) diff --git a/lib/Target

Re: [Mesa-dev] [PATCH] R600: Add lit tests for texture sampling instruction selection.

2013-02-14 Thread Michel Dänzer
0x0080e479 Stack dump: 0. Program arguments: build-trunk/Debug+Asserts/bin/llc -march=r600 -mcpu=SI 1. Running pass 'Function Pass Manager' on module 'stdin'. 2. Running pass 'SI annotate control flow' on function '@test' -- Earthling Michel Dänzer

Re: [Mesa-dev] [PATCH 01/12] R600/structurizer: add class to find the Nearest Common Dominator

2013-02-14 Thread Michel Dänzer
On Don, 2013-02-14 at 11:32 +0100, Christian König wrote: Am 13.02.2013 18:22, schrieb Michel Dänzer: On Mit, 2013-02-13 at 18:17 +0100, Christian König wrote: Am 13.02.2013 18:11, schrieb Michel Dänzer: On Mit, 2013-02-13 at 11:34 -0500, Tom Stellard wrote: There's just the one cleanup

Re: [Mesa-dev] [PATCH 10/12] R600/SI: cleanup literal handling v2

2013-02-14 Thread Michel Dänzer
.addImm(0) // OMOD For me this resulted in encoding 0 directly (because these operands are not declared as VSrc_32), i.e. VGPR0, which is no good here. addImm(0x80) for inline constant 0 worked for me. -- Earthling Michel Dänzer | http://www.amd.com Libre

Re: [Mesa-dev] [PATCH 10/12] R600/SI: cleanup literal handling v2

2013-02-14 Thread Michel Dänzer
On Don, 2013-02-14 at 14:35 +0100, Michel Dänzer wrote: On Don, 2013-02-14 at 11:43 +0100, Christian König wrote: +// Only one literal allowed +break; The same literal could be used for several operands though. :) Basically, it seems like we're pretty close to allowing VSrc

Re: [Mesa-dev] [PATCH 10/12] R600/SI: cleanup literal handling v2

2013-02-14 Thread Michel Dänzer
On Don, 2013-02-14 at 15:14 +0100, Michel Dänzer wrote: On Don, 2013-02-14 at 14:35 +0100, Michel Dänzer wrote: On Don, 2013-02-14 at 11:43 +0100, Christian König wrote: +// Only one literal allowed +break; The same literal could be used for several operands though

Re: [Mesa-dev] [PATCH 10/12] R600/SI: cleanup literal handling v2

2013-02-14 Thread Michel Dänzer
On Don, 2013-02-14 at 16:20 +0100, Christian König wrote: Am 14.02.2013 15:14, schrieb Michel Dänzer: On Don, 2013-02-14 at 14:35 +0100, Michel Dänzer wrote: On Don, 2013-02-14 at 11:43 +0100, Christian König wrote: +// Only one literal allowed +break; The same literal could

Re: [Mesa-dev] [PATCH v2] R600/SI: Fix INTERP_CONST.

2013-02-14 Thread Michel Dänzer
On Mit, 2013-02-13 at 17:51 +0100, Christian König wrote: Am 13.02.2013 17:07, schrieb Michel Dänzer: From: Michel Dänzer michel.daen...@amd.com The important fix is that the constant interpolation value is stored in the parameter slot P0, which is encoded as 2. In addition, pass

[Mesa-dev] [PATCH v3] R600/SI: Fix int_SI_fs_interp_constant

2013-02-14 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com The important fix is that the constant interpolation value is stored in the parameter slot P0, which is encoded as 2. In addition, drop the SI_INTERP_CONST pseudo instruction, pass the parameter slot as an operand to V_INTERP_MOV_F32 instead

Re: [Mesa-dev] r600g: status of my work on the shader optimization

2013-02-15 Thread Michel Dänzer
at least some of the lessons learned from your branch to the LLVM backend as well. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Debian, X and DRI developer ___ mesa-dev mailing

[Mesa-dev] [PATCH 1/2] radeonsi: properly implement S8Z24 depth-stencil format

2013-02-15 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com Based on r600g commit 2b9659c9e627ad03160899b8be04f96307d098eb . Fixes crashes with 4 piglit tests which are now hitting these formats. NOTE: This is a candidate for the 9.1 branch. Signed-off-by: Michel Dänzer michel.daen...@amd.com --- src/gallium

[Mesa-dev] [PATCH 2/2] radeonsi: Use stencil surface level information for stencil texturing

2013-02-15 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com 7 more little dwarves^W piglits. NOTE: This is a candidate for the 9.1 branch. Signed-off-by: Michel Dänzer michel.daen...@amd.com --- src/gallium/drivers/radeonsi/r600_texture.c | 3 +-- src/gallium/drivers/radeonsi/si_state.c | 14

[Mesa-dev] [PATCH] radeonsi: Fix PIPE_FORMAT_X32_S8X24_UINT sampler hardware format

2013-02-15 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com 4 more little piglits. NOTE: This is a candidate for the 9.1 branch. Signed-off-by: Michel Dänzer michel.daen...@amd.com --- src/gallium/drivers/radeonsi/si_state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium

Re: [Mesa-dev] [PATCH] radeonsi: Fix blending using destination alpha factor but non-alpha destination

2013-02-19 Thread Michel Dänzer
On Die, 2013-02-19 at 14:04 +0100, Marek Olšák wrote: On Tue, Feb 19, 2013 at 11:02 AM, Michel Dänzer mic...@daenzer.net wrote: Really, what I don't understand is why r600g doesn't seem affected by this... at least on my RS880 it's passing the piglit tests this change fixes with radeonsi

Re: [Mesa-dev] [PATCH 4/8] R600/SI: simplify VOPC_* patterns

2013-02-19 Thread Michel Dänzer
, could you add the operands to them? let SRC2 = 0x80; Hmm, we're scattering quite a few of these magic 0x80 around, would be nice to make those more self-documenting somehow... -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast

Re: [Mesa-dev] [PATCH] radeonsi: Fix blending using destination alpha factor but non-alpha destination

2013-02-19 Thread Michel Dänzer
On Die, 2013-02-19 at 15:48 +0100, Marek Olšák wrote: On Tue, Feb 19, 2013 at 3:28 PM, Michel Dänzer mic...@daenzer.net wrote: On Die, 2013-02-19 at 14:04 +0100, Marek Olšák wrote: On Tue, Feb 19, 2013 at 11:02 AM, Michel Dänzer mic...@daenzer.net wrote: Really, what I don't understand

[Mesa-dev] [PATCH 1/3] radeonsi: use u_box_origin_2d helper function

2013-02-19 Thread Michel Dänzer
From: Marek Olšák mar...@gmail.com [ Cherry-picked from r600g commit b278aba42310e8fa30f2408b9dcd58dbb4901724 ] Signed-off-by: Michel Dänzer michel.daen...@amd.com --- src/gallium/drivers/radeonsi/r600_texture.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src

[Mesa-dev] [PATCH 0/3] radeonsi: Cherry-pick transfer fixes from r600g

2013-02-19 Thread Michel Dänzer
These together get us 11 more little piglits with Marek's glTex(Sub)Image improvements in st/mesa. [PATCH 1/3] radeonsi: use u_box_origin_2d helper function [PATCH 2/3] radeonsi: add assertions to prevent creation of invalid [PATCH 3/3] radeonsi: implement 3D transfers

[Mesa-dev] [PATCH 2/3] radeonsi: add assertions to prevent creation of invalid surfaces

2013-02-19 Thread Michel Dänzer
From: Marek Olšák mar...@gmail.com [ Cherry-picked from r600g commit ef11ed61a0414d0405c3faf7f48fa3f1d083f82e ] Signed-off-by: Michel Dänzer michel.daen...@amd.com --- src/gallium/drivers/radeonsi/r600_blit.c | 15 --- src/gallium/drivers/radeonsi/r600_texture.c | 2 ++ src

[Mesa-dev] [PATCH 3/3] radeonsi: implement 3D transfers

2013-02-19 Thread Michel Dänzer
From: Marek Olšák mar...@gmail.com That means we can map and read multiple slices with one transfer_map call. [ Cherry-picked from r600g commit 1aebb6911e9aa1bd8900868b58d1750ca83a20c7 ] Signed-off-by: Michel Dänzer michel.daen...@amd.com --- src/gallium/drivers/radeonsi/r600_texture.c | 49

Re: [Mesa-dev] [PATCH] radeonsi: Fix memory leak in si_shader_select.

2013-02-20 Thread Michel Dänzer
(type=%u) %d\n, sel-type, r); sel-current = NULL; + FREE(shader); return r; } Reviewed-by: Michel Dänzer michel.daen...@amd.com Can you fix the same problem in r600g while you're

[Mesa-dev] [PATCH] R600/SI: Make sure M0 is loaded for V_INTERP_MOV_F32

2013-02-20 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com NOTE: This is a candidate for the Mesa stable branch. Signed-off-by: Michel Dänzer michel.daen...@amd.com --- Not sure why the lack of this didn't seem to cause problems in my testing last week... lib/Target/R600/SIInstructions.td | 3

[Mesa-dev] [PATCH 2/2] r600g/Cayman: Fix blending using destination alpha factor but non-alpha dest

2013-02-20 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com Only compile tested, but should fix at least some piglit fbo-blending tests. NOTE: This is a candidate for the stable branches. Signed-off-by: Michel Dänzer michel.daen...@amd.com --- src/gallium/drivers/r600/evergreen_state.c | 13 + 1

[Mesa-dev] [PATCH v2 1/2] radeonsi: Fix blending using destination alpha factor but non-alpha destination

2013-02-20 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com 11 more little piglits. NOTE: This is a candidate for the 9.1 branch. Signed-off-by: Michel Dänzer michel.daen...@amd.com --- v2: Marek pointed out there actually is a hardware bit for this as of Cayman. :) src/gallium/drivers/radeonsi

Re: [Mesa-dev] [PATCH 01/12] R600/structurizer: add class to find the Nearest Common Dominator

2013-02-20 Thread Michel Dänzer
On Don, 2013-02-14 at 11:32 +0100, Christian König wrote: Am 13.02.2013 18:22, schrieb Michel Dänzer: On Mit, 2013-02-13 at 18:17 +0100, Christian König wrote: Am 13.02.2013 18:11, schrieb Michel Dänzer: On Mit, 2013-02-13 at 11:34 -0500, Tom Stellard wrote: There's just the one cleanup

Re: [Mesa-dev] [PATCH 11/14] R600/SI: add OMOD patterns

2013-02-21 Thread Michel Dänzer
*/) +; Is there any advantage to doing it like this as opposed to using V_MUL_F32_e32 with the corresponding inline constant source operands? I guess it could work for SGPRs as the source as well, if the patterns used VSrc instead of VReg, but otherwise MUL would result in more compact code. -- Earthling Michel

Re: [Mesa-dev] [PATCH 09/14] R600/SI: add all the other missing asm operands

2013-02-21 Thread Michel Dänzer
for the asm string changes. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Debian, X and DRI developer ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http

Re: [Mesa-dev] [PATCH 11/14] R600/SI: add OMOD patterns

2013-02-21 Thread Michel Dänzer
On Don, 2013-02-21 at 09:44 +0100, Christian König wrote: Am 21.02.2013 09:26, schrieb Michel Dänzer: On Mit, 2013-02-20 at 18:46 +0100, Christian König wrote: diff --git a/lib/Target/R600/SIInstructions.td b/lib/Target/R600/SIInstructions.td index 833e6cd..7c157e9 100644

Re: [Mesa-dev] [PATCH 01/12] R600/structurizer: add class to find the Nearest Common Dominator

2013-02-21 Thread Michel Dänzer
On Mit, 2013-02-20 at 17:56 +0100, Michel Dänzer wrote: On Don, 2013-02-14 at 11:32 +0100, Christian König wrote: Am 13.02.2013 18:22, schrieb Michel Dänzer: On Mit, 2013-02-13 at 18:17 +0100, Christian König wrote: Am 13.02.2013 18:11, schrieb Michel Dänzer: On Mit, 2013-02-13 at 11

Re: [Mesa-dev] [PATCH 09/14] R600/SI: add all the other missing asm operands

2013-02-21 Thread Michel Dänzer
On Don, 2013-02-21 at 10:38 +0100, Christian König wrote: Am 21.02.2013 09:39, schrieb Michel Dänzer: On Mit, 2013-02-20 at 18:46 +0100, Christian König wrote: diff --git a/lib/Target/R600/SIInstructions.td b/lib/Target/R600/SIInstructions.td index 700b8f8..866c7cb 100644 --- a/lib

Re: [Mesa-dev] [PATCH] vl: Fix off-by-one error in device_name_length allocation.

2013-02-22 Thread Michel Dänzer
assignment looks superfluous now. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Debian, X and DRI developer ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http

[Mesa-dev] [PATCH 3/4] R600/SI: Initial support for LDS/GDS instructions

2013-02-22 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com Signed-off-by: Michel Dänzer michel.daen...@amd.com --- lib/Target/R600/SIInstrFormats.td | 24 lib/Target/R600/SIInstrInfo.td| 22 ++ lib/Target/R600/SIInstructions.td | 4 3 files changed, 50

[Mesa-dev] [PATCH 2/4] R600/SI: Handle VGPR256 in copyPhysReg

2013-02-22 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com Signed-off-by: Michel Dänzer michel.daen...@amd.com --- lib/Target/R600/SIInstrInfo.cpp | 28 +++- 1 file changed, 27 insertions(+), 1 deletion(-) diff --git a/lib/Target/R600/SIInstrInfo.cpp b/lib/Target/R600/SIInstrInfo.cpp

[Mesa-dev] [PATCH 1/4] R600/SI: Add intrinsics for texture sampling with user derivatives

2013-02-22 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com Signed-off-by: Michel Dänzer michel.daen...@amd.com --- lib/Target/R600/SIInstructions.td | 7 ++- lib/Target/R600/SIIntrinsics.td | 1 + 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/lib/Target/R600/SIInstructions.td b/lib

[Mesa-dev] [PATCH 4/4] R600/SI: Support AMDGPU.ddx/y intrinsics

2013-02-22 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com Use LDS for calculating the deltas between neighbouring pixels. Not sure the sign of the delta is correct for both dimensions (the sign doesn't seem to matter for the relevant piglit tests), but it'll be easy to fix that up if not. Signed-off-by: Michel

[Mesa-dev] [PATCH 1/3] radeonsi: Refactor packing of texture coordinates

2013-02-22 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com The number of coordinates to pack will be useful for other address parameters as well. Signed-off-by: Michel Dänzer michel.daen...@amd.com --- src/gallium/drivers/radeonsi/radeonsi_shader.c | 54 +++--- 1 file changed, 32 insertions

[Mesa-dev] [PATCH 2/3] radeonsi: Handle TGSI_OPCODE_TXD

2013-02-22 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com Signed-off-by: Michel Dänzer michel.daen...@amd.com --- src/gallium/drivers/radeonsi/radeonsi_shader.c | 23 +-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/radeonsi_shader.c b/src

[Mesa-dev] [PATCH 3/3] radeonsi: Handle TGSI_OPCODE_DDX/Y

2013-02-22 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com 15 more little piglits. Signed-off-by: Michel Dänzer michel.daen...@amd.com --- src/gallium/drivers/radeonsi/radeonsi_shader.c | 34 ++ src/gallium/drivers/radeonsi/radeonsi_shader.h | 1 + src/gallium/drivers/radeonsi

Re: [Mesa-dev] [PATCH 4/4] R600/SI: Support AMDGPU.ddx/y intrinsics

2013-02-22 Thread Michel Dänzer
for any source operand, and it automagically uses an inline constant, a literal or a temporary register as appropriate. It sounded like Christian is getting close to that. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast

Re: [Mesa-dev] [PATCH 4/4] R600/SI: Support AMDGPU.ddx/y intrinsics

2013-02-22 Thread Michel Dänzer
On Fre, 2013-02-22 at 09:05 -0800, Paul Berry wrote: On 22 February 2013 08:02, Michel Dänzer mic...@daenzer.net wrote: From: Michel Dänzer michel.daen...@amd.com Use LDS for calculating the deltas between neighbouring pixels. Not sure the sign

Re: [Mesa-dev] [PATCH v2] vl: Fix off-by-one error in device_name_length allocation.

2013-02-23 Thread Michel Dänzer
On Sam, 2013-02-23 at 05:37 +0100, Vinson Lee wrote: Fixes out-of-bounds write reported by Coverity. Signed-off-by: Vinson Lee v...@freedesktop.org Reviewed-by: Michel Dänzer mic...@daenzer.net -- Earthling Michel Dänzer | http://www.amd.com Libre software

Re: [Mesa-dev] [PATCH] r600g/radeonsi: unreference previous fence in flush

2013-03-04 Thread Michel Dänzer
that's correct, but if it is, the change should be amended with an explanation why. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Debian, X and DRI developer ___ mesa-dev mailing

Re: [Mesa-dev] [PATCH 1/7] radeonsi: switch to v*i8 for resources and samplers

2013-03-05 Thread Michel Dänzer
-key.export_16bpc cbuf) 0x1; if (compressed) Don't sneak in unrelated changes like this. You can push trivial fixes like this without review. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Debian, X

Re: [Mesa-dev] [PATCH 7/7] radeon/llvm: enable LICM and DCE pass

2013-03-05 Thread Michel Dänzer
On Die, 2013-03-05 at 15:27 +0100, Christian König wrote: From: Christian König christian.koe...@amd.com Signed-off-by: Christian König christian.koe...@amd.com This could use a little more information, e.g.: What are LICM and DCE? Why is it a good idea to enable them? -- Earthling Michel

Re: [Mesa-dev] [PATCH] Fix build of swrast only without libdrm

2013-03-05 Thread Michel Dänzer
lib/gallium/swrast_dri.so based on llvmpipe/softpipe. Presumably both are built before and after the change(s) in question, they merely changed which one ends up installed / picked up first at runtime. -- Earthling Michel Dänzer | http://www.amd.com Libre software

Re: [Mesa-dev] [PATCH 7/7] radeon/llvm: enable LICM and DCE pass

2013-03-06 Thread Michel Dänzer
a bit more into the depth. For example imagine a loop with an unused variable incremented, the increment depends on itself, but it's completely useless... Thanks for the explanations guys, but the point is really that the change needs to be self-explanatory. :) -- Earthling Michel Dänzer

<    1   2   3   4   5   6   7   8   9   10   >