Re: [Mesa-dev] [BUG] Large slowdown with RADV / Warcraft with latest Mesa from Git.

2021-01-08 Thread Chris Rankin 
Hi, thanks for replying.

Yes, that simple patch seems to have done the trick.

Cheers,
Chris
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [BUG] Large slowdown with RADV / Warcraft with latest Mesa from Git.

2021-01-08 Thread Chris Rankin 
Hi,

I've just noticed a large drop in FPS (from 60 down to 15) when playing World 
of Warcraft with the latest Mesa from Git.
A quick git bisect has identified this commit:

4292fb2139282e6906d4ad2a8be2fd81ed7ca8af is the first bad commit
commit 4292fb2139282e6906d4ad2a8be2fd81ed7ca8af
Author: Michel Dänzer 
Date:   Mon Dec 21 15:41:56 2020 +0100

    wsi/x11: Use PresentOptionAsync for MAILBOX present mode with Xwayland
    
    This allows Xwayland to forward buffers to the Wayland compositor ASAP
    for fullscreen / undecorated windows, which in turn allows true mailbox
    behaviour in the Wayland compositor.
    
    Without this, Xwayland has to emulate the mailbox behaviour itself,
    which it cannot do as well as the Wayland compositor by design.
    
    Reviewed-by: Bas Nieuwenhuizen 
    Part-of: 

 src/vulkan/wsi/wsi_common_x11.c | 7 +++
 1 file changed, 7 insertions(+)

I am playing WoW with this release of Wine:

wine-6.0-0.4rc4.fc33.x86_64

And this version of DXVK:

wine-dxvk-1.7.2-3.fc33.x86_64

Curiously, I am using Xorg rather than Wayland, and so don't understand why 
this commit should affect me.

Glxinfo reports the following:

Extended renderer info (GLX_MESA_query_renderer):
    Vendor: AMD (0x1002)
    Device: AMD Radeon (TM) R7 300 Series (BONAIRE, DRM 3.40.0, 5.10.5, LLVM 
12.0.0) (0x665f)
    Version: 21.0.0
    Accelerated: yes
    Video memory: 2048MB
    Unified memory: no
    Preferred profile: core (0x1)
    Max core profile version: 4.6
    Max compat profile version: 4.6
    Max GLES1 profile version: 1.1
    Max GLES[23] profile version: 3.2
Memory info (GL_ATI_meminfo):
    VBO free memory - total: 1483 MB, largest block: 1483 MB
    VBO free aux. memory - total: 2691 MB, largest block: 2691 MB
    Texture free memory - total: 1483 MB, largest block: 1483 MB
    Texture free aux. memory - total: 2691 MB, largest block: 2691 MB
    Renderbuffer free memory - total: 1483 MB, largest block: 1483 MB
    Renderbuffer free aux. memory - total: 2691 MB, largest block: 2691 MB
Memory info (GL_NVX_gpu_memory_info):
    Dedicated video memory: 2048 MB
    Total available memory: 5120 MB
    Currently available dedicated video memory: 1483 MB
OpenGL vendor string: AMD
OpenGL renderer string: AMD Radeon (TM) R7 300 Series (BONAIRE, DRM 3.40.0, 
5.10.5, LLVM 12.0.0)
OpenGL core profile version string: 4.6 (Core Profile) Mesa 21.0.0-devel 
(git-4292fb2139)

Cheers,
Chris
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [BUG] Large slowdown with RADV / Warcraft with latest Mesa from Git.

2021-01-08 Thread Michel Dänzer 

On 2021-01-08 6:16 p.m., Michel Dänzer wrote:

On 2021-01-08 5:54 p.m., Chris Rankin wrote:

Hi,

I've just noticed a large drop in FPS (from 60 down to 15) when 
playing World of Warcraft with the latest Mesa from Git.

A quick git bisect has identified this commit:

4292fb2139282e6906d4ad2a8be2fd81ed7ca8af is the first bad commit
commit 4292fb2139282e6906d4ad2a8be2fd81ed7ca8af
Author: Michel Dänzer 
Date:   Mon Dec 21 15:41:56 2020 +0100

 wsi/x11: Use PresentOptionAsync for MAILBOX present mode with 
Xwayland
 This allows Xwayland to forward buffers to the Wayland compositor 
ASAP
 for fullscreen / undecorated windows, which in turn allows true 
mailbox

 behaviour in the Wayland compositor.
 Without this, Xwayland has to emulate the mailbox behaviour itself,
 which it cannot do as well as the Wayland compositor by design.
 Reviewed-by: Bas Nieuwenhuizen 
 Part-of: 



  src/vulkan/wsi/wsi_common_x11.c | 7 +++
  1 file changed, 7 insertions(+)

I am playing WoW with this release of Wine:

wine-6.0-0.4rc4.fc33.x86_64

And this version of DXVK:

wine-dxvk-1.7.2-3.fc33.x86_64

Curiously, I am using Xorg rather than Wayland, and so don't 
understand why this commit should affect me.


Does the attached patch fix it?


Actually, that would only make a difference if your X server didn't 
support the RANDR extension, which seems unlikely.



I found two more bugs: 
https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8393


Still not sure how that could have caused a drop from 60 to 15 fps, but 
hopefully this will fix it.



--
Earthling Michel Dänzer   |   https://redhat.com
Libre software enthusiast | Mesa and X developer
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [BUG] Large slowdown with RADV / Warcraft with latest Mesa from Git.

2021-01-08 Thread Michel Dänzer 

On 2021-01-08 5:54 p.m., Chris Rankin wrote:

Hi,

I've just noticed a large drop in FPS (from 60 down to 15) when playing World 
of Warcraft with the latest Mesa from Git.
A quick git bisect has identified this commit:

4292fb2139282e6906d4ad2a8be2fd81ed7ca8af is the first bad commit
commit 4292fb2139282e6906d4ad2a8be2fd81ed7ca8af
Author: Michel Dänzer 
Date:   Mon Dec 21 15:41:56 2020 +0100

     wsi/x11: Use PresentOptionAsync for MAILBOX present mode with Xwayland
 
     This allows Xwayland to forward buffers to the Wayland compositor ASAP

     for fullscreen / undecorated windows, which in turn allows true mailbox
     behaviour in the Wayland compositor.
 
     Without this, Xwayland has to emulate the mailbox behaviour itself,

     which it cannot do as well as the Wayland compositor by design.
 
     Reviewed-by: Bas Nieuwenhuizen 

     Part-of: 

  src/vulkan/wsi/wsi_common_x11.c | 7 +++
  1 file changed, 7 insertions(+)

I am playing WoW with this release of Wine:

wine-6.0-0.4rc4.fc33.x86_64

And this version of DXVK:

wine-dxvk-1.7.2-3.fc33.x86_64

Curiously, I am using Xorg rather than Wayland, and so don't understand why 
this commit should affect me.


Does the attached patch fix it?


P.S. Mesa uses GitLab issues for bug tracking now: 
https://gitlab.freedesktop.org/mesa/mesa/-/issues


--
Earthling Michel Dänzer   |   https://redhat.com
Libre software enthusiast | Mesa and X developer
diff --git a/src/vulkan/wsi/wsi_common_x11.c b/src/vulkan/wsi/wsi_common_x11.c
index dcad48ca612..f204e329338 100644
--- a/src/vulkan/wsi/wsi_common_x11.c
+++ b/src/vulkan/wsi/wsi_common_x11.c
@@ -236,9 +236,9 @@ wsi_x11_connection_create(struct wsi_device *wsi_dev,
 #endif
 
if (randr_reply && randr_reply->present != 0)
-   {
   wsi_conn->is_xwayland = wsi_x11_detect_xwayland(conn);
-   }
+   else
+  wsi_conn->is_xwayland = false;
 
wsi_conn->has_dri3_modifiers = has_dri3_v1_2 && has_present_v1_2;
wsi_conn->is_proprietary_x11 = false;
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev