Re: [Mesa-dev] [PATCH] Avoid ASan new-delete-type-mismatch

On Fri, Jun 10, 2016 at 11:34 AM, Stephan Bergmann wrote: > On 06/10/2016 05:20 PM, Ilia Mirkin wrote: >> >> It's pretty easy for me to fix up before I apply it too, but if I "git >> am" your email, it'll be attributed to the one you sent it from, >> unless that From line is

Re: [Mesa-dev] [PATCH] Avoid ASan new-delete-type-mismatch

On Fri, Jun 10, 2016 at 11:32 AM, Jan Vesely wrote: > On Fri, 2016-06-10 at 11:20 -0400, Ilia Mirkin wrote: >> On Fri, Jun 10, 2016 at 6:28 AM, Stephan Bergmann > m> wrote: >> > On 06/10/2016 12:09 PM, Eric Engestrom wrote: >> > > >> > > On Thu, Jun

Re: [Mesa-dev] [PATCH] Avoid ASan new-delete-type-mismatch

On 06/10/2016 05:20 PM, Ilia Mirkin wrote: It's pretty easy for me to fix up before I apply it too, but if I "git am" your email, it'll be attributed to the one you sent it from, unless that From line is there as line 1 of the email body. Just let me know if you want me to fix it up. Despite the

Re: [Mesa-dev] [PATCH] Avoid ASan new-delete-type-mismatch

On Fri, 2016-06-10 at 11:20 -0400, Ilia Mirkin wrote: > On Fri, Jun 10, 2016 at 6:28 AM, Stephan Bergmann m> wrote: > > On 06/10/2016 12:09 PM, Eric Engestrom wrote: > > > > > > On Thu, Jun 09, 2016 at 05:13:20PM +0200, Stephan Bergmann wrote: > > > > > > Since you didn't

Re: [Mesa-dev] [PATCH] Avoid ASan new-delete-type-mismatch

On Fri, Jun 10, 2016 at 6:28 AM, Stephan Bergmann wrote: > On 06/10/2016 12:09 PM, Eric Engestrom wrote: >> >> On Thu, Jun 09, 2016 at 05:13:20PM +0200, Stephan Bergmann wrote: >> >> Since you didn't send this patch from your primary email account, >> you might want to add

Re: [Mesa-dev] [PATCH] Avoid ASan new-delete-type-mismatch

On Fri, Jun 10, 2016 at 12:28:38PM +0200, Stephan Bergmann wrote: > On 06/10/2016 12:09 PM, Eric Engestrom wrote: > > On Thu, Jun 09, 2016 at 05:13:20PM +0200, Stephan Bergmann wrote: > > > > Since you didn't send this patch from your primary email account, > > you might want to add this line

Re: [Mesa-dev] [PATCH] Avoid ASan new-delete-type-mismatch

On 06/10/2016 12:09 PM, Eric Engestrom wrote: On Thu, Jun 09, 2016 at 05:13:20PM +0200, Stephan Bergmann wrote: Since you didn't send this patch from your primary email account, you might want to add this line here, otherwise the author will be "stephan.bergmann.second...@googlemail.com":

Re: [Mesa-dev] [PATCH] Avoid ASan new-delete-type-mismatch

On Thu, Jun 09, 2016 at 05:13:20PM +0200, Stephan Bergmann wrote: Since you didn't send this patch from your primary email account, you might want to add this line here, otherwise the author will be "stephan.bergmann.second...@googlemail.com": From: Stephan Bergmann >

[Mesa-dev] [PATCH] Avoid ASan new-delete-type-mismatch

...when Function::domTree is created as DominatorTree in Function::convertToSSA (src/gallium/drivers/nouveau/codegen/nv50_ir_ssa.cpp) but destroyed only as base Graph in ~Function (src/gallium/drivers/nouveau/codegen/nv50_ir_bb.cpp). --- src/gallium/drivers/nouveau/codegen/nv50_ir_graph.h | 2 +-

Re: [Mesa-dev] [PATCH] Avoid ASan new-delete-type-mismatch

On 06/09/2016 05:01 PM, Ilia Mirkin wrote: Is this all because Graph doesn't have a virtual destructor? We don't construct/destruct those too often, I'd much rather just make it virtual rather than moving DominatorTree. Yes, that of course also works. Corresponding patch coming.

Re: [Mesa-dev] [PATCH] Avoid ASan new-delete-type-mismatch

Is this all because Graph doesn't have a virtual destructor? We don't construct/destruct those too often, I'd much rather just make it virtual rather than moving DominatorTree. On Thu, Jun 9, 2016 at 10:52 AM, Stephan Bergmann wrote: > ...when

[Mesa-dev] [PATCH] Avoid ASan new-delete-type-mismatch

...when Function::domTree is created as DominatorTree in Function::convertToSSA (src/gallium/drivers/nouveau/codegen/nv50_ir_ssa.cpp) but destroyed only as base Graph in ~Function (src/gallium/drivers/nouveau/codegen/nv50_ir_bb.cpp). --- src/gallium/drivers/nouveau/codegen/nv50_ir.h | 37

Re: [Mesa-dev] [PATCH] Avoid ASan new-delete-type-mismatch (in src/gallium/drivers/nouveau/codegen/)

Please send the patch inline, and in such a way that I'll be able to apply it with git am. Git send-email does the right thing, FYI. On Jun 9, 2016 9:26 AM, "Stephan Bergmann" wrote: > see attached 0001-Avoid-ASan-new-delete-type-mismatch.patch > >

[Mesa-dev] [PATCH] Avoid ASan new-delete-type-mismatch (in src/gallium/drivers/nouveau/codegen/)

see attached 0001-Avoid-ASan-new-delete-type-mismatch.patch >From 653d9da624c56fab05ed568133f30640b9e75b4f Mon Sep 17 00:00:00 2001 From: Stephan Bergmann Date: Thu, 9 Jun 2016 15:21:46 +0200 Subject: [PATCH] Avoid ASan new-delete-type-mismatch ...when Function::domTree is