Re: [Mesa-dev] [PATCH] Revert "glsl: relax input->output validation for SSO programs"

2019-02-15 Thread Timothy Arceri
Reviewed-by: Timothy Arceri But I think you should add something like the following to the commit message: "This was fixed properly by commit ..." Once you push "glsl/linker: don't fail non static used inputs without matching outputs" On 9/2/19 4:06 am, Andres Gomez wrote: This reverts

[Mesa-dev] [PATCH] Revert "glsl: relax input->output validation for SSO programs"

2019-02-08 Thread Andres Gomez
This reverts commit 1aa5738e666a9534c7e5b46f077327e6d647c64f. This patch incorrectly asumed that for SSOs no inner interface matching check was needed. From the ARB_separate_shader_objects spec v.25: " With separable program objects, interfaces between shader stages may involve the